From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E55EAC4363D for ; Mon, 21 Sep 2020 17:52:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0D31216C4 for ; Mon, 21 Sep 2020 17:52:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d9FHneM2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728206AbgIURwy (ORCPT ); Mon, 21 Sep 2020 13:52:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbgIURwx (ORCPT ); Mon, 21 Sep 2020 13:52:53 -0400 Received: from mail-yb1-xb41.google.com (mail-yb1-xb41.google.com [IPv6:2607:f8b0:4864:20::b41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B84CAC061755; Mon, 21 Sep 2020 10:52:53 -0700 (PDT) Received: by mail-yb1-xb41.google.com with SMTP id 67so10916816ybt.6; Mon, 21 Sep 2020 10:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SKjNQMGb1+nm0CnnDw2aoYSyVGHtiTfWCigjGqfb/+E=; b=d9FHneM2P4UxVk88dAx28UxwPAGxarNtMwaqkCGZua9STsqKgPYHCSfzKYMFYUxmfv wTllfUf5RLgTYGEzyRgNrmP1dblvy/67akSZjOv5RDzjTxc1HLzNHpE+tGCB/8OCOj9e nuEoK8QUMPe+pVI1Id7/TMO+/O048VcoRmQAaL6tH7F9NLejjTLstXtXFjoVBLuFzUXX lhJETWlGd9SLle6CqOjQKaB+pFQ8J2kczK206ZeOYKrijJVDAefJT8ghNqLi4hliCzNA HjhkUvdS+/qqjbaSla3PUyf7ZeT4IigH6moX0lcNey1B+dJWDo9auAh5y+fz5Gx4vl15 affQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SKjNQMGb1+nm0CnnDw2aoYSyVGHtiTfWCigjGqfb/+E=; b=tAsn0IajoaRfetQUKbDEDuxZqp7NVTErTmarb52Kq9dc3pisCz3aUMpvBL0vgmSXO/ vLW6rjOjkIOPKRjqlFmPrLFqnPketWb/OTuOVUwebelmBW9wKqCNoRmc44UVnQgzteej 0eMNB6A1Xd/utijBmMs5/dA6XYkhsS9vLlcY8DrFH2PcSWAiJsEQ8Gt19k6uRVN+XXSy J6tUrWcUO56LsFw1FHkH7Fb4viiyskSIAPZSBi5A/1wey27QYwSYJk5gVtkvSvgCqRbV H4+3nHlNG52Oiy2uBCoGr8TY8Pyx43TciaqXhOlp93IcTkpxXxfkBsms55XSpFFnsgrc On7g== X-Gm-Message-State: AOAM530H8hv9Im4DWpfto++ebO3N2JNmsu2HIrMNvP1r9wmvxlmz+nIK n0XhXzWKp7f8C+w1m8MvlxADELsb/mx8VSeMGOc= X-Google-Smtp-Source: ABdhPJwG/v5AEvqbf4XjP/SdkJJVKa8hUfCwk70rh1VomyNc7J66rcB333cB+SBTkM5sT7fkWrWYwpitua9D9LujH6Q= X-Received: by 2002:a25:9d06:: with SMTP id i6mr1458382ybp.510.1600710772768; Mon, 21 Sep 2020 10:52:52 -0700 (PDT) MIME-Version: 1.0 References: <20200916223512.2885524-1-haoluo@google.com> <20200916223512.2885524-3-haoluo@google.com> In-Reply-To: <20200916223512.2885524-3-haoluo@google.com> From: Andrii Nakryiko Date: Mon, 21 Sep 2020 10:52:41 -0700 Message-ID: Subject: Re: [PATCH bpf-next v3 2/6] bpf/libbpf: BTF support for typed ksyms To: Hao Luo Cc: Networking , bpf , open list , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Quentin Monnet , Steven Rostedt , Ingo Molnar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2020 at 3:38 PM Hao Luo wrote: > > If a ksym is defined with a type, libbpf will try to find the ksym's btf > information from kernel btf. If a valid btf entry for the ksym is found, > libbpf can pass in the found btf id to the verifier, which validates the > ksym's type and value. > > Typeless ksyms (i.e. those defined as 'void') will not have such btf_id, > but it has the symbol's address (read from kallsyms) and its value is > treated as a raw pointer. > > Signed-off-by: Hao Luo > --- This looks nice and clean, thanks! Acked-by: Andrii Nakryiko > tools/lib/bpf/libbpf.c | 112 ++++++++++++++++++++++++++++++++++++----- > 1 file changed, 99 insertions(+), 13 deletions(-) > [...]