All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>, Yonghong Song <yhs@fb.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH bpf-next v1 0/2] Ensure type tags are always ordered first in BTF
Date: Tue, 12 Apr 2022 20:23:44 -0700	[thread overview]
Message-ID: <CAEf4BzbUnyZcNU8SuQMTFSbsye05hgcTOq7CFZGvhF3PqA_GAA@mail.gmail.com> (raw)
In-Reply-To: <20220406004121.282699-1-memxor@gmail.com>

On Tue, Apr 5, 2022 at 5:41 PM Kumar Kartikeya Dwivedi <memxor@gmail.com> wrote:
>
> When iterating over modifiers, ensure that type tags can only occur at head of
> the chain, and don't occur later, such that checking for them once in the start
> tells us there are no more type tags in later modifiers. Clang already ensures
> to emit such BTF, but user can craft their own BTF which violates such
> assumptions if relied upon in the kernel.
>
> Kumar Kartikeya Dwivedi (2):
>   bpf: Ensure type tags precede modifiers in BTF
>   selftests/bpf: Add tests for type tag order validation
>
>  kernel/bpf/btf.c                             | 51 +++++++++++++
>  tools/testing/selftests/bpf/prog_tests/btf.c | 77 ++++++++++++++++++++
>  2 files changed, 128 insertions(+)
>
> --
> 2.35.1
>

Yonghong, can you please take a look?

      parent reply	other threads:[~2022-04-13  3:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06  0:41 [PATCH bpf-next v1 0/2] Ensure type tags are always ordered first in BTF Kumar Kartikeya Dwivedi
2022-04-06  0:41 ` [PATCH bpf-next v1 1/2] bpf: Ensure type tags precede modifiers " Kumar Kartikeya Dwivedi
2022-04-18 19:53   ` Yonghong Song
2022-04-18 20:31     ` Kumar Kartikeya Dwivedi
2022-04-18 22:22       ` Yonghong Song
2022-04-06  0:41 ` [PATCH bpf-next v1 2/2] selftests/bpf: Add tests for type tag order validation Kumar Kartikeya Dwivedi
2022-04-13  3:23 ` Andrii Nakryiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEf4BzbUnyZcNU8SuQMTFSbsye05hgcTOq7CFZGvhF3PqA_GAA@mail.gmail.com \
    --to=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=memxor@gmail.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.