From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B24DFC43603 for ; Tue, 10 Dec 2019 17:05:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8004C2077B for ; Tue, 10 Dec 2019 17:05:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WWXv43wI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727685AbfLJRFL (ORCPT ); Tue, 10 Dec 2019 12:05:11 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:38815 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727505AbfLJRFL (ORCPT ); Tue, 10 Dec 2019 12:05:11 -0500 Received: by mail-qt1-f193.google.com with SMTP id z15so3422131qts.5; Tue, 10 Dec 2019 09:05:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hq2orN4bzDs9BZngQDWA2aITI2xBOitIAgMk0BXVEwA=; b=WWXv43wIlp0HKLM3kWoMGnq9uaaEz9bhi+hGeEMPp3r2LKNQIzkMrNSibXD7krKKI+ 8rHdKjand3Ybvs06G269oQ9hvTGI0s7wge5KYo1rnKCnL2K8ZSQLODuBRjfEaOySKbkw P2XBgfUMaZp0A3828TLPirQbQUq9ymSa6KD/+2TvsZPF/h6GQPnQ1rzfJOovu6dT7yLV qpUxxJfsAHxC4h++amw5BIIClWAiixNa7pXpJh7GKA/DUDlK7o5TedCjvFo6CaocCRx2 xXwbGKmoKvG7meIT+5699bmYGXF8lmNlsT4GQ6N/PRjBOKdGdcfaGRza7uSwJ9cm/7Gx MAZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hq2orN4bzDs9BZngQDWA2aITI2xBOitIAgMk0BXVEwA=; b=uQapl5Pcvo5AwZerF1gidkkh378MCwXOT9RAaVB9PSfF5VQaBLHPIKaldch80QIK6s XXN8x82B/9CgeXlXyp20MkV96WWeP0zbB6gdK01ngFk8y3p3B+cYZU24NrkuzAUZNLAs OnkeocUhmHLiPyGpK9SjkoEwx2r/6dTfSAFByGEubmlUbS6m607SLXOH093d0YED8hMv uSr5rf+5bC+vzZDmoMUlAxRhBXojlz/qjjbvsFSS5IH9UudvVYQ0uwWCdY6C2jiLOohe yhl2FEXcAfCGHUabY/q5kkiM3so/pjinejTTCAsOv6WVGnGpBZ0hhyzZJy3G2H9M5no9 UszA== X-Gm-Message-State: APjAAAXFik/J+W7sRywfsrh9FN3TBbNxtP2KnmT3k2gy+xyjV1Hv3NWC K/VNuzPQlUWgE6XpCKdu+hYOVbiv0SK7EWFCo7o= X-Google-Smtp-Source: APXvYqzSQflsEC0jC2jtW8BiBz9tYg4DZXsAOLjBW3t240EedldhaWO9bSdWgP2FXUgvyVENBRY01HqWEsutx435+y4= X-Received: by 2002:ac8:5457:: with SMTP id d23mr29370437qtq.93.1575997509922; Tue, 10 Dec 2019 09:05:09 -0800 (PST) MIME-Version: 1.0 References: <20191210011438.4182911-1-andriin@fb.com> <20191210011438.4182911-4-andriin@fb.com> <20191209173353.64aeef0a@cakuba.netronome.com> In-Reply-To: <20191209173353.64aeef0a@cakuba.netronome.com> From: Andrii Nakryiko Date: Tue, 10 Dec 2019 09:04:58 -0800 Message-ID: Subject: Re: [PATCH bpf-next 03/15] libbpf: move non-public APIs from libbpf.h to libbpf_internal.h To: Jakub Kicinski Cc: Andrii Nakryiko , bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Dec 9, 2019 at 5:33 PM Jakub Kicinski wrote: > > On Mon, 9 Dec 2019 17:14:26 -0800, Andrii Nakryiko wrote: > > Few libbpf APIs are not public but currently exposed through libbpf.h to be > > used by bpftool. Move them to libbpf_internal.h, where intent of being > > non-stable and non-public is much more obvious. > > > > Signed-off-by: Andrii Nakryiko > > --- > > tools/bpf/bpftool/net.c | 1 + > > tools/lib/bpf/libbpf.h | 17 ----------------- > > tools/lib/bpf/libbpf_internal.h | 17 +++++++++++++++++ > > 3 files changed, 18 insertions(+), 17 deletions(-) > > > > diff --git a/tools/bpf/bpftool/net.c b/tools/bpf/bpftool/net.c > > index 4f52d3151616..d93bee298e54 100644 > > --- a/tools/bpf/bpftool/net.c > > +++ b/tools/bpf/bpftool/net.c > > @@ -18,6 +18,7 @@ > > > > #include > > #include > > +#include "libbpf_internal.h" > > #include "main.h" > > #include "netlink_dumper.h" > > I thought this idea was unpopular when proposed? There was a recent discussion about the need for unstable APIs to be exposed to bpftool and we concluded that libbpf_internal.h is the most appropriate place to do this.