From: Andrii Nakryiko <andrii.nakryiko@gmail.com> To: Xu Kuohai <xukuohai@huawei.com> Cc: bpf <bpf@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, open list <linux-kernel@vger.kernel.org>, Networking <netdev@vger.kernel.org>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@vger.kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>, Daniel Borkmann <daniel@iogearbox.net>, Alexei Starovoitov <ast@kernel.org>, Zi Shen Lim <zlim.lnx@gmail.com>, Andrii Nakryiko <andrii@kernel.org>, Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>, John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@kernel.org>, "David S . Miller" <davem@davemloft.net>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>, David Ahern <dsahern@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>, X86 ML <x86@kernel.org>, hpa@zytor.com, Shuah Khan <shuah@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Ard Biesheuvel <ardb@kernel.org>, Pasha Tatashin <pasha.tatashin@soleen.com>, Peter Collingbourne <pcc@google.com>, Daniel Kiss <daniel.kiss@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, Steven Price <steven.price@arm.com>, Marc Zyngier <maz@kernel.org>, Mark Brown <broonie@kernel.org>, Kumar Kartikeya Dwivedi <memxor@gmail.com>, Delyan Kratunov <delyank@fb.com> Subject: Re: [PATCH bpf-next v2 5/6] bpf, arm64: bpf trampoline for arm64 Date: Fri, 15 Apr 2022 10:12:31 -0700 [thread overview] Message-ID: <CAEf4Bzb_R56wAuD-Wgg7B5brT-dcsa+5sYynY+_CFzRwg+N5AA@mail.gmail.com> (raw) In-Reply-To: <20220414162220.1985095-6-xukuohai@huawei.com> On Thu, Apr 14, 2022 at 9:10 AM Xu Kuohai <xukuohai@huawei.com> wrote: > > Add bpf trampoline support for arm64. Most of the logic is the same as > x86. > > fentry before bpf trampoline hooked: > mov x9, x30 > nop > > fentry after bpf trampoline hooked: > mov x9, x30 > bl <bpf_trampoline> > > Tested on qemu, result: > #55 fentry_fexit:OK > #56 fentry_test:OK > #58 fexit_sleep:OK > #59 fexit_stress:OK > #60 fexit_test:OK > #67 get_func_args_test:OK > #68 get_func_ip_test:OK > #101 modify_return:OK > > Signed-off-by: Xu Kuohai <xukuohai@huawei.com> > Acked-by: Song Liu <songliubraving@fb.com> > --- Can you please also take a look at [0], which is an ongoing work to add support for BPF cookie to BPF trampoline-based BPF programs. It's very close to being done, so it would be good if you can implement that at the same time. [0] https://patchwork.kernel.org/project/netdevbpf/patch/20220412165555.4146407-4-kuifeng@fb.com/ > arch/arm64/net/bpf_jit.h | 14 +- > arch/arm64/net/bpf_jit_comp.c | 338 +++++++++++++++++++++++++++++++++- > 2 files changed, 348 insertions(+), 4 deletions(-) > [...]
WARNING: multiple messages have this Message-ID (diff)
From: Andrii Nakryiko <andrii.nakryiko@gmail.com> To: Xu Kuohai <xukuohai@huawei.com> Cc: bpf <bpf@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, open list <linux-kernel@vger.kernel.org>, Networking <netdev@vger.kernel.org>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@vger.kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>, Daniel Borkmann <daniel@iogearbox.net>, Alexei Starovoitov <ast@kernel.org>, Zi Shen Lim <zlim.lnx@gmail.com>, Andrii Nakryiko <andrii@kernel.org>, Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>, John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@kernel.org>, "David S . Miller" <davem@davemloft.net>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>, David Ahern <dsahern@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>, X86 ML <x86@kernel.org>, hpa@zytor.com, Shuah Khan <shuah@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Ard Biesheuvel <ardb@kernel.org>, Pasha Tatashin <pasha.tatashin@soleen.com>, Peter Collingbourne <pcc@google.com>, Daniel Kiss <daniel.kiss@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, Steven Price <steven.price@arm.com>, Marc Zyngier <maz@kernel.org>, Mark Brown <broonie@kernel.org>, Kumar Kartikeya Dwivedi <memxor@gmail.com>, Delyan Kratunov <delyank@fb.com> Subject: Re: [PATCH bpf-next v2 5/6] bpf, arm64: bpf trampoline for arm64 Date: Fri, 15 Apr 2022 10:12:31 -0700 [thread overview] Message-ID: <CAEf4Bzb_R56wAuD-Wgg7B5brT-dcsa+5sYynY+_CFzRwg+N5AA@mail.gmail.com> (raw) In-Reply-To: <20220414162220.1985095-6-xukuohai@huawei.com> On Thu, Apr 14, 2022 at 9:10 AM Xu Kuohai <xukuohai@huawei.com> wrote: > > Add bpf trampoline support for arm64. Most of the logic is the same as > x86. > > fentry before bpf trampoline hooked: > mov x9, x30 > nop > > fentry after bpf trampoline hooked: > mov x9, x30 > bl <bpf_trampoline> > > Tested on qemu, result: > #55 fentry_fexit:OK > #56 fentry_test:OK > #58 fexit_sleep:OK > #59 fexit_stress:OK > #60 fexit_test:OK > #67 get_func_args_test:OK > #68 get_func_ip_test:OK > #101 modify_return:OK > > Signed-off-by: Xu Kuohai <xukuohai@huawei.com> > Acked-by: Song Liu <songliubraving@fb.com> > --- Can you please also take a look at [0], which is an ongoing work to add support for BPF cookie to BPF trampoline-based BPF programs. It's very close to being done, so it would be good if you can implement that at the same time. [0] https://patchwork.kernel.org/project/netdevbpf/patch/20220412165555.4146407-4-kuifeng@fb.com/ > arch/arm64/net/bpf_jit.h | 14 +- > arch/arm64/net/bpf_jit_comp.c | 338 +++++++++++++++++++++++++++++++++- > 2 files changed, 348 insertions(+), 4 deletions(-) > [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-15 17:12 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-14 16:22 [PATCH bpf-next v2 0/6] bpf trampoline for arm64 Xu Kuohai 2022-04-14 16:22 ` Xu Kuohai 2022-04-14 16:22 ` [PATCH bpf-next v2 1/6] arm64: ftrace: Add ftrace direct call support Xu Kuohai 2022-04-14 16:22 ` Xu Kuohai 2022-04-14 16:22 ` [PATCH bpf-next v2 2/6] ftrace: Fix deadloop caused by direct call in ftrace selftest Xu Kuohai 2022-04-14 16:22 ` Xu Kuohai 2022-04-20 23:24 ` Steven Rostedt 2022-04-20 23:24 ` Steven Rostedt 2022-04-21 3:01 ` Xu Kuohai 2022-04-21 3:01 ` Xu Kuohai 2022-04-14 16:22 ` [PATCH bpf-next v2 3/6] bpf: Move is_valid_bpf_tramp_flags() to the public trampoline code Xu Kuohai 2022-04-14 16:22 ` Xu Kuohai 2022-04-14 16:22 ` [PATCH bpf-next v2 4/6] bpf, arm64: Impelment bpf_arch_text_poke() for arm64 Xu Kuohai 2022-04-14 16:22 ` Xu Kuohai 2022-04-15 2:34 ` Hou Tao 2022-04-15 2:34 ` Hou Tao 2022-04-15 3:39 ` Xu Kuohai 2022-04-15 3:39 ` Xu Kuohai 2022-04-22 10:54 ` Jakub Sitnicki 2022-04-22 10:54 ` Jakub Sitnicki 2022-04-24 5:05 ` Xu Kuohai 2022-04-24 5:05 ` Xu Kuohai 2022-04-25 14:26 ` Jakub Sitnicki 2022-04-25 14:26 ` Jakub Sitnicki 2022-04-26 4:01 ` Xu Kuohai 2022-04-26 4:01 ` Xu Kuohai 2022-04-14 16:22 ` [PATCH bpf-next v2 5/6] bpf, arm64: bpf trampoline " Xu Kuohai 2022-04-14 16:22 ` Xu Kuohai 2022-04-15 17:12 ` Andrii Nakryiko [this message] 2022-04-15 17:12 ` Andrii Nakryiko 2022-04-16 1:57 ` Xu Kuohai 2022-04-16 1:57 ` Xu Kuohai 2022-04-20 7:43 ` Xu Kuohai 2022-04-20 7:43 ` Xu Kuohai 2022-04-20 11:42 ` KP Singh 2022-04-20 11:42 ` KP Singh 2022-04-14 16:22 ` [PATCH bpf-next v2 6/6] selftests/bpf: Fix trivial typo in fentry_fexit.c Xu Kuohai 2022-04-14 16:22 ` Xu Kuohai 2022-04-15 2:37 ` [PATCH bpf-next v2 0/6] bpf trampoline for arm64 Hou Tao 2022-04-15 2:37 ` Hou Tao 2022-04-15 3:47 ` Xu Kuohai 2022-04-15 3:47 ` Xu Kuohai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAEf4Bzb_R56wAuD-Wgg7B5brT-dcsa+5sYynY+_CFzRwg+N5AA@mail.gmail.com \ --to=andrii.nakryiko@gmail.com \ --cc=andrii@kernel.org \ --cc=ardb@kernel.org \ --cc=ast@kernel.org \ --cc=bp@alien8.de \ --cc=bpf@vger.kernel.org \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=daniel.kiss@arm.com \ --cc=daniel@iogearbox.net \ --cc=dave.hansen@linux.intel.com \ --cc=davem@davemloft.net \ --cc=delyank@fb.com \ --cc=dsahern@kernel.org \ --cc=hpa@zytor.com \ --cc=john.fastabend@gmail.com \ --cc=kafai@fb.com \ --cc=kpsingh@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=memxor@gmail.com \ --cc=mingo@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=pasha.tatashin@soleen.com \ --cc=pcc@google.com \ --cc=rostedt@goodmis.org \ --cc=shuah@kernel.org \ --cc=songliubraving@fb.com \ --cc=steven.price@arm.com \ --cc=sudeep.holla@arm.com \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ --cc=x86@kernel.org \ --cc=xukuohai@huawei.com \ --cc=yhs@fb.com \ --cc=yoshfuji@linux-ipv6.org \ --cc=zlim.lnx@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.