From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C0AC433EF for ; Fri, 15 Apr 2022 17:12:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239686AbiDORPR (ORCPT ); Fri, 15 Apr 2022 13:15:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235654AbiDORPM (ORCPT ); Fri, 15 Apr 2022 13:15:12 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A4519BAC5; Fri, 15 Apr 2022 10:12:43 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id c125so1585518iof.9; Fri, 15 Apr 2022 10:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WrjUGuM6rsjd8l4kfiI/+ZvHzPP7KdnaSgcThC3AV8o=; b=kKdXm1SFgaU0iXA2vligFziQ2tI3e4EIcf2e7gI9zKaVVjoJhwqa6nil1gW6QuZQcX yTfkNxFYkQabvpe3wRuWqWHLTF6CpllydvcNWtRCILfdfOR5A63e2ts7V2n6xzxOsJpG Y4aq1E0Z23FtIuzyB8xUYBJg6qyRNu5J43LfRlXIp49m7Rq7gUl0mfxkV0kqxxxk8fly eQRSN0sUhANtHFudZbLuk4Nw/mGjSIBoVboWUuwBJUTqF8wImuscttw8qag/vC/gBaCA v8WKOJzooa3wSHSmQfhzNL7BHJXQum0JWnLtwlIVyivtFiBpBZKILiGPhpyH2fOmH/zr etug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WrjUGuM6rsjd8l4kfiI/+ZvHzPP7KdnaSgcThC3AV8o=; b=NCTZQOpJh6WRWa2wP2fsV+xVT11hFBauk334ATqklZ2TVQz8UyHUEppn1l6HRNW6Ww oD6ddO8AbFu3M8QurbD2nJNGungnK4fcVNCVwBgA9y0OuG0vs+Ql18jRehDmTyVSlxtp o1JtIPphPD/uz6F9lKZYFqsGhD1UOa+8M9+inigJ+WiITc3h7vJi7Oo6j1h5b5FwCX/h RKQDYS1ftaxOrA2qJU7JAXW0V/qKesfB0NJZgJwiHWJg8iyVt92Ya22BnNnCZWB8Xn2B KWekKMnUY+Uh1lT4Vq9yxpAey2nmO6UFnueLDDmAQgPQcdZTDreTvV+zlvzQUzmtiFhl rxbg== X-Gm-Message-State: AOAM5321lRDISJNOIL54u5BC9qF63xma6aBQv3t7KGjuALyCFehOqEhu vNqnWtTUWvOjmzV4wk0KDElmhEIie7KEWdYimI8= X-Google-Smtp-Source: ABdhPJzxTm55bqpj9D4DAFEW2P37c3B5S+N0gPMJy7zffSpWPkEiz3q0FQyy5x0p9Pr8mdpZ/LMosfy/lWxTiQuG6ZA= X-Received: by 2002:a05:6602:185a:b0:645:d914:35e9 with SMTP id d26-20020a056602185a00b00645d91435e9mr3603490ioi.154.1650042762884; Fri, 15 Apr 2022 10:12:42 -0700 (PDT) MIME-Version: 1.0 References: <20220414162220.1985095-1-xukuohai@huawei.com> <20220414162220.1985095-6-xukuohai@huawei.com> In-Reply-To: <20220414162220.1985095-6-xukuohai@huawei.com> From: Andrii Nakryiko Date: Fri, 15 Apr 2022 10:12:31 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2 5/6] bpf, arm64: bpf trampoline for arm64 To: Xu Kuohai Cc: bpf , linux-arm-kernel , open list , Networking , "open list:KERNEL SELFTEST FRAMEWORK" , Catalin Marinas , Will Deacon , Steven Rostedt , Ingo Molnar , Daniel Borkmann , Alexei Starovoitov , Zi Shen Lim , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Thomas Gleixner , Borislav Petkov , Dave Hansen , X86 ML , hpa@zytor.com, Shuah Khan , Mark Rutland , Ard Biesheuvel , Pasha Tatashin , Peter Collingbourne , Daniel Kiss , Sudeep Holla , Steven Price , Marc Zyngier , Mark Brown , Kumar Kartikeya Dwivedi , Delyan Kratunov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2022 at 9:10 AM Xu Kuohai wrote: > > Add bpf trampoline support for arm64. Most of the logic is the same as > x86. > > fentry before bpf trampoline hooked: > mov x9, x30 > nop > > fentry after bpf trampoline hooked: > mov x9, x30 > bl > > Tested on qemu, result: > #55 fentry_fexit:OK > #56 fentry_test:OK > #58 fexit_sleep:OK > #59 fexit_stress:OK > #60 fexit_test:OK > #67 get_func_args_test:OK > #68 get_func_ip_test:OK > #101 modify_return:OK > > Signed-off-by: Xu Kuohai > Acked-by: Song Liu > --- Can you please also take a look at [0], which is an ongoing work to add support for BPF cookie to BPF trampoline-based BPF programs. It's very close to being done, so it would be good if you can implement that at the same time. [0] https://patchwork.kernel.org/project/netdevbpf/patch/20220412165555.4146407-4-kuifeng@fb.com/ > arch/arm64/net/bpf_jit.h | 14 +- > arch/arm64/net/bpf_jit_comp.c | 338 +++++++++++++++++++++++++++++++++- > 2 files changed, 348 insertions(+), 4 deletions(-) > [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31DCAC433EF for ; Fri, 15 Apr 2022 17:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v4epsQ1EIRpYvQyZrzNG5gp9UQFAzrnpVk6baBQSYRI=; b=Y8XKNhWnqo/jha +5PFUZwbGTSnw1K6m0tmJxHjmytGG7Tcs0U01kcEyqzF0SBfi0Ua9ZP5dLk48asNBgeJGT/E5abX9 gPi4cGtT3FGMsX4YV8grMJuVyoeRCuvD3JWTvGvfID4XJvhzZcoR4o1mimk6vqvxK/39v66sZYS9Q 3svGV5+fVYc92XoQOnBV1e5roR/5hSZkVmJgzRzyzRc25O1i2sWP11Asxw3JWmNLLycELod6v32cL jEK+UE6rpj7QRNijqVq+mb+yZHIFg+hhwScypOGI5Iw8J6YbJqJVyWtjp5DdqtuS2HEoMLaqm7Bvc 7ooojj68mQzja+fblSxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfPV3-00AzQh-DC; Fri, 15 Apr 2022 17:12:49 +0000 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfPUz-00AzPg-Ge for linux-arm-kernel@lists.infradead.org; Fri, 15 Apr 2022 17:12:47 +0000 Received: by mail-io1-xd2e.google.com with SMTP id q22so2434488iod.2 for ; Fri, 15 Apr 2022 10:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WrjUGuM6rsjd8l4kfiI/+ZvHzPP7KdnaSgcThC3AV8o=; b=kKdXm1SFgaU0iXA2vligFziQ2tI3e4EIcf2e7gI9zKaVVjoJhwqa6nil1gW6QuZQcX yTfkNxFYkQabvpe3wRuWqWHLTF6CpllydvcNWtRCILfdfOR5A63e2ts7V2n6xzxOsJpG Y4aq1E0Z23FtIuzyB8xUYBJg6qyRNu5J43LfRlXIp49m7Rq7gUl0mfxkV0kqxxxk8fly eQRSN0sUhANtHFudZbLuk4Nw/mGjSIBoVboWUuwBJUTqF8wImuscttw8qag/vC/gBaCA v8WKOJzooa3wSHSmQfhzNL7BHJXQum0JWnLtwlIVyivtFiBpBZKILiGPhpyH2fOmH/zr etug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WrjUGuM6rsjd8l4kfiI/+ZvHzPP7KdnaSgcThC3AV8o=; b=hyj8JB4Kkqz3k2/XpzOrD5tv75IV/+4IUYc9tlf2VT46nAn3deyYA8bapZsFnWeQkB Nk0YOJHS5//N22sEx422QZZHg23Yu3NeC+1Te1UYt4r/HUj16NukW3+IvMGch7DQDzKD LT55iXnIQQP/pS0ypMnaeMYMR0Io2L3rN+Rg7FD3+RmcKvEokwV6J/LfAb/OaVykr8HF lKzjZmdDs1mMzB+33oDyHiAqq7pBBS39bv5OWVyL2HqkjmLHJUDl5CrO6FDaKeWiDPzw 104DIAfd/4vDgBZy2ta8vEaQxo+cKa4o7C0fw1zKkwVSJRcJQCLMCBghlyogRm9PR11T LQ2g== X-Gm-Message-State: AOAM531tlAko4GMu1avCZEF/vmmvLFgegG/9mp8VLknSPHYtWnAgF7XL pK/BOmukgdF7/0w9jNyFYboDBQdiPYdtfGZQlHo= X-Google-Smtp-Source: ABdhPJzxTm55bqpj9D4DAFEW2P37c3B5S+N0gPMJy7zffSpWPkEiz3q0FQyy5x0p9Pr8mdpZ/LMosfy/lWxTiQuG6ZA= X-Received: by 2002:a05:6602:185a:b0:645:d914:35e9 with SMTP id d26-20020a056602185a00b00645d91435e9mr3603490ioi.154.1650042762884; Fri, 15 Apr 2022 10:12:42 -0700 (PDT) MIME-Version: 1.0 References: <20220414162220.1985095-1-xukuohai@huawei.com> <20220414162220.1985095-6-xukuohai@huawei.com> In-Reply-To: <20220414162220.1985095-6-xukuohai@huawei.com> From: Andrii Nakryiko Date: Fri, 15 Apr 2022 10:12:31 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2 5/6] bpf, arm64: bpf trampoline for arm64 To: Xu Kuohai Cc: bpf , linux-arm-kernel , open list , Networking , "open list:KERNEL SELFTEST FRAMEWORK" , Catalin Marinas , Will Deacon , Steven Rostedt , Ingo Molnar , Daniel Borkmann , Alexei Starovoitov , Zi Shen Lim , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Thomas Gleixner , Borislav Petkov , Dave Hansen , X86 ML , hpa@zytor.com, Shuah Khan , Mark Rutland , Ard Biesheuvel , Pasha Tatashin , Peter Collingbourne , Daniel Kiss , Sudeep Holla , Steven Price , Marc Zyngier , Mark Brown , Kumar Kartikeya Dwivedi , Delyan Kratunov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220415_101245_590253_F8A0A5E0 X-CRM114-Status: GOOD ( 15.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 14, 2022 at 9:10 AM Xu Kuohai wrote: > > Add bpf trampoline support for arm64. Most of the logic is the same as > x86. > > fentry before bpf trampoline hooked: > mov x9, x30 > nop > > fentry after bpf trampoline hooked: > mov x9, x30 > bl > > Tested on qemu, result: > #55 fentry_fexit:OK > #56 fentry_test:OK > #58 fexit_sleep:OK > #59 fexit_stress:OK > #60 fexit_test:OK > #67 get_func_args_test:OK > #68 get_func_ip_test:OK > #101 modify_return:OK > > Signed-off-by: Xu Kuohai > Acked-by: Song Liu > --- Can you please also take a look at [0], which is an ongoing work to add support for BPF cookie to BPF trampoline-based BPF programs. It's very close to being done, so it would be good if you can implement that at the same time. [0] https://patchwork.kernel.org/project/netdevbpf/patch/20220412165555.4146407-4-kuifeng@fb.com/ > arch/arm64/net/bpf_jit.h | 14 +- > arch/arm64/net/bpf_jit_comp.c | 338 +++++++++++++++++++++++++++++++++- > 2 files changed, 348 insertions(+), 4 deletions(-) > [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel