From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F106AC43603 for ; Fri, 20 Dec 2019 17:44:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C25F5206CB for ; Fri, 20 Dec 2019 17:44:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="trk+heeZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727390AbfLTRoz (ORCPT ); Fri, 20 Dec 2019 12:44:55 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:38219 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727388AbfLTRoz (ORCPT ); Fri, 20 Dec 2019 12:44:55 -0500 Received: by mail-qt1-f193.google.com with SMTP id n15so8885348qtp.5; Fri, 20 Dec 2019 09:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PXioLGJ/HOo+TcdumPwT8VxWceb6rylqhibjXYXAy8M=; b=trk+heeZMkwa9yGualln6us4653B6hoINKyYjXJSwzqQyWIY5apdUdREy6BJw436fP PQ1TWaTBtZft+w3k/akSpHms8QJKk/ngcagXRVTe86INsYqU6AhUN7RyfBr8DUzzlqHd FazLYF0vAeYcnKPcZq1iOa0lke/6knPTwE51WpM8Zb7swn9vq4COOZfsCL43vB/jOBx8 Y+1Ulks9x4PGKTqMVeOGAoUO3Hhx7EvM7+BtbLgFxcVgCxZOUZMNDK0E62FiivmBSpUj QbNlVBjYBaYng1I+orZhlneTjcH25x02AuVqOEXrPjAfZx/ZRYfxbotDY1VjBbK5fwAW CbZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PXioLGJ/HOo+TcdumPwT8VxWceb6rylqhibjXYXAy8M=; b=Kldrxn2oGIO4fkPB00RhIGhujz89075u9/3kIwwE6TtRy7Z9rpVsu/nHzPbRZA/zc0 PHmaT/Dm5+a2TXUDT+jdLB6U2+xdmHeefgm6adPmSTPaRh7wv42TtJxKzLVMuIYjhAGl OxddhfTREzhtifdPPiHHQdExH6IWTzYNxw637mQKNczdW8E7fEUy2zL8jp6Xf+FT5Bzq Dobeto8FCtNpvIO2zJo3IsGMXAfFBHm6pr/6jyT2WIf7vofPcbg8nbtGtVv1iJNdWGOl natYEONTcFwJQWfdSp/m7NQYtmM+jBuCeWiCBakX1Jh5kL7GZLFJ+NHUhAu7Ztl0T7pI JoqQ== X-Gm-Message-State: APjAAAUFOwtaihngJYES1siFcRplOiHjRyqZAsUg6qM7mBw57JC3T+N7 poJ3Z8XAHvWNkX5UoUikmi7+sEdYz0CzN/ZwSQk= X-Google-Smtp-Source: APXvYqzKL3BW/Ztf/c+tlhipMeX2437hmDhFBidGE96aV6lDpkX6C0sIPitlxPKJLpZZG3R6bpQLclsuhx9Njx0LlbA= X-Received: by 2002:ac8:7b29:: with SMTP id l9mr12337997qtu.141.1576863894000; Fri, 20 Dec 2019 09:44:54 -0800 (PST) MIME-Version: 1.0 References: <157685877642.26195.2798780195186786841.stgit@firesoul> In-Reply-To: <157685877642.26195.2798780195186786841.stgit@firesoul> From: Andrii Nakryiko Date: Fri, 20 Dec 2019 09:44:42 -0800 Message-ID: Subject: Re: [PATCH bpf] samples/bpf: xdp_redirect_cpu fix missing tracepoint attach To: Jesper Dangaard Brouer Cc: bpf , Networking , =?UTF-8?Q?Maciek_Fija=C5=82kowski?= , Daniel Borkmann , Alexei Starovoitov , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Dec 20, 2019 at 8:19 AM Jesper Dangaard Brouer wrote: > > When sample xdp_redirect_cpu was converted to use libbpf, the > tracepoints used by this sample were not getting attached automatically > like with bpf_load.c. The BPF-maps was still getting loaded, thus > nobody notice that the tracepoints were not updating these maps. > > This fix doesn't use the new skeleton code, as this bug was introduced > in v5.1 and stable might want to backport this. E.g. Red Hat QA uses > this sample as part of their testing. > > Fixes: bbaf6029c49c ("samples/bpf: Convert XDP samples to libbpf usage") > Signed-off-by: Jesper Dangaard Brouer > --- Acked-by: Andrii Nakryiko > samples/bpf/xdp_redirect_cpu_user.c | 59 +++++++++++++++++++++++++++++++++-- > 1 file changed, 55 insertions(+), 4 deletions(-) > [...]