From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29DDDC4363C for ; Mon, 21 Sep 2020 17:57:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CED5120BED for ; Mon, 21 Sep 2020 17:57:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TfKGQgC7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728154AbgIUR5N (ORCPT ); Mon, 21 Sep 2020 13:57:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbgIUR5M (ORCPT ); Mon, 21 Sep 2020 13:57:12 -0400 Received: from mail-yb1-xb41.google.com (mail-yb1-xb41.google.com [IPv6:2607:f8b0:4864:20::b41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65BCEC061755; Mon, 21 Sep 2020 10:57:12 -0700 (PDT) Received: by mail-yb1-xb41.google.com with SMTP id k18so2157733ybh.1; Mon, 21 Sep 2020 10:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sfv2GkP+8uG546pQRvIkIIzlFhcpsb5WNAyb9sZP3VM=; b=TfKGQgC76iG5Fwj3HGDdztONc6XcwsCPCJIqzNCmwwrgeqnRr4MMq2tOk+TjEgLP6z HuBRL0uucAX+ELBQJCZ+wh4SXLTiEgHPxEdlu3o92QHW36o+E3gqsvWxMXsePu59FAuG 11ahLkFDhWtU6PQL+6mu0isOO1yT5YBLVQJsJqEM3HEmPS4Uyhpv+LKsvbXRZFHDfKgv 4e3FCUd7Zm2J0rHGveRP5MxQ1iiny8tEfkS0CRLAdCQN/vO0kghVY14rbjIqHN1CpAxM Z6/BwST7aZk5gAIjt6vi9h/i7ZnOlNbOG0OH//KFI4wJQ170nogmmWA4hNX7PSaQVwHr uvgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sfv2GkP+8uG546pQRvIkIIzlFhcpsb5WNAyb9sZP3VM=; b=aPOS58EmRGzijxvygrv9bQ2IKw6JwbI0zrmK0mspAQY9ixfWfv1SFve1P1Nyfc7exr fJsCk0qhfSDVohog+qqhSX9oCnJeb3E+GO8n1zXqxZ4j0q623QhpuZu2iYw70w3PJkSX a4WS9fbf+1iY6/VboblBnJYyRXFATDo4+gwgxRhYqDLKqylb+ejFg57slmrJXmwQCUvK qQqtJqecIgT37xHYMXONyfAi71pDb8kdbvCDCT7GaHnhEuDPrDlcoUCdltIq7UfDoQwh d62m4E94GQWXKxMAc/DgOMw88SxtFtrZxTguvnDDUgN3iMAjiRSIImk1DsjVmO7HBMe6 1Wxg== X-Gm-Message-State: AOAM532VvF2xvKk6JFBcYgPgUcAydW/qLIfXHe5iaraOVjSgtEvYeniC ZEJ5IIhID0S/yKlwSrJflHZzO9FvXap7jSHmImw= X-Google-Smtp-Source: ABdhPJxS8Q5mIofEfi8HpR2Q+otGNIK3oXK54P/XbCPZoNXSGRzYAgIg5Wb/gxzVpr1D+UCWqCCWEOeF3SveoltgHMU= X-Received: by 2002:a25:9d06:: with SMTP id i6mr1482122ybp.510.1600711031713; Mon, 21 Sep 2020 10:57:11 -0700 (PDT) MIME-Version: 1.0 References: <20200916223512.2885524-1-haoluo@google.com> <20200916223512.2885524-4-haoluo@google.com> In-Reply-To: <20200916223512.2885524-4-haoluo@google.com> From: Andrii Nakryiko Date: Mon, 21 Sep 2020 10:57:00 -0700 Message-ID: Subject: Re: [PATCH bpf-next v3 3/6] selftests/bpf: ksyms_btf to test typed ksyms To: Hao Luo Cc: Networking , bpf , open list , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Quentin Monnet , Steven Rostedt , Ingo Molnar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2020 at 3:39 PM Hao Luo wrote: > > Selftests for typed ksyms. Tests two types of ksyms: one is a struct, > the other is a plain int. This tests two paths in the kernel. Struct > ksyms will be converted into PTR_TO_BTF_ID by the verifier while int > typed ksyms will be converted into PTR_TO_MEM. > > Signed-off-by: Hao Luo > --- LGTM. Acked-by: Andrii Nakryiko > .../testing/selftests/bpf/prog_tests/ksyms.c | 38 ++++------ > .../selftests/bpf/prog_tests/ksyms_btf.c | 70 +++++++++++++++++++ > .../selftests/bpf/progs/test_ksyms_btf.c | 23 ++++++ > tools/testing/selftests/bpf/trace_helpers.c | 27 +++++++ > tools/testing/selftests/bpf/trace_helpers.h | 4 ++ > 5 files changed, 137 insertions(+), 25 deletions(-) > create mode 100644 tools/testing/selftests/bpf/prog_tests/ksyms_btf.c > create mode 100644 tools/testing/selftests/bpf/progs/test_ksyms_btf.c > [...]