From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_MED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50DADC28CC6 for ; Mon, 3 Jun 2019 13:07:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 271BD28004 for ; Mon, 3 Jun 2019 13:07:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DW+1tj6N" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728010AbfFCNHh (ORCPT ); Mon, 3 Jun 2019 09:07:37 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:46104 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727387AbfFCNHh (ORCPT ); Mon, 3 Jun 2019 09:07:37 -0400 Received: by mail-qk1-f193.google.com with SMTP id a132so290003qkb.13 for ; Mon, 03 Jun 2019 06:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BSEdgqESlMSsojoD0L6U8hdhvYh8fKdpdX1m+uG6RFw=; b=DW+1tj6N1A9FAqtzap+AF6eatkOZTRTXTNwk0XFkECvmtI5lf6m5JH8zaLMoOV49Fe pfGivCOkFydNDnB4SiT8LQZ6a3GosrtEz6VufOBIGuvqSpKaUeuhErLpMIaew66tE23s 1zMqpaUd/0fdVLdsdsKSrbXhbMa00wFK6fjAFYNiGY8mxd6HhoU3XUITgtfdfbPCfYMp 4DNHJ1fEpUUQuVtENTeM5BuuXW2b+lCFQVKnZv4S/NJAaanDHpcsNRnd74Gjj8gtfhmz M4ncQGkj3SKmOcIvTfsXgD+lHz31scAjqrqxeoXoZhEw3V+t560vYe+odOzIPIEkw5UX WICw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BSEdgqESlMSsojoD0L6U8hdhvYh8fKdpdX1m+uG6RFw=; b=h/s+6ogJz2f9NQn5J9VvM7DV4ovv8CSecfQkshVtuAJ9AGEPN1aQq/2EQoPPrESYBp Jxhtp8WDqn0vAaRx7tOsn7149PGkuBi8svV2GOq4YEHbkHshOV+QB0eb0Ns04OctYrbE Yjg2Vb0UWWXf7VwMWPZ+GNSCa1r8JWwtCaoGmBwkD7TfEubFGJ0RsEWEIeUV0REoQKc7 kvzEhDRiZyKffBwzdVqYfcPnNXcBiQPlfw0JE9lD12ioSGlGM5UoH6XFs3y6B6mPRRih puyKeJiWt3H5EgBKlNEZxnlAZzYmtPEoMDoTdIC3oHEQCqnFbU68M2mC1oXnKpKSGIOn vsNw== X-Gm-Message-State: APjAAAVem1ykbjOa3nqv3GixA3oAbmP6BDcc6qV8uUYlUmw2E0nuZFBG C+mZBYTujjmK6Dd++McRjt8c6uhggkeT5GM+bJ+8SQ== X-Google-Smtp-Source: APXvYqyq3rUxBaOA0YTWzvW4UmUadCCZQDT1jRpuqGG7BQNosITRSlrgEDi9k3H2zgxs+fEv02BXOLT0hjqss3UsmnU= X-Received: by 2002:a37:a9c9:: with SMTP id s192mr21560737qke.335.1559567256651; Mon, 03 Jun 2019 06:07:36 -0700 (PDT) MIME-Version: 1.0 References: <20190531222910.2499861-1-kafai@fb.com> <20190531222911.2500496-1-kafai@fb.com> In-Reply-To: <20190531222911.2500496-1-kafai@fb.com> From: Craig Gallek Date: Mon, 3 Jun 2019 09:07:33 -0400 Message-ID: Subject: Re: [PATCH bpf 1/2] bpf: udp: ipv6: Avoid running reuseport's bpf_prog from __udp6_lib_err To: Martin KaFai Lau Cc: bpf@vger.kernel.org, netdev , Alexei Starovoitov , Daniel Borkmann , David Miller , Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, May 31, 2019 at 6:29 PM Martin KaFai Lau wrote: > > __udp6_lib_err() may be called when handling icmpv6 message. For example, > the icmpv6 toobig(type=2). __udp6_lib_lookup() is then called > which may call reuseport_select_sock(). reuseport_select_sock() will > call into a bpf_prog (if there is one). > > reuseport_select_sock() is expecting the skb->data pointing to the > transport header (udphdr in this case). For example, run_bpf_filter() > is pulling the transport header. > > However, in the __udp6_lib_err() path, the skb->data is pointing to the > ipv6hdr instead of the udphdr. > > One option is to pull and push the ipv6hdr in __udp6_lib_err(). > Instead of doing this, this patch follows how the original > commit 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") > was done in IPv4, which has passed a NULL skb pointer to > reuseport_select_sock(). > > Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") > Cc: Craig Gallek > Signed-off-by: Martin KaFai Lau Acked-by: Craig Gallek