From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60958C636D4 for ; Tue, 31 Jan 2023 18:07:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMuyP-0007md-Rj; Tue, 31 Jan 2023 13:03:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMuxM-0007Bn-Bq for qemu-devel@nongnu.org; Tue, 31 Jan 2023 13:02:08 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMuxK-0000mB-M0 for qemu-devel@nongnu.org; Tue, 31 Jan 2023 13:02:08 -0500 Received: by mail-wr1-x430.google.com with SMTP id m7so15016626wru.8 for ; Tue, 31 Jan 2023 10:02:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yfM6G8FfZOMRFuqk0oCRUG07u5+/at2liHmrKytveWs=; b=d+P6jjk/kiArqaKOXHopQeLXjO5WYksG/qb3IIXfpdntdvuRDy2I92QlZxxl40dXBa PlIcD0MhtPIOY3cz7NjfxyXY6+rc3UM1jXd4r3pgOtmn2WDJ6mOQc+uNaEN/o7hHIp+g 2b+CK8yKh8ia2xSJ3pJUPPSZtSW67qiFwZXMRN+Co/AN2/Mlj6CnlgCEAuLtAWmd83i0 Sc6PjZlMLmIi0EbagPFEOI4xxqaT5d5tGxjDD89zyB03AluBjOUaL0MVkPRtTejUd1Ll tox93GfXd7Uujzv6z3IeHmo+Ay/FuXd21ScS8dS9bR7F8vXXQVMpGMaqJiPvSY7scCkX HsUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yfM6G8FfZOMRFuqk0oCRUG07u5+/at2liHmrKytveWs=; b=OnajcKIib7AJlZVIfM4lyza+U5CMCWF54KYyK8Jy4p6bnhhC0eBYYrmP7im1CCC4+W b4zbQiPv07gRXemTHHeXjhNpxOBj+HF4hQ842DW+1W/06s66x27sZ0Vulf3Qe8XkDlnc 8LU2nPRxphYa78+uMcWYewIxB4NM55CXayYC1aQGY4gTc+bYGorDlH7B7HDu4FbvCiPa T60uZjFTqUfQJkbycsej2dGAJhuzSMbNcIlMcWlEwv+9wo5vjBY3RvMFSlAVfyuH2qDV 9HpKEhUwyxzffBg5USKgidmx554a7pYaRJHvPnG92nVCCkKAdQEHz58P1CE/20W8DybF 5Uog== X-Gm-Message-State: AO0yUKUd5UzDRhBuyYk2TxRBTvBH5OO7ieSNw5db4nT3IPjJyvXaseVB f/khG68QkXP1/Z1jPqHADFRkaFdNqs/iBTwKeq9wUw== X-Google-Smtp-Source: AK7set8VKt45SaRVzHdFljCY8czBkvy5T5RcvVTx8bZ0I6wUFT/zr8wklHpos5xhhC3tbyqYNaPtM9BD5W8a848cRbw= X-Received: by 2002:a5d:6f0a:0:b0:2c2:8229:be98 with SMTP id ay10-20020a5d6f0a000000b002c28229be98mr80770wrb.189.1675188124897; Tue, 31 Jan 2023 10:02:04 -0800 (PST) MIME-Version: 1.0 References: <20230124195945.181842-1-christoph.muellner@vrull.eu> <20230124195945.181842-10-christoph.muellner@vrull.eu> <3d864ae7-5430-8db9-f91c-fd24f428b04d@linaro.org> In-Reply-To: <3d864ae7-5430-8db9-f91c-fd24f428b04d@linaro.org> From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Tue, 31 Jan 2023 19:01:51 +0100 Message-ID: Subject: Re: [PATCH v3 09/14] RISC-V: Adding T-Head MemIdx extension To: Richard Henderson Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Alistair Francis , Bin Meng , Philipp Tomsich , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Palmer Dabbelt , Nelson Chu , Kito Cheng , Cooper Qu , Lifang Xia , Yunhai Shang , Zhiwei Liu Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=christoph.muellner@vrull.eu; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jan 24, 2023 at 10:21 PM Richard Henderson wrote: > > On 1/24/23 09:59, Christoph Muellner wrote: > > +/* XTheadMemIdx */ > > + > > +/* > > + * Load with memop from indexed address and add (imm5 << imm2) to rs1. > > + * If !preinc, then the load address is rs1. > > + * If preinc, then the load address is rs1 + (imm5) << imm2). > > + */ > > +static bool gen_load_inc(DisasContext *ctx, arg_th_meminc *a, MemOp memop, > > + bool preinc) > > +{ > > + TCGv rd = dest_gpr(ctx, a->rd); > > + TCGv addr = get_address(ctx, a->rs1, preinc ? a->imm5 << a->imm2 : 0); > > + > > + tcg_gen_qemu_ld_tl(rd, addr, ctx->mem_idx, memop); > > + addr = get_address(ctx, a->rs1, !preinc ? a->imm5 << a->imm2 : 0); > > First, you're leaking the previous 'addr' temporary. Indeed! The real question is of course, why we call get_address() twice... Fixed in v4. > Second, get_address may make modifications to 'addr' which you don't want to write back. Fixed in v4. > Third, you are not checking for rd != rs1. Fixed in v4. > > I think what you want is > > int imm = a->imm5 << a->imm2; > TCGv addr = get_address(ctx, a->rs1, preinc ? imm : 0); > TCGv rd = dest_gpr(ctx, a->rd); > TCGv rs1 = get_gpr(ctx, a->rs1, EXT_NONE); > > tcg_gen_qemu_ld_tl(rd, addr, ctx->mem_idx, memop); > tcg_gen_addi_tl(rs1, rs1, imm); > gen_set_gpr(ctx, a->rd, rd); > gen_set_gpr(ctx, a->rs1, rs1); Yes (plus the check for rd != rs1). Fixed in v4. Thank you! > > > r~