From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63425C636CD for ; Tue, 31 Jan 2023 18:07:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMuzB-0000Jy-DB; Tue, 31 Jan 2023 13:04:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMuxP-0007CE-MU for qemu-devel@nongnu.org; Tue, 31 Jan 2023 13:02:15 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMuxN-0000nD-Hs for qemu-devel@nongnu.org; Tue, 31 Jan 2023 13:02:11 -0500 Received: by mail-wm1-x32c.google.com with SMTP id c10-20020a05600c0a4a00b003db0636ff84so11302385wmq.0 for ; Tue, 31 Jan 2023 10:02:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2szvPcKRPC9pwG7IsrFPcPmBzYbmXCTANnM8sJK8zRY=; b=nKqsKUjg15ks+VlRcUEhG+EvFy4yNQELZPO8Z7Wt0MAL/Ziiph2dU7qDgkQ0+eEZDe oSIxX0htO28Fg7xgftSs+eRJastKr+sr2gGN+P9KUMI8CaaMORbF7Ow7jm+6DyMvwLQp 3g8dUCrpkyEAurd16hsPfplw+cXE+LuNxGU/zXMtPKl6GwNQcoJtjz4GosqudTh8OHNj SBemrXfMZw+7v2uJ912suLl51JhHM6mpnIXtl8g26pNIC8Q/CAWE6JtkRlQXsUnbvdJp 8lN9D0RgWZ4YSrj4JMy4nNwNd2+2Tm6BTAXvsBrniYIMzXjKGevlWk8nKjOXBcRHiUCr 4meQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2szvPcKRPC9pwG7IsrFPcPmBzYbmXCTANnM8sJK8zRY=; b=JNf91qzfG+RTzetOauP5AUw66m9zT9G28LT8si0JAAzbWCYpuinESvFRSuYdc1FDyt 6XgIIiqHrb54J9ZO4b6Var9iTCpNMa1i8Ltt8lO++uA87CE8VH2DdtRdCKLOZOdvvvl5 /43brAd70CdLGysve4BNY8dQRrxwehseGtX5wssvYS6q5JlV3fuwxSqwmkq7ZiFfpggR NxtGji/VjI25Ib+5plGStcsbJ651ItV0zP3DA61tiivLiK5+ZzmHZrWRsGAfepbsmJTF mmY7jMrsTXn00SNIpjN2V9zcg+DrcqBBTb6178FRtoo2VOFxA/NDoa+T1FVJ4NMxAIOR hFDA== X-Gm-Message-State: AFqh2kpoRRXSdjMRN9XRUbE1aaD3CU3TlRlVSTu6aiueqVyP9Zo1X6Od NELTAAdLJyyFT/5yor6qKJ2/6bCChTRrVP5nwI9cTQ== X-Google-Smtp-Source: AMrXdXtxaWvTK5c3I40PWfsimXu0sfMRtTMCQgqC6sHoM4/qUNuR2iKTYR0ZhS4FyFqmSc3G2A4wvYd+PgFreWDd04Y= X-Received: by 2002:a1c:f217:0:b0:3d9:f704:8eac with SMTP id s23-20020a1cf217000000b003d9f7048eacmr3122537wmc.74.1675188128266; Tue, 31 Jan 2023 10:02:08 -0800 (PST) MIME-Version: 1.0 References: <20230124195945.181842-1-christoph.muellner@vrull.eu> <20230124195945.181842-13-christoph.muellner@vrull.eu> <64af1437-b910-e5b3-c462-0ef0c416ba39@linaro.org> In-Reply-To: <64af1437-b910-e5b3-c462-0ef0c416ba39@linaro.org> From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Tue, 31 Jan 2023 19:01:54 +0100 Message-ID: Subject: Re: [PATCH v3 12/14] RISC-V: Add initial support for T-Head C906 To: Richard Henderson Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Alistair Francis , Bin Meng , Philipp Tomsich , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Palmer Dabbelt , Nelson Chu , Kito Cheng , Cooper Qu , Lifang Xia , Yunhai Shang , Zhiwei Liu Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=christoph.muellner@vrull.eu; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jan 24, 2023 at 10:26 PM Richard Henderson wrote: > > On 1/24/23 09:59, Christoph Muellner wrote: > > +++ b/target/riscv/cpu.h > > @@ -27,6 +27,7 @@ > > #include "qom/object.h" > > #include "qemu/int128.h" > > #include "cpu_bits.h" > > +#include "cpu_vendorid.h" > > I don't see that this ID is required for all users of riscv/cpu.h. > This include should be limited to cpu.c. Fixed in v4. Thank you! > > > r~