From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40643)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1Z7o6K-0003ay-Rf
	for qemu-devel@nongnu.org; Wed, 24 Jun 2015 13:04:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1Z7o6G-0004MQ-GZ
	for qemu-devel@nongnu.org; Wed, 24 Jun 2015 13:04:40 -0400
Received: from mail-yk0-f170.google.com ([209.85.160.170]:33736)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1Z7o6G-0004Lr-D7
	for qemu-devel@nongnu.org; Wed, 24 Jun 2015 13:04:36 -0400
Received: by ykdt186 with SMTP id t186so27225321ykd.0
	for <qemu-devel@nongnu.org>; Wed, 24 Jun 2015 10:04:35 -0700 (PDT)
MIME-Version: 1.0
Sender: peter.crosthwaite@petalogix.com
In-Reply-To: <CAFEAcA-N1hHEwigNR6qin3ma29ywhkXm7nFyoBLcsj1KugvrMQ@mail.gmail.com>
References: <cover.1434432813.git.crosthwaite.peter@gmail.com>
	<00c96d447252bc1333e14e626611f4f5a58f9bf5.1434432813.git.crosthwaite.peter@gmail.com>
	<5588466A.1030902@suse.de>
	<CAEgOgz6DMgg6WABrAPB_273xJGaA56F44-_G2Z3Ck2zD_yi89Q@mail.gmail.com>
	<CAFEAcA-N1hHEwigNR6qin3ma29ywhkXm7nFyoBLcsj1KugvrMQ@mail.gmail.com>
Date: Wed, 24 Jun 2015 10:04:35 -0700
Message-ID: <CAEgOgz4KSdXACB9EHiXW6GRmtjMKNe=LvkGaBN94=D3Y+D3a4A@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 2/4] gdbstub: Use cpu_set_pc helper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Peter Crosthwaite <crosthwaitepeter@gmail.com>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On Wed, Jun 24, 2015 at 3:01 AM, Peter Maydell <peter.maydell@linaro.org> w=
rote:
> On 24 June 2015 at 03:50, Peter Crosthwaite
> <peter.crosthwaite@xilinx.com> wrote:
>> On Mon, Jun 22, 2015 at 10:31 AM, Andreas F=C3=A4rber <afaerber@suse.de>=
 wrote:
>>> I believe this argument will probably go away; otherwise this should've
>>> been &error_abort or something instead of NULL.
>>>
>>
>> I'm not sure. As I don't see what is catching the case of a gdb 'c'
>> packet for a CPU that doesn't implement set_pc. I'd rather preserve
>> the existing behaviour, and have the qom wrapper do nothing if it is
>> not implemented.
>
> Well, this is one reason why every CPU needs to implement set_pc...
>

Well. I guess it works for a common case where a continue doesn't
change the PC? If the debugger doesn't change the PC the "c" should
work even without a set_pc call so we don't want to assert on this
valid use case.

Regards,
Peter

> -- PMM
>