From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49455)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1WPRif-0000BU-FI
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 03:12:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1WPRiZ-0000rX-MQ
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 03:12:21 -0400
Received: from mail-wg0-f49.google.com ([74.125.82.49]:44898)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1WPRiZ-0000rT-GY
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 03:12:15 -0400
Received: by mail-wg0-f49.google.com with SMTP id a1so4245774wgh.20
	for <qemu-devel@nongnu.org>; Mon, 17 Mar 2014 00:12:14 -0700 (PDT)
MIME-Version: 1.0
Sender: peter.crosthwaite@petalogix.com
In-Reply-To: <1394134385-1727-22-git-send-email-peter.maydell@linaro.org>
References: <1394134385-1727-1-git-send-email-peter.maydell@linaro.org>
	<1394134385-1727-22-git-send-email-peter.maydell@linaro.org>
Date: Mon, 17 Mar 2014 17:12:14 +1000
Message-ID: <CAEgOgz4y57Cq5=xMZLVqzkv6TJ3f+njkKwb54wCGb+yB0EedLA@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH v4 21/21] hw/arm/virt: Add support for
	Cortex-A57
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>, Patch Tracking <patches@linaro.org>, Michael Matz <matz@suse.de>, Claudio Fontana <claudio.fontana@huawei.com>, Alexander Graf <agraf@suse.de>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Christoffer Dall <christoffer.dall@linaro.org>, Richard Henderson <rth@twiddle.net>

On Fri, Mar 7, 2014 at 5:33 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> Support the Cortex-A57 in the virt machine model.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This should perhaps not be just stealing the a15mpcore_priv
> on the basis that it's a GICv2...

Wont this mean you gets lots of extraneous hardware? Although, with a
pure virtual machine I guess you can do whatever you really want.

> ---
>  hw/arm/virt.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 517f2fe..d985d2e 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -123,6 +123,14 @@ static VirtBoardInfo machines[] = {
>          .irqmap = a15irqmap,
>      },
>      {
> +        .cpu_model = "cortex-a57",
> +        /* Use the A15 private peripheral model for now: probably wrong! */
> +        .qdevname = "a15mpcore_priv",

Can you just change this to gics qdev name? The qdev propnames of gic
and mpcore ("num-cpu" and "num-irq") should just match. Then perhaps a
little callback to set gicv2 version property.

Regards,
Peter

> +        .gic_compatible = "arm,cortex-a15-gic",
> +        .memmap = a15memmap,
> +        .irqmap = a15irqmap,
> +    },
> +    {
>          .cpu_model = "host",
>          /* We use the A15 private peripheral model to get a V2 GIC */
>          .qdevname = "a15mpcore_priv",
> --
> 1.9.0
>
>