From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44373)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1YlRR8-0000HB-EA
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 20:25:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1YlRR4-0005ve-0b
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 20:25:42 -0400
Received: from mail-qc0-f169.google.com ([209.85.216.169]:33514)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1YlRR3-0005va-P3
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 20:25:37 -0400
Received: by qcrf4 with SMTP id f4so18376224qcr.0
	for <qemu-devel@nongnu.org>; Thu, 23 Apr 2015 17:25:37 -0700 (PDT)
MIME-Version: 1.0
Sender: peter.crosthwaite@petalogix.com
In-Reply-To: <CAFEAcA_AODA-mrx8zLxb9D6LWCR2fZES-JDDhbPgSevzsrcT0A@mail.gmail.com>
References: <cover.1427108387.git.peter.crosthwaite@xilinx.com>
	<f865c90b0ca53fce8d7e2a8a1970dd2e30986966.1427108387.git.peter.crosthwaite@xilinx.com>
	<CAFEAcA_AODA-mrx8zLxb9D6LWCR2fZES-JDDhbPgSevzsrcT0A@mail.gmail.com>
Date: Thu, 23 Apr 2015 17:25:37 -0700
Message-ID: <CAEgOgz5T04d9znp7EqkD1jOdJwta7Wuspa7q_fKAXuGYMHz6OA@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH target-arm v4 10/16] char: cadence_uart:
 Clean up variable names
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Edgar Iglesias <edgar.iglesias@xilinx.com>, zach.pfeffer@xilinx.com, Ryota Ozaki <ozaki.ryota@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, Alistair Francis <alistair.francis@xilinx.com>, "michals@xilinx.com" <michals@xilinx.com>

On Thu, Apr 23, 2015 at 10:59 AM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> On 23 March 2015 at 11:05, Peter Crosthwaite
> <peter.crosthwaite@xilinx.com> wrote:
>> In preparation for migrating the state struct and type cast macro to a public
>> header. The acronym "UART" on it's own is not specific enough to be used in a
>> more global namespace so preface with "cadence". Fix the capitalisation of
>> "uart" in the state type while touching the typename. Preface macros
>> used by the state struct itself with CADENCE_UART so they don't conflict
>> in namespace either.
>
> This is another non-standalone commit message. Other than that:

Fixed.

> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Thanks.

>
>> -    s->r[R_SR] |= s->rx_count == RX_FIFO_SIZE ? UART_SR_INTR_RFUL : 0;
>> +    s->r[R_SR] |= s->rx_count == CADENCE_UART_RX_FIFO_SIZE ? UART_SR_INTR_RFUL
>> +                                                           : 0;
>
> These look kind of ugly as the line length got long enough to wrap.
>     if (s->rx_count == CADENCE_UART_RX_FIFO_SIZE) {
>         s->r[R_SR] |= UART_SR_INTR_RFUL;
>     }
> looks nicer to me (and makes it clearer that the bit only updates
> if the condition is true, rather than leaving you to figure it out
> from the combination of the OR and the ternary operator with a zero
> operand), but that kind of change doesn't belong in this
> no-content-change patch. You could do it in a later patch, or
> not do it at all if you don't think it's important enough (I
> don't care strongly either way).
>

Thinking we do this later to minimize scope of the series.

Regards,
Peter

> -- PMM
>