From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43732)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1YlRMZ-0006CZ-PO
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 20:21:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1YlRMV-0004eh-BJ
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 20:20:59 -0400
Received: from mail-qg0-f50.google.com ([209.85.192.50]:34382)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1YlRMV-0004eb-7q
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 20:20:55 -0400
Received: by qgfi89 with SMTP id i89so16153563qgf.1
	for <qemu-devel@nongnu.org>; Thu, 23 Apr 2015 17:20:54 -0700 (PDT)
MIME-Version: 1.0
Sender: peter.crosthwaite@petalogix.com
In-Reply-To: <CAFEAcA9tX+cmQzZ4yVoARbPpcJUqFv2r03X+ZHOgfUUmUK7B8Q@mail.gmail.com>
References: <cover.1427108387.git.peter.crosthwaite@xilinx.com>
	<4aa1fe1f66ef0765564e50b26a64bdf2427ac7cd.1427108387.git.peter.crosthwaite@xilinx.com>
	<CAFEAcA9tX+cmQzZ4yVoARbPpcJUqFv2r03X+ZHOgfUUmUK7B8Q@mail.gmail.com>
Date: Thu, 23 Apr 2015 17:20:54 -0700
Message-ID: <CAEgOgz5tASfB-cMSdpsMie_HLd+VsbYS6Myfv9Q=2rRUTCgydw@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH target-arm v4 11/16] char: cadence_uart:
 Split state struct and type into header
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Edgar Iglesias <edgar.iglesias@xilinx.com>, zach.pfeffer@xilinx.com, Ryota Ozaki <ozaki.ryota@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, Alistair Francis <alistair.francis@xilinx.com>, "michals@xilinx.com" <michals@xilinx.com>

On Thu, Apr 23, 2015 at 11:00 AM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> On 23 March 2015 at 11:05, Peter Crosthwaite
> <peter.crosthwaite@xilinx.com> wrote:
>> To allow using the device with modern SoC programming conventions. The
>> state struct needs to be visible to embed the device in SoC containers.
>>
>> Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
>> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>
> Non-standalone commit message body, header file needs copyright/license
> comment, include guard shouldn't have trailing _. Otherwise:
>

All fixed.

> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>

Thanks,

Regards,
Peter

> thanks
> -- PMM
>