From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52888)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1Uwv3h-0005T5-Sg
	for qemu-devel@nongnu.org; Wed, 10 Jul 2013 10:07:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1Uwv3c-0002lR-8R
	for qemu-devel@nongnu.org; Wed, 10 Jul 2013 10:07:53 -0400
Received: from mail-bk0-f45.google.com ([209.85.214.45]:46590)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1Uwv3c-0002lM-26
	for qemu-devel@nongnu.org; Wed, 10 Jul 2013 10:07:48 -0400
Received: by mail-bk0-f45.google.com with SMTP id je9so2831151bkc.4
	for <qemu-devel@nongnu.org>; Wed, 10 Jul 2013 07:07:47 -0700 (PDT)
MIME-Version: 1.0
Sender: peter.crosthwaite@petalogix.com
In-Reply-To: <51DD1A7F.1040809@suse.de>
References: <cb482f5459c86cc928f95c19b061badaa9adc1e9.1373432540.git.peter.crosthwaite@xilinx.com>
	<CAFEAcA8MYogkOc+Vz_5U9rr82r+X=TG68RuRfhUMU3B-y8Lz1g@mail.gmail.com>
	<51DD1A7F.1040809@suse.de>
Date: Thu, 11 Jul 2013 00:07:46 +1000
Message-ID: <CAEgOgz6FLaK1-Jy7xNdNpJ0VDfi5hEu5ZNEbL-PyVCQhstC_sQ@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH arm-devs v1 1/2] hw/timer: Introduce ARM A9
 Global Timer.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: devel@thom.fr.eu.org, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

Hi Andreas,

On Wed, Jul 10, 2013 at 6:25 PM, Andreas F=E4rber <afaerber@suse.de> wrote:
> Am 10.07.2013 09:41, schrieb Peter Maydell:
>> On 10 July 2013 06:08,  <peter.crosthwaite@xilinx.com> wrote:
>>> From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>>>
>>> The ARM A9 MPCore has a timer that is global to all CPUs in the mpcore.
>>> The timer is shared but each CPU has a private independent comparator
>>> and interrupt.
>>>
>>> Original version contributed by Francois LEGAL.
>>>
>>> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>>> ---
>>> Francois, do you want to re-add your SOB? I have changed the device
>>> a lot since your V2.
>
> If you have a DCO for a patch you're reusing, you should never "drop" it
> from your patch. You can still leave the textual explanation there.
>
>> The usual way to indicate this (assuming Francois signed off the
>> original patchset) is something like:
>>
>>   Signed-off-by: Original Author
>>   [You: <short description of subsequent changes>]
>>   Signed-off-by: Your Name
>
> Add to that, the difference between From and SOB indicates that you did
> more than just cosmetic touches. For example, when I wrote from scratch
> a new SoC QOM object I used my From and the original author's Sob (to
> put the blame on me while recording the DCO), whereas when I purely
> updated code to MemoryRegions, Coding Style, QOM casts, etc. I use the
> original author's From and [AF: ...].

This is much more than a stylistic change, its very heavily refactored. I t=
hink
its better to --reset-author but ill bring the SOB accross. Whereas with P2
all I have done is split of the MPCore changes from original file verbatim,=
 so
I guess that should be original author.

Regards,
Peter

>
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg
>