From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42796)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1TK8gE-0006jP-1i
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 10:15:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1TK8g3-0003Uj-LG
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 10:15:06 -0400
Received: from mail-vb0-f45.google.com ([209.85.212.45]:33785)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1TK8g3-0003Uf-Hv
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 10:14:55 -0400
Received: by mail-vb0-f45.google.com with SMTP id p1so1789449vbi.4
	for <qemu-devel@nongnu.org>; Fri, 05 Oct 2012 07:14:55 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA9E8VSzc33S3VTgsZTWZ-crV08VM+0CfqPGDyYNWP-8Cg@mail.gmail.com>
References: <1349395739-26502-1-git-send-email-peter.crosthwaite@xilinx.com>
	<1349395739-26502-7-git-send-email-peter.crosthwaite@xilinx.com>
	<CAFEAcA9E8VSzc33S3VTgsZTWZ-crV08VM+0CfqPGDyYNWP-8Cg@mail.gmail.com>
Date: Sat, 6 Oct 2012 00:14:54 +1000
Message-ID: <CAEgOgz6WeBrFRXZ9TNVF7qnS7OtTqoWkX9+v3wfosRKXXiNwiw@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH 06/14] stellaris: Removed SSI mux
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: blauwirbel@gmail.com, edgar.iglesias@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org

On Fri, Oct 5, 2012 at 10:34 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 5 October 2012 01:08, Peter Crosthwaite
> <peter.crosthwaite@petalogix.com> wrote:
>> From: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
>>
>> Removed the explicit SSI mux and wired the CS line directly up to the SSI
>> devices.
>>
>> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
>> +            dev = ssi_create_slave(bus, "ssi-sd");
>>              if (gpio_dev[GPIO_D]) {
>> -                qdev_connect_gpio_out(gpio_dev[GPIO_D], 0, select_pin);
>> +                qdev_connect_gpio_out(gpio_dev[GPIO_D], 0,
>> +                                        qdev_get_gpio_in(dev, 0));
>>              }
>>
>> -            bus = qdev_get_child_bus(mux, "ssi0");
>> -            ssi_create_slave(bus, "ssi-sd");
>> -
>> -            bus = qdev_get_child_bus(mux, "ssi1");
>>              dev = ssi_create_slave(bus, "ssd0323");
>> +            if (gpio_dev[GPIO_D]) {
>> +                qdev_connect_gpio_out(gpio_dev[GPIO_D], 0,
>> +                                        qdev_get_gpio_in(dev, 0));
>> +            }
>
> ...this seems to be trying to wire up two devices to the same
> GPIO output ?
>

Reimplemented using qemu_irq_split()

Regards,
Peter

> -- PMM