From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47328)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1YlRi4-0006xd-48
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 20:43:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1YlRi0-0002Xn-3N
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 20:43:12 -0400
Received: from mail-qk0-f179.google.com ([209.85.220.179]:34845)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1YlRhz-0002Xh-WB
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 20:43:08 -0400
Received: by qkhg7 with SMTP id g7so21611582qkh.2
	for <qemu-devel@nongnu.org>; Thu, 23 Apr 2015 17:43:07 -0700 (PDT)
MIME-Version: 1.0
Sender: peter.crosthwaite@petalogix.com
In-Reply-To: <CAFEAcA9FnjTxiGStruowViahNC08C0sjreqxbdJaOxGsW6poVw@mail.gmail.com>
References: <cover.1427108387.git.peter.crosthwaite@xilinx.com>
	<8f036aa5e8b618bcce048c1ca9ce629ec49aad31.1427108387.git.peter.crosthwaite@xilinx.com>
	<CAFEAcA9FnjTxiGStruowViahNC08C0sjreqxbdJaOxGsW6poVw@mail.gmail.com>
Date: Thu, 23 Apr 2015 17:43:07 -0700
Message-ID: <CAEgOgz7U_GYJvnGhYfBvYkEbhOrUFch-q7bD4ej0GNLNew4u4w@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH target-arm v4 15/16] arm: xilinx-ep108: Add
	bootloading
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Edgar Iglesias <edgar.iglesias@xilinx.com>, Ryota Ozaki <ozaki.ryota@gmail.com>, "michals@xilinx.com" <michals@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, zach.pfeffer@xilinx.com

On Thu, Apr 23, 2015 at 11:15 AM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> On 23 March 2015 at 11:05, Peter Crosthwaite
> <peter.crosthwaite@xilinx.com> wrote:
>> Using standard ARM bootloader.
>
> Commit msg, etc.
>
>> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>> ---
>>  hw/arm/xlnx-ep108.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c
>> index 6e89456..a86f595 100644
>> --- a/hw/arm/xlnx-ep108.c
>> +++ b/hw/arm/xlnx-ep108.c
>> @@ -28,6 +28,8 @@ typedef struct XlnxEP108 {
>>  /* Max 2GB RAM */
>>  #define EP108_MAX_RAM_SIZE 0x80000000ull
>>
>> +static struct arm_boot_info xlnx_ep108_binfo;
>> +
>>  static void xlnx_ep108_init(MachineState *machine)
>>  {
>>      XlnxEP108 *s = g_new0(XlnxEP108, 1);
>> @@ -58,6 +60,12 @@ static void xlnx_ep108_init(MachineState *machine)
>>                             &error_abort);
>>      vmstate_register_ram_global(&s->ddr_ram);
>>      memory_region_add_subregion(get_system_memory(), 0, &s->ddr_ram);
>> +
>> +    xlnx_ep108_binfo.ram_size = machine->ram_size;
>> +    xlnx_ep108_binfo.kernel_filename = machine->kernel_filename;
>> +    xlnx_ep108_binfo.kernel_cmdline = machine->kernel_cmdline;
>> +    xlnx_ep108_binfo.initrd_filename = machine->initrd_filename;
>
> nb_cpus, loader_start ?
>

I don't see any valid use for non-0 nb_cpus for aarch64 bootloading. I
think PSCI just handles it all? default_write_secondary will write in
smpboot contents which is AA32.

Loader start is 0. I'll make it explicit.

Regards,
Peter

>> +    arm_load_kernel(&s->soc.cpu[0], &xlnx_ep108_binfo);
>>  }
>>
>>  static QEMUMachine xlnx_ep108_machine = {
>> --
>> 2.3.1.2.g90df61e.dirty
>
> thanks
> -- PMM
>