From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752771AbdKJKc7 (ORCPT ); Fri, 10 Nov 2017 05:32:59 -0500 Received: from mail-qk0-f172.google.com ([209.85.220.172]:46917 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404AbdKJKc4 (ORCPT ); Fri, 10 Nov 2017 05:32:56 -0500 X-Google-Smtp-Source: AGs4zMYUcH+uJ/DK4n5x2BY2J7qR9l++Z6AN4sv3ZHKTdOqwTzHQlKlKWCaAU8la1AOKJFmcfxMHgsAoG7b+fw1+nMI= MIME-Version: 1.0 In-Reply-To: References: <1510244046-3256-1-git-send-email-tixxdz@gmail.com> <1510244046-3256-2-git-send-email-tixxdz@gmail.com> From: Djalal Harouni Date: Fri, 10 Nov 2017 11:32:55 +0100 Message-ID: Subject: Re: [PATCH RFC v3 1/7] proc: add proc_fs_info struct to store proc information To: Alexey Dobriyan Cc: Kees Cook , Alexey Gladkov , Andy Lutomirski , Andrew Morton , Linux FS Devel , linux-kernel , kernel-hardening@lists.openwall.com, LSM List , Linux API , Greg Kroah-Hartman , Alexander Viro , Akinobu Mita , "Tobin C. Harding" , Oleg Nesterov , Jeff Layton , Ingo Molnar , "Eric W. Biederman" , Linus Torvalds , Daniel Micay , Jonathan Corbet , "J. Bruce Fields" , Stephen Rothwell , Solar Designer Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 10, 2017 at 11:26 AM, Alexey Dobriyan wrote: > On 11/9/17, Djalal Harouni wrote: > >> +struct proc_fs_info { >> + struct pid_namespace *pid_ns; >> +}; > >> +static inline struct proc_fs_info *proc_sb(struct super_block *sb) >> +{ >> + return sb->s_fs_info; >> +} > > Can you rename this to "struct proc_super_block *" then? > That "info" suffix all over filesystems doesn't add much info itself > just more typing. > Ditto for "fs_info" identifiers. Ok, will do. >> +extern inline struct proc_fs_info *proc_sb(struct super_block *sb) >> { return NULL;} > > extern inline? Oups, sorry will fix it and try to compile without proc. Thank you! -- tixxdz From mboxrd@z Thu Jan 1 00:00:00 1970 From: Djalal Harouni Subject: Re: [PATCH RFC v3 1/7] proc: add proc_fs_info struct to store proc information Date: Fri, 10 Nov 2017 11:32:55 +0100 Message-ID: References: <1510244046-3256-1-git-send-email-tixxdz@gmail.com> <1510244046-3256-2-git-send-email-tixxdz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: owner-linux-security-module@vger.kernel.org To: Alexey Dobriyan Cc: Kees Cook , Alexey Gladkov , Andy Lutomirski , Andrew Morton , Linux FS Devel , linux-kernel , kernel-hardening@lists.openwall.com, LSM List , Linux API , Greg Kroah-Hartman , Alexander Viro , Akinobu Mita , "Tobin C. Harding" , Oleg Nesterov , Jeff Layton , Ingo Molnar , "Eric W. Biederman" , Linus Torvalds , Daniel Micay List-Id: linux-api@vger.kernel.org On Fri, Nov 10, 2017 at 11:26 AM, Alexey Dobriyan wrote: > On 11/9/17, Djalal Harouni wrote: > >> +struct proc_fs_info { >> + struct pid_namespace *pid_ns; >> +}; > >> +static inline struct proc_fs_info *proc_sb(struct super_block *sb) >> +{ >> + return sb->s_fs_info; >> +} > > Can you rename this to "struct proc_super_block *" then? > That "info" suffix all over filesystems doesn't add much info itself > just more typing. > Ditto for "fs_info" identifiers. Ok, will do. >> +extern inline struct proc_fs_info *proc_sb(struct super_block *sb) >> { return NULL;} > > extern inline? Oups, sorry will fix it and try to compile without proc. Thank you! -- tixxdz From mboxrd@z Thu Jan 1 00:00:00 1970 From: tixxdz@gmail.com (Djalal Harouni) Date: Fri, 10 Nov 2017 11:32:55 +0100 Subject: [PATCH RFC v3 1/7] proc: add proc_fs_info struct to store proc information In-Reply-To: References: <1510244046-3256-1-git-send-email-tixxdz@gmail.com> <1510244046-3256-2-git-send-email-tixxdz@gmail.com> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Fri, Nov 10, 2017 at 11:26 AM, Alexey Dobriyan wrote: > On 11/9/17, Djalal Harouni wrote: > >> +struct proc_fs_info { >> + struct pid_namespace *pid_ns; >> +}; > >> +static inline struct proc_fs_info *proc_sb(struct super_block *sb) >> +{ >> + return sb->s_fs_info; >> +} > > Can you rename this to "struct proc_super_block *" then? > That "info" suffix all over filesystems doesn't add much info itself > just more typing. > Ditto for "fs_info" identifiers. Ok, will do. >> +extern inline struct proc_fs_info *proc_sb(struct super_block *sb) >> { return NULL;} > > extern inline? Oups, sorry will fix it and try to compile without proc. Thank you! -- tixxdz -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 MIME-Version: 1.0 In-Reply-To: References: <1510244046-3256-1-git-send-email-tixxdz@gmail.com> <1510244046-3256-2-git-send-email-tixxdz@gmail.com> From: Djalal Harouni Date: Fri, 10 Nov 2017 11:32:55 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: [kernel-hardening] Re: [PATCH RFC v3 1/7] proc: add proc_fs_info struct to store proc information To: Alexey Dobriyan Cc: Kees Cook , Alexey Gladkov , Andy Lutomirski , Andrew Morton , Linux FS Devel , linux-kernel , kernel-hardening@lists.openwall.com, LSM List , Linux API , Greg Kroah-Hartman , Alexander Viro , Akinobu Mita , "Tobin C. Harding" , Oleg Nesterov , Jeff Layton , Ingo Molnar , "Eric W. Biederman" , Linus Torvalds , Daniel Micay , Jonathan Corbet , "J. Bruce Fields" , Stephen Rothwell , Solar Designer List-ID: On Fri, Nov 10, 2017 at 11:26 AM, Alexey Dobriyan wrote: > On 11/9/17, Djalal Harouni wrote: > >> +struct proc_fs_info { >> + struct pid_namespace *pid_ns; >> +}; > >> +static inline struct proc_fs_info *proc_sb(struct super_block *sb) >> +{ >> + return sb->s_fs_info; >> +} > > Can you rename this to "struct proc_super_block *" then? > That "info" suffix all over filesystems doesn't add much info itself > just more typing. > Ditto for "fs_info" identifiers. Ok, will do. >> +extern inline struct proc_fs_info *proc_sb(struct super_block *sb) >> { return NULL;} > > extern inline? Oups, sorry will fix it and try to compile without proc. Thank you! -- tixxdz