From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E93C6FD1F for ; Wed, 22 Mar 2023 14:19:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229991AbjCVOTE (ORCPT ); Wed, 22 Mar 2023 10:19:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231434AbjCVOSq (ORCPT ); Wed, 22 Mar 2023 10:18:46 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73EC46506A for ; Wed, 22 Mar 2023 07:18:16 -0700 (PDT) Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 7C5464185E for ; Wed, 22 Mar 2023 14:18:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1679494692; bh=7XZVyJw56GOSYCywV6LPILMZhj++FZFsBU6mgCuT8fQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=VQYrKktrnLgqItulloCSwlvz2afiiR0sC3L8iiAwwvssAbXt+tmQTIaPcaUOXvsKs Cb8sbFC4dcMdeYPLD2qvZkk4pCxAoBjjAvBjsPQ73VOFekjwt0Q3aXwsoAbr3Exw/A lum3wE6nMRorlg0Ult1EXLnezhbQ683fSMyUs7bJa71kHhoQS61lp6dkHX8B92LxBs FUgPXZeyyIlb/NPgMCUqv88RPc2uYrmpwhNBwBvyBkl9CE2mBa5Hov+J9UC5OomhEh Tlb0FVqJp2QWHO3X5CE5NEvnk1RAOFyxiE313jhDyp3U46jbQTiMy9WD+LBh87ZMgu Z7pYqB+KNP17Q== Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-5446a91c40cso189671417b3.18 for ; Wed, 22 Mar 2023 07:18:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679494689; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7XZVyJw56GOSYCywV6LPILMZhj++FZFsBU6mgCuT8fQ=; b=qFTuw0ep7IoQfg3nKEaBAzdT/htTF8BbUoQAnOUW+XaC2B7m0H2+ofDSFXn3W/yqpo Uf7oKBkUlXGDosbMqmwRkqncO6RcTRChtaSFtwkka4F2wBVf/ZRXtgGMRNffjthe8F00 JpHzeuNQGLkAwnY32489tYhmwYfMDHY+dkV9CtTTojLpX4ynatfdWfJttIC7eXfDJG0i PtDJ+icAwagMTh3k956CJyQTGQcMhMfaXutMjTkmp+5BA0de55wUaFMVSD6ukITxe/r0 PMPCNt/6Krg2ohEr3XaqelszkJw5e6jOhDtwvd0D7NXc9WiSSqARLAuiOv7E87kRyvvU 2LEw== X-Gm-Message-State: AAQBX9eiLdBnHJ+nLrmh2bgSuXABCTk2qbghpftyM5ArdOICgBiFVGiP EXuLMOMfUQvJ2tctxjURiGJpDIWvxeEu9r34wEowSGlf3hNn+pMyEsGg1bullTLKuzsSNgxi6Hf RBvqWl9m3vpewj4FJSnqPIk0b8MMqOaLjpK/0cqvIkO6NYCzA1sOGcd5ZcJcHZE/vz49H X-Received: by 2002:a5b:34a:0:b0:a99:de9d:d504 with SMTP id q10-20020a5b034a000000b00a99de9dd504mr4017150ybp.12.1679494689201; Wed, 22 Mar 2023 07:18:09 -0700 (PDT) X-Google-Smtp-Source: AKy350ZaWd695Qr21xcE8I1197J/xWJayD/EbAbBFsqd+2Q3QKbwsqkT95oOZVCdGbYgv0QLG2bxQu7uTn00fpCib4I= X-Received: by 2002:a5b:34a:0:b0:a99:de9d:d504 with SMTP id q10-20020a5b034a000000b00a99de9dd504mr4017144ybp.12.1679494688982; Wed, 22 Mar 2023 07:18:08 -0700 (PDT) MIME-Version: 1.0 References: <20230321183342.617114-1-aleksandr.mikhalitsyn@canonical.com> <20230322141317.am2j6ml4rvwc5hrx@wittgenstein> In-Reply-To: <20230322141317.am2j6ml4rvwc5hrx@wittgenstein> From: Aleksandr Mikhalitsyn Date: Wed, 22 Mar 2023 15:17:58 +0100 Message-ID: Subject: Re: [PATCH net-next v2 0/3] Add SCM_PIDFD and SO_PEERPIDFD To: Christian Brauner Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Leon Romanovsky , David Ahern , Arnd Bergmann , Kees Cook , Kuniyuki Iwashima , Lennart Poettering Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2023 at 3:13=E2=80=AFPM Christian Brauner wrote: > > On Tue, Mar 21, 2023 at 07:33:39PM +0100, Alexander Mikhalitsyn wrote: > > 1. Implement SCM_PIDFD, a new type of CMSG type analogical to SCM_CREDE= NTIALS, > > but it contains pidfd instead of plain pid, which allows programmers no= t > > to care about PID reuse problem. > > > > 2. Add SO_PEERPIDFD which allows to get pidfd of peer socket holder pid= fd. > > This thing is direct analog of SO_PEERCRED which allows to get plain PI= D. > > > > 3. Add SCM_PIDFD / SO_PEERPIDFD kselftest > > > > Idea comes from UAPI kernel group: > > https://uapi-group.org/kernel-features/ > > > > Big thanks to Christian Brauner and Lennart Poettering for productive > > discussions about this. > > > > Cc: "David S. Miller" > > Cc: Eric Dumazet > > Cc: Jakub Kicinski > > Cc: Paolo Abeni > > Cc: Leon Romanovsky > > Cc: David Ahern > > Cc: Arnd Bergmann > > Cc: Kees Cook > > Cc: Christian Brauner > > Cc: Kuniyuki Iwashima > > Cc: Lennart Poettering > > > > Alexander Mikhalitsyn (3): > > scm: add SO_PASSPIDFD and SCM_PIDFD > > net: core: add getsockopt SO_PEERPIDFD > > selftests: net: add SCM_PIDFD / SO_PEERPIDFD test > > > > arch/alpha/include/uapi/asm/socket.h | 3 + > > arch/mips/include/uapi/asm/socket.h | 3 + > > arch/parisc/include/uapi/asm/socket.h | 3 + > > arch/sparc/include/uapi/asm/socket.h | 3 + > > include/linux/net.h | 1 + > > include/linux/socket.h | 1 + > > include/net/scm.h | 14 +- > > include/uapi/asm-generic/socket.h | 3 + > > net/core/sock.c | 32 ++ > > net/mptcp/sockopt.c | 1 + > > net/unix/af_unix.c | 18 +- > > tools/include/uapi/asm-generic/socket.h | 3 + > > tools/testing/selftests/net/.gitignore | 1 + > > tools/testing/selftests/net/af_unix/Makefile | 3 +- > > .../testing/selftests/net/af_unix/scm_pidfd.c | 336 ++++++++++++++++++ > > 15 files changed, 417 insertions(+), 8 deletions(-) > > create mode 100644 tools/testing/selftests/net/af_unix/scm_pidfd.c > > What's the commit for this work? Because this seems to fail to apply > cleanly on anything from v6.3-rc1 until v6.3-rc3. It's based on net-next https://git.kernel.org/netdev/net-next/c/a02d83f9947= d Kind regards, Alex >