All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: William Roberts <bill.c.roberts@gmail.com>
Cc: Nicolas Iooss <nicolas.iooss@m4x.org>,
	SElinux list <selinux@vger.kernel.org>,
	Ulrich Drepper <drepper@redhat.com>,
	Ondrej Mosnacek <omosnace@redhat.com>,
	Petr Lautrbach <plautrba@redhat.com>,
	William Roberts <william.c.roberts@intel.com>
Subject: Re: [PATCH v2 3/3] lbespol: remove wild cards in mapfile
Date: Wed, 11 Mar 2020 14:53:08 -0400	[thread overview]
Message-ID: <CAEjxPJ4FTpQRTp2ChKrsyYUZMwicKQ_vT=BCgCDdpXLGLtODCA@mail.gmail.com> (raw)
In-Reply-To: <20200310210854.466-4-william.c.roberts@intel.com>

On Tue, Mar 10, 2020 at 5:09 PM <bill.c.roberts@gmail.com> wrote:
>
> From: William Roberts <william.c.roberts@intel.com>
>
> With the old hidden_def and hidden_proto DSO infrastructure removed,
> correctness of the map file becomes paramount, as it is what filters out
> public API. Because of this, the wild cards should not be used, as it
> lets some functions through that should not be made public API. Thus
> remove the wild cards, and sort the list.
>
> Additionally, verify that nothing changed in external symbols as well:
>
> This was checked by generating an old export map (from master):
> nm --defined-only -g ./src/libsepol.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map
>
> Then creating a new one for this library after this patch is applied:
> nm --defined-only -g ./src/libsepol.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map
>
> And diffing them:
> diff old.map new.map
>
> Signed-off-by: William Roberts <william.c.roberts@intel.com>

Other than the typo in the subject line,
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>

This should fix https://github.com/SELinuxProject/selinux/issues/204

  reply	other threads:[~2020-03-11 18:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 15:25 libsepol drop dso.h bill.c.roberts
2020-03-09 15:25 ` [PATCH 1/2] libsepol/dso: drop hidden_proto and hidden_def bill.c.roberts
2020-03-10 20:10   ` Stephen Smalley
2020-03-10 20:15     ` William Roberts
2020-03-09 15:25 ` [PATCH 2/2] libsepol/Makefile: add -fno-semantic-interposition bill.c.roberts
2020-03-10 21:08 ` V2 libsepol drop dso.h bill.c.roberts
2020-03-10 21:08   ` [PATCH v2 1/3] libsepol/dso: drop hidden_proto and hidden_def bill.c.roberts
2020-03-10 21:08   ` [PATCH v2 2/3] libsepol/Makefile: add -fno-semantic-interposition bill.c.roberts
2020-03-10 21:08   ` [PATCH v2 3/3] lbespol: remove wild cards in mapfile bill.c.roberts
2020-03-11 18:53     ` Stephen Smalley [this message]
2020-03-11 18:54       ` Stephen Smalley
2020-03-12 13:59         ` William Roberts
2020-03-12 20:22           ` Stephen Smalley
2020-03-12 21:42             ` William Roberts
2020-03-13 11:03               ` Ondrej Mosnacek
2020-03-13 14:22                 ` William Roberts
2020-03-13 14:41                   ` Ondrej Mosnacek
2020-03-13 14:51                     ` William Roberts
2020-03-17 17:46               ` Stephen Smalley
2020-03-19 19:46                 ` William Roberts
2020-03-19 19:48                   ` [PATCH] cil: drop remaining dso.h include bill.c.roberts
2020-03-20  8:08                     ` Ondrej Mosnacek
2020-03-23 15:35                       ` William Roberts
2020-03-26 15:16                         ` Joshua Brindle
2020-03-26 15:35                           ` William Roberts
2020-03-26 15:46                           ` cil: Fix DISABLE_SYMVER support and drop last dso.h bill.c.roberts
2020-03-26 15:46                             ` [PATCH 1/2] cil: rm dead dso.h file bill.c.roberts
2020-03-26 15:46                             ` [PATCH 2/2] cil: re-enable DISABLE_SYMVER define bill.c.roberts
2020-03-26 15:47                             ` cil: Fix DISABLE_SYMVER support and drop last dso.h William Roberts
2020-03-26 16:05                               ` Joshua Brindle
2020-03-26 16:18                                 ` William Roberts
2020-03-27 14:27                                   ` William Roberts
2020-03-27 14:47                                     ` Stephen Smalley
2020-03-27 15:02                                       ` William Roberts
2020-03-26 16:50                           ` [PATCH] cil: drop remaining dso.h include Stephen Smalley
2020-03-26 16:51                             ` William Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEjxPJ4FTpQRTp2ChKrsyYUZMwicKQ_vT=BCgCDdpXLGLtODCA@mail.gmail.com' \
    --to=stephen.smalley.work@gmail.com \
    --cc=bill.c.roberts@gmail.com \
    --cc=drepper@redhat.com \
    --cc=nicolas.iooss@m4x.org \
    --cc=omosnace@redhat.com \
    --cc=plautrba@redhat.com \
    --cc=selinux@vger.kernel.org \
    --cc=william.c.roberts@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.