From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: Ondrej Mosnacek <omosnace@redhat.com>, Paul Moore <paul@paul-moore.com>
Cc: SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH] selinux-testsuite: update to work on Debian
Date: Wed, 6 May 2020 16:26:49 -0400 [thread overview]
Message-ID: <CAEjxPJ7ZsE=ArK0HZiZMOZ0u_z-b8mdADpj+jWto7r+6+1Jozg@mail.gmail.com> (raw)
In-Reply-To: <CAEjxPJ5=6FhOukWThYeO+LrNTAfPSeCq-7Z27c+zhAdesPbDXg@mail.gmail.com>
On Wed, May 6, 2020 at 3:57 PM Stephen Smalley
<stephen.smalley.work@gmail.com> wrote:
>
> On Wed, May 6, 2020 at 3:37 PM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> >
> > On Wed, May 6, 2020 at 2:54 AM Stephen Smalley
> > <stephen.smalley.work@gmail.com> wrote:
> > > diff --git a/policy/Makefile b/policy/Makefile
> > > index dfe601b..f86aac4 100644
> > > --- a/policy/Makefile
> > > +++ b/policy/Makefile
> > > @@ -40,6 +40,8 @@ CIL_TARGETS = test_add_levels.cil test_glblub.cil
> > > endif
> > > endif # GLBLUB
> > >
> > > +CIL_TARGETS += test_mlsconstrain.cil test_overlay_defaultrange.cil
> >
> > This causes a problem on RHEL-6, since it doesn't understand CIL
> > modules. We'll probably need to detect if semodule supports CIL before
> > trying to add the modules.
>
> I thought we had stopped worrying about RHEL compatibility in the
> upstream testsuite going forward and deferring all of those tweaks to
> downstream? I'm not fundamentally opposed but that was the impression
> I had received earlier. If we are still carrying RHEL support, then
> how old of RHEL do we still care about? RHEL-6 is six months away
> from regular EOL?
Also not sure what we would test here to determine whether CIL is supported.
It isn't directly linked to a particular kernel or module binary
policy version, and the version of libsepol that first introduced it
in RHEL-7 probably differs from upstream (assuming it was back-ported
there).
>
> > > diff --git a/policy/test_execute_no_trans.te b/policy/test_execute_no_trans.te
> > > index 79ba868..f699f56 100644
> > > --- a/policy/test_execute_no_trans.te
> > > +++ b/policy/test_execute_no_trans.te
> > > @@ -24,4 +24,4 @@ userdom_sysadm_entry_spec_domtrans_to(test_execute_notrans_t)
> > >
> > > #Allow test_execute_notrans permissions to the allowed type
> > > can_exec(test_execute_notrans_t,test_execute_notrans_allowed_t)
> > > -allow test_execute_notrans_t test_execute_notrans_denied_t:file mmap_file_perms;
> > > +allow test_execute_notrans_t test_execute_notrans_denied_t:file mmap_exec_file_perms;
> >
> > This causes the testsuite to fail on RHEL-7, since there
> > mmap_exec_file_perms includes execute_no_trans for some reason. And on
> > RHEL-6 mmap_exec_file_perms is not defined at all. Can we solve this
> > bz defining mmap_exec_file_perms as mmap_file_perms in test_policy.if
> > if mmap_exec_file_perms is not defined?
>
> Yes, if we are still providing RHEL-7 compatibility for the testsuite,
> that's easy enough.
Actually on second thought that seems problematic since RHEL-7 defines
it but defines it differently. So essentially I'd just need to
undefine it and redefine it always, or just inline the definition
itself here.
next prev parent reply other threads:[~2020-05-06 20:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 0:53 [PATCH] selinux-testsuite: update to work on Debian Stephen Smalley
2020-05-06 13:44 ` Stephen Smalley
2020-05-06 14:57 ` William Roberts
2020-05-06 15:50 ` Stephen Smalley
2020-05-06 15:54 ` William Roberts
2020-05-06 16:37 ` Russell Coker
2020-05-07 8:35 ` Laurent Bigonville
2020-05-07 12:51 ` Stephen Smalley
2020-05-07 13:13 ` Petr Lautrbach
2020-05-07 13:32 ` Stephen Smalley
2020-05-07 13:41 ` Laurent Bigonville
2020-05-08 3:03 ` Paul Moore
2020-05-13 15:51 ` Stephen Smalley
2020-05-15 16:27 ` William Roberts
2020-05-15 16:41 ` Ondrej Mosnacek
2020-05-15 16:46 ` William Roberts
2020-05-15 17:18 ` Ondrej Mosnacek
2020-05-15 17:24 ` William Roberts
2020-05-07 14:49 ` Russell Coker
2020-05-07 14:54 ` Stephen Smalley
2020-05-07 15:01 ` William Roberts
2020-05-07 15:12 ` Stephen Smalley
2020-05-07 15:22 ` William Roberts
2020-05-12 11:19 ` Petr Lautrbach
[not found] ` <CAJVWAV07O-cQ5EzqYpodjeVRjdtD7ga=bUwEiTm00BaKRMiyFQ@mail.gmail.com>
2020-05-06 19:17 ` Fwd: " Dac Override
2020-05-06 20:07 ` Stephen Smalley
2020-05-06 19:37 ` Ondrej Mosnacek
2020-05-06 19:57 ` Stephen Smalley
2020-05-06 20:26 ` Stephen Smalley [this message]
2020-05-07 8:24 ` Ondrej Mosnacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEjxPJ7ZsE=ArK0HZiZMOZ0u_z-b8mdADpj+jWto7r+6+1Jozg@mail.gmail.com' \
--to=stephen.smalley.work@gmail.com \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.