From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D256C43603 for ; Wed, 4 Dec 2019 12:57:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FFFC20803 for ; Wed, 4 Dec 2019 12:57:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CjK94ZRk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727872AbfLDM5L (ORCPT ); Wed, 4 Dec 2019 07:57:11 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33668 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbfLDM5L (ORCPT ); Wed, 4 Dec 2019 07:57:11 -0500 Received: by mail-wr1-f65.google.com with SMTP id b6so8541235wrq.0; Wed, 04 Dec 2019 04:57:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WX9DsnxjR1TLkIQAS0BjsZD23PSgQu93DSuzJlaRss8=; b=CjK94ZRk2M/LKqEEX5rm/3WkZf/HiI3Q+vVXDbZOZxQNFGaqW6DwTHkkkx84vRfS+M U4ORtkjPBA9iSMbi9wpu7YmMFTp+pNz3ylxcjalwvJv2KZQBId8X2noNPl++SsRNODK7 QHPvskaMNV5R762Lpb7nY4iTA+SdVhlMhJxfRgfvM6jxwD1ZNI97gcI1rUhzyzNaVE+Q k0Bc2/yGbWtp6U/eTSBRlksg5lobZN4iEcrEFCI2rqfgwYhIgxNwI1rIPCeNNltPaVVM rHvfdkl+vcc+QKkCwM59zcflNAcevYc8jww4nTJSaG3Zq6ZEE7D6XZBEvNXC3R/zck1W +j6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WX9DsnxjR1TLkIQAS0BjsZD23PSgQu93DSuzJlaRss8=; b=pxgNVOgwIvkOfmoXERfwOH0Kiku7SN/V9+mRNatB+tUZlpcj0uYwx5WnpaNTD/h+Bd FdO7FGNayoTnSeKaMPfDIUIXSSeA7nmuZCyWmKzmCw2FcB3v4lR7G/zKeimLjUfAiz7A Q2VD6++zB64LPRbGsrpdkOzZSSHvLQvPyKyZl6ISblWtB72CYBcpCxbFqp9NmQARmOyE 4tNKgnF6F+CHHulI5AHx3fnf3odzuVoecz2oG/+592xMabSrd0c/h5eUH1c0jIf+QRtd XbeGBNNUBzhauA4atFhpwvDRAoKCd74vw33T4c76gOTH36Q10/A6S6PCU6BmM734gnrA wJ3A== X-Gm-Message-State: APjAAAUfurpV8ZteyShaiPCn2cp8mPWYI9Py+2MaEZqvrtBKcn7EglMl 1NQpLXO8iycKOaavmZ+Zx2n59nnzmR3CQucjwSM= X-Google-Smtp-Source: APXvYqzndsNueQS92Xe4B1d71REsjlvqx9ynvD8CvVkru+ORVDr1gVmjag6dLc6gMBN+1fpeYUjla8YjTCCO/YsvQMA= X-Received: by 2002:adf:dd52:: with SMTP id u18mr3950790wrm.131.1575464228649; Wed, 04 Dec 2019 04:57:08 -0800 (PST) MIME-Version: 1.0 References: <20191204124816.1415359-1-colin.king@canonical.com> In-Reply-To: <20191204124816.1415359-1-colin.king@canonical.com> From: Daniel Baluta Date: Wed, 4 Dec 2019 14:56:57 +0200 Message-ID: Subject: Re: [PATCH] ASoC: SOF: imx8: fix memory allocation failure check on priv->pd_dev To: Colin King Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Daniel Baluta , Pierre-Louis Bossart , Linux-ALSA , linux-arm-kernel , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 4, 2019 at 2:49 PM Colin King wrote: > > From: Colin Ian King > > The memory allocation failure check for priv->pd_dev is incorrectly > pointer checking priv instead of priv->pd_dev. Fix this. > > Addresses-Coverity: ("Logically dead code") > Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support") > Signed-off-by: Colin Ian King Reviewed-by: Daniel Baluta Good catch! Thanks Colin! > --- > sound/soc/sof/imx/imx8.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/imx/imx8.c b/sound/soc/sof/imx/imx8.c > index cfefcfd92798..9d926b1df0d7 100644 > --- a/sound/soc/sof/imx/imx8.c > +++ b/sound/soc/sof/imx/imx8.c > @@ -209,7 +209,7 @@ static int imx8_probe(struct snd_sof_dev *sdev) > > priv->pd_dev = devm_kmalloc_array(&pdev->dev, priv->num_domains, > sizeof(*priv->pd_dev), GFP_KERNEL); > - if (!priv) > + if (!priv->pd_dev) > return -ENOMEM; > > priv->link = devm_kmalloc_array(&pdev->dev, priv->num_domains, > -- > 2.24.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Baluta Date: Wed, 04 Dec 2019 12:56:57 +0000 Subject: Re: [PATCH] ASoC: SOF: imx8: fix memory allocation failure check on priv->pd_dev Message-Id: List-Id: References: <20191204124816.1415359-1-colin.king@canonical.com> In-Reply-To: <20191204124816.1415359-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Daniel Baluta , Pierre-Louis Bossart , Linux-ALSA , Linux Kernel Mailing List , Fabio Estevam , Sascha Hauer , kernel-janitors@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , linux-arm-kernel On Wed, Dec 4, 2019 at 2:49 PM Colin King wrote: > > From: Colin Ian King > > The memory allocation failure check for priv->pd_dev is incorrectly > pointer checking priv instead of priv->pd_dev. Fix this. > > Addresses-Coverity: ("Logically dead code") > Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support") > Signed-off-by: Colin Ian King Reviewed-by: Daniel Baluta Good catch! Thanks Colin! > --- > sound/soc/sof/imx/imx8.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/imx/imx8.c b/sound/soc/sof/imx/imx8.c > index cfefcfd92798..9d926b1df0d7 100644 > --- a/sound/soc/sof/imx/imx8.c > +++ b/sound/soc/sof/imx/imx8.c > @@ -209,7 +209,7 @@ static int imx8_probe(struct snd_sof_dev *sdev) > > priv->pd_dev = devm_kmalloc_array(&pdev->dev, priv->num_domains, > sizeof(*priv->pd_dev), GFP_KERNEL); > - if (!priv) > + if (!priv->pd_dev) > return -ENOMEM; > > priv->link = devm_kmalloc_array(&pdev->dev, priv->num_domains, > -- > 2.24.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9716C43603 for ; Wed, 4 Dec 2019 12:58:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 629D520803 for ; Wed, 4 Dec 2019 12:58:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="C+cDMby7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CjK94ZRk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 629D520803 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4E02D1614; Wed, 4 Dec 2019 13:57:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4E02D1614 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1575464284; bh=GCWtwP+F+slJCnbcDQ2hu8Cmc8nkHGaRhJcScqwigMc=; h=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=C+cDMby7xBpUFWJTD1mbTswCcxjdy/3eWIjmaEcVgym0EOfFd8JaEUsuQMHd3Ut2U geE+CwdliqkEhsGOtscOND2vdcI01WIwoB+t/lt14HPQf7Z3J1PzzP8EkfnUJ/yIoU Jj9N50Q5MS2V7LgM4OBgDmFvVIge3us+Rsbjdv7s= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C16FAF801D9; Wed, 4 Dec 2019 13:57:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4A39FF801EC; Wed, 4 Dec 2019 13:57:12 +0100 (CET) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 97D7CF800B4 for ; Wed, 4 Dec 2019 13:57:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 97D7CF800B4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CjK94ZRk" Received: by mail-wr1-x442.google.com with SMTP id a15so8458742wrf.9 for ; Wed, 04 Dec 2019 04:57:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WX9DsnxjR1TLkIQAS0BjsZD23PSgQu93DSuzJlaRss8=; b=CjK94ZRk2M/LKqEEX5rm/3WkZf/HiI3Q+vVXDbZOZxQNFGaqW6DwTHkkkx84vRfS+M U4ORtkjPBA9iSMbi9wpu7YmMFTp+pNz3ylxcjalwvJv2KZQBId8X2noNPl++SsRNODK7 QHPvskaMNV5R762Lpb7nY4iTA+SdVhlMhJxfRgfvM6jxwD1ZNI97gcI1rUhzyzNaVE+Q k0Bc2/yGbWtp6U/eTSBRlksg5lobZN4iEcrEFCI2rqfgwYhIgxNwI1rIPCeNNltPaVVM rHvfdkl+vcc+QKkCwM59zcflNAcevYc8jww4nTJSaG3Zq6ZEE7D6XZBEvNXC3R/zck1W +j6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WX9DsnxjR1TLkIQAS0BjsZD23PSgQu93DSuzJlaRss8=; b=Pf9p06jSPQC6KoDlFlznWEE8egS0iDaV8T8xDwi/WiQ/ka0bsGBZYOuUP3vf3YeWOq nZg0JDwoqsqhrn7ZzbU3d2Cfc2eSXam8OtkRkYPEKZZuqgVWDHUZMWwJg5luF8U+ojrd KaQPB6kzE7dHkITq3mvQocAsV8Z6d/37BLkQd3kRvkHiu4rJvH29OXc3stJ2ZXGzsD2Z IXGEvFiI5fDn2PQvrRr/t9ryUkw+hfYQ6ZkmUlKNlo6bEFmm+01f6VodUpUEb9vqqxkJ gmSR7DUzS2lCpxbVRMbws4BmCbNC0ThjbREiMwLb5+S+MalAuzIzlZ9zjyPKT0XYiltv MfFw== X-Gm-Message-State: APjAAAWPdqWt9GxjBJF6s+Bzck0biwKw6c2J2qjkiyp7n+1SvLoSLGBj 5rBI1BkyQS1uiKE3XvOZl/F+PXS/a8IVRm/nOa8= X-Google-Smtp-Source: APXvYqzndsNueQS92Xe4B1d71REsjlvqx9ynvD8CvVkru+ORVDr1gVmjag6dLc6gMBN+1fpeYUjla8YjTCCO/YsvQMA= X-Received: by 2002:adf:dd52:: with SMTP id u18mr3950790wrm.131.1575464228649; Wed, 04 Dec 2019 04:57:08 -0800 (PST) MIME-Version: 1.0 References: <20191204124816.1415359-1-colin.king@canonical.com> In-Reply-To: <20191204124816.1415359-1-colin.king@canonical.com> From: Daniel Baluta Date: Wed, 4 Dec 2019 14:56:57 +0200 Message-ID: To: Colin King Cc: Daniel Baluta , Pierre-Louis Bossart , Linux-ALSA , Linux Kernel Mailing List , Fabio Estevam , Sascha Hauer , kernel-janitors@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , linux-arm-kernel Subject: Re: [alsa-devel] [PATCH] ASoC: SOF: imx8: fix memory allocation failure check on priv->pd_dev X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Dec 4, 2019 at 2:49 PM Colin King wrote: > > From: Colin Ian King > > The memory allocation failure check for priv->pd_dev is incorrectly > pointer checking priv instead of priv->pd_dev. Fix this. > > Addresses-Coverity: ("Logically dead code") > Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support") > Signed-off-by: Colin Ian King Reviewed-by: Daniel Baluta Good catch! Thanks Colin! > --- > sound/soc/sof/imx/imx8.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/imx/imx8.c b/sound/soc/sof/imx/imx8.c > index cfefcfd92798..9d926b1df0d7 100644 > --- a/sound/soc/sof/imx/imx8.c > +++ b/sound/soc/sof/imx/imx8.c > @@ -209,7 +209,7 @@ static int imx8_probe(struct snd_sof_dev *sdev) > > priv->pd_dev = devm_kmalloc_array(&pdev->dev, priv->num_domains, > sizeof(*priv->pd_dev), GFP_KERNEL); > - if (!priv) > + if (!priv->pd_dev) > return -ENOMEM; > > priv->link = devm_kmalloc_array(&pdev->dev, priv->num_domains, > -- > 2.24.0 > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EB14C3F68F for ; Wed, 4 Dec 2019 12:57:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54BA12073C for ; Wed, 4 Dec 2019 12:57:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HRZjY6vQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CjK94ZRk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54BA12073C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=diQP0JO41q+RrhOTZyIPOh7iv+6AqD/OIzrZyW+7T/U=; b=HRZjY6vQPgOXNC Ys5inMcoyI4TMtAqlvby/1rqCC6dUbpQwEQ0+Ua7Os4zEIOWtdi/kFM0Oq6iDBr6+plAjn/WI2zXk /tYQHfMRKtcji3+leXaXmXMu/kShSQx25P8V5nKm5lhKCMFTv5xnV7pbGUU/jFZ9srjTX6eX9CXRH IzniEe5AAXP/rWmo4PayP+n0VNAyq7rKOXz4pv/urlKvqID2w3k+sPytkgC/UsC34LgVdm2em/bX0 /gFoqizhxyNYIkDV14tJxfZ18BkHgu8WkqSZJ8GgPf26qNS6GwYAgeMK/Qv8fjVje9/FSE6/n7kkz iGeseyPczz3Si/6RmTUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1icUDu-0001gb-QI; Wed, 04 Dec 2019 12:57:42 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1icUDO-0001Fp-U0 for linux-arm-kernel@lists.infradead.org; Wed, 04 Dec 2019 12:57:13 +0000 Received: by mail-wr1-x443.google.com with SMTP id w15so8505494wru.4 for ; Wed, 04 Dec 2019 04:57:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WX9DsnxjR1TLkIQAS0BjsZD23PSgQu93DSuzJlaRss8=; b=CjK94ZRk2M/LKqEEX5rm/3WkZf/HiI3Q+vVXDbZOZxQNFGaqW6DwTHkkkx84vRfS+M U4ORtkjPBA9iSMbi9wpu7YmMFTp+pNz3ylxcjalwvJv2KZQBId8X2noNPl++SsRNODK7 QHPvskaMNV5R762Lpb7nY4iTA+SdVhlMhJxfRgfvM6jxwD1ZNI97gcI1rUhzyzNaVE+Q k0Bc2/yGbWtp6U/eTSBRlksg5lobZN4iEcrEFCI2rqfgwYhIgxNwI1rIPCeNNltPaVVM rHvfdkl+vcc+QKkCwM59zcflNAcevYc8jww4nTJSaG3Zq6ZEE7D6XZBEvNXC3R/zck1W +j6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WX9DsnxjR1TLkIQAS0BjsZD23PSgQu93DSuzJlaRss8=; b=I7Z21o5Wtz4tuo9VDhlwUbZQkalyx6tzL8Tcg8bnIMzqDCOR3a5PGr6PLEmB+k1Vcn NpJwPDLtUdL+g4cporXJNoMAeBMX/wGNY1rsBO5BEQORMSm6jfCrNU1xkGOh9Ke9lS9B zoI6i2fQWnajaWxQgH/yxCgOwgz9QS7xJ7yhHXaiPxWrrsOICvDDi+Qo/G+WW83pJTbP Llb9rqDrq10TUUs3pKFKG67teZABqpNAhT2FFFljP+fd4L8oJdbJ4P28lqDyiAuTzoTy gAWTC3Cr+YzZFmAeYNacv1NIj3VCBLoUquXacpsINA7X55f/xNSk/k2lqSYouAnpsdjG 58vA== X-Gm-Message-State: APjAAAVcexMl6qBsHSZ6qWbi0QH3QYjymARtrPRGU3foDkPzDZ1CS7J2 wJDuZ4ltcNpsSmgvD7+mNt4rdPQRd4N9XRLMP6s= X-Google-Smtp-Source: APXvYqzndsNueQS92Xe4B1d71REsjlvqx9ynvD8CvVkru+ORVDr1gVmjag6dLc6gMBN+1fpeYUjla8YjTCCO/YsvQMA= X-Received: by 2002:adf:dd52:: with SMTP id u18mr3950790wrm.131.1575464228649; Wed, 04 Dec 2019 04:57:08 -0800 (PST) MIME-Version: 1.0 References: <20191204124816.1415359-1-colin.king@canonical.com> In-Reply-To: <20191204124816.1415359-1-colin.king@canonical.com> From: Daniel Baluta Date: Wed, 4 Dec 2019 14:56:57 +0200 Message-ID: Subject: Re: [PATCH] ASoC: SOF: imx8: fix memory allocation failure check on priv->pd_dev To: Colin King X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191204_045711_009627_8E2A60C0 X-CRM114-Status: GOOD ( 15.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Baluta , Pierre-Louis Bossart , Linux-ALSA , Linux Kernel Mailing List , Fabio Estevam , Sascha Hauer , kernel-janitors@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , NXP Linux Team , Pengutronix Kernel Team , Jaroslav Kysela , Shawn Guo , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 4, 2019 at 2:49 PM Colin King wrote: > > From: Colin Ian King > > The memory allocation failure check for priv->pd_dev is incorrectly > pointer checking priv instead of priv->pd_dev. Fix this. > > Addresses-Coverity: ("Logically dead code") > Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support") > Signed-off-by: Colin Ian King Reviewed-by: Daniel Baluta Good catch! Thanks Colin! > --- > sound/soc/sof/imx/imx8.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/imx/imx8.c b/sound/soc/sof/imx/imx8.c > index cfefcfd92798..9d926b1df0d7 100644 > --- a/sound/soc/sof/imx/imx8.c > +++ b/sound/soc/sof/imx/imx8.c > @@ -209,7 +209,7 @@ static int imx8_probe(struct snd_sof_dev *sdev) > > priv->pd_dev = devm_kmalloc_array(&pdev->dev, priv->num_domains, > sizeof(*priv->pd_dev), GFP_KERNEL); > - if (!priv) > + if (!priv->pd_dev) > return -ENOMEM; > > priv->link = devm_kmalloc_array(&pdev->dev, priv->num_domains, > -- > 2.24.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel