From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 023B0C3F2D7 for ; Tue, 3 Mar 2020 13:17:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C20E720842 for ; Tue, 3 Mar 2020 13:17:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuocMO5b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728963AbgCCNRf (ORCPT ); Tue, 3 Mar 2020 08:17:35 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:54545 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728124AbgCCNRf (ORCPT ); Tue, 3 Mar 2020 08:17:35 -0500 Received: by mail-wm1-f67.google.com with SMTP id i9so1733810wml.4; Tue, 03 Mar 2020 05:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x1haolJvTMTs4qAKKQpFP8pY7Ez4bO8I0NW3W3vGhjY=; b=OuocMO5bejjzlYN7dgw8I+8i7eYd2hQHN4Z6zRclkIyqy204aGYP9hBgL0OfmqkUs2 VwkGfDLA7OjW5W7CCKViNtEZZaKACTs29/be0YTbgm/2tmmJdc+zsgurpV68PSrI4n0y qZGu/h11pBgohxtCnuw9NS+/rL/fghbF5xQ9vGE6m3ZCWB4kYe1/SQko1ja8UCdmqBMb wMtj0pF8zR9m+qrZJof85tZdKOtQBz+s9o0hc2wRsHqnPExf3XHgaNSMhvoJxkLgV23j plKLYqojWrxfJGa8HkPldn1PPKxCakR7AHxQ8v1Qd88GfCwh9lu8b/GzjTgtAxKvVLgD qWIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x1haolJvTMTs4qAKKQpFP8pY7Ez4bO8I0NW3W3vGhjY=; b=gjspNOzcHZj56hjMed/8JCTBxZsPZwpCkIM7lgp/4uPNljMOpLKG23PiDi8c7VQGzw kmVUGdn8vlhkZGlXz23YIDt5SvsArRHgjn02dB3vMBJqOtdvtHs3w3+eROtKQb1LrzuC AgZWYREP4zY2MFxYoAY/xFjHhP3ngMhotxOYQrkOi6naU+ZDwQ/lJX01tRrCEV5EEQSN bi0tMn718w52MGdWq2nmvma9qlK2nMJdBHEWsREWlLg26S46aL8sOMk0fSoyhOt47xoq ClqUzO9yNJwiO6KrSYAOpIAjT7UQ3aR1Cu4gEfGQrbrhIJx1eIK/sOnAXzdF7u0mow/D 73nw== X-Gm-Message-State: ANhLgQ2Slm0ctOd3oKSXotO7GLcXNDMmzPivSscGjq7sayVWFBG1x7DM g19vBjvnXcuHGbRkbzmclbfxyvN5NtkjszSKuVM= X-Google-Smtp-Source: ADFU+vtrqxh9biAxeykoHsq+WDr8PQuEooauex3an4mdH3DhWCElhBl6tZ0babeoVFgVsf3/xOOvr2qyvHAvbWS8TDs= X-Received: by 2002:a1c:9e51:: with SMTP id h78mr4179705wme.44.1583241453088; Tue, 03 Mar 2020 05:17:33 -0800 (PST) MIME-Version: 1.0 References: <20200302205700.29746-1-daniel.baluta@oss.nxp.com> <20200302205700.29746-3-daniel.baluta@oss.nxp.com> In-Reply-To: From: Daniel Baluta Date: Tue, 3 Mar 2020 15:17:21 +0200 Message-ID: Subject: Re: [RFC PATCH 2/2] ASoC: SOF: Use multi PM domains helpers To: "Sridharan, Ranjani" Cc: Daniel Baluta , rjw@rjwysocki.net, "Brown, Len" , Pavel Machek , Aisheng Dong , Ulf Hansson , Fabio Estevam , Linux-ALSA , linux-pm@vger.kernel.org, Greg KH , Sascha Hauer , khilman@kernel.org, Ranjani Sridharan , Linux Kernel Mailing List , Daniel Baluta , Pierre-Louis Bossart , Paul Olaru , dl-linux-imx , Pengutronix Kernel Team , Shawn Guo , "S.j. Wang" , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 2, 2020 at 11:26 PM Sridharan, Ranjani wrote: > > > > On Mon, Mar 2, 2020 at 1:00 PM Daniel Baluta wrote: >> >> From: Daniel Baluta >> >> Use dev_multi_pm_attach / dev_multi_pm_detach instead of the hardcoded >> version. >> >> Signed-off-by: Daniel Baluta >> --- >> sound/soc/sof/imx/imx8.c | 54 +++++----------------------------------- >> 1 file changed, 6 insertions(+), 48 deletions(-) >> >> diff --git a/sound/soc/sof/imx/imx8.c b/sound/soc/sof/imx/imx8.c >> index b692752b2178..ca740538a2d5 100644 >> --- a/sound/soc/sof/imx/imx8.c >> +++ b/sound/soc/sof/imx/imx8.c >> @@ -51,10 +51,7 @@ struct imx8_priv { >> struct imx_sc_ipc *sc_ipc; >> >> /* Power domain handling */ >> - int num_domains; >> - struct device **pd_dev; >> - struct device_link **link; >> - >> + struct dev_multi_pm_domain_data *mpd; >> }; >> >> static void imx8_get_reply(struct snd_sof_dev *sdev) >> @@ -207,7 +204,6 @@ static int imx8_probe(struct snd_sof_dev *sdev) >> struct resource res; >> u32 base, size; >> int ret = 0; >> - int i; >> >> priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); >> if (!priv) >> @@ -218,39 +214,9 @@ static int imx8_probe(struct snd_sof_dev *sdev) >> priv->sdev = sdev; >> >> /* power up device associated power domains */ >> - priv->num_domains = of_count_phandle_with_args(np, "power-domains", >> - "#power-domain-cells"); >> - if (priv->num_domains < 0) { >> - dev_err(sdev->dev, "no power-domains property in %pOF\n", np); >> - return priv->num_domains; >> - } >> - >> - priv->pd_dev = devm_kmalloc_array(&pdev->dev, priv->num_domains, >> - sizeof(*priv->pd_dev), GFP_KERNEL); >> - if (!priv->pd_dev) >> - return -ENOMEM; >> - >> - priv->link = devm_kmalloc_array(&pdev->dev, priv->num_domains, >> - sizeof(*priv->link), GFP_KERNEL); >> - if (!priv->link) >> - return -ENOMEM; >> - >> - for (i = 0; i < priv->num_domains; i++) { >> - priv->pd_dev[i] = dev_pm_domain_attach_by_id(&pdev->dev, i); >> - if (IS_ERR(priv->pd_dev[i])) { >> - ret = PTR_ERR(priv->pd_dev[i]); >> - goto exit_unroll_pm; >> - } >> - priv->link[i] = device_link_add(&pdev->dev, priv->pd_dev[i], >> - DL_FLAG_STATELESS | >> - DL_FLAG_PM_RUNTIME | >> - DL_FLAG_RPM_ACTIVE); >> - if (!priv->link[i]) { >> - ret = -ENOMEM; >> - dev_pm_domain_detach(priv->pd_dev[i], false); >> - goto exit_unroll_pm; >> - } >> - } >> + priv->mpd = dev_multi_pm_attach(&pdev->dev); >> + if (IS_ERR(priv->mpd)) >> + return PTR_ERR(priv->mpd); >> >> ret = imx_scu_get_handle(&priv->sc_ipc); >> if (ret) { >> @@ -329,25 +295,17 @@ static int imx8_probe(struct snd_sof_dev *sdev) >> exit_pdev_unregister: >> platform_device_unregister(priv->ipc_dev); >> exit_unroll_pm: > > Can we also rename the label to exit_pm_detach maybe? It is no longer an unroll anymore right? Sure, will do in v2. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C833C3F2CD for ; Tue, 3 Mar 2020 13:18:31 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A82320848 for ; Tue, 3 Mar 2020 13:18:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="JnjpVyNx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuocMO5b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A82320848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DEE501669; Tue, 3 Mar 2020 14:17:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DEE501669 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1583241509; bh=65n561VtKXigdEgKq6a3V5RunbVkoTfwTsHNKg2JC6Q=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JnjpVyNxh+UAcMVFyOP61+JKNAiBbc3bysMYhgKbL04ax7jXCfTv+SyrXedModd9n Anptd6K8h6MNYrVGmLI1O70ZuRkTnB+YtHQ79gVtSuq44tWNXfsWITQzi7jGan/0Vi uYR62edb1PvHp+pO3/W0BxFf69PlWCtBB5AsWwFg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5054CF80245; Tue, 3 Mar 2020 14:17:38 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E3A8DF8025F; Tue, 3 Mar 2020 14:17:36 +0100 (CET) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 30892F80131 for ; Tue, 3 Mar 2020 14:17:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 30892F80131 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuocMO5b" Received: by mail-wm1-x341.google.com with SMTP id 6so3133586wmi.5 for ; Tue, 03 Mar 2020 05:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x1haolJvTMTs4qAKKQpFP8pY7Ez4bO8I0NW3W3vGhjY=; b=OuocMO5bejjzlYN7dgw8I+8i7eYd2hQHN4Z6zRclkIyqy204aGYP9hBgL0OfmqkUs2 VwkGfDLA7OjW5W7CCKViNtEZZaKACTs29/be0YTbgm/2tmmJdc+zsgurpV68PSrI4n0y qZGu/h11pBgohxtCnuw9NS+/rL/fghbF5xQ9vGE6m3ZCWB4kYe1/SQko1ja8UCdmqBMb wMtj0pF8zR9m+qrZJof85tZdKOtQBz+s9o0hc2wRsHqnPExf3XHgaNSMhvoJxkLgV23j plKLYqojWrxfJGa8HkPldn1PPKxCakR7AHxQ8v1Qd88GfCwh9lu8b/GzjTgtAxKvVLgD qWIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x1haolJvTMTs4qAKKQpFP8pY7Ez4bO8I0NW3W3vGhjY=; b=ttVaVzLjW4urkvAUPqjqkk7jyJxP9ma7xbjFcXak7bMAzdLd2+NonC+AONHA6wXKGt qHmhsThGkieeafhbPz2sBiQ/okkEuFMcXwbAWj6sagI1ljx1KfBuhmJxlDLOdz9W/cVS +bvXtHDDAZFodQVt6VNwppO9YFg8Oju3xnHtFFCZfsuHw8PDNGKjsvQvjaa27ZhBsL5A EWN/xK/S833aQykg2TdCzAn/oO2VY4DGy4cgH7LDWROmxmBVWRwYafXT5xkx280cw1hq VIGBBCqv13IToZmS6rA4ye5oEpNfaQdM0P/M7Nx1qLiMvR2v5sAr98HJBHNw8f8v4nMG CwZw== X-Gm-Message-State: ANhLgQ0z8u2GyEM7VjDJqLYBNt0p87CXLf3aLWFIBbo+T+MlBUI5ROnx T9LVOWkR4MS82Khzk9Ll4qORJcOM9UyDPUPcwvA= X-Google-Smtp-Source: ADFU+vtrqxh9biAxeykoHsq+WDr8PQuEooauex3an4mdH3DhWCElhBl6tZ0babeoVFgVsf3/xOOvr2qyvHAvbWS8TDs= X-Received: by 2002:a1c:9e51:: with SMTP id h78mr4179705wme.44.1583241453088; Tue, 03 Mar 2020 05:17:33 -0800 (PST) MIME-Version: 1.0 References: <20200302205700.29746-1-daniel.baluta@oss.nxp.com> <20200302205700.29746-3-daniel.baluta@oss.nxp.com> In-Reply-To: From: Daniel Baluta Date: Tue, 3 Mar 2020 15:17:21 +0200 Message-ID: Subject: Re: [RFC PATCH 2/2] ASoC: SOF: Use multi PM domains helpers To: "Sridharan, Ranjani" Content-Type: text/plain; charset="UTF-8" Cc: Ulf Hansson , Daniel Baluta , Linux-ALSA , Pierre-Louis Bossart , Pavel Machek , Fabio Estevam , khilman@kernel.org, Ranjani Sridharan , dl-linux-imx , "Brown, Len" , linux-pm@vger.kernel.org, Sascha Hauer , Paul Olaru , Daniel Baluta , linux-arm-kernel , Aisheng Dong , Greg KH , "S.j. Wang" , rjw@rjwysocki.net, Linux Kernel Mailing List , Pengutronix Kernel Team , Shawn Guo X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Mar 2, 2020 at 11:26 PM Sridharan, Ranjani wrote: > > > > On Mon, Mar 2, 2020 at 1:00 PM Daniel Baluta wrote: >> >> From: Daniel Baluta >> >> Use dev_multi_pm_attach / dev_multi_pm_detach instead of the hardcoded >> version. >> >> Signed-off-by: Daniel Baluta >> --- >> sound/soc/sof/imx/imx8.c | 54 +++++----------------------------------- >> 1 file changed, 6 insertions(+), 48 deletions(-) >> >> diff --git a/sound/soc/sof/imx/imx8.c b/sound/soc/sof/imx/imx8.c >> index b692752b2178..ca740538a2d5 100644 >> --- a/sound/soc/sof/imx/imx8.c >> +++ b/sound/soc/sof/imx/imx8.c >> @@ -51,10 +51,7 @@ struct imx8_priv { >> struct imx_sc_ipc *sc_ipc; >> >> /* Power domain handling */ >> - int num_domains; >> - struct device **pd_dev; >> - struct device_link **link; >> - >> + struct dev_multi_pm_domain_data *mpd; >> }; >> >> static void imx8_get_reply(struct snd_sof_dev *sdev) >> @@ -207,7 +204,6 @@ static int imx8_probe(struct snd_sof_dev *sdev) >> struct resource res; >> u32 base, size; >> int ret = 0; >> - int i; >> >> priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); >> if (!priv) >> @@ -218,39 +214,9 @@ static int imx8_probe(struct snd_sof_dev *sdev) >> priv->sdev = sdev; >> >> /* power up device associated power domains */ >> - priv->num_domains = of_count_phandle_with_args(np, "power-domains", >> - "#power-domain-cells"); >> - if (priv->num_domains < 0) { >> - dev_err(sdev->dev, "no power-domains property in %pOF\n", np); >> - return priv->num_domains; >> - } >> - >> - priv->pd_dev = devm_kmalloc_array(&pdev->dev, priv->num_domains, >> - sizeof(*priv->pd_dev), GFP_KERNEL); >> - if (!priv->pd_dev) >> - return -ENOMEM; >> - >> - priv->link = devm_kmalloc_array(&pdev->dev, priv->num_domains, >> - sizeof(*priv->link), GFP_KERNEL); >> - if (!priv->link) >> - return -ENOMEM; >> - >> - for (i = 0; i < priv->num_domains; i++) { >> - priv->pd_dev[i] = dev_pm_domain_attach_by_id(&pdev->dev, i); >> - if (IS_ERR(priv->pd_dev[i])) { >> - ret = PTR_ERR(priv->pd_dev[i]); >> - goto exit_unroll_pm; >> - } >> - priv->link[i] = device_link_add(&pdev->dev, priv->pd_dev[i], >> - DL_FLAG_STATELESS | >> - DL_FLAG_PM_RUNTIME | >> - DL_FLAG_RPM_ACTIVE); >> - if (!priv->link[i]) { >> - ret = -ENOMEM; >> - dev_pm_domain_detach(priv->pd_dev[i], false); >> - goto exit_unroll_pm; >> - } >> - } >> + priv->mpd = dev_multi_pm_attach(&pdev->dev); >> + if (IS_ERR(priv->mpd)) >> + return PTR_ERR(priv->mpd); >> >> ret = imx_scu_get_handle(&priv->sc_ipc); >> if (ret) { >> @@ -329,25 +295,17 @@ static int imx8_probe(struct snd_sof_dev *sdev) >> exit_pdev_unregister: >> platform_device_unregister(priv->ipc_dev); >> exit_unroll_pm: > > Can we also rename the label to exit_pm_detach maybe? It is no longer an unroll anymore right? Sure, will do in v2. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77DDDC3F2CD for ; Tue, 3 Mar 2020 13:17:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4850A20842 for ; Tue, 3 Mar 2020 13:17:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ij5caky/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuocMO5b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4850A20842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W90b2UQ1+UjKUNDAz3QaZTNBydzAk0s4BdCJw4Mhkgk=; b=Ij5caky/ww7hN/ b5OMGcxpMywcMwsl85+Iu0dTEOz0JAxwmov6dsvBG/iqNIDEh77B+AyqEAPPBQBEf9dc+lf1pu64T xA2BkwfuVAUR9xwUINhupvCUvAjVN/FiWdriHsDfD1B5/owhY4j5BQJy6PYVbiwCC3cR5ZZ4YlJA8 +HB9YFjkf5TZ6ax8fTAnWhR+xqFqaPpAIZ+yNc2K6nW67kz9UC6UfXBUai5zF5VB2JJB2/hSk7vsY MkgQ7fKP/txbM6qO/udXtPy9PE29vPl/b28Xskx+63ME1gN1kA0I77tGiu6lGr+Je+L2EN+7eea44 gTsOP+Q8VcKBmdu+9Qag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j97QX-0004Fl-Ji; Tue, 03 Mar 2020 13:17:37 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j97QU-0004F9-S9 for linux-arm-kernel@lists.infradead.org; Tue, 03 Mar 2020 13:17:36 +0000 Received: by mail-wm1-x341.google.com with SMTP id g134so1788344wme.3 for ; Tue, 03 Mar 2020 05:17:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x1haolJvTMTs4qAKKQpFP8pY7Ez4bO8I0NW3W3vGhjY=; b=OuocMO5bejjzlYN7dgw8I+8i7eYd2hQHN4Z6zRclkIyqy204aGYP9hBgL0OfmqkUs2 VwkGfDLA7OjW5W7CCKViNtEZZaKACTs29/be0YTbgm/2tmmJdc+zsgurpV68PSrI4n0y qZGu/h11pBgohxtCnuw9NS+/rL/fghbF5xQ9vGE6m3ZCWB4kYe1/SQko1ja8UCdmqBMb wMtj0pF8zR9m+qrZJof85tZdKOtQBz+s9o0hc2wRsHqnPExf3XHgaNSMhvoJxkLgV23j plKLYqojWrxfJGa8HkPldn1PPKxCakR7AHxQ8v1Qd88GfCwh9lu8b/GzjTgtAxKvVLgD qWIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x1haolJvTMTs4qAKKQpFP8pY7Ez4bO8I0NW3W3vGhjY=; b=XXbcPxr+1d2+QqE96wwGHT5sIOnEyzeyimdYMR5iNEocUyS/tfN4P2BXlKin5LRsP5 mPx8pWd+hnOJOIymXsZJkMJH8ApB/u+ReDyvhJFggerWgU2L6Br2LSwSspfZzk747g3H wS5o94trbgZQm4oGm0qq4RwAKHdyZXnZ+tGCQqA5Yjrd2+Usrxl61SF59aV8XS2TTyT9 uWdTrzZ/juwlmdOHoif379i1dt3wrl8WPmVGFqhG4FwNrBKr+Rb5DyxX5cr+Xa8QOSMm z7mYUfHcqBrUFaDermJBuJHYHHTvZj5u+nwh3ibhfXm/E7W0hb7hx3jVSThKOPRyep7N q/mg== X-Gm-Message-State: ANhLgQ2McatdolLl0e8Y/jSHGn22GN+wbQBhY3skp7c35IVNZWwV+nBu yxnmiChSvTctCl+Udfe+4PEHBN+oEJtf/T1sgMuAI4kIgro= X-Google-Smtp-Source: ADFU+vtrqxh9biAxeykoHsq+WDr8PQuEooauex3an4mdH3DhWCElhBl6tZ0babeoVFgVsf3/xOOvr2qyvHAvbWS8TDs= X-Received: by 2002:a1c:9e51:: with SMTP id h78mr4179705wme.44.1583241453088; Tue, 03 Mar 2020 05:17:33 -0800 (PST) MIME-Version: 1.0 References: <20200302205700.29746-1-daniel.baluta@oss.nxp.com> <20200302205700.29746-3-daniel.baluta@oss.nxp.com> In-Reply-To: From: Daniel Baluta Date: Tue, 3 Mar 2020 15:17:21 +0200 Message-ID: Subject: Re: [RFC PATCH 2/2] ASoC: SOF: Use multi PM domains helpers To: "Sridharan, Ranjani" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200303_051734_941493_7B7C797D X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Daniel Baluta , Linux-ALSA , Pierre-Louis Bossart , Pavel Machek , Fabio Estevam , khilman@kernel.org, Ranjani Sridharan , dl-linux-imx , "Brown, Len" , linux-pm@vger.kernel.org, Sascha Hauer , Paul Olaru , Daniel Baluta , linux-arm-kernel , Aisheng Dong , Greg KH , "S.j. Wang" , rjw@rjwysocki.net, Linux Kernel Mailing List , Pengutronix Kernel Team , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 2, 2020 at 11:26 PM Sridharan, Ranjani wrote: > > > > On Mon, Mar 2, 2020 at 1:00 PM Daniel Baluta wrote: >> >> From: Daniel Baluta >> >> Use dev_multi_pm_attach / dev_multi_pm_detach instead of the hardcoded >> version. >> >> Signed-off-by: Daniel Baluta >> --- >> sound/soc/sof/imx/imx8.c | 54 +++++----------------------------------- >> 1 file changed, 6 insertions(+), 48 deletions(-) >> >> diff --git a/sound/soc/sof/imx/imx8.c b/sound/soc/sof/imx/imx8.c >> index b692752b2178..ca740538a2d5 100644 >> --- a/sound/soc/sof/imx/imx8.c >> +++ b/sound/soc/sof/imx/imx8.c >> @@ -51,10 +51,7 @@ struct imx8_priv { >> struct imx_sc_ipc *sc_ipc; >> >> /* Power domain handling */ >> - int num_domains; >> - struct device **pd_dev; >> - struct device_link **link; >> - >> + struct dev_multi_pm_domain_data *mpd; >> }; >> >> static void imx8_get_reply(struct snd_sof_dev *sdev) >> @@ -207,7 +204,6 @@ static int imx8_probe(struct snd_sof_dev *sdev) >> struct resource res; >> u32 base, size; >> int ret = 0; >> - int i; >> >> priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); >> if (!priv) >> @@ -218,39 +214,9 @@ static int imx8_probe(struct snd_sof_dev *sdev) >> priv->sdev = sdev; >> >> /* power up device associated power domains */ >> - priv->num_domains = of_count_phandle_with_args(np, "power-domains", >> - "#power-domain-cells"); >> - if (priv->num_domains < 0) { >> - dev_err(sdev->dev, "no power-domains property in %pOF\n", np); >> - return priv->num_domains; >> - } >> - >> - priv->pd_dev = devm_kmalloc_array(&pdev->dev, priv->num_domains, >> - sizeof(*priv->pd_dev), GFP_KERNEL); >> - if (!priv->pd_dev) >> - return -ENOMEM; >> - >> - priv->link = devm_kmalloc_array(&pdev->dev, priv->num_domains, >> - sizeof(*priv->link), GFP_KERNEL); >> - if (!priv->link) >> - return -ENOMEM; >> - >> - for (i = 0; i < priv->num_domains; i++) { >> - priv->pd_dev[i] = dev_pm_domain_attach_by_id(&pdev->dev, i); >> - if (IS_ERR(priv->pd_dev[i])) { >> - ret = PTR_ERR(priv->pd_dev[i]); >> - goto exit_unroll_pm; >> - } >> - priv->link[i] = device_link_add(&pdev->dev, priv->pd_dev[i], >> - DL_FLAG_STATELESS | >> - DL_FLAG_PM_RUNTIME | >> - DL_FLAG_RPM_ACTIVE); >> - if (!priv->link[i]) { >> - ret = -ENOMEM; >> - dev_pm_domain_detach(priv->pd_dev[i], false); >> - goto exit_unroll_pm; >> - } >> - } >> + priv->mpd = dev_multi_pm_attach(&pdev->dev); >> + if (IS_ERR(priv->mpd)) >> + return PTR_ERR(priv->mpd); >> >> ret = imx_scu_get_handle(&priv->sc_ipc); >> if (ret) { >> @@ -329,25 +295,17 @@ static int imx8_probe(struct snd_sof_dev *sdev) >> exit_pdev_unregister: >> platform_device_unregister(priv->ipc_dev); >> exit_unroll_pm: > > Can we also rename the label to exit_pm_detach maybe? It is no longer an unroll anymore right? Sure, will do in v2. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel