From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B038EC76188 for ; Fri, 19 Jul 2019 06:34:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E8582173B for ; Fri, 19 Jul 2019 06:34:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QSOwOufE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726883AbfGSGet (ORCPT ); Fri, 19 Jul 2019 02:34:49 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:35060 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbfGSGes (ORCPT ); Fri, 19 Jul 2019 02:34:48 -0400 Received: by mail-wr1-f67.google.com with SMTP id y4so31062318wrm.2; Thu, 18 Jul 2019 23:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kMcKTsEVyji+n2fYLtlne8FEnWZcMA2/ktkd0SxT+VI=; b=QSOwOufE4zhKaOthPkDk7gWdX3qwYegZikq56s0mkeTwW5vSbnTSAff0lcnACu34zb vdRjrjSoxzugWQ5xieksmi9CByUQ5AnlvJvPceiVK6Sma4J2CcItR6GSqE/+xv2rjim9 hszdEfhJIQs0Cvwusfs52LSo1AccmTUPJozjSty8KUF6cjhaQHqgQxUAgI0dd8a4xTnH BZ8cKAEWJkxNC2IOVZ6nJ+kTlghlY5buBFzyqooQ2Jiy3cOwUPAYOLNzB/9wFrTNfb72 p9dkMyMTd4O6yToPz/j1GJ9UScDq+CL+Hi80pQVbp5CH5uBdZp0mNnDg/VSEYBXXVgOE ehYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kMcKTsEVyji+n2fYLtlne8FEnWZcMA2/ktkd0SxT+VI=; b=BILJIDFTiLJd6KQpuJOQE9102mtBhs0Gesstd355vEv53pVH5YpninYpuzepLU6/IK 5qx9irZVuyVpmP6sP65zYReupDmBrFUjWdeG8Sf7qSDk6poCR4pUBrtRC618QuWrnY9Y 9FdAkTAliSbif+WcdO38zFv/SzRv9r6Wn+f5dH1SHSg87UzteIi+PSgMqemtVNRbhqq3 YP4+L+qOsSaXNKcVgq/mj0oX6pYHnK1oYWPWkBfTLPRIepIoKlbhY2qBxtuFeT0QgUtq JS8OPQ92ASJfRMRWhf3o35X2F/dCZzoHLQnVKXOHHHZyvYZiF6l+JeXE9GVu/MSXnHZ5 Nx1Q== X-Gm-Message-State: APjAAAUTuxFSwkXPusqmSGYuT4NSCRlEa+4gaKO9tspXTaUbOnR7biK8 lTq5yylCqjo3tcrihqOS+HpQsdYAjL/auJCOiB4= X-Google-Smtp-Source: APXvYqzkF6gS1MNZBLZ1Ty1LQtpQfLnkNKW7cn72gR9MP8uHzDu7PJQxe2xQB/GaBTVdYHWPDS52KzZOIEH2mFQtBgM= X-Received: by 2002:a05:6000:14b:: with SMTP id r11mr54574650wrx.196.1563518086309; Thu, 18 Jul 2019 23:34:46 -0700 (PDT) MIME-Version: 1.0 References: <20190718151346.3523-1-daniel.baluta@nxp.com> <20190718151346.3523-4-daniel.baluta@nxp.com> In-Reply-To: From: Daniel Baluta Date: Fri, 19 Jul 2019 09:34:34 +0300 Message-ID: Subject: Re: [PATCH 3/3] dt-bindings: dsp: fsl: Add DSP core binding support To: Leonard Crestez Cc: Rob Herring , Daniel Baluta , Shawn Guo , Mark Rutland , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , "S.j. Wang" , Paul Olaru , Aisheng Dong , Anson Huang , Peng Fan , Frank Li , Devicetree List , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , "sound-open-firmware@alsa-project.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 18, 2019 at 9:40 PM Leonard Crestez wrote: > > On 18.07.2019 21:24, Daniel Baluta wrote: > > On Thu, Jul 18, 2019 at 7:41 PM Rob Herring wrote: > >> > >> On Thu, Jul 18, 2019 at 9:13 AM Daniel Baluta wrote: > >>> > >>> This describes the DSP device tree node. > >>> > >>> Signed-off-by: Daniel Baluta > > >>> + power-domains: > >>> + description: > >>> + List of phandle and PM domain specifier as documented in > >>> + Documentation/devicetree/bindings/power/power_domain.txt > >> > >> How many? 4? > > > > Yes, 4 for i.MX8QXP. Also, the same number is for i.MX8QM. Anyhow, I didn't > > added added a limit here because I really don't know how many will be > > in upcoming i.MX platforms. > > Which 4? It might help to use power-domain-names explicitly just like > it's done for clocks and mboxes. > > This is very common for phandle lists. 4 like in the example at the bottom of the patch: + power-domains = <&pd IMX_SC_R_MU_13A>, + <&pd IMX_SC_R_MU_13B>, + <&pd IMX_SC_R_DSP>, + <&pd IMX_SC_R_DSP_RAM>; Not sure if it makes sense to use power-domain-names as the driver parses directly the "power-domains" property. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Baluta Subject: Re: [PATCH 3/3] dt-bindings: dsp: fsl: Add DSP core binding support Date: Fri, 19 Jul 2019 09:34:34 +0300 Message-ID: References: <20190718151346.3523-1-daniel.baluta@nxp.com> <20190718151346.3523-4-daniel.baluta@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Leonard Crestez Cc: Mark Rutland , Aisheng Dong , Peng Fan , Fabio Estevam , Anson Huang , Devicetree List , Daniel Baluta , Sascha Hauer , Frank Li , "linux-kernel@vger.kernel.org" , Paul Olaru , Rob Herring , dl-linux-imx , Sascha Hauer , Shawn Guo , "S.j. Wang" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "sound-open-firmware@alsa-project.org" List-Id: devicetree@vger.kernel.org On Thu, Jul 18, 2019 at 9:40 PM Leonard Crestez wrote: > > On 18.07.2019 21:24, Daniel Baluta wrote: > > On Thu, Jul 18, 2019 at 7:41 PM Rob Herring wrote: > >> > >> On Thu, Jul 18, 2019 at 9:13 AM Daniel Baluta wrote: > >>> > >>> This describes the DSP device tree node. > >>> > >>> Signed-off-by: Daniel Baluta > > >>> + power-domains: > >>> + description: > >>> + List of phandle and PM domain specifier as documented in > >>> + Documentation/devicetree/bindings/power/power_domain.txt > >> > >> How many? 4? > > > > Yes, 4 for i.MX8QXP. Also, the same number is for i.MX8QM. Anyhow, I didn't > > added added a limit here because I really don't know how many will be > > in upcoming i.MX platforms. > > Which 4? It might help to use power-domain-names explicitly just like > it's done for clocks and mboxes. > > This is very common for phandle lists. 4 like in the example at the bottom of the patch: + power-domains = <&pd IMX_SC_R_MU_13A>, + <&pd IMX_SC_R_MU_13B>, + <&pd IMX_SC_R_DSP>, + <&pd IMX_SC_R_DSP_RAM>; Not sure if it makes sense to use power-domain-names as the driver parses directly the "power-domains" property. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52737C76188 for ; Fri, 19 Jul 2019 06:34:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 196962173B for ; Fri, 19 Jul 2019 06:34:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OyqxJina"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QSOwOufE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 196962173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SYfz1sAgZi60eoPUUcAWl6oPf6BQu+USdfYLNstCGEs=; b=OyqxJina7dYJ60 r9zTmFehNxDAVOZoymasqReU9karZoTK9LdURdn7QEWTQyBrtqs1pibbMqbfkWFIyoN53/yQVxPpc yzv418xTLeqUOMnafkMR8WqcnRW4/QPcVqvKTnFsbKM4ka4zdLlDQsJD5eJUZm3/vBsw4iKBav/k9 XOQL0pa7wpTb6o3PATgTY55O3t2y5wdQTIhDY01gEXgd/WqjKB3z5FYEXpiUpGZe+sZndFaBvX1C0 s6dVPcjN/ydvKHDyY5jNQOp1Cm0JnDbQK71N5qcXSlhj4kmmYly26JLJWfIHKTPSY38RAR2NXBDJl IMnkbyCI/GnncdAkyuqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hoMTm-0002r8-O1; Fri, 19 Jul 2019 06:34:54 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hoMTj-0002qI-BM for linux-arm-kernel@lists.infradead.org; Fri, 19 Jul 2019 06:34:52 +0000 Received: by mail-wr1-x441.google.com with SMTP id n4so31097806wrs.3 for ; Thu, 18 Jul 2019 23:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kMcKTsEVyji+n2fYLtlne8FEnWZcMA2/ktkd0SxT+VI=; b=QSOwOufE4zhKaOthPkDk7gWdX3qwYegZikq56s0mkeTwW5vSbnTSAff0lcnACu34zb vdRjrjSoxzugWQ5xieksmi9CByUQ5AnlvJvPceiVK6Sma4J2CcItR6GSqE/+xv2rjim9 hszdEfhJIQs0Cvwusfs52LSo1AccmTUPJozjSty8KUF6cjhaQHqgQxUAgI0dd8a4xTnH BZ8cKAEWJkxNC2IOVZ6nJ+kTlghlY5buBFzyqooQ2Jiy3cOwUPAYOLNzB/9wFrTNfb72 p9dkMyMTd4O6yToPz/j1GJ9UScDq+CL+Hi80pQVbp5CH5uBdZp0mNnDg/VSEYBXXVgOE ehYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kMcKTsEVyji+n2fYLtlne8FEnWZcMA2/ktkd0SxT+VI=; b=A6gpMgUSPaJVJsmoPvOr5idBvMN20K80ivhskoe3XRPb7ry6WW8lXT5yQez6ZIFTfh LwrUvg7BBekRyb1UuOA5Gy14H3fOlPeJsJl6LGurZFwWBnuC3Y0SfpjToKiRUH0DyaF8 Qqc2tVgIGx1+9nQK8Y8h+OdBj8OgmyHklXmHD3BmqzBdT7frNgjqo+8kTxgidoS0Ew0O Oo8om54K0zsCyckNzt8zIFBYu1lT9PIsLfme+XdEHFOwkdLrfqVgwBiGmobPCp6FZPPo Xz6Hdh0ImI/rgwIe1R6ZNMDOhArS4DKvhMXSkOjDvaRvgmw5UIg10XhsXQs1wqLTSiBT 9orQ== X-Gm-Message-State: APjAAAV63y/7l4o1Yqp03g1QKP6jwvfPEsek0ZbJXF3MBlcSK/6Iv7zW w3QotGjbXxzsh/EZUSrBtf2A7AUR1KgSf2Hnk8k= X-Google-Smtp-Source: APXvYqzkF6gS1MNZBLZ1Ty1LQtpQfLnkNKW7cn72gR9MP8uHzDu7PJQxe2xQB/GaBTVdYHWPDS52KzZOIEH2mFQtBgM= X-Received: by 2002:a05:6000:14b:: with SMTP id r11mr54574650wrx.196.1563518086309; Thu, 18 Jul 2019 23:34:46 -0700 (PDT) MIME-Version: 1.0 References: <20190718151346.3523-1-daniel.baluta@nxp.com> <20190718151346.3523-4-daniel.baluta@nxp.com> In-Reply-To: From: Daniel Baluta Date: Fri, 19 Jul 2019 09:34:34 +0300 Message-ID: Subject: Re: [PATCH 3/3] dt-bindings: dsp: fsl: Add DSP core binding support To: Leonard Crestez X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190718_233451_394549_D6B61685 X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Aisheng Dong , Peng Fan , Fabio Estevam , Anson Huang , Devicetree List , Daniel Baluta , Sascha Hauer , Frank Li , "linux-kernel@vger.kernel.org" , Paul Olaru , Rob Herring , dl-linux-imx , Sascha Hauer , Shawn Guo , "S.j. Wang" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "sound-open-firmware@alsa-project.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 18, 2019 at 9:40 PM Leonard Crestez wrote: > > On 18.07.2019 21:24, Daniel Baluta wrote: > > On Thu, Jul 18, 2019 at 7:41 PM Rob Herring wrote: > >> > >> On Thu, Jul 18, 2019 at 9:13 AM Daniel Baluta wrote: > >>> > >>> This describes the DSP device tree node. > >>> > >>> Signed-off-by: Daniel Baluta > > >>> + power-domains: > >>> + description: > >>> + List of phandle and PM domain specifier as documented in > >>> + Documentation/devicetree/bindings/power/power_domain.txt > >> > >> How many? 4? > > > > Yes, 4 for i.MX8QXP. Also, the same number is for i.MX8QM. Anyhow, I didn't > > added added a limit here because I really don't know how many will be > > in upcoming i.MX platforms. > > Which 4? It might help to use power-domain-names explicitly just like > it's done for clocks and mboxes. > > This is very common for phandle lists. 4 like in the example at the bottom of the patch: + power-domains = <&pd IMX_SC_R_MU_13A>, + <&pd IMX_SC_R_MU_13B>, + <&pd IMX_SC_R_DSP>, + <&pd IMX_SC_R_DSP_RAM>; Not sure if it makes sense to use power-domain-names as the driver parses directly the "power-domains" property. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel