From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB3BDC43603 for ; Thu, 5 Dec 2019 08:44:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 970EB224F8 for ; Thu, 5 Dec 2019 08:44:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U2VSti3x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728921AbfLEIoB (ORCPT ); Thu, 5 Dec 2019 03:44:01 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:51186 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbfLEIoA (ORCPT ); Thu, 5 Dec 2019 03:44:00 -0500 Received: by mail-wm1-f68.google.com with SMTP id p9so2688661wmg.0 for ; Thu, 05 Dec 2019 00:43:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lU1EvzM/eLD0n0vZaZM7AMkwMVY8sZSz0h3WsdV8t0E=; b=U2VSti3xVYS3TZPRfEbXKHUduQrzXSc5f+w1SuhjId7MWQwy7oOm4AD/MgMfRrvBTD 8BVTycGLuJp8sE6OQ+FG0TCjsXTjRI964j4m5fup+dxVQ1Mlsa/+9p6kWM4HQEUnLUPB jDoOpTvvmLrggMmDLQIrbrpt5LlAn6GbQjyJzvu+gdCJX+gp30vQL38CMQoJbw+vSUBh vzqWSDfZ60M9svZzy8bab7AWE7X0RDQRXDUrvfoAx35v2NKnCNG3v2WH50/J0oJuj6Vy N0t0vFI5R42CNnD2QpW2oIE8fwT3iMnetrtWzEp9GEPetG4/UuqNqfJVlZQZR3k3ONod jj8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lU1EvzM/eLD0n0vZaZM7AMkwMVY8sZSz0h3WsdV8t0E=; b=hyV8wOfOCk6mocJT0YaKtG9rLPAMRxuv4uzK8QnRNqnZxi73kOVoinuLT/mV6RgcAA fRZ7b37qV3n/Q9c/keES17hX388y9jdnZvXgU0JpD7ZxV8KXqMBfx63gsSpQLLDx1NlP IYAMjbPiogw1iOD4EJpqkoeHPB2393FH6JJ19+K78DmKAbJTfRI+JSM2RoxTZWpsfawi mDzcw8cPvJYWLJdUfIz2N+sLVLiM+NLxn4//FMXi1Id5OBAZZ8BAVL9iMHZ7g3R3gZyh Yv7i9pibCsbVEldSoSrzPfFaty0HKSqIRqie9DUD2i8bWCTz2J8FnznhXpSo/DPj2O5d WxoQ== X-Gm-Message-State: APjAAAVWnyW60CqTwRedrE0ryLPgG3TrpNnp97R8olcGW0JJ4jVOcL1M 1gMLOqWZCjnOxcqem5/TSu9ZkwYRqyUiYiLFUZI= X-Google-Smtp-Source: APXvYqzHaKRUEfbiAOswMp49ewBcixg21LL6YP05PzNudQhdouGxpQM6W2U/QiJNtYTg+vZqQcCAgBCV7oa+geJPtRg= X-Received: by 2002:a1c:4944:: with SMTP id w65mr3776661wma.39.1575535439089; Thu, 05 Dec 2019 00:43:59 -0800 (PST) MIME-Version: 1.0 References: <20191128223802.18228-1-michael@walle.cc> In-Reply-To: <20191128223802.18228-1-michael@walle.cc> From: Daniel Baluta Date: Thu, 5 Dec 2019 10:43:46 +0200 Message-ID: Subject: Re: [PATCH] ASoC: fsl_sai: add IRQF_SHARED To: Michael Walle Cc: Linux-ALSA , linuxppc-dev@lists.ozlabs.org, Linux Kernel Mailing List , Timur Tabi , Nicolin Chen , Xiubo Li , Fabio Estevam , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 29, 2019 at 12:40 AM Michael Walle wrote: > > The LS1028A SoC uses the same interrupt line for adjacent SAIs. Use > IRQF_SHARED to be able to use these SAIs simultaneously. Hi Michael, Thanks for the patch. We have a similar change inside our internal tree (it is on my long TODO list to upstream :D). We add the shared flag conditionally on a dts property. Do you think it is a good idea to always add shared flag? I'm thinking on SAI IP integrations where the interrupt is edge triggered. AFAIK edge triggered interrupts do not get along very well with sharing an interrupt line. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5AC5C43603 for ; Thu, 5 Dec 2019 08:44:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E400D24249 for ; Thu, 5 Dec 2019 08:44:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="SGYSw/lg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U2VSti3x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E400D24249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D6234165E; Thu, 5 Dec 2019 09:44:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D6234165E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1575535496; bh=+asvy3zR9la2+sz5/5YZ9uK4awG6uyAmOHCSrCZitmg=; h=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=SGYSw/lgs38hbJyH7mJru/xsBf9+PJ5tT9N8rE3rXXGS6z52kHkWBMpbvxpZwiwTJ JNSKqes5q+crCdxIvYy1fG2eFmanSlbs4EAMmi93qtcIfeCz81iijZ2HWFLHcTqATx K3igB0gG/URhQgYJvMyBgUkSxNGJ3Q/iI6HT0iYI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 55355F8015A; Thu, 5 Dec 2019 09:44:05 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 63A15F800B4; Thu, 5 Dec 2019 09:44:03 +0100 (CET) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3845DF800B4 for ; Thu, 5 Dec 2019 09:43:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3845DF800B4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U2VSti3x" Received: by mail-wm1-x344.google.com with SMTP id t14so2647009wmi.5 for ; Thu, 05 Dec 2019 00:43:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lU1EvzM/eLD0n0vZaZM7AMkwMVY8sZSz0h3WsdV8t0E=; b=U2VSti3xVYS3TZPRfEbXKHUduQrzXSc5f+w1SuhjId7MWQwy7oOm4AD/MgMfRrvBTD 8BVTycGLuJp8sE6OQ+FG0TCjsXTjRI964j4m5fup+dxVQ1Mlsa/+9p6kWM4HQEUnLUPB jDoOpTvvmLrggMmDLQIrbrpt5LlAn6GbQjyJzvu+gdCJX+gp30vQL38CMQoJbw+vSUBh vzqWSDfZ60M9svZzy8bab7AWE7X0RDQRXDUrvfoAx35v2NKnCNG3v2WH50/J0oJuj6Vy N0t0vFI5R42CNnD2QpW2oIE8fwT3iMnetrtWzEp9GEPetG4/UuqNqfJVlZQZR3k3ONod jj8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lU1EvzM/eLD0n0vZaZM7AMkwMVY8sZSz0h3WsdV8t0E=; b=G1j7xszm8WAg03QBAT/YilbZwdwW2hO7iqhuyRb0Htq6O/stqzu+xI7D8LyqQ4mJXw uuYBUq/xi1k9Csx48BaoDxkOunoIdzgq3rnp2S/0GXySDQ3XzuYopxQBv8wXsEdJoru2 UH4Md5+ZF9KfUjzGZ45UfRk/QXv46WAvxC781O7A67fkMw5ZPWJWPXYi6Dx0ecFfXhN/ Rv+Rl70EBjO0cxDQM1veoD2itStPQI5bXfh1ql7aDBNhsOxGQPb2OAJqx3/CNDWnQBff OAMaDl9nJxNc0okJdaWOGnleKB/W+syGuyuWzLB7hGW1niCPnlsZeS9g5OYFkMFfdrr5 P7Yw== X-Gm-Message-State: APjAAAVAwldlh20nhbyTkpifRQZXvDGi0/KTAfIKkg/yOT9b3/PCY3tm TmuOZ33W2OeoCBMEUa3MA2flKwd3SDQ1aZX55OM= X-Google-Smtp-Source: APXvYqzHaKRUEfbiAOswMp49ewBcixg21LL6YP05PzNudQhdouGxpQM6W2U/QiJNtYTg+vZqQcCAgBCV7oa+geJPtRg= X-Received: by 2002:a1c:4944:: with SMTP id w65mr3776661wma.39.1575535439089; Thu, 05 Dec 2019 00:43:59 -0800 (PST) MIME-Version: 1.0 References: <20191128223802.18228-1-michael@walle.cc> In-Reply-To: <20191128223802.18228-1-michael@walle.cc> From: Daniel Baluta Date: Thu, 5 Dec 2019 10:43:46 +0200 Message-ID: To: Michael Walle Cc: Linux-ALSA , Timur Tabi , Xiubo Li , Fabio Estevam , Takashi Iwai , Linux Kernel Mailing List , Liam Girdwood , Nicolin Chen , Mark Brown , linuxppc-dev@lists.ozlabs.org Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_sai: add IRQF_SHARED X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Nov 29, 2019 at 12:40 AM Michael Walle wrote: > > The LS1028A SoC uses the same interrupt line for adjacent SAIs. Use > IRQF_SHARED to be able to use these SAIs simultaneously. Hi Michael, Thanks for the patch. We have a similar change inside our internal tree (it is on my long TODO list to upstream :D). We add the shared flag conditionally on a dts property. Do you think it is a good idea to always add shared flag? I'm thinking on SAI IP integrations where the interrupt is edge triggered. AFAIK edge triggered interrupts do not get along very well with sharing an interrupt line. _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09527C43603 for ; Thu, 5 Dec 2019 08:46:10 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75827205ED for ; Thu, 5 Dec 2019 08:46:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U2VSti3x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75827205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47T8St6cn0zDqZW for ; Thu, 5 Dec 2019 19:46:06 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=daniel.baluta@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="U2VSti3x"; dkim-atps=neutral Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47T8QW4Nw9zDqYP for ; Thu, 5 Dec 2019 19:44:03 +1100 (AEDT) Received: by mail-wm1-x342.google.com with SMTP id p17so2665528wmi.3 for ; Thu, 05 Dec 2019 00:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lU1EvzM/eLD0n0vZaZM7AMkwMVY8sZSz0h3WsdV8t0E=; b=U2VSti3xVYS3TZPRfEbXKHUduQrzXSc5f+w1SuhjId7MWQwy7oOm4AD/MgMfRrvBTD 8BVTycGLuJp8sE6OQ+FG0TCjsXTjRI964j4m5fup+dxVQ1Mlsa/+9p6kWM4HQEUnLUPB jDoOpTvvmLrggMmDLQIrbrpt5LlAn6GbQjyJzvu+gdCJX+gp30vQL38CMQoJbw+vSUBh vzqWSDfZ60M9svZzy8bab7AWE7X0RDQRXDUrvfoAx35v2NKnCNG3v2WH50/J0oJuj6Vy N0t0vFI5R42CNnD2QpW2oIE8fwT3iMnetrtWzEp9GEPetG4/UuqNqfJVlZQZR3k3ONod jj8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lU1EvzM/eLD0n0vZaZM7AMkwMVY8sZSz0h3WsdV8t0E=; b=ktgpSMmGbnDS+6j/6xCx3gJsZ36nlHmivX/sisAPolp7G7rksx3TWLXfIya96frKpC WiLFD0W+zDr8qtiPAeh+SG3rsTM3kI/kU9U4sEpAHqLU7TyML+RvLyDyrlnIfk2z1knp g9f7NSESI+M6N9tdE5xSWspnyDSe1IyQzANZz5htYq5W8CQyURvQt6Z+T1Jzbz4ew+jN sWAtxoVGdABCxi34g9v5Owb3yGZnGtldaCHx2fKpJ488jJofhIzCqwwZeko+s6NMvu1E kVaJIZ8wfWOe2fK6andfD281uv5O2ynbl37mtVh3Zg/3jiNnhuNfKOl6/hQb/uujHRra TT5A== X-Gm-Message-State: APjAAAVhFqJDTHimHAwiAH9P0lwi3lL88pjzpSgFuVwM5JW4YL/RYvuQ Bl6Txq0K0GjVgc4fqBzwe0LcD8+JJNNve3wVyCQ= X-Google-Smtp-Source: APXvYqzHaKRUEfbiAOswMp49ewBcixg21LL6YP05PzNudQhdouGxpQM6W2U/QiJNtYTg+vZqQcCAgBCV7oa+geJPtRg= X-Received: by 2002:a1c:4944:: with SMTP id w65mr3776661wma.39.1575535439089; Thu, 05 Dec 2019 00:43:59 -0800 (PST) MIME-Version: 1.0 References: <20191128223802.18228-1-michael@walle.cc> In-Reply-To: <20191128223802.18228-1-michael@walle.cc> From: Daniel Baluta Date: Thu, 5 Dec 2019 10:43:46 +0200 Message-ID: Subject: Re: [PATCH] ASoC: fsl_sai: add IRQF_SHARED To: Michael Walle Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-ALSA , Timur Tabi , Xiubo Li , Fabio Estevam , Takashi Iwai , Linux Kernel Mailing List , Liam Girdwood , Nicolin Chen , Mark Brown , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Nov 29, 2019 at 12:40 AM Michael Walle wrote: > > The LS1028A SoC uses the same interrupt line for adjacent SAIs. Use > IRQF_SHARED to be able to use these SAIs simultaneously. Hi Michael, Thanks for the patch. We have a similar change inside our internal tree (it is on my long TODO list to upstream :D). We add the shared flag conditionally on a dts property. Do you think it is a good idea to always add shared flag? I'm thinking on SAI IP integrations where the interrupt is edge triggered. AFAIK edge triggered interrupts do not get along very well with sharing an interrupt line.