From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5190BC7618B for ; Thu, 25 Jul 2019 06:08:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23F5F20828 for ; Thu, 25 Jul 2019 06:08:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YHuUocaS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729094AbfGYGIc (ORCPT ); Thu, 25 Jul 2019 02:08:32 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38951 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727530AbfGYGIb (ORCPT ); Thu, 25 Jul 2019 02:08:31 -0400 Received: by mail-wr1-f65.google.com with SMTP id x4so49284465wrt.6 for ; Wed, 24 Jul 2019 23:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=latsD49SbH6+14WTREJoq/H2WKuYcXOmWv0v0lWZfMo=; b=YHuUocaSQuBDb4/+my9nanv/AIgj+H3gXw2FWCnDH18O9Sxm/qfJ9hBycuupuqsSyr Q2hxlHfOF6YK5++nJOuJ8DLpjgJGuNXVTDmwX/x5y+LW/6V58NoDGh0T01lHBL+NYZ78 vVuL+uUhoUtrI4C1goiEMpKcZSb3X15aPhKzXl/3m/LwQJXBld/2BmTftSa0eZepVxSE W/Gh62II2Zc3TIErxNyRyA9hVZXru9veJ5Hg3red1HKi6ClYcvoOaatdWlTX8HXduuHJ XaXgyLk4oLHkdPQhyKzBjIRfv+UgBBf5AetkBMThgK3FIuXommwlOf7PS4DNf+YZZmXW Nr7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=latsD49SbH6+14WTREJoq/H2WKuYcXOmWv0v0lWZfMo=; b=LZNA/dAidEus0rY08cCYiu3R9kqYNVKWguMv/bUFAXzvmcrGh7uUZ5+pX7fLVOIkyk om4NIZHyu5c6bkFDCQyTr67+0zbidI+fjebFbahRQb41BjZYSubbxcUc+9XrLq/3VsZY sMpEWS4AZgQqNAq7Z8SmZdA6sKLCviU3maTL66ThGl94zPn1xtK4Phg4JD2El/chWB4Y FqK2B/id8WBNthbDHsvgIbEiJ091sEtL4MbZ+iwAUtiNcoqQiGVxeUzvTISdVgUY2X2c 3bXA24IerQt3CPXUogBT2BfmQ7MEktYq/94YRAug/+YoLT+ZT225HlhnRzSL0piyD1hK gZkQ== X-Gm-Message-State: APjAAAUN62iDWiol+rT4uz49IjxifjEiY7LHmpIE+PdXWdCXimtl0NPz IEw7zMNbBLOAfaYwTFQ+51SbF2lbnMYoG0sdOy8= X-Google-Smtp-Source: APXvYqygKTZcpAUad4xCLhuwEwjXgMEOhsMCmrgBhao93Fa2kJ6wTZaNsdznhI1yMHhycn2/c4/j+qf52ggAwTcXS60= X-Received: by 2002:adf:f450:: with SMTP id f16mr60328116wrp.335.1564034909544; Wed, 24 Jul 2019 23:08:29 -0700 (PDT) MIME-Version: 1.0 References: <20190722124833.28757-1-daniel.baluta@nxp.com> <20190722124833.28757-7-daniel.baluta@nxp.com> <20190724231342.GB6859@Asurada-Nvidia.nvidia.com> In-Reply-To: <20190724231342.GB6859@Asurada-Nvidia.nvidia.com> From: Daniel Baluta Date: Thu, 25 Jul 2019 09:08:18 +0300 Message-ID: Subject: Re: [alsa-devel] [PATCH 06/10] ASoC: dt-bindings: Document dl_mask property To: Nicolin Chen Cc: Daniel Baluta , Linux-ALSA , Viorel Suman , Timur Tabi , Xiubo Li , linuxppc-dev@lists.ozlabs.org, "S.j. Wang" , "Angus Ainslie (Purism)" , Takashi Iwai , Mark Brown , dl-linux-imx , Pengutronix Kernel Team , Fabio Estevam , Linux Kernel Mailing List , Lucas Stach Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 25, 2019 at 2:14 AM Nicolin Chen wrote: > > On Mon, Jul 22, 2019 at 03:48:29PM +0300, Daniel Baluta wrote: > > SAI supports up to 8 data lines. This property let the user > > configure how many data lines should be used per transfer > > direction (Tx/Rx). > > > > Signed-off-by: Daniel Baluta > > --- > > Documentation/devicetree/bindings/sound/fsl-sai.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt > > index 2e726b983845..59f4d965a5fb 100644 > > --- a/Documentation/devicetree/bindings/sound/fsl-sai.txt > > +++ b/Documentation/devicetree/bindings/sound/fsl-sai.txt > > @@ -49,6 +49,11 @@ Optional properties: > > > + - fsl,dl_mask : list of two integers (bitmask, first for RX, second > > Not quite in favor of the naming here; And this patch should > be sent to the devicetree maillist and add DT maintainers -- > they would give some good naming advice. > > From my point of view, I feel, since data lines are enabled > consecutively, probably it'd be clear just to have something > like "fsl,num-datalines = <2 2>", corresponding to "dl_mask > = <0x3 0x3>". I believe there're examples in the existing DT > bindings, so let's see how others suggest. > Your suggestion looks good to me. Anyhow, after reading again the documentation it seems that datalines are not always required to be consecutive. The need to be consecutive only when FIFO combine mode is enabled. Will fix the documentation in the next version. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Baluta Subject: Re: [PATCH 06/10] ASoC: dt-bindings: Document dl_mask property Date: Thu, 25 Jul 2019 09:08:18 +0300 Message-ID: References: <20190722124833.28757-1-daniel.baluta@nxp.com> <20190722124833.28757-7-daniel.baluta@nxp.com> <20190724231342.GB6859@Asurada-Nvidia.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8C40CF800E8 for ; Thu, 25 Jul 2019 08:08:30 +0200 (CEST) Received: by mail-wr1-x441.google.com with SMTP id x1so34345505wrr.9 for ; Wed, 24 Jul 2019 23:08:30 -0700 (PDT) In-Reply-To: <20190724231342.GB6859@Asurada-Nvidia.nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Nicolin Chen Cc: Linux-ALSA , Fabio Estevam , Pengutronix Kernel Team , Timur Tabi , Xiubo Li , Daniel Baluta , "S.j. Wang" , "Angus Ainslie (Purism)" , Takashi Iwai , Linux Kernel Mailing List , Mark Brown , dl-linux-imx , Viorel Suman , linuxppc-dev@lists.ozlabs.org, Lucas Stach List-Id: alsa-devel@alsa-project.org On Thu, Jul 25, 2019 at 2:14 AM Nicolin Chen wrote: > > On Mon, Jul 22, 2019 at 03:48:29PM +0300, Daniel Baluta wrote: > > SAI supports up to 8 data lines. This property let the user > > configure how many data lines should be used per transfer > > direction (Tx/Rx). > > > > Signed-off-by: Daniel Baluta > > --- > > Documentation/devicetree/bindings/sound/fsl-sai.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt > > index 2e726b983845..59f4d965a5fb 100644 > > --- a/Documentation/devicetree/bindings/sound/fsl-sai.txt > > +++ b/Documentation/devicetree/bindings/sound/fsl-sai.txt > > @@ -49,6 +49,11 @@ Optional properties: > > > + - fsl,dl_mask : list of two integers (bitmask, first for RX, second > > Not quite in favor of the naming here; And this patch should > be sent to the devicetree maillist and add DT maintainers -- > they would give some good naming advice. > > From my point of view, I feel, since data lines are enabled > consecutively, probably it'd be clear just to have something > like "fsl,num-datalines = <2 2>", corresponding to "dl_mask > = <0x3 0x3>". I believe there're examples in the existing DT > bindings, so let's see how others suggest. > Your suggestion looks good to me. Anyhow, after reading again the documentation it seems that datalines are not always required to be consecutive. The need to be consecutive only when FIFO combine mode is enabled. Will fix the documentation in the next version. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF3ADC7618B for ; Thu, 25 Jul 2019 06:11:03 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73A9A20828 for ; Thu, 25 Jul 2019 06:11:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YHuUocaS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73A9A20828 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45vMKK1D1jzDqK9 for ; Thu, 25 Jul 2019 16:11:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=daniel.baluta@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YHuUocaS"; dkim-atps=neutral Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45vMGS3Z9PzDqKD for ; Thu, 25 Jul 2019 16:08:32 +1000 (AEST) Received: by mail-wr1-x441.google.com with SMTP id n9so24255985wrr.4 for ; Wed, 24 Jul 2019 23:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=latsD49SbH6+14WTREJoq/H2WKuYcXOmWv0v0lWZfMo=; b=YHuUocaSQuBDb4/+my9nanv/AIgj+H3gXw2FWCnDH18O9Sxm/qfJ9hBycuupuqsSyr Q2hxlHfOF6YK5++nJOuJ8DLpjgJGuNXVTDmwX/x5y+LW/6V58NoDGh0T01lHBL+NYZ78 vVuL+uUhoUtrI4C1goiEMpKcZSb3X15aPhKzXl/3m/LwQJXBld/2BmTftSa0eZepVxSE W/Gh62II2Zc3TIErxNyRyA9hVZXru9veJ5Hg3red1HKi6ClYcvoOaatdWlTX8HXduuHJ XaXgyLk4oLHkdPQhyKzBjIRfv+UgBBf5AetkBMThgK3FIuXommwlOf7PS4DNf+YZZmXW Nr7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=latsD49SbH6+14WTREJoq/H2WKuYcXOmWv0v0lWZfMo=; b=YhIsgETr+yJoXDUFz9fxbwe3oJsAgQUeMP0Xv/tuVXnKhlrSkot70r90Y0n1UnN8d+ 4m0XK3AozOxipNK+t2+fJPInIk566YXEDYIZbjr0C8N7MuoaoOu0JhzeYTwqLaZvrvwA TWmBYhwqpf+7xKWuOwz2w/UHQmRHAyJ2y/12WIWXyIO/qSDSZLiDwjZs2XeOt0G05bgP cUYjeEHKTRT8LLLCHqXn3mt2x0tR+7ZDlchppG+m6piJvOwZD5MZB4u5gt0OCfUkofz7 nE/7vpFyWxI0ShwKvDP+DGzVpN3/GbhpRNCcLHAq1fl+SDaPOrEjQEc95oQRQL61v4iG CGDw== X-Gm-Message-State: APjAAAWBialJu5rTeYQ8cgUYUe8TyXRdRkIXdNW9uLwRnNR5LCsgUpgH EuJAiFG5Q/QqLHb4p96Ay4rWs2yXn7vbmXFr/Pw= X-Google-Smtp-Source: APXvYqygKTZcpAUad4xCLhuwEwjXgMEOhsMCmrgBhao93Fa2kJ6wTZaNsdznhI1yMHhycn2/c4/j+qf52ggAwTcXS60= X-Received: by 2002:adf:f450:: with SMTP id f16mr60328116wrp.335.1564034909544; Wed, 24 Jul 2019 23:08:29 -0700 (PDT) MIME-Version: 1.0 References: <20190722124833.28757-1-daniel.baluta@nxp.com> <20190722124833.28757-7-daniel.baluta@nxp.com> <20190724231342.GB6859@Asurada-Nvidia.nvidia.com> In-Reply-To: <20190724231342.GB6859@Asurada-Nvidia.nvidia.com> From: Daniel Baluta Date: Thu, 25 Jul 2019 09:08:18 +0300 Message-ID: Subject: Re: [alsa-devel] [PATCH 06/10] ASoC: dt-bindings: Document dl_mask property To: Nicolin Chen Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-ALSA , Fabio Estevam , Pengutronix Kernel Team , Timur Tabi , Xiubo Li , Daniel Baluta , "S.j. Wang" , "Angus Ainslie \(Purism\)" , Takashi Iwai , Linux Kernel Mailing List , Mark Brown , dl-linux-imx , Viorel Suman , linuxppc-dev@lists.ozlabs.org, Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jul 25, 2019 at 2:14 AM Nicolin Chen wrote: > > On Mon, Jul 22, 2019 at 03:48:29PM +0300, Daniel Baluta wrote: > > SAI supports up to 8 data lines. This property let the user > > configure how many data lines should be used per transfer > > direction (Tx/Rx). > > > > Signed-off-by: Daniel Baluta > > --- > > Documentation/devicetree/bindings/sound/fsl-sai.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt > > index 2e726b983845..59f4d965a5fb 100644 > > --- a/Documentation/devicetree/bindings/sound/fsl-sai.txt > > +++ b/Documentation/devicetree/bindings/sound/fsl-sai.txt > > @@ -49,6 +49,11 @@ Optional properties: > > > + - fsl,dl_mask : list of two integers (bitmask, first for RX, second > > Not quite in favor of the naming here; And this patch should > be sent to the devicetree maillist and add DT maintainers -- > they would give some good naming advice. > > From my point of view, I feel, since data lines are enabled > consecutively, probably it'd be clear just to have something > like "fsl,num-datalines = <2 2>", corresponding to "dl_mask > = <0x3 0x3>". I believe there're examples in the existing DT > bindings, so let's see how others suggest. > Your suggestion looks good to me. Anyhow, after reading again the documentation it seems that datalines are not always required to be consecutive. The need to be consecutive only when FIFO combine mode is enabled. Will fix the documentation in the next version.