From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50798)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <elta.era@gmail.com>) id 1XC9OO-0005CD-7C
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 11:32:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <elta.era@gmail.com>) id 1XC9OM-0000cH-NE
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 11:32:44 -0400
Received: from mail-qg0-x232.google.com ([2607:f8b0:400d:c04::232]:33056)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <elta.era@gmail.com>) id 1XC9OM-0000c9-IU
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 11:32:42 -0400
Received: by mail-qg0-f50.google.com with SMTP id q108so10362578qgd.9
	for <qemu-devel@nongnu.org>; Tue, 29 Jul 2014 08:32:40 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20140729140858.GA6069@hall.aurel32.net>
References: <1406563102-11035-1-git-send-email-elta.era@gmail.com>
	<1406563102-11035-2-git-send-email-elta.era@gmail.com>
	<20140728214242.GA24813@ohm.rr44.fr>
	<CAFEAcA-B-_vu1pP7xYxsY=vKzON_hsrkd3QVNJH-H=NHKnxaJw@mail.gmail.com>
	<20140728223236.GC18733@ohm.rr44.fr>
	<CAFEAcA_+ZM3v7e6KJGgKF_wgNCg19wYGRHJ3NYz1SG1EOcyJgw@mail.gmail.com>
	<20140728225254.GA1268@hall.aurel32.net>
	<53D79664.9070007@gmail.com>
	<20140729140858.GA6069@hall.aurel32.net>
Date: Tue, 29 Jul 2014 23:32:39 +0800
Message-ID: <CAEomy4T-E4TTjwQv_XHUOZecFNKYO5G5Y8kERftw3JiCZ98N3Q@mail.gmail.com>
From: Dongxue Zhang <elta.era@gmail.com>
Content-Type: multipart/alternative; boundary=001a11c31f02f195a304ff56bf77
Subject: Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement
 for msb and lsb
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>

--001a11c31f02f195a304ff56bf77
Content-Type: text/plain; charset=UTF-8

Ok, I got you. I will re-build a new patch for all the bitops.


2014-07-29 22:08 GMT+08:00 Aurelien Jarno <aurelien@aurel32.net>:

> On Tue, Jul 29, 2014 at 08:41:08PM +0800, Elta wrote:
> > I think, debug mode shouldn't crash the qemu with an unpredictable
> > operation,
> > so i want to fix it. And you say there shouldn't raise RI, i agree with
> you.
>
> Agreed.
>
> > Or when lsb > msb, just leave the code and do nothing. What do you
> > think about
> > this way?
>
> Yes, you can use something like:
>
>     if (lsb <= msb) {
>         deposit(...)
>     }
>
> --
> Aurelien Jarno                          GPG: 4096R/1DDD8C9B
> aurelien@aurel32.net                 http://www.aurel32.net
>

--001a11c31f02f195a304ff56bf77
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Ok, I got you. I will re-build a new patch for all the bit=
ops.</div><div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">201=
4-07-29 22:08 GMT+08:00 Aurelien Jarno <span dir=3D"ltr">&lt;<a href=3D"mai=
lto:aurelien@aurel32.net" target=3D"_blank">aurelien@aurel32.net</a>&gt;</s=
pan>:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div class=3D"">On Tue, Jul 29, 2014 at 08:4=
1:08PM +0800, Elta wrote:<br>
&gt; I think, debug mode shouldn&#39;t crash the qemu with an unpredictable=
<br>
&gt; operation,<br>
&gt; so i want to fix it. And you say there shouldn&#39;t raise RI, i agree=
 with you.<br>
<br>
</div>Agreed.<br>
<div class=3D""><br>
&gt; Or when lsb &gt; msb, just leave the code and do nothing. What do you<=
br>
&gt; think about<br>
&gt; this way?<br>
<br>
</div>Yes, you can use something like:<br>
<br>
=C2=A0 =C2=A0 if (lsb &lt;=3D msb) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 deposit(...)<br>
<div class=3D"HOEnZb"><div class=3D"h5">=C2=A0 =C2=A0 }<br>
<br>
--<br>
Aurelien Jarno =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0GPG: 4096R/1DDD8C9B<br>
<a href=3D"mailto:aurelien@aurel32.net">aurelien@aurel32.net</a> =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <a href=3D"http://www.aurel32=
.net" target=3D"_blank">http://www.aurel32.net</a><br>
</div></div></blockquote></div><br></div>

--001a11c31f02f195a304ff56bf77--