From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elena Ufimtseva Subject: Re: [PATCH] numa.c: use spaces instead of tabs Date: Wed, 3 Sep 2014 08:34:05 -0400 Message-ID: References: <1409717890-2837-1-git-send-email-ufimtseva@gmail.com> <1409737969.2673.35.camel@Solace.lan> <54070330020000780003029A@mail.emea.novell.com> <540725DE0200007800030453@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <540725DE0200007800030453@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Ian Campbell , George Dunlap , Dario Faggioli , Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, Sep 3, 2014 at 8:29 AM, Jan Beulich wrote: >>>> On 03.09.14 at 13:59, wrote: >> Jan, you say that such style is not used.. But numa.c uses tabs as >> :set list shows and its not Xen style either. >> Coding style says - 4 spaces for one level of indent. numa.c uses tabs >> and sometimes space between tabs. >> >> I am looking at the rest of the files in xen/arch/x86/ and see that >> they have all same tab= 4 spaces for indentation. >> for example see xen/arch/x86/domain.c. >> I used this for vim to re-tab the file: set noai ts=4 sw=8 expandtab >> >> Linux has 8 spaces for tabs.. So I am lost here. > > In a few files, original Linux style got retained, and we're accepting > that. See for example xen/arch/x86/cpu/. As a result, keeping the > file here as is would be fine (as indicated before); the only alternative > would be to fully switch it to Xen style. > > Jan > Jan I understand that, but that style is mixed. Not linux, not Xen :) And tabs also do not make it look like linux. But I got your point I think. Or leave it as it is (with tabs), or change it to Xen style. -- Elena