From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757556Ab3FEUPB (ORCPT ); Wed, 5 Jun 2013 16:15:01 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:43948 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757286Ab3FEUO6 (ORCPT ); Wed, 5 Jun 2013 16:14:58 -0400 MIME-Version: 1.0 In-Reply-To: <1369489718-25869-7-git-send-email-jiang.liu@huawei.com> References: <1369489718-25869-1-git-send-email-jiang.liu@huawei.com> <1369489718-25869-7-git-send-email-jiang.liu@huawei.com> From: Bjorn Helgaas Date: Wed, 5 Jun 2013 14:14:38 -0600 Message-ID: Subject: Re: [PATCH v3, part1 06/10] PCI: make PCI host bridge/bus creating and destroying logic symmetric To: Jiang Liu Cc: Yinghai Lu , Jiang Liu , "Rafael J . Wysocki" , Greg Kroah-Hartman , Gu Zheng , Toshi Kani , Myron Stowe , Yijing Wang , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 25, 2013 at 7:48 AM, Jiang Liu wrote: > This patch makes PCI host bridge/bus creating and destroying logic > symmetric by using device_initialize()/device_add()/device_del()/put_device() > pairs as discussed in thread at: > http://comments.gmane.org/gmane.linux.kernel.pci/22073 > > It also fixes a bug in error recovery path in pci_create_root_bus() > which may kfree() an in-use host bridge object. Can you split out the bug fix into a separate patch, in case it's something we want to backport by itself? I'd do it myself, but I didn't understand at a glance what the problem was. Bjorn