From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbbDBUNu (ORCPT ); Thu, 2 Apr 2015 16:13:50 -0400 Received: from mail-qc0-f180.google.com ([209.85.216.180]:34373 "EHLO mail-qc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbbDBUNr (ORCPT ); Thu, 2 Apr 2015 16:13:47 -0400 MIME-Version: 1.0 In-Reply-To: <20150326233555.GE5622@wotan.suse.de> References: <1426893517-2511-1-git-send-email-mcgrof@do-not-panic.com> <1426893517-2511-3-git-send-email-mcgrof@do-not-panic.com> <20150325195941.GM25884@l.oracle.com> <20150326233555.GE5622@wotan.suse.de> From: Bjorn Helgaas Date: Thu, 2 Apr 2015 15:13:26 -0500 Message-ID: Subject: Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR To: "Luis R. Rodriguez" Cc: Konrad Rzeszutek Wilk , "Luis R. Rodriguez" , Andy Lutomirski , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , jgross@suse.com, Jan Beulich , Borislav Petkov , Suresh Siddha , venkatesh.pallipadi@intel.com, Dave Airlie , "linux-kernel@vger.kernel.org" , linux-fbdev@vger.kernel.org, "x86@kernel.org" , "xen-devel@lists.xenproject.org" , Ingo Molnar , Daniel Vetter , Antonino Daplas , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Dave Hansen , Stefan Bader , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , David Vrabel , Toshi Kani , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2015 at 6:35 PM, Luis R. Rodriguez wrote: > I'll rephrase this to: > > --- > It is possible to enable CONFIG_MTRR and up with it > disabled at run time and yet CONFIG_X86_PAT continues > to kick through with all functionally enabled. This > can happen for instance on Xen where MTRR is not > supported but PAT is, this can happen now on Linux as > of commit 47591df50 by Juergen introduced as of v3.19. I still can't parse this. What does "up with it disabled at run time" mean? And "... continues to kick through"? Probably some idiomatic usage I'm just too old to understand :) Please use the conventional citation format: 47591df50512 ("xen: Support Xen pv-domains using PAT") A one-character typo in a SHA1 makes it completely useless, so it's nice to have the summary line both for readability and a bit of redundancy. Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Date: Thu, 02 Apr 2015 20:13:26 +0000 Subject: Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR Message-Id: List-Id: References: <1426893517-2511-1-git-send-email-mcgrof@do-not-panic.com> <1426893517-2511-3-git-send-email-mcgrof@do-not-panic.com> <20150325195941.GM25884@l.oracle.com> <20150326233555.GE5622@wotan.suse.de> In-Reply-To: <20150326233555.GE5622@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Luis R. Rodriguez" Cc: Konrad Rzeszutek Wilk , "Luis R. Rodriguez" , Andy Lutomirski , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , jgross@suse.com, Jan Beulich , Borislav Petkov , Suresh Siddha , venkatesh.pallipadi@intel.com, Dave Airlie , "linux-kernel@vger.kernel.org" , linux-fbdev@vger.kernel.org, "x86@kernel.org" , "xen-devel@lists.xenproject.org" , Ingo Molnar , Daniel Vetter , Antonino Daplas , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Dave Hansen , Stefan Bader , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , David Vrabel , Toshi Kani , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel On Thu, Mar 26, 2015 at 6:35 PM, Luis R. Rodriguez wrote: > I'll rephrase this to: > > --- > It is possible to enable CONFIG_MTRR and up with it > disabled at run time and yet CONFIG_X86_PAT continues > to kick through with all functionally enabled. This > can happen for instance on Xen where MTRR is not > supported but PAT is, this can happen now on Linux as > of commit 47591df50 by Juergen introduced as of v3.19. I still can't parse this. What does "up with it disabled at run time" mean? And "... continues to kick through"? Probably some idiomatic usage I'm just too old to understand :) Please use the conventional citation format: 47591df50512 ("xen: Support Xen pv-domains using PAT") A one-character typo in a SHA1 makes it completely useless, so it's nice to have the summary line both for readability and a bit of redundancy. Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR Date: Thu, 2 Apr 2015 15:13:26 -0500 Message-ID: References: <1426893517-2511-1-git-send-email-mcgrof@do-not-panic.com> <1426893517-2511-3-git-send-email-mcgrof@do-not-panic.com> <20150325195941.GM25884@l.oracle.com> <20150326233555.GE5622@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20150326233555.GE5622@wotan.suse.de> Sender: linux-kernel-owner@vger.kernel.org To: "Luis R. Rodriguez" Cc: Konrad Rzeszutek Wilk , "Luis R. Rodriguez" , Andy Lutomirski , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , jgross@suse.com, Jan Beulich , Borislav Petkov , Suresh Siddha , venkatesh.pallipadi@intel.com, Dave Airlie , "linux-kernel@vger.kernel.org" , linux-fbdev@vger.kernel.org, "x86@kernel.org" , "xen-devel@lists.xenproject.org" , Ingo Molnar , Daniel Vetter , Antonino Daplas , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Dave Hansen , Stefan List-Id: xen-devel@lists.xenproject.org On Thu, Mar 26, 2015 at 6:35 PM, Luis R. Rodriguez wrote: > I'll rephrase this to: > > --- > It is possible to enable CONFIG_MTRR and up with it > disabled at run time and yet CONFIG_X86_PAT continues > to kick through with all functionally enabled. This > can happen for instance on Xen where MTRR is not > supported but PAT is, this can happen now on Linux as > of commit 47591df50 by Juergen introduced as of v3.19. I still can't parse this. What does "up with it disabled at run time" mean? And "... continues to kick through"? Probably some idiomatic usage I'm just too old to understand :) Please use the conventional citation format: 47591df50512 ("xen: Support Xen pv-domains using PAT") A one-character typo in a SHA1 makes it completely useless, so it's nice to have the summary line both for readability and a bit of redundancy. Bjorn