From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755077Ab1HZNy1 (ORCPT ); Fri, 26 Aug 2011 09:54:27 -0400 Received: from smtp-out.google.com ([74.125.121.67]:47482 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754333Ab1HZNyX convert rfc822-to-8bit (ORCPT ); Fri, 26 Aug 2011 09:54:23 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=dkim-signature:mime-version:in-reply-to:references:from:date: message-id:subject:to:cc:content-type: content-transfer-encoding:x-system-of-record; b=vo1631kIGQ+XShmZQI5ra1lGhZjK+fvuB5XS7AgHqcRt/7END8r/8sq0iRRQdAIvi 3AB/C30QyCOjg55m+9hZQ== MIME-Version: 1.0 In-Reply-To: <1314349633-13155-1-git-send-email-dczhu@mips.com> References: <1314349633-13155-1-git-send-email-dczhu@mips.com> From: Bjorn Helgaas Date: Fri, 26 Aug 2011 07:54:00 -0600 Message-ID: Subject: Re: [PATCH v3 0/2] Pass resources to pci_create_bus() and fix MIPS PCI resources To: Deng-Cheng Zhu Cc: jbarnes@virtuousgeek.org, ralf@linux-mips.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, eyal@mips.com, zenon@mips.com, dengcheng.zhu@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2011 at 3:07 AM, Deng-Cheng Zhu wrote: > Change the pci_create_bus() interface to pass in available resources to get them > settled down early. This is to avoid possible resource conflicts while doing > pci_scan_slot() in pci_scan_child_bus(). Note that pcibios_fixup_bus() can get > rid of such conflicts, but it's done AFTER scanning slots. > > In addition, MIPS PCI resources are now fixed using this new interface. > > -- Changes -- > v3 - v2: > o Do not do fixups for root buses in pcibios_fixup_bus(). > o Skip bus creation when bus resources cannot be allocated. > o PCI domain/bus numbers added to the error info in controller_resources(). > > v2 - v1: > o Merge [PATCH 1/3] to [PATCH 3/3], so now 2 patches in total. > o Add more info to patch description. > o Fix arch breaks in default resource setup discovered by Bjorn Helgaas. > > Deng-Cheng Zhu (2): >  PCI: Pass available resources into pci_create_bus() >  MIPS: PCI: Pass controller's resources to pci_create_bus() in >    pcibios_scanbus() > >  arch/microblaze/pci/pci-common.c |    3 +- >  arch/mips/pci/pci.c              |   61 +++++++++++++++++++++++++++++++++----- >  arch/powerpc/kernel/pci-common.c |    3 +- >  arch/sparc/kernel/pci.c          |    3 +- >  arch/x86/pci/acpi.c              |    2 +- >  drivers/pci/probe.c              |   15 +++++++-- >  include/linux/pci.h              |    3 +- >  7 files changed, 73 insertions(+), 17 deletions(-) This is beautiful. Thanks for doing this work! I hope other architectures will follow your lead and get rid of their root bus resource fixups. Reviewed-by: Bjorn Helgaas