From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752594Ab2GIRFh (ORCPT ); Mon, 9 Jul 2012 13:05:37 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:63137 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480Ab2GIRFf (ORCPT ); Mon, 9 Jul 2012 13:05:35 -0400 MIME-Version: 1.0 In-Reply-To: <4FFAACF8.8040801@huawei.com> References: <1338795894-6292-1-git-send-email-jiang.liu@huawei.com> <4FF34CEF.3090400@redhat.com> <4FFAACF8.8040801@huawei.com> From: Bjorn Helgaas Date: Mon, 9 Jul 2012 11:05:14 -0600 Message-ID: Subject: Re: [Resend with Ack][PATCH v1] PCI: allow acpiphp to handle PCIe ports without native PCIe hotplug capability To: Jiang Liu Cc: Yinghai Lu , Don Dutile , "Rafael J. Wysocki" , Kenji Kaneshige , Taku Izumi , Yijing Wang , Keping Chen , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Jiang Liu Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 9, 2012 at 4:05 AM, Jiang Liu wrote: > Hi Bjorn and Yinghai, > What's the policy to export a symbol by EXPORT_SYMBOL() > or EXPORT_SYMBOL_GPL()? I know the legal difference, but don't > know when I should mark a symbol as GPL. >>From Documentation/DocBook/kernel-hacking.tmpl, EXPORT_SYMBOL_GPL implies that the function is considered an internal implementation issue, and not really an interface. So I use EXPORT_SYMBOL_GPL unless I'm willing to support the symbol as an interface indefinitely. Bjorn