From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f169.google.com ([209.85.128.169]:33367 "EHLO mail-wr0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbdDCOEP (ORCPT ); Mon, 3 Apr 2017 10:04:15 -0400 Received: by mail-wr0-f169.google.com with SMTP id w43so170482267wrb.0 for ; Mon, 03 Apr 2017 07:04:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1491223250991@kroah.com> References: <1491223250991@kroah.com> From: Bjorn Helgaas Date: Mon, 3 Apr 2017 07:03:53 -0700 Message-ID: Subject: Re: Patch "PCI: thunder-pem: Add legacy firmware support for Cavium ThunderX host controller" has been added to the 4.10-stable tree To: Greg Kroah-Hartman Cc: tn@semihalf.com, Vadim.Lomovtsev@caviumnetworks.com, Robert Richter , "stable@vger.kernel.org" , stable-commits@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org List-ID: I think there's an issue with this one that will be resolved this week. It would be better to wait for that and add both patches to the stable tree at the same time. On Mon, Apr 3, 2017 at 5:40 AM, wrote: > > This is a note to let you know that I've just added the patch titled > > PCI: thunder-pem: Add legacy firmware support for Cavium ThunderX host controller > > to the 4.10-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > pci-thunder-pem-add-legacy-firmware-support-for-cavium-thunderx-host-controller.patch > and it can be found in the queue-4.10 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let know about it. > > > From 9abb27c7594a62bbf6385e20b7f5a90b4eceae2f Mon Sep 17 00:00:00 2001 > From: Tomasz Nowicki > Date: Thu, 23 Mar 2017 17:10:16 -0500 > Subject: PCI: thunder-pem: Add legacy firmware support for Cavium ThunderX host controller > > From: Tomasz Nowicki > > commit 9abb27c7594a62bbf6385e20b7f5a90b4eceae2f upstream. > > During early days of PCI quirks support, ThunderX firmware did not provide > PNP0c02 node with PCI configuration space and PEM-specific register ranges. > This means that for legacy FW we are not reserving these resources and > cannot gather PEM-specific resources for further PEM initialization. > > To support already deployed legacy FW, calculate PEM-specific ranges and > provide resources reservation as fallback scenario into PEM driver when we > could not gather PEM reg base from ACPI tables. > > Tested-by: Robert Richter > Signed-off-by: Tomasz Nowicki > Signed-off-by: Vadim Lomovtsev > Signed-off-by: Bjorn Helgaas > Acked-by: Robert Richter > Signed-off-by: Greg Kroah-Hartman > > --- > drivers/pci/host/pci-thunder-pem.c | 56 +++++++++++++++++++++++++++++++++++-- > 1 file changed, 54 insertions(+), 2 deletions(-) > > --- a/drivers/pci/host/pci-thunder-pem.c > +++ b/drivers/pci/host/pci-thunder-pem.c > @@ -14,6 +14,7 @@ > * Copyright (C) 2015 - 2016 Cavium, Inc. > */ > > +#include > #include > #include > #include > @@ -319,6 +320,50 @@ static int thunder_pem_init(struct devic > > #if defined(CONFIG_ACPI) && defined(CONFIG_PCI_QUIRKS) > > +#define PEM_RES_BASE 0x87e0c0000000UL > +#define PEM_NODE_MASK GENMASK(45, 44) > +#define PEM_INDX_MASK GENMASK(26, 24) > +#define PEM_MIN_DOM_IN_NODE 4 > +#define PEM_MAX_DOM_IN_NODE 10 > + > +static void thunder_pem_reserve_range(struct device *dev, int seg, > + struct resource *r) > +{ > + resource_size_t start = r->start, end = r->end; > + struct resource *res; > + const char *regionid; > + > + regionid = kasprintf(GFP_KERNEL, "PEM RC:%d", seg); > + if (!regionid) > + return; > + > + res = request_mem_region(start, end - start + 1, regionid); > + if (res) > + res->flags &= ~IORESOURCE_BUSY; > + else > + kfree(regionid); > + > + dev_info(dev, "%pR %s reserved\n", r, > + res ? "has been" : "could not be"); > +} > + > +static void thunder_pem_legacy_fw(struct acpi_pci_root *root, > + struct resource *res_pem) > +{ > + int node = acpi_get_node(root->device->handle); > + int index; > + > + if (node == NUMA_NO_NODE) > + node = 0; > + > + index = root->segment - PEM_MIN_DOM_IN_NODE; > + index -= node * PEM_MAX_DOM_IN_NODE; > + res_pem->start = PEM_RES_BASE | FIELD_PREP(PEM_NODE_MASK, node) | > + FIELD_PREP(PEM_INDX_MASK, index); > + res_pem->end = res_pem->start + SZ_16M - 1; > + res_pem->flags = IORESOURCE_MEM; > +} > + > static int thunder_pem_acpi_init(struct pci_config_window *cfg) > { > struct device *dev = cfg->parent; > @@ -332,9 +377,16 @@ static int thunder_pem_acpi_init(struct > return -ENOMEM; > > ret = acpi_get_rc_resources(dev, "CAVA02B", root->segment, res_pem); > + > + /* > + * If we fail to gather resources it means that we run with old > + * FW where we need to calculate PEM-specific resources manually. > + */ > if (ret) { > - dev_err(dev, "can't get rc base address\n"); > - return ret; > + thunder_pem_legacy_fw(root, res_pem); > + /* Reserve PEM-specific resources and PCI configuration space */ > + thunder_pem_reserve_range(dev, root->segment, res_pem); > + thunder_pem_reserve_range(dev, root->segment, &cfg->res); > } > > return thunder_pem_init(dev, cfg, res_pem); > > > Patches currently in stable-queue which might be from tn@semihalf.com are > > queue-4.10/pci-thunder-pem-add-legacy-firmware-support-for-cavium-thunderx-host-controller.patch > queue-4.10/pci-thunder-pem-use-cavium-assigned-hardware-id-for-thunderx-host-controller.patch