On Mon, Sep 1, 2014 at 5:46 PM, Jan Beulich <JBeulich@suse.com> wrote:

> >>> On 01.09.14 at 16:21, <tklengyel@sec.in.tum.de> wrote:
> > --- a/xen/arch/x86/x86_64/compat/mm.c
> > +++ b/xen/arch/x86/x86_64/compat/mm.c
> > @@ -198,10 +198,6 @@ int compat_arch_memory_op(unsigned long cmd,
> XEN_GUEST_HANDLE_PARAM(void) arg)
> >          break;
> >      }
> >
> > -    case XENMEM_access_op:
> > -        rc = mem_access_memop(cmd, guest_handle_cast(arg,
> xen_mem_access_op_t));
> > -        break;
> > -
>
> I don't think you can simply drop this.
>

OK.


>
> > @@ -967,6 +968,14 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t)
> u_domctl)
> >      }
> >      break;
> >
> > +    case XEN_DOMCTL_mem_event_op:
> > +    {
> > +        ret = mem_event_domctl(d, &op->u.mem_event_op,
> > +                              guest_handle_cast(u_domctl, void));
> > +        copyback = 1;
> > +    }
> > +    break;
>
> Please drop the unnecessary braces.
>
> Jan


All other cases have braces around them here, even when not required, so
this just follows the established style.

Tamas