From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamas K Lengyel Subject: Re: [PATCH v3 03/15] xen: Relocate mem_event_op domctl and access_op memop into common. Date: Mon, 1 Sep 2014 18:25:45 +0200 Message-ID: References: <1409581329-2607-1-git-send-email-tklengyel@sec.in.tum.de> <1409581329-2607-4-git-send-email-tklengyel@sec.in.tum.de> <5404B101020000780002F8D7@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3566871862990600656==" Return-path: In-Reply-To: <5404B101020000780002F8D7@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian Campbell , Tim Deegan , Julien Grall , Ian Jackson , "xen-devel@lists.xen.org" , Stefano Stabellini , Andres Lagar-Cavilla , Daniel De Graaf , Tamas K Lengyel List-Id: xen-devel@lists.xenproject.org --===============3566871862990600656== Content-Type: multipart/alternative; boundary=001a113ac46872f2d40502037451 --001a113ac46872f2d40502037451 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Sep 1, 2014 at 5:46 PM, Jan Beulich wrote: > >>> On 01.09.14 at 16:21, wrote: > > --- a/xen/arch/x86/x86_64/compat/mm.c > > +++ b/xen/arch/x86/x86_64/compat/mm.c > > @@ -198,10 +198,6 @@ int compat_arch_memory_op(unsigned long cmd, > XEN_GUEST_HANDLE_PARAM(void) arg) > > break; > > } > > > > - case XENMEM_access_op: > > - rc = mem_access_memop(cmd, guest_handle_cast(arg, > xen_mem_access_op_t)); > > - break; > > - > > I don't think you can simply drop this. > OK. > > > @@ -967,6 +968,14 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) > u_domctl) > > } > > break; > > > > + case XEN_DOMCTL_mem_event_op: > > + { > > + ret = mem_event_domctl(d, &op->u.mem_event_op, > > + guest_handle_cast(u_domctl, void)); > > + copyback = 1; > > + } > > + break; > > Please drop the unnecessary braces. > > Jan All other cases have braces around them here, even when not required, so this just follows the established style. Tamas --001a113ac46872f2d40502037451 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable



On Mon, Sep 1, 2014 at 5:46 PM, Jan Beulich <<= a href=3D"mailto:JBeulich@suse.com" target=3D"_blank">JBeulich@suse.com= > wrote:
>>> On 01.09.14 at = 16:21, <tklengyel@sec.in.tum.= de> wrote:
> --- a/xen/arch/x86/x86_64/compat/mm.c
> +++ b/xen/arch/x86/x86_64/compat/mm.c
> @@ -198,10 +198,6 @@ int compat_arch_memory_op(unsigned long cmd, XEN_= GUEST_HANDLE_PARAM(void) arg)
>=A0 =A0 =A0 =A0 =A0 break;
>=A0 =A0 =A0 }
>
> -=A0 =A0 case XENMEM_access_op:
> -=A0 =A0 =A0 =A0 rc =3D mem_access_memop(cmd, guest_handle_cast(arg, x= en_mem_access_op_t));
> -=A0 =A0 =A0 =A0 break;
> -

I don't think you can simply drop this.

=
OK.
=A0

> @@ -967,6 +968,14 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_= t) u_domctl)
>=A0 =A0 =A0 }
>=A0 =A0 =A0 break;
>
> +=A0 =A0 case XEN_DOMCTL_mem_event_op:
> +=A0 =A0 {
> +=A0 =A0 =A0 =A0 ret =3D mem_event_domctl(d, &op->u.mem_event_o= p,
> +=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 guest_han= dle_cast(u_domctl, void));
> +=A0 =A0 =A0 =A0 copyback =3D 1;
> +=A0 =A0 }
> +=A0 =A0 break;

Please drop the unnecessary braces.

Jan

All other cases have brac= es around them here, even when not required, so this just follows the estab= lished style.

Tamas
--001a113ac46872f2d40502037451-- --===============3566871862990600656== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3566871862990600656==--