From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamas K Lengyel Subject: Re: [PATCH v3 03/15] xen: Relocate mem_event_op domctl and access_op memop into common. Date: Tue, 2 Sep 2014 09:41:50 +0200 Message-ID: References: <1409581329-2607-1-git-send-email-tklengyel@sec.in.tum.de> <1409581329-2607-4-git-send-email-tklengyel@sec.in.tum.de> <5404B6D9.2020108@linaro.org> <5405856C020000780002FAE4@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4951030101395403040==" Return-path: In-Reply-To: <5405856C020000780002FAE4@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian Campbell , Tim Deegan , Julien Grall , Ian Jackson , "xen-devel@lists.xen.org" , Stefano Stabellini , Andres Lagar-Cavilla , Daniel De Graaf , Tamas K Lengyel List-Id: xen-devel@lists.xenproject.org --===============4951030101395403040== Content-Type: multipart/alternative; boundary=001a11c17ab69da650050210402c --001a11c17ab69da650050210402c Content-Type: text/plain; charset=ISO-8859-1 On Tue, Sep 2, 2014 at 8:53 AM, Jan Beulich wrote: > >>> On 01.09.14 at 22:51, wrote: > > On Mon, Sep 1, 2014 at 8:11 PM, Julien Grall > wrote: > >> On 01/09/14 10:21, Tamas K Lengyel wrote: > >> > diff --git a/xen/common/memory.c b/xen/common/memory.c > >> > index cc8a3d0..4e530bf 100644 > >> > --- a/xen/common/memory.c > >> > +++ b/xen/common/memory.c > >> > @@ -25,6 +25,7 @@ > >> > #include > >> > #include > >> > #include > >> > +#include > >> > #include > >> > > > > @Julien: the problem causing your compile issue is here with the order of > > the inclusion of the headers. public/memory.h needs to be included before > > xen/mem_access.h, I'll fix it in the next iteration.. > > But then please by making xen/mem_access.h include the prereq > header rather than altering the order here. > > Jan > I was thinking of the same thing, that would be a lot more robust solution. Tamas --001a11c17ab69da650050210402c Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

= On Tue, Sep 2, 2014 at 8:53 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>> On 01.09.14 at = 22:51, <tamas.lengyel@zent= ific.com> wrote:
> On Mon, Sep 1, 2014 at 8:11 PM, Julien Grall <julien.grall@linaro.org> wrote:
>> On 01/09/14 10:21, Tamas K Lengyel wrote: >> > diff --git a/xen/common/memory.c b/xen/common/memory.c
>> > index cc8a3d0..4e530bf 100644
>> > --- a/xen/common/memory.c
>> > +++ b/xen/common/memory.c
>> > @@ -25,6 +25,7 @@
>> >=A0 =A0#include <asm/hardirq.h>
>> >=A0 =A0#include <asm/p2m.h>
>> >=A0 =A0#include <xen/numa.h>
>> > +#include <xen/mem_access.h>
>> >=A0 =A0#include <public/memory.h>
>>
>
> @Julien: the problem causing your compile issue is here with the order= of
> the inclusion of the headers. public/memory.h needs to be included bef= ore
> xen/mem_access.h, I'll fix it in the next iteration..

But then please by making xen/mem_access.h include the prereq
header rather than altering the order here.

Jan

I was thinking of the= same thing, that would be a lot more robust solution.

Ta= mas

--001a11c17ab69da650050210402c-- --===============4951030101395403040== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4951030101395403040==--