From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamas K Lengyel Subject: Re: [RFC PATCH V3 10/12] xen: Introduce monitor_op domctl Date: Fri, 30 Jan 2015 12:24:07 +0100 Message-ID: References: <1422567998-29995-1-git-send-email-tamas.lengyel@zentific.com> <1422567998-29995-11-git-send-email-tamas.lengyel@zentific.com> <54CB399E.10002@bitdefender.com> <54CB6607.7000803@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Razvan Cojocaru Cc: "Tian, Kevin" , wei.liu2@citrix.com, Ian Campbell , Stefano Stabellini , Jun Nakajima , Steven Maresca , Tim Deegan , "xen-devel@lists.xen.org" , "Dong, Eddie" , Andres Lagar-Cavilla , Jan Beulich , rshriram@cs.ubc.ca, Keir Fraser , Daniel De Graaf , yanghy@cn.fujitsu.com, Ian Jackson List-Id: xen-devel@lists.xenproject.org >> >> There are also places in patches yet to be published I've worked on >> where we gate things on introspection_enabled being != 0, so please >> don't remove it or have it misbehave. >> >> I'll look into the extended_capture option in case it will allow future >> removal of the MSR special case for introspection, but a flag like that >> is necessary and can't simply be deprecated and removed. > > Ack, the plan was actually to replace all references to > arch.hvm_domain.introspection_enabled with > arch.monitor_options.mov_to_msr.extended_capture. I see I forgot to > actually fully follow through that plan but that's the intention at > least. So the functionality would remain, it would just be worked into > the coherent settings field with every other type of events. If you take a look at the next iteration of this series at https://github.com/tklengyel/xen/compare/mem_event_cleanup4?expand=1 I updated this patch to implement what I described above. Tamas