From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamas K Lengyel Subject: Re: [PATCH v3 03/15] xen: Relocate mem_event_op domctl and access_op memop into common. Date: Mon, 1 Sep 2014 22:51:42 +0200 Message-ID: References: <1409581329-2607-1-git-send-email-tklengyel@sec.in.tum.de> <1409581329-2607-4-git-send-email-tklengyel@sec.in.tum.de> <5404B6D9.2020108@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2025157015928468547==" Return-path: In-Reply-To: <5404B6D9.2020108@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Ian Campbell , Tim Deegan , Ian Jackson , "xen-devel@lists.xen.org" , Stefano Stabellini , Andres Lagar-Cavilla , Jan Beulich , Daniel De Graaf , Tamas K Lengyel List-Id: xen-devel@lists.xenproject.org --===============2025157015928468547== Content-Type: multipart/alternative; boundary=089e0149d2e8995c9d0502072b8e --089e0149d2e8995c9d0502072b8e Content-Type: text/plain; charset=ISO-8859-1 On Mon, Sep 1, 2014 at 8:11 PM, Julien Grall wrote: > Hello Tamas, > > On 01/09/14 10:21, Tamas K Lengyel wrote: > > diff --git a/xen/common/memory.c b/xen/common/memory.c > > index cc8a3d0..4e530bf 100644 > > --- a/xen/common/memory.c > > +++ b/xen/common/memory.c > > @@ -25,6 +25,7 @@ > > #include > > #include > > #include > > +#include > > #include > @Julien: the problem causing your compile issue is here with the order of the inclusion of the headers. public/memory.h needs to be included before xen/mem_access.h, I'll fix it in the next iteration.. > > #include > > #include > > @@ -969,6 +970,10 @@ long do_memory_op(unsigned long cmd, > XEN_GUEST_HANDLE_PARAM(void) arg) > > > > break; > > > > + case XENMEM_access_op: > > + rc = mem_access_memop(cmd, guest_handle_cast(arg, > xen_mem_access_op_t)); > > + break; > > + > > Every patch should be able to compile without requiring a future patch. > This is very useful when we need to bisect the tree. > > Actually I got the following error: > > In file included from /home/julieng/works/xen/xen/include/asm/system.h:6:0, > from /home/julieng/works/xen/xen/include/xen/list.h:11, > from /home/julieng/works/xen/xen/include/xen/mm.h:32, > from memory.c:13: > /home/julieng/works/xen/xen/include/public/arch-arm.h:196:41: error: > unknown type name '__guest_handle_xen_mem_access_op_t' > #define XEN_GUEST_HANDLE_PARAM(name) __guest_handle_ ## name > ^ > /home/julieng/works/xen/xen/include/xen/mem_access.h:36:22: note: in > expansion of macro 'XEN_GUEST_HANDLE_PARAM' > XEN_GUEST_HANDLE_PARAM(xen_mem_access_op_t) arg) > ^ > memory.c: In function 'do_memory_op': > memory.c:974:9: error: implicit declaration of function 'mem_access_memop' > [-Werror=implicit-function-declaration] > rc = mem_access_memop(cmd, guest_handle_cast(arg, > xen_mem_access_op_t)); > ^ > memory.c:974:9: error: nested extern declaration of 'mem_access_memop' > [-Werror=nested-externs] > > Regards, > > -- > Julien Grall > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > --089e0149d2e8995c9d0502072b8e Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On M= on, Sep 1, 2014 at 8:11 PM, Julien Grall <julien.grall@linaro.org> wrote:
Hello Tamas,

On 01/09/14 10:21, Tamas K Lengyel wrote:
> diff --git a/xen/common/memory.c b/xen/common/memory.c
> index cc8a3d0..4e530bf 100644
> --- a/xen/common/memory.c
> +++ b/xen/common/memory.c
> @@ -25,6 +25,7 @@
>   #include <asm/hardirq.h>
>   #include <asm/p2m.h>
>   #include <xen/numa.h>
> +#include <xen/mem_access.h>
>   #include <public/memory.h>

>   #include <xsm/xsm.h>
>   #include <xen/trace.h>
> @@ -969,6 +970,10 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HA= NDLE_PARAM(void) arg)
>
>           break;
>
> +    case XENMEM_access_op:
> +        rc =3D mem_access_memop(cmd, guest_handle= _cast(arg, xen_mem_access_op_t));
> +        break;
> +

Every patch should be able to compile without requiring a future patc= h.
This is very useful when we need to bisect the tree.

Actually I got the following error:

In file included from /home/julieng/works/xen/xen/include/asm/system.h:6:0,=
                 from /home/ju= lieng/works/xen/xen/include/xen/list.h:11,
                 from /home/ju= lieng/works/xen/xen/include/xen/mm.h:32,
                 from memory.c= :13:
/home/julieng/works/xen/xen/include/public/arch-arm.h:196:41: error: unknow= n type name ‘__guest_handle_xen_mem_access_op_t’
 #define XEN_GUEST_HANDLE_PARAM(name)    __guest_handle_ ## = name
                     = ;                    ^ /home/julieng/works/xen/xen/include/xen/mem_access.h:36:22: note: in expans= ion of macro ‘XEN_GUEST_HANDLE_PARAM’
                     = ; XEN_GUEST_HANDLE_PARAM(xen_mem_access_op_t) arg)
                     = ; ^
memory.c: In function ‘do_memory_op’:
memory.c:974:9: error: implicit declaration of function ‘mem_access_m= emop’ [-Werror=3Dimplicit-function-declaration]
         rc =3D mem_access_memop(c= md, guest_handle_cast(arg, xen_mem_access_op_t));
         ^
memory.c:974:9: error: nested extern declaration of ‘mem_access_memop= ’ [-Werror=3Dnested-externs]

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.x= en.org/xen-devel

--089e0149d2e8995c9d0502072b8e-- --===============2025157015928468547== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2025157015928468547==--