From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tamas K Lengyel <tamas.lengyel@zentific.com>
Subject: Re: [PATCH for-4.5 v8 06/19] xen: Relocate mem_event_op
 domctl and access_op memop into common.
Date: Tue, 23 Sep 2014 16:08:06 +0200
Message-ID: <CAErYnshW5ZGtWs4qODxLrGfGDnsxz8obae++Pb2azhdkKbZBGw@mail.gmail.com>
References: <1411478070-13836-1-git-send-email-tklengyel@sec.in.tum.de>
	<1411478070-13836-7-git-send-email-tklengyel@sec.in.tum.de>
	<542192860200007800037BB5@mail.emea.novell.com>
	<54217D0F.90606@bitdefender.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8054124372937716539=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54217D0F.90606@bitdefender.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Razvan Cojocaru <rcojocaru@bitdefender.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@linaro.org>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Jan Beulich <JBeulich@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Tamas K Lengyel <tklengyel@sec.in.tum.de>
List-Id: xen-devel@lists.xenproject.org

--===============8054124372937716539==
Content-Type: multipart/alternative; boundary=001a11c3127eb803c90503bc184e

--001a11c3127eb803c90503bc184e
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Sep 23, 2014 at 4:00 PM, Razvan Cojocaru <rcojocaru@bitdefender.com>
wrote:

> On 09/23/2014 04:32 PM, Jan Beulich wrote:
> >>>> On 23.09.14 at 15:14, <tklengyel@sec.in.tum.de> wrote:
> >> --- a/xen/common/mem_event.c
> >> +++ b/xen/common/mem_event.c
> >> @@ -623,12 +623,9 @@ int mem_event_domctl(struct domain *d,
> >> xen_domctl_mem_event_op_t *mec,
> >>                                      HVM_PARAM_ACCESS_RING_PFN,
> >>                                      mem_access_notification);
> >>
> >> -            if ( mec->op != XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE &&
> >> -                 rc == 0 && hvm_funcs.enable_msr_exit_interception )
> >> -            {
> >> -                d->arch.hvm_domain.introspection_enabled = 1;
> >> -                hvm_funcs.enable_msr_exit_interception(d);
> >> -            }
> >> +            if ( !rc && mec->op !=
> XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE )
> >> +                p2m_enable_msr_exit_interception(d);
> >
> > The name is clearly not suitable for an abstraction - there's certainly
> > not going to be MSRs on each and every CPU architecture. Maybe
> > consult with Razvan on an agreeable more suitable name.
>
> P2m_set_up_introspection() perhaps? With the MSR HVM code where
> applicable, nothing (or something else) where not? Would this be too
> generic?
>
>
Yes, I think its too generic of a name (which IMHO applies to the boolean
on the hvm_domain as well, introspection_enabled). I don't know what would
be an adequate name for this really.

Tamas


>
> Regards,
> Razvan Cojocaru
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>

--001a11c3127eb803c90503bc184e
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Tue, Sep 23, 2014 at 4:00 PM, Razvan Cojocaru <span dir=3D"ltr">&lt;=
<a href=3D"mailto:rcojocaru@bitdefender.com" target=3D"_blank">rcojocaru@bi=
tdefender.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span=
 class=3D"">On 09/23/2014 04:32 PM, Jan Beulich wrote:<br>
&gt;&gt;&gt;&gt; On 23.09.14 at 15:14, &lt;<a href=3D"mailto:tklengyel@sec.=
in.tum.de">tklengyel@sec.in.tum.de</a>&gt; wrote:<br>
</span><span class=3D"">&gt;&gt; --- a/xen/common/mem_event.c<br>
&gt;&gt; +++ b/xen/common/mem_event.c<br>
&gt;&gt; @@ -623,12 +623,9 @@ int mem_event_domctl(struct domain *d,<br>
&gt;&gt; xen_domctl_mem_event_op_t *mec,<br>
&gt;&gt;=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 =A0 =A0 HVM_PARAM_ACCESS_RING_PFN,<br>
&gt;&gt;=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 =A0 =A0 mem_access_notification);<br>
&gt;&gt;<br>
&gt;&gt; -=A0 =A0 =A0 =A0 =A0 =A0 if ( mec-&gt;op !=3D XEN_DOMCTL_MEM_EVENT=
_OP_ACCESS_ENABLE &amp;&amp;<br>
&gt;&gt; -=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0rc =3D=3D 0 &amp;&amp; hvm_fun=
cs.enable_msr_exit_interception )<br>
&gt;&gt; -=A0 =A0 =A0 =A0 =A0 =A0 {<br>
&gt;&gt; -=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 d-&gt;arch.hvm_domain.introspecti=
on_enabled =3D 1;<br>
&gt;&gt; -=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 hvm_funcs.enable_msr_exit_interce=
ption(d);<br>
&gt;&gt; -=A0 =A0 =A0 =A0 =A0 =A0 }<br>
&gt;&gt; +=A0 =A0 =A0 =A0 =A0 =A0 if ( !rc &amp;&amp; mec-&gt;op !=3D XEN_D=
OMCTL_MEM_EVENT_OP_ACCESS_ENABLE )<br>
&gt;&gt; +=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 p2m_enable_msr_exit_interception(=
d);<br>
&gt;<br>
&gt; The name is clearly not suitable for an abstraction - there&#39;s cert=
ainly<br>
&gt; not going to be MSRs on each and every CPU architecture. Maybe<br>
&gt; consult with Razvan on an agreeable more suitable name.<br>
<br>
</span>P2m_set_up_introspection() perhaps? With the MSR HVM code where<br>
applicable, nothing (or something else) where not? Would this be too<br>
generic?<br>
<br></blockquote><div><br></div><div>Yes, I think its too generic of a name=
 (which IMHO applies to the boolean on the hvm_domain as well, introspectio=
n_enabled). I don&#39;t know what would be an adequate name for this really=
.<br><br>Tamas<br></div><div>=A0</div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Regards,<br>
Razvan Cojocaru<br>
<div class=3D"HOEnZb"><div class=3D"h5"><br>
_______________________________________________<br>
Xen-devel mailing list<br>
<a href=3D"mailto:Xen-devel@lists.xen.org">Xen-devel@lists.xen.org</a><br>
<a href=3D"http://lists.xen.org/xen-devel" target=3D"_blank">http://lists.x=
en.org/xen-devel</a><br>
</div></div></blockquote></div><br></div></div>

--001a11c3127eb803c90503bc184e--


--===============8054124372937716539==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============8054124372937716539==--