* [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem
@ 2015-01-18 15:17 Tamas K Lengyel
2015-01-18 15:17 ` [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures Tamas K Lengyel
` (8 more replies)
0 siblings, 9 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-18 15:17 UTC (permalink / raw)
To: xen-devel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, tim, ian.jackson, eddie.dong, andres, jbeulich,
Tamas K Lengyel, rshriram, keir, dgdegra, yanghy
This patch series aims to clean up the mem_event subsystem within Xen. The
original use-case for this system was to allow external helper applications
running in privileged domains to control various memory operations performed
by Xen. Amongs these were paging, sharing and access control. The subsystem
has since been extended to also deliver non-memory related events, namely
various HVM debugging events (INT3, MTF, MOV-TO-CR, MOV-TO-MSR). The structures
and naming of related functions however has not caught up to these new
use-cases, thus leaving many ambigouities in the code.
In this series we convert the mem_event structures to a union of sub-structures
which clearly define the scope of information that is transmitted via the event
delivery mechanism. Afterwards, we clean up the naming of the structures and
related functions to more clearly be in line with their actual operations.
This RFC PATCH series is also available at:
https://github.com/tklengyel/xen/tree/mem_event_cleanup2
Razvan Cojocaru (1):
xen/mem_event: Cleanup of mem_event structures
Tamas K Lengyel (7):
xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'
xen/mem_paging: Convert mem_event_op to mem_paging_op
x86/hvm: rename hvm_memory_event_* functions to hvm_event_*
xen/mem_event: Rename mem_event to vm_event
xen/vm_event: Decouple vm_event and mem_access.
tools/tests: Clean-up tools/tests/xen-access
x86/hvm: factor out vm_event related functions into separate file
docs/misc/pvh-readme.txt | 2 +-
tools/libxc/Makefile | 2 +-
tools/libxc/xc_domain_restore.c | 14 +-
tools/libxc/xc_domain_save.c | 4 +-
tools/libxc/xc_hvm_build_x86.c | 2 +-
tools/libxc/xc_mem_access.c | 10 +-
tools/libxc/xc_mem_event.c | 178 ---------
tools/libxc/xc_mem_paging.c | 38 +-
tools/libxc/xc_memshr.c | 12 +-
tools/libxc/xc_private.h | 9 +-
tools/libxc/xc_vm_event.c | 162 ++++++++
tools/libxc/xg_save_restore.h | 2 +-
tools/tests/xen-access/xen-access.c | 210 ++++------
tools/xenpaging/pagein.c | 2 +-
tools/xenpaging/xenpaging.c | 150 ++++----
tools/xenpaging/xenpaging.h | 8 +-
xen/arch/x86/domain.c | 2 +-
xen/arch/x86/domctl.c | 4 +-
xen/arch/x86/hvm/Makefile | 3 +-
xen/arch/x86/hvm/emulate.c | 4 +-
xen/arch/x86/hvm/event.c | 195 ++++++++++
xen/arch/x86/hvm/hvm.c | 154 +-------
xen/arch/x86/hvm/vmx/vmcs.c | 4 +-
xen/arch/x86/hvm/vmx/vmx.c | 7 +-
xen/arch/x86/mm/hap/nested_ept.c | 4 +-
xen/arch/x86/mm/hap/nested_hap.c | 4 +-
xen/arch/x86/mm/mem_paging.c | 16 +-
xen/arch/x86/mm/mem_sharing.c | 31 +-
xen/arch/x86/mm/p2m-pod.c | 4 +-
xen/arch/x86/mm/p2m-pt.c | 4 +-
xen/arch/x86/mm/p2m.c | 213 ++++++-----
xen/arch/x86/x86_64/compat/mm.c | 12 +-
xen/arch/x86/x86_64/mm.c | 13 +-
xen/common/Makefile | 2 +-
xen/common/domain.c | 12 +-
xen/common/domctl.c | 6 +-
xen/common/mem_access.c | 24 +-
xen/common/mem_event.c | 742 ------------------------------------
xen/common/vm_event.c | 742 ++++++++++++++++++++++++++++++++++++
xen/drivers/passthrough/pci.c | 2 +-
xen/include/Makefile | 2 +-
xen/include/asm-arm/p2m.h | 6 +-
xen/include/asm-x86/domain.h | 4 +-
xen/include/asm-x86/hvm/emulate.h | 2 +-
xen/include/asm-x86/hvm/event.h | 40 ++
xen/include/asm-x86/hvm/hvm.h | 11 -
xen/include/asm-x86/mem_paging.h | 2 +-
xen/include/asm-x86/p2m.h | 16 +-
xen/include/public/domctl.h | 44 +--
xen/include/public/hvm/params.h | 2 +-
xen/include/public/mem_event.h | 134 -------
xen/include/public/memory.h | 6 +-
xen/include/public/vm_event.h | 197 ++++++++++
xen/include/xen/mem_access.h | 4 +-
xen/include/xen/mem_event.h | 143 -------
xen/include/xen/p2m-common.h | 4 +-
xen/include/xen/sched.h | 24 +-
xen/include/xen/vm_event.h | 87 +++++
xen/include/xsm/dummy.h | 6 +-
xen/include/xsm/xsm.h | 14 +-
xen/xsm/dummy.c | 6 +-
xen/xsm/flask/hooks.c | 36 +-
xen/xsm/flask/policy/access_vectors | 2 +-
63 files changed, 1909 insertions(+), 1892 deletions(-)
delete mode 100644 tools/libxc/xc_mem_event.c
create mode 100644 tools/libxc/xc_vm_event.c
create mode 100644 xen/arch/x86/hvm/event.c
delete mode 100644 xen/common/mem_event.c
create mode 100644 xen/common/vm_event.c
create mode 100644 xen/include/asm-x86/hvm/event.h
delete mode 100644 xen/include/public/mem_event.h
create mode 100644 xen/include/public/vm_event.h
delete mode 100644 xen/include/xen/mem_event.h
create mode 100644 xen/include/xen/vm_event.h
--
2.1.4
^ permalink raw reply [flat|nested] 53+ messages in thread
* [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-18 15:17 [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Tamas K Lengyel
@ 2015-01-18 15:17 ` Tamas K Lengyel
2015-01-22 12:43 ` Tim Deegan
2015-01-22 15:00 ` Jan Beulich
2015-01-18 15:17 ` [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor' Tamas K Lengyel
` (7 subsequent siblings)
8 siblings, 2 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-18 15:17 UTC (permalink / raw)
To: xen-devel
Cc: kevin.tian, wei.liu2, ian.campbell, Razvan Cojocaru,
stefano.stabellini, jun.nakajima, tim, ian.jackson, eddie.dong,
andres, jbeulich, Tamas K Lengyel, rshriram, keir, dgdegra,
yanghy
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
The public mem_event structures used to communicate with helper applications via
shared rings have been used in different settings. However, the variable names
within this structure have not reflected this fact, resulting in the reuse of
variables to mean different things under different scenarios.
This patch remedies the issue by clearly defining the structure members based on
the actual context within which the structure is used.
Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
---
tools/tests/xen-access/xen-access.c | 33 ++++---
tools/xenpaging/xenpaging.c | 34 +++----
xen/arch/x86/hvm/hvm.c | 185 ++++++++++++++++++++----------------
xen/arch/x86/mm/mem_sharing.c | 7 +-
xen/arch/x86/mm/p2m.c | 129 +++++++++++++------------
xen/include/Makefile | 2 +-
xen/include/public/mem_event.h | 99 +++++++++++++++----
7 files changed, 292 insertions(+), 197 deletions(-)
diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c
index 6cb382d..9d53fb3 100644
--- a/tools/tests/xen-access/xen-access.c
+++ b/tools/tests/xen-access/xen-access.c
@@ -556,8 +556,8 @@ int main(int argc, char *argv[])
rsp.flags = req.flags;
switch (req.reason) {
- case MEM_EVENT_REASON_VIOLATION:
- rc = xc_get_mem_access(xch, domain_id, req.gfn, &access);
+ case MEM_EVENT_REASON_MEM_ACCESS_VIOLATION:
+ rc = xc_get_mem_access(xch, domain_id, req.mem_access_event.gfn, &access);
if (rc < 0)
{
ERROR("Error %d getting mem_access event\n", rc);
@@ -567,21 +567,21 @@ int main(int argc, char *argv[])
printf("PAGE ACCESS: %c%c%c for GFN %"PRIx64" (offset %06"
PRIx64") gla %016"PRIx64" (valid: %c; fault in gpt: %c; fault with gla: %c) (vcpu %u)\n",
- req.access_r ? 'r' : '-',
- req.access_w ? 'w' : '-',
- req.access_x ? 'x' : '-',
- req.gfn,
- req.offset,
- req.gla,
- req.gla_valid ? 'y' : 'n',
- req.fault_in_gpt ? 'y' : 'n',
- req.fault_with_gla ? 'y': 'n',
+ req.mem_access_event.access_r ? 'r' : '-',
+ req.mem_access_event.access_w ? 'w' : '-',
+ req.mem_access_event.access_x ? 'x' : '-',
+ req.mem_access_event.gfn,
+ req.mem_access_event.offset,
+ req.mem_access_event.gla,
+ req.mem_access_event.gla_valid ? 'y' : 'n',
+ req.mem_access_event.fault_in_gpt ? 'y' : 'n',
+ req.mem_access_event.fault_with_gla ? 'y': 'n',
req.vcpu_id);
if ( default_access != after_first_access )
{
rc = xc_set_mem_access(xch, domain_id, after_first_access,
- req.gfn, 1);
+ req.mem_access_event.gfn, 1);
if (rc < 0)
{
ERROR("Error %d setting gfn to access_type %d\n", rc,
@@ -592,13 +592,12 @@ int main(int argc, char *argv[])
}
- rsp.gfn = req.gfn;
- rsp.p2mt = req.p2mt;
+ rsp.mem_access_event.gfn = req.mem_access_event.gfn;
break;
case MEM_EVENT_REASON_INT3:
- printf("INT3: rip=%016"PRIx64", gfn=%"PRIx64" (vcpu %d)\n",
- req.gla,
- req.gfn,
+ printf("INT3: rip=%016"PRIx64", gfn=%"PRIx64" (vcpu %d)\n",
+ req.int3_event.gla,
+ req.int3_event.gfn,
req.vcpu_id);
/* Reinject */
diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c
index 82c1ee4..148b3e7 100644
--- a/tools/xenpaging/xenpaging.c
+++ b/tools/xenpaging/xenpaging.c
@@ -684,9 +684,9 @@ static int xenpaging_resume_page(struct xenpaging *paging, mem_event_response_t
* This allows page-out of these gfns if the target grows again.
*/
if (paging->num_paged_out > paging->policy_mru_size)
- policy_notify_paged_in(rsp->gfn);
+ policy_notify_paged_in(rsp->mem_paging_event.gfn);
else
- policy_notify_paged_in_nomru(rsp->gfn);
+ policy_notify_paged_in_nomru(rsp->mem_paging_event.gfn);
/* Record number of resumed pages */
paging->num_paged_out--;
@@ -910,49 +910,49 @@ int main(int argc, char *argv[])
get_request(&paging->mem_event, &req);
- if ( req.gfn > paging->max_pages )
+ if ( req.mem_paging_event.gfn > paging->max_pages )
{
- ERROR("Requested gfn %"PRIx64" higher than max_pages %x\n", req.gfn, paging->max_pages);
+ ERROR("Requested gfn %"PRIx64" higher than max_pages %x\n", req.mem_paging_event.gfn, paging->max_pages);
goto out;
}
/* Check if the page has already been paged in */
- if ( test_and_clear_bit(req.gfn, paging->bitmap) )
+ if ( test_and_clear_bit(req.mem_paging_event.gfn, paging->bitmap) )
{
/* Find where in the paging file to read from */
- slot = paging->gfn_to_slot[req.gfn];
+ slot = paging->gfn_to_slot[req.mem_paging_event.gfn];
/* Sanity check */
- if ( paging->slot_to_gfn[slot] != req.gfn )
+ if ( paging->slot_to_gfn[slot] != req.mem_paging_event.gfn )
{
- ERROR("Expected gfn %"PRIx64" in slot %d, but found gfn %lx\n", req.gfn, slot, paging->slot_to_gfn[slot]);
+ ERROR("Expected gfn %"PRIx64" in slot %d, but found gfn %lx\n", req.mem_paging_event.gfn, slot, paging->slot_to_gfn[slot]);
goto out;
}
if ( req.flags & MEM_EVENT_FLAG_DROP_PAGE )
{
- DPRINTF("drop_page ^ gfn %"PRIx64" pageslot %d\n", req.gfn, slot);
+ DPRINTF("drop_page ^ gfn %"PRIx64" pageslot %d\n", req.mem_paging_event.gfn, slot);
/* Notify policy of page being dropped */
- policy_notify_dropped(req.gfn);
+ policy_notify_dropped(req.mem_paging_event.gfn);
}
else
{
/* Populate the page */
- if ( xenpaging_populate_page(paging, req.gfn, slot) < 0 )
+ if ( xenpaging_populate_page(paging, req.mem_paging_event.gfn, slot) < 0 )
{
- ERROR("Error populating page %"PRIx64"", req.gfn);
+ ERROR("Error populating page %"PRIx64"", req.mem_paging_event.gfn);
goto out;
}
}
/* Prepare the response */
- rsp.gfn = req.gfn;
+ rsp.mem_paging_event.gfn = req.mem_paging_event.gfn;
rsp.vcpu_id = req.vcpu_id;
rsp.flags = req.flags;
if ( xenpaging_resume_page(paging, &rsp, 1) < 0 )
{
- PERROR("Error resuming page %"PRIx64"", req.gfn);
+ PERROR("Error resuming page %"PRIx64"", req.mem_paging_event.gfn);
goto out;
}
@@ -967,7 +967,7 @@ int main(int argc, char *argv[])
DPRINTF("page %s populated (domain = %d; vcpu = %d;"
" gfn = %"PRIx64"; paused = %d; evict_fail = %d)\n",
req.flags & MEM_EVENT_FLAG_EVICT_FAIL ? "not" : "already",
- paging->mem_event.domain_id, req.vcpu_id, req.gfn,
+ paging->mem_event.domain_id, req.vcpu_id, req.mem_paging_event.gfn,
!!(req.flags & MEM_EVENT_FLAG_VCPU_PAUSED) ,
!!(req.flags & MEM_EVENT_FLAG_EVICT_FAIL) );
@@ -975,13 +975,13 @@ int main(int argc, char *argv[])
if (( req.flags & MEM_EVENT_FLAG_VCPU_PAUSED ) || ( req.flags & MEM_EVENT_FLAG_EVICT_FAIL ))
{
/* Prepare the response */
- rsp.gfn = req.gfn;
+ rsp.mem_paging_event.gfn = req.mem_paging_event.gfn;
rsp.vcpu_id = req.vcpu_id;
rsp.flags = req.flags;
if ( xenpaging_resume_page(paging, &rsp, 0) < 0 )
{
- PERROR("Error resuming page %"PRIx64"", req.gfn);
+ PERROR("Error resuming page %"PRIx64"", req.mem_paging_event.gfn);
goto out;
}
}
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index bc414ff..bd8c393 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -6176,48 +6176,42 @@ static void hvm_mem_event_fill_regs(mem_event_request_t *req)
const struct cpu_user_regs *regs = guest_cpu_user_regs();
const struct vcpu *curr = current;
- req->x86_regs.rax = regs->eax;
- req->x86_regs.rcx = regs->ecx;
- req->x86_regs.rdx = regs->edx;
- req->x86_regs.rbx = regs->ebx;
- req->x86_regs.rsp = regs->esp;
- req->x86_regs.rbp = regs->ebp;
- req->x86_regs.rsi = regs->esi;
- req->x86_regs.rdi = regs->edi;
-
- req->x86_regs.r8 = regs->r8;
- req->x86_regs.r9 = regs->r9;
- req->x86_regs.r10 = regs->r10;
- req->x86_regs.r11 = regs->r11;
- req->x86_regs.r12 = regs->r12;
- req->x86_regs.r13 = regs->r13;
- req->x86_regs.r14 = regs->r14;
- req->x86_regs.r15 = regs->r15;
-
- req->x86_regs.rflags = regs->eflags;
- req->x86_regs.rip = regs->eip;
-
- req->x86_regs.msr_efer = curr->arch.hvm_vcpu.guest_efer;
- req->x86_regs.cr0 = curr->arch.hvm_vcpu.guest_cr[0];
- req->x86_regs.cr3 = curr->arch.hvm_vcpu.guest_cr[3];
- req->x86_regs.cr4 = curr->arch.hvm_vcpu.guest_cr[4];
-}
-
-static int hvm_memory_event_traps(long p, uint32_t reason,
- unsigned long value, unsigned long old,
- bool_t gla_valid, unsigned long gla)
-{
- struct vcpu* v = current;
- struct domain *d = v->domain;
- mem_event_request_t req = { .reason = reason };
+ req->regs.x86.rax = regs->eax;
+ req->regs.x86.rcx = regs->ecx;
+ req->regs.x86.rdx = regs->edx;
+ req->regs.x86.rbx = regs->ebx;
+ req->regs.x86.rsp = regs->esp;
+ req->regs.x86.rbp = regs->ebp;
+ req->regs.x86.rsi = regs->esi;
+ req->regs.x86.rdi = regs->edi;
+
+ req->regs.x86.r8 = regs->r8;
+ req->regs.x86.r9 = regs->r9;
+ req->regs.x86.r10 = regs->r10;
+ req->regs.x86.r11 = regs->r11;
+ req->regs.x86.r12 = regs->r12;
+ req->regs.x86.r13 = regs->r13;
+ req->regs.x86.r14 = regs->r14;
+ req->regs.x86.r15 = regs->r15;
+
+ req->regs.x86.rflags = regs->eflags;
+ req->regs.x86.rip = regs->eip;
+
+ req->regs.x86.msr_efer = curr->arch.hvm_vcpu.guest_efer;
+ req->regs.x86.cr0 = curr->arch.hvm_vcpu.guest_cr[0];
+ req->regs.x86.cr3 = curr->arch.hvm_vcpu.guest_cr[3];
+ req->regs.x86.cr4 = curr->arch.hvm_vcpu.guest_cr[4];
+}
+
+static int hvm_memory_event_traps(long parameters, mem_event_request_t *req)
+{
int rc;
+ struct vcpu *v = current;
+ struct domain *d = v->domain;
- if ( !(p & HVMPME_MODE_MASK) )
+ if ( !(parameters & HVMPME_MODE_MASK) )
return 0;
- if ( (p & HVMPME_onchangeonly) && (value == old) )
- return 1;
-
rc = mem_event_claim_slot(d, &d->mem_event->access);
if ( rc == -ENOSYS )
{
@@ -6228,85 +6222,114 @@ static int hvm_memory_event_traps(long p, uint32_t reason,
else if ( rc < 0 )
return rc;
- if ( (p & HVMPME_MODE_MASK) == HVMPME_mode_sync )
+ if ( (parameters & HVMPME_MODE_MASK) == HVMPME_mode_sync )
{
- req.flags |= MEM_EVENT_FLAG_VCPU_PAUSED;
+ req->flags |= MEM_EVENT_FLAG_VCPU_PAUSED;
mem_event_vcpu_pause(v);
}
- req.gfn = value;
- req.vcpu_id = v->vcpu_id;
- if ( gla_valid )
- {
- req.offset = gla & ((1 << PAGE_SHIFT) - 1);
- req.gla = gla;
- req.gla_valid = 1;
- }
- else
- {
- req.gla = old;
- }
-
- hvm_mem_event_fill_regs(&req);
- mem_event_put_request(d, &d->mem_event->access, &req);
-
+ hvm_mem_event_fill_regs(req);
+ mem_event_put_request(d, &d->mem_event->access, req);
+
return 1;
}
void hvm_memory_event_cr0(unsigned long value, unsigned long old)
{
- hvm_memory_event_traps(current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_CR0],
- MEM_EVENT_REASON_CR0,
- value, old, 0, 0);
+ mem_event_request_t req = {
+ .reason = MEM_EVENT_REASON_CR0,
+ .vcpu_id = current->vcpu_id,
+ .cr_event.new_value = value,
+ .cr_event.old_value = old
+ };
+
+ long parameters = current->domain->arch.hvm_domain
+ .params[HVM_PARAM_MEMORY_EVENT_CR0];
+
+ if ( (parameters & HVMPME_onchangeonly) && (value == old) )
+ return;
+
+ hvm_memory_event_traps(parameters, &req);
}
void hvm_memory_event_cr3(unsigned long value, unsigned long old)
{
- hvm_memory_event_traps(current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_CR3],
- MEM_EVENT_REASON_CR3,
- value, old, 0, 0);
+ mem_event_request_t req = {
+ .reason = MEM_EVENT_REASON_CR3,
+ .vcpu_id = current->vcpu_id,
+ .cr_event.new_value = value,
+ .cr_event.old_value = old
+ };
+
+ long parameters = current->domain->arch.hvm_domain
+ .params[HVM_PARAM_MEMORY_EVENT_CR3];
+
+ if ( (parameters & HVMPME_onchangeonly) && (value == old) )
+ return;
+
+ hvm_memory_event_traps(parameters, &req);
}
void hvm_memory_event_cr4(unsigned long value, unsigned long old)
{
- hvm_memory_event_traps(current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_CR4],
- MEM_EVENT_REASON_CR4,
- value, old, 0, 0);
+ mem_event_request_t req = {
+ .reason = MEM_EVENT_REASON_CR4,
+ .vcpu_id = current->vcpu_id,
+ .cr_event.new_value = value,
+ .cr_event.old_value = old
+ };
+
+ long parameters = current->domain->arch.hvm_domain
+ .params[HVM_PARAM_MEMORY_EVENT_CR4];
+
+ if ( (parameters & HVMPME_onchangeonly) && (value == old) )
+ return;
+
+ hvm_memory_event_traps(parameters, &req);
}
void hvm_memory_event_msr(unsigned long msr, unsigned long value)
{
+ mem_event_request_t req = {
+ .reason = MEM_EVENT_REASON_MSR,
+ .vcpu_id = current->vcpu_id,
+ .msr_event.msr = msr,
+ .msr_event.new_value = value,
+ };
+
hvm_memory_event_traps(current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_MSR],
- MEM_EVENT_REASON_MSR,
- value, ~value, 1, msr);
+ .params[HVM_PARAM_MEMORY_EVENT_MSR],
+ &req);
}
int hvm_memory_event_int3(unsigned long gla)
{
uint32_t pfec = PFEC_page_present;
- unsigned long gfn;
- gfn = paging_gva_to_gfn(current, gla, &pfec);
+ mem_event_request_t req = {
+ .reason = MEM_EVENT_REASON_INT3,
+ .vcpu_id = current->vcpu_id,
+ .int3_event.gla = gla,
+ .int3_event.gfn = paging_gva_to_gfn(current, gla, &pfec)
+ };
return hvm_memory_event_traps(current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_INT3],
- MEM_EVENT_REASON_INT3,
- gfn, 0, 1, gla);
+ .params[HVM_PARAM_MEMORY_EVENT_INT3],
+ &req);
}
int hvm_memory_event_single_step(unsigned long gla)
{
uint32_t pfec = PFEC_page_present;
- unsigned long gfn;
- gfn = paging_gva_to_gfn(current, gla, &pfec);
+ mem_event_request_t req = {
+ .reason = MEM_EVENT_REASON_SINGLESTEP,
+ .vcpu_id = current->vcpu_id,
+ .singlestep_event.gla = gla,
+ .singlestep_event.gfn = paging_gva_to_gfn(current, gla, &pfec)
+ };
return hvm_memory_event_traps(current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_SINGLE_STEP],
- MEM_EVENT_REASON_SINGLESTEP,
- gfn, 0, 1, gla);
+ .params[HVM_PARAM_MEMORY_EVENT_SINGLE_STEP],
+ &req);
}
int nhvm_vcpu_hostrestore(struct vcpu *v, struct cpu_user_regs *regs)
diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
index 7c0fc7d..c15edcc 100644
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -559,7 +559,10 @@ int mem_sharing_notify_enomem(struct domain *d, unsigned long gfn,
{
struct vcpu *v = current;
int rc;
- mem_event_request_t req = { .gfn = gfn };
+ mem_event_request_t req = {
+ .reason = MEM_EVENT_REASON_MEM_SHARING,
+ .mem_sharing_event.gfn = gfn
+ };
if ( (rc = __mem_event_claim_slot(d,
&d->mem_event->share, allow_sleep)) < 0 )
@@ -571,7 +574,7 @@ int mem_sharing_notify_enomem(struct domain *d, unsigned long gfn,
mem_event_vcpu_pause(v);
}
- req.p2mt = p2m_ram_shared;
+ req.mem_sharing_event.p2mt = p2m_ram_shared;
req.vcpu_id = v->vcpu_id;
mem_event_put_request(d, &d->mem_event->share, &req);
diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
index efa49dd..8ec0150 100644
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -1077,7 +1077,10 @@ int p2m_mem_paging_evict(struct domain *d, unsigned long gfn)
void p2m_mem_paging_drop_page(struct domain *d, unsigned long gfn,
p2m_type_t p2mt)
{
- mem_event_request_t req = { .gfn = gfn };
+ mem_event_request_t req = {
+ .reason = MEM_EVENT_REASON_MEM_PAGING,
+ .mem_paging_event.gfn = gfn
+ };
/* We allow no ring in this unique case, because it won't affect
* correctness of the guest execution at this point. If this is the only
@@ -1124,7 +1127,10 @@ void p2m_mem_paging_drop_page(struct domain *d, unsigned long gfn,
void p2m_mem_paging_populate(struct domain *d, unsigned long gfn)
{
struct vcpu *v = current;
- mem_event_request_t req = { .gfn = gfn };
+ mem_event_request_t req = {
+ .reason = MEM_EVENT_REASON_MEM_PAGING,
+ .mem_paging_event.gfn = gfn
+ };
p2m_type_t p2mt;
p2m_access_t a;
mfn_t mfn;
@@ -1174,7 +1180,7 @@ void p2m_mem_paging_populate(struct domain *d, unsigned long gfn)
}
/* Send request to pager */
- req.p2mt = p2mt;
+ req.mem_paging_event.p2mt = p2mt;
req.vcpu_id = v->vcpu_id;
mem_event_put_request(d, &d->mem_event->paging, &req);
@@ -1309,15 +1315,15 @@ void p2m_mem_paging_resume(struct domain *d)
if ( !(rsp.flags & MEM_EVENT_FLAG_DROP_PAGE) )
{
gfn_lock(p2m, rsp.gfn, 0);
- mfn = p2m->get_entry(p2m, rsp.gfn, &p2mt, &a, 0, NULL);
+ mfn = p2m->get_entry(p2m, rsp.mem_access_event.gfn, &p2mt, &a, 0, NULL);
/* Allow only pages which were prepared properly, or pages which
* were nominated but not evicted */
if ( mfn_valid(mfn) && (p2mt == p2m_ram_paging_in) )
{
- p2m_set_entry(p2m, rsp.gfn, mfn, PAGE_ORDER_4K,
+ p2m_set_entry(p2m, rsp.mem_access_event.gfn, mfn, PAGE_ORDER_4K,
paging_mode_log_dirty(d) ? p2m_ram_logdirty :
p2m_ram_rw, a);
- set_gpfn_from_mfn(mfn_x(mfn), rsp.gfn);
+ set_gpfn_from_mfn(mfn_x(mfn), rsp.mem_access_event.gfn);
}
gfn_unlock(p2m, rsp.gfn, 0);
}
@@ -1337,49 +1343,49 @@ static void p2m_mem_event_fill_regs(mem_event_request_t *req)
/* Architecture-specific vmcs/vmcb bits */
hvm_funcs.save_cpu_ctxt(curr, &ctxt);
- req->x86_regs.rax = regs->eax;
- req->x86_regs.rcx = regs->ecx;
- req->x86_regs.rdx = regs->edx;
- req->x86_regs.rbx = regs->ebx;
- req->x86_regs.rsp = regs->esp;
- req->x86_regs.rbp = regs->ebp;
- req->x86_regs.rsi = regs->esi;
- req->x86_regs.rdi = regs->edi;
-
- req->x86_regs.r8 = regs->r8;
- req->x86_regs.r9 = regs->r9;
- req->x86_regs.r10 = regs->r10;
- req->x86_regs.r11 = regs->r11;
- req->x86_regs.r12 = regs->r12;
- req->x86_regs.r13 = regs->r13;
- req->x86_regs.r14 = regs->r14;
- req->x86_regs.r15 = regs->r15;
-
- req->x86_regs.rflags = regs->eflags;
- req->x86_regs.rip = regs->eip;
-
- req->x86_regs.dr7 = curr->arch.debugreg[7];
- req->x86_regs.cr0 = ctxt.cr0;
- req->x86_regs.cr2 = ctxt.cr2;
- req->x86_regs.cr3 = ctxt.cr3;
- req->x86_regs.cr4 = ctxt.cr4;
-
- req->x86_regs.sysenter_cs = ctxt.sysenter_cs;
- req->x86_regs.sysenter_esp = ctxt.sysenter_esp;
- req->x86_regs.sysenter_eip = ctxt.sysenter_eip;
-
- req->x86_regs.msr_efer = ctxt.msr_efer;
- req->x86_regs.msr_star = ctxt.msr_star;
- req->x86_regs.msr_lstar = ctxt.msr_lstar;
+ req->regs.x86.rax = regs->eax;
+ req->regs.x86.rcx = regs->ecx;
+ req->regs.x86.rdx = regs->edx;
+ req->regs.x86.rbx = regs->ebx;
+ req->regs.x86.rsp = regs->esp;
+ req->regs.x86.rbp = regs->ebp;
+ req->regs.x86.rsi = regs->esi;
+ req->regs.x86.rdi = regs->edi;
+
+ req->regs.x86.r8 = regs->r8;
+ req->regs.x86.r9 = regs->r9;
+ req->regs.x86.r10 = regs->r10;
+ req->regs.x86.r11 = regs->r11;
+ req->regs.x86.r12 = regs->r12;
+ req->regs.x86.r13 = regs->r13;
+ req->regs.x86.r14 = regs->r14;
+ req->regs.x86.r15 = regs->r15;
+
+ req->regs.x86.rflags = regs->eflags;
+ req->regs.x86.rip = regs->eip;
+
+ req->regs.x86.dr7 = curr->arch.debugreg[7];
+ req->regs.x86.cr0 = ctxt.cr0;
+ req->regs.x86.cr2 = ctxt.cr2;
+ req->regs.x86.cr3 = ctxt.cr3;
+ req->regs.x86.cr4 = ctxt.cr4;
+
+ req->regs.x86.sysenter_cs = ctxt.sysenter_cs;
+ req->regs.x86.sysenter_esp = ctxt.sysenter_esp;
+ req->regs.x86.sysenter_eip = ctxt.sysenter_eip;
+
+ req->regs.x86.msr_efer = ctxt.msr_efer;
+ req->regs.x86.msr_star = ctxt.msr_star;
+ req->regs.x86.msr_lstar = ctxt.msr_lstar;
hvm_get_segment_register(curr, x86_seg_fs, &seg);
- req->x86_regs.fs_base = seg.base;
+ req->regs.x86.fs_base = seg.base;
hvm_get_segment_register(curr, x86_seg_gs, &seg);
- req->x86_regs.gs_base = seg.base;
+ req->regs.x86.gs_base = seg.base;
hvm_get_segment_register(curr, x86_seg_cs, &seg);
- req->x86_regs.cs_arbytes = seg.attr.bytes;
+ req->regs.x86.cs_arbytes = seg.attr.bytes;
}
void p2m_mem_event_emulate_check(struct vcpu *v, const mem_event_response_t *rsp)
@@ -1390,39 +1396,40 @@ void p2m_mem_event_emulate_check(struct vcpu *v, const mem_event_response_t *rsp
xenmem_access_t access;
bool_t violation = 1;
- if ( p2m_get_mem_access(v->domain, rsp->gfn, &access) == 0 )
+ if ( p2m_get_mem_access(v->domain, rsp->mem_access_event.gfn, &access) == 0 )
{
switch ( access )
{
case XENMEM_access_n:
case XENMEM_access_n2rwx:
default:
- violation = rsp->access_r || rsp->access_w || rsp->access_x;
+ violation = rsp->mem_access_event.access_r || rsp->mem_access_event.access_w ||
+ rsp->mem_access_event.access_x;
break;
case XENMEM_access_r:
- violation = rsp->access_w || rsp->access_x;
+ violation = rsp->mem_access_event.access_w || rsp->mem_access_event.access_x;
break;
case XENMEM_access_w:
- violation = rsp->access_r || rsp->access_x;
+ violation = rsp->mem_access_event.access_r || rsp->mem_access_event.access_x;
break;
case XENMEM_access_x:
- violation = rsp->access_r || rsp->access_w;
+ violation = rsp->mem_access_event.access_r || rsp->mem_access_event.access_w;
break;
case XENMEM_access_rx:
case XENMEM_access_rx2rw:
- violation = rsp->access_w;
+ violation = rsp->mem_access_event.access_w;
break;
case XENMEM_access_wx:
- violation = rsp->access_r;
+ violation = rsp->mem_access_event.access_r;
break;
case XENMEM_access_rw:
- violation = rsp->access_x;
+ violation = rsp->mem_access_event.access_x;
break;
case XENMEM_access_rwx:
@@ -1540,24 +1547,24 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
if ( req )
{
*req_ptr = req;
- req->reason = MEM_EVENT_REASON_VIOLATION;
+ req->reason = MEM_EVENT_REASON_MEM_ACCESS_VIOLATION;
/* Pause the current VCPU */
if ( p2ma != p2m_access_n2rwx )
req->flags |= MEM_EVENT_FLAG_VCPU_PAUSED;
/* Send request to mem event */
- req->gfn = gfn;
- req->offset = gpa & ((1 << PAGE_SHIFT) - 1);
- req->gla_valid = npfec.gla_valid;
- req->gla = gla;
+ req->mem_access_event.gfn = gfn;
+ req->mem_access_event.offset = gpa & ((1 << PAGE_SHIFT) - 1);
+ req->mem_access_event.gla_valid = npfec.gla_valid;
+ req->mem_access_event.gla = gla;
if ( npfec.kind == npfec_kind_with_gla )
- req->fault_with_gla = 1;
+ req->mem_access_event.fault_with_gla = 1;
else if ( npfec.kind == npfec_kind_in_gpt )
- req->fault_in_gpt = 1;
- req->access_r = npfec.read_access;
- req->access_w = npfec.write_access;
- req->access_x = npfec.insn_fetch;
+ req->mem_access_event.fault_in_gpt = 1;
+ req->mem_access_event.access_r = npfec.read_access;
+ req->mem_access_event.access_w = npfec.write_access;
+ req->mem_access_event.access_x = npfec.insn_fetch;
req->vcpu_id = v->vcpu_id;
p2m_mem_event_fill_regs(req);
diff --git a/xen/include/Makefile b/xen/include/Makefile
index f7ccbc9..530db83 100644
--- a/xen/include/Makefile
+++ b/xen/include/Makefile
@@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
all: headers.chk
-headers.chk: $(filter-out public/arch-% public/%ctl.h public/xsm/% public/%hvm/save.h, $(wildcard public/*.h public/*/*.h) $(public-y)) Makefile
+headers.chk: $(filter-out public/arch-% public/%ctl.h public/mem_event.h public/xsm/% public/%hvm/save.h, $(wildcard public/*.h public/*/*.h) $(public-y)) Makefile
for i in $(filter %.h,$^); do $(CC) -ansi -include stdint.h -Wall -W -Werror -S -o /dev/null -x c $$i || exit 1; echo $$i; done >$@.new
mv $@.new $@
diff --git a/xen/include/public/mem_event.h b/xen/include/public/mem_event.h
index 599f9e8..dbcc48b 100644
--- a/xen/include/public/mem_event.h
+++ b/xen/include/public/mem_event.h
@@ -27,9 +27,15 @@
#ifndef _XEN_PUBLIC_MEM_EVENT_H
#define _XEN_PUBLIC_MEM_EVENT_H
+#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
+#error "vm event operations are intended for use only by Xen or node control tools"
+#endif
+
#include "xen.h"
#include "io/ring.h"
+#define MEM_EVENT_INTERFACE_VERSION 0x00000001
+
/* Memory event flags */
#define MEM_EVENT_FLAG_VCPU_PAUSED (1 << 0)
#define MEM_EVENT_FLAG_DROP_PAGE (1 << 1)
@@ -48,16 +54,27 @@
*/
#define MEM_EVENT_FLAG_EMULATE_NOWRITE (1 << 6)
-/* Reasons for the memory event request */
-#define MEM_EVENT_REASON_UNKNOWN 0 /* typical reason */
-#define MEM_EVENT_REASON_VIOLATION 1 /* access violation, GFN is address */
-#define MEM_EVENT_REASON_CR0 2 /* CR0 was hit: gfn is new CR0 value, gla is previous */
-#define MEM_EVENT_REASON_CR3 3 /* CR3 was hit: gfn is new CR3 value, gla is previous */
-#define MEM_EVENT_REASON_CR4 4 /* CR4 was hit: gfn is new CR4 value, gla is previous */
-#define MEM_EVENT_REASON_INT3 5 /* int3 was hit: gla/gfn are RIP */
-#define MEM_EVENT_REASON_SINGLESTEP 6 /* single step was invoked: gla/gfn are RIP */
-#define MEM_EVENT_REASON_MSR 7 /* MSR was hit: gfn is MSR value, gla is MSR address;
- does NOT honour HVMPME_onchangeonly */
+/* Reasons for the vm event request */
+/* Default case */
+#define MEM_EVENT_REASON_UNKNOWN 0
+/* Memory access violation */
+#define MEM_EVENT_REASON_MEM_ACCESS_VIOLATION 1
+/* Memory sharing event */
+#define MEM_EVENT_REASON_MEM_SHARING 2
+/* Memory paging event */
+#define MEM_EVENT_REASON_MEM_PAGING 3
+/* CR0 was updated */
+#define MEM_EVENT_REASON_CR0 4
+/* CR3 was updated */
+#define MEM_EVENT_REASON_CR3 5
+/* CR4 was updated */
+#define MEM_EVENT_REASON_CR4 6
+/* Debug operation executed (int3) */
+#define MEM_EVENT_REASON_INT3 7
+/* Single-step (MTF) */
+#define MEM_EVENT_REASON_SINGLESTEP 8
+/* An MSR was updated. Does NOT honour HVMPME_onchangeonly */
+#define MEM_EVENT_REASON_MSR 9
/* Using a custom struct (not hvm_hw_cpu) so as to not fill
* the mem_event ring buffer too quickly. */
@@ -97,16 +114,16 @@ struct mem_event_regs_x86 {
uint32_t _pad;
};
-typedef struct mem_event_st {
- uint32_t flags;
- uint32_t vcpu_id;
+struct mem_event_regs {
+ union {
+ struct mem_event_regs_x86 x86;
+ };
+};
+struct mem_event_mem_access_data {
uint64_t gfn;
uint64_t offset;
uint64_t gla; /* if gla_valid */
-
- uint32_t p2mt;
-
uint16_t access_r:1;
uint16_t access_w:1;
uint16_t access_x:1;
@@ -114,9 +131,55 @@ typedef struct mem_event_st {
uint16_t fault_with_gla:1;
uint16_t fault_in_gpt:1;
uint16_t available:10;
+};
+
+struct mem_event_cr_data {
+ uint64_t new_value;
+ uint64_t old_value;
+};
+
+struct mem_event_int3_data {
+ uint64_t gfn;
+ uint64_t gla;
+};
+
+struct mem_event_singlestep_data {
+ uint64_t gfn;
+ uint64_t gla;
+};
+
+struct mem_event_msr_data {
+ uint64_t msr;
+ uint64_t old_value;
+ uint64_t new_value;
+};
+
+struct mem_event_paging_data {
+ uint64_t gfn;
+ uint32_t p2mt;
+};
+
+struct mem_event_sharing_data {
+ uint64_t gfn;
+ uint32_t p2mt;
+};
+
+typedef struct mem_event_st {
+ uint32_t flags;
+ uint32_t vcpu_id;
+ uint32_t reason;
+
+ union {
+ struct mem_event_paging_data mem_paging_event;
+ struct mem_event_sharing_data mem_sharing_event;
+ struct mem_event_mem_access_data mem_access_event;
+ struct mem_event_cr_data cr_event;
+ struct mem_event_int3_data int3_event;
+ struct mem_event_singlestep_data singlestep_event;
+ struct mem_event_msr_data msr_event;
+ };
- uint16_t reason;
- struct mem_event_regs_x86 x86_regs;
+ struct mem_event_regs regs;
} mem_event_request_t, mem_event_response_t;
DEFINE_RING_TYPES(mem_event, mem_event_request_t, mem_event_response_t);
--
2.1.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'
2015-01-18 15:17 [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Tamas K Lengyel
2015-01-18 15:17 ` [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures Tamas K Lengyel
@ 2015-01-18 15:17 ` Tamas K Lengyel
2015-01-22 12:53 ` Tim Deegan
2015-01-22 15:02 ` Jan Beulich
2015-01-18 15:17 ` [RFC PATCH V2 3/8] xen/mem_paging: Convert mem_event_op to mem_paging_op Tamas K Lengyel
` (6 subsequent siblings)
8 siblings, 2 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-18 15:17 UTC (permalink / raw)
To: xen-devel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, tim, ian.jackson, eddie.dong, andres, jbeulich,
Tamas K Lengyel, rshriram, keir, dgdegra, yanghy
The name of the ring still implies it is used only for memory accesses,
which is no longer the case. It is also used to deliver variuos HVM events,
thus the name "monitor" is more appropriate in this setting.
Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
---
tools/libxc/xc_domain_restore.c | 14 +++++++-------
tools/libxc/xc_domain_save.c | 4 ++--
tools/libxc/xc_hvm_build_x86.c | 2 +-
tools/libxc/xc_mem_access.c | 8 ++++----
tools/libxc/xc_mem_event.c | 8 ++++----
tools/libxc/xg_save_restore.h | 2 +-
xen/arch/x86/hvm/hvm.c | 4 ++--
xen/arch/x86/hvm/vmx/vmcs.c | 2 +-
xen/arch/x86/mm/p2m.c | 2 +-
xen/common/mem_access.c | 8 ++++----
xen/common/mem_event.c | 22 +++++++++++-----------
xen/include/public/domctl.h | 12 ++++++------
xen/include/public/hvm/params.h | 2 +-
xen/include/xen/sched.h | 4 ++--
14 files changed, 47 insertions(+), 47 deletions(-)
diff --git a/tools/libxc/xc_domain_restore.c b/tools/libxc/xc_domain_restore.c
index a382701..2ab9f46 100644
--- a/tools/libxc/xc_domain_restore.c
+++ b/tools/libxc/xc_domain_restore.c
@@ -734,7 +734,7 @@ typedef struct {
uint64_t vcpumap[XC_SR_MAX_VCPUS/64];
uint64_t identpt;
uint64_t paging_ring_pfn;
- uint64_t access_ring_pfn;
+ uint64_t monitor_ring_pfn;
uint64_t sharing_ring_pfn;
uint64_t vm86_tss;
uint64_t console_pfn;
@@ -828,15 +828,15 @@ static int pagebuf_get_one(xc_interface *xch, struct restore_ctx *ctx,
// DPRINTF("paging ring pfn address: %llx\n", buf->paging_ring_pfn);
return pagebuf_get_one(xch, ctx, buf, fd, dom);
- case XC_SAVE_ID_HVM_ACCESS_RING_PFN:
+ case XC_SAVE_ID_HVM_MONITOR_RING_PFN:
/* Skip padding 4 bytes then read the mem access ring location. */
- if ( RDEXACT(fd, &buf->access_ring_pfn, sizeof(uint32_t)) ||
- RDEXACT(fd, &buf->access_ring_pfn, sizeof(uint64_t)) )
+ if ( RDEXACT(fd, &buf->monitor_ring_pfn, sizeof(uint32_t)) ||
+ RDEXACT(fd, &buf->monitor_ring_pfn, sizeof(uint64_t)) )
{
PERROR("error read the access ring pfn");
return -1;
}
- // DPRINTF("access ring pfn address: %llx\n", buf->access_ring_pfn);
+ // DPRINTF("monitor ring pfn address: %llx\n", buf->monitor_ring_pfn);
return pagebuf_get_one(xch, ctx, buf, fd, dom);
case XC_SAVE_ID_HVM_SHARING_RING_PFN:
@@ -1660,8 +1660,8 @@ int xc_domain_restore(xc_interface *xch, int io_fd, uint32_t dom,
xc_hvm_param_set(xch, dom, HVM_PARAM_IDENT_PT, pagebuf.identpt);
if ( pagebuf.paging_ring_pfn )
xc_hvm_param_set(xch, dom, HVM_PARAM_PAGING_RING_PFN, pagebuf.paging_ring_pfn);
- if ( pagebuf.access_ring_pfn )
- xc_hvm_param_set(xch, dom, HVM_PARAM_ACCESS_RING_PFN, pagebuf.access_ring_pfn);
+ if ( pagebuf.monitor_ring_pfn )
+ xc_hvm_param_set(xch, dom, HVM_PARAM_MONITOR_RING_PFN, pagebuf.monitor_ring_pfn);
if ( pagebuf.sharing_ring_pfn )
xc_hvm_param_set(xch, dom, HVM_PARAM_SHARING_RING_PFN, pagebuf.sharing_ring_pfn);
if ( pagebuf.vm86_tss )
diff --git a/tools/libxc/xc_domain_save.c b/tools/libxc/xc_domain_save.c
index 254fdb3..949ef64 100644
--- a/tools/libxc/xc_domain_save.c
+++ b/tools/libxc/xc_domain_save.c
@@ -1664,9 +1664,9 @@ int xc_domain_save(xc_interface *xch, int io_fd, uint32_t dom, uint32_t max_iter
goto out;
}
- chunk.id = XC_SAVE_ID_HVM_ACCESS_RING_PFN;
+ chunk.id = XC_SAVE_ID_HVM_MONITOR_RING_PFN;
chunk.data = 0;
- xc_hvm_param_get(xch, dom, HVM_PARAM_ACCESS_RING_PFN, &chunk.data);
+ xc_hvm_param_get(xch, dom, HVM_PARAM_MONITOR_RING_PFN, &chunk.data);
if ( (chunk.data != 0) &&
wrexact(io_fd, &chunk, sizeof(chunk)) )
diff --git a/tools/libxc/xc_hvm_build_x86.c b/tools/libxc/xc_hvm_build_x86.c
index c81a25b..30a929d 100644
--- a/tools/libxc/xc_hvm_build_x86.c
+++ b/tools/libxc/xc_hvm_build_x86.c
@@ -497,7 +497,7 @@ static int setup_guest(xc_interface *xch,
special_pfn(SPECIALPAGE_CONSOLE));
xc_hvm_param_set(xch, dom, HVM_PARAM_PAGING_RING_PFN,
special_pfn(SPECIALPAGE_PAGING));
- xc_hvm_param_set(xch, dom, HVM_PARAM_ACCESS_RING_PFN,
+ xc_hvm_param_set(xch, dom, HVM_PARAM_MONITOR_RING_PFN,
special_pfn(SPECIALPAGE_ACCESS));
xc_hvm_param_set(xch, dom, HVM_PARAM_SHARING_RING_PFN,
special_pfn(SPECIALPAGE_SHARING));
diff --git a/tools/libxc/xc_mem_access.c b/tools/libxc/xc_mem_access.c
index 55d0e9f..1c979ed 100644
--- a/tools/libxc/xc_mem_access.c
+++ b/tools/libxc/xc_mem_access.c
@@ -26,22 +26,22 @@
void *xc_mem_access_enable(xc_interface *xch, domid_t domain_id, uint32_t *port)
{
- return xc_mem_event_enable(xch, domain_id, HVM_PARAM_ACCESS_RING_PFN,
+ return xc_mem_event_enable(xch, domain_id, HVM_PARAM_MONITOR_RING_PFN,
port, 0);
}
void *xc_mem_access_enable_introspection(xc_interface *xch, domid_t domain_id,
uint32_t *port)
{
- return xc_mem_event_enable(xch, domain_id, HVM_PARAM_ACCESS_RING_PFN,
+ return xc_mem_event_enable(xch, domain_id, HVM_PARAM_MONITOR_RING_PFN,
port, 1);
}
int xc_mem_access_disable(xc_interface *xch, domid_t domain_id)
{
return xc_mem_event_control(xch, domain_id,
- XEN_DOMCTL_MEM_EVENT_OP_ACCESS_DISABLE,
- XEN_DOMCTL_MEM_EVENT_OP_ACCESS,
+ XEN_DOMCTL_MEM_EVENT_OP_MONITOR_DISABLE,
+ XEN_DOMCTL_MEM_EVENT_OP_MONITOR,
NULL);
}
diff --git a/tools/libxc/xc_mem_event.c b/tools/libxc/xc_mem_event.c
index 8c0be4e..20db2ed 100644
--- a/tools/libxc/xc_mem_event.c
+++ b/tools/libxc/xc_mem_event.c
@@ -119,12 +119,12 @@ void *xc_mem_event_enable(xc_interface *xch, domid_t domain_id, int param,
mode = XEN_DOMCTL_MEM_EVENT_OP_PAGING;
break;
- case HVM_PARAM_ACCESS_RING_PFN:
+ case HVM_PARAM_MONITOR_RING_PFN:
if ( enable_introspection )
- op = XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE_INTROSPECTION;
+ op = XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION;
else
- op = XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE;
- mode = XEN_DOMCTL_MEM_EVENT_OP_ACCESS;
+ op = XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE;
+ mode = XEN_DOMCTL_MEM_EVENT_OP_MONITOR;
break;
case HVM_PARAM_SHARING_RING_PFN:
diff --git a/tools/libxc/xg_save_restore.h b/tools/libxc/xg_save_restore.h
index bdd9009..10348aa 100644
--- a/tools/libxc/xg_save_restore.h
+++ b/tools/libxc/xg_save_restore.h
@@ -256,7 +256,7 @@
#define XC_SAVE_ID_HVM_GENERATION_ID_ADDR -14
/* Markers for the pfn's hosting these mem event rings */
#define XC_SAVE_ID_HVM_PAGING_RING_PFN -15
-#define XC_SAVE_ID_HVM_ACCESS_RING_PFN -16
+#define XC_SAVE_ID_HVM_MONITOR_RING_PFN -16
#define XC_SAVE_ID_HVM_SHARING_RING_PFN -17
#define XC_SAVE_ID_TOOLSTACK -18 /* Optional toolstack specific info */
/* These are a pair; it is an error for one to exist without the other */
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index bd8c393..f936d51 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -6212,7 +6212,7 @@ static int hvm_memory_event_traps(long parameters, mem_event_request_t *req)
if ( !(parameters & HVMPME_MODE_MASK) )
return 0;
- rc = mem_event_claim_slot(d, &d->mem_event->access);
+ rc = mem_event_claim_slot(d, &d->mem_event->monitor);
if ( rc == -ENOSYS )
{
/* If there was no ring to handle the event, then
@@ -6229,7 +6229,7 @@ static int hvm_memory_event_traps(long parameters, mem_event_request_t *req)
}
hvm_mem_event_fill_regs(req);
- mem_event_put_request(d, &d->mem_event->access, req);
+ mem_event_put_request(d, &d->mem_event->monitor, req);
return 1;
}
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 9d8033e..e553fb0 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -715,7 +715,7 @@ void vmx_disable_intercept_for_msr(struct vcpu *v, u32 msr, int type)
return;
if ( unlikely(d->arch.hvm_domain.introspection_enabled) &&
- mem_event_check_ring(&d->mem_event->access) )
+ mem_event_check_ring(&d->mem_event->monitor) )
{
unsigned int i;
diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
index 8ec0150..b42322a 100644
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -1489,7 +1489,7 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
gfn_unlock(p2m, gfn, 0);
/* Otherwise, check if there is a memory event listener, and send the message along */
- if ( !mem_event_check_ring(&d->mem_event->access) || !req_ptr )
+ if ( !mem_event_check_ring(&d->mem_event->monitor) || !req_ptr )
{
/* No listener */
if ( p2m->access_required )
diff --git a/xen/common/mem_access.c b/xen/common/mem_access.c
index d8aac5f..f01ccfd 100644
--- a/xen/common/mem_access.c
+++ b/xen/common/mem_access.c
@@ -34,7 +34,7 @@ void mem_access_resume(struct domain *d)
mem_event_response_t rsp;
/* Pull all responses off the ring. */
- while ( mem_event_get_response(d, &d->mem_event->access, &rsp) )
+ while ( mem_event_get_response(d, &d->mem_event->monitor, &rsp) )
{
struct vcpu *v;
@@ -79,7 +79,7 @@ int mem_access_memop(unsigned long cmd,
goto out;
rc = -ENODEV;
- if ( unlikely(!d->mem_event->access.ring_page) )
+ if ( unlikely(!d->mem_event->monitor.ring_page) )
goto out;
switch ( mao.op )
@@ -146,11 +146,11 @@ int mem_access_memop(unsigned long cmd,
int mem_access_send_req(struct domain *d, mem_event_request_t *req)
{
- int rc = mem_event_claim_slot(d, &d->mem_event->access);
+ int rc = mem_event_claim_slot(d, &d->mem_event->monitor);
if ( rc < 0 )
return rc;
- mem_event_put_request(d, &d->mem_event->access, req);
+ mem_event_put_request(d, &d->mem_event->monitor, req);
return 0;
}
diff --git a/xen/common/mem_event.c b/xen/common/mem_event.c
index 16ebdb5..37b5558 100644
--- a/xen/common/mem_event.c
+++ b/xen/common/mem_event.c
@@ -443,7 +443,7 @@ static void mem_paging_notification(struct vcpu *v, unsigned int port)
/* Registered with Xen-bound event channel for incoming notifications. */
static void mem_access_notification(struct vcpu *v, unsigned int port)
{
- if ( likely(v->domain->mem_event->access.ring_page != NULL) )
+ if ( likely(v->domain->mem_event->monitor.ring_page != NULL) )
mem_access_resume(v->domain);
}
#endif
@@ -508,9 +508,9 @@ void mem_event_cleanup(struct domain *d)
}
#endif
#ifdef HAS_MEM_ACCESS
- if ( d->mem_event->access.ring_page ) {
- destroy_waitqueue_head(&d->mem_event->access.wq);
- (void)mem_event_disable(d, &d->mem_event->access);
+ if ( d->mem_event->monitor.ring_page ) {
+ destroy_waitqueue_head(&d->mem_event->monitor.wq);
+ (void)mem_event_disable(d, &d->mem_event->monitor);
}
#endif
#ifdef HAS_MEM_SHARING
@@ -609,32 +609,32 @@ int mem_event_domctl(struct domain *d, xen_domctl_mem_event_op_t *mec,
#endif
#ifdef HAS_MEM_ACCESS
- case XEN_DOMCTL_MEM_EVENT_OP_ACCESS:
+ case XEN_DOMCTL_MEM_EVENT_OP_MONITOR:
{
- struct mem_event_domain *med = &d->mem_event->access;
+ struct mem_event_domain *med = &d->mem_event->monitor;
rc = -EINVAL;
switch( mec->op )
{
- case XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE:
- case XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE_INTROSPECTION:
+ case XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE:
+ case XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION:
{
rc = -ENODEV;
if ( !p2m_mem_event_sanity_check(d) )
break;
rc = mem_event_enable(d, mec, med, _VPF_mem_access,
- HVM_PARAM_ACCESS_RING_PFN,
+ HVM_PARAM_MONITOR_RING_PFN,
mem_access_notification);
- if ( mec->op == XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE_INTROSPECTION
+ if ( mec->op == XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION
&& !rc )
p2m_setup_introspection(d);
}
break;
- case XEN_DOMCTL_MEM_EVENT_OP_ACCESS_DISABLE:
+ case XEN_DOMCTL_MEM_EVENT_OP_MONITOR_DISABLE:
{
if ( med->ring_page )
{
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 57e2ed7..0e3aaf1 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -775,7 +775,7 @@ struct xen_domctl_gdbsx_domstatus {
#define XEN_DOMCTL_MEM_EVENT_OP_PAGING_DISABLE 1
/*
- * Access permissions.
+ * Monitor permissions.
*
* As with paging, use the domctl for teardown/setup of the
* helper<->hypervisor interface.
@@ -788,16 +788,16 @@ struct xen_domctl_gdbsx_domstatus {
* The memory event handler can then resume the VCPU and redo the access
* with a XENMEM_access_op_resume hypercall.
*
- * The XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE domctl returns several
+ * The XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE domctl returns several
* non-standard error codes to indicate why access could not be enabled:
* ENODEV - host lacks HAP support (EPT/NPT) or HAP is disabled in guest
* EBUSY - guest has or had access enabled, ring buffer still active
*/
-#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS 2
+#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR 2
-#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE 0
-#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS_DISABLE 1
-#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE_INTROSPECTION 2
+#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE 0
+#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_DISABLE 1
+#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION 2
/*
* Sharing ENOMEM helper.
diff --git a/xen/include/public/hvm/params.h b/xen/include/public/hvm/params.h
index 3c51072..489ab09 100644
--- a/xen/include/public/hvm/params.h
+++ b/xen/include/public/hvm/params.h
@@ -177,7 +177,7 @@
/* Params for the mem event rings */
#define HVM_PARAM_PAGING_RING_PFN 27
-#define HVM_PARAM_ACCESS_RING_PFN 28
+#define HVM_PARAM_MONITOR_RING_PFN 28
#define HVM_PARAM_SHARING_RING_PFN 29
/* SHUTDOWN_* action in case of a triple fault */
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 46fc6e3..2fc36ea 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -288,8 +288,8 @@ struct mem_event_per_domain
struct mem_event_domain share;
/* Memory paging support */
struct mem_event_domain paging;
- /* Memory access support */
- struct mem_event_domain access;
+ /* VM event monitor support */
+ struct mem_event_domain monitor;
};
struct evtchn_port_ops;
--
2.1.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [RFC PATCH V2 3/8] xen/mem_paging: Convert mem_event_op to mem_paging_op
2015-01-18 15:17 [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Tamas K Lengyel
2015-01-18 15:17 ` [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures Tamas K Lengyel
2015-01-18 15:17 ` [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor' Tamas K Lengyel
@ 2015-01-18 15:17 ` Tamas K Lengyel
2015-01-22 13:03 ` Tim Deegan
2015-01-22 15:09 ` Jan Beulich
2015-01-18 15:17 ` [RFC PATCH V2 4/8] x86/hvm: rename hvm_memory_event_* functions to hvm_event_* Tamas K Lengyel
` (5 subsequent siblings)
8 siblings, 2 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-18 15:17 UTC (permalink / raw)
To: xen-devel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, tim, ian.jackson, eddie.dong, andres, jbeulich,
Tamas K Lengyel, rshriram, keir, dgdegra, yanghy
The only use-case of the mem_event_op structure had been in mem_paging,
thus renaming the structure mem_paging_op and relocating its associated
functions clarifies its actual usage.
Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
---
tools/libxc/xc_mem_event.c | 16 ----------------
tools/libxc/xc_mem_paging.c | 26 ++++++++++++++++++--------
tools/libxc/xc_private.h | 3 ---
xen/arch/x86/mm/mem_paging.c | 12 ++++++------
xen/arch/x86/x86_64/compat/mm.c | 8 ++++----
xen/arch/x86/x86_64/mm.c | 8 ++++----
xen/common/mem_event.c | 2 +-
xen/include/asm-x86/mem_paging.h | 2 +-
xen/include/public/memory.h | 6 +++---
9 files changed, 37 insertions(+), 46 deletions(-)
diff --git a/tools/libxc/xc_mem_event.c b/tools/libxc/xc_mem_event.c
index 20db2ed..a5e0948 100644
--- a/tools/libxc/xc_mem_event.c
+++ b/tools/libxc/xc_mem_event.c
@@ -40,22 +40,6 @@ int xc_mem_event_control(xc_interface *xch, domid_t domain_id, unsigned int op,
return rc;
}
-int xc_mem_event_memop(xc_interface *xch, domid_t domain_id,
- unsigned int op, unsigned int mode,
- uint64_t gfn, void *buffer)
-{
- xen_mem_event_op_t meo;
-
- memset(&meo, 0, sizeof(meo));
-
- meo.op = op;
- meo.domain = domain_id;
- meo.gfn = gfn;
- meo.buffer = (unsigned long) buffer;
-
- return do_memory_op(xch, mode, &meo, sizeof(meo));
-}
-
void *xc_mem_event_enable(xc_interface *xch, domid_t domain_id, int param,
uint32_t *port, int enable_introspection)
{
diff --git a/tools/libxc/xc_mem_paging.c b/tools/libxc/xc_mem_paging.c
index 8aa7d4d..bf3173d 100644
--- a/tools/libxc/xc_mem_paging.c
+++ b/tools/libxc/xc_mem_paging.c
@@ -23,6 +23,20 @@
#include "xc_private.h"
+static int xc_mem_paging_memop(xc_interface *xch, domid_t domain_id,
+ unsigned int op, uint64_t gfn, void *buffer)
+{
+ xen_mem_paging_op_t mpo;
+
+ memset(&mpo, 0, sizeof(mpo));
+
+ mpo.op = op;
+ mpo.domain = domain_id;
+ mpo.gfn = gfn;
+ mpo.buffer = (unsigned long) buffer;
+
+ return do_memory_op(xch, XENMEM_paging_op, &mpo, sizeof(mpo));
+}
int xc_mem_paging_enable(xc_interface *xch, domid_t domain_id,
uint32_t *port)
@@ -49,25 +63,22 @@ int xc_mem_paging_disable(xc_interface *xch, domid_t domain_id)
int xc_mem_paging_nominate(xc_interface *xch, domid_t domain_id, unsigned long gfn)
{
- return xc_mem_event_memop(xch, domain_id,
+ return xc_mem_paging_memop(xch, domain_id,
XENMEM_paging_op_nominate,
- XENMEM_paging_op,
gfn, NULL);
}
int xc_mem_paging_evict(xc_interface *xch, domid_t domain_id, unsigned long gfn)
{
- return xc_mem_event_memop(xch, domain_id,
+ return xc_mem_paging_memop(xch, domain_id,
XENMEM_paging_op_evict,
- XENMEM_paging_op,
gfn, NULL);
}
int xc_mem_paging_prep(xc_interface *xch, domid_t domain_id, unsigned long gfn)
{
- return xc_mem_event_memop(xch, domain_id,
+ return xc_mem_paging_memop(xch, domain_id,
XENMEM_paging_op_prep,
- XENMEM_paging_op,
gfn, NULL);
}
@@ -87,9 +98,8 @@ int xc_mem_paging_load(xc_interface *xch, domid_t domain_id,
if ( mlock(buffer, XC_PAGE_SIZE) )
return -1;
- rc = xc_mem_event_memop(xch, domain_id,
+ rc = xc_mem_paging_memop(xch, domain_id,
XENMEM_paging_op_prep,
- XENMEM_paging_op,
gfn, buffer);
old_errno = errno;
diff --git a/tools/libxc/xc_private.h b/tools/libxc/xc_private.h
index 45b8644..f1f601c 100644
--- a/tools/libxc/xc_private.h
+++ b/tools/libxc/xc_private.h
@@ -425,9 +425,6 @@ int xc_ffs64(uint64_t x);
*/
int xc_mem_event_control(xc_interface *xch, domid_t domain_id, unsigned int op,
unsigned int mode, uint32_t *port);
-int xc_mem_event_memop(xc_interface *xch, domid_t domain_id,
- unsigned int op, unsigned int mode,
- uint64_t gfn, void *buffer);
/*
* Enables mem_event and returns the mapped ring page indicated by param.
* param can be HVM_PARAM_PAGING/ACCESS/SHARING_RING_PFN
diff --git a/xen/arch/x86/mm/mem_paging.c b/xen/arch/x86/mm/mem_paging.c
index 65f6a3d..f28e65b 100644
--- a/xen/arch/x86/mm/mem_paging.c
+++ b/xen/arch/x86/mm/mem_paging.c
@@ -25,31 +25,31 @@
#include <xen/mem_event.h>
-int mem_paging_memop(struct domain *d, xen_mem_event_op_t *mec)
+int mem_paging_memop(struct domain *d, xen_mem_paging_op_t *mpc)
{
if ( unlikely(!d->mem_event->paging.ring_page) )
return -ENODEV;
- switch( mec->op )
+ switch( mpc->op )
{
case XENMEM_paging_op_nominate:
{
- unsigned long gfn = mec->gfn;
+ unsigned long gfn = mpc->gfn;
return p2m_mem_paging_nominate(d, gfn);
}
break;
case XENMEM_paging_op_evict:
{
- unsigned long gfn = mec->gfn;
+ unsigned long gfn = mpc->gfn;
return p2m_mem_paging_evict(d, gfn);
}
break;
case XENMEM_paging_op_prep:
{
- unsigned long gfn = mec->gfn;
- return p2m_mem_paging_prep(d, gfn, mec->buffer);
+ unsigned long gfn = mpc->gfn;
+ return p2m_mem_paging_prep(d, gfn, mpc->buffer);
}
break;
diff --git a/xen/arch/x86/x86_64/compat/mm.c b/xen/arch/x86/x86_64/compat/mm.c
index f90f611..c8ea85a 100644
--- a/xen/arch/x86/x86_64/compat/mm.c
+++ b/xen/arch/x86/x86_64/compat/mm.c
@@ -188,11 +188,11 @@ int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
case XENMEM_paging_op:
{
- xen_mem_event_op_t meo;
- if ( copy_from_guest(&meo, arg, 1) )
+ xen_mem_paging_op_t mpo;
+ if ( copy_from_guest(&mpo, arg, 1) )
return -EFAULT;
- rc = do_mem_event_op(cmd, meo.domain, &meo);
- if ( !rc && __copy_to_guest(arg, &meo, 1) )
+ rc = do_mem_event_op(cmd, mpo.domain, &mpo);
+ if ( !rc && __copy_to_guest(arg, &mpo, 1) )
return -EFAULT;
break;
}
diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c
index d631aee..2fa1f67 100644
--- a/xen/arch/x86/x86_64/mm.c
+++ b/xen/arch/x86/x86_64/mm.c
@@ -985,11 +985,11 @@ long subarch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
case XENMEM_paging_op:
{
- xen_mem_event_op_t meo;
- if ( copy_from_guest(&meo, arg, 1) )
+ xen_mem_paging_op_t mpo;
+ if ( copy_from_guest(&mpo, arg, 1) )
return -EFAULT;
- rc = do_mem_event_op(cmd, meo.domain, &meo);
- if ( !rc && __copy_to_guest(arg, &meo, 1) )
+ rc = do_mem_event_op(cmd, mpo.domain, &mpo);
+ if ( !rc && __copy_to_guest(arg, &mpo, 1) )
return -EFAULT;
break;
}
diff --git a/xen/common/mem_event.c b/xen/common/mem_event.c
index 37b5558..b99e7d5 100644
--- a/xen/common/mem_event.c
+++ b/xen/common/mem_event.c
@@ -474,7 +474,7 @@ int do_mem_event_op(int op, uint32_t domain, void *arg)
{
#ifdef HAS_MEM_PAGING
case XENMEM_paging_op:
- ret = mem_paging_memop(d, (xen_mem_event_op_t *) arg);
+ ret = mem_paging_memop(d, (xen_mem_paging_op_t *) arg);
break;
#endif
#ifdef HAS_MEM_SHARING
diff --git a/xen/include/asm-x86/mem_paging.h b/xen/include/asm-x86/mem_paging.h
index 6b7a1fe..92ed2fa 100644
--- a/xen/include/asm-x86/mem_paging.h
+++ b/xen/include/asm-x86/mem_paging.h
@@ -21,7 +21,7 @@
*/
-int mem_paging_memop(struct domain *d, xen_mem_event_op_t *meo);
+int mem_paging_memop(struct domain *d, xen_mem_paging_op_t *meo);
/*
diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
index 595f953..fdf864e 100644
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -372,7 +372,7 @@ typedef struct xen_pod_target xen_pod_target_t;
#define XENMEM_paging_op_evict 1
#define XENMEM_paging_op_prep 2
-struct xen_mem_event_op {
+struct xen_mem_paging_op {
uint8_t op; /* XENMEM_*_op_* */
domid_t domain;
@@ -382,8 +382,8 @@ struct xen_mem_event_op {
/* Other OPs */
uint64_aligned_t gfn; /* IN: gfn of page being operated on */
};
-typedef struct xen_mem_event_op xen_mem_event_op_t;
-DEFINE_XEN_GUEST_HANDLE(xen_mem_event_op_t);
+typedef struct xen_mem_paging_op xen_mem_paging_op_t;
+DEFINE_XEN_GUEST_HANDLE(xen_mem_paging_op_t);
#define XENMEM_access_op 21
#define XENMEM_access_op_resume 0
--
2.1.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [RFC PATCH V2 4/8] x86/hvm: rename hvm_memory_event_* functions to hvm_event_*
2015-01-18 15:17 [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Tamas K Lengyel
` (2 preceding siblings ...)
2015-01-18 15:17 ` [RFC PATCH V2 3/8] xen/mem_paging: Convert mem_event_op to mem_paging_op Tamas K Lengyel
@ 2015-01-18 15:17 ` Tamas K Lengyel
2015-01-22 13:05 ` Tim Deegan
2015-01-22 15:56 ` Andrew Cooper
2015-01-18 15:17 ` [RFC PATCH V2 5/8] xen/mem_event: Rename mem_event to vm_event Tamas K Lengyel
` (4 subsequent siblings)
8 siblings, 2 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-18 15:17 UTC (permalink / raw)
To: xen-devel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, tim, ian.jackson, eddie.dong, andres, jbeulich,
Tamas K Lengyel, rshriram, keir, dgdegra, yanghy
The function names currently imply that these events are to be delivered via
the memory_event subsystem. However, the naming is confusing as these events
have nothing to do with actual memory events. Simply naming these functions
hvm_event_* more accurately describe their usage.
Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
---
docs/misc/pvh-readme.txt | 2 +-
xen/arch/x86/hvm/hvm.c | 50 +++++++++++++++++++++----------------------
xen/arch/x86/hvm/vmx/vmx.c | 6 +++---
xen/include/asm-x86/hvm/hvm.h | 12 +++++------
4 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/docs/misc/pvh-readme.txt b/docs/misc/pvh-readme.txt
index c5b3de4..bbd9dbe 100644
--- a/docs/misc/pvh-readme.txt
+++ b/docs/misc/pvh-readme.txt
@@ -49,7 +49,7 @@ Following remain to be done for PVH:
- AMD port.
- 32bit PVH guest support in both linux and xen. Xen changes are tagged
"32bitfixme".
- - Add support for monitoring guest behavior. See hvm_memory_event* functions
+ - Add support for monitoring guest behavior. See hvm_event* functions
in hvm.c
- vcpu hotplug support
- Live migration of PVH guests.
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index f936d51..1968865 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -3229,7 +3229,7 @@ int hvm_set_cr0(unsigned long value)
hvm_funcs.handle_cd(v, value);
hvm_update_cr(v, 0, value);
- hvm_memory_event_cr0(value, old_value);
+ hvm_event_cr0(value, old_value);
if ( (value ^ old_value) & X86_CR0_PG ) {
if ( !nestedhvm_vmswitch_in_progress(v) && nestedhvm_vcpu_in_guestmode(v) )
@@ -3270,7 +3270,7 @@ int hvm_set_cr3(unsigned long value)
old=v->arch.hvm_vcpu.guest_cr[3];
v->arch.hvm_vcpu.guest_cr[3] = value;
paging_update_cr3(v);
- hvm_memory_event_cr3(value, old);
+ hvm_event_cr3(value, old);
return X86EMUL_OKAY;
bad_cr3:
@@ -3311,7 +3311,7 @@ int hvm_set_cr4(unsigned long value)
}
hvm_update_cr(v, 4, value);
- hvm_memory_event_cr4(value, old_cr);
+ hvm_event_cr4(value, old_cr);
/*
* Modifying CR4.{PSE,PAE,PGE,SMEP}, or clearing CR4.PCIDE
@@ -4457,7 +4457,7 @@ int hvm_msr_write_intercept(unsigned int msr, uint64_t msr_content)
hvm_cpuid(1, NULL, NULL, NULL, &edx);
mtrr = !!(edx & cpufeat_mask(X86_FEATURE_MTRR));
- hvm_memory_event_msr(msr, msr_content);
+ hvm_event_msr(msr, msr_content);
switch ( msr )
{
@@ -6171,7 +6171,7 @@ int hvm_debug_op(struct vcpu *v, int32_t op)
return rc;
}
-static void hvm_mem_event_fill_regs(mem_event_request_t *req)
+static void hvm_event_fill_regs(mem_event_request_t *req)
{
const struct cpu_user_regs *regs = guest_cpu_user_regs();
const struct vcpu *curr = current;
@@ -6203,7 +6203,7 @@ static void hvm_mem_event_fill_regs(mem_event_request_t *req)
req->regs.x86.cr4 = curr->arch.hvm_vcpu.guest_cr[4];
}
-static int hvm_memory_event_traps(long parameters, mem_event_request_t *req)
+static int hvm_event_traps(long parameters, mem_event_request_t *req)
{
int rc;
struct vcpu *v = current;
@@ -6228,13 +6228,13 @@ static int hvm_memory_event_traps(long parameters, mem_event_request_t *req)
mem_event_vcpu_pause(v);
}
- hvm_mem_event_fill_regs(req);
+ hvm_event_fill_regs(req);
mem_event_put_request(d, &d->mem_event->monitor, req);
return 1;
}
-void hvm_memory_event_cr0(unsigned long value, unsigned long old)
+void hvm_event_cr0(unsigned long value, unsigned long old)
{
mem_event_request_t req = {
.reason = MEM_EVENT_REASON_CR0,
@@ -6249,10 +6249,10 @@ void hvm_memory_event_cr0(unsigned long value, unsigned long old)
if ( (parameters & HVMPME_onchangeonly) && (value == old) )
return;
- hvm_memory_event_traps(parameters, &req);
+ hvm_event_traps(parameters, &req);
}
-void hvm_memory_event_cr3(unsigned long value, unsigned long old)
+void hvm_event_cr3(unsigned long value, unsigned long old)
{
mem_event_request_t req = {
.reason = MEM_EVENT_REASON_CR3,
@@ -6267,10 +6267,10 @@ void hvm_memory_event_cr3(unsigned long value, unsigned long old)
if ( (parameters & HVMPME_onchangeonly) && (value == old) )
return;
- hvm_memory_event_traps(parameters, &req);
+ hvm_event_traps(parameters, &req);
}
-void hvm_memory_event_cr4(unsigned long value, unsigned long old)
+void hvm_event_cr4(unsigned long value, unsigned long old)
{
mem_event_request_t req = {
.reason = MEM_EVENT_REASON_CR4,
@@ -6285,10 +6285,10 @@ void hvm_memory_event_cr4(unsigned long value, unsigned long old)
if ( (parameters & HVMPME_onchangeonly) && (value == old) )
return;
- hvm_memory_event_traps(parameters, &req);
+ hvm_event_traps(parameters, &req);
}
-void hvm_memory_event_msr(unsigned long msr, unsigned long value)
+void hvm_event_msr(unsigned long msr, unsigned long value)
{
mem_event_request_t req = {
.reason = MEM_EVENT_REASON_MSR,
@@ -6297,12 +6297,12 @@ void hvm_memory_event_msr(unsigned long msr, unsigned long value)
.msr_event.new_value = value,
};
- hvm_memory_event_traps(current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_MSR],
- &req);
+ hvm_event_traps(current->domain->arch.hvm_domain
+ .params[HVM_PARAM_MEMORY_EVENT_MSR],
+ &req);
}
-int hvm_memory_event_int3(unsigned long gla)
+int hvm_event_int3(unsigned long gla)
{
uint32_t pfec = PFEC_page_present;
mem_event_request_t req = {
@@ -6312,12 +6312,12 @@ int hvm_memory_event_int3(unsigned long gla)
.int3_event.gfn = paging_gva_to_gfn(current, gla, &pfec)
};
- return hvm_memory_event_traps(current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_INT3],
- &req);
+ return hvm_event_traps(current->domain->arch.hvm_domain
+ .params[HVM_PARAM_MEMORY_EVENT_INT3],
+ &req);
}
-int hvm_memory_event_single_step(unsigned long gla)
+int hvm_event_single_step(unsigned long gla)
{
uint32_t pfec = PFEC_page_present;
mem_event_request_t req = {
@@ -6327,9 +6327,9 @@ int hvm_memory_event_single_step(unsigned long gla)
.singlestep_event.gfn = paging_gva_to_gfn(current, gla, &pfec)
};
- return hvm_memory_event_traps(current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_SINGLE_STEP],
- &req);
+ return hvm_event_traps(current->domain->arch.hvm_domain
+ .params[HVM_PARAM_MEMORY_EVENT_SINGLE_STEP],
+ &req);
}
int nhvm_vcpu_hostrestore(struct vcpu *v, struct cpu_user_regs *regs)
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index f2554d6..d2c39f4 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -1967,7 +1967,7 @@ static int vmx_cr_access(unsigned long exit_qualification)
unsigned long old = curr->arch.hvm_vcpu.guest_cr[0];
curr->arch.hvm_vcpu.guest_cr[0] &= ~X86_CR0_TS;
vmx_update_guest_cr(curr, 0);
- hvm_memory_event_cr0(curr->arch.hvm_vcpu.guest_cr[0], old);
+ hvm_event_cr0(curr->arch.hvm_vcpu.guest_cr[0], old);
HVMTRACE_0D(CLTS);
break;
}
@@ -2816,7 +2816,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
break;
}
else {
- int handled = hvm_memory_event_int3(regs->eip);
+ int handled = hvm_event_int3(regs->eip);
if ( handled < 0 )
{
@@ -3133,7 +3133,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
v->arch.hvm_vmx.exec_control &= ~CPU_BASED_MONITOR_TRAP_FLAG;
vmx_update_cpu_exec_control(v);
if ( v->arch.hvm_vcpu.single_step ) {
- hvm_memory_event_single_step(regs->eip);
+ hvm_event_single_step(regs->eip);
if ( v->domain->debugger_attached )
domain_pause_for_debugger();
}
diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h
index e3d2d9a..5ac390b 100644
--- a/xen/include/asm-x86/hvm/hvm.h
+++ b/xen/include/asm-x86/hvm/hvm.h
@@ -474,15 +474,15 @@ int hvm_x2apic_msr_read(struct vcpu *v, unsigned int msr, uint64_t *msr_content)
int hvm_x2apic_msr_write(struct vcpu *v, unsigned int msr, uint64_t msr_content);
/* Called for current VCPU on crX changes by guest */
-void hvm_memory_event_cr0(unsigned long value, unsigned long old);
-void hvm_memory_event_cr3(unsigned long value, unsigned long old);
-void hvm_memory_event_cr4(unsigned long value, unsigned long old);
-void hvm_memory_event_msr(unsigned long msr, unsigned long value);
+void hvm_event_cr0(unsigned long value, unsigned long old);
+void hvm_event_cr3(unsigned long value, unsigned long old);
+void hvm_event_cr4(unsigned long value, unsigned long old);
+void hvm_event_msr(unsigned long msr, unsigned long value);
/* Called for current VCPU on int3: returns -1 if no listener */
-int hvm_memory_event_int3(unsigned long gla);
+int hvm_event_int3(unsigned long gla);
/* Called for current VCPU on single step: returns -1 if no listener */
-int hvm_memory_event_single_step(unsigned long gla);
+int hvm_event_single_step(unsigned long gla);
/*
* Nested HVM
--
2.1.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [RFC PATCH V2 5/8] xen/mem_event: Rename mem_event to vm_event
2015-01-18 15:17 [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Tamas K Lengyel
` (3 preceding siblings ...)
2015-01-18 15:17 ` [RFC PATCH V2 4/8] x86/hvm: rename hvm_memory_event_* functions to hvm_event_* Tamas K Lengyel
@ 2015-01-18 15:17 ` Tamas K Lengyel
2015-01-22 14:52 ` Tim Deegan
2015-01-18 15:17 ` [RFC PATCH V2 6/8] xen/vm_event: Decouple vm_event and mem_access Tamas K Lengyel
` (3 subsequent siblings)
8 siblings, 1 reply; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-18 15:17 UTC (permalink / raw)
To: xen-devel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, tim, ian.jackson, eddie.dong, andres, jbeulich,
Tamas K Lengyel, rshriram, keir, dgdegra, yanghy
The mem_event system has originally been used to deliver memory event
related information to helper programs located in a domain. However,
the usage of this sub-system have since been expanded to include non-memory
related events as well, such as register changes, debugging and singlestepping.
Therefore, renaming the system "vm_event" more accurately describes the actual
usage of the subsystem.
In this patch I also clear up the ambiguities that resulted from the interchanged
mem_event and mem_access terminology.
Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
---
tools/libxc/Makefile | 2 +-
tools/libxc/xc_mem_access.c | 10 +-
tools/libxc/xc_mem_event.c | 162 --------
tools/libxc/xc_mem_paging.c | 12 +-
tools/libxc/xc_memshr.c | 12 +-
tools/libxc/xc_private.h | 6 +-
tools/libxc/xc_vm_event.c | 162 ++++++++
tools/tests/xen-access/xen-access.c | 104 ++---
tools/xenpaging/pagein.c | 2 +-
tools/xenpaging/xenpaging.c | 118 +++---
tools/xenpaging/xenpaging.h | 8 +-
xen/arch/x86/domain.c | 2 +-
xen/arch/x86/domctl.c | 4 +-
xen/arch/x86/hvm/emulate.c | 4 +-
xen/arch/x86/hvm/hvm.c | 44 +--
xen/arch/x86/hvm/vmx/vmcs.c | 4 +-
xen/arch/x86/mm/hap/nested_ept.c | 4 +-
xen/arch/x86/mm/hap/nested_hap.c | 4 +-
xen/arch/x86/mm/mem_paging.c | 4 +-
xen/arch/x86/mm/mem_sharing.c | 28 +-
xen/arch/x86/mm/p2m-pod.c | 4 +-
xen/arch/x86/mm/p2m-pt.c | 4 +-
xen/arch/x86/mm/p2m.c | 94 ++---
xen/arch/x86/x86_64/compat/mm.c | 6 +-
xen/arch/x86/x86_64/mm.c | 7 +-
xen/common/Makefile | 2 +-
xen/common/domain.c | 12 +-
xen/common/domctl.c | 6 +-
xen/common/mem_access.c | 24 +-
xen/common/mem_event.c | 742 ------------------------------------
xen/common/vm_event.c | 742 ++++++++++++++++++++++++++++++++++++
xen/drivers/passthrough/pci.c | 2 +-
xen/include/Makefile | 2 +-
xen/include/asm-arm/p2m.h | 6 +-
xen/include/asm-x86/domain.h | 4 +-
xen/include/asm-x86/hvm/emulate.h | 2 +-
xen/include/asm-x86/p2m.h | 16 +-
xen/include/public/domctl.h | 42 +-
xen/include/public/mem_event.h | 197 ----------
xen/include/public/vm_event.h | 197 ++++++++++
xen/include/xen/mem_access.h | 4 +-
xen/include/xen/mem_event.h | 143 -------
xen/include/xen/p2m-common.h | 4 +-
xen/include/xen/sched.h | 26 +-
xen/include/xen/vm_event.h | 143 +++++++
xen/include/xsm/dummy.h | 4 +-
xen/include/xsm/xsm.h | 12 +-
xen/xsm/dummy.c | 4 +-
xen/xsm/flask/hooks.c | 16 +-
xen/xsm/flask/policy/access_vectors | 2 +-
50 files changed, 1580 insertions(+), 1585 deletions(-)
delete mode 100644 tools/libxc/xc_mem_event.c
create mode 100644 tools/libxc/xc_vm_event.c
delete mode 100644 xen/common/mem_event.c
create mode 100644 xen/common/vm_event.c
delete mode 100644 xen/include/public/mem_event.h
create mode 100644 xen/include/public/vm_event.h
delete mode 100644 xen/include/xen/mem_event.h
create mode 100644 xen/include/xen/vm_event.h
diff --git a/tools/libxc/Makefile b/tools/libxc/Makefile
index bd2ca6c..6ef17ec 100644
--- a/tools/libxc/Makefile
+++ b/tools/libxc/Makefile
@@ -26,7 +26,7 @@ CTRL_SRCS-y += xc_pm.c
CTRL_SRCS-y += xc_cpu_hotplug.c
CTRL_SRCS-y += xc_resume.c
CTRL_SRCS-y += xc_tmem.c
-CTRL_SRCS-y += xc_mem_event.c
+CTRL_SRCS-y += xc_vm_event.c
CTRL_SRCS-y += xc_mem_paging.c
CTRL_SRCS-y += xc_mem_access.c
CTRL_SRCS-y += xc_memshr.c
diff --git a/tools/libxc/xc_mem_access.c b/tools/libxc/xc_mem_access.c
index 1c979ed..80f4e2d 100644
--- a/tools/libxc/xc_mem_access.c
+++ b/tools/libxc/xc_mem_access.c
@@ -26,22 +26,22 @@
void *xc_mem_access_enable(xc_interface *xch, domid_t domain_id, uint32_t *port)
{
- return xc_mem_event_enable(xch, domain_id, HVM_PARAM_MONITOR_RING_PFN,
+ return xc_vm_event_enable(xch, domain_id, HVM_PARAM_MONITOR_RING_PFN,
port, 0);
}
void *xc_mem_access_enable_introspection(xc_interface *xch, domid_t domain_id,
uint32_t *port)
{
- return xc_mem_event_enable(xch, domain_id, HVM_PARAM_MONITOR_RING_PFN,
+ return xc_vm_event_enable(xch, domain_id, HVM_PARAM_MONITOR_RING_PFN,
port, 1);
}
int xc_mem_access_disable(xc_interface *xch, domid_t domain_id)
{
- return xc_mem_event_control(xch, domain_id,
- XEN_DOMCTL_MEM_EVENT_OP_MONITOR_DISABLE,
- XEN_DOMCTL_MEM_EVENT_OP_MONITOR,
+ return xc_vm_event_control(xch, domain_id,
+ XEN_DOMCTL_VM_EVENT_OP_MONITOR_DISABLE,
+ XEN_DOMCTL_VM_EVENT_OP_MONITOR,
NULL);
}
diff --git a/tools/libxc/xc_mem_event.c b/tools/libxc/xc_mem_event.c
deleted file mode 100644
index a5e0948..0000000
--- a/tools/libxc/xc_mem_event.c
+++ /dev/null
@@ -1,162 +0,0 @@
-/******************************************************************************
- *
- * xc_mem_event.c
- *
- * Interface to low-level memory event functionality.
- *
- * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp)
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2.1 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- */
-
-#include "xc_private.h"
-
-int xc_mem_event_control(xc_interface *xch, domid_t domain_id, unsigned int op,
- unsigned int mode, uint32_t *port)
-{
- DECLARE_DOMCTL;
- int rc;
-
- domctl.cmd = XEN_DOMCTL_mem_event_op;
- domctl.domain = domain_id;
- domctl.u.mem_event_op.op = op;
- domctl.u.mem_event_op.mode = mode;
-
- rc = do_domctl(xch, &domctl);
- if ( !rc && port )
- *port = domctl.u.mem_event_op.port;
- return rc;
-}
-
-void *xc_mem_event_enable(xc_interface *xch, domid_t domain_id, int param,
- uint32_t *port, int enable_introspection)
-{
- void *ring_page = NULL;
- uint64_t pfn;
- xen_pfn_t ring_pfn, mmap_pfn;
- unsigned int op, mode;
- int rc1, rc2, saved_errno;
-
- if ( !port )
- {
- errno = EINVAL;
- return NULL;
- }
-
- /* Pause the domain for ring page setup */
- rc1 = xc_domain_pause(xch, domain_id);
- if ( rc1 != 0 )
- {
- PERROR("Unable to pause domain\n");
- return NULL;
- }
-
- /* Get the pfn of the ring page */
- rc1 = xc_hvm_param_get(xch, domain_id, param, &pfn);
- if ( rc1 != 0 )
- {
- PERROR("Failed to get pfn of ring page\n");
- goto out;
- }
-
- ring_pfn = pfn;
- mmap_pfn = pfn;
- ring_page = xc_map_foreign_batch(xch, domain_id, PROT_READ | PROT_WRITE,
- &mmap_pfn, 1);
- if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
- {
- /* Map failed, populate ring page */
- rc1 = xc_domain_populate_physmap_exact(xch, domain_id, 1, 0, 0,
- &ring_pfn);
- if ( rc1 != 0 )
- {
- PERROR("Failed to populate ring pfn\n");
- goto out;
- }
-
- mmap_pfn = ring_pfn;
- ring_page = xc_map_foreign_batch(xch, domain_id, PROT_READ | PROT_WRITE,
- &mmap_pfn, 1);
- if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
- {
- PERROR("Could not map the ring page\n");
- goto out;
- }
- }
-
- switch ( param )
- {
- case HVM_PARAM_PAGING_RING_PFN:
- op = XEN_DOMCTL_MEM_EVENT_OP_PAGING_ENABLE;
- mode = XEN_DOMCTL_MEM_EVENT_OP_PAGING;
- break;
-
- case HVM_PARAM_MONITOR_RING_PFN:
- if ( enable_introspection )
- op = XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION;
- else
- op = XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE;
- mode = XEN_DOMCTL_MEM_EVENT_OP_MONITOR;
- break;
-
- case HVM_PARAM_SHARING_RING_PFN:
- op = XEN_DOMCTL_MEM_EVENT_OP_SHARING_ENABLE;
- mode = XEN_DOMCTL_MEM_EVENT_OP_SHARING;
- break;
-
- /*
- * This is for the outside chance that the HVM_PARAM is valid but is invalid
- * as far as mem_event goes.
- */
- default:
- errno = EINVAL;
- rc1 = -1;
- goto out;
- }
-
- rc1 = xc_mem_event_control(xch, domain_id, op, mode, port);
- if ( rc1 != 0 )
- {
- PERROR("Failed to enable mem_event\n");
- goto out;
- }
-
- /* Remove the ring_pfn from the guest's physmap */
- rc1 = xc_domain_decrease_reservation_exact(xch, domain_id, 1, 0, &ring_pfn);
- if ( rc1 != 0 )
- PERROR("Failed to remove ring page from guest physmap");
-
- out:
- saved_errno = errno;
-
- rc2 = xc_domain_unpause(xch, domain_id);
- if ( rc1 != 0 || rc2 != 0 )
- {
- if ( rc2 != 0 )
- {
- if ( rc1 == 0 )
- saved_errno = errno;
- PERROR("Unable to unpause domain");
- }
-
- if ( ring_page )
- munmap(ring_page, XC_PAGE_SIZE);
- ring_page = NULL;
-
- errno = saved_errno;
- }
-
- return ring_page;
-}
diff --git a/tools/libxc/xc_mem_paging.c b/tools/libxc/xc_mem_paging.c
index bf3173d..8408b07 100644
--- a/tools/libxc/xc_mem_paging.c
+++ b/tools/libxc/xc_mem_paging.c
@@ -47,17 +47,17 @@ int xc_mem_paging_enable(xc_interface *xch, domid_t domain_id,
return -1;
}
- return xc_mem_event_control(xch, domain_id,
- XEN_DOMCTL_MEM_EVENT_OP_PAGING_ENABLE,
- XEN_DOMCTL_MEM_EVENT_OP_PAGING,
+ return xc_vm_event_control(xch, domain_id,
+ XEN_DOMCTL_VM_EVENT_OP_PAGING_ENABLE,
+ XEN_DOMCTL_VM_EVENT_OP_PAGING,
port);
}
int xc_mem_paging_disable(xc_interface *xch, domid_t domain_id)
{
- return xc_mem_event_control(xch, domain_id,
- XEN_DOMCTL_MEM_EVENT_OP_PAGING_DISABLE,
- XEN_DOMCTL_MEM_EVENT_OP_PAGING,
+ return xc_vm_event_control(xch, domain_id,
+ XEN_DOMCTL_VM_EVENT_OP_PAGING_DISABLE,
+ XEN_DOMCTL_VM_EVENT_OP_PAGING,
NULL);
}
diff --git a/tools/libxc/xc_memshr.c b/tools/libxc/xc_memshr.c
index d6a9539..fafa073 100644
--- a/tools/libxc/xc_memshr.c
+++ b/tools/libxc/xc_memshr.c
@@ -52,18 +52,18 @@ int xc_memshr_ring_enable(xc_interface *xch,
return -1;
}
- return xc_mem_event_control(xch, domid,
- XEN_DOMCTL_MEM_EVENT_OP_SHARING_ENABLE,
- XEN_DOMCTL_MEM_EVENT_OP_SHARING,
+ return xc_vm_event_control(xch, domid,
+ XEN_DOMCTL_VM_EVENT_OP_SHARING_ENABLE,
+ XEN_DOMCTL_VM_EVENT_OP_SHARING,
port);
}
int xc_memshr_ring_disable(xc_interface *xch,
domid_t domid)
{
- return xc_mem_event_control(xch, domid,
- XEN_DOMCTL_MEM_EVENT_OP_SHARING_DISABLE,
- XEN_DOMCTL_MEM_EVENT_OP_SHARING,
+ return xc_vm_event_control(xch, domid,
+ XEN_DOMCTL_VM_EVENT_OP_SHARING_DISABLE,
+ XEN_DOMCTL_VM_EVENT_OP_SHARING,
NULL);
}
diff --git a/tools/libxc/xc_private.h b/tools/libxc/xc_private.h
index f1f601c..a539300 100644
--- a/tools/libxc/xc_private.h
+++ b/tools/libxc/xc_private.h
@@ -421,15 +421,15 @@ int xc_ffs64(uint64_t x);
#define DOMPRINTF_CALLED(xch) xc_dom_printf((xch), "%s: called", __FUNCTION__)
/**
- * mem_event operations. Internal use only.
+ * vm_event operations. Internal use only.
*/
-int xc_mem_event_control(xc_interface *xch, domid_t domain_id, unsigned int op,
+int xc_vm_event_control(xc_interface *xch, domid_t domain_id, unsigned int op,
unsigned int mode, uint32_t *port);
/*
* Enables mem_event and returns the mapped ring page indicated by param.
* param can be HVM_PARAM_PAGING/ACCESS/SHARING_RING_PFN
*/
-void *xc_mem_event_enable(xc_interface *xch, domid_t domain_id, int param,
+void *xc_vm_event_enable(xc_interface *xch, domid_t domain_id, int param,
uint32_t *port, int enable_introspection);
#endif /* __XC_PRIVATE_H__ */
diff --git a/tools/libxc/xc_vm_event.c b/tools/libxc/xc_vm_event.c
new file mode 100644
index 0000000..39d794d
--- /dev/null
+++ b/tools/libxc/xc_vm_event.c
@@ -0,0 +1,162 @@
+/******************************************************************************
+ *
+ * xc_vm_event.c
+ *
+ * Interface to low-level VM event functionality.
+ *
+ * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp)
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include "xc_private.h"
+
+int xc_vm_event_control(xc_interface *xch, domid_t domain_id, unsigned int op,
+ unsigned int mode, uint32_t *port)
+{
+ DECLARE_DOMCTL;
+ int rc;
+
+ domctl.cmd = XEN_DOMCTL_vm_event_op;
+ domctl.domain = domain_id;
+ domctl.u.vm_event_op.op = op;
+ domctl.u.vm_event_op.mode = mode;
+
+ rc = do_domctl(xch, &domctl);
+ if ( !rc && port )
+ *port = domctl.u.vm_event_op.port;
+ return rc;
+}
+
+void *xc_vm_event_enable(xc_interface *xch, domid_t domain_id, int param,
+ uint32_t *port, int enable_introspection)
+{
+ void *ring_page = NULL;
+ uint64_t pfn;
+ xen_pfn_t ring_pfn, mmap_pfn;
+ unsigned int op, mode;
+ int rc1, rc2, saved_errno;
+
+ if ( !port )
+ {
+ errno = EINVAL;
+ return NULL;
+ }
+
+ /* Pause the domain for ring page setup */
+ rc1 = xc_domain_pause(xch, domain_id);
+ if ( rc1 != 0 )
+ {
+ PERROR("Unable to pause domain\n");
+ return NULL;
+ }
+
+ /* Get the pfn of the ring page */
+ rc1 = xc_hvm_param_get(xch, domain_id, param, &pfn);
+ if ( rc1 != 0 )
+ {
+ PERROR("Failed to get pfn of ring page\n");
+ goto out;
+ }
+
+ ring_pfn = pfn;
+ mmap_pfn = pfn;
+ ring_page = xc_map_foreign_batch(xch, domain_id, PROT_READ | PROT_WRITE,
+ &mmap_pfn, 1);
+ if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
+ {
+ /* Map failed, populate ring page */
+ rc1 = xc_domain_populate_physmap_exact(xch, domain_id, 1, 0, 0,
+ &ring_pfn);
+ if ( rc1 != 0 )
+ {
+ PERROR("Failed to populate ring pfn\n");
+ goto out;
+ }
+
+ mmap_pfn = ring_pfn;
+ ring_page = xc_map_foreign_batch(xch, domain_id, PROT_READ | PROT_WRITE,
+ &mmap_pfn, 1);
+ if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
+ {
+ PERROR("Could not map the ring page\n");
+ goto out;
+ }
+ }
+
+ switch ( param )
+ {
+ case HVM_PARAM_PAGING_RING_PFN:
+ op = XEN_DOMCTL_VM_EVENT_OP_PAGING_ENABLE;
+ mode = XEN_DOMCTL_VM_EVENT_OP_PAGING;
+ break;
+
+ case HVM_PARAM_MONITOR_RING_PFN:
+ if ( enable_introspection )
+ op = XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION;
+ else
+ op = XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE;
+ mode = XEN_DOMCTL_VM_EVENT_OP_MONITOR;
+ break;
+
+ case HVM_PARAM_SHARING_RING_PFN:
+ op = XEN_DOMCTL_VM_EVENT_OP_SHARING_ENABLE;
+ mode = XEN_DOMCTL_VM_EVENT_OP_SHARING;
+ break;
+
+ /*
+ * This is for the outside chance that the HVM_PARAM is valid but is invalid
+ * as far as vm_event goes.
+ */
+ default:
+ errno = EINVAL;
+ rc1 = -1;
+ goto out;
+ }
+
+ rc1 = xc_vm_event_control(xch, domain_id, op, mode, port);
+ if ( rc1 != 0 )
+ {
+ PERROR("Failed to enable vm_event\n");
+ goto out;
+ }
+
+ /* Remove the ring_pfn from the guest's physmap */
+ rc1 = xc_domain_decrease_reservation_exact(xch, domain_id, 1, 0, &ring_pfn);
+ if ( rc1 != 0 )
+ PERROR("Failed to remove ring page from guest physmap");
+
+ out:
+ saved_errno = errno;
+
+ rc2 = xc_domain_unpause(xch, domain_id);
+ if ( rc1 != 0 || rc2 != 0 )
+ {
+ if ( rc2 != 0 )
+ {
+ if ( rc1 == 0 )
+ saved_errno = errno;
+ PERROR("Unable to unpause domain");
+ }
+
+ if ( ring_page )
+ munmap(ring_page, XC_PAGE_SIZE);
+ ring_page = NULL;
+
+ errno = saved_errno;
+ }
+
+ return ring_page;
+}
diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c
index 9d53fb3..3538323 100644
--- a/tools/tests/xen-access/xen-access.c
+++ b/tools/tests/xen-access/xen-access.c
@@ -39,7 +39,7 @@
#include <sys/poll.h>
#include <xenctrl.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#define DPRINTF(a, b...) fprintf(stderr, a, ## b)
#define ERROR(a, b...) fprintf(stderr, a "\n", ## b)
@@ -91,26 +91,26 @@ static inline int spin_trylock(spinlock_t *lock)
return !test_and_set_bit(1, lock);
}
-#define mem_event_ring_lock_init(_m) spin_lock_init(&(_m)->ring_lock)
-#define mem_event_ring_lock(_m) spin_lock(&(_m)->ring_lock)
-#define mem_event_ring_unlock(_m) spin_unlock(&(_m)->ring_lock)
+#define vm_event_ring_lock_init(_m) spin_lock_init(&(_m)->ring_lock)
+#define vm_event_ring_lock(_m) spin_lock(&(_m)->ring_lock)
+#define vm_event_ring_unlock(_m) spin_unlock(&(_m)->ring_lock)
-typedef struct mem_event {
+typedef struct vm_event {
domid_t domain_id;
xc_evtchn *xce_handle;
int port;
- mem_event_back_ring_t back_ring;
+ vm_event_back_ring_t back_ring;
uint32_t evtchn_port;
void *ring_page;
spinlock_t ring_lock;
-} mem_event_t;
+} vm_event_t;
typedef struct xenaccess {
xc_interface *xc_handle;
xc_domaininfo_t *domain_info;
- mem_event_t mem_event;
+ vm_event_t vm_event;
} xenaccess_t;
static int interrupted;
@@ -170,13 +170,13 @@ int xenaccess_teardown(xc_interface *xch, xenaccess_t *xenaccess)
return 0;
/* Tear down domain xenaccess in Xen */
- if ( xenaccess->mem_event.ring_page )
- munmap(xenaccess->mem_event.ring_page, XC_PAGE_SIZE);
+ if ( xenaccess->vm_event.ring_page )
+ munmap(xenaccess->vm_event.ring_page, XC_PAGE_SIZE);
if ( mem_access_enable )
{
rc = xc_mem_access_disable(xenaccess->xc_handle,
- xenaccess->mem_event.domain_id);
+ xenaccess->vm_event.domain_id);
if ( rc != 0 )
{
ERROR("Error tearing down domain xenaccess in xen");
@@ -186,8 +186,8 @@ int xenaccess_teardown(xc_interface *xch, xenaccess_t *xenaccess)
/* Unbind VIRQ */
if ( evtchn_bind )
{
- rc = xc_evtchn_unbind(xenaccess->mem_event.xce_handle,
- xenaccess->mem_event.port);
+ rc = xc_evtchn_unbind(xenaccess->vm_event.xce_handle,
+ xenaccess->vm_event.port);
if ( rc != 0 )
{
ERROR("Error unbinding event port");
@@ -197,7 +197,7 @@ int xenaccess_teardown(xc_interface *xch, xenaccess_t *xenaccess)
/* Close event channel */
if ( evtchn_open )
{
- rc = xc_evtchn_close(xenaccess->mem_event.xce_handle);
+ rc = xc_evtchn_close(xenaccess->vm_event.xce_handle);
if ( rc != 0 )
{
ERROR("Error closing event channel");
@@ -239,17 +239,17 @@ xenaccess_t *xenaccess_init(xc_interface **xch_r, domid_t domain_id)
xenaccess->xc_handle = xch;
/* Set domain id */
- xenaccess->mem_event.domain_id = domain_id;
+ xenaccess->vm_event.domain_id = domain_id;
/* Initialise lock */
- mem_event_ring_lock_init(&xenaccess->mem_event);
+ vm_event_ring_lock_init(&xenaccess->vm_event);
/* Enable mem_access */
- xenaccess->mem_event.ring_page =
+ xenaccess->vm_event.ring_page =
xc_mem_access_enable(xenaccess->xc_handle,
- xenaccess->mem_event.domain_id,
- &xenaccess->mem_event.evtchn_port);
- if ( xenaccess->mem_event.ring_page == NULL )
+ xenaccess->vm_event.domain_id,
+ &xenaccess->vm_event.evtchn_port);
+ if ( xenaccess->vm_event.ring_page == NULL )
{
switch ( errno ) {
case EBUSY:
@@ -267,8 +267,8 @@ xenaccess_t *xenaccess_init(xc_interface **xch_r, domid_t domain_id)
mem_access_enable = 1;
/* Open event channel */
- xenaccess->mem_event.xce_handle = xc_evtchn_open(NULL, 0);
- if ( xenaccess->mem_event.xce_handle == NULL )
+ xenaccess->vm_event.xce_handle = xc_evtchn_open(NULL, 0);
+ if ( xenaccess->vm_event.xce_handle == NULL )
{
ERROR("Failed to open event channel");
goto err;
@@ -276,21 +276,21 @@ xenaccess_t *xenaccess_init(xc_interface **xch_r, domid_t domain_id)
evtchn_open = 1;
/* Bind event notification */
- rc = xc_evtchn_bind_interdomain(xenaccess->mem_event.xce_handle,
- xenaccess->mem_event.domain_id,
- xenaccess->mem_event.evtchn_port);
+ rc = xc_evtchn_bind_interdomain(xenaccess->vm_event.xce_handle,
+ xenaccess->vm_event.domain_id,
+ xenaccess->vm_event.evtchn_port);
if ( rc < 0 )
{
ERROR("Failed to bind event channel");
goto err;
}
evtchn_bind = 1;
- xenaccess->mem_event.port = rc;
+ xenaccess->vm_event.port = rc;
/* Initialise ring */
- SHARED_RING_INIT((mem_event_sring_t *)xenaccess->mem_event.ring_page);
- BACK_RING_INIT(&xenaccess->mem_event.back_ring,
- (mem_event_sring_t *)xenaccess->mem_event.ring_page,
+ SHARED_RING_INIT((vm_event_sring_t *)xenaccess->vm_event.ring_page);
+ BACK_RING_INIT(&xenaccess->vm_event.back_ring,
+ (vm_event_sring_t *)xenaccess->vm_event.ring_page,
XC_PAGE_SIZE);
/* Get domaininfo */
@@ -320,14 +320,14 @@ xenaccess_t *xenaccess_init(xc_interface **xch_r, domid_t domain_id)
return NULL;
}
-int get_request(mem_event_t *mem_event, mem_event_request_t *req)
+int get_request(vm_event_t *vm_event, vm_event_request_t *req)
{
- mem_event_back_ring_t *back_ring;
+ vm_event_back_ring_t *back_ring;
RING_IDX req_cons;
- mem_event_ring_lock(mem_event);
+ vm_event_ring_lock(vm_event);
- back_ring = &mem_event->back_ring;
+ back_ring = &vm_event->back_ring;
req_cons = back_ring->req_cons;
/* Copy request */
@@ -338,19 +338,19 @@ int get_request(mem_event_t *mem_event, mem_event_request_t *req)
back_ring->req_cons = req_cons;
back_ring->sring->req_event = req_cons + 1;
- mem_event_ring_unlock(mem_event);
+ vm_event_ring_unlock(vm_event);
return 0;
}
-static int put_response(mem_event_t *mem_event, mem_event_response_t *rsp)
+static int put_response(vm_event_t *vm_event, vm_event_response_t *rsp)
{
- mem_event_back_ring_t *back_ring;
+ vm_event_back_ring_t *back_ring;
RING_IDX rsp_prod;
- mem_event_ring_lock(mem_event);
+ vm_event_ring_lock(vm_event);
- back_ring = &mem_event->back_ring;
+ back_ring = &vm_event->back_ring;
rsp_prod = back_ring->rsp_prod_pvt;
/* Copy response */
@@ -361,24 +361,24 @@ static int put_response(mem_event_t *mem_event, mem_event_response_t *rsp)
back_ring->rsp_prod_pvt = rsp_prod;
RING_PUSH_RESPONSES(back_ring);
- mem_event_ring_unlock(mem_event);
+ vm_event_ring_unlock(vm_event);
return 0;
}
-static int xenaccess_resume_page(xenaccess_t *paging, mem_event_response_t *rsp)
+static int xenaccess_resume_page(xenaccess_t *paging, vm_event_response_t *rsp)
{
int ret;
/* Put the page info on the ring */
- ret = put_response(&paging->mem_event, rsp);
+ ret = put_response(&paging->vm_event, rsp);
if ( ret != 0 )
goto out;
/* Tell Xen page is ready */
- ret = xc_mem_access_resume(paging->xc_handle, paging->mem_event.domain_id);
- ret = xc_evtchn_notify(paging->mem_event.xce_handle,
- paging->mem_event.port);
+ ret = xc_mem_access_resume(paging->xc_handle, paging->vm_event.domain_id);
+ ret = xc_evtchn_notify(paging->vm_event.xce_handle,
+ paging->vm_event.port);
out:
return ret;
@@ -400,8 +400,8 @@ int main(int argc, char *argv[])
struct sigaction act;
domid_t domain_id;
xenaccess_t *xenaccess;
- mem_event_request_t req;
- mem_event_response_t rsp;
+ vm_event_request_t req;
+ vm_event_response_t rsp;
int rc = -1;
int rc1;
xc_interface *xch;
@@ -507,7 +507,7 @@ int main(int argc, char *argv[])
rc = xc_hvm_param_set(xch, domain_id, HVM_PARAM_MEMORY_EVENT_INT3, HVMPME_mode_disabled);
if ( rc < 0 )
{
- ERROR("Error %d setting int3 mem_event\n", rc);
+ ERROR("Error %d setting int3 vm_event\n", rc);
goto exit;
}
@@ -527,7 +527,7 @@ int main(int argc, char *argv[])
shutting_down = 1;
}
- rc = xc_wait_for_event_or_timeout(xch, xenaccess->mem_event.xce_handle, 100);
+ rc = xc_wait_for_event_or_timeout(xch, xenaccess->vm_event.xce_handle, 100);
if ( rc < -1 )
{
ERROR("Error getting event");
@@ -539,11 +539,11 @@ int main(int argc, char *argv[])
DPRINTF("Got event from Xen\n");
}
- while ( RING_HAS_UNCONSUMED_REQUESTS(&xenaccess->mem_event.back_ring) )
+ while ( RING_HAS_UNCONSUMED_REQUESTS(&xenaccess->vm_event.back_ring) )
{
xenmem_access_t access;
- rc = get_request(&xenaccess->mem_event, &req);
+ rc = get_request(&xenaccess->vm_event, &req);
if ( rc != 0 )
{
ERROR("Error getting request");
@@ -556,7 +556,7 @@ int main(int argc, char *argv[])
rsp.flags = req.flags;
switch (req.reason) {
- case MEM_EVENT_REASON_MEM_ACCESS_VIOLATION:
+ case VM_EVENT_REASON_MEM_ACCESS_VIOLATION:
rc = xc_get_mem_access(xch, domain_id, req.mem_access_event.gfn, &access);
if (rc < 0)
{
@@ -594,7 +594,7 @@ int main(int argc, char *argv[])
rsp.mem_access_event.gfn = req.mem_access_event.gfn;
break;
- case MEM_EVENT_REASON_INT3:
+ case VM_EVENT_REASON_INT3:
printf("INT3: rip=%016"PRIx64", gfn=%"PRIx64" (vcpu %d)\n",
req.int3_event.gla,
req.int3_event.gfn,
diff --git a/tools/xenpaging/pagein.c b/tools/xenpaging/pagein.c
index b3bcef7..7cb0f33 100644
--- a/tools/xenpaging/pagein.c
+++ b/tools/xenpaging/pagein.c
@@ -63,7 +63,7 @@ void page_in_trigger(void)
void create_page_in_thread(struct xenpaging *paging)
{
- page_in_args.dom = paging->mem_event.domain_id;
+ page_in_args.dom = paging->vm_event.domain_id;
page_in_args.pagein_queue = paging->pagein_queue;
page_in_args.xch = paging->xc_handle;
if (pthread_create(&page_in_thread, NULL, page_in, &page_in_args) == 0)
diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c
index 148b3e7..3031d1e 100644
--- a/tools/xenpaging/xenpaging.c
+++ b/tools/xenpaging/xenpaging.c
@@ -63,7 +63,7 @@ static void close_handler(int sig)
static void xenpaging_mem_paging_flush_ioemu_cache(struct xenpaging *paging)
{
struct xs_handle *xsh = paging->xs_handle;
- domid_t domain_id = paging->mem_event.domain_id;
+ domid_t domain_id = paging->vm_event.domain_id;
char path[80];
sprintf(path, "/local/domain/0/device-model/%u/command", domain_id);
@@ -74,7 +74,7 @@ static void xenpaging_mem_paging_flush_ioemu_cache(struct xenpaging *paging)
static int xenpaging_wait_for_event_or_timeout(struct xenpaging *paging)
{
xc_interface *xch = paging->xc_handle;
- xc_evtchn *xce = paging->mem_event.xce_handle;
+ xc_evtchn *xce = paging->vm_event.xce_handle;
char **vec, *val;
unsigned int num;
struct pollfd fd[2];
@@ -111,7 +111,7 @@ static int xenpaging_wait_for_event_or_timeout(struct xenpaging *paging)
if ( strcmp(vec[XS_WATCH_TOKEN], watch_token) == 0 )
{
/* If our guest disappeared, set interrupt flag and fall through */
- if ( xs_is_domain_introduced(paging->xs_handle, paging->mem_event.domain_id) == false )
+ if ( xs_is_domain_introduced(paging->xs_handle, paging->vm_event.domain_id) == false )
{
xs_unwatch(paging->xs_handle, "@releaseDomain", watch_token);
interrupted = SIGQUIT;
@@ -171,7 +171,7 @@ static int xenpaging_get_tot_pages(struct xenpaging *paging)
xc_domaininfo_t domain_info;
int rc;
- rc = xc_domain_getinfolist(xch, paging->mem_event.domain_id, 1, &domain_info);
+ rc = xc_domain_getinfolist(xch, paging->vm_event.domain_id, 1, &domain_info);
if ( rc != 1 )
{
PERROR("Error getting domain info");
@@ -231,7 +231,7 @@ static int xenpaging_getopts(struct xenpaging *paging, int argc, char *argv[])
{
switch(ch) {
case 'd':
- paging->mem_event.domain_id = atoi(optarg);
+ paging->vm_event.domain_id = atoi(optarg);
break;
case 'f':
filename = strdup(optarg);
@@ -264,7 +264,7 @@ static int xenpaging_getopts(struct xenpaging *paging, int argc, char *argv[])
}
/* Set domain id */
- if ( !paging->mem_event.domain_id )
+ if ( !paging->vm_event.domain_id )
{
printf("Numerical <domain_id> missing!\n");
return 1;
@@ -312,7 +312,7 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
}
/* write domain ID to watch so we can ignore other domain shutdowns */
- snprintf(watch_token, sizeof(watch_token), "%u", paging->mem_event.domain_id);
+ snprintf(watch_token, sizeof(watch_token), "%u", paging->vm_event.domain_id);
if ( xs_watch(paging->xs_handle, "@releaseDomain", watch_token) == false )
{
PERROR("Could not bind to shutdown watch\n");
@@ -320,7 +320,7 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
}
/* Watch xenpagings working target */
- dom_path = xs_get_domain_path(paging->xs_handle, paging->mem_event.domain_id);
+ dom_path = xs_get_domain_path(paging->xs_handle, paging->vm_event.domain_id);
if ( !dom_path )
{
PERROR("Could not find domain path\n");
@@ -339,17 +339,17 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
}
/* Map the ring page */
- xc_get_hvm_param(xch, paging->mem_event.domain_id,
+ xc_get_hvm_param(xch, paging->vm_event.domain_id,
HVM_PARAM_PAGING_RING_PFN, &ring_pfn);
mmap_pfn = ring_pfn;
- paging->mem_event.ring_page =
- xc_map_foreign_batch(xch, paging->mem_event.domain_id,
+ paging->vm_event.ring_page =
+ xc_map_foreign_batch(xch, paging->vm_event.domain_id,
PROT_READ | PROT_WRITE, &mmap_pfn, 1);
if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
{
/* Map failed, populate ring page */
rc = xc_domain_populate_physmap_exact(paging->xc_handle,
- paging->mem_event.domain_id,
+ paging->vm_event.domain_id,
1, 0, 0, &ring_pfn);
if ( rc != 0 )
{
@@ -358,8 +358,8 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
}
mmap_pfn = ring_pfn;
- paging->mem_event.ring_page =
- xc_map_foreign_batch(xch, paging->mem_event.domain_id,
+ paging->vm_event.ring_page =
+ xc_map_foreign_batch(xch, paging->vm_event.domain_id,
PROT_READ | PROT_WRITE, &mmap_pfn, 1);
if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
{
@@ -369,8 +369,8 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
}
/* Initialise Xen */
- rc = xc_mem_paging_enable(xch, paging->mem_event.domain_id,
- &paging->mem_event.evtchn_port);
+ rc = xc_mem_paging_enable(xch, paging->vm_event.domain_id,
+ &paging->vm_event.evtchn_port);
if ( rc != 0 )
{
switch ( errno ) {
@@ -394,40 +394,40 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
}
/* Open event channel */
- paging->mem_event.xce_handle = xc_evtchn_open(NULL, 0);
- if ( paging->mem_event.xce_handle == NULL )
+ paging->vm_event.xce_handle = xc_evtchn_open(NULL, 0);
+ if ( paging->vm_event.xce_handle == NULL )
{
PERROR("Failed to open event channel");
goto err;
}
/* Bind event notification */
- rc = xc_evtchn_bind_interdomain(paging->mem_event.xce_handle,
- paging->mem_event.domain_id,
- paging->mem_event.evtchn_port);
+ rc = xc_evtchn_bind_interdomain(paging->vm_event.xce_handle,
+ paging->vm_event.domain_id,
+ paging->vm_event.evtchn_port);
if ( rc < 0 )
{
PERROR("Failed to bind event channel");
goto err;
}
- paging->mem_event.port = rc;
+ paging->vm_event.port = rc;
/* Initialise ring */
- SHARED_RING_INIT((mem_event_sring_t *)paging->mem_event.ring_page);
- BACK_RING_INIT(&paging->mem_event.back_ring,
- (mem_event_sring_t *)paging->mem_event.ring_page,
+ SHARED_RING_INIT((vm_event_sring_t *)paging->vm_event.ring_page);
+ BACK_RING_INIT(&paging->vm_event.back_ring,
+ (vm_event_sring_t *)paging->vm_event.ring_page,
PAGE_SIZE);
/* Now that the ring is set, remove it from the guest's physmap */
if ( xc_domain_decrease_reservation_exact(xch,
- paging->mem_event.domain_id, 1, 0, &ring_pfn) )
+ paging->vm_event.domain_id, 1, 0, &ring_pfn) )
PERROR("Failed to remove ring from guest physmap");
/* Get max_pages from guest if not provided via cmdline */
if ( !paging->max_pages )
{
- rc = xc_domain_getinfolist(xch, paging->mem_event.domain_id, 1,
+ rc = xc_domain_getinfolist(xch, paging->vm_event.domain_id, 1,
&domain_info);
if ( rc != 1 )
{
@@ -497,9 +497,9 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
free(paging->paging_buffer);
}
- if ( paging->mem_event.ring_page )
+ if ( paging->vm_event.ring_page )
{
- munmap(paging->mem_event.ring_page, PAGE_SIZE);
+ munmap(paging->vm_event.ring_page, PAGE_SIZE);
}
free(dom_path);
@@ -524,28 +524,28 @@ static void xenpaging_teardown(struct xenpaging *paging)
paging->xc_handle = NULL;
/* Tear down domain paging in Xen */
- munmap(paging->mem_event.ring_page, PAGE_SIZE);
- rc = xc_mem_paging_disable(xch, paging->mem_event.domain_id);
+ munmap(paging->vm_event.ring_page, PAGE_SIZE);
+ rc = xc_mem_paging_disable(xch, paging->vm_event.domain_id);
if ( rc != 0 )
{
PERROR("Error tearing down domain paging in xen");
}
/* Unbind VIRQ */
- rc = xc_evtchn_unbind(paging->mem_event.xce_handle, paging->mem_event.port);
+ rc = xc_evtchn_unbind(paging->vm_event.xce_handle, paging->vm_event.port);
if ( rc != 0 )
{
PERROR("Error unbinding event port");
}
- paging->mem_event.port = -1;
+ paging->vm_event.port = -1;
/* Close event channel */
- rc = xc_evtchn_close(paging->mem_event.xce_handle);
+ rc = xc_evtchn_close(paging->vm_event.xce_handle);
if ( rc != 0 )
{
PERROR("Error closing event channel");
}
- paging->mem_event.xce_handle = NULL;
+ paging->vm_event.xce_handle = NULL;
/* Close connection to xenstore */
xs_close(paging->xs_handle);
@@ -558,12 +558,12 @@ static void xenpaging_teardown(struct xenpaging *paging)
}
}
-static void get_request(struct mem_event *mem_event, mem_event_request_t *req)
+static void get_request(struct vm_event *vm_event, vm_event_request_t *req)
{
- mem_event_back_ring_t *back_ring;
+ vm_event_back_ring_t *back_ring;
RING_IDX req_cons;
- back_ring = &mem_event->back_ring;
+ back_ring = &vm_event->back_ring;
req_cons = back_ring->req_cons;
/* Copy request */
@@ -575,12 +575,12 @@ static void get_request(struct mem_event *mem_event, mem_event_request_t *req)
back_ring->sring->req_event = req_cons + 1;
}
-static void put_response(struct mem_event *mem_event, mem_event_response_t *rsp)
+static void put_response(struct vm_event *vm_event, vm_event_response_t *rsp)
{
- mem_event_back_ring_t *back_ring;
+ vm_event_back_ring_t *back_ring;
RING_IDX rsp_prod;
- back_ring = &mem_event->back_ring;
+ back_ring = &vm_event->back_ring;
rsp_prod = back_ring->rsp_prod_pvt;
/* Copy response */
@@ -607,7 +607,7 @@ static int xenpaging_evict_page(struct xenpaging *paging, unsigned long gfn, int
DECLARE_DOMCTL;
/* Nominate page */
- ret = xc_mem_paging_nominate(xch, paging->mem_event.domain_id, gfn);
+ ret = xc_mem_paging_nominate(xch, paging->vm_event.domain_id, gfn);
if ( ret < 0 )
{
/* unpageable gfn is indicated by EBUSY */
@@ -619,7 +619,7 @@ static int xenpaging_evict_page(struct xenpaging *paging, unsigned long gfn, int
}
/* Map page */
- page = xc_map_foreign_pages(xch, paging->mem_event.domain_id, PROT_READ, &victim, 1);
+ page = xc_map_foreign_pages(xch, paging->vm_event.domain_id, PROT_READ, &victim, 1);
if ( page == NULL )
{
PERROR("Error mapping page %lx", gfn);
@@ -641,7 +641,7 @@ static int xenpaging_evict_page(struct xenpaging *paging, unsigned long gfn, int
munmap(page, PAGE_SIZE);
/* Tell Xen to evict page */
- ret = xc_mem_paging_evict(xch, paging->mem_event.domain_id, gfn);
+ ret = xc_mem_paging_evict(xch, paging->vm_event.domain_id, gfn);
if ( ret < 0 )
{
/* A gfn in use is indicated by EBUSY */
@@ -671,10 +671,10 @@ static int xenpaging_evict_page(struct xenpaging *paging, unsigned long gfn, int
return ret;
}
-static int xenpaging_resume_page(struct xenpaging *paging, mem_event_response_t *rsp, int notify_policy)
+static int xenpaging_resume_page(struct xenpaging *paging, vm_event_response_t *rsp, int notify_policy)
{
/* Put the page info on the ring */
- put_response(&paging->mem_event, rsp);
+ put_response(&paging->vm_event, rsp);
/* Notify policy of page being paged in */
if ( notify_policy )
@@ -693,7 +693,7 @@ static int xenpaging_resume_page(struct xenpaging *paging, mem_event_response_t
}
/* Tell Xen page is ready */
- return xc_evtchn_notify(paging->mem_event.xce_handle, paging->mem_event.port);
+ return xc_evtchn_notify(paging->vm_event.xce_handle, paging->vm_event.port);
}
static int xenpaging_populate_page(struct xenpaging *paging, unsigned long gfn, int i)
@@ -715,7 +715,7 @@ static int xenpaging_populate_page(struct xenpaging *paging, unsigned long gfn,
do
{
/* Tell Xen to allocate a page for the domain */
- ret = xc_mem_paging_load(xch, paging->mem_event.domain_id, gfn, paging->paging_buffer);
+ ret = xc_mem_paging_load(xch, paging->vm_event.domain_id, gfn, paging->paging_buffer);
if ( ret < 0 )
{
if ( errno == ENOMEM )
@@ -857,8 +857,8 @@ int main(int argc, char *argv[])
{
struct sigaction act;
struct xenpaging *paging;
- mem_event_request_t req;
- mem_event_response_t rsp;
+ vm_event_request_t req;
+ vm_event_response_t rsp;
int num, prev_num = 0;
int slot;
int tot_pages;
@@ -874,7 +874,7 @@ int main(int argc, char *argv[])
}
xch = paging->xc_handle;
- DPRINTF("starting %s for domain_id %u with pagefile %s\n", argv[0], paging->mem_event.domain_id, filename);
+ DPRINTF("starting %s for domain_id %u with pagefile %s\n", argv[0], paging->vm_event.domain_id, filename);
/* ensure that if we get a signal, we'll do cleanup, then exit */
act.sa_handler = close_handler;
@@ -903,12 +903,12 @@ int main(int argc, char *argv[])
DPRINTF("Got event from Xen\n");
}
- while ( RING_HAS_UNCONSUMED_REQUESTS(&paging->mem_event.back_ring) )
+ while ( RING_HAS_UNCONSUMED_REQUESTS(&paging->vm_event.back_ring) )
{
/* Indicate possible error */
rc = 1;
- get_request(&paging->mem_event, &req);
+ get_request(&paging->vm_event, &req);
if ( req.mem_paging_event.gfn > paging->max_pages )
{
@@ -929,7 +929,7 @@ int main(int argc, char *argv[])
goto out;
}
- if ( req.flags & MEM_EVENT_FLAG_DROP_PAGE )
+ if ( req.flags & VM_EVENT_FLAG_DROP_PAGE )
{
DPRINTF("drop_page ^ gfn %"PRIx64" pageslot %d\n", req.mem_paging_event.gfn, slot);
/* Notify policy of page being dropped */
@@ -966,13 +966,13 @@ int main(int argc, char *argv[])
{
DPRINTF("page %s populated (domain = %d; vcpu = %d;"
" gfn = %"PRIx64"; paused = %d; evict_fail = %d)\n",
- req.flags & MEM_EVENT_FLAG_EVICT_FAIL ? "not" : "already",
- paging->mem_event.domain_id, req.vcpu_id, req.mem_paging_event.gfn,
- !!(req.flags & MEM_EVENT_FLAG_VCPU_PAUSED) ,
- !!(req.flags & MEM_EVENT_FLAG_EVICT_FAIL) );
+ req.flags & VM_EVENT_FLAG_EVICT_FAIL ? "not" : "already",
+ paging->vm_event.domain_id, req.vcpu_id, req.mem_paging_event.gfn,
+ !!(req.flags & VM_EVENT_FLAG_VCPU_PAUSED) ,
+ !!(req.flags & VM_EVENT_FLAG_EVICT_FAIL) );
/* Tell Xen to resume the vcpu */
- if (( req.flags & MEM_EVENT_FLAG_VCPU_PAUSED ) || ( req.flags & MEM_EVENT_FLAG_EVICT_FAIL ))
+ if (( req.flags & VM_EVENT_FLAG_VCPU_PAUSED ) || ( req.flags & VM_EVENT_FLAG_EVICT_FAIL ))
{
/* Prepare the response */
rsp.mem_paging_event.gfn = req.mem_paging_event.gfn;
diff --git a/tools/xenpaging/xenpaging.h b/tools/xenpaging/xenpaging.h
index 877db2f..25d511d 100644
--- a/tools/xenpaging/xenpaging.h
+++ b/tools/xenpaging/xenpaging.h
@@ -27,15 +27,15 @@
#include <xc_private.h>
#include <xen/event_channel.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#define XENPAGING_PAGEIN_QUEUE_SIZE 64
-struct mem_event {
+struct vm_event {
domid_t domain_id;
xc_evtchn *xce_handle;
int port;
- mem_event_back_ring_t back_ring;
+ vm_event_back_ring_t back_ring;
uint32_t evtchn_port;
void *ring_page;
};
@@ -51,7 +51,7 @@ struct xenpaging {
void *paging_buffer;
- struct mem_event mem_event;
+ struct vm_event vm_event;
int fd;
/* number of pages for which data structures were allocated */
int max_pages;
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index 11c7d9f..16855dc 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -432,7 +432,7 @@ int vcpu_initialise(struct vcpu *v)
v->arch.flags = TF_kernel_mode;
/* By default, do not emulate */
- v->arch.mem_event.emulate_flags = 0;
+ v->arch.vm_event.emulate_flags = 0;
rc = mapcache_vcpu_init(v);
if ( rc )
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index 82365a4..3951ed3 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -30,8 +30,8 @@
#include <xen/hypercall.h> /* for arch_do_domctl */
#include <xsm/xsm.h>
#include <xen/iommu.h>
-#include <xen/mem_event.h>
-#include <public/mem_event.h>
+#include <xen/vm_event.h>
+#include <public/vm_event.h>
#include <asm/mem_sharing.h>
#include <asm/xstate.h>
#include <asm/debugger.h>
diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c
index 14c1847..218f6aa 100644
--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -1401,7 +1401,7 @@ int hvm_emulate_one_no_write(
return _hvm_emulate_one(hvmemul_ctxt, &hvm_emulate_ops_no_write);
}
-void hvm_mem_event_emulate_one(bool_t nowrite, unsigned int trapnr,
+void hvm_mem_access_emulate_one(bool_t nowrite, unsigned int trapnr,
unsigned int errcode)
{
struct hvm_emulate_ctxt ctx = {{ 0 }};
@@ -1418,7 +1418,7 @@ void hvm_mem_event_emulate_one(bool_t nowrite, unsigned int trapnr,
{
case X86EMUL_RETRY:
/*
- * This function is called when handling an EPT-related mem_event
+ * This function is called when handling an EPT-related vm_event
* reply. As such, nothing else needs to be done here, since simply
* returning makes the current instruction cause a page fault again,
* consistent with X86EMUL_RETRY.
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 1968865..48ef545 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -35,7 +35,7 @@
#include <xen/paging.h>
#include <xen/cpu.h>
#include <xen/wait.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <xen/mem_access.h>
#include <xen/rangeset.h>
#include <asm/shadow.h>
@@ -66,7 +66,7 @@
#include <public/hvm/ioreq.h>
#include <public/version.h>
#include <public/memory.h>
-#include <public/mem_event.h>
+#include <public/vm_event.h>
#include <public/arch-x86/cpuid.h>
bool_t __read_mostly hvm_enabled;
@@ -2717,7 +2717,7 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla,
struct p2m_domain *p2m;
int rc, fall_through = 0, paged = 0;
int sharing_enomem = 0;
- mem_event_request_t *req_ptr = NULL;
+ vm_event_request_t *req_ptr = NULL;
/* On Nested Virtualization, walk the guest page table.
* If this succeeds, all is fine.
@@ -2787,7 +2787,7 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla,
{
bool_t violation;
- /* If the access is against the permissions, then send to mem_event */
+ /* If the access is against the permissions, then send to vm_event */
switch (p2ma)
{
case p2m_access_n:
@@ -6171,7 +6171,7 @@ int hvm_debug_op(struct vcpu *v, int32_t op)
return rc;
}
-static void hvm_event_fill_regs(mem_event_request_t *req)
+static void hvm_event_fill_regs(vm_event_request_t *req)
{
const struct cpu_user_regs *regs = guest_cpu_user_regs();
const struct vcpu *curr = current;
@@ -6203,7 +6203,7 @@ static void hvm_event_fill_regs(mem_event_request_t *req)
req->regs.x86.cr4 = curr->arch.hvm_vcpu.guest_cr[4];
}
-static int hvm_event_traps(long parameters, mem_event_request_t *req)
+static int hvm_event_traps(long parameters, vm_event_request_t *req)
{
int rc;
struct vcpu *v = current;
@@ -6212,7 +6212,7 @@ static int hvm_event_traps(long parameters, mem_event_request_t *req)
if ( !(parameters & HVMPME_MODE_MASK) )
return 0;
- rc = mem_event_claim_slot(d, &d->mem_event->monitor);
+ rc = vm_event_claim_slot(d, &d->vm_event->monitor);
if ( rc == -ENOSYS )
{
/* If there was no ring to handle the event, then
@@ -6224,20 +6224,20 @@ static int hvm_event_traps(long parameters, mem_event_request_t *req)
if ( (parameters & HVMPME_MODE_MASK) == HVMPME_mode_sync )
{
- req->flags |= MEM_EVENT_FLAG_VCPU_PAUSED;
- mem_event_vcpu_pause(v);
+ req->flags |= VM_EVENT_FLAG_VCPU_PAUSED;
+ vm_event_vcpu_pause(v);
}
hvm_event_fill_regs(req);
- mem_event_put_request(d, &d->mem_event->monitor, req);
+ vm_event_put_request(d, &d->vm_event->monitor, req);
return 1;
}
void hvm_event_cr0(unsigned long value, unsigned long old)
{
- mem_event_request_t req = {
- .reason = MEM_EVENT_REASON_CR0,
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_CR0,
.vcpu_id = current->vcpu_id,
.cr_event.new_value = value,
.cr_event.old_value = old
@@ -6254,8 +6254,8 @@ void hvm_event_cr0(unsigned long value, unsigned long old)
void hvm_event_cr3(unsigned long value, unsigned long old)
{
- mem_event_request_t req = {
- .reason = MEM_EVENT_REASON_CR3,
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_CR3,
.vcpu_id = current->vcpu_id,
.cr_event.new_value = value,
.cr_event.old_value = old
@@ -6272,8 +6272,8 @@ void hvm_event_cr3(unsigned long value, unsigned long old)
void hvm_event_cr4(unsigned long value, unsigned long old)
{
- mem_event_request_t req = {
- .reason = MEM_EVENT_REASON_CR4,
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_CR4,
.vcpu_id = current->vcpu_id,
.cr_event.new_value = value,
.cr_event.old_value = old
@@ -6290,8 +6290,8 @@ void hvm_event_cr4(unsigned long value, unsigned long old)
void hvm_event_msr(unsigned long msr, unsigned long value)
{
- mem_event_request_t req = {
- .reason = MEM_EVENT_REASON_MSR,
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_MSR,
.vcpu_id = current->vcpu_id,
.msr_event.msr = msr,
.msr_event.new_value = value,
@@ -6305,8 +6305,8 @@ void hvm_event_msr(unsigned long msr, unsigned long value)
int hvm_event_int3(unsigned long gla)
{
uint32_t pfec = PFEC_page_present;
- mem_event_request_t req = {
- .reason = MEM_EVENT_REASON_INT3,
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_INT3,
.vcpu_id = current->vcpu_id,
.int3_event.gla = gla,
.int3_event.gfn = paging_gva_to_gfn(current, gla, &pfec)
@@ -6320,8 +6320,8 @@ int hvm_event_int3(unsigned long gla)
int hvm_event_single_step(unsigned long gla)
{
uint32_t pfec = PFEC_page_present;
- mem_event_request_t req = {
- .reason = MEM_EVENT_REASON_SINGLESTEP,
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_SINGLESTEP,
.vcpu_id = current->vcpu_id,
.singlestep_event.gla = gla,
.singlestep_event.gfn = paging_gva_to_gfn(current, gla, &pfec)
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index e553fb0..0f2b2e6 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -25,7 +25,7 @@
#include <xen/event.h>
#include <xen/kernel.h>
#include <xen/keyhandler.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <asm/current.h>
#include <asm/cpufeature.h>
#include <asm/processor.h>
@@ -715,7 +715,7 @@ void vmx_disable_intercept_for_msr(struct vcpu *v, u32 msr, int type)
return;
if ( unlikely(d->arch.hvm_domain.introspection_enabled) &&
- mem_event_check_ring(&d->mem_event->monitor) )
+ vm_event_check_ring(&d->vm_event->monitor) )
{
unsigned int i;
diff --git a/xen/arch/x86/mm/hap/nested_ept.c b/xen/arch/x86/mm/hap/nested_ept.c
index cbbc4e9..40adac3 100644
--- a/xen/arch/x86/mm/hap/nested_ept.c
+++ b/xen/arch/x86/mm/hap/nested_ept.c
@@ -17,9 +17,9 @@
* this program; if not, write to the Free Software Foundation, Inc., 59 Temple
* Place - Suite 330, Boston, MA 02111-1307 USA.
*/
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <xen/event.h>
-#include <public/mem_event.h>
+#include <public/vm_event.h>
#include <asm/domain.h>
#include <asm/page.h>
#include <asm/paging.h>
diff --git a/xen/arch/x86/mm/hap/nested_hap.c b/xen/arch/x86/mm/hap/nested_hap.c
index 9c1ec11..cb28943 100644
--- a/xen/arch/x86/mm/hap/nested_hap.c
+++ b/xen/arch/x86/mm/hap/nested_hap.c
@@ -19,9 +19,9 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <xen/event.h>
-#include <public/mem_event.h>
+#include <public/vm_event.h>
#include <asm/domain.h>
#include <asm/page.h>
#include <asm/paging.h>
diff --git a/xen/arch/x86/mm/mem_paging.c b/xen/arch/x86/mm/mem_paging.c
index f28e65b..aaa72a9 100644
--- a/xen/arch/x86/mm/mem_paging.c
+++ b/xen/arch/x86/mm/mem_paging.c
@@ -22,12 +22,12 @@
#include <asm/p2m.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
int mem_paging_memop(struct domain *d, xen_mem_paging_op_t *mpc)
{
- if ( unlikely(!d->mem_event->paging.ring_page) )
+ if ( unlikely(!d->vm_event->paging.ring_page) )
return -ENODEV;
switch( mpc->op )
diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
index c15edcc..b17a0a9 100644
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -28,7 +28,7 @@
#include <xen/grant_table.h>
#include <xen/sched.h>
#include <xen/rcupdate.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <asm/page.h>
#include <asm/string.h>
#include <asm/p2m.h>
@@ -559,25 +559,25 @@ int mem_sharing_notify_enomem(struct domain *d, unsigned long gfn,
{
struct vcpu *v = current;
int rc;
- mem_event_request_t req = {
- .reason = MEM_EVENT_REASON_MEM_SHARING,
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_MEM_SHARING,
.mem_sharing_event.gfn = gfn
};
- if ( (rc = __mem_event_claim_slot(d,
- &d->mem_event->share, allow_sleep)) < 0 )
+ if ( (rc = __vm_event_claim_slot(d,
+ &d->vm_event->share, allow_sleep)) < 0 )
return rc;
if ( v->domain == d )
{
- req.flags = MEM_EVENT_FLAG_VCPU_PAUSED;
- mem_event_vcpu_pause(v);
+ req.flags = VM_EVENT_FLAG_VCPU_PAUSED;
+ vm_event_vcpu_pause(v);
}
req.mem_sharing_event.p2mt = p2m_ram_shared;
req.vcpu_id = v->vcpu_id;
- mem_event_put_request(d, &d->mem_event->share, &req);
+ vm_event_put_request(d, &d->vm_event->share, &req);
return 0;
}
@@ -594,14 +594,14 @@ unsigned int mem_sharing_get_nr_shared_mfns(void)
int mem_sharing_sharing_resume(struct domain *d)
{
- mem_event_response_t rsp;
+ vm_event_response_t rsp;
/* Get all requests off the ring */
- while ( mem_event_get_response(d, &d->mem_event->share, &rsp) )
+ while ( vm_event_get_response(d, &d->vm_event->share, &rsp) )
{
struct vcpu *v;
- if ( rsp.flags & MEM_EVENT_FLAG_DUMMY )
+ if ( rsp.flags & VM_EVENT_FLAG_DUMMY )
continue;
/* Validate the vcpu_id in the response. */
@@ -611,8 +611,8 @@ int mem_sharing_sharing_resume(struct domain *d)
v = d->vcpu[rsp.vcpu_id];
/* Unpause domain/vcpu */
- if ( rsp.flags & MEM_EVENT_FLAG_VCPU_PAUSED )
- mem_event_vcpu_unpause(v);
+ if ( rsp.flags & VM_EVENT_FLAG_VCPU_PAUSED )
+ vm_event_vcpu_unpause(v);
}
return 0;
@@ -1139,7 +1139,7 @@ err_out:
/* A note on the rationale for unshare error handling:
* 1. Unshare can only fail with ENOMEM. Any other error conditions BUG_ON()'s
- * 2. We notify a potential dom0 helper through a mem_event ring. But we
+ * 2. We notify a potential dom0 helper through a vm_event ring. But we
* allow the notification to not go to sleep. If the event ring is full
* of ENOMEM warnings, then it's on the ball.
* 3. We cannot go to sleep until the unshare is resolved, because we might
diff --git a/xen/arch/x86/mm/p2m-pod.c b/xen/arch/x86/mm/p2m-pod.c
index 43f507c..0679f00 100644
--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -21,9 +21,9 @@
*/
#include <xen/iommu.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <xen/event.h>
-#include <public/mem_event.h>
+#include <public/vm_event.h>
#include <asm/domain.h>
#include <asm/page.h>
#include <asm/paging.h>
diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c
index e48b63a..654384a 100644
--- a/xen/arch/x86/mm/p2m-pt.c
+++ b/xen/arch/x86/mm/p2m-pt.c
@@ -26,10 +26,10 @@
*/
#include <xen/iommu.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <xen/event.h>
#include <xen/trace.h>
-#include <public/mem_event.h>
+#include <public/vm_event.h>
#include <asm/domain.h>
#include <asm/page.h>
#include <asm/paging.h>
diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
index b42322a..7544667 100644
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -25,9 +25,9 @@
*/
#include <xen/iommu.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <xen/event.h>
-#include <public/mem_event.h>
+#include <public/vm_event.h>
#include <asm/domain.h>
#include <asm/page.h>
#include <asm/paging.h>
@@ -1077,8 +1077,8 @@ int p2m_mem_paging_evict(struct domain *d, unsigned long gfn)
void p2m_mem_paging_drop_page(struct domain *d, unsigned long gfn,
p2m_type_t p2mt)
{
- mem_event_request_t req = {
- .reason = MEM_EVENT_REASON_MEM_PAGING,
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_MEM_PAGING,
.mem_paging_event.gfn = gfn
};
@@ -1086,21 +1086,21 @@ void p2m_mem_paging_drop_page(struct domain *d, unsigned long gfn,
* correctness of the guest execution at this point. If this is the only
* page that happens to be paged-out, we'll be okay.. but it's likely the
* guest will crash shortly anyways. */
- int rc = mem_event_claim_slot(d, &d->mem_event->paging);
+ int rc = vm_event_claim_slot(d, &d->vm_event->paging);
if ( rc < 0 )
return;
/* Send release notification to pager */
- req.flags = MEM_EVENT_FLAG_DROP_PAGE;
+ req.flags = VM_EVENT_FLAG_DROP_PAGE;
/* Update stats unless the page hasn't yet been evicted */
if ( p2mt != p2m_ram_paging_out )
atomic_dec(&d->paged_pages);
else
/* Evict will fail now, tag this request for pager */
- req.flags |= MEM_EVENT_FLAG_EVICT_FAIL;
+ req.flags |= VM_EVENT_FLAG_EVICT_FAIL;
- mem_event_put_request(d, &d->mem_event->paging, &req);
+ vm_event_put_request(d, &d->vm_event->paging, &req);
}
/**
@@ -1127,8 +1127,8 @@ void p2m_mem_paging_drop_page(struct domain *d, unsigned long gfn,
void p2m_mem_paging_populate(struct domain *d, unsigned long gfn)
{
struct vcpu *v = current;
- mem_event_request_t req = {
- .reason = MEM_EVENT_REASON_MEM_PAGING,
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_MEM_PAGING,
.mem_paging_event.gfn = gfn
};
p2m_type_t p2mt;
@@ -1137,7 +1137,7 @@ void p2m_mem_paging_populate(struct domain *d, unsigned long gfn)
struct p2m_domain *p2m = p2m_get_hostp2m(d);
/* We're paging. There should be a ring */
- int rc = mem_event_claim_slot(d, &d->mem_event->paging);
+ int rc = vm_event_claim_slot(d, &d->vm_event->paging);
if ( rc == -ENOSYS )
{
gdprintk(XENLOG_ERR, "Domain %hu paging gfn %lx yet no ring "
@@ -1159,7 +1159,7 @@ void p2m_mem_paging_populate(struct domain *d, unsigned long gfn)
{
/* Evict will fail now, tag this request for pager */
if ( p2mt == p2m_ram_paging_out )
- req.flags |= MEM_EVENT_FLAG_EVICT_FAIL;
+ req.flags |= VM_EVENT_FLAG_EVICT_FAIL;
p2m_set_entry(p2m, gfn, mfn, PAGE_ORDER_4K, p2m_ram_paging_in, a);
}
@@ -1168,14 +1168,14 @@ void p2m_mem_paging_populate(struct domain *d, unsigned long gfn)
/* Pause domain if request came from guest and gfn has paging type */
if ( p2m_is_paging(p2mt) && v->domain == d )
{
- mem_event_vcpu_pause(v);
- req.flags |= MEM_EVENT_FLAG_VCPU_PAUSED;
+ vm_event_vcpu_pause(v);
+ req.flags |= VM_EVENT_FLAG_VCPU_PAUSED;
}
/* No need to inform pager if the gfn is not in the page-out path */
else if ( p2mt != p2m_ram_paging_out && p2mt != p2m_ram_paged )
{
/* gfn is already on its way back and vcpu is not paused */
- mem_event_cancel_slot(d, &d->mem_event->paging);
+ vm_event_cancel_slot(d, &d->vm_event->paging);
return;
}
@@ -1183,7 +1183,7 @@ void p2m_mem_paging_populate(struct domain *d, unsigned long gfn)
req.mem_paging_event.p2mt = p2mt;
req.vcpu_id = v->vcpu_id;
- mem_event_put_request(d, &d->mem_event->paging, &req);
+ vm_event_put_request(d, &d->vm_event->paging, &req);
}
/**
@@ -1292,17 +1292,17 @@ int p2m_mem_paging_prep(struct domain *d, unsigned long gfn, uint64_t buffer)
void p2m_mem_paging_resume(struct domain *d)
{
struct p2m_domain *p2m = p2m_get_hostp2m(d);
- mem_event_response_t rsp;
+ vm_event_response_t rsp;
p2m_type_t p2mt;
p2m_access_t a;
mfn_t mfn;
/* Pull all responses off the ring */
- while( mem_event_get_response(d, &d->mem_event->paging, &rsp) )
+ while( vm_event_get_response(d, &d->vm_event->paging, &rsp) )
{
struct vcpu *v;
- if ( rsp.flags & MEM_EVENT_FLAG_DUMMY )
+ if ( rsp.flags & VM_EVENT_FLAG_DUMMY )
continue;
/* Validate the vcpu_id in the response. */
@@ -1312,7 +1312,7 @@ void p2m_mem_paging_resume(struct domain *d)
v = d->vcpu[rsp.vcpu_id];
/* Fix p2m entry if the page was not dropped */
- if ( !(rsp.flags & MEM_EVENT_FLAG_DROP_PAGE) )
+ if ( !(rsp.flags & VM_EVENT_FLAG_DROP_PAGE) )
{
gfn_lock(p2m, rsp.gfn, 0);
mfn = p2m->get_entry(p2m, rsp.mem_access_event.gfn, &p2mt, &a, 0, NULL);
@@ -1328,12 +1328,12 @@ void p2m_mem_paging_resume(struct domain *d)
gfn_unlock(p2m, rsp.gfn, 0);
}
/* Unpause domain */
- if ( rsp.flags & MEM_EVENT_FLAG_VCPU_PAUSED )
- mem_event_vcpu_unpause(v);
+ if ( rsp.flags & VM_EVENT_FLAG_VCPU_PAUSED )
+ vm_event_vcpu_unpause(v);
}
}
-static void p2m_mem_event_fill_regs(mem_event_request_t *req)
+static void p2m_vm_event_fill_regs(vm_event_request_t *req)
{
const struct cpu_user_regs *regs = guest_cpu_user_regs();
struct segment_register seg;
@@ -1388,10 +1388,10 @@ static void p2m_mem_event_fill_regs(mem_event_request_t *req)
req->regs.x86.cs_arbytes = seg.attr.bytes;
}
-void p2m_mem_event_emulate_check(struct vcpu *v, const mem_event_response_t *rsp)
+void p2m_mem_access_emulate_check(struct vcpu *v, const vm_event_response_t *rsp)
{
/* Mark vcpu for skipping one instruction upon rescheduling. */
- if ( rsp->flags & MEM_EVENT_FLAG_EMULATE )
+ if ( rsp->flags & VM_EVENT_FLAG_EMULATE )
{
xenmem_access_t access;
bool_t violation = 1;
@@ -1438,7 +1438,7 @@ void p2m_mem_event_emulate_check(struct vcpu *v, const mem_event_response_t *rsp
}
}
- v->arch.mem_event.emulate_flags = violation ? rsp->flags : 0;
+ v->arch.vm_event.emulate_flags = violation ? rsp->flags : 0;
}
}
@@ -1453,7 +1453,7 @@ void p2m_setup_introspection(struct domain *d)
bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
struct npfec npfec,
- mem_event_request_t **req_ptr)
+ vm_event_request_t **req_ptr)
{
struct vcpu *v = current;
unsigned long gfn = gpa >> PAGE_SHIFT;
@@ -1462,7 +1462,7 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
mfn_t mfn;
p2m_type_t p2mt;
p2m_access_t p2ma;
- mem_event_request_t *req;
+ vm_event_request_t *req;
int rc;
unsigned long eip = guest_cpu_user_regs()->eip;
@@ -1489,13 +1489,13 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
gfn_unlock(p2m, gfn, 0);
/* Otherwise, check if there is a memory event listener, and send the message along */
- if ( !mem_event_check_ring(&d->mem_event->monitor) || !req_ptr )
+ if ( !vm_event_check_ring(&d->vm_event->monitor) || !req_ptr )
{
/* No listener */
if ( p2m->access_required )
{
gdprintk(XENLOG_INFO, "Memory access permissions failure, "
- "no mem_event listener VCPU %d, dom %d\n",
+ "no vm_event listener VCPU %d, dom %d\n",
v->vcpu_id, d->domain_id);
domain_crash(v->domain);
return 0;
@@ -1518,40 +1518,40 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
}
}
- /* The previous mem_event reply does not match the current state. */
- if ( v->arch.mem_event.gpa != gpa || v->arch.mem_event.eip != eip )
+ /* The previous vm_event reply does not match the current state. */
+ if ( v->arch.vm_event.gpa != gpa || v->arch.vm_event.eip != eip )
{
- /* Don't emulate the current instruction, send a new mem_event. */
- v->arch.mem_event.emulate_flags = 0;
+ /* Don't emulate the current instruction, send a new vm_event. */
+ v->arch.vm_event.emulate_flags = 0;
/*
* Make sure to mark the current state to match it again against
- * the new mem_event about to be sent.
+ * the new vm_event about to be sent.
*/
- v->arch.mem_event.gpa = gpa;
- v->arch.mem_event.eip = eip;
+ v->arch.vm_event.gpa = gpa;
+ v->arch.vm_event.eip = eip;
}
- if ( v->arch.mem_event.emulate_flags )
+ if ( v->arch.vm_event.emulate_flags )
{
- hvm_mem_event_emulate_one((v->arch.mem_event.emulate_flags &
- MEM_EVENT_FLAG_EMULATE_NOWRITE) != 0,
- TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE);
+ hvm_mem_access_emulate_one((v->arch.vm_event.emulate_flags &
+ VM_EVENT_FLAG_EMULATE_NOWRITE) != 0,
+ TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE);
- v->arch.mem_event.emulate_flags = 0;
+ v->arch.vm_event.emulate_flags = 0;
return 1;
}
*req_ptr = NULL;
- req = xzalloc(mem_event_request_t);
+ req = xzalloc(vm_event_request_t);
if ( req )
{
*req_ptr = req;
- req->reason = MEM_EVENT_REASON_MEM_ACCESS_VIOLATION;
+ req->reason = VM_EVENT_REASON_MEM_ACCESS_VIOLATION;
/* Pause the current VCPU */
if ( p2ma != p2m_access_n2rwx )
- req->flags |= MEM_EVENT_FLAG_VCPU_PAUSED;
+ req->flags |= VM_EVENT_FLAG_VCPU_PAUSED;
/* Send request to mem event */
req->mem_access_event.gfn = gfn;
@@ -1567,12 +1567,12 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
req->mem_access_event.access_x = npfec.insn_fetch;
req->vcpu_id = v->vcpu_id;
- p2m_mem_event_fill_regs(req);
+ p2m_vm_event_fill_regs(req);
}
/* Pause the current VCPU */
if ( p2ma != p2m_access_n2rwx )
- mem_event_vcpu_pause(v);
+ vm_event_vcpu_pause(v);
/* VCPU may be paused, return whether we promoted automatically */
return (p2ma == p2m_access_n2rwx);
diff --git a/xen/arch/x86/x86_64/compat/mm.c b/xen/arch/x86/x86_64/compat/mm.c
index c8ea85a..959ccf5 100644
--- a/xen/arch/x86/x86_64/compat/mm.c
+++ b/xen/arch/x86/x86_64/compat/mm.c
@@ -1,5 +1,5 @@
#include <xen/event.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <xen/mem_access.h>
#include <xen/multicall.h>
#include <compat/memory.h>
@@ -191,7 +191,7 @@ int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
xen_mem_paging_op_t mpo;
if ( copy_from_guest(&mpo, arg, 1) )
return -EFAULT;
- rc = do_mem_event_op(cmd, mpo.domain, &mpo);
+ rc = do_vm_event_op(cmd, mpo.domain, &mpo);
if ( !rc && __copy_to_guest(arg, &mpo, 1) )
return -EFAULT;
break;
@@ -204,7 +204,7 @@ int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
return -EFAULT;
if ( mso.op == XENMEM_sharing_op_audit )
return mem_sharing_audit();
- rc = do_mem_event_op(cmd, mso.domain, &mso);
+ rc = do_vm_event_op(cmd, mso.domain, &mso);
if ( !rc && __copy_to_guest(arg, &mso, 1) )
return -EFAULT;
break;
diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c
index 2fa1f67..47c8578 100644
--- a/xen/arch/x86/x86_64/mm.c
+++ b/xen/arch/x86/x86_64/mm.c
@@ -26,7 +26,7 @@
#include <xen/nodemask.h>
#include <xen/guest_access.h>
#include <xen/hypercall.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <xen/mem_access.h>
#include <asm/current.h>
#include <asm/asm_defns.h>
@@ -988,7 +988,8 @@ long subarch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
xen_mem_paging_op_t mpo;
if ( copy_from_guest(&mpo, arg, 1) )
return -EFAULT;
- rc = do_mem_event_op(cmd, mpo.domain, &mpo);
+
+ rc = do_vm_event_op(cmd, mpo.domain, &mpo);
if ( !rc && __copy_to_guest(arg, &mpo, 1) )
return -EFAULT;
break;
@@ -1001,7 +1002,7 @@ long subarch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
return -EFAULT;
if ( mso.op == XENMEM_sharing_op_audit )
return mem_sharing_audit();
- rc = do_mem_event_op(cmd, mso.domain, &mso);
+ rc = do_vm_event_op(cmd, mso.domain, &mso);
if ( !rc && __copy_to_guest(arg, &mso, 1) )
return -EFAULT;
break;
diff --git a/xen/common/Makefile b/xen/common/Makefile
index 8391246..f1b73a3 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -54,7 +54,7 @@ obj-y += rbtree.o
obj-y += lzo.o
obj-$(HAS_PDX) += pdx.o
obj-$(HAS_MEM_ACCESS) += mem_access.o
-obj-$(HAS_MEM_ACCESS) += mem_event.o
+obj-$(HAS_MEM_ACCESS) += vm_event.o
obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma unlzo unlz4 earlycpio,$(n).init.o)
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 336e9ea..d739614 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -15,7 +15,7 @@
#include <xen/domain.h>
#include <xen/mm.h>
#include <xen/event.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <xen/time.h>
#include <xen/console.h>
#include <xen/softirq.h>
@@ -344,8 +344,8 @@ struct domain *domain_create(
poolid = 0;
err = -ENOMEM;
- d->mem_event = xzalloc(struct mem_event_per_domain);
- if ( !d->mem_event )
+ d->vm_event = xzalloc(struct vm_event_per_domain);
+ if ( !d->vm_event )
goto fail;
d->pbuf = xzalloc_array(char, DOMAIN_PBUF_SIZE);
@@ -387,7 +387,7 @@ struct domain *domain_create(
if ( hardware_domain == d )
hardware_domain = old_hwdom;
atomic_set(&d->refcnt, DOMAIN_DESTROYED);
- xfree(d->mem_event);
+ xfree(d->vm_event);
xfree(d->pbuf);
if ( init_status & INIT_arch )
arch_domain_destroy(d);
@@ -629,7 +629,7 @@ int domain_kill(struct domain *d)
d->is_dying = DOMDYING_dead;
/* Mem event cleanup has to go here because the rings
* have to be put before we call put_domain. */
- mem_event_cleanup(d);
+ vm_event_cleanup(d);
put_domain(d);
send_global_virq(VIRQ_DOM_EXC);
/* fallthrough */
@@ -808,7 +808,7 @@ static void complete_domain_destroy(struct rcu_head *head)
free_xenoprof_pages(d);
#endif
- xfree(d->mem_event);
+ xfree(d->vm_event);
xfree(d->pbuf);
for ( i = d->max_vcpus - 1; i >= 0; i-- )
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index f15dcfe..e6d8310 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -24,7 +24,7 @@
#include <xen/bitmap.h>
#include <xen/paging.h>
#include <xen/hypercall.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <asm/current.h>
#include <asm/irq.h>
#include <asm/page.h>
@@ -1113,8 +1113,8 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
}
break;
- case XEN_DOMCTL_mem_event_op:
- ret = mem_event_domctl(d, &op->u.mem_event_op,
+ case XEN_DOMCTL_vm_event_op:
+ ret = vm_event_domctl(d, &op->u.vm_event_op,
guest_handle_cast(u_domctl, void));
copyback = 1;
break;
diff --git a/xen/common/mem_access.c b/xen/common/mem_access.c
index f01ccfd..b8d3d49 100644
--- a/xen/common/mem_access.c
+++ b/xen/common/mem_access.c
@@ -24,21 +24,21 @@
#include <xen/sched.h>
#include <xen/guest_access.h>
#include <xen/hypercall.h>
-#include <xen/mem_event.h>
+#include <xen/vm_event.h>
#include <public/memory.h>
#include <asm/p2m.h>
#include <xsm/xsm.h>
void mem_access_resume(struct domain *d)
{
- mem_event_response_t rsp;
+ vm_event_response_t rsp;
/* Pull all responses off the ring. */
- while ( mem_event_get_response(d, &d->mem_event->monitor, &rsp) )
+ while ( vm_event_get_response(d, &d->vm_event->monitor, &rsp) )
{
struct vcpu *v;
- if ( rsp.flags & MEM_EVENT_FLAG_DUMMY )
+ if ( rsp.flags & VM_EVENT_FLAG_DUMMY )
continue;
/* Validate the vcpu_id in the response. */
@@ -47,11 +47,11 @@ void mem_access_resume(struct domain *d)
v = d->vcpu[rsp.vcpu_id];
- p2m_mem_event_emulate_check(v, &rsp);
+ p2m_mem_access_emulate_check(v, &rsp);
/* Unpause domain. */
- if ( rsp.flags & MEM_EVENT_FLAG_VCPU_PAUSED )
- mem_event_vcpu_unpause(v);
+ if ( rsp.flags & VM_EVENT_FLAG_VCPU_PAUSED )
+ vm_event_vcpu_unpause(v);
}
}
@@ -74,12 +74,12 @@ int mem_access_memop(unsigned long cmd,
if ( !p2m_mem_access_sanity_check(d) )
goto out;
- rc = xsm_mem_event_op(XSM_DM_PRIV, d, XENMEM_access_op);
+ rc = xsm_vm_event_op(XSM_DM_PRIV, d, XENMEM_access_op);
if ( rc )
goto out;
rc = -ENODEV;
- if ( unlikely(!d->mem_event->monitor.ring_page) )
+ if ( unlikely(!d->vm_event->monitor.ring_page) )
goto out;
switch ( mao.op )
@@ -144,13 +144,13 @@ int mem_access_memop(unsigned long cmd,
return rc;
}
-int mem_access_send_req(struct domain *d, mem_event_request_t *req)
+int mem_access_send_req(struct domain *d, vm_event_request_t *req)
{
- int rc = mem_event_claim_slot(d, &d->mem_event->monitor);
+ int rc = vm_event_claim_slot(d, &d->vm_event->monitor);
if ( rc < 0 )
return rc;
- mem_event_put_request(d, &d->mem_event->monitor, req);
+ vm_event_put_request(d, &d->vm_event->monitor, req);
return 0;
}
diff --git a/xen/common/mem_event.c b/xen/common/mem_event.c
deleted file mode 100644
index b99e7d5..0000000
--- a/xen/common/mem_event.c
+++ /dev/null
@@ -1,742 +0,0 @@
-/******************************************************************************
- * mem_event.c
- *
- * Memory event support.
- *
- * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp)
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- */
-
-
-#include <xen/sched.h>
-#include <xen/event.h>
-#include <xen/wait.h>
-#include <xen/mem_event.h>
-#include <xen/mem_access.h>
-#include <asm/p2m.h>
-
-#ifdef HAS_MEM_PAGING
-#include <asm/mem_paging.h>
-#endif
-
-#ifdef HAS_MEM_SHARING
-#include <asm/mem_sharing.h>
-#endif
-
-#include <xsm/xsm.h>
-
-/* for public/io/ring.h macros */
-#define xen_mb() mb()
-#define xen_rmb() rmb()
-#define xen_wmb() wmb()
-
-#define mem_event_ring_lock_init(_med) spin_lock_init(&(_med)->ring_lock)
-#define mem_event_ring_lock(_med) spin_lock(&(_med)->ring_lock)
-#define mem_event_ring_unlock(_med) spin_unlock(&(_med)->ring_lock)
-
-static int mem_event_enable(
- struct domain *d,
- xen_domctl_mem_event_op_t *mec,
- struct mem_event_domain *med,
- int pause_flag,
- int param,
- xen_event_channel_notification_t notification_fn)
-{
- int rc;
- unsigned long ring_gfn = d->arch.hvm_domain.params[param];
-
- /* Only one helper at a time. If the helper crashed,
- * the ring is in an undefined state and so is the guest.
- */
- if ( med->ring_page )
- return -EBUSY;
-
- /* The parameter defaults to zero, and it should be
- * set to something */
- if ( ring_gfn == 0 )
- return -ENOSYS;
-
- mem_event_ring_lock_init(med);
- mem_event_ring_lock(med);
-
- rc = prepare_ring_for_helper(d, ring_gfn, &med->ring_pg_struct,
- &med->ring_page);
- if ( rc < 0 )
- goto err;
-
- /* Set the number of currently blocked vCPUs to 0. */
- med->blocked = 0;
-
- /* Allocate event channel */
- rc = alloc_unbound_xen_event_channel(d->vcpu[0],
- current->domain->domain_id,
- notification_fn);
- if ( rc < 0 )
- goto err;
-
- med->xen_port = mec->port = rc;
-
- /* Prepare ring buffer */
- FRONT_RING_INIT(&med->front_ring,
- (mem_event_sring_t *)med->ring_page,
- PAGE_SIZE);
-
- /* Save the pause flag for this particular ring. */
- med->pause_flag = pause_flag;
-
- /* Initialize the last-chance wait queue. */
- init_waitqueue_head(&med->wq);
-
- mem_event_ring_unlock(med);
- return 0;
-
- err:
- destroy_ring_for_helper(&med->ring_page,
- med->ring_pg_struct);
- mem_event_ring_unlock(med);
-
- return rc;
-}
-
-static unsigned int mem_event_ring_available(struct mem_event_domain *med)
-{
- int avail_req = RING_FREE_REQUESTS(&med->front_ring);
- avail_req -= med->target_producers;
- avail_req -= med->foreign_producers;
-
- BUG_ON(avail_req < 0);
-
- return avail_req;
-}
-
-/*
- * mem_event_wake_blocked() will wakeup vcpus waiting for room in the
- * ring. These vCPUs were paused on their way out after placing an event,
- * but need to be resumed where the ring is capable of processing at least
- * one event from them.
- */
-static void mem_event_wake_blocked(struct domain *d, struct mem_event_domain *med)
-{
- struct vcpu *v;
- int online = d->max_vcpus;
- unsigned int avail_req = mem_event_ring_available(med);
-
- if ( avail_req == 0 || med->blocked == 0 )
- return;
-
- /*
- * We ensure that we only have vCPUs online if there are enough free slots
- * for their memory events to be processed. This will ensure that no
- * memory events are lost (due to the fact that certain types of events
- * cannot be replayed, we need to ensure that there is space in the ring
- * for when they are hit).
- * See comment below in mem_event_put_request().
- */
- for_each_vcpu ( d, v )
- if ( test_bit(med->pause_flag, &v->pause_flags) )
- online--;
-
- ASSERT(online == (d->max_vcpus - med->blocked));
-
- /* We remember which vcpu last woke up to avoid scanning always linearly
- * from zero and starving higher-numbered vcpus under high load */
- if ( d->vcpu )
- {
- int i, j, k;
-
- for (i = med->last_vcpu_wake_up + 1, j = 0; j < d->max_vcpus; i++, j++)
- {
- k = i % d->max_vcpus;
- v = d->vcpu[k];
- if ( !v )
- continue;
-
- if ( !(med->blocked) || online >= avail_req )
- break;
-
- if ( test_and_clear_bit(med->pause_flag, &v->pause_flags) )
- {
- vcpu_unpause(v);
- online++;
- med->blocked--;
- med->last_vcpu_wake_up = k;
- }
- }
- }
-}
-
-/*
- * In the event that a vCPU attempted to place an event in the ring and
- * was unable to do so, it is queued on a wait queue. These are woken as
- * needed, and take precedence over the blocked vCPUs.
- */
-static void mem_event_wake_queued(struct domain *d, struct mem_event_domain *med)
-{
- unsigned int avail_req = mem_event_ring_available(med);
-
- if ( avail_req > 0 )
- wake_up_nr(&med->wq, avail_req);
-}
-
-/*
- * mem_event_wake() will wakeup all vcpus waiting for the ring to
- * become available. If we have queued vCPUs, they get top priority. We
- * are guaranteed that they will go through code paths that will eventually
- * call mem_event_wake() again, ensuring that any blocked vCPUs will get
- * unpaused once all the queued vCPUs have made it through.
- */
-void mem_event_wake(struct domain *d, struct mem_event_domain *med)
-{
- if (!list_empty(&med->wq.list))
- mem_event_wake_queued(d, med);
- else
- mem_event_wake_blocked(d, med);
-}
-
-static int mem_event_disable(struct domain *d, struct mem_event_domain *med)
-{
- if ( med->ring_page )
- {
- struct vcpu *v;
-
- mem_event_ring_lock(med);
-
- if ( !list_empty(&med->wq.list) )
- {
- mem_event_ring_unlock(med);
- return -EBUSY;
- }
-
- /* Free domU's event channel and leave the other one unbound */
- free_xen_event_channel(d->vcpu[0], med->xen_port);
-
- /* Unblock all vCPUs */
- for_each_vcpu ( d, v )
- {
- if ( test_and_clear_bit(med->pause_flag, &v->pause_flags) )
- {
- vcpu_unpause(v);
- med->blocked--;
- }
- }
-
- destroy_ring_for_helper(&med->ring_page,
- med->ring_pg_struct);
- mem_event_ring_unlock(med);
- }
-
- return 0;
-}
-
-static inline void mem_event_release_slot(struct domain *d,
- struct mem_event_domain *med)
-{
- /* Update the accounting */
- if ( current->domain == d )
- med->target_producers--;
- else
- med->foreign_producers--;
-
- /* Kick any waiters */
- mem_event_wake(d, med);
-}
-
-/*
- * mem_event_mark_and_pause() tags vcpu and put it to sleep.
- * The vcpu will resume execution in mem_event_wake_waiters().
- */
-void mem_event_mark_and_pause(struct vcpu *v, struct mem_event_domain *med)
-{
- if ( !test_and_set_bit(med->pause_flag, &v->pause_flags) )
- {
- vcpu_pause_nosync(v);
- med->blocked++;
- }
-}
-
-/*
- * This must be preceded by a call to claim_slot(), and is guaranteed to
- * succeed. As a side-effect however, the vCPU may be paused if the ring is
- * overly full and its continued execution would cause stalling and excessive
- * waiting. The vCPU will be automatically unpaused when the ring clears.
- */
-void mem_event_put_request(struct domain *d,
- struct mem_event_domain *med,
- mem_event_request_t *req)
-{
- mem_event_front_ring_t *front_ring;
- int free_req;
- unsigned int avail_req;
- RING_IDX req_prod;
-
- if ( current->domain != d )
- {
- req->flags |= MEM_EVENT_FLAG_FOREIGN;
-#ifndef NDEBUG
- if ( !(req->flags & MEM_EVENT_FLAG_VCPU_PAUSED) )
- gdprintk(XENLOG_G_WARNING, "d%dv%d was not paused.\n",
- d->domain_id, req->vcpu_id);
-#endif
- }
-
- mem_event_ring_lock(med);
-
- /* Due to the reservations, this step must succeed. */
- front_ring = &med->front_ring;
- free_req = RING_FREE_REQUESTS(front_ring);
- ASSERT(free_req > 0);
-
- /* Copy request */
- req_prod = front_ring->req_prod_pvt;
- memcpy(RING_GET_REQUEST(front_ring, req_prod), req, sizeof(*req));
- req_prod++;
-
- /* Update ring */
- front_ring->req_prod_pvt = req_prod;
- RING_PUSH_REQUESTS(front_ring);
-
- /* We've actually *used* our reservation, so release the slot. */
- mem_event_release_slot(d, med);
-
- /* Give this vCPU a black eye if necessary, on the way out.
- * See the comments above wake_blocked() for more information
- * on how this mechanism works to avoid waiting. */
- avail_req = mem_event_ring_available(med);
- if( current->domain == d && avail_req < d->max_vcpus )
- mem_event_mark_and_pause(current, med);
-
- mem_event_ring_unlock(med);
-
- notify_via_xen_event_channel(d, med->xen_port);
-}
-
-int mem_event_get_response(struct domain *d, struct mem_event_domain *med, mem_event_response_t *rsp)
-{
- mem_event_front_ring_t *front_ring;
- RING_IDX rsp_cons;
-
- mem_event_ring_lock(med);
-
- front_ring = &med->front_ring;
- rsp_cons = front_ring->rsp_cons;
-
- if ( !RING_HAS_UNCONSUMED_RESPONSES(front_ring) )
- {
- mem_event_ring_unlock(med);
- return 0;
- }
-
- /* Copy response */
- memcpy(rsp, RING_GET_RESPONSE(front_ring, rsp_cons), sizeof(*rsp));
- rsp_cons++;
-
- /* Update ring */
- front_ring->rsp_cons = rsp_cons;
- front_ring->sring->rsp_event = rsp_cons + 1;
-
- /* Kick any waiters -- since we've just consumed an event,
- * there may be additional space available in the ring. */
- mem_event_wake(d, med);
-
- mem_event_ring_unlock(med);
-
- return 1;
-}
-
-void mem_event_cancel_slot(struct domain *d, struct mem_event_domain *med)
-{
- mem_event_ring_lock(med);
- mem_event_release_slot(d, med);
- mem_event_ring_unlock(med);
-}
-
-static int mem_event_grab_slot(struct mem_event_domain *med, int foreign)
-{
- unsigned int avail_req;
-
- if ( !med->ring_page )
- return -ENOSYS;
-
- mem_event_ring_lock(med);
-
- avail_req = mem_event_ring_available(med);
- if ( avail_req == 0 )
- {
- mem_event_ring_unlock(med);
- return -EBUSY;
- }
-
- if ( !foreign )
- med->target_producers++;
- else
- med->foreign_producers++;
-
- mem_event_ring_unlock(med);
-
- return 0;
-}
-
-/* Simple try_grab wrapper for use in the wait_event() macro. */
-static int mem_event_wait_try_grab(struct mem_event_domain *med, int *rc)
-{
- *rc = mem_event_grab_slot(med, 0);
- return *rc;
-}
-
-/* Call mem_event_grab_slot() until the ring doesn't exist, or is available. */
-static int mem_event_wait_slot(struct mem_event_domain *med)
-{
- int rc = -EBUSY;
- wait_event(med->wq, mem_event_wait_try_grab(med, &rc) != -EBUSY);
- return rc;
-}
-
-bool_t mem_event_check_ring(struct mem_event_domain *med)
-{
- return (med->ring_page != NULL);
-}
-
-/*
- * Determines whether or not the current vCPU belongs to the target domain,
- * and calls the appropriate wait function. If it is a guest vCPU, then we
- * use mem_event_wait_slot() to reserve a slot. As long as there is a ring,
- * this function will always return 0 for a guest. For a non-guest, we check
- * for space and return -EBUSY if the ring is not available.
- *
- * Return codes: -ENOSYS: the ring is not yet configured
- * -EBUSY: the ring is busy
- * 0: a spot has been reserved
- *
- */
-int __mem_event_claim_slot(struct domain *d, struct mem_event_domain *med,
- bool_t allow_sleep)
-{
- if ( (current->domain == d) && allow_sleep )
- return mem_event_wait_slot(med);
- else
- return mem_event_grab_slot(med, (current->domain != d));
-}
-
-#ifdef HAS_MEM_PAGING
-/* Registered with Xen-bound event channel for incoming notifications. */
-static void mem_paging_notification(struct vcpu *v, unsigned int port)
-{
- if ( likely(v->domain->mem_event->paging.ring_page != NULL) )
- p2m_mem_paging_resume(v->domain);
-}
-#endif
-
-#ifdef HAS_MEM_ACCESS
-/* Registered with Xen-bound event channel for incoming notifications. */
-static void mem_access_notification(struct vcpu *v, unsigned int port)
-{
- if ( likely(v->domain->mem_event->monitor.ring_page != NULL) )
- mem_access_resume(v->domain);
-}
-#endif
-
-#ifdef HAS_MEM_SHARING
-/* Registered with Xen-bound event channel for incoming notifications. */
-static void mem_sharing_notification(struct vcpu *v, unsigned int port)
-{
- if ( likely(v->domain->mem_event->share.ring_page != NULL) )
- mem_sharing_sharing_resume(v->domain);
-}
-#endif
-
-int do_mem_event_op(int op, uint32_t domain, void *arg)
-{
- int ret;
- struct domain *d;
-
- ret = rcu_lock_live_remote_domain_by_id(domain, &d);
- if ( ret )
- return ret;
-
- ret = xsm_mem_event_op(XSM_DM_PRIV, d, op);
- if ( ret )
- goto out;
-
- switch (op)
- {
-#ifdef HAS_MEM_PAGING
- case XENMEM_paging_op:
- ret = mem_paging_memop(d, (xen_mem_paging_op_t *) arg);
- break;
-#endif
-#ifdef HAS_MEM_SHARING
- case XENMEM_sharing_op:
- ret = mem_sharing_memop(d, (xen_mem_sharing_op_t *) arg);
- break;
-#endif
- default:
- ret = -ENOSYS;
- }
-
- out:
- rcu_unlock_domain(d);
- return ret;
-}
-
-/* Clean up on domain destruction */
-void mem_event_cleanup(struct domain *d)
-{
-#ifdef HAS_MEM_PAGING
- if ( d->mem_event->paging.ring_page ) {
- /* Destroying the wait queue head means waking up all
- * queued vcpus. This will drain the list, allowing
- * the disable routine to complete. It will also drop
- * all domain refs the wait-queued vcpus are holding.
- * Finally, because this code path involves previously
- * pausing the domain (domain_kill), unpausing the
- * vcpus causes no harm. */
- destroy_waitqueue_head(&d->mem_event->paging.wq);
- (void)mem_event_disable(d, &d->mem_event->paging);
- }
-#endif
-#ifdef HAS_MEM_ACCESS
- if ( d->mem_event->monitor.ring_page ) {
- destroy_waitqueue_head(&d->mem_event->monitor.wq);
- (void)mem_event_disable(d, &d->mem_event->monitor);
- }
-#endif
-#ifdef HAS_MEM_SHARING
- if ( d->mem_event->share.ring_page ) {
- destroy_waitqueue_head(&d->mem_event->share.wq);
- (void)mem_event_disable(d, &d->mem_event->share);
- }
-#endif
-}
-
-int mem_event_domctl(struct domain *d, xen_domctl_mem_event_op_t *mec,
- XEN_GUEST_HANDLE_PARAM(void) u_domctl)
-{
- int rc;
-
- rc = xsm_mem_event_control(XSM_PRIV, d, mec->mode, mec->op);
- if ( rc )
- return rc;
-
- if ( unlikely(d == current->domain) )
- {
- gdprintk(XENLOG_INFO, "Tried to do a memory event op on itself.\n");
- return -EINVAL;
- }
-
- if ( unlikely(d->is_dying) )
- {
- gdprintk(XENLOG_INFO, "Ignoring memory event op on dying domain %u\n",
- d->domain_id);
- return 0;
- }
-
- if ( unlikely(d->vcpu == NULL) || unlikely(d->vcpu[0] == NULL) )
- {
- gdprintk(XENLOG_INFO,
- "Memory event op on a domain (%u) with no vcpus\n",
- d->domain_id);
- return -EINVAL;
- }
-
- rc = -ENOSYS;
-
- switch ( mec->mode )
- {
-#ifdef HAS_MEM_PAGING
- case XEN_DOMCTL_MEM_EVENT_OP_PAGING:
- {
- struct mem_event_domain *med = &d->mem_event->paging;
- rc = -EINVAL;
-
- switch( mec->op )
- {
- case XEN_DOMCTL_MEM_EVENT_OP_PAGING_ENABLE:
- {
- struct p2m_domain *p2m = p2m_get_hostp2m(d);
-
- rc = -EOPNOTSUPP;
- /* pvh fixme: p2m_is_foreign types need addressing */
- if ( is_pvh_vcpu(current) || is_pvh_domain(hardware_domain) )
- break;
-
- rc = -ENODEV;
- /* Only HAP is supported */
- if ( !hap_enabled(d) )
- break;
-
- /* No paging if iommu is used */
- rc = -EMLINK;
- if ( unlikely(need_iommu(d)) )
- break;
-
- rc = -EXDEV;
- /* Disallow paging in a PoD guest */
- if ( p2m->pod.entry_count )
- break;
-
- rc = mem_event_enable(d, mec, med, _VPF_mem_paging,
- HVM_PARAM_PAGING_RING_PFN,
- mem_paging_notification);
- }
- break;
-
- case XEN_DOMCTL_MEM_EVENT_OP_PAGING_DISABLE:
- {
- if ( med->ring_page )
- rc = mem_event_disable(d, med);
- }
- break;
-
- default:
- rc = -ENOSYS;
- break;
- }
- }
- break;
-#endif
-
-#ifdef HAS_MEM_ACCESS
- case XEN_DOMCTL_MEM_EVENT_OP_MONITOR:
- {
- struct mem_event_domain *med = &d->mem_event->monitor;
- rc = -EINVAL;
-
- switch( mec->op )
- {
- case XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE:
- case XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION:
- {
- rc = -ENODEV;
- if ( !p2m_mem_event_sanity_check(d) )
- break;
-
- rc = mem_event_enable(d, mec, med, _VPF_mem_access,
- HVM_PARAM_MONITOR_RING_PFN,
- mem_access_notification);
-
- if ( mec->op == XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION
- && !rc )
- p2m_setup_introspection(d);
-
- }
- break;
-
- case XEN_DOMCTL_MEM_EVENT_OP_MONITOR_DISABLE:
- {
- if ( med->ring_page )
- {
- rc = mem_event_disable(d, med);
- d->arch.hvm_domain.introspection_enabled = 0;
- }
- }
- break;
-
- default:
- rc = -ENOSYS;
- break;
- }
- }
- break;
-#endif
-
-#ifdef HAS_MEM_SHARING
- case XEN_DOMCTL_MEM_EVENT_OP_SHARING:
- {
- struct mem_event_domain *med = &d->mem_event->share;
- rc = -EINVAL;
-
- switch( mec->op )
- {
- case XEN_DOMCTL_MEM_EVENT_OP_SHARING_ENABLE:
- {
- rc = -EOPNOTSUPP;
- /* pvh fixme: p2m_is_foreign types need addressing */
- if ( is_pvh_vcpu(current) || is_pvh_domain(hardware_domain) )
- break;
-
- rc = -ENODEV;
- /* Only HAP is supported */
- if ( !hap_enabled(d) )
- break;
-
- rc = mem_event_enable(d, mec, med, _VPF_mem_sharing,
- HVM_PARAM_SHARING_RING_PFN,
- mem_sharing_notification);
- }
- break;
-
- case XEN_DOMCTL_MEM_EVENT_OP_SHARING_DISABLE:
- {
- if ( med->ring_page )
- rc = mem_event_disable(d, med);
- }
- break;
-
- default:
- rc = -ENOSYS;
- break;
- }
- }
- break;
-#endif
-
- default:
- rc = -ENOSYS;
- }
-
- return rc;
-}
-
-void mem_event_vcpu_pause(struct vcpu *v)
-{
- ASSERT(v == current);
-
- atomic_inc(&v->mem_event_pause_count);
- vcpu_pause_nosync(v);
-}
-
-void mem_event_vcpu_unpause(struct vcpu *v)
-{
- int old, new, prev = v->mem_event_pause_count.counter;
-
- /* All unpause requests as a result of toolstack responses. Prevent
- * underflow of the vcpu pause count. */
- do
- {
- old = prev;
- new = old - 1;
-
- if ( new < 0 )
- {
- printk(XENLOG_G_WARNING
- "%pv mem_event: Too many unpause attempts\n", v);
- return;
- }
-
- prev = cmpxchg(&v->mem_event_pause_count.counter, old, new);
- } while ( prev != old );
-
- vcpu_unpause(v);
-}
-
-/*
- * Local variables:
- * mode: C
- * c-file-style: "BSD"
- * c-basic-offset: 4
- * indent-tabs-mode: nil
- * End:
- */
diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
new file mode 100644
index 0000000..f81eae4
--- /dev/null
+++ b/xen/common/vm_event.c
@@ -0,0 +1,742 @@
+/******************************************************************************
+ * vm_event.c
+ *
+ * VM event support.
+ *
+ * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp)
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+
+#include <xen/sched.h>
+#include <xen/event.h>
+#include <xen/wait.h>
+#include <xen/vm_event.h>
+#include <xen/mem_access.h>
+#include <asm/p2m.h>
+
+#ifdef HAS_MEM_PAGING
+#include <asm/mem_paging.h>
+#endif
+
+#ifdef HAS_MEM_SHARING
+#include <asm/mem_sharing.h>
+#endif
+
+#include <xsm/xsm.h>
+
+/* for public/io/ring.h macros */
+#define xen_mb() mb()
+#define xen_rmb() rmb()
+#define xen_wmb() wmb()
+
+#define vm_event_ring_lock_init(_ved) spin_lock_init(&(_ved)->ring_lock)
+#define vm_event_ring_lock(_ved) spin_lock(&(_ved)->ring_lock)
+#define vm_event_ring_unlock(_ved) spin_unlock(&(_ved)->ring_lock)
+
+static int vm_event_enable(
+ struct domain *d,
+ xen_domctl_vm_event_op_t *vec,
+ struct vm_event_domain *ved,
+ int pause_flag,
+ int param,
+ xen_event_channel_notification_t notification_fn)
+{
+ int rc;
+ unsigned long ring_gfn = d->arch.hvm_domain.params[param];
+
+ /* Only one helper at a time. If the helper crashed,
+ * the ring is in an undefined state and so is the guest.
+ */
+ if ( ved->ring_page )
+ return -EBUSY;
+
+ /* The parameter defaults to zero, and it should be
+ * set to something */
+ if ( ring_gfn == 0 )
+ return -ENOSYS;
+
+ vm_event_ring_lock_init(ved);
+ vm_event_ring_lock(ved);
+
+ rc = prepare_ring_for_helper(d, ring_gfn, &ved->ring_pg_struct,
+ &ved->ring_page);
+ if ( rc < 0 )
+ goto err;
+
+ /* Set the number of currently blocked vCPUs to 0. */
+ ved->blocked = 0;
+
+ /* Allocate event channel */
+ rc = alloc_unbound_xen_event_channel(d->vcpu[0],
+ current->domain->domain_id,
+ notification_fn);
+ if ( rc < 0 )
+ goto err;
+
+ ved->xen_port = vec->port = rc;
+
+ /* Prepare ring buffer */
+ FRONT_RING_INIT(&ved->front_ring,
+ (vm_event_sring_t *)ved->ring_page,
+ PAGE_SIZE);
+
+ /* Save the pause flag for this particular ring. */
+ ved->pause_flag = pause_flag;
+
+ /* Initialize the last-chance wait queue. */
+ init_waitqueue_head(&ved->wq);
+
+ vm_event_ring_unlock(ved);
+ return 0;
+
+ err:
+ destroy_ring_for_helper(&ved->ring_page,
+ ved->ring_pg_struct);
+ vm_event_ring_unlock(ved);
+
+ return rc;
+}
+
+static unsigned int vm_event_ring_available(struct vm_event_domain *ved)
+{
+ int avail_req = RING_FREE_REQUESTS(&ved->front_ring);
+ avail_req -= ved->target_producers;
+ avail_req -= ved->foreign_producers;
+
+ BUG_ON(avail_req < 0);
+
+ return avail_req;
+}
+
+/*
+ * vm_event_wake_blocked() will wakeup vcpus waiting for room in the
+ * ring. These vCPUs were paused on their way out after placing an event,
+ * but need to be resumed where the ring is capable of processing at least
+ * one event from them.
+ */
+static void vm_event_wake_blocked(struct domain *d, struct vm_event_domain *ved)
+{
+ struct vcpu *v;
+ int online = d->max_vcpus;
+ unsigned int avail_req = vm_event_ring_available(ved);
+
+ if ( avail_req == 0 || ved->blocked == 0 )
+ return;
+
+ /*
+ * We ensure that we only have vCPUs online if there are enough free slots
+ * for their memory events to be processed. This will ensure that no
+ * memory events are lost (due to the fact that certain types of events
+ * cannot be replayed, we need to ensure that there is space in the ring
+ * for when they are hit).
+ * See comment below in vm_event_put_request().
+ */
+ for_each_vcpu ( d, v )
+ if ( test_bit(ved->pause_flag, &v->pause_flags) )
+ online--;
+
+ ASSERT(online == (d->max_vcpus - ved->blocked));
+
+ /* We remember which vcpu last woke up to avoid scanning always linearly
+ * from zero and starving higher-numbered vcpus under high load */
+ if ( d->vcpu )
+ {
+ int i, j, k;
+
+ for (i = ved->last_vcpu_wake_up + 1, j = 0; j < d->max_vcpus; i++, j++)
+ {
+ k = i % d->max_vcpus;
+ v = d->vcpu[k];
+ if ( !v )
+ continue;
+
+ if ( !(ved->blocked) || online >= avail_req )
+ break;
+
+ if ( test_and_clear_bit(ved->pause_flag, &v->pause_flags) )
+ {
+ vcpu_unpause(v);
+ online++;
+ ved->blocked--;
+ ved->last_vcpu_wake_up = k;
+ }
+ }
+ }
+}
+
+/*
+ * In the event that a vCPU attempted to place an event in the ring and
+ * was unable to do so, it is queued on a wait queue. These are woken as
+ * needed, and take precedence over the blocked vCPUs.
+ */
+static void vm_event_wake_queued(struct domain *d, struct vm_event_domain *ved)
+{
+ unsigned int avail_req = vm_event_ring_available(ved);
+
+ if ( avail_req > 0 )
+ wake_up_nr(&ved->wq, avail_req);
+}
+
+/*
+ * vm_event_wake() will wakeup all vcpus waiting for the ring to
+ * become available. If we have queued vCPUs, they get top priority. We
+ * are guaranteed that they will go through code paths that will eventually
+ * call vm_event_wake() again, ensuring that any blocked vCPUs will get
+ * unpaused once all the queued vCPUs have made it through.
+ */
+void vm_event_wake(struct domain *d, struct vm_event_domain *ved)
+{
+ if (!list_empty(&ved->wq.list))
+ vm_event_wake_queued(d, ved);
+ else
+ vm_event_wake_blocked(d, ved);
+}
+
+static int vm_event_disable(struct domain *d, struct vm_event_domain *ved)
+{
+ if ( ved->ring_page )
+ {
+ struct vcpu *v;
+
+ vm_event_ring_lock(ved);
+
+ if ( !list_empty(&ved->wq.list) )
+ {
+ vm_event_ring_unlock(ved);
+ return -EBUSY;
+ }
+
+ /* Free domU's event channel and leave the other one unbound */
+ free_xen_event_channel(d->vcpu[0], ved->xen_port);
+
+ /* Unblock all vCPUs */
+ for_each_vcpu ( d, v )
+ {
+ if ( test_and_clear_bit(ved->pause_flag, &v->pause_flags) )
+ {
+ vcpu_unpause(v);
+ ved->blocked--;
+ }
+ }
+
+ destroy_ring_for_helper(&ved->ring_page,
+ ved->ring_pg_struct);
+ vm_event_ring_unlock(ved);
+ }
+
+ return 0;
+}
+
+static inline void vm_event_release_slot(struct domain *d,
+ struct vm_event_domain *ved)
+{
+ /* Update the accounting */
+ if ( current->domain == d )
+ ved->target_producers--;
+ else
+ ved->foreign_producers--;
+
+ /* Kick any waiters */
+ vm_event_wake(d, ved);
+}
+
+/*
+ * vm_event_mark_and_pause() tags vcpu and put it to sleep.
+ * The vcpu will resume execution in vm_event_wake_waiters().
+ */
+void vm_event_mark_and_pause(struct vcpu *v, struct vm_event_domain *ved)
+{
+ if ( !test_and_set_bit(ved->pause_flag, &v->pause_flags) )
+ {
+ vcpu_pause_nosync(v);
+ ved->blocked++;
+ }
+}
+
+/*
+ * This must be preceded by a call to claim_slot(), and is guaranteed to
+ * succeed. As a side-effect however, the vCPU may be paused if the ring is
+ * overly full and its continued execution would cause stalling and excessive
+ * waiting. The vCPU will be automatically unpaused when the ring clears.
+ */
+void vm_event_put_request(struct domain *d,
+ struct vm_event_domain *ved,
+ vm_event_request_t *req)
+{
+ vm_event_front_ring_t *front_ring;
+ int free_req;
+ unsigned int avail_req;
+ RING_IDX req_prod;
+
+ if ( current->domain != d )
+ {
+ req->flags |= VM_EVENT_FLAG_FOREIGN;
+#ifndef NDEBUG
+ if ( !(req->flags & VM_EVENT_FLAG_VCPU_PAUSED) )
+ gdprintk(XENLOG_G_WARNING, "d%dv%d was not paused.\n",
+ d->domain_id, req->vcpu_id);
+#endif
+ }
+
+ vm_event_ring_lock(ved);
+
+ /* Due to the reservations, this step must succeed. */
+ front_ring = &ved->front_ring;
+ free_req = RING_FREE_REQUESTS(front_ring);
+ ASSERT(free_req > 0);
+
+ /* Copy request */
+ req_prod = front_ring->req_prod_pvt;
+ memcpy(RING_GET_REQUEST(front_ring, req_prod), req, sizeof(*req));
+ req_prod++;
+
+ /* Update ring */
+ front_ring->req_prod_pvt = req_prod;
+ RING_PUSH_REQUESTS(front_ring);
+
+ /* We've actually *used* our reservation, so release the slot. */
+ vm_event_release_slot(d, ved);
+
+ /* Give this vCPU a black eye if necessary, on the way out.
+ * See the comments above wake_blocked() for more information
+ * on how this vechanism works to avoid waiting. */
+ avail_req = vm_event_ring_available(ved);
+ if( current->domain == d && avail_req < d->max_vcpus )
+ vm_event_mark_and_pause(current, ved);
+
+ vm_event_ring_unlock(ved);
+
+ notify_via_xen_event_channel(d, ved->xen_port);
+}
+
+int vm_event_get_response(struct domain *d, struct vm_event_domain *ved, vm_event_response_t *rsp)
+{
+ vm_event_front_ring_t *front_ring;
+ RING_IDX rsp_cons;
+
+ vm_event_ring_lock(ved);
+
+ front_ring = &ved->front_ring;
+ rsp_cons = front_ring->rsp_cons;
+
+ if ( !RING_HAS_UNCONSUMED_RESPONSES(front_ring) )
+ {
+ vm_event_ring_unlock(ved);
+ return 0;
+ }
+
+ /* Copy response */
+ memcpy(rsp, RING_GET_RESPONSE(front_ring, rsp_cons), sizeof(*rsp));
+ rsp_cons++;
+
+ /* Update ring */
+ front_ring->rsp_cons = rsp_cons;
+ front_ring->sring->rsp_event = rsp_cons + 1;
+
+ /* Kick any waiters -- since we've just consumed an event,
+ * there may be additional space available in the ring. */
+ vm_event_wake(d, ved);
+
+ vm_event_ring_unlock(ved);
+
+ return 1;
+}
+
+void vm_event_cancel_slot(struct domain *d, struct vm_event_domain *ved)
+{
+ vm_event_ring_lock(ved);
+ vm_event_release_slot(d, ved);
+ vm_event_ring_unlock(ved);
+}
+
+static int vm_event_grab_slot(struct vm_event_domain *ved, int foreign)
+{
+ unsigned int avail_req;
+
+ if ( !ved->ring_page )
+ return -ENOSYS;
+
+ vm_event_ring_lock(ved);
+
+ avail_req = vm_event_ring_available(ved);
+ if ( avail_req == 0 )
+ {
+ vm_event_ring_unlock(ved);
+ return -EBUSY;
+ }
+
+ if ( !foreign )
+ ved->target_producers++;
+ else
+ ved->foreign_producers++;
+
+ vm_event_ring_unlock(ved);
+
+ return 0;
+}
+
+/* Simple try_grab wrapper for use in the wait_event() macro. */
+static int vm_event_wait_try_grab(struct vm_event_domain *ved, int *rc)
+{
+ *rc = vm_event_grab_slot(ved, 0);
+ return *rc;
+}
+
+/* Call vm_event_grab_slot() until the ring doesn't exist, or is available. */
+static int vm_event_wait_slot(struct vm_event_domain *ved)
+{
+ int rc = -EBUSY;
+ wait_event(ved->wq, vm_event_wait_try_grab(ved, &rc) != -EBUSY);
+ return rc;
+}
+
+bool_t vm_event_check_ring(struct vm_event_domain *ved)
+{
+ return (ved->ring_page != NULL);
+}
+
+/*
+ * Determines whether or not the current vCPU belongs to the target domain,
+ * and calls the appropriate wait function. If it is a guest vCPU, then we
+ * use vm_event_wait_slot() to reserve a slot. As long as there is a ring,
+ * this function will always return 0 for a guest. For a non-guest, we check
+ * for space and return -EBUSY if the ring is not available.
+ *
+ * Return codes: -ENOSYS: the ring is not yet configured
+ * -EBUSY: the ring is busy
+ * 0: a spot has been reserved
+ *
+ */
+int __vm_event_claim_slot(struct domain *d, struct vm_event_domain *ved,
+ bool_t allow_sleep)
+{
+ if ( (current->domain == d) && allow_sleep )
+ return vm_event_wait_slot(ved);
+ else
+ return vm_event_grab_slot(ved, (current->domain != d));
+}
+
+#ifdef HAS_MEM_PAGING
+/* Registered with Xen-bound event channel for incoming notifications. */
+static void mem_paging_notification(struct vcpu *v, unsigned int port)
+{
+ if ( likely(v->domain->vm_event->paging.ring_page != NULL) )
+ p2m_mem_paging_resume(v->domain);
+}
+#endif
+
+#ifdef HAS_MEM_ACCESS
+/* Registered with Xen-bound event channel for incoming notifications. */
+static void mem_access_notification(struct vcpu *v, unsigned int port)
+{
+ if ( likely(v->domain->vm_event->monitor.ring_page != NULL) )
+ mem_access_resume(v->domain);
+}
+#endif
+
+#ifdef HAS_MEM_SHARING
+/* Registered with Xen-bound event channel for incoming notifications. */
+static void mem_sharing_notification(struct vcpu *v, unsigned int port)
+{
+ if ( likely(v->domain->vm_event->share.ring_page != NULL) )
+ mem_sharing_sharing_resume(v->domain);
+}
+#endif
+
+int do_vm_event_op(int op, uint32_t domain, void *arg)
+{
+ int ret;
+ struct domain *d;
+
+ ret = rcu_lock_live_remote_domain_by_id(domain, &d);
+ if ( ret )
+ return ret;
+
+ ret = xsm_vm_event_op(XSM_DM_PRIV, d, op);
+ if ( ret )
+ goto out;
+
+ switch (op)
+ {
+#ifdef HAS_MEM_PAGING
+ case XENMEM_paging_op:
+ ret = mem_paging_memop(d, (xen_mem_paging_op_t *) arg);
+ break;
+#endif
+#ifdef HAS_MEM_SHARING
+ case XENMEM_sharing_op:
+ ret = mem_sharing_memop(d, (xen_mem_sharing_op_t *) arg);
+ break;
+#endif
+ default:
+ ret = -ENOSYS;
+ }
+
+ out:
+ rcu_unlock_domain(d);
+ return ret;
+}
+
+/* Clean up on domain destruction */
+void vm_event_cleanup(struct domain *d)
+{
+#ifdef HAS_MEM_PAGING
+ if ( d->vm_event->paging.ring_page ) {
+ /* Destroying the wait queue head means waking up all
+ * queued vcpus. This will drain the list, allowing
+ * the disable routine to complete. It will also drop
+ * all domain refs the wait-queued vcpus are holding.
+ * Finally, because this code path involves previously
+ * pausing the domain (domain_kill), unpausing the
+ * vcpus causes no harm. */
+ destroy_waitqueue_head(&d->vm_event->paging.wq);
+ (void)vm_event_disable(d, &d->vm_event->paging);
+ }
+#endif
+#ifdef HAS_MEM_ACCESS
+ if ( d->vm_event->monitor.ring_page ) {
+ destroy_waitqueue_head(&d->vm_event->monitor.wq);
+ (void)vm_event_disable(d, &d->vm_event->monitor);
+ }
+#endif
+#ifdef HAS_MEM_SHARING
+ if ( d->vm_event->share.ring_page ) {
+ destroy_waitqueue_head(&d->vm_event->share.wq);
+ (void)vm_event_disable(d, &d->vm_event->share);
+ }
+#endif
+}
+
+int vm_event_domctl(struct domain *d, xen_domctl_vm_event_op_t *vec,
+ XEN_GUEST_HANDLE_PARAM(void) u_domctl)
+{
+ int rc;
+
+ rc = xsm_vm_event_control(XSM_PRIV, d, vec->mode, vec->op);
+ if ( rc )
+ return rc;
+
+ if ( unlikely(d == current->domain) )
+ {
+ gdprintk(XENLOG_INFO, "Tried to do a memory event op on itself.\n");
+ return -EINVAL;
+ }
+
+ if ( unlikely(d->is_dying) )
+ {
+ gdprintk(XENLOG_INFO, "Ignoring memory event op on dying domain %u\n",
+ d->domain_id);
+ return 0;
+ }
+
+ if ( unlikely(d->vcpu == NULL) || unlikely(d->vcpu[0] == NULL) )
+ {
+ gdprintk(XENLOG_INFO,
+ "Memory event op on a domain (%u) with no vcpus\n",
+ d->domain_id);
+ return -EINVAL;
+ }
+
+ rc = -ENOSYS;
+
+ switch ( vec->mode )
+ {
+#ifdef HAS_MEM_PAGING
+ case XEN_DOMCTL_VM_EVENT_OP_PAGING:
+ {
+ struct vm_event_domain *ved = &d->vm_event->paging;
+ rc = -EINVAL;
+
+ switch( vec->op )
+ {
+ case XEN_DOMCTL_VM_EVENT_OP_PAGING_ENABLE:
+ {
+ struct p2m_domain *p2m = p2m_get_hostp2m(d);
+
+ rc = -EOPNOTSUPP;
+ /* pvh fixme: p2m_is_foreign types need addressing */
+ if ( is_pvh_vcpu(current) || is_pvh_domain(hardware_domain) )
+ break;
+
+ rc = -ENODEV;
+ /* Only HAP is supported */
+ if ( !hap_enabled(d) )
+ break;
+
+ /* No paging if iommu is used */
+ rc = -EMLINK;
+ if ( unlikely(need_iommu(d)) )
+ break;
+
+ rc = -EXDEV;
+ /* Disallow paging in a PoD guest */
+ if ( p2m->pod.entry_count )
+ break;
+
+ rc = vm_event_enable(d, vec, ved, _VPF_mem_paging,
+ HVM_PARAM_PAGING_RING_PFN,
+ mem_paging_notification);
+ }
+ break;
+
+ case XEN_DOMCTL_VM_EVENT_OP_PAGING_DISABLE:
+ {
+ if ( ved->ring_page )
+ rc = vm_event_disable(d, ved);
+ }
+ break;
+
+ default:
+ rc = -ENOSYS;
+ break;
+ }
+ }
+ break;
+#endif
+
+#ifdef HAS_MEM_ACCESS
+ case XEN_DOMCTL_VM_EVENT_OP_MONITOR:
+ {
+ struct vm_event_domain *ved = &d->vm_event->monitor;
+ rc = -EINVAL;
+
+ switch( vec->op )
+ {
+ case XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE:
+ case XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION:
+ {
+ rc = -ENODEV;
+ if ( !p2m_mem_access_sanity_check(d) )
+ break;
+
+ rc = vm_event_enable(d, vec, ved, _VPF_mem_access,
+ HVM_PARAM_MONITOR_RING_PFN,
+ mem_access_notification);
+
+ if ( vec->op == XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION
+ && !rc )
+ p2m_setup_introspection(d);
+
+ }
+ break;
+
+ case XEN_DOMCTL_VM_EVENT_OP_MONITOR_DISABLE:
+ {
+ if ( ved->ring_page )
+ {
+ rc = vm_event_disable(d, ved);
+ d->arch.hvm_domain.introspection_enabled = 0;
+ }
+ }
+ break;
+
+ default:
+ rc = -ENOSYS;
+ break;
+ }
+ }
+ break;
+#endif
+
+#ifdef HAS_MEM_SHARING
+ case XEN_DOMCTL_VM_EVENT_OP_SHARING:
+ {
+ struct vm_event_domain *ved = &d->vm_event->share;
+ rc = -EINVAL;
+
+ switch( vec->op )
+ {
+ case XEN_DOMCTL_VM_EVENT_OP_SHARING_ENABLE:
+ {
+ rc = -EOPNOTSUPP;
+ /* pvh fixme: p2m_is_foreign types need addressing */
+ if ( is_pvh_vcpu(current) || is_pvh_domain(hardware_domain) )
+ break;
+
+ rc = -ENODEV;
+ /* Only HAP is supported */
+ if ( !hap_enabled(d) )
+ break;
+
+ rc = vm_event_enable(d, vec, ved, _VPF_mem_sharing,
+ HVM_PARAM_SHARING_RING_PFN,
+ mem_sharing_notification);
+ }
+ break;
+
+ case XEN_DOMCTL_VM_EVENT_OP_SHARING_DISABLE:
+ {
+ if ( ved->ring_page )
+ rc = vm_event_disable(d, ved);
+ }
+ break;
+
+ default:
+ rc = -ENOSYS;
+ break;
+ }
+ }
+ break;
+#endif
+
+ default:
+ rc = -ENOSYS;
+ }
+
+ return rc;
+}
+
+void vm_event_vcpu_pause(struct vcpu *v)
+{
+ ASSERT(v == current);
+
+ atomic_inc(&v->vm_event_pause_count);
+ vcpu_pause_nosync(v);
+}
+
+void vm_event_vcpu_unpause(struct vcpu *v)
+{
+ int old, new, prev = v->vm_event_pause_count.counter;
+
+ /* All unpause requests as a result of toolstack responses. Prevent
+ * underflow of the vcpu pause count. */
+ do
+ {
+ old = prev;
+ new = old - 1;
+
+ if ( new < 0 )
+ {
+ printk(XENLOG_G_WARNING
+ "%pv vm_event: Too many unpause attempts\n", v);
+ return;
+ }
+
+ prev = cmpxchg(&v->vm_event_pause_count.counter, old, new);
+ } while ( prev != old );
+
+ vcpu_unpause(v);
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 78c6977..964384b 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -1346,7 +1346,7 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn)
* enabled for this domain */
if ( unlikely(!need_iommu(d) &&
(d->arch.hvm_domain.mem_sharing_enabled ||
- d->mem_event->paging.ring_page ||
+ d->vm_event->paging.ring_page ||
p2m_get_hostp2m(d)->global_logdirty)) )
return -EXDEV;
diff --git a/xen/include/Makefile b/xen/include/Makefile
index 530db83..537a1f5 100644
--- a/xen/include/Makefile
+++ b/xen/include/Makefile
@@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
all: headers.chk
-headers.chk: $(filter-out public/arch-% public/%ctl.h public/mem_event.h public/xsm/% public/%hvm/save.h, $(wildcard public/*.h public/*/*.h) $(public-y)) Makefile
+headers.chk: $(filter-out public/arch-% public/%ctl.h public/vm_event.h public/xsm/% public/%hvm/save.h, $(wildcard public/*.h public/*/*.h) $(public-y)) Makefile
for i in $(filter %.h,$^); do $(CC) -ansi -include stdint.h -Wall -W -Werror -S -o /dev/null -x c $$i || exit 1; echo $$i; done >$@.new
mv $@.new $@
diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
index da36504..e1a72d5 100644
--- a/xen/include/asm-arm/p2m.h
+++ b/xen/include/asm-arm/p2m.h
@@ -45,7 +45,7 @@ struct p2m_domain {
unsigned long shattered[4];
} stats;
- /* If true, and an access fault comes in and there is no mem_event listener,
+ /* If true, and an access fault comes in and there is no vm_event listener,
* pause domain. Otherwise, remove access restrictions. */
bool_t access_required;
};
@@ -71,8 +71,8 @@ typedef enum {
} p2m_type_t;
static inline
-void p2m_mem_event_emulate_check(struct vcpu *v,
- const mem_event_response_t *rsp)
+void p2m_mem_access_emulate_check(struct vcpu *v,
+ const vm_event_response_t *rsp)
{
/* Not supported on ARM. */
};
diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h
index 6a77a93..20ede1e 100644
--- a/xen/include/asm-x86/domain.h
+++ b/xen/include/asm-x86/domain.h
@@ -478,13 +478,13 @@ struct arch_vcpu
/*
* Should we emulate the next matching instruction on VCPU resume
- * after a mem_event?
+ * after a vm_event?
*/
struct {
uint32_t emulate_flags;
unsigned long gpa;
unsigned long eip;
- } mem_event;
+ } vm_event;
} __cacheline_aligned;
diff --git a/xen/include/asm-x86/hvm/emulate.h b/xen/include/asm-x86/hvm/emulate.h
index 5411302..b3971c8 100644
--- a/xen/include/asm-x86/hvm/emulate.h
+++ b/xen/include/asm-x86/hvm/emulate.h
@@ -38,7 +38,7 @@ int hvm_emulate_one(
struct hvm_emulate_ctxt *hvmemul_ctxt);
int hvm_emulate_one_no_write(
struct hvm_emulate_ctxt *hvmemul_ctxt);
-void hvm_mem_event_emulate_one(bool_t nowrite,
+void hvm_mem_access_emulate_one(bool_t nowrite,
unsigned int trapnr,
unsigned int errcode);
void hvm_emulate_prepare(
diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h
index 5f7fe71..2ee863b 100644
--- a/xen/include/asm-x86/p2m.h
+++ b/xen/include/asm-x86/p2m.h
@@ -238,7 +238,7 @@ struct p2m_domain {
* retyped get this access type. See definition of p2m_access_t. */
p2m_access_t default_access;
- /* If true, and an access fault comes in and there is no mem_event listener,
+ /* If true, and an access fault comes in and there is no vm_event listener,
* pause domain. Otherwise, remove access restrictions. */
bool_t access_required;
@@ -572,7 +572,7 @@ void p2m_mem_paging_resume(struct domain *d);
* locks -- caller must also xfree the request. */
bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
struct npfec npfec,
- mem_event_request_t **req_ptr);
+ vm_event_request_t **req_ptr);
/* Set access type for a region of pfns.
* If start_pfn == -1ul, sets the default access type */
@@ -586,22 +586,16 @@ int p2m_get_mem_access(struct domain *d, unsigned long pfn,
/* Check for emulation and mark vcpu for skipping one instruction
* upon rescheduling if required. */
-void p2m_mem_event_emulate_check(struct vcpu *v,
- const mem_event_response_t *rsp);
+void p2m_mem_access_emulate_check(struct vcpu *v,
+ const vm_event_response_t *rsp);
/* Enable arch specific introspection options (such as MSR interception). */
void p2m_setup_introspection(struct domain *d);
-/* Sanity check for mem_event hardware support */
-static inline bool_t p2m_mem_event_sanity_check(struct domain *d)
-{
- return hap_enabled(d) && cpu_has_vmx;
-}
-
/* Sanity check for mem_access hardware support */
static inline bool_t p2m_mem_access_sanity_check(struct domain *d)
{
- return is_hvm_domain(d);
+ return hap_enabled(d) && cpu_has_vmx && is_hvm_domain(d);
}
/*
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 0e3aaf1..1d4b241 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -753,7 +753,7 @@ struct xen_domctl_gdbsx_domstatus {
* Memory event operations
*/
-/* XEN_DOMCTL_mem_event_op */
+/* XEN_DOMCTL_vm_event_op */
/*
* Domain memory paging
@@ -762,17 +762,17 @@ struct xen_domctl_gdbsx_domstatus {
* pager<->hypervisor interface. Use XENMEM_paging_op*
* to perform per-page operations.
*
- * The XEN_DOMCTL_MEM_EVENT_OP_PAGING_ENABLE domctl returns several
+ * The XEN_DOMCTL_VM_EVENT_OP_PAGING_ENABLE domctl returns several
* non-standard error codes to indicate why paging could not be enabled:
* ENODEV - host lacks HAP support (EPT/NPT) or HAP is disabled in guest
* EMLINK - guest has iommu passthrough enabled
* EXDEV - guest has PoD enabled
* EBUSY - guest has or had paging enabled, ring buffer still active
*/
-#define XEN_DOMCTL_MEM_EVENT_OP_PAGING 1
+#define XEN_DOMCTL_VM_EVENT_OP_PAGING 1
-#define XEN_DOMCTL_MEM_EVENT_OP_PAGING_ENABLE 0
-#define XEN_DOMCTL_MEM_EVENT_OP_PAGING_DISABLE 1
+#define XEN_DOMCTL_VM_EVENT_OP_PAGING_ENABLE 0
+#define XEN_DOMCTL_VM_EVENT_OP_PAGING_DISABLE 1
/*
* Monitor permissions.
@@ -783,21 +783,21 @@ struct xen_domctl_gdbsx_domstatus {
* There are HVM hypercalls to set the per-page access permissions of every
* page in a domain. When one of these permissions--independent, read,
* write, and execute--is violated, the VCPU is paused and a memory event
- * is sent with what happened. (See public/mem_event.h) .
+ * is sent with what happened. (See public/vm_event.h) .
*
* The memory event handler can then resume the VCPU and redo the access
* with a XENMEM_access_op_resume hypercall.
*
- * The XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE domctl returns several
+ * The XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE domctl returns several
* non-standard error codes to indicate why access could not be enabled:
* ENODEV - host lacks HAP support (EPT/NPT) or HAP is disabled in guest
* EBUSY - guest has or had access enabled, ring buffer still active
*/
-#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR 2
+#define XEN_DOMCTL_VM_EVENT_OP_MONITOR 2
-#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE 0
-#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_DISABLE 1
-#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION 2
+#define XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE 0
+#define XEN_DOMCTL_VM_EVENT_OP_MONITOR_DISABLE 1
+#define XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION 2
/*
* Sharing ENOMEM helper.
@@ -812,21 +812,21 @@ struct xen_domctl_gdbsx_domstatus {
* Note that shring can be turned on (as per the domctl below)
* *without* this ring being setup.
*/
-#define XEN_DOMCTL_MEM_EVENT_OP_SHARING 3
+#define XEN_DOMCTL_VM_EVENT_OP_SHARING 3
-#define XEN_DOMCTL_MEM_EVENT_OP_SHARING_ENABLE 0
-#define XEN_DOMCTL_MEM_EVENT_OP_SHARING_DISABLE 1
+#define XEN_DOMCTL_VM_EVENT_OP_SHARING_ENABLE 0
+#define XEN_DOMCTL_VM_EVENT_OP_SHARING_DISABLE 1
/* Use for teardown/setup of helper<->hypervisor interface for paging,
* access and sharing.*/
-struct xen_domctl_mem_event_op {
- uint32_t op; /* XEN_DOMCTL_MEM_EVENT_OP_*_* */
- uint32_t mode; /* XEN_DOMCTL_MEM_EVENT_OP_* */
+struct xen_domctl_vm_event_op {
+ uint32_t op; /* XEN_DOMCTL_VM_EVENT_OP_*_* */
+ uint32_t mode; /* XEN_DOMCTL_VM_EVENT_OP_* */
uint32_t port; /* OUT: event channel for ring */
};
-typedef struct xen_domctl_mem_event_op xen_domctl_mem_event_op_t;
-DEFINE_XEN_GUEST_HANDLE(xen_domctl_mem_event_op_t);
+typedef struct xen_domctl_vm_event_op xen_domctl_vm_event_op_t;
+DEFINE_XEN_GUEST_HANDLE(xen_domctl_vm_event_op_t);
/*
* Memory sharing operations
@@ -1049,7 +1049,7 @@ struct xen_domctl {
#define XEN_DOMCTL_suppress_spurious_page_faults 53
#define XEN_DOMCTL_debug_op 54
#define XEN_DOMCTL_gethvmcontext_partial 55
-#define XEN_DOMCTL_mem_event_op 56
+#define XEN_DOMCTL_vm_event_op 56
#define XEN_DOMCTL_mem_sharing_op 57
#define XEN_DOMCTL_disable_migrate 58
#define XEN_DOMCTL_gettscinfo 59
@@ -1117,7 +1117,7 @@ struct xen_domctl {
struct xen_domctl_set_target set_target;
struct xen_domctl_subscribe subscribe;
struct xen_domctl_debug_op debug_op;
- struct xen_domctl_mem_event_op mem_event_op;
+ struct xen_domctl_vm_event_op vm_event_op;
struct xen_domctl_mem_sharing_op mem_sharing_op;
#if defined(__i386__) || defined(__x86_64__)
struct xen_domctl_cpuid cpuid;
diff --git a/xen/include/public/mem_event.h b/xen/include/public/mem_event.h
deleted file mode 100644
index dbcc48b..0000000
--- a/xen/include/public/mem_event.h
+++ /dev/null
@@ -1,197 +0,0 @@
-/******************************************************************************
- * mem_event.h
- *
- * Memory event common structures.
- *
- * Copyright (c) 2009 by Citrix Systems, Inc. (Patrick Colp)
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- */
-
-#ifndef _XEN_PUBLIC_MEM_EVENT_H
-#define _XEN_PUBLIC_MEM_EVENT_H
-
-#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
-#error "vm event operations are intended for use only by Xen or node control tools"
-#endif
-
-#include "xen.h"
-#include "io/ring.h"
-
-#define MEM_EVENT_INTERFACE_VERSION 0x00000001
-
-/* Memory event flags */
-#define MEM_EVENT_FLAG_VCPU_PAUSED (1 << 0)
-#define MEM_EVENT_FLAG_DROP_PAGE (1 << 1)
-#define MEM_EVENT_FLAG_EVICT_FAIL (1 << 2)
-#define MEM_EVENT_FLAG_FOREIGN (1 << 3)
-#define MEM_EVENT_FLAG_DUMMY (1 << 4)
-/*
- * Emulate the fault-causing instruction (if set in the event response flags).
- * This will allow the guest to continue execution without lifting the page
- * access restrictions.
- */
-#define MEM_EVENT_FLAG_EMULATE (1 << 5)
-/*
- * Same as MEM_EVENT_FLAG_EMULATE, but with write operations or operations
- * potentially having side effects (like memory mapped or port I/O) disabled.
- */
-#define MEM_EVENT_FLAG_EMULATE_NOWRITE (1 << 6)
-
-/* Reasons for the vm event request */
-/* Default case */
-#define MEM_EVENT_REASON_UNKNOWN 0
-/* Memory access violation */
-#define MEM_EVENT_REASON_MEM_ACCESS_VIOLATION 1
-/* Memory sharing event */
-#define MEM_EVENT_REASON_MEM_SHARING 2
-/* Memory paging event */
-#define MEM_EVENT_REASON_MEM_PAGING 3
-/* CR0 was updated */
-#define MEM_EVENT_REASON_CR0 4
-/* CR3 was updated */
-#define MEM_EVENT_REASON_CR3 5
-/* CR4 was updated */
-#define MEM_EVENT_REASON_CR4 6
-/* Debug operation executed (int3) */
-#define MEM_EVENT_REASON_INT3 7
-/* Single-step (MTF) */
-#define MEM_EVENT_REASON_SINGLESTEP 8
-/* An MSR was updated. Does NOT honour HVMPME_onchangeonly */
-#define MEM_EVENT_REASON_MSR 9
-
-/* Using a custom struct (not hvm_hw_cpu) so as to not fill
- * the mem_event ring buffer too quickly. */
-struct mem_event_regs_x86 {
- uint64_t rax;
- uint64_t rcx;
- uint64_t rdx;
- uint64_t rbx;
- uint64_t rsp;
- uint64_t rbp;
- uint64_t rsi;
- uint64_t rdi;
- uint64_t r8;
- uint64_t r9;
- uint64_t r10;
- uint64_t r11;
- uint64_t r12;
- uint64_t r13;
- uint64_t r14;
- uint64_t r15;
- uint64_t rflags;
- uint64_t dr7;
- uint64_t rip;
- uint64_t cr0;
- uint64_t cr2;
- uint64_t cr3;
- uint64_t cr4;
- uint64_t sysenter_cs;
- uint64_t sysenter_esp;
- uint64_t sysenter_eip;
- uint64_t msr_efer;
- uint64_t msr_star;
- uint64_t msr_lstar;
- uint64_t fs_base;
- uint64_t gs_base;
- uint32_t cs_arbytes;
- uint32_t _pad;
-};
-
-struct mem_event_regs {
- union {
- struct mem_event_regs_x86 x86;
- };
-};
-
-struct mem_event_mem_access_data {
- uint64_t gfn;
- uint64_t offset;
- uint64_t gla; /* if gla_valid */
- uint16_t access_r:1;
- uint16_t access_w:1;
- uint16_t access_x:1;
- uint16_t gla_valid:1;
- uint16_t fault_with_gla:1;
- uint16_t fault_in_gpt:1;
- uint16_t available:10;
-};
-
-struct mem_event_cr_data {
- uint64_t new_value;
- uint64_t old_value;
-};
-
-struct mem_event_int3_data {
- uint64_t gfn;
- uint64_t gla;
-};
-
-struct mem_event_singlestep_data {
- uint64_t gfn;
- uint64_t gla;
-};
-
-struct mem_event_msr_data {
- uint64_t msr;
- uint64_t old_value;
- uint64_t new_value;
-};
-
-struct mem_event_paging_data {
- uint64_t gfn;
- uint32_t p2mt;
-};
-
-struct mem_event_sharing_data {
- uint64_t gfn;
- uint32_t p2mt;
-};
-
-typedef struct mem_event_st {
- uint32_t flags;
- uint32_t vcpu_id;
- uint32_t reason;
-
- union {
- struct mem_event_paging_data mem_paging_event;
- struct mem_event_sharing_data mem_sharing_event;
- struct mem_event_mem_access_data mem_access_event;
- struct mem_event_cr_data cr_event;
- struct mem_event_int3_data int3_event;
- struct mem_event_singlestep_data singlestep_event;
- struct mem_event_msr_data msr_event;
- };
-
- struct mem_event_regs regs;
-} mem_event_request_t, mem_event_response_t;
-
-DEFINE_RING_TYPES(mem_event, mem_event_request_t, mem_event_response_t);
-
-#endif
-
-/*
- * Local variables:
- * mode: C
- * c-file-style: "BSD"
- * c-basic-offset: 4
- * tab-width: 4
- * indent-tabs-mode: nil
- * End:
- */
diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
new file mode 100644
index 0000000..287c3fc
--- /dev/null
+++ b/xen/include/public/vm_event.h
@@ -0,0 +1,197 @@
+/******************************************************************************
+ * vm_event.h
+ *
+ * VM event common structures.
+ *
+ * Copyright (c) 2009 by Citrix Systems, Inc. (Patrick Colp)
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#ifndef _XEN_PUBLIC_VM_EVENT_H
+#define _XEN_PUBLIC_VM_EVENT_H
+
+#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
+#error "vm event operations are intended for use only by Xen or node control tools"
+#endif
+
+#include "xen.h"
+#include "io/ring.h"
+
+#define MEM_EVENT_INTERFACE_VERSION 0x00000001
+
+/* Memory event flags */
+#define VM_EVENT_FLAG_VCPU_PAUSED (1 << 0)
+#define VM_EVENT_FLAG_DROP_PAGE (1 << 1)
+#define VM_EVENT_FLAG_EVICT_FAIL (1 << 2)
+#define VM_EVENT_FLAG_FOREIGN (1 << 3)
+#define VM_EVENT_FLAG_DUMMY (1 << 4)
+/*
+ * Emulate the fault-causing instruction (if set in the event response flags).
+ * This will allow the guest to continue execution without lifting the page
+ * access restrictions.
+ */
+#define VM_EVENT_FLAG_EMULATE (1 << 5)
+/*
+ * Same as VM_EVENT_FLAG_EMULATE, but with write operations or operations
+ * potentially having side effects (like memory mapped or port I/O) disabled.
+ */
+#define VM_EVENT_FLAG_EMULATE_NOWRITE (1 << 6)
+
+/* Reasons for the vm event request */
+/* Default case */
+#define VM_EVENT_REASON_UNKNOWN 0
+/* Memory access violation */
+#define VM_EVENT_REASON_MEM_ACCESS_VIOLATION 1
+/* Memory sharing event */
+#define VM_EVENT_REASON_MEM_SHARING 2
+/* Memory paging event */
+#define VM_EVENT_REASON_MEM_PAGING 3
+/* CR0 was updated */
+#define VM_EVENT_REASON_CR0 4
+/* CR3 was updated */
+#define VM_EVENT_REASON_CR3 5
+/* CR4 was updated */
+#define VM_EVENT_REASON_CR4 6
+/* Debug operation executed (int3) */
+#define VM_EVENT_REASON_INT3 7
+/* Single-step (MTF) */
+#define VM_EVENT_REASON_SINGLESTEP 8
+/* An MSR was updated. Does NOT honour HVMPME_onchangeonly */
+#define VM_EVENT_REASON_MSR 9
+
+/* Using a custom struct (not hvm_hw_cpu) so as to not fill
+ * the vm_event ring buffer too quickly. */
+struct vm_event_regs_x86 {
+ uint64_t rax;
+ uint64_t rcx;
+ uint64_t rdx;
+ uint64_t rbx;
+ uint64_t rsp;
+ uint64_t rbp;
+ uint64_t rsi;
+ uint64_t rdi;
+ uint64_t r8;
+ uint64_t r9;
+ uint64_t r10;
+ uint64_t r11;
+ uint64_t r12;
+ uint64_t r13;
+ uint64_t r14;
+ uint64_t r15;
+ uint64_t rflags;
+ uint64_t dr7;
+ uint64_t rip;
+ uint64_t cr0;
+ uint64_t cr2;
+ uint64_t cr3;
+ uint64_t cr4;
+ uint64_t sysenter_cs;
+ uint64_t sysenter_esp;
+ uint64_t sysenter_eip;
+ uint64_t msr_efer;
+ uint64_t msr_star;
+ uint64_t msr_lstar;
+ uint64_t fs_base;
+ uint64_t gs_base;
+ uint32_t cs_arbytes;
+ uint32_t _pad;
+};
+
+struct vm_event_regs {
+ union {
+ struct vm_event_regs_x86 x86;
+ };
+};
+
+struct vm_event_mem_access_data {
+ uint64_t gfn;
+ uint64_t offset;
+ uint64_t gla; /* if gla_valid */
+ uint16_t access_r:1;
+ uint16_t access_w:1;
+ uint16_t access_x:1;
+ uint16_t gla_valid:1;
+ uint16_t fault_with_gla:1;
+ uint16_t fault_in_gpt:1;
+ uint16_t available:10;
+};
+
+struct vm_event_cr_data {
+ uint64_t new_value;
+ uint64_t old_value;
+};
+
+struct vm_event_int3_data {
+ uint64_t gfn;
+ uint64_t gla;
+};
+
+struct vm_event_singlestep_data {
+ uint64_t gfn;
+ uint64_t gla;
+};
+
+struct vm_event_msr_data {
+ uint64_t msr;
+ uint64_t old_value;
+ uint64_t new_value;
+};
+
+struct vm_event_paging_data {
+ uint64_t gfn;
+ uint32_t p2mt;
+};
+
+struct vm_event_sharing_data {
+ uint64_t gfn;
+ uint32_t p2mt;
+};
+
+typedef struct vm_event_st {
+ uint32_t flags;
+ uint32_t vcpu_id;
+ uint32_t reason;
+
+ union {
+ struct vm_event_paging_data mem_paging_event;
+ struct vm_event_sharing_data mem_sharing_event;
+ struct vm_event_mem_access_data mem_access_event;
+ struct vm_event_cr_data cr_event;
+ struct vm_event_int3_data int3_event;
+ struct vm_event_singlestep_data singlestep_event;
+ struct vm_event_msr_data msr_event;
+ };
+
+ struct vm_event_regs regs;
+} vm_event_request_t, vm_event_response_t;
+
+DEFINE_RING_TYPES(vm_event, vm_event_request_t, vm_event_response_t);
+
+#endif
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/xen/mem_access.h b/xen/include/xen/mem_access.h
index 6ceb2a4..1d01221 100644
--- a/xen/include/xen/mem_access.h
+++ b/xen/include/xen/mem_access.h
@@ -29,7 +29,7 @@
int mem_access_memop(unsigned long cmd,
XEN_GUEST_HANDLE_PARAM(xen_mem_access_op_t) arg);
-int mem_access_send_req(struct domain *d, mem_event_request_t *req);
+int mem_access_send_req(struct domain *d, vm_event_request_t *req);
/* Resumes the running of the VCPU, restarting the last instruction */
void mem_access_resume(struct domain *d);
@@ -44,7 +44,7 @@ int mem_access_memop(unsigned long cmd,
}
static inline
-int mem_access_send_req(struct domain *d, mem_event_request_t *req)
+int mem_access_send_req(struct domain *d, vm_event_request_t *req)
{
return -ENOSYS;
}
diff --git a/xen/include/xen/mem_event.h b/xen/include/xen/mem_event.h
deleted file mode 100644
index 4f3ad8e..0000000
--- a/xen/include/xen/mem_event.h
+++ /dev/null
@@ -1,143 +0,0 @@
-/******************************************************************************
- * mem_event.h
- *
- * Common interface for memory event support.
- *
- * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp)
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- */
-
-
-#ifndef __MEM_EVENT_H__
-#define __MEM_EVENT_H__
-
-#include <xen/sched.h>
-
-#ifdef HAS_MEM_ACCESS
-
-/* Clean up on domain destruction */
-void mem_event_cleanup(struct domain *d);
-
-/* Returns whether a ring has been set up */
-bool_t mem_event_check_ring(struct mem_event_domain *med);
-
-/* Returns 0 on success, -ENOSYS if there is no ring, -EBUSY if there is no
- * available space and the caller is a foreign domain. If the guest itself
- * is the caller, -EBUSY is avoided by sleeping on a wait queue to ensure
- * that the ring does not lose future events.
- *
- * However, the allow_sleep flag can be set to false in cases in which it is ok
- * to lose future events, and thus -EBUSY can be returned to guest vcpus
- * (handle with care!).
- *
- * In general, you must follow a claim_slot() call with either put_request() or
- * cancel_slot(), both of which are guaranteed to
- * succeed.
- */
-int __mem_event_claim_slot(struct domain *d, struct mem_event_domain *med,
- bool_t allow_sleep);
-static inline int mem_event_claim_slot(struct domain *d,
- struct mem_event_domain *med)
-{
- return __mem_event_claim_slot(d, med, 1);
-}
-
-static inline int mem_event_claim_slot_nosleep(struct domain *d,
- struct mem_event_domain *med)
-{
- return __mem_event_claim_slot(d, med, 0);
-}
-
-void mem_event_cancel_slot(struct domain *d, struct mem_event_domain *med);
-
-void mem_event_put_request(struct domain *d, struct mem_event_domain *med,
- mem_event_request_t *req);
-
-int mem_event_get_response(struct domain *d, struct mem_event_domain *med,
- mem_event_response_t *rsp);
-
-int do_mem_event_op(int op, uint32_t domain, void *arg);
-int mem_event_domctl(struct domain *d, xen_domctl_mem_event_op_t *mec,
- XEN_GUEST_HANDLE_PARAM(void) u_domctl);
-
-void mem_event_vcpu_pause(struct vcpu *v);
-void mem_event_vcpu_unpause(struct vcpu *v);
-
-#else
-
-static inline void mem_event_cleanup(struct domain *d) {}
-
-static inline bool_t mem_event_check_ring(struct mem_event_domain *med)
-{
- return 0;
-}
-
-static inline int mem_event_claim_slot(struct domain *d,
- struct mem_event_domain *med)
-{
- return -ENOSYS;
-}
-
-static inline int mem_event_claim_slot_nosleep(struct domain *d,
- struct mem_event_domain *med)
-{
- return -ENOSYS;
-}
-
-static inline
-void mem_event_cancel_slot(struct domain *d, struct mem_event_domain *med)
-{}
-
-static inline
-void mem_event_put_request(struct domain *d, struct mem_event_domain *med,
- mem_event_request_t *req)
-{}
-
-static inline
-int mem_event_get_response(struct domain *d, struct mem_event_domain *med,
- mem_event_response_t *rsp)
-{
- return -ENOSYS;
-}
-
-static inline int do_mem_event_op(int op, uint32_t domain, void *arg)
-{
- return -ENOSYS;
-}
-
-static inline
-int mem_event_domctl(struct domain *d, xen_domctl_mem_event_op_t *mec,
- XEN_GUEST_HANDLE_PARAM(void) u_domctl)
-{
- return -ENOSYS;
-}
-
-static inline void mem_event_vcpu_pause(struct vcpu *v) {}
-static inline void mem_event_vcpu_unpause(struct vcpu *v) {}
-
-#endif /* HAS_MEM_ACCESS */
-
-#endif /* __MEM_EVENT_H__ */
-
-
-/*
- * Local variables:
- * mode: C
- * c-file-style: "BSD"
- * c-basic-offset: 4
- * indent-tabs-mode: nil
- * End:
- */
diff --git a/xen/include/xen/p2m-common.h b/xen/include/xen/p2m-common.h
index 29f3628..5da8a2d 100644
--- a/xen/include/xen/p2m-common.h
+++ b/xen/include/xen/p2m-common.h
@@ -1,12 +1,12 @@
#ifndef _XEN_P2M_COMMON_H
#define _XEN_P2M_COMMON_H
-#include <public/mem_event.h>
+#include <public/vm_event.h>
/*
* Additional access types, which are used to further restrict
* the permissions given my the p2m_type_t memory type. Violations
- * caused by p2m_access_t restrictions are sent to the mem_event
+ * caused by p2m_access_t restrictions are sent to the vm_event
* interface.
*
* The access permissions are soft state: when any ambiguous change of page
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 2fc36ea..14fae4a 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -23,7 +23,7 @@
#include <public/domctl.h>
#include <public/sysctl.h>
#include <public/vcpu.h>
-#include <public/mem_event.h>
+#include <public/vm_event.h>
#include <public/event_channel.h>
#ifdef CONFIG_COMPAT
@@ -214,8 +214,8 @@ struct vcpu
unsigned long pause_flags;
atomic_t pause_count;
- /* VCPU paused for mem_event replies. */
- atomic_t mem_event_pause_count;
+ /* VCPU paused for vm_event replies. */
+ atomic_t vm_event_pause_count;
/* VCPU paused by system controller. */
int controller_pause_count;
@@ -258,7 +258,7 @@ struct vcpu
#define domain_is_locked(d) spin_is_locked(&(d)->domain_lock)
/* Memory event */
-struct mem_event_domain
+struct vm_event_domain
{
/* ring lock */
spinlock_t ring_lock;
@@ -269,10 +269,10 @@ struct mem_event_domain
void *ring_page;
struct page_info *ring_pg_struct;
/* front-end ring */
- mem_event_front_ring_t front_ring;
+ vm_event_front_ring_t front_ring;
/* event channel port (vcpu0 only) */
int xen_port;
- /* mem_event bit for vcpu->pause_flags */
+ /* vm_event bit for vcpu->pause_flags */
int pause_flag;
/* list of vcpus waiting for room in the ring */
struct waitqueue_head wq;
@@ -282,14 +282,14 @@ struct mem_event_domain
unsigned int last_vcpu_wake_up;
};
-struct mem_event_per_domain
+struct vm_event_per_domain
{
/* Memory sharing support */
- struct mem_event_domain share;
+ struct vm_event_domain share;
/* Memory paging support */
- struct mem_event_domain paging;
- /* VM event monitor support */
- struct mem_event_domain monitor;
+ struct vm_event_domain paging;
+ /* Memory access support */
+ struct vm_event_domain monitor;
};
struct evtchn_port_ops;
@@ -442,8 +442,8 @@ struct domain
/* Non-migratable and non-restoreable? */
bool_t disable_migrate;
- /* Various mem_events */
- struct mem_event_per_domain *mem_event;
+ /* Various vm_events */
+ struct vm_event_per_domain *vm_event;
/*
* Can be specified by the user. If that is not the case, it is
diff --git a/xen/include/xen/vm_event.h b/xen/include/xen/vm_event.h
new file mode 100644
index 0000000..988ea42
--- /dev/null
+++ b/xen/include/xen/vm_event.h
@@ -0,0 +1,143 @@
+/******************************************************************************
+ * vm_event.h
+ *
+ * Common interface for memory event support.
+ *
+ * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp)
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+
+#ifndef __VM_EVENT_H__
+#define __VM_EVENT_H__
+
+#include <xen/sched.h>
+
+#ifdef HAS_MEM_ACCESS
+
+/* Clean up on domain destruction */
+void vm_event_cleanup(struct domain *d);
+
+/* Returns whether a ring has been set up */
+bool_t vm_event_check_ring(struct vm_event_domain *med);
+
+/* Returns 0 on success, -ENOSYS if there is no ring, -EBUSY if there is no
+ * available space and the caller is a foreign domain. If the guest itself
+ * is the caller, -EBUSY is avoided by sleeping on a wait queue to ensure
+ * that the ring does not lose future events.
+ *
+ * However, the allow_sleep flag can be set to false in cases in which it is ok
+ * to lose future events, and thus -EBUSY can be returned to guest vcpus
+ * (handle with care!).
+ *
+ * In general, you must follow a claim_slot() call with either put_request() or
+ * cancel_slot(), both of which are guaranteed to
+ * succeed.
+ */
+int __vm_event_claim_slot(struct domain *d, struct vm_event_domain *med,
+ bool_t allow_sleep);
+static inline int vm_event_claim_slot(struct domain *d,
+ struct vm_event_domain *med)
+{
+ return __vm_event_claim_slot(d, med, 1);
+}
+
+static inline int vm_event_claim_slot_nosleep(struct domain *d,
+ struct vm_event_domain *med)
+{
+ return __vm_event_claim_slot(d, med, 0);
+}
+
+void vm_event_cancel_slot(struct domain *d, struct vm_event_domain *med);
+
+void vm_event_put_request(struct domain *d, struct vm_event_domain *med,
+ vm_event_request_t *req);
+
+int vm_event_get_response(struct domain *d, struct vm_event_domain *med,
+ vm_event_response_t *rsp);
+
+int do_vm_event_op(int op, uint32_t domain, void *arg);
+int vm_event_domctl(struct domain *d, xen_domctl_vm_event_op_t *mec,
+ XEN_GUEST_HANDLE_PARAM(void) u_domctl);
+
+void vm_event_vcpu_pause(struct vcpu *v);
+void vm_event_vcpu_unpause(struct vcpu *v);
+
+#else
+
+static inline void vm_event_cleanup(struct domain *d) {}
+
+static inline bool_t vm_event_check_ring(struct vm_event_domain *med)
+{
+ return 0;
+}
+
+static inline int vm_event_claim_slot(struct domain *d,
+ struct vm_event_domain *med)
+{
+ return -ENOSYS;
+}
+
+static inline int vm_event_claim_slot_nosleep(struct domain *d,
+ struct vm_event_domain *med)
+{
+ return -ENOSYS;
+}
+
+static inline
+void vm_event_cancel_slot(struct domain *d, struct vm_event_domain *med)
+{}
+
+static inline
+void vm_event_put_request(struct domain *d, struct vm_event_domain *med,
+ vm_event_request_t *req)
+{}
+
+static inline
+int vm_event_get_response(struct domain *d, struct vm_event_domain *med,
+ vm_event_response_t *rsp)
+{
+ return -ENOSYS;
+}
+
+static inline int do_vm_event_op(int op, uint32_t domain, void *arg)
+{
+ return -ENOSYS;
+}
+
+static inline
+int vm_event_domctl(struct domain *d, xen_domctl_vm_event_op_t *mec,
+ XEN_GUEST_HANDLE_PARAM(void) u_domctl)
+{
+ return -ENOSYS;
+}
+
+static inline void vm_event_vcpu_pause(struct vcpu *v) {}
+static inline void vm_event_vcpu_unpause(struct vcpu *v) {}
+
+#endif /* HAS_MEM_ACCESS */
+
+#endif /* __VM_EVENT_H__ */
+
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
index f20e89c..4227093 100644
--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -514,13 +514,13 @@ static XSM_INLINE int xsm_hvm_param_nested(XSM_DEFAULT_ARG struct domain *d)
}
#ifdef HAS_MEM_ACCESS
-static XSM_INLINE int xsm_mem_event_control(XSM_DEFAULT_ARG struct domain *d, int mode, int op)
+static XSM_INLINE int xsm_vm_event_control(XSM_DEFAULT_ARG struct domain *d, int mode, int op)
{
XSM_ASSERT_ACTION(XSM_PRIV);
return xsm_default_action(action, current->domain, d);
}
-static XSM_INLINE int xsm_mem_event_op(XSM_DEFAULT_ARG struct domain *d, int op)
+static XSM_INLINE int xsm_vm_event_op(XSM_DEFAULT_ARG struct domain *d, int op)
{
XSM_ASSERT_ACTION(XSM_DM_PRIV);
return xsm_default_action(action, current->domain, d);
diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
index 4ce089f..cff9d35 100644
--- a/xen/include/xsm/xsm.h
+++ b/xen/include/xsm/xsm.h
@@ -142,8 +142,8 @@ struct xsm_operations {
int (*get_vnumainfo) (struct domain *d);
#ifdef HAS_MEM_ACCESS
- int (*mem_event_control) (struct domain *d, int mode, int op);
- int (*mem_event_op) (struct domain *d, int op);
+ int (*vm_event_control) (struct domain *d, int mode, int op);
+ int (*vm_event_op) (struct domain *d, int op);
#endif
#ifdef CONFIG_X86
@@ -544,14 +544,14 @@ static inline int xsm_get_vnumainfo (xsm_default_t def, struct domain *d)
}
#ifdef HAS_MEM_ACCESS
-static inline int xsm_mem_event_control (xsm_default_t def, struct domain *d, int mode, int op)
+static inline int xsm_vm_event_control (xsm_default_t def, struct domain *d, int mode, int op)
{
- return xsm_ops->mem_event_control(d, mode, op);
+ return xsm_ops->vm_event_control(d, mode, op);
}
-static inline int xsm_mem_event_op (xsm_default_t def, struct domain *d, int op)
+static inline int xsm_vm_event_op (xsm_default_t def, struct domain *d, int op)
{
- return xsm_ops->mem_event_op(d, op);
+ return xsm_ops->vm_event_op(d, op);
}
#endif
diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
index 8eb3050..25fca68 100644
--- a/xen/xsm/dummy.c
+++ b/xen/xsm/dummy.c
@@ -119,8 +119,8 @@ void xsm_fixup_ops (struct xsm_operations *ops)
set_to_dummy_if_null(ops, map_gmfn_foreign);
#ifdef HAS_MEM_ACCESS
- set_to_dummy_if_null(ops, mem_event_control);
- set_to_dummy_if_null(ops, mem_event_op);
+ set_to_dummy_if_null(ops, vm_event_control);
+ set_to_dummy_if_null(ops, vm_event_op);
#endif
#ifdef CONFIG_X86
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index d48463f..c419543 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -578,7 +578,7 @@ static int flask_domctl(struct domain *d, int cmd)
case XEN_DOMCTL_memory_mapping:
case XEN_DOMCTL_set_target:
#ifdef HAS_MEM_ACCESS
- case XEN_DOMCTL_mem_event_op:
+ case XEN_DOMCTL_vm_event_op:
#endif
#ifdef CONFIG_X86
/* These have individual XSM hooks (arch/x86/domctl.c) */
@@ -689,7 +689,7 @@ static int flask_domctl(struct domain *d, int cmd)
return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__TRIGGER);
case XEN_DOMCTL_set_access_required:
- return current_has_perm(d, SECCLASS_HVM, HVM__MEM_EVENT);
+ return current_has_perm(d, SECCLASS_HVM, HVM__VM_EVENT);
case XEN_DOMCTL_debug_op:
case XEN_DOMCTL_gdbsx_guestmemio:
@@ -1203,14 +1203,14 @@ static int flask_deassign_device(struct domain *d, uint32_t machine_bdf)
#endif /* HAS_PASSTHROUGH && HAS_PCI */
#ifdef HAS_MEM_ACCESS
-static int flask_mem_event_control(struct domain *d, int mode, int op)
+static int flask_vm_event_control(struct domain *d, int mode, int op)
{
- return current_has_perm(d, SECCLASS_HVM, HVM__MEM_EVENT);
+ return current_has_perm(d, SECCLASS_HVM, HVM__VM_EVENT);
}
-static int flask_mem_event_op(struct domain *d, int op)
+static int flask_vm_event_op(struct domain *d, int op)
{
- return current_has_perm(d, SECCLASS_HVM, HVM__MEM_EVENT);
+ return current_has_perm(d, SECCLASS_HVM, HVM__VM_EVENT);
}
#endif /* HAS_MEM_ACCESS */
@@ -1597,8 +1597,8 @@ static struct xsm_operations flask_ops = {
#endif
#ifdef HAS_MEM_ACCESS
- .mem_event_control = flask_mem_event_control,
- .mem_event_op = flask_mem_event_op,
+ .vm_event_control = flask_vm_event_control,
+ .vm_event_op = flask_vm_event_op,
#endif
#ifdef CONFIG_X86
diff --git a/xen/xsm/flask/policy/access_vectors b/xen/xsm/flask/policy/access_vectors
index 1da9f63..9da3275 100644
--- a/xen/xsm/flask/policy/access_vectors
+++ b/xen/xsm/flask/policy/access_vectors
@@ -249,7 +249,7 @@ class hvm
# HVMOP_inject_trap
hvmctl
# XEN_DOMCTL_set_access_required
- mem_event
+ vm_event
# XEN_DOMCTL_mem_sharing_op and XENMEM_sharing_op_{share,add_physmap} with:
# source = the domain making the hypercall
# target = domain whose memory is being shared
--
2.1.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [RFC PATCH V2 6/8] xen/vm_event: Decouple vm_event and mem_access.
2015-01-18 15:17 [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Tamas K Lengyel
` (4 preceding siblings ...)
2015-01-18 15:17 ` [RFC PATCH V2 5/8] xen/mem_event: Rename mem_event to vm_event Tamas K Lengyel
@ 2015-01-18 15:17 ` Tamas K Lengyel
2015-01-22 14:56 ` Tim Deegan
2015-01-18 15:18 ` [RFC PATCH V2 7/8] tools/tests: Clean-up tools/tests/xen-access Tamas K Lengyel
` (2 subsequent siblings)
8 siblings, 1 reply; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-18 15:17 UTC (permalink / raw)
To: xen-devel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, tim, ian.jackson, eddie.dong, andres, jbeulich,
Tamas K Lengyel, rshriram, keir, dgdegra, yanghy
The vm_event subsystem has been artifically tied to the presence of mem_access.
While mem_access does depend on vm_event, vm_event is an entirely independent
subsystem that can be used for arbitrary function-offloading to helper apps in
domains. This patch removes the dependency that mem_access needs to be supported
in order to enable vm_event.
Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
---
xen/common/Makefile | 2 +-
xen/include/xen/vm_event.h | 56 ----------------------------------------------
xen/include/xsm/dummy.h | 2 --
xen/include/xsm/xsm.h | 2 --
xen/xsm/dummy.c | 2 --
xen/xsm/flask/hooks.c | 32 +++++++++++---------------
6 files changed, 14 insertions(+), 82 deletions(-)
diff --git a/xen/common/Makefile b/xen/common/Makefile
index f1b73a3..2ccf0bb 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -52,9 +52,9 @@ obj-y += tmem_xen.o
obj-y += radix-tree.o
obj-y += rbtree.o
obj-y += lzo.o
+obj-y += vm_event.o
obj-$(HAS_PDX) += pdx.o
obj-$(HAS_MEM_ACCESS) += mem_access.o
-obj-$(HAS_MEM_ACCESS) += vm_event.o
obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma unlzo unlz4 earlycpio,$(n).init.o)
diff --git a/xen/include/xen/vm_event.h b/xen/include/xen/vm_event.h
index 988ea42..477ef7e 100644
--- a/xen/include/xen/vm_event.h
+++ b/xen/include/xen/vm_event.h
@@ -26,8 +26,6 @@
#include <xen/sched.h>
-#ifdef HAS_MEM_ACCESS
-
/* Clean up on domain destruction */
void vm_event_cleanup(struct domain *d);
@@ -76,60 +74,6 @@ int vm_event_domctl(struct domain *d, xen_domctl_vm_event_op_t *mec,
void vm_event_vcpu_pause(struct vcpu *v);
void vm_event_vcpu_unpause(struct vcpu *v);
-#else
-
-static inline void vm_event_cleanup(struct domain *d) {}
-
-static inline bool_t vm_event_check_ring(struct vm_event_domain *med)
-{
- return 0;
-}
-
-static inline int vm_event_claim_slot(struct domain *d,
- struct vm_event_domain *med)
-{
- return -ENOSYS;
-}
-
-static inline int vm_event_claim_slot_nosleep(struct domain *d,
- struct vm_event_domain *med)
-{
- return -ENOSYS;
-}
-
-static inline
-void vm_event_cancel_slot(struct domain *d, struct vm_event_domain *med)
-{}
-
-static inline
-void vm_event_put_request(struct domain *d, struct vm_event_domain *med,
- vm_event_request_t *req)
-{}
-
-static inline
-int vm_event_get_response(struct domain *d, struct vm_event_domain *med,
- vm_event_response_t *rsp)
-{
- return -ENOSYS;
-}
-
-static inline int do_vm_event_op(int op, uint32_t domain, void *arg)
-{
- return -ENOSYS;
-}
-
-static inline
-int vm_event_domctl(struct domain *d, xen_domctl_vm_event_op_t *mec,
- XEN_GUEST_HANDLE_PARAM(void) u_domctl)
-{
- return -ENOSYS;
-}
-
-static inline void vm_event_vcpu_pause(struct vcpu *v) {}
-static inline void vm_event_vcpu_unpause(struct vcpu *v) {}
-
-#endif /* HAS_MEM_ACCESS */
-
#endif /* __VM_EVENT_H__ */
diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
index 4227093..50ee929 100644
--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -513,7 +513,6 @@ static XSM_INLINE int xsm_hvm_param_nested(XSM_DEFAULT_ARG struct domain *d)
return xsm_default_action(action, current->domain, d);
}
-#ifdef HAS_MEM_ACCESS
static XSM_INLINE int xsm_vm_event_control(XSM_DEFAULT_ARG struct domain *d, int mode, int op)
{
XSM_ASSERT_ACTION(XSM_PRIV);
@@ -525,7 +524,6 @@ static XSM_INLINE int xsm_vm_event_op(XSM_DEFAULT_ARG struct domain *d, int op)
XSM_ASSERT_ACTION(XSM_DM_PRIV);
return xsm_default_action(action, current->domain, d);
}
-#endif
#ifdef CONFIG_X86
static XSM_INLINE int xsm_do_mca(XSM_DEFAULT_VOID)
diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
index cff9d35..61c5acc 100644
--- a/xen/include/xsm/xsm.h
+++ b/xen/include/xsm/xsm.h
@@ -141,10 +141,8 @@ struct xsm_operations {
int (*hvm_param_nested) (struct domain *d);
int (*get_vnumainfo) (struct domain *d);
-#ifdef HAS_MEM_ACCESS
int (*vm_event_control) (struct domain *d, int mode, int op);
int (*vm_event_op) (struct domain *d, int op);
-#endif
#ifdef CONFIG_X86
int (*do_mca) (void);
diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
index 25fca68..6d12d32 100644
--- a/xen/xsm/dummy.c
+++ b/xen/xsm/dummy.c
@@ -118,10 +118,8 @@ void xsm_fixup_ops (struct xsm_operations *ops)
set_to_dummy_if_null(ops, remove_from_physmap);
set_to_dummy_if_null(ops, map_gmfn_foreign);
-#ifdef HAS_MEM_ACCESS
set_to_dummy_if_null(ops, vm_event_control);
set_to_dummy_if_null(ops, vm_event_op);
-#endif
#ifdef CONFIG_X86
set_to_dummy_if_null(ops, do_mca);
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index c419543..5008b79 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -577,9 +577,7 @@ static int flask_domctl(struct domain *d, int cmd)
case XEN_DOMCTL_iomem_permission:
case XEN_DOMCTL_memory_mapping:
case XEN_DOMCTL_set_target:
-#ifdef HAS_MEM_ACCESS
case XEN_DOMCTL_vm_event_op:
-#endif
#ifdef CONFIG_X86
/* These have individual XSM hooks (arch/x86/domctl.c) */
case XEN_DOMCTL_shadow_op:
@@ -1136,6 +1134,16 @@ static int flask_hvm_param_nested(struct domain *d)
return current_has_perm(d, SECCLASS_HVM, HVM__NESTED);
}
+static int flask_vm_event_control(struct domain *d, int mode, int op)
+{
+ return current_has_perm(d, SECCLASS_HVM, HVM__VM_EVENT);
+}
+
+static int flask_vm_event_op(struct domain *d, int op)
+{
+ return current_has_perm(d, SECCLASS_HVM, HVM__VM_EVENT);
+}
+
#if defined(HAS_PASSTHROUGH) && defined(HAS_PCI)
static int flask_get_device_group(uint32_t machine_bdf)
{
@@ -1202,18 +1210,6 @@ static int flask_deassign_device(struct domain *d, uint32_t machine_bdf)
}
#endif /* HAS_PASSTHROUGH && HAS_PCI */
-#ifdef HAS_MEM_ACCESS
-static int flask_vm_event_control(struct domain *d, int mode, int op)
-{
- return current_has_perm(d, SECCLASS_HVM, HVM__VM_EVENT);
-}
-
-static int flask_vm_event_op(struct domain *d, int op)
-{
- return current_has_perm(d, SECCLASS_HVM, HVM__VM_EVENT);
-}
-#endif /* HAS_MEM_ACCESS */
-
#ifdef CONFIG_X86
static int flask_do_mca(void)
{
@@ -1581,6 +1577,9 @@ static struct xsm_operations flask_ops = {
.do_xsm_op = do_flask_op,
.get_vnumainfo = flask_get_vnumainfo,
+ .vm_event_control = flask_vm_event_control,
+ .vm_event_op = flask_vm_event_op,
+
#ifdef CONFIG_COMPAT
.do_compat_op = compat_flask_op,
#endif
@@ -1596,11 +1595,6 @@ static struct xsm_operations flask_ops = {
.deassign_device = flask_deassign_device,
#endif
-#ifdef HAS_MEM_ACCESS
- .vm_event_control = flask_vm_event_control,
- .vm_event_op = flask_vm_event_op,
-#endif
-
#ifdef CONFIG_X86
.do_mca = flask_do_mca,
.shadow_control = flask_shadow_control,
--
2.1.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [RFC PATCH V2 7/8] tools/tests: Clean-up tools/tests/xen-access
2015-01-18 15:17 [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Tamas K Lengyel
` (5 preceding siblings ...)
2015-01-18 15:17 ` [RFC PATCH V2 6/8] xen/vm_event: Decouple vm_event and mem_access Tamas K Lengyel
@ 2015-01-18 15:18 ` Tamas K Lengyel
2015-01-18 15:18 ` [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file Tamas K Lengyel
2015-01-19 13:03 ` [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Andrew Cooper
8 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-18 15:18 UTC (permalink / raw)
To: xen-devel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, tim, ian.jackson, eddie.dong, andres, jbeulich,
Tamas K Lengyel, rshriram, keir, dgdegra, yanghy
The spin-lock implementation in the xen-access test program is implemented
in a fashion that is actually incomplete. The x86 assembly that guarantees that
the lock is held by only one thread lacks the "lock;" instruction.
However, the spin-lock is not actually necessary in xen-access as it is not
multithreaded. The presence of the faulty implementation of the lock in a non-
mulithreaded environment is unnecessarily complicated for developers who are
trying to follow this code as a guide in implementing their own applications.
Thus, removing it from the code improves the clarity on the behavior of the
system.
Also converting functions that always return 0 to return to void, and making
the teardown function actually return an error code on error.
Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
---
tools/tests/xen-access/xen-access.c | 99 +++++++------------------------------
1 file changed, 19 insertions(+), 80 deletions(-)
diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c
index 3538323..80e4de9 100644
--- a/tools/tests/xen-access/xen-access.c
+++ b/tools/tests/xen-access/xen-access.c
@@ -45,56 +45,6 @@
#define ERROR(a, b...) fprintf(stderr, a "\n", ## b)
#define PERROR(a, b...) fprintf(stderr, a ": %s\n", ## b, strerror(errno))
-/* Spinlock and mem event definitions */
-
-#define SPIN_LOCK_UNLOCKED 0
-
-#define ADDR (*(volatile long *) addr)
-/**
- * test_and_set_bit - Set a bit and return its old value
- * @nr: Bit to set
- * @addr: Address to count from
- *
- * This operation is atomic and cannot be reordered.
- * It also implies a memory barrier.
- */
-static inline int test_and_set_bit(int nr, volatile void *addr)
-{
- int oldbit;
-
- asm volatile (
- "btsl %2,%1\n\tsbbl %0,%0"
- : "=r" (oldbit), "=m" (ADDR)
- : "Ir" (nr), "m" (ADDR) : "memory");
- return oldbit;
-}
-
-typedef int spinlock_t;
-
-static inline void spin_lock(spinlock_t *lock)
-{
- while ( test_and_set_bit(1, lock) );
-}
-
-static inline void spin_lock_init(spinlock_t *lock)
-{
- *lock = SPIN_LOCK_UNLOCKED;
-}
-
-static inline void spin_unlock(spinlock_t *lock)
-{
- *lock = SPIN_LOCK_UNLOCKED;
-}
-
-static inline int spin_trylock(spinlock_t *lock)
-{
- return !test_and_set_bit(1, lock);
-}
-
-#define vm_event_ring_lock_init(_m) spin_lock_init(&(_m)->ring_lock)
-#define vm_event_ring_lock(_m) spin_lock(&(_m)->ring_lock)
-#define vm_event_ring_unlock(_m) spin_unlock(&(_m)->ring_lock)
-
typedef struct vm_event {
domid_t domain_id;
xc_evtchn *xce_handle;
@@ -102,7 +52,6 @@ typedef struct vm_event {
vm_event_back_ring_t back_ring;
uint32_t evtchn_port;
void *ring_page;
- spinlock_t ring_lock;
} vm_event_t;
typedef struct xenaccess {
@@ -180,6 +129,7 @@ int xenaccess_teardown(xc_interface *xch, xenaccess_t *xenaccess)
if ( rc != 0 )
{
ERROR("Error tearing down domain xenaccess in xen");
+ return rc;
}
}
@@ -191,6 +141,7 @@ int xenaccess_teardown(xc_interface *xch, xenaccess_t *xenaccess)
if ( rc != 0 )
{
ERROR("Error unbinding event port");
+ return rc;
}
}
@@ -201,6 +152,7 @@ int xenaccess_teardown(xc_interface *xch, xenaccess_t *xenaccess)
if ( rc != 0 )
{
ERROR("Error closing event channel");
+ return rc;
}
}
@@ -209,6 +161,7 @@ int xenaccess_teardown(xc_interface *xch, xenaccess_t *xenaccess)
if ( rc != 0 )
{
ERROR("Error closing connection to xen");
+ return rc;
}
xenaccess->xc_handle = NULL;
@@ -241,9 +194,6 @@ xenaccess_t *xenaccess_init(xc_interface **xch_r, domid_t domain_id)
/* Set domain id */
xenaccess->vm_event.domain_id = domain_id;
- /* Initialise lock */
- vm_event_ring_lock_init(&xenaccess->vm_event);
-
/* Enable mem_access */
xenaccess->vm_event.ring_page =
xc_mem_access_enable(xenaccess->xc_handle,
@@ -314,19 +264,24 @@ xenaccess_t *xenaccess_init(xc_interface **xch_r, domid_t domain_id)
return xenaccess;
err:
- xenaccess_teardown(xch, xenaccess);
+ rc = xenaccess_teardown(xch, xenaccess);
+ if ( rc )
+ {
+ ERROR("Failed to teardown xenaccess structure!\n");
+ }
err_iface:
return NULL;
}
-int get_request(vm_event_t *vm_event, vm_event_request_t *req)
+/*
+ * Note that this function is not thread safe.
+ */
+static void get_request(vm_event_t *vm_event, vm_event_request_t *req)
{
vm_event_back_ring_t *back_ring;
RING_IDX req_cons;
- vm_event_ring_lock(vm_event);
-
back_ring = &vm_event->back_ring;
req_cons = back_ring->req_cons;
@@ -337,19 +292,16 @@ int get_request(vm_event_t *vm_event, vm_event_request_t *req)
/* Update ring */
back_ring->req_cons = req_cons;
back_ring->sring->req_event = req_cons + 1;
-
- vm_event_ring_unlock(vm_event);
-
- return 0;
}
-static int put_response(vm_event_t *vm_event, vm_event_response_t *rsp)
+/*
+ * Note that this function is not thread safe.
+ */
+static void put_response(vm_event_t *vm_event, vm_event_response_t *rsp)
{
vm_event_back_ring_t *back_ring;
RING_IDX rsp_prod;
- vm_event_ring_lock(vm_event);
-
back_ring = &vm_event->back_ring;
rsp_prod = back_ring->rsp_prod_pvt;
@@ -360,10 +312,6 @@ static int put_response(vm_event_t *vm_event, vm_event_response_t *rsp)
/* Update ring */
back_ring->rsp_prod_pvt = rsp_prod;
RING_PUSH_RESPONSES(back_ring);
-
- vm_event_ring_unlock(vm_event);
-
- return 0;
}
static int xenaccess_resume_page(xenaccess_t *paging, vm_event_response_t *rsp)
@@ -371,16 +319,13 @@ static int xenaccess_resume_page(xenaccess_t *paging, vm_event_response_t *rsp)
int ret;
/* Put the page info on the ring */
- ret = put_response(&paging->vm_event, rsp);
- if ( ret != 0 )
- goto out;
+ put_response(&paging->vm_event, rsp);
/* Tell Xen page is ready */
ret = xc_mem_access_resume(paging->xc_handle, paging->vm_event.domain_id);
ret = xc_evtchn_notify(paging->vm_event.xce_handle,
paging->vm_event.port);
- out:
return ret;
}
@@ -543,13 +488,7 @@ int main(int argc, char *argv[])
{
xenmem_access_t access;
- rc = get_request(&xenaccess->vm_event, &req);
- if ( rc != 0 )
- {
- ERROR("Error getting request");
- interrupted = -1;
- continue;
- }
+ get_request(&xenaccess->vm_event, &req);
memset( &rsp, 0, sizeof (rsp) );
rsp.vcpu_id = req.vcpu_id;
--
2.1.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file
2015-01-18 15:17 [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Tamas K Lengyel
` (6 preceding siblings ...)
2015-01-18 15:18 ` [RFC PATCH V2 7/8] tools/tests: Clean-up tools/tests/xen-access Tamas K Lengyel
@ 2015-01-18 15:18 ` Tamas K Lengyel
2015-01-22 15:00 ` Tim Deegan
` (2 more replies)
2015-01-19 13:03 ` [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Andrew Cooper
8 siblings, 3 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-18 15:18 UTC (permalink / raw)
To: xen-devel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, tim, ian.jackson, eddie.dong, andres, jbeulich,
Tamas K Lengyel, rshriram, keir, dgdegra, yanghy
To avoid growing hvm.c these functions can be stored
separately.
Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
---
xen/arch/x86/hvm/Makefile | 3 +-
xen/arch/x86/hvm/event.c | 195 ++++++++++++++++++++++++++++++++++++++++
xen/arch/x86/hvm/hvm.c | 163 +--------------------------------
xen/arch/x86/hvm/vmx/vmx.c | 1 +
xen/include/asm-x86/hvm/event.h | 40 +++++++++
xen/include/asm-x86/hvm/hvm.h | 11 ---
6 files changed, 239 insertions(+), 174 deletions(-)
create mode 100644 xen/arch/x86/hvm/event.c
create mode 100644 xen/include/asm-x86/hvm/event.h
diff --git a/xen/arch/x86/hvm/Makefile b/xen/arch/x86/hvm/Makefile
index eea5555..2389923 100644
--- a/xen/arch/x86/hvm/Makefile
+++ b/xen/arch/x86/hvm/Makefile
@@ -22,4 +22,5 @@ obj-y += vlapic.o
obj-y += vmsi.o
obj-y += vpic.o
obj-y += vpt.o
-obj-y += vpmu.o
\ No newline at end of file
+obj-y += vpmu.o
+obj-y += event.o
diff --git a/xen/arch/x86/hvm/event.c b/xen/arch/x86/hvm/event.c
new file mode 100644
index 0000000..96d1748
--- /dev/null
+++ b/xen/arch/x86/hvm/event.c
@@ -0,0 +1,195 @@
+/*
+* event.c: Common hardware virtual machine event abstractions.
+*
+* Copyright (c) 2004, Intel Corporation.
+* Copyright (c) 2005, International Business Machines Corporation.
+* Copyright (c) 2008, Citrix Systems, Inc.
+*
+* This program is free software; you can redistribute it and/or modify it
+* under the terms and conditions of the GNU General Public License,
+* version 2, as published by the Free Software Foundation.
+*
+* This program is distributed in the hope it will be useful, but WITHOUT
+* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+* more details.
+*
+* You should have received a copy of the GNU General Public License along with
+* this program; if not, write to the Free Software Foundation, Inc., 59 Temple
+* Place - Suite 330, Boston, MA 02111-1307 USA.
+*/
+
+#include <xen/vm_event.h>
+#include <xen/paging.h>
+#include <public/vm_event.h>
+
+static void hvm_event_fill_regs(vm_event_request_t *req)
+{
+ const struct cpu_user_regs *regs = guest_cpu_user_regs();
+ const struct vcpu *curr = current;
+
+ req->regs.x86.rax = regs->eax;
+ req->regs.x86.rcx = regs->ecx;
+ req->regs.x86.rdx = regs->edx;
+ req->regs.x86.rbx = regs->ebx;
+ req->regs.x86.rsp = regs->esp;
+ req->regs.x86.rbp = regs->ebp;
+ req->regs.x86.rsi = regs->esi;
+ req->regs.x86.rdi = regs->edi;
+
+ req->regs.x86.r8 = regs->r8;
+ req->regs.x86.r9 = regs->r9;
+ req->regs.x86.r10 = regs->r10;
+ req->regs.x86.r11 = regs->r11;
+ req->regs.x86.r12 = regs->r12;
+ req->regs.x86.r13 = regs->r13;
+ req->regs.x86.r14 = regs->r14;
+ req->regs.x86.r15 = regs->r15;
+
+ req->regs.x86.rflags = regs->eflags;
+ req->regs.x86.rip = regs->eip;
+
+ req->regs.x86.msr_efer = curr->arch.hvm_vcpu.guest_efer;
+ req->regs.x86.cr0 = curr->arch.hvm_vcpu.guest_cr[0];
+ req->regs.x86.cr3 = curr->arch.hvm_vcpu.guest_cr[3];
+ req->regs.x86.cr4 = curr->arch.hvm_vcpu.guest_cr[4];
+}
+
+static int hvm_event_traps(long parameters, vm_event_request_t *req)
+{
+ int rc;
+ struct vcpu *v = current;
+ struct domain *d = v->domain;
+
+ if ( !(parameters & HVMPME_MODE_MASK) )
+ return 0;
+
+ rc = vm_event_claim_slot(d, &d->vm_event->monitor);
+ if ( rc == -ENOSYS )
+ {
+ /* If there was no ring to handle the event, then
+ * simple continue executing normally. */
+ return 1;
+ }
+ else if ( rc < 0 )
+ return rc;
+
+ if ( (parameters & HVMPME_MODE_MASK) == HVMPME_mode_sync )
+ {
+ req->flags |= VM_EVENT_FLAG_VCPU_PAUSED;
+ vm_event_vcpu_pause(v);
+ }
+
+ hvm_event_fill_regs(req);
+ vm_event_put_request(d, &d->vm_event->monitor, req);
+
+ return 1;
+}
+
+void hvm_event_cr0(unsigned long value, unsigned long old)
+{
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_CR0,
+ .vcpu_id = current->vcpu_id,
+ .cr_event.new_value = value,
+ .cr_event.old_value = old
+ };
+
+ long parameters = current->domain->arch.hvm_domain
+ .params[HVM_PARAM_MEMORY_EVENT_CR0];
+
+ if ( (parameters & HVMPME_onchangeonly) && (value == old) )
+ return;
+
+ hvm_event_traps(parameters, &req);
+}
+
+void hvm_event_cr3(unsigned long value, unsigned long old)
+{
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_CR3,
+ .vcpu_id = current->vcpu_id,
+ .cr_event.new_value = value,
+ .cr_event.old_value = old
+ };
+
+ long parameters = current->domain->arch.hvm_domain
+ .params[HVM_PARAM_MEMORY_EVENT_CR3];
+
+ if ( (parameters & HVMPME_onchangeonly) && (value == old) )
+ return;
+
+ hvm_event_traps(parameters, &req);
+}
+
+void hvm_event_cr4(unsigned long value, unsigned long old)
+{
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_CR4,
+ .vcpu_id = current->vcpu_id,
+ .cr_event.new_value = value,
+ .cr_event.old_value = old
+ };
+
+ long parameters = current->domain->arch.hvm_domain
+ .params[HVM_PARAM_MEMORY_EVENT_CR4];
+
+ if ( (parameters & HVMPME_onchangeonly) && (value == old) )
+ return;
+
+ hvm_event_traps(parameters, &req);
+}
+
+void hvm_event_msr(unsigned long msr, unsigned long value)
+{
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_MSR,
+ .vcpu_id = current->vcpu_id,
+ .msr_event.msr = msr,
+ .msr_event.new_value = value,
+ };
+
+ hvm_event_traps(current->domain->arch.hvm_domain
+ .params[HVM_PARAM_MEMORY_EVENT_MSR],
+ &req);
+}
+
+int hvm_event_int3(unsigned long gla)
+{
+ uint32_t pfec = PFEC_page_present;
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_INT3,
+ .vcpu_id = current->vcpu_id,
+ .int3_event.gla = gla,
+ .int3_event.gfn = paging_gva_to_gfn(current, gla, &pfec)
+ };
+
+ return hvm_event_traps(current->domain->arch.hvm_domain
+ .params[HVM_PARAM_MEMORY_EVENT_INT3],
+ &req);
+}
+
+int hvm_event_single_step(unsigned long gla)
+{
+ uint32_t pfec = PFEC_page_present;
+ vm_event_request_t req = {
+ .reason = VM_EVENT_REASON_SINGLESTEP,
+ .vcpu_id = current->vcpu_id,
+ .singlestep_event.gla = gla,
+ .singlestep_event.gfn = paging_gva_to_gfn(current, gla, &pfec)
+ };
+
+ return hvm_event_traps(current->domain->arch.hvm_domain
+ .params[HVM_PARAM_MEMORY_EVENT_SINGLE_STEP],
+ &req);
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 48ef545..7c17c5c 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -35,7 +35,6 @@
#include <xen/paging.h>
#include <xen/cpu.h>
#include <xen/wait.h>
-#include <xen/vm_event.h>
#include <xen/mem_access.h>
#include <xen/rangeset.h>
#include <asm/shadow.h>
@@ -60,6 +59,7 @@
#include <asm/hvm/cacheattr.h>
#include <asm/hvm/trace.h>
#include <asm/hvm/nestedhvm.h>
+#include <asm/hvm/event.h>
#include <asm/mtrr.h>
#include <asm/apic.h>
#include <public/sched.h>
@@ -6171,167 +6171,6 @@ int hvm_debug_op(struct vcpu *v, int32_t op)
return rc;
}
-static void hvm_event_fill_regs(vm_event_request_t *req)
-{
- const struct cpu_user_regs *regs = guest_cpu_user_regs();
- const struct vcpu *curr = current;
-
- req->regs.x86.rax = regs->eax;
- req->regs.x86.rcx = regs->ecx;
- req->regs.x86.rdx = regs->edx;
- req->regs.x86.rbx = regs->ebx;
- req->regs.x86.rsp = regs->esp;
- req->regs.x86.rbp = regs->ebp;
- req->regs.x86.rsi = regs->esi;
- req->regs.x86.rdi = regs->edi;
-
- req->regs.x86.r8 = regs->r8;
- req->regs.x86.r9 = regs->r9;
- req->regs.x86.r10 = regs->r10;
- req->regs.x86.r11 = regs->r11;
- req->regs.x86.r12 = regs->r12;
- req->regs.x86.r13 = regs->r13;
- req->regs.x86.r14 = regs->r14;
- req->regs.x86.r15 = regs->r15;
-
- req->regs.x86.rflags = regs->eflags;
- req->regs.x86.rip = regs->eip;
-
- req->regs.x86.msr_efer = curr->arch.hvm_vcpu.guest_efer;
- req->regs.x86.cr0 = curr->arch.hvm_vcpu.guest_cr[0];
- req->regs.x86.cr3 = curr->arch.hvm_vcpu.guest_cr[3];
- req->regs.x86.cr4 = curr->arch.hvm_vcpu.guest_cr[4];
-}
-
-static int hvm_event_traps(long parameters, vm_event_request_t *req)
-{
- int rc;
- struct vcpu *v = current;
- struct domain *d = v->domain;
-
- if ( !(parameters & HVMPME_MODE_MASK) )
- return 0;
-
- rc = vm_event_claim_slot(d, &d->vm_event->monitor);
- if ( rc == -ENOSYS )
- {
- /* If there was no ring to handle the event, then
- * simple continue executing normally. */
- return 1;
- }
- else if ( rc < 0 )
- return rc;
-
- if ( (parameters & HVMPME_MODE_MASK) == HVMPME_mode_sync )
- {
- req->flags |= VM_EVENT_FLAG_VCPU_PAUSED;
- vm_event_vcpu_pause(v);
- }
-
- hvm_event_fill_regs(req);
- vm_event_put_request(d, &d->vm_event->monitor, req);
-
- return 1;
-}
-
-void hvm_event_cr0(unsigned long value, unsigned long old)
-{
- vm_event_request_t req = {
- .reason = VM_EVENT_REASON_CR0,
- .vcpu_id = current->vcpu_id,
- .cr_event.new_value = value,
- .cr_event.old_value = old
- };
-
- long parameters = current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_CR0];
-
- if ( (parameters & HVMPME_onchangeonly) && (value == old) )
- return;
-
- hvm_event_traps(parameters, &req);
-}
-
-void hvm_event_cr3(unsigned long value, unsigned long old)
-{
- vm_event_request_t req = {
- .reason = VM_EVENT_REASON_CR3,
- .vcpu_id = current->vcpu_id,
- .cr_event.new_value = value,
- .cr_event.old_value = old
- };
-
- long parameters = current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_CR3];
-
- if ( (parameters & HVMPME_onchangeonly) && (value == old) )
- return;
-
- hvm_event_traps(parameters, &req);
-}
-
-void hvm_event_cr4(unsigned long value, unsigned long old)
-{
- vm_event_request_t req = {
- .reason = VM_EVENT_REASON_CR4,
- .vcpu_id = current->vcpu_id,
- .cr_event.new_value = value,
- .cr_event.old_value = old
- };
-
- long parameters = current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_CR4];
-
- if ( (parameters & HVMPME_onchangeonly) && (value == old) )
- return;
-
- hvm_event_traps(parameters, &req);
-}
-
-void hvm_event_msr(unsigned long msr, unsigned long value)
-{
- vm_event_request_t req = {
- .reason = VM_EVENT_REASON_MSR,
- .vcpu_id = current->vcpu_id,
- .msr_event.msr = msr,
- .msr_event.new_value = value,
- };
-
- hvm_event_traps(current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_MSR],
- &req);
-}
-
-int hvm_event_int3(unsigned long gla)
-{
- uint32_t pfec = PFEC_page_present;
- vm_event_request_t req = {
- .reason = VM_EVENT_REASON_INT3,
- .vcpu_id = current->vcpu_id,
- .int3_event.gla = gla,
- .int3_event.gfn = paging_gva_to_gfn(current, gla, &pfec)
- };
-
- return hvm_event_traps(current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_INT3],
- &req);
-}
-
-int hvm_event_single_step(unsigned long gla)
-{
- uint32_t pfec = PFEC_page_present;
- vm_event_request_t req = {
- .reason = VM_EVENT_REASON_SINGLESTEP,
- .vcpu_id = current->vcpu_id,
- .singlestep_event.gla = gla,
- .singlestep_event.gfn = paging_gva_to_gfn(current, gla, &pfec)
- };
-
- return hvm_event_traps(current->domain->arch.hvm_domain
- .params[HVM_PARAM_MEMORY_EVENT_SINGLE_STEP],
- &req);
-}
-
int nhvm_vcpu_hostrestore(struct vcpu *v, struct cpu_user_regs *regs)
{
if (hvm_funcs.nhvm_vcpu_hostrestore)
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index d2c39f4..42429ab 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -52,6 +52,7 @@
#include <asm/hvm/vpt.h>
#include <public/hvm/save.h>
#include <asm/hvm/trace.h>
+#include <asm/hvm/event.h>
#include <asm/xenoprof.h>
#include <asm/debugger.h>
#include <asm/apic.h>
diff --git a/xen/include/asm-x86/hvm/event.h b/xen/include/asm-x86/hvm/event.h
new file mode 100644
index 0000000..5a498a9
--- /dev/null
+++ b/xen/include/asm-x86/hvm/event.h
@@ -0,0 +1,40 @@
+/*
+ * event.h: Hardware virtual machine assist events.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
+ * Place - Suite 330, Boston, MA 02111-1307 USA.
+ */
+
+#ifndef __ASM_X86_HVM_EVENT_H__
+#define __ASM_X86_HVM_EVENT_H__
+
+/* Called for current VCPU on crX changes by guest */
+void hvm_event_cr0(unsigned long value, unsigned long old);
+void hvm_event_cr3(unsigned long value, unsigned long old);
+void hvm_event_cr4(unsigned long value, unsigned long old);
+void hvm_event_msr(unsigned long msr, unsigned long value);
+/* Called for current VCPU on int3: returns -1 if no listener */
+int hvm_event_int3(unsigned long gla);
+int hvm_event_single_step(unsigned long gla);
+
+#endif /* __ASM_X86_HVM_EVENT_H__ */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h
index 5ac390b..c77076a 100644
--- a/xen/include/asm-x86/hvm/hvm.h
+++ b/xen/include/asm-x86/hvm/hvm.h
@@ -473,17 +473,6 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla,
int hvm_x2apic_msr_read(struct vcpu *v, unsigned int msr, uint64_t *msr_content);
int hvm_x2apic_msr_write(struct vcpu *v, unsigned int msr, uint64_t msr_content);
-/* Called for current VCPU on crX changes by guest */
-void hvm_event_cr0(unsigned long value, unsigned long old);
-void hvm_event_cr3(unsigned long value, unsigned long old);
-void hvm_event_cr4(unsigned long value, unsigned long old);
-void hvm_event_msr(unsigned long msr, unsigned long value);
-/* Called for current VCPU on int3: returns -1 if no listener */
-int hvm_event_int3(unsigned long gla);
-
-/* Called for current VCPU on single step: returns -1 if no listener */
-int hvm_event_single_step(unsigned long gla);
-
/*
* Nested HVM
*/
--
2.1.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem
2015-01-18 15:17 [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Tamas K Lengyel
` (7 preceding siblings ...)
2015-01-18 15:18 ` [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file Tamas K Lengyel
@ 2015-01-19 13:03 ` Andrew Cooper
2015-01-21 10:59 ` Tamas K Lengyel
8 siblings, 1 reply; 53+ messages in thread
From: Andrew Cooper @ 2015-01-19 13:03 UTC (permalink / raw)
To: Tamas K Lengyel, xen-devel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
ian.jackson, tim, jbeulich, eddie.dong, andres, jun.nakajima,
rshriram, keir, dgdegra, yanghy
On 18/01/15 15:17, Tamas K Lengyel wrote:
> This patch series aims to clean up the mem_event subsystem within Xen. The
> original use-case for this system was to allow external helper applications
> running in privileged domains to control various memory operations performed
> by Xen. Amongs these were paging, sharing and access control. The subsystem
> has since been extended to also deliver non-memory related events, namely
> various HVM debugging events (INT3, MTF, MOV-TO-CR, MOV-TO-MSR). The structures
> and naming of related functions however has not caught up to these new
> use-cases, thus leaving many ambigouities in the code.
>
> In this series we convert the mem_event structures to a union of sub-structures
> which clearly define the scope of information that is transmitted via the event
> delivery mechanism. Afterwards, we clean up the naming of the structures and
> related functions to more clearly be in line with their actual operations.
>
> This RFC PATCH series is also available at:
> https://github.com/tklengyel/xen/tree/mem_event_cleanup2
One note to start with. There are a lot of file renames in this
series. Using gits -M option for patches should make the series rather
smaller.
I also wonder whether it might be easier to organise the series along
the lines of introducing vm_event, move the existing interfaces across,
then deleting mem_event. Lets see how easy it is to review in its
current form first though.
~Andrew
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem
2015-01-19 13:03 ` [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Andrew Cooper
@ 2015-01-21 10:59 ` Tamas K Lengyel
0 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-21 10:59 UTC (permalink / raw)
To: Andrew Cooper
Cc: Tian, Kevin, wei.liu2, Ian Campbell, Stefano Stabellini,
Ian Jackson, Tim Deegan, xen-devel, Jan Beulich, Dong, Eddie,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
> I also wonder whether it might be easier to organise the series along
> the lines of introducing vm_event, move the existing interfaces across,
> then deleting mem_event. Lets see how easy it is to review in its
> current form first though.
>
> ~Andrew
Ack, that indeed might be easier to review. I'm OK with going that
route if preferred!
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-18 15:17 ` [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures Tamas K Lengyel
@ 2015-01-22 12:43 ` Tim Deegan
2015-01-22 12:50 ` Razvan Cojocaru
2015-01-22 12:50 ` Tamas K Lengyel
2015-01-22 15:00 ` Jan Beulich
1 sibling, 2 replies; 53+ messages in thread
From: Tim Deegan @ 2015-01-22 12:43 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: kevin.tian, wei.liu2, ian.campbell, Razvan Cojocaru,
stefano.stabellini, jun.nakajima, eddie.dong, ian.jackson,
xen-devel, andres, jbeulich, rshriram, keir, dgdegra, yanghy
Hi,
At 16:17 +0100 on 18 Jan (1421594274), Tamas K Lengyel wrote:
> From: Razvan Cojocaru <rcojocaru@bitdefender.com>
>
> The public mem_event structures used to communicate with helper applications via
> shared rings have been used in different settings. However, the variable names
> within this structure have not reflected this fact, resulting in the reuse of
> variables to mean different things under different scenarios.
>
> This patch remedies the issue by clearly defining the structure members based on
> the actual context within which the structure is used.
>
> Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
This looks like a nice improvement. If everyone who commented about
making ABI changes is happy with it, I am too.
It would be nice if you could add some comments to the new struct
definitions saying what the various fields mean (e.g. when the event
triggers and what the fields will contain).
One nit in the patch itself:
> @@ -592,13 +592,12 @@ int main(int argc, char *argv[])
> }
>
>
> - rsp.gfn = req.gfn;
> - rsp.p2mt = req.p2mt;
> + rsp.mem_access_event.gfn = req.mem_access_event.gfn;
You're dropping a p2mt update here. Is that an oversight?
With the obvious equivalent update inserted,
Acked-by: Tim Deegan <tim@xen.org>
Cheers,
Tim.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-22 12:43 ` Tim Deegan
@ 2015-01-22 12:50 ` Razvan Cojocaru
2015-01-22 12:50 ` Tamas K Lengyel
1 sibling, 0 replies; 53+ messages in thread
From: Razvan Cojocaru @ 2015-01-22 12:50 UTC (permalink / raw)
To: Tim Deegan, Tamas K Lengyel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
ian.jackson, eddie.dong, xen-devel, jbeulich, andres,
jun.nakajima, rshriram, keir, dgdegra, yanghy
On 01/22/2015 02:43 PM, Tim Deegan wrote:
> Hi,
>
> At 16:17 +0100 on 18 Jan (1421594274), Tamas K Lengyel wrote:
>> From: Razvan Cojocaru <rcojocaru@bitdefender.com>
>>
>> The public mem_event structures used to communicate with helper applications via
>> shared rings have been used in different settings. However, the variable names
>> within this structure have not reflected this fact, resulting in the reuse of
>> variables to mean different things under different scenarios.
>>
>> This patch remedies the issue by clearly defining the structure members based on
>> the actual context within which the structure is used.
>>
>> Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
>
> This looks like a nice improvement. If everyone who commented about
> making ABI changes is happy with it, I am too.
>
> It would be nice if you could add some comments to the new struct
> definitions saying what the various fields mean (e.g. when the event
> triggers and what the fields will contain).
>
> One nit in the patch itself:
>
>> @@ -592,13 +592,12 @@ int main(int argc, char *argv[])
>> }
>>
>>
>> - rsp.gfn = req.gfn;
>> - rsp.p2mt = req.p2mt;
>> + rsp.mem_access_event.gfn = req.mem_access_event.gfn;
>
> You're dropping a p2mt update here. Is that an oversight?
Yes, that's an oversight (unless Tamas knows something about this I don't).
Thanks,
Razvan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-22 12:43 ` Tim Deegan
2015-01-22 12:50 ` Razvan Cojocaru
@ 2015-01-22 12:50 ` Tamas K Lengyel
2015-01-22 12:53 ` Razvan Cojocaru
2015-01-22 13:11 ` Tim Deegan
1 sibling, 2 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-22 12:50 UTC (permalink / raw)
To: Tim Deegan
Cc: Tian, Kevin, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Jun Nakajima, Dong, Eddie, Ian Jackson,
xen-devel, Andres Lagar-Cavilla, Jan Beulich, rshriram,
Keir Fraser, Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 1:43 PM, Tim Deegan <tim@xen.org> wrote:
> Hi,
>
> At 16:17 +0100 on 18 Jan (1421594274), Tamas K Lengyel wrote:
>> From: Razvan Cojocaru <rcojocaru@bitdefender.com>
>>
>> The public mem_event structures used to communicate with helper applications via
>> shared rings have been used in different settings. However, the variable names
>> within this structure have not reflected this fact, resulting in the reuse of
>> variables to mean different things under different scenarios.
>>
>> This patch remedies the issue by clearly defining the structure members based on
>> the actual context within which the structure is used.
>>
>> Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
>
> This looks like a nice improvement. If everyone who commented about
> making ABI changes is happy with it, I am too.
>
> It would be nice if you could add some comments to the new struct
> definitions saying what the various fields mean (e.g. when the event
> triggers and what the fields will contain).
Ack, will do!
>
> One nit in the patch itself:
>
>> @@ -592,13 +592,12 @@ int main(int argc, char *argv[])
>> }
>>
>>
>> - rsp.gfn = req.gfn;
>> - rsp.p2mt = req.p2mt;
>> + rsp.mem_access_event.gfn = req.mem_access_event.gfn;
>
> You're dropping a p2mt update here. Is that an oversight?
> With the obvious equivalent update inserted,
No, it is not. That field is only used by mem_sharing and mem_paging,
not by mem_access.
Thanks,
Tamas
>
> Acked-by: Tim Deegan <tim@xen.org>
>
> Cheers,
>
> Tim.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'
2015-01-18 15:17 ` [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor' Tamas K Lengyel
@ 2015-01-22 12:53 ` Tim Deegan
2015-01-22 14:12 ` Tamas K Lengyel
2015-01-22 15:02 ` Jan Beulich
1 sibling, 1 reply; 53+ messages in thread
From: Tim Deegan @ 2015-01-22 12:53 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, eddie.dong, ian.jackson, xen-devel, andres,
jbeulich, rshriram, keir, dgdegra, yanghy
At 16:17 +0100 on 18 Jan (1421594275), Tamas K Lengyel wrote:
> The name of the ring still implies it is used only for memory accesses,
> which is no longer the case. It is also used to deliver variuos HVM events,
> thus the name "monitor" is more appropriate in this setting.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
Renaming the ring seems good (again assuming everyone is happy about
making these API changes). However I think you need to rework the
public header comment a bit more than just s/access/monitor/. The
operation is to set up the event ring but almost all the comments is
about the access permissions system. It needs a description that
would be useful to a developer who didn't already know how all thses
systems worked. :)
Cheers,
Tim.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-22 12:50 ` Tamas K Lengyel
@ 2015-01-22 12:53 ` Razvan Cojocaru
2015-01-22 13:11 ` Tim Deegan
1 sibling, 0 replies; 53+ messages in thread
From: Razvan Cojocaru @ 2015-01-22 12:53 UTC (permalink / raw)
To: Tamas K Lengyel, Tim Deegan
Cc: Tian, Kevin, wei.liu2, Ian Campbell, Stefano Stabellini,
Ian Jackson, Dong, Eddie, xen-devel, Jan Beulich,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On 01/22/2015 02:50 PM, Tamas K Lengyel wrote:
> On Thu, Jan 22, 2015 at 1:43 PM, Tim Deegan <tim@xen.org> wrote:
>> Hi,
>>
>> At 16:17 +0100 on 18 Jan (1421594274), Tamas K Lengyel wrote:
>>> From: Razvan Cojocaru <rcojocaru@bitdefender.com>
>>>
>>> The public mem_event structures used to communicate with helper applications via
>>> shared rings have been used in different settings. However, the variable names
>>> within this structure have not reflected this fact, resulting in the reuse of
>>> variables to mean different things under different scenarios.
>>>
>>> This patch remedies the issue by clearly defining the structure members based on
>>> the actual context within which the structure is used.
>>>
>>> Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
>>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
>>
>> This looks like a nice improvement. If everyone who commented about
>> making ABI changes is happy with it, I am too.
>>
>> It would be nice if you could add some comments to the new struct
>> definitions saying what the various fields mean (e.g. when the event
>> triggers and what the fields will contain).
>
> Ack, will do!
>
>>
>> One nit in the patch itself:
>>
>>> @@ -592,13 +592,12 @@ int main(int argc, char *argv[])
>>> }
>>>
>>>
>>> - rsp.gfn = req.gfn;
>>> - rsp.p2mt = req.p2mt;
>>> + rsp.mem_access_event.gfn = req.mem_access_event.gfn;
>>
>> You're dropping a p2mt update here. Is that an oversight?
>> With the obvious equivalent update inserted,
>
> No, it is not. That field is only used by mem_sharing and mem_paging,
> not by mem_access.
Ah, I stand corrected. I've checked agains my original patch, but the
series also separates the mentioned areas.
Sorry for the noise,
Razvan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 3/8] xen/mem_paging: Convert mem_event_op to mem_paging_op
2015-01-18 15:17 ` [RFC PATCH V2 3/8] xen/mem_paging: Convert mem_event_op to mem_paging_op Tamas K Lengyel
@ 2015-01-22 13:03 ` Tim Deegan
2015-01-22 15:09 ` Jan Beulich
1 sibling, 0 replies; 53+ messages in thread
From: Tim Deegan @ 2015-01-22 13:03 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, eddie.dong, ian.jackson, xen-devel, andres,
jbeulich, rshriram, keir, dgdegra, yanghy
At 16:17 +0100 on 18 Jan (1421594276), Tamas K Lengyel wrote:
> The only use-case of the mem_event_op structure had been in mem_paging,
> thus renaming the structure mem_paging_op and relocating its associated
> functions clarifies its actual usage.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
Acked-by: Tim Deegan <tim@xen.org>
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 4/8] x86/hvm: rename hvm_memory_event_* functions to hvm_event_*
2015-01-18 15:17 ` [RFC PATCH V2 4/8] x86/hvm: rename hvm_memory_event_* functions to hvm_event_* Tamas K Lengyel
@ 2015-01-22 13:05 ` Tim Deegan
2015-01-22 15:56 ` Andrew Cooper
1 sibling, 0 replies; 53+ messages in thread
From: Tim Deegan @ 2015-01-22 13:05 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, eddie.dong, ian.jackson, xen-devel, andres,
jbeulich, rshriram, keir, dgdegra, yanghy
At 16:17 +0100 on 18 Jan (1421594277), Tamas K Lengyel wrote:
> The function names currently imply that these events are to be delivered via
> the memory_event subsystem. However, the naming is confusing as these events
> have nothing to do with actual memory events. Simply naming these functions
> hvm_event_* more accurately describe their usage.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
Acked-by: Tim Deegan <tim@xen.org>
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-22 12:50 ` Tamas K Lengyel
2015-01-22 12:53 ` Razvan Cojocaru
@ 2015-01-22 13:11 ` Tim Deegan
1 sibling, 0 replies; 53+ messages in thread
From: Tim Deegan @ 2015-01-22 13:11 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: Tian, Kevin, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Jun Nakajima, Dong, Eddie, Ian Jackson,
xen-devel, Andres Lagar-Cavilla, Jan Beulich, rshriram,
Keir Fraser, Daniel De Graaf, yanghy
At 13:50 +0100 on 22 Jan (1421931059), Tamas K Lengyel wrote:
> On Thu, Jan 22, 2015 at 1:43 PM, Tim Deegan <tim@xen.org> wrote:
> >> - rsp.gfn = req.gfn;
> >> - rsp.p2mt = req.p2mt;
> >> + rsp.mem_access_event.gfn = req.mem_access_event.gfn;
> >
> > You're dropping a p2mt update here. Is that an oversight?
> > With the obvious equivalent update inserted,
>
> No, it is not. That field is only used by mem_sharing and mem_paging,
> not by mem_access.
I see - the field doesn't exist any more, and was never populated
before. That's OK then. :)
Tim.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'
2015-01-22 12:53 ` Tim Deegan
@ 2015-01-22 14:12 ` Tamas K Lengyel
0 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-22 14:12 UTC (permalink / raw)
To: Tim Deegan
Cc: Tian, Kevin, wei.liu2, Ian Campbell, Stefano Stabellini,
Jun Nakajima, Dong, Eddie, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jan Beulich, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 1:53 PM, Tim Deegan <tim@xen.org> wrote:
> At 16:17 +0100 on 18 Jan (1421594275), Tamas K Lengyel wrote:
>> The name of the ring still implies it is used only for memory accesses,
>> which is no longer the case. It is also used to deliver variuos HVM events,
>> thus the name "monitor" is more appropriate in this setting.
>>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
>
> Renaming the ring seems good (again assuming everyone is happy about
> making these API changes). However I think you need to rework the
> public header comment a bit more than just s/access/monitor/. The
> operation is to set up the event ring but almost all the comments is
> about the access permissions system. It needs a description that
> would be useful to a developer who didn't already know how all thses
> systems worked. :)
Ack, will describe it a bit better!
Tamas
>
> Cheers,
>
> Tim.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 5/8] xen/mem_event: Rename mem_event to vm_event
2015-01-18 15:17 ` [RFC PATCH V2 5/8] xen/mem_event: Rename mem_event to vm_event Tamas K Lengyel
@ 2015-01-22 14:52 ` Tim Deegan
2015-01-22 15:02 ` Tamas K Lengyel
0 siblings, 1 reply; 53+ messages in thread
From: Tim Deegan @ 2015-01-22 14:52 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, eddie.dong, ian.jackson, xen-devel, andres,
jbeulich, rshriram, keir, dgdegra, yanghy
At 16:17 +0100 on 18 Jan (1421594278), Tamas K Lengyel wrote:
> The mem_event system has originally been used to deliver memory event
> related information to helper programs located in a domain. However,
> the usage of this sub-system have since been expanded to include non-memory
> related events as well, such as register changes, debugging and singlestepping.
> Therefore, renaming the system "vm_event" more accurately describes the actual
> usage of the subsystem.
>
> In this patch I also clear up the ambiguities that resulted from the interchanged
> mem_event and mem_access terminology.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
This patch is pretty much unreviewable in that it is both renames and
edits files, but I'm OK with the general intent. I see Andrew's
already suggested some git runes to handle the rename better.
Cheers,
Tim.
> ---
> tools/libxc/Makefile | 2 +-
> tools/libxc/xc_mem_access.c | 10 +-
> tools/libxc/xc_mem_event.c | 162 --------
> tools/libxc/xc_mem_paging.c | 12 +-
> tools/libxc/xc_memshr.c | 12 +-
> tools/libxc/xc_private.h | 6 +-
> tools/libxc/xc_vm_event.c | 162 ++++++++
> tools/tests/xen-access/xen-access.c | 104 ++---
> tools/xenpaging/pagein.c | 2 +-
> tools/xenpaging/xenpaging.c | 118 +++---
> tools/xenpaging/xenpaging.h | 8 +-
> xen/arch/x86/domain.c | 2 +-
> xen/arch/x86/domctl.c | 4 +-
> xen/arch/x86/hvm/emulate.c | 4 +-
> xen/arch/x86/hvm/hvm.c | 44 +--
> xen/arch/x86/hvm/vmx/vmcs.c | 4 +-
> xen/arch/x86/mm/hap/nested_ept.c | 4 +-
> xen/arch/x86/mm/hap/nested_hap.c | 4 +-
> xen/arch/x86/mm/mem_paging.c | 4 +-
> xen/arch/x86/mm/mem_sharing.c | 28 +-
> xen/arch/x86/mm/p2m-pod.c | 4 +-
> xen/arch/x86/mm/p2m-pt.c | 4 +-
> xen/arch/x86/mm/p2m.c | 94 ++---
> xen/arch/x86/x86_64/compat/mm.c | 6 +-
> xen/arch/x86/x86_64/mm.c | 7 +-
> xen/common/Makefile | 2 +-
> xen/common/domain.c | 12 +-
> xen/common/domctl.c | 6 +-
> xen/common/mem_access.c | 24 +-
> xen/common/mem_event.c | 742 ------------------------------------
> xen/common/vm_event.c | 742 ++++++++++++++++++++++++++++++++++++
> xen/drivers/passthrough/pci.c | 2 +-
> xen/include/Makefile | 2 +-
> xen/include/asm-arm/p2m.h | 6 +-
> xen/include/asm-x86/domain.h | 4 +-
> xen/include/asm-x86/hvm/emulate.h | 2 +-
> xen/include/asm-x86/p2m.h | 16 +-
> xen/include/public/domctl.h | 42 +-
> xen/include/public/mem_event.h | 197 ----------
> xen/include/public/vm_event.h | 197 ++++++++++
> xen/include/xen/mem_access.h | 4 +-
> xen/include/xen/mem_event.h | 143 -------
> xen/include/xen/p2m-common.h | 4 +-
> xen/include/xen/sched.h | 26 +-
> xen/include/xen/vm_event.h | 143 +++++++
> xen/include/xsm/dummy.h | 4 +-
> xen/include/xsm/xsm.h | 12 +-
> xen/xsm/dummy.c | 4 +-
> xen/xsm/flask/hooks.c | 16 +-
> xen/xsm/flask/policy/access_vectors | 2 +-
> 50 files changed, 1580 insertions(+), 1585 deletions(-)
> delete mode 100644 tools/libxc/xc_mem_event.c
> create mode 100644 tools/libxc/xc_vm_event.c
> delete mode 100644 xen/common/mem_event.c
> create mode 100644 xen/common/vm_event.c
> delete mode 100644 xen/include/public/mem_event.h
> create mode 100644 xen/include/public/vm_event.h
> delete mode 100644 xen/include/xen/mem_event.h
> create mode 100644 xen/include/xen/vm_event.h
>
> diff --git a/tools/libxc/Makefile b/tools/libxc/Makefile
> index bd2ca6c..6ef17ec 100644
> --- a/tools/libxc/Makefile
> +++ b/tools/libxc/Makefile
> @@ -26,7 +26,7 @@ CTRL_SRCS-y += xc_pm.c
> CTRL_SRCS-y += xc_cpu_hotplug.c
> CTRL_SRCS-y += xc_resume.c
> CTRL_SRCS-y += xc_tmem.c
> -CTRL_SRCS-y += xc_mem_event.c
> +CTRL_SRCS-y += xc_vm_event.c
> CTRL_SRCS-y += xc_mem_paging.c
> CTRL_SRCS-y += xc_mem_access.c
> CTRL_SRCS-y += xc_memshr.c
> diff --git a/tools/libxc/xc_mem_access.c b/tools/libxc/xc_mem_access.c
> index 1c979ed..80f4e2d 100644
> --- a/tools/libxc/xc_mem_access.c
> +++ b/tools/libxc/xc_mem_access.c
> @@ -26,22 +26,22 @@
>
> void *xc_mem_access_enable(xc_interface *xch, domid_t domain_id, uint32_t *port)
> {
> - return xc_mem_event_enable(xch, domain_id, HVM_PARAM_MONITOR_RING_PFN,
> + return xc_vm_event_enable(xch, domain_id, HVM_PARAM_MONITOR_RING_PFN,
> port, 0);
> }
>
> void *xc_mem_access_enable_introspection(xc_interface *xch, domid_t domain_id,
> uint32_t *port)
> {
> - return xc_mem_event_enable(xch, domain_id, HVM_PARAM_MONITOR_RING_PFN,
> + return xc_vm_event_enable(xch, domain_id, HVM_PARAM_MONITOR_RING_PFN,
> port, 1);
> }
>
> int xc_mem_access_disable(xc_interface *xch, domid_t domain_id)
> {
> - return xc_mem_event_control(xch, domain_id,
> - XEN_DOMCTL_MEM_EVENT_OP_MONITOR_DISABLE,
> - XEN_DOMCTL_MEM_EVENT_OP_MONITOR,
> + return xc_vm_event_control(xch, domain_id,
> + XEN_DOMCTL_VM_EVENT_OP_MONITOR_DISABLE,
> + XEN_DOMCTL_VM_EVENT_OP_MONITOR,
> NULL);
> }
>
> diff --git a/tools/libxc/xc_mem_event.c b/tools/libxc/xc_mem_event.c
> deleted file mode 100644
> index a5e0948..0000000
> --- a/tools/libxc/xc_mem_event.c
> +++ /dev/null
> @@ -1,162 +0,0 @@
> -/******************************************************************************
> - *
> - * xc_mem_event.c
> - *
> - * Interface to low-level memory event functionality.
> - *
> - * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp)
> - *
> - * This library is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU Lesser General Public
> - * License as published by the Free Software Foundation; either
> - * version 2.1 of the License, or (at your option) any later version.
> - *
> - * This library is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> - * Lesser General Public License for more details.
> - *
> - * You should have received a copy of the GNU Lesser General Public
> - * License along with this library; if not, write to the Free Software
> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> - */
> -
> -#include "xc_private.h"
> -
> -int xc_mem_event_control(xc_interface *xch, domid_t domain_id, unsigned int op,
> - unsigned int mode, uint32_t *port)
> -{
> - DECLARE_DOMCTL;
> - int rc;
> -
> - domctl.cmd = XEN_DOMCTL_mem_event_op;
> - domctl.domain = domain_id;
> - domctl.u.mem_event_op.op = op;
> - domctl.u.mem_event_op.mode = mode;
> -
> - rc = do_domctl(xch, &domctl);
> - if ( !rc && port )
> - *port = domctl.u.mem_event_op.port;
> - return rc;
> -}
> -
> -void *xc_mem_event_enable(xc_interface *xch, domid_t domain_id, int param,
> - uint32_t *port, int enable_introspection)
> -{
> - void *ring_page = NULL;
> - uint64_t pfn;
> - xen_pfn_t ring_pfn, mmap_pfn;
> - unsigned int op, mode;
> - int rc1, rc2, saved_errno;
> -
> - if ( !port )
> - {
> - errno = EINVAL;
> - return NULL;
> - }
> -
> - /* Pause the domain for ring page setup */
> - rc1 = xc_domain_pause(xch, domain_id);
> - if ( rc1 != 0 )
> - {
> - PERROR("Unable to pause domain\n");
> - return NULL;
> - }
> -
> - /* Get the pfn of the ring page */
> - rc1 = xc_hvm_param_get(xch, domain_id, param, &pfn);
> - if ( rc1 != 0 )
> - {
> - PERROR("Failed to get pfn of ring page\n");
> - goto out;
> - }
> -
> - ring_pfn = pfn;
> - mmap_pfn = pfn;
> - ring_page = xc_map_foreign_batch(xch, domain_id, PROT_READ | PROT_WRITE,
> - &mmap_pfn, 1);
> - if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
> - {
> - /* Map failed, populate ring page */
> - rc1 = xc_domain_populate_physmap_exact(xch, domain_id, 1, 0, 0,
> - &ring_pfn);
> - if ( rc1 != 0 )
> - {
> - PERROR("Failed to populate ring pfn\n");
> - goto out;
> - }
> -
> - mmap_pfn = ring_pfn;
> - ring_page = xc_map_foreign_batch(xch, domain_id, PROT_READ | PROT_WRITE,
> - &mmap_pfn, 1);
> - if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
> - {
> - PERROR("Could not map the ring page\n");
> - goto out;
> - }
> - }
> -
> - switch ( param )
> - {
> - case HVM_PARAM_PAGING_RING_PFN:
> - op = XEN_DOMCTL_MEM_EVENT_OP_PAGING_ENABLE;
> - mode = XEN_DOMCTL_MEM_EVENT_OP_PAGING;
> - break;
> -
> - case HVM_PARAM_MONITOR_RING_PFN:
> - if ( enable_introspection )
> - op = XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION;
> - else
> - op = XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE;
> - mode = XEN_DOMCTL_MEM_EVENT_OP_MONITOR;
> - break;
> -
> - case HVM_PARAM_SHARING_RING_PFN:
> - op = XEN_DOMCTL_MEM_EVENT_OP_SHARING_ENABLE;
> - mode = XEN_DOMCTL_MEM_EVENT_OP_SHARING;
> - break;
> -
> - /*
> - * This is for the outside chance that the HVM_PARAM is valid but is invalid
> - * as far as mem_event goes.
> - */
> - default:
> - errno = EINVAL;
> - rc1 = -1;
> - goto out;
> - }
> -
> - rc1 = xc_mem_event_control(xch, domain_id, op, mode, port);
> - if ( rc1 != 0 )
> - {
> - PERROR("Failed to enable mem_event\n");
> - goto out;
> - }
> -
> - /* Remove the ring_pfn from the guest's physmap */
> - rc1 = xc_domain_decrease_reservation_exact(xch, domain_id, 1, 0, &ring_pfn);
> - if ( rc1 != 0 )
> - PERROR("Failed to remove ring page from guest physmap");
> -
> - out:
> - saved_errno = errno;
> -
> - rc2 = xc_domain_unpause(xch, domain_id);
> - if ( rc1 != 0 || rc2 != 0 )
> - {
> - if ( rc2 != 0 )
> - {
> - if ( rc1 == 0 )
> - saved_errno = errno;
> - PERROR("Unable to unpause domain");
> - }
> -
> - if ( ring_page )
> - munmap(ring_page, XC_PAGE_SIZE);
> - ring_page = NULL;
> -
> - errno = saved_errno;
> - }
> -
> - return ring_page;
> -}
> diff --git a/tools/libxc/xc_mem_paging.c b/tools/libxc/xc_mem_paging.c
> index bf3173d..8408b07 100644
> --- a/tools/libxc/xc_mem_paging.c
> +++ b/tools/libxc/xc_mem_paging.c
> @@ -47,17 +47,17 @@ int xc_mem_paging_enable(xc_interface *xch, domid_t domain_id,
> return -1;
> }
>
> - return xc_mem_event_control(xch, domain_id,
> - XEN_DOMCTL_MEM_EVENT_OP_PAGING_ENABLE,
> - XEN_DOMCTL_MEM_EVENT_OP_PAGING,
> + return xc_vm_event_control(xch, domain_id,
> + XEN_DOMCTL_VM_EVENT_OP_PAGING_ENABLE,
> + XEN_DOMCTL_VM_EVENT_OP_PAGING,
> port);
> }
>
> int xc_mem_paging_disable(xc_interface *xch, domid_t domain_id)
> {
> - return xc_mem_event_control(xch, domain_id,
> - XEN_DOMCTL_MEM_EVENT_OP_PAGING_DISABLE,
> - XEN_DOMCTL_MEM_EVENT_OP_PAGING,
> + return xc_vm_event_control(xch, domain_id,
> + XEN_DOMCTL_VM_EVENT_OP_PAGING_DISABLE,
> + XEN_DOMCTL_VM_EVENT_OP_PAGING,
> NULL);
> }
>
> diff --git a/tools/libxc/xc_memshr.c b/tools/libxc/xc_memshr.c
> index d6a9539..fafa073 100644
> --- a/tools/libxc/xc_memshr.c
> +++ b/tools/libxc/xc_memshr.c
> @@ -52,18 +52,18 @@ int xc_memshr_ring_enable(xc_interface *xch,
> return -1;
> }
>
> - return xc_mem_event_control(xch, domid,
> - XEN_DOMCTL_MEM_EVENT_OP_SHARING_ENABLE,
> - XEN_DOMCTL_MEM_EVENT_OP_SHARING,
> + return xc_vm_event_control(xch, domid,
> + XEN_DOMCTL_VM_EVENT_OP_SHARING_ENABLE,
> + XEN_DOMCTL_VM_EVENT_OP_SHARING,
> port);
> }
>
> int xc_memshr_ring_disable(xc_interface *xch,
> domid_t domid)
> {
> - return xc_mem_event_control(xch, domid,
> - XEN_DOMCTL_MEM_EVENT_OP_SHARING_DISABLE,
> - XEN_DOMCTL_MEM_EVENT_OP_SHARING,
> + return xc_vm_event_control(xch, domid,
> + XEN_DOMCTL_VM_EVENT_OP_SHARING_DISABLE,
> + XEN_DOMCTL_VM_EVENT_OP_SHARING,
> NULL);
> }
>
> diff --git a/tools/libxc/xc_private.h b/tools/libxc/xc_private.h
> index f1f601c..a539300 100644
> --- a/tools/libxc/xc_private.h
> +++ b/tools/libxc/xc_private.h
> @@ -421,15 +421,15 @@ int xc_ffs64(uint64_t x);
> #define DOMPRINTF_CALLED(xch) xc_dom_printf((xch), "%s: called", __FUNCTION__)
>
> /**
> - * mem_event operations. Internal use only.
> + * vm_event operations. Internal use only.
> */
> -int xc_mem_event_control(xc_interface *xch, domid_t domain_id, unsigned int op,
> +int xc_vm_event_control(xc_interface *xch, domid_t domain_id, unsigned int op,
> unsigned int mode, uint32_t *port);
> /*
> * Enables mem_event and returns the mapped ring page indicated by param.
> * param can be HVM_PARAM_PAGING/ACCESS/SHARING_RING_PFN
> */
> -void *xc_mem_event_enable(xc_interface *xch, domid_t domain_id, int param,
> +void *xc_vm_event_enable(xc_interface *xch, domid_t domain_id, int param,
> uint32_t *port, int enable_introspection);
>
> #endif /* __XC_PRIVATE_H__ */
> diff --git a/tools/libxc/xc_vm_event.c b/tools/libxc/xc_vm_event.c
> new file mode 100644
> index 0000000..39d794d
> --- /dev/null
> +++ b/tools/libxc/xc_vm_event.c
> @@ -0,0 +1,162 @@
> +/******************************************************************************
> + *
> + * xc_vm_event.c
> + *
> + * Interface to low-level VM event functionality.
> + *
> + * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp)
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +
> +#include "xc_private.h"
> +
> +int xc_vm_event_control(xc_interface *xch, domid_t domain_id, unsigned int op,
> + unsigned int mode, uint32_t *port)
> +{
> + DECLARE_DOMCTL;
> + int rc;
> +
> + domctl.cmd = XEN_DOMCTL_vm_event_op;
> + domctl.domain = domain_id;
> + domctl.u.vm_event_op.op = op;
> + domctl.u.vm_event_op.mode = mode;
> +
> + rc = do_domctl(xch, &domctl);
> + if ( !rc && port )
> + *port = domctl.u.vm_event_op.port;
> + return rc;
> +}
> +
> +void *xc_vm_event_enable(xc_interface *xch, domid_t domain_id, int param,
> + uint32_t *port, int enable_introspection)
> +{
> + void *ring_page = NULL;
> + uint64_t pfn;
> + xen_pfn_t ring_pfn, mmap_pfn;
> + unsigned int op, mode;
> + int rc1, rc2, saved_errno;
> +
> + if ( !port )
> + {
> + errno = EINVAL;
> + return NULL;
> + }
> +
> + /* Pause the domain for ring page setup */
> + rc1 = xc_domain_pause(xch, domain_id);
> + if ( rc1 != 0 )
> + {
> + PERROR("Unable to pause domain\n");
> + return NULL;
> + }
> +
> + /* Get the pfn of the ring page */
> + rc1 = xc_hvm_param_get(xch, domain_id, param, &pfn);
> + if ( rc1 != 0 )
> + {
> + PERROR("Failed to get pfn of ring page\n");
> + goto out;
> + }
> +
> + ring_pfn = pfn;
> + mmap_pfn = pfn;
> + ring_page = xc_map_foreign_batch(xch, domain_id, PROT_READ | PROT_WRITE,
> + &mmap_pfn, 1);
> + if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
> + {
> + /* Map failed, populate ring page */
> + rc1 = xc_domain_populate_physmap_exact(xch, domain_id, 1, 0, 0,
> + &ring_pfn);
> + if ( rc1 != 0 )
> + {
> + PERROR("Failed to populate ring pfn\n");
> + goto out;
> + }
> +
> + mmap_pfn = ring_pfn;
> + ring_page = xc_map_foreign_batch(xch, domain_id, PROT_READ | PROT_WRITE,
> + &mmap_pfn, 1);
> + if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
> + {
> + PERROR("Could not map the ring page\n");
> + goto out;
> + }
> + }
> +
> + switch ( param )
> + {
> + case HVM_PARAM_PAGING_RING_PFN:
> + op = XEN_DOMCTL_VM_EVENT_OP_PAGING_ENABLE;
> + mode = XEN_DOMCTL_VM_EVENT_OP_PAGING;
> + break;
> +
> + case HVM_PARAM_MONITOR_RING_PFN:
> + if ( enable_introspection )
> + op = XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION;
> + else
> + op = XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE;
> + mode = XEN_DOMCTL_VM_EVENT_OP_MONITOR;
> + break;
> +
> + case HVM_PARAM_SHARING_RING_PFN:
> + op = XEN_DOMCTL_VM_EVENT_OP_SHARING_ENABLE;
> + mode = XEN_DOMCTL_VM_EVENT_OP_SHARING;
> + break;
> +
> + /*
> + * This is for the outside chance that the HVM_PARAM is valid but is invalid
> + * as far as vm_event goes.
> + */
> + default:
> + errno = EINVAL;
> + rc1 = -1;
> + goto out;
> + }
> +
> + rc1 = xc_vm_event_control(xch, domain_id, op, mode, port);
> + if ( rc1 != 0 )
> + {
> + PERROR("Failed to enable vm_event\n");
> + goto out;
> + }
> +
> + /* Remove the ring_pfn from the guest's physmap */
> + rc1 = xc_domain_decrease_reservation_exact(xch, domain_id, 1, 0, &ring_pfn);
> + if ( rc1 != 0 )
> + PERROR("Failed to remove ring page from guest physmap");
> +
> + out:
> + saved_errno = errno;
> +
> + rc2 = xc_domain_unpause(xch, domain_id);
> + if ( rc1 != 0 || rc2 != 0 )
> + {
> + if ( rc2 != 0 )
> + {
> + if ( rc1 == 0 )
> + saved_errno = errno;
> + PERROR("Unable to unpause domain");
> + }
> +
> + if ( ring_page )
> + munmap(ring_page, XC_PAGE_SIZE);
> + ring_page = NULL;
> +
> + errno = saved_errno;
> + }
> +
> + return ring_page;
> +}
> diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c
> index 9d53fb3..3538323 100644
> --- a/tools/tests/xen-access/xen-access.c
> +++ b/tools/tests/xen-access/xen-access.c
> @@ -39,7 +39,7 @@
> #include <sys/poll.h>
>
> #include <xenctrl.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
>
> #define DPRINTF(a, b...) fprintf(stderr, a, ## b)
> #define ERROR(a, b...) fprintf(stderr, a "\n", ## b)
> @@ -91,26 +91,26 @@ static inline int spin_trylock(spinlock_t *lock)
> return !test_and_set_bit(1, lock);
> }
>
> -#define mem_event_ring_lock_init(_m) spin_lock_init(&(_m)->ring_lock)
> -#define mem_event_ring_lock(_m) spin_lock(&(_m)->ring_lock)
> -#define mem_event_ring_unlock(_m) spin_unlock(&(_m)->ring_lock)
> +#define vm_event_ring_lock_init(_m) spin_lock_init(&(_m)->ring_lock)
> +#define vm_event_ring_lock(_m) spin_lock(&(_m)->ring_lock)
> +#define vm_event_ring_unlock(_m) spin_unlock(&(_m)->ring_lock)
>
> -typedef struct mem_event {
> +typedef struct vm_event {
> domid_t domain_id;
> xc_evtchn *xce_handle;
> int port;
> - mem_event_back_ring_t back_ring;
> + vm_event_back_ring_t back_ring;
> uint32_t evtchn_port;
> void *ring_page;
> spinlock_t ring_lock;
> -} mem_event_t;
> +} vm_event_t;
>
> typedef struct xenaccess {
> xc_interface *xc_handle;
>
> xc_domaininfo_t *domain_info;
>
> - mem_event_t mem_event;
> + vm_event_t vm_event;
> } xenaccess_t;
>
> static int interrupted;
> @@ -170,13 +170,13 @@ int xenaccess_teardown(xc_interface *xch, xenaccess_t *xenaccess)
> return 0;
>
> /* Tear down domain xenaccess in Xen */
> - if ( xenaccess->mem_event.ring_page )
> - munmap(xenaccess->mem_event.ring_page, XC_PAGE_SIZE);
> + if ( xenaccess->vm_event.ring_page )
> + munmap(xenaccess->vm_event.ring_page, XC_PAGE_SIZE);
>
> if ( mem_access_enable )
> {
> rc = xc_mem_access_disable(xenaccess->xc_handle,
> - xenaccess->mem_event.domain_id);
> + xenaccess->vm_event.domain_id);
> if ( rc != 0 )
> {
> ERROR("Error tearing down domain xenaccess in xen");
> @@ -186,8 +186,8 @@ int xenaccess_teardown(xc_interface *xch, xenaccess_t *xenaccess)
> /* Unbind VIRQ */
> if ( evtchn_bind )
> {
> - rc = xc_evtchn_unbind(xenaccess->mem_event.xce_handle,
> - xenaccess->mem_event.port);
> + rc = xc_evtchn_unbind(xenaccess->vm_event.xce_handle,
> + xenaccess->vm_event.port);
> if ( rc != 0 )
> {
> ERROR("Error unbinding event port");
> @@ -197,7 +197,7 @@ int xenaccess_teardown(xc_interface *xch, xenaccess_t *xenaccess)
> /* Close event channel */
> if ( evtchn_open )
> {
> - rc = xc_evtchn_close(xenaccess->mem_event.xce_handle);
> + rc = xc_evtchn_close(xenaccess->vm_event.xce_handle);
> if ( rc != 0 )
> {
> ERROR("Error closing event channel");
> @@ -239,17 +239,17 @@ xenaccess_t *xenaccess_init(xc_interface **xch_r, domid_t domain_id)
> xenaccess->xc_handle = xch;
>
> /* Set domain id */
> - xenaccess->mem_event.domain_id = domain_id;
> + xenaccess->vm_event.domain_id = domain_id;
>
> /* Initialise lock */
> - mem_event_ring_lock_init(&xenaccess->mem_event);
> + vm_event_ring_lock_init(&xenaccess->vm_event);
>
> /* Enable mem_access */
> - xenaccess->mem_event.ring_page =
> + xenaccess->vm_event.ring_page =
> xc_mem_access_enable(xenaccess->xc_handle,
> - xenaccess->mem_event.domain_id,
> - &xenaccess->mem_event.evtchn_port);
> - if ( xenaccess->mem_event.ring_page == NULL )
> + xenaccess->vm_event.domain_id,
> + &xenaccess->vm_event.evtchn_port);
> + if ( xenaccess->vm_event.ring_page == NULL )
> {
> switch ( errno ) {
> case EBUSY:
> @@ -267,8 +267,8 @@ xenaccess_t *xenaccess_init(xc_interface **xch_r, domid_t domain_id)
> mem_access_enable = 1;
>
> /* Open event channel */
> - xenaccess->mem_event.xce_handle = xc_evtchn_open(NULL, 0);
> - if ( xenaccess->mem_event.xce_handle == NULL )
> + xenaccess->vm_event.xce_handle = xc_evtchn_open(NULL, 0);
> + if ( xenaccess->vm_event.xce_handle == NULL )
> {
> ERROR("Failed to open event channel");
> goto err;
> @@ -276,21 +276,21 @@ xenaccess_t *xenaccess_init(xc_interface **xch_r, domid_t domain_id)
> evtchn_open = 1;
>
> /* Bind event notification */
> - rc = xc_evtchn_bind_interdomain(xenaccess->mem_event.xce_handle,
> - xenaccess->mem_event.domain_id,
> - xenaccess->mem_event.evtchn_port);
> + rc = xc_evtchn_bind_interdomain(xenaccess->vm_event.xce_handle,
> + xenaccess->vm_event.domain_id,
> + xenaccess->vm_event.evtchn_port);
> if ( rc < 0 )
> {
> ERROR("Failed to bind event channel");
> goto err;
> }
> evtchn_bind = 1;
> - xenaccess->mem_event.port = rc;
> + xenaccess->vm_event.port = rc;
>
> /* Initialise ring */
> - SHARED_RING_INIT((mem_event_sring_t *)xenaccess->mem_event.ring_page);
> - BACK_RING_INIT(&xenaccess->mem_event.back_ring,
> - (mem_event_sring_t *)xenaccess->mem_event.ring_page,
> + SHARED_RING_INIT((vm_event_sring_t *)xenaccess->vm_event.ring_page);
> + BACK_RING_INIT(&xenaccess->vm_event.back_ring,
> + (vm_event_sring_t *)xenaccess->vm_event.ring_page,
> XC_PAGE_SIZE);
>
> /* Get domaininfo */
> @@ -320,14 +320,14 @@ xenaccess_t *xenaccess_init(xc_interface **xch_r, domid_t domain_id)
> return NULL;
> }
>
> -int get_request(mem_event_t *mem_event, mem_event_request_t *req)
> +int get_request(vm_event_t *vm_event, vm_event_request_t *req)
> {
> - mem_event_back_ring_t *back_ring;
> + vm_event_back_ring_t *back_ring;
> RING_IDX req_cons;
>
> - mem_event_ring_lock(mem_event);
> + vm_event_ring_lock(vm_event);
>
> - back_ring = &mem_event->back_ring;
> + back_ring = &vm_event->back_ring;
> req_cons = back_ring->req_cons;
>
> /* Copy request */
> @@ -338,19 +338,19 @@ int get_request(mem_event_t *mem_event, mem_event_request_t *req)
> back_ring->req_cons = req_cons;
> back_ring->sring->req_event = req_cons + 1;
>
> - mem_event_ring_unlock(mem_event);
> + vm_event_ring_unlock(vm_event);
>
> return 0;
> }
>
> -static int put_response(mem_event_t *mem_event, mem_event_response_t *rsp)
> +static int put_response(vm_event_t *vm_event, vm_event_response_t *rsp)
> {
> - mem_event_back_ring_t *back_ring;
> + vm_event_back_ring_t *back_ring;
> RING_IDX rsp_prod;
>
> - mem_event_ring_lock(mem_event);
> + vm_event_ring_lock(vm_event);
>
> - back_ring = &mem_event->back_ring;
> + back_ring = &vm_event->back_ring;
> rsp_prod = back_ring->rsp_prod_pvt;
>
> /* Copy response */
> @@ -361,24 +361,24 @@ static int put_response(mem_event_t *mem_event, mem_event_response_t *rsp)
> back_ring->rsp_prod_pvt = rsp_prod;
> RING_PUSH_RESPONSES(back_ring);
>
> - mem_event_ring_unlock(mem_event);
> + vm_event_ring_unlock(vm_event);
>
> return 0;
> }
>
> -static int xenaccess_resume_page(xenaccess_t *paging, mem_event_response_t *rsp)
> +static int xenaccess_resume_page(xenaccess_t *paging, vm_event_response_t *rsp)
> {
> int ret;
>
> /* Put the page info on the ring */
> - ret = put_response(&paging->mem_event, rsp);
> + ret = put_response(&paging->vm_event, rsp);
> if ( ret != 0 )
> goto out;
>
> /* Tell Xen page is ready */
> - ret = xc_mem_access_resume(paging->xc_handle, paging->mem_event.domain_id);
> - ret = xc_evtchn_notify(paging->mem_event.xce_handle,
> - paging->mem_event.port);
> + ret = xc_mem_access_resume(paging->xc_handle, paging->vm_event.domain_id);
> + ret = xc_evtchn_notify(paging->vm_event.xce_handle,
> + paging->vm_event.port);
>
> out:
> return ret;
> @@ -400,8 +400,8 @@ int main(int argc, char *argv[])
> struct sigaction act;
> domid_t domain_id;
> xenaccess_t *xenaccess;
> - mem_event_request_t req;
> - mem_event_response_t rsp;
> + vm_event_request_t req;
> + vm_event_response_t rsp;
> int rc = -1;
> int rc1;
> xc_interface *xch;
> @@ -507,7 +507,7 @@ int main(int argc, char *argv[])
> rc = xc_hvm_param_set(xch, domain_id, HVM_PARAM_MEMORY_EVENT_INT3, HVMPME_mode_disabled);
> if ( rc < 0 )
> {
> - ERROR("Error %d setting int3 mem_event\n", rc);
> + ERROR("Error %d setting int3 vm_event\n", rc);
> goto exit;
> }
>
> @@ -527,7 +527,7 @@ int main(int argc, char *argv[])
> shutting_down = 1;
> }
>
> - rc = xc_wait_for_event_or_timeout(xch, xenaccess->mem_event.xce_handle, 100);
> + rc = xc_wait_for_event_or_timeout(xch, xenaccess->vm_event.xce_handle, 100);
> if ( rc < -1 )
> {
> ERROR("Error getting event");
> @@ -539,11 +539,11 @@ int main(int argc, char *argv[])
> DPRINTF("Got event from Xen\n");
> }
>
> - while ( RING_HAS_UNCONSUMED_REQUESTS(&xenaccess->mem_event.back_ring) )
> + while ( RING_HAS_UNCONSUMED_REQUESTS(&xenaccess->vm_event.back_ring) )
> {
> xenmem_access_t access;
>
> - rc = get_request(&xenaccess->mem_event, &req);
> + rc = get_request(&xenaccess->vm_event, &req);
> if ( rc != 0 )
> {
> ERROR("Error getting request");
> @@ -556,7 +556,7 @@ int main(int argc, char *argv[])
> rsp.flags = req.flags;
>
> switch (req.reason) {
> - case MEM_EVENT_REASON_MEM_ACCESS_VIOLATION:
> + case VM_EVENT_REASON_MEM_ACCESS_VIOLATION:
> rc = xc_get_mem_access(xch, domain_id, req.mem_access_event.gfn, &access);
> if (rc < 0)
> {
> @@ -594,7 +594,7 @@ int main(int argc, char *argv[])
>
> rsp.mem_access_event.gfn = req.mem_access_event.gfn;
> break;
> - case MEM_EVENT_REASON_INT3:
> + case VM_EVENT_REASON_INT3:
> printf("INT3: rip=%016"PRIx64", gfn=%"PRIx64" (vcpu %d)\n",
> req.int3_event.gla,
> req.int3_event.gfn,
> diff --git a/tools/xenpaging/pagein.c b/tools/xenpaging/pagein.c
> index b3bcef7..7cb0f33 100644
> --- a/tools/xenpaging/pagein.c
> +++ b/tools/xenpaging/pagein.c
> @@ -63,7 +63,7 @@ void page_in_trigger(void)
>
> void create_page_in_thread(struct xenpaging *paging)
> {
> - page_in_args.dom = paging->mem_event.domain_id;
> + page_in_args.dom = paging->vm_event.domain_id;
> page_in_args.pagein_queue = paging->pagein_queue;
> page_in_args.xch = paging->xc_handle;
> if (pthread_create(&page_in_thread, NULL, page_in, &page_in_args) == 0)
> diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c
> index 148b3e7..3031d1e 100644
> --- a/tools/xenpaging/xenpaging.c
> +++ b/tools/xenpaging/xenpaging.c
> @@ -63,7 +63,7 @@ static void close_handler(int sig)
> static void xenpaging_mem_paging_flush_ioemu_cache(struct xenpaging *paging)
> {
> struct xs_handle *xsh = paging->xs_handle;
> - domid_t domain_id = paging->mem_event.domain_id;
> + domid_t domain_id = paging->vm_event.domain_id;
> char path[80];
>
> sprintf(path, "/local/domain/0/device-model/%u/command", domain_id);
> @@ -74,7 +74,7 @@ static void xenpaging_mem_paging_flush_ioemu_cache(struct xenpaging *paging)
> static int xenpaging_wait_for_event_or_timeout(struct xenpaging *paging)
> {
> xc_interface *xch = paging->xc_handle;
> - xc_evtchn *xce = paging->mem_event.xce_handle;
> + xc_evtchn *xce = paging->vm_event.xce_handle;
> char **vec, *val;
> unsigned int num;
> struct pollfd fd[2];
> @@ -111,7 +111,7 @@ static int xenpaging_wait_for_event_or_timeout(struct xenpaging *paging)
> if ( strcmp(vec[XS_WATCH_TOKEN], watch_token) == 0 )
> {
> /* If our guest disappeared, set interrupt flag and fall through */
> - if ( xs_is_domain_introduced(paging->xs_handle, paging->mem_event.domain_id) == false )
> + if ( xs_is_domain_introduced(paging->xs_handle, paging->vm_event.domain_id) == false )
> {
> xs_unwatch(paging->xs_handle, "@releaseDomain", watch_token);
> interrupted = SIGQUIT;
> @@ -171,7 +171,7 @@ static int xenpaging_get_tot_pages(struct xenpaging *paging)
> xc_domaininfo_t domain_info;
> int rc;
>
> - rc = xc_domain_getinfolist(xch, paging->mem_event.domain_id, 1, &domain_info);
> + rc = xc_domain_getinfolist(xch, paging->vm_event.domain_id, 1, &domain_info);
> if ( rc != 1 )
> {
> PERROR("Error getting domain info");
> @@ -231,7 +231,7 @@ static int xenpaging_getopts(struct xenpaging *paging, int argc, char *argv[])
> {
> switch(ch) {
> case 'd':
> - paging->mem_event.domain_id = atoi(optarg);
> + paging->vm_event.domain_id = atoi(optarg);
> break;
> case 'f':
> filename = strdup(optarg);
> @@ -264,7 +264,7 @@ static int xenpaging_getopts(struct xenpaging *paging, int argc, char *argv[])
> }
>
> /* Set domain id */
> - if ( !paging->mem_event.domain_id )
> + if ( !paging->vm_event.domain_id )
> {
> printf("Numerical <domain_id> missing!\n");
> return 1;
> @@ -312,7 +312,7 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
> }
>
> /* write domain ID to watch so we can ignore other domain shutdowns */
> - snprintf(watch_token, sizeof(watch_token), "%u", paging->mem_event.domain_id);
> + snprintf(watch_token, sizeof(watch_token), "%u", paging->vm_event.domain_id);
> if ( xs_watch(paging->xs_handle, "@releaseDomain", watch_token) == false )
> {
> PERROR("Could not bind to shutdown watch\n");
> @@ -320,7 +320,7 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
> }
>
> /* Watch xenpagings working target */
> - dom_path = xs_get_domain_path(paging->xs_handle, paging->mem_event.domain_id);
> + dom_path = xs_get_domain_path(paging->xs_handle, paging->vm_event.domain_id);
> if ( !dom_path )
> {
> PERROR("Could not find domain path\n");
> @@ -339,17 +339,17 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
> }
>
> /* Map the ring page */
> - xc_get_hvm_param(xch, paging->mem_event.domain_id,
> + xc_get_hvm_param(xch, paging->vm_event.domain_id,
> HVM_PARAM_PAGING_RING_PFN, &ring_pfn);
> mmap_pfn = ring_pfn;
> - paging->mem_event.ring_page =
> - xc_map_foreign_batch(xch, paging->mem_event.domain_id,
> + paging->vm_event.ring_page =
> + xc_map_foreign_batch(xch, paging->vm_event.domain_id,
> PROT_READ | PROT_WRITE, &mmap_pfn, 1);
> if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
> {
> /* Map failed, populate ring page */
> rc = xc_domain_populate_physmap_exact(paging->xc_handle,
> - paging->mem_event.domain_id,
> + paging->vm_event.domain_id,
> 1, 0, 0, &ring_pfn);
> if ( rc != 0 )
> {
> @@ -358,8 +358,8 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
> }
>
> mmap_pfn = ring_pfn;
> - paging->mem_event.ring_page =
> - xc_map_foreign_batch(xch, paging->mem_event.domain_id,
> + paging->vm_event.ring_page =
> + xc_map_foreign_batch(xch, paging->vm_event.domain_id,
> PROT_READ | PROT_WRITE, &mmap_pfn, 1);
> if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
> {
> @@ -369,8 +369,8 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
> }
>
> /* Initialise Xen */
> - rc = xc_mem_paging_enable(xch, paging->mem_event.domain_id,
> - &paging->mem_event.evtchn_port);
> + rc = xc_mem_paging_enable(xch, paging->vm_event.domain_id,
> + &paging->vm_event.evtchn_port);
> if ( rc != 0 )
> {
> switch ( errno ) {
> @@ -394,40 +394,40 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
> }
>
> /* Open event channel */
> - paging->mem_event.xce_handle = xc_evtchn_open(NULL, 0);
> - if ( paging->mem_event.xce_handle == NULL )
> + paging->vm_event.xce_handle = xc_evtchn_open(NULL, 0);
> + if ( paging->vm_event.xce_handle == NULL )
> {
> PERROR("Failed to open event channel");
> goto err;
> }
>
> /* Bind event notification */
> - rc = xc_evtchn_bind_interdomain(paging->mem_event.xce_handle,
> - paging->mem_event.domain_id,
> - paging->mem_event.evtchn_port);
> + rc = xc_evtchn_bind_interdomain(paging->vm_event.xce_handle,
> + paging->vm_event.domain_id,
> + paging->vm_event.evtchn_port);
> if ( rc < 0 )
> {
> PERROR("Failed to bind event channel");
> goto err;
> }
>
> - paging->mem_event.port = rc;
> + paging->vm_event.port = rc;
>
> /* Initialise ring */
> - SHARED_RING_INIT((mem_event_sring_t *)paging->mem_event.ring_page);
> - BACK_RING_INIT(&paging->mem_event.back_ring,
> - (mem_event_sring_t *)paging->mem_event.ring_page,
> + SHARED_RING_INIT((vm_event_sring_t *)paging->vm_event.ring_page);
> + BACK_RING_INIT(&paging->vm_event.back_ring,
> + (vm_event_sring_t *)paging->vm_event.ring_page,
> PAGE_SIZE);
>
> /* Now that the ring is set, remove it from the guest's physmap */
> if ( xc_domain_decrease_reservation_exact(xch,
> - paging->mem_event.domain_id, 1, 0, &ring_pfn) )
> + paging->vm_event.domain_id, 1, 0, &ring_pfn) )
> PERROR("Failed to remove ring from guest physmap");
>
> /* Get max_pages from guest if not provided via cmdline */
> if ( !paging->max_pages )
> {
> - rc = xc_domain_getinfolist(xch, paging->mem_event.domain_id, 1,
> + rc = xc_domain_getinfolist(xch, paging->vm_event.domain_id, 1,
> &domain_info);
> if ( rc != 1 )
> {
> @@ -497,9 +497,9 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
> free(paging->paging_buffer);
> }
>
> - if ( paging->mem_event.ring_page )
> + if ( paging->vm_event.ring_page )
> {
> - munmap(paging->mem_event.ring_page, PAGE_SIZE);
> + munmap(paging->vm_event.ring_page, PAGE_SIZE);
> }
>
> free(dom_path);
> @@ -524,28 +524,28 @@ static void xenpaging_teardown(struct xenpaging *paging)
>
> paging->xc_handle = NULL;
> /* Tear down domain paging in Xen */
> - munmap(paging->mem_event.ring_page, PAGE_SIZE);
> - rc = xc_mem_paging_disable(xch, paging->mem_event.domain_id);
> + munmap(paging->vm_event.ring_page, PAGE_SIZE);
> + rc = xc_mem_paging_disable(xch, paging->vm_event.domain_id);
> if ( rc != 0 )
> {
> PERROR("Error tearing down domain paging in xen");
> }
>
> /* Unbind VIRQ */
> - rc = xc_evtchn_unbind(paging->mem_event.xce_handle, paging->mem_event.port);
> + rc = xc_evtchn_unbind(paging->vm_event.xce_handle, paging->vm_event.port);
> if ( rc != 0 )
> {
> PERROR("Error unbinding event port");
> }
> - paging->mem_event.port = -1;
> + paging->vm_event.port = -1;
>
> /* Close event channel */
> - rc = xc_evtchn_close(paging->mem_event.xce_handle);
> + rc = xc_evtchn_close(paging->vm_event.xce_handle);
> if ( rc != 0 )
> {
> PERROR("Error closing event channel");
> }
> - paging->mem_event.xce_handle = NULL;
> + paging->vm_event.xce_handle = NULL;
>
> /* Close connection to xenstore */
> xs_close(paging->xs_handle);
> @@ -558,12 +558,12 @@ static void xenpaging_teardown(struct xenpaging *paging)
> }
> }
>
> -static void get_request(struct mem_event *mem_event, mem_event_request_t *req)
> +static void get_request(struct vm_event *vm_event, vm_event_request_t *req)
> {
> - mem_event_back_ring_t *back_ring;
> + vm_event_back_ring_t *back_ring;
> RING_IDX req_cons;
>
> - back_ring = &mem_event->back_ring;
> + back_ring = &vm_event->back_ring;
> req_cons = back_ring->req_cons;
>
> /* Copy request */
> @@ -575,12 +575,12 @@ static void get_request(struct mem_event *mem_event, mem_event_request_t *req)
> back_ring->sring->req_event = req_cons + 1;
> }
>
> -static void put_response(struct mem_event *mem_event, mem_event_response_t *rsp)
> +static void put_response(struct vm_event *vm_event, vm_event_response_t *rsp)
> {
> - mem_event_back_ring_t *back_ring;
> + vm_event_back_ring_t *back_ring;
> RING_IDX rsp_prod;
>
> - back_ring = &mem_event->back_ring;
> + back_ring = &vm_event->back_ring;
> rsp_prod = back_ring->rsp_prod_pvt;
>
> /* Copy response */
> @@ -607,7 +607,7 @@ static int xenpaging_evict_page(struct xenpaging *paging, unsigned long gfn, int
> DECLARE_DOMCTL;
>
> /* Nominate page */
> - ret = xc_mem_paging_nominate(xch, paging->mem_event.domain_id, gfn);
> + ret = xc_mem_paging_nominate(xch, paging->vm_event.domain_id, gfn);
> if ( ret < 0 )
> {
> /* unpageable gfn is indicated by EBUSY */
> @@ -619,7 +619,7 @@ static int xenpaging_evict_page(struct xenpaging *paging, unsigned long gfn, int
> }
>
> /* Map page */
> - page = xc_map_foreign_pages(xch, paging->mem_event.domain_id, PROT_READ, &victim, 1);
> + page = xc_map_foreign_pages(xch, paging->vm_event.domain_id, PROT_READ, &victim, 1);
> if ( page == NULL )
> {
> PERROR("Error mapping page %lx", gfn);
> @@ -641,7 +641,7 @@ static int xenpaging_evict_page(struct xenpaging *paging, unsigned long gfn, int
> munmap(page, PAGE_SIZE);
>
> /* Tell Xen to evict page */
> - ret = xc_mem_paging_evict(xch, paging->mem_event.domain_id, gfn);
> + ret = xc_mem_paging_evict(xch, paging->vm_event.domain_id, gfn);
> if ( ret < 0 )
> {
> /* A gfn in use is indicated by EBUSY */
> @@ -671,10 +671,10 @@ static int xenpaging_evict_page(struct xenpaging *paging, unsigned long gfn, int
> return ret;
> }
>
> -static int xenpaging_resume_page(struct xenpaging *paging, mem_event_response_t *rsp, int notify_policy)
> +static int xenpaging_resume_page(struct xenpaging *paging, vm_event_response_t *rsp, int notify_policy)
> {
> /* Put the page info on the ring */
> - put_response(&paging->mem_event, rsp);
> + put_response(&paging->vm_event, rsp);
>
> /* Notify policy of page being paged in */
> if ( notify_policy )
> @@ -693,7 +693,7 @@ static int xenpaging_resume_page(struct xenpaging *paging, mem_event_response_t
> }
>
> /* Tell Xen page is ready */
> - return xc_evtchn_notify(paging->mem_event.xce_handle, paging->mem_event.port);
> + return xc_evtchn_notify(paging->vm_event.xce_handle, paging->vm_event.port);
> }
>
> static int xenpaging_populate_page(struct xenpaging *paging, unsigned long gfn, int i)
> @@ -715,7 +715,7 @@ static int xenpaging_populate_page(struct xenpaging *paging, unsigned long gfn,
> do
> {
> /* Tell Xen to allocate a page for the domain */
> - ret = xc_mem_paging_load(xch, paging->mem_event.domain_id, gfn, paging->paging_buffer);
> + ret = xc_mem_paging_load(xch, paging->vm_event.domain_id, gfn, paging->paging_buffer);
> if ( ret < 0 )
> {
> if ( errno == ENOMEM )
> @@ -857,8 +857,8 @@ int main(int argc, char *argv[])
> {
> struct sigaction act;
> struct xenpaging *paging;
> - mem_event_request_t req;
> - mem_event_response_t rsp;
> + vm_event_request_t req;
> + vm_event_response_t rsp;
> int num, prev_num = 0;
> int slot;
> int tot_pages;
> @@ -874,7 +874,7 @@ int main(int argc, char *argv[])
> }
> xch = paging->xc_handle;
>
> - DPRINTF("starting %s for domain_id %u with pagefile %s\n", argv[0], paging->mem_event.domain_id, filename);
> + DPRINTF("starting %s for domain_id %u with pagefile %s\n", argv[0], paging->vm_event.domain_id, filename);
>
> /* ensure that if we get a signal, we'll do cleanup, then exit */
> act.sa_handler = close_handler;
> @@ -903,12 +903,12 @@ int main(int argc, char *argv[])
> DPRINTF("Got event from Xen\n");
> }
>
> - while ( RING_HAS_UNCONSUMED_REQUESTS(&paging->mem_event.back_ring) )
> + while ( RING_HAS_UNCONSUMED_REQUESTS(&paging->vm_event.back_ring) )
> {
> /* Indicate possible error */
> rc = 1;
>
> - get_request(&paging->mem_event, &req);
> + get_request(&paging->vm_event, &req);
>
> if ( req.mem_paging_event.gfn > paging->max_pages )
> {
> @@ -929,7 +929,7 @@ int main(int argc, char *argv[])
> goto out;
> }
>
> - if ( req.flags & MEM_EVENT_FLAG_DROP_PAGE )
> + if ( req.flags & VM_EVENT_FLAG_DROP_PAGE )
> {
> DPRINTF("drop_page ^ gfn %"PRIx64" pageslot %d\n", req.mem_paging_event.gfn, slot);
> /* Notify policy of page being dropped */
> @@ -966,13 +966,13 @@ int main(int argc, char *argv[])
> {
> DPRINTF("page %s populated (domain = %d; vcpu = %d;"
> " gfn = %"PRIx64"; paused = %d; evict_fail = %d)\n",
> - req.flags & MEM_EVENT_FLAG_EVICT_FAIL ? "not" : "already",
> - paging->mem_event.domain_id, req.vcpu_id, req.mem_paging_event.gfn,
> - !!(req.flags & MEM_EVENT_FLAG_VCPU_PAUSED) ,
> - !!(req.flags & MEM_EVENT_FLAG_EVICT_FAIL) );
> + req.flags & VM_EVENT_FLAG_EVICT_FAIL ? "not" : "already",
> + paging->vm_event.domain_id, req.vcpu_id, req.mem_paging_event.gfn,
> + !!(req.flags & VM_EVENT_FLAG_VCPU_PAUSED) ,
> + !!(req.flags & VM_EVENT_FLAG_EVICT_FAIL) );
>
> /* Tell Xen to resume the vcpu */
> - if (( req.flags & MEM_EVENT_FLAG_VCPU_PAUSED ) || ( req.flags & MEM_EVENT_FLAG_EVICT_FAIL ))
> + if (( req.flags & VM_EVENT_FLAG_VCPU_PAUSED ) || ( req.flags & VM_EVENT_FLAG_EVICT_FAIL ))
> {
> /* Prepare the response */
> rsp.mem_paging_event.gfn = req.mem_paging_event.gfn;
> diff --git a/tools/xenpaging/xenpaging.h b/tools/xenpaging/xenpaging.h
> index 877db2f..25d511d 100644
> --- a/tools/xenpaging/xenpaging.h
> +++ b/tools/xenpaging/xenpaging.h
> @@ -27,15 +27,15 @@
>
> #include <xc_private.h>
> #include <xen/event_channel.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
>
> #define XENPAGING_PAGEIN_QUEUE_SIZE 64
>
> -struct mem_event {
> +struct vm_event {
> domid_t domain_id;
> xc_evtchn *xce_handle;
> int port;
> - mem_event_back_ring_t back_ring;
> + vm_event_back_ring_t back_ring;
> uint32_t evtchn_port;
> void *ring_page;
> };
> @@ -51,7 +51,7 @@ struct xenpaging {
>
> void *paging_buffer;
>
> - struct mem_event mem_event;
> + struct vm_event vm_event;
> int fd;
> /* number of pages for which data structures were allocated */
> int max_pages;
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index 11c7d9f..16855dc 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -432,7 +432,7 @@ int vcpu_initialise(struct vcpu *v)
> v->arch.flags = TF_kernel_mode;
>
> /* By default, do not emulate */
> - v->arch.mem_event.emulate_flags = 0;
> + v->arch.vm_event.emulate_flags = 0;
>
> rc = mapcache_vcpu_init(v);
> if ( rc )
> diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
> index 82365a4..3951ed3 100644
> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -30,8 +30,8 @@
> #include <xen/hypercall.h> /* for arch_do_domctl */
> #include <xsm/xsm.h>
> #include <xen/iommu.h>
> -#include <xen/mem_event.h>
> -#include <public/mem_event.h>
> +#include <xen/vm_event.h>
> +#include <public/vm_event.h>
> #include <asm/mem_sharing.h>
> #include <asm/xstate.h>
> #include <asm/debugger.h>
> diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c
> index 14c1847..218f6aa 100644
> --- a/xen/arch/x86/hvm/emulate.c
> +++ b/xen/arch/x86/hvm/emulate.c
> @@ -1401,7 +1401,7 @@ int hvm_emulate_one_no_write(
> return _hvm_emulate_one(hvmemul_ctxt, &hvm_emulate_ops_no_write);
> }
>
> -void hvm_mem_event_emulate_one(bool_t nowrite, unsigned int trapnr,
> +void hvm_mem_access_emulate_one(bool_t nowrite, unsigned int trapnr,
> unsigned int errcode)
> {
> struct hvm_emulate_ctxt ctx = {{ 0 }};
> @@ -1418,7 +1418,7 @@ void hvm_mem_event_emulate_one(bool_t nowrite, unsigned int trapnr,
> {
> case X86EMUL_RETRY:
> /*
> - * This function is called when handling an EPT-related mem_event
> + * This function is called when handling an EPT-related vm_event
> * reply. As such, nothing else needs to be done here, since simply
> * returning makes the current instruction cause a page fault again,
> * consistent with X86EMUL_RETRY.
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index 1968865..48ef545 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -35,7 +35,7 @@
> #include <xen/paging.h>
> #include <xen/cpu.h>
> #include <xen/wait.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <xen/mem_access.h>
> #include <xen/rangeset.h>
> #include <asm/shadow.h>
> @@ -66,7 +66,7 @@
> #include <public/hvm/ioreq.h>
> #include <public/version.h>
> #include <public/memory.h>
> -#include <public/mem_event.h>
> +#include <public/vm_event.h>
> #include <public/arch-x86/cpuid.h>
>
> bool_t __read_mostly hvm_enabled;
> @@ -2717,7 +2717,7 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla,
> struct p2m_domain *p2m;
> int rc, fall_through = 0, paged = 0;
> int sharing_enomem = 0;
> - mem_event_request_t *req_ptr = NULL;
> + vm_event_request_t *req_ptr = NULL;
>
> /* On Nested Virtualization, walk the guest page table.
> * If this succeeds, all is fine.
> @@ -2787,7 +2787,7 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla,
> {
> bool_t violation;
>
> - /* If the access is against the permissions, then send to mem_event */
> + /* If the access is against the permissions, then send to vm_event */
> switch (p2ma)
> {
> case p2m_access_n:
> @@ -6171,7 +6171,7 @@ int hvm_debug_op(struct vcpu *v, int32_t op)
> return rc;
> }
>
> -static void hvm_event_fill_regs(mem_event_request_t *req)
> +static void hvm_event_fill_regs(vm_event_request_t *req)
> {
> const struct cpu_user_regs *regs = guest_cpu_user_regs();
> const struct vcpu *curr = current;
> @@ -6203,7 +6203,7 @@ static void hvm_event_fill_regs(mem_event_request_t *req)
> req->regs.x86.cr4 = curr->arch.hvm_vcpu.guest_cr[4];
> }
>
> -static int hvm_event_traps(long parameters, mem_event_request_t *req)
> +static int hvm_event_traps(long parameters, vm_event_request_t *req)
> {
> int rc;
> struct vcpu *v = current;
> @@ -6212,7 +6212,7 @@ static int hvm_event_traps(long parameters, mem_event_request_t *req)
> if ( !(parameters & HVMPME_MODE_MASK) )
> return 0;
>
> - rc = mem_event_claim_slot(d, &d->mem_event->monitor);
> + rc = vm_event_claim_slot(d, &d->vm_event->monitor);
> if ( rc == -ENOSYS )
> {
> /* If there was no ring to handle the event, then
> @@ -6224,20 +6224,20 @@ static int hvm_event_traps(long parameters, mem_event_request_t *req)
>
> if ( (parameters & HVMPME_MODE_MASK) == HVMPME_mode_sync )
> {
> - req->flags |= MEM_EVENT_FLAG_VCPU_PAUSED;
> - mem_event_vcpu_pause(v);
> + req->flags |= VM_EVENT_FLAG_VCPU_PAUSED;
> + vm_event_vcpu_pause(v);
> }
>
> hvm_event_fill_regs(req);
> - mem_event_put_request(d, &d->mem_event->monitor, req);
> + vm_event_put_request(d, &d->vm_event->monitor, req);
>
> return 1;
> }
>
> void hvm_event_cr0(unsigned long value, unsigned long old)
> {
> - mem_event_request_t req = {
> - .reason = MEM_EVENT_REASON_CR0,
> + vm_event_request_t req = {
> + .reason = VM_EVENT_REASON_CR0,
> .vcpu_id = current->vcpu_id,
> .cr_event.new_value = value,
> .cr_event.old_value = old
> @@ -6254,8 +6254,8 @@ void hvm_event_cr0(unsigned long value, unsigned long old)
>
> void hvm_event_cr3(unsigned long value, unsigned long old)
> {
> - mem_event_request_t req = {
> - .reason = MEM_EVENT_REASON_CR3,
> + vm_event_request_t req = {
> + .reason = VM_EVENT_REASON_CR3,
> .vcpu_id = current->vcpu_id,
> .cr_event.new_value = value,
> .cr_event.old_value = old
> @@ -6272,8 +6272,8 @@ void hvm_event_cr3(unsigned long value, unsigned long old)
>
> void hvm_event_cr4(unsigned long value, unsigned long old)
> {
> - mem_event_request_t req = {
> - .reason = MEM_EVENT_REASON_CR4,
> + vm_event_request_t req = {
> + .reason = VM_EVENT_REASON_CR4,
> .vcpu_id = current->vcpu_id,
> .cr_event.new_value = value,
> .cr_event.old_value = old
> @@ -6290,8 +6290,8 @@ void hvm_event_cr4(unsigned long value, unsigned long old)
>
> void hvm_event_msr(unsigned long msr, unsigned long value)
> {
> - mem_event_request_t req = {
> - .reason = MEM_EVENT_REASON_MSR,
> + vm_event_request_t req = {
> + .reason = VM_EVENT_REASON_MSR,
> .vcpu_id = current->vcpu_id,
> .msr_event.msr = msr,
> .msr_event.new_value = value,
> @@ -6305,8 +6305,8 @@ void hvm_event_msr(unsigned long msr, unsigned long value)
> int hvm_event_int3(unsigned long gla)
> {
> uint32_t pfec = PFEC_page_present;
> - mem_event_request_t req = {
> - .reason = MEM_EVENT_REASON_INT3,
> + vm_event_request_t req = {
> + .reason = VM_EVENT_REASON_INT3,
> .vcpu_id = current->vcpu_id,
> .int3_event.gla = gla,
> .int3_event.gfn = paging_gva_to_gfn(current, gla, &pfec)
> @@ -6320,8 +6320,8 @@ int hvm_event_int3(unsigned long gla)
> int hvm_event_single_step(unsigned long gla)
> {
> uint32_t pfec = PFEC_page_present;
> - mem_event_request_t req = {
> - .reason = MEM_EVENT_REASON_SINGLESTEP,
> + vm_event_request_t req = {
> + .reason = VM_EVENT_REASON_SINGLESTEP,
> .vcpu_id = current->vcpu_id,
> .singlestep_event.gla = gla,
> .singlestep_event.gfn = paging_gva_to_gfn(current, gla, &pfec)
> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
> index e553fb0..0f2b2e6 100644
> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> @@ -25,7 +25,7 @@
> #include <xen/event.h>
> #include <xen/kernel.h>
> #include <xen/keyhandler.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <asm/current.h>
> #include <asm/cpufeature.h>
> #include <asm/processor.h>
> @@ -715,7 +715,7 @@ void vmx_disable_intercept_for_msr(struct vcpu *v, u32 msr, int type)
> return;
>
> if ( unlikely(d->arch.hvm_domain.introspection_enabled) &&
> - mem_event_check_ring(&d->mem_event->monitor) )
> + vm_event_check_ring(&d->vm_event->monitor) )
> {
> unsigned int i;
>
> diff --git a/xen/arch/x86/mm/hap/nested_ept.c b/xen/arch/x86/mm/hap/nested_ept.c
> index cbbc4e9..40adac3 100644
> --- a/xen/arch/x86/mm/hap/nested_ept.c
> +++ b/xen/arch/x86/mm/hap/nested_ept.c
> @@ -17,9 +17,9 @@
> * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
> * Place - Suite 330, Boston, MA 02111-1307 USA.
> */
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <xen/event.h>
> -#include <public/mem_event.h>
> +#include <public/vm_event.h>
> #include <asm/domain.h>
> #include <asm/page.h>
> #include <asm/paging.h>
> diff --git a/xen/arch/x86/mm/hap/nested_hap.c b/xen/arch/x86/mm/hap/nested_hap.c
> index 9c1ec11..cb28943 100644
> --- a/xen/arch/x86/mm/hap/nested_hap.c
> +++ b/xen/arch/x86/mm/hap/nested_hap.c
> @@ -19,9 +19,9 @@
> * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> */
>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <xen/event.h>
> -#include <public/mem_event.h>
> +#include <public/vm_event.h>
> #include <asm/domain.h>
> #include <asm/page.h>
> #include <asm/paging.h>
> diff --git a/xen/arch/x86/mm/mem_paging.c b/xen/arch/x86/mm/mem_paging.c
> index f28e65b..aaa72a9 100644
> --- a/xen/arch/x86/mm/mem_paging.c
> +++ b/xen/arch/x86/mm/mem_paging.c
> @@ -22,12 +22,12 @@
>
>
> #include <asm/p2m.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
>
>
> int mem_paging_memop(struct domain *d, xen_mem_paging_op_t *mpc)
> {
> - if ( unlikely(!d->mem_event->paging.ring_page) )
> + if ( unlikely(!d->vm_event->paging.ring_page) )
> return -ENODEV;
>
> switch( mpc->op )
> diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
> index c15edcc..b17a0a9 100644
> --- a/xen/arch/x86/mm/mem_sharing.c
> +++ b/xen/arch/x86/mm/mem_sharing.c
> @@ -28,7 +28,7 @@
> #include <xen/grant_table.h>
> #include <xen/sched.h>
> #include <xen/rcupdate.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <asm/page.h>
> #include <asm/string.h>
> #include <asm/p2m.h>
> @@ -559,25 +559,25 @@ int mem_sharing_notify_enomem(struct domain *d, unsigned long gfn,
> {
> struct vcpu *v = current;
> int rc;
> - mem_event_request_t req = {
> - .reason = MEM_EVENT_REASON_MEM_SHARING,
> + vm_event_request_t req = {
> + .reason = VM_EVENT_REASON_MEM_SHARING,
> .mem_sharing_event.gfn = gfn
> };
>
> - if ( (rc = __mem_event_claim_slot(d,
> - &d->mem_event->share, allow_sleep)) < 0 )
> + if ( (rc = __vm_event_claim_slot(d,
> + &d->vm_event->share, allow_sleep)) < 0 )
> return rc;
>
> if ( v->domain == d )
> {
> - req.flags = MEM_EVENT_FLAG_VCPU_PAUSED;
> - mem_event_vcpu_pause(v);
> + req.flags = VM_EVENT_FLAG_VCPU_PAUSED;
> + vm_event_vcpu_pause(v);
> }
>
> req.mem_sharing_event.p2mt = p2m_ram_shared;
> req.vcpu_id = v->vcpu_id;
>
> - mem_event_put_request(d, &d->mem_event->share, &req);
> + vm_event_put_request(d, &d->vm_event->share, &req);
>
> return 0;
> }
> @@ -594,14 +594,14 @@ unsigned int mem_sharing_get_nr_shared_mfns(void)
>
> int mem_sharing_sharing_resume(struct domain *d)
> {
> - mem_event_response_t rsp;
> + vm_event_response_t rsp;
>
> /* Get all requests off the ring */
> - while ( mem_event_get_response(d, &d->mem_event->share, &rsp) )
> + while ( vm_event_get_response(d, &d->vm_event->share, &rsp) )
> {
> struct vcpu *v;
>
> - if ( rsp.flags & MEM_EVENT_FLAG_DUMMY )
> + if ( rsp.flags & VM_EVENT_FLAG_DUMMY )
> continue;
>
> /* Validate the vcpu_id in the response. */
> @@ -611,8 +611,8 @@ int mem_sharing_sharing_resume(struct domain *d)
> v = d->vcpu[rsp.vcpu_id];
>
> /* Unpause domain/vcpu */
> - if ( rsp.flags & MEM_EVENT_FLAG_VCPU_PAUSED )
> - mem_event_vcpu_unpause(v);
> + if ( rsp.flags & VM_EVENT_FLAG_VCPU_PAUSED )
> + vm_event_vcpu_unpause(v);
> }
>
> return 0;
> @@ -1139,7 +1139,7 @@ err_out:
>
> /* A note on the rationale for unshare error handling:
> * 1. Unshare can only fail with ENOMEM. Any other error conditions BUG_ON()'s
> - * 2. We notify a potential dom0 helper through a mem_event ring. But we
> + * 2. We notify a potential dom0 helper through a vm_event ring. But we
> * allow the notification to not go to sleep. If the event ring is full
> * of ENOMEM warnings, then it's on the ball.
> * 3. We cannot go to sleep until the unshare is resolved, because we might
> diff --git a/xen/arch/x86/mm/p2m-pod.c b/xen/arch/x86/mm/p2m-pod.c
> index 43f507c..0679f00 100644
> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -21,9 +21,9 @@
> */
>
> #include <xen/iommu.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <xen/event.h>
> -#include <public/mem_event.h>
> +#include <public/vm_event.h>
> #include <asm/domain.h>
> #include <asm/page.h>
> #include <asm/paging.h>
> diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c
> index e48b63a..654384a 100644
> --- a/xen/arch/x86/mm/p2m-pt.c
> +++ b/xen/arch/x86/mm/p2m-pt.c
> @@ -26,10 +26,10 @@
> */
>
> #include <xen/iommu.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <xen/event.h>
> #include <xen/trace.h>
> -#include <public/mem_event.h>
> +#include <public/vm_event.h>
> #include <asm/domain.h>
> #include <asm/page.h>
> #include <asm/paging.h>
> diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
> index b42322a..7544667 100644
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -25,9 +25,9 @@
> */
>
> #include <xen/iommu.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <xen/event.h>
> -#include <public/mem_event.h>
> +#include <public/vm_event.h>
> #include <asm/domain.h>
> #include <asm/page.h>
> #include <asm/paging.h>
> @@ -1077,8 +1077,8 @@ int p2m_mem_paging_evict(struct domain *d, unsigned long gfn)
> void p2m_mem_paging_drop_page(struct domain *d, unsigned long gfn,
> p2m_type_t p2mt)
> {
> - mem_event_request_t req = {
> - .reason = MEM_EVENT_REASON_MEM_PAGING,
> + vm_event_request_t req = {
> + .reason = VM_EVENT_REASON_MEM_PAGING,
> .mem_paging_event.gfn = gfn
> };
>
> @@ -1086,21 +1086,21 @@ void p2m_mem_paging_drop_page(struct domain *d, unsigned long gfn,
> * correctness of the guest execution at this point. If this is the only
> * page that happens to be paged-out, we'll be okay.. but it's likely the
> * guest will crash shortly anyways. */
> - int rc = mem_event_claim_slot(d, &d->mem_event->paging);
> + int rc = vm_event_claim_slot(d, &d->vm_event->paging);
> if ( rc < 0 )
> return;
>
> /* Send release notification to pager */
> - req.flags = MEM_EVENT_FLAG_DROP_PAGE;
> + req.flags = VM_EVENT_FLAG_DROP_PAGE;
>
> /* Update stats unless the page hasn't yet been evicted */
> if ( p2mt != p2m_ram_paging_out )
> atomic_dec(&d->paged_pages);
> else
> /* Evict will fail now, tag this request for pager */
> - req.flags |= MEM_EVENT_FLAG_EVICT_FAIL;
> + req.flags |= VM_EVENT_FLAG_EVICT_FAIL;
>
> - mem_event_put_request(d, &d->mem_event->paging, &req);
> + vm_event_put_request(d, &d->vm_event->paging, &req);
> }
>
> /**
> @@ -1127,8 +1127,8 @@ void p2m_mem_paging_drop_page(struct domain *d, unsigned long gfn,
> void p2m_mem_paging_populate(struct domain *d, unsigned long gfn)
> {
> struct vcpu *v = current;
> - mem_event_request_t req = {
> - .reason = MEM_EVENT_REASON_MEM_PAGING,
> + vm_event_request_t req = {
> + .reason = VM_EVENT_REASON_MEM_PAGING,
> .mem_paging_event.gfn = gfn
> };
> p2m_type_t p2mt;
> @@ -1137,7 +1137,7 @@ void p2m_mem_paging_populate(struct domain *d, unsigned long gfn)
> struct p2m_domain *p2m = p2m_get_hostp2m(d);
>
> /* We're paging. There should be a ring */
> - int rc = mem_event_claim_slot(d, &d->mem_event->paging);
> + int rc = vm_event_claim_slot(d, &d->vm_event->paging);
> if ( rc == -ENOSYS )
> {
> gdprintk(XENLOG_ERR, "Domain %hu paging gfn %lx yet no ring "
> @@ -1159,7 +1159,7 @@ void p2m_mem_paging_populate(struct domain *d, unsigned long gfn)
> {
> /* Evict will fail now, tag this request for pager */
> if ( p2mt == p2m_ram_paging_out )
> - req.flags |= MEM_EVENT_FLAG_EVICT_FAIL;
> + req.flags |= VM_EVENT_FLAG_EVICT_FAIL;
>
> p2m_set_entry(p2m, gfn, mfn, PAGE_ORDER_4K, p2m_ram_paging_in, a);
> }
> @@ -1168,14 +1168,14 @@ void p2m_mem_paging_populate(struct domain *d, unsigned long gfn)
> /* Pause domain if request came from guest and gfn has paging type */
> if ( p2m_is_paging(p2mt) && v->domain == d )
> {
> - mem_event_vcpu_pause(v);
> - req.flags |= MEM_EVENT_FLAG_VCPU_PAUSED;
> + vm_event_vcpu_pause(v);
> + req.flags |= VM_EVENT_FLAG_VCPU_PAUSED;
> }
> /* No need to inform pager if the gfn is not in the page-out path */
> else if ( p2mt != p2m_ram_paging_out && p2mt != p2m_ram_paged )
> {
> /* gfn is already on its way back and vcpu is not paused */
> - mem_event_cancel_slot(d, &d->mem_event->paging);
> + vm_event_cancel_slot(d, &d->vm_event->paging);
> return;
> }
>
> @@ -1183,7 +1183,7 @@ void p2m_mem_paging_populate(struct domain *d, unsigned long gfn)
> req.mem_paging_event.p2mt = p2mt;
> req.vcpu_id = v->vcpu_id;
>
> - mem_event_put_request(d, &d->mem_event->paging, &req);
> + vm_event_put_request(d, &d->vm_event->paging, &req);
> }
>
> /**
> @@ -1292,17 +1292,17 @@ int p2m_mem_paging_prep(struct domain *d, unsigned long gfn, uint64_t buffer)
> void p2m_mem_paging_resume(struct domain *d)
> {
> struct p2m_domain *p2m = p2m_get_hostp2m(d);
> - mem_event_response_t rsp;
> + vm_event_response_t rsp;
> p2m_type_t p2mt;
> p2m_access_t a;
> mfn_t mfn;
>
> /* Pull all responses off the ring */
> - while( mem_event_get_response(d, &d->mem_event->paging, &rsp) )
> + while( vm_event_get_response(d, &d->vm_event->paging, &rsp) )
> {
> struct vcpu *v;
>
> - if ( rsp.flags & MEM_EVENT_FLAG_DUMMY )
> + if ( rsp.flags & VM_EVENT_FLAG_DUMMY )
> continue;
>
> /* Validate the vcpu_id in the response. */
> @@ -1312,7 +1312,7 @@ void p2m_mem_paging_resume(struct domain *d)
> v = d->vcpu[rsp.vcpu_id];
>
> /* Fix p2m entry if the page was not dropped */
> - if ( !(rsp.flags & MEM_EVENT_FLAG_DROP_PAGE) )
> + if ( !(rsp.flags & VM_EVENT_FLAG_DROP_PAGE) )
> {
> gfn_lock(p2m, rsp.gfn, 0);
> mfn = p2m->get_entry(p2m, rsp.mem_access_event.gfn, &p2mt, &a, 0, NULL);
> @@ -1328,12 +1328,12 @@ void p2m_mem_paging_resume(struct domain *d)
> gfn_unlock(p2m, rsp.gfn, 0);
> }
> /* Unpause domain */
> - if ( rsp.flags & MEM_EVENT_FLAG_VCPU_PAUSED )
> - mem_event_vcpu_unpause(v);
> + if ( rsp.flags & VM_EVENT_FLAG_VCPU_PAUSED )
> + vm_event_vcpu_unpause(v);
> }
> }
>
> -static void p2m_mem_event_fill_regs(mem_event_request_t *req)
> +static void p2m_vm_event_fill_regs(vm_event_request_t *req)
> {
> const struct cpu_user_regs *regs = guest_cpu_user_regs();
> struct segment_register seg;
> @@ -1388,10 +1388,10 @@ static void p2m_mem_event_fill_regs(mem_event_request_t *req)
> req->regs.x86.cs_arbytes = seg.attr.bytes;
> }
>
> -void p2m_mem_event_emulate_check(struct vcpu *v, const mem_event_response_t *rsp)
> +void p2m_mem_access_emulate_check(struct vcpu *v, const vm_event_response_t *rsp)
> {
> /* Mark vcpu for skipping one instruction upon rescheduling. */
> - if ( rsp->flags & MEM_EVENT_FLAG_EMULATE )
> + if ( rsp->flags & VM_EVENT_FLAG_EMULATE )
> {
> xenmem_access_t access;
> bool_t violation = 1;
> @@ -1438,7 +1438,7 @@ void p2m_mem_event_emulate_check(struct vcpu *v, const mem_event_response_t *rsp
> }
> }
>
> - v->arch.mem_event.emulate_flags = violation ? rsp->flags : 0;
> + v->arch.vm_event.emulate_flags = violation ? rsp->flags : 0;
> }
> }
>
> @@ -1453,7 +1453,7 @@ void p2m_setup_introspection(struct domain *d)
>
> bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
> struct npfec npfec,
> - mem_event_request_t **req_ptr)
> + vm_event_request_t **req_ptr)
> {
> struct vcpu *v = current;
> unsigned long gfn = gpa >> PAGE_SHIFT;
> @@ -1462,7 +1462,7 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
> mfn_t mfn;
> p2m_type_t p2mt;
> p2m_access_t p2ma;
> - mem_event_request_t *req;
> + vm_event_request_t *req;
> int rc;
> unsigned long eip = guest_cpu_user_regs()->eip;
>
> @@ -1489,13 +1489,13 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
> gfn_unlock(p2m, gfn, 0);
>
> /* Otherwise, check if there is a memory event listener, and send the message along */
> - if ( !mem_event_check_ring(&d->mem_event->monitor) || !req_ptr )
> + if ( !vm_event_check_ring(&d->vm_event->monitor) || !req_ptr )
> {
> /* No listener */
> if ( p2m->access_required )
> {
> gdprintk(XENLOG_INFO, "Memory access permissions failure, "
> - "no mem_event listener VCPU %d, dom %d\n",
> + "no vm_event listener VCPU %d, dom %d\n",
> v->vcpu_id, d->domain_id);
> domain_crash(v->domain);
> return 0;
> @@ -1518,40 +1518,40 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
> }
> }
>
> - /* The previous mem_event reply does not match the current state. */
> - if ( v->arch.mem_event.gpa != gpa || v->arch.mem_event.eip != eip )
> + /* The previous vm_event reply does not match the current state. */
> + if ( v->arch.vm_event.gpa != gpa || v->arch.vm_event.eip != eip )
> {
> - /* Don't emulate the current instruction, send a new mem_event. */
> - v->arch.mem_event.emulate_flags = 0;
> + /* Don't emulate the current instruction, send a new vm_event. */
> + v->arch.vm_event.emulate_flags = 0;
>
> /*
> * Make sure to mark the current state to match it again against
> - * the new mem_event about to be sent.
> + * the new vm_event about to be sent.
> */
> - v->arch.mem_event.gpa = gpa;
> - v->arch.mem_event.eip = eip;
> + v->arch.vm_event.gpa = gpa;
> + v->arch.vm_event.eip = eip;
> }
>
> - if ( v->arch.mem_event.emulate_flags )
> + if ( v->arch.vm_event.emulate_flags )
> {
> - hvm_mem_event_emulate_one((v->arch.mem_event.emulate_flags &
> - MEM_EVENT_FLAG_EMULATE_NOWRITE) != 0,
> - TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE);
> + hvm_mem_access_emulate_one((v->arch.vm_event.emulate_flags &
> + VM_EVENT_FLAG_EMULATE_NOWRITE) != 0,
> + TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE);
>
> - v->arch.mem_event.emulate_flags = 0;
> + v->arch.vm_event.emulate_flags = 0;
> return 1;
> }
>
> *req_ptr = NULL;
> - req = xzalloc(mem_event_request_t);
> + req = xzalloc(vm_event_request_t);
> if ( req )
> {
> *req_ptr = req;
> - req->reason = MEM_EVENT_REASON_MEM_ACCESS_VIOLATION;
> + req->reason = VM_EVENT_REASON_MEM_ACCESS_VIOLATION;
>
> /* Pause the current VCPU */
> if ( p2ma != p2m_access_n2rwx )
> - req->flags |= MEM_EVENT_FLAG_VCPU_PAUSED;
> + req->flags |= VM_EVENT_FLAG_VCPU_PAUSED;
>
> /* Send request to mem event */
> req->mem_access_event.gfn = gfn;
> @@ -1567,12 +1567,12 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
> req->mem_access_event.access_x = npfec.insn_fetch;
> req->vcpu_id = v->vcpu_id;
>
> - p2m_mem_event_fill_regs(req);
> + p2m_vm_event_fill_regs(req);
> }
>
> /* Pause the current VCPU */
> if ( p2ma != p2m_access_n2rwx )
> - mem_event_vcpu_pause(v);
> + vm_event_vcpu_pause(v);
>
> /* VCPU may be paused, return whether we promoted automatically */
> return (p2ma == p2m_access_n2rwx);
> diff --git a/xen/arch/x86/x86_64/compat/mm.c b/xen/arch/x86/x86_64/compat/mm.c
> index c8ea85a..959ccf5 100644
> --- a/xen/arch/x86/x86_64/compat/mm.c
> +++ b/xen/arch/x86/x86_64/compat/mm.c
> @@ -1,5 +1,5 @@
> #include <xen/event.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <xen/mem_access.h>
> #include <xen/multicall.h>
> #include <compat/memory.h>
> @@ -191,7 +191,7 @@ int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
> xen_mem_paging_op_t mpo;
> if ( copy_from_guest(&mpo, arg, 1) )
> return -EFAULT;
> - rc = do_mem_event_op(cmd, mpo.domain, &mpo);
> + rc = do_vm_event_op(cmd, mpo.domain, &mpo);
> if ( !rc && __copy_to_guest(arg, &mpo, 1) )
> return -EFAULT;
> break;
> @@ -204,7 +204,7 @@ int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
> return -EFAULT;
> if ( mso.op == XENMEM_sharing_op_audit )
> return mem_sharing_audit();
> - rc = do_mem_event_op(cmd, mso.domain, &mso);
> + rc = do_vm_event_op(cmd, mso.domain, &mso);
> if ( !rc && __copy_to_guest(arg, &mso, 1) )
> return -EFAULT;
> break;
> diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c
> index 2fa1f67..47c8578 100644
> --- a/xen/arch/x86/x86_64/mm.c
> +++ b/xen/arch/x86/x86_64/mm.c
> @@ -26,7 +26,7 @@
> #include <xen/nodemask.h>
> #include <xen/guest_access.h>
> #include <xen/hypercall.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <xen/mem_access.h>
> #include <asm/current.h>
> #include <asm/asm_defns.h>
> @@ -988,7 +988,8 @@ long subarch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
> xen_mem_paging_op_t mpo;
> if ( copy_from_guest(&mpo, arg, 1) )
> return -EFAULT;
> - rc = do_mem_event_op(cmd, mpo.domain, &mpo);
> +
> + rc = do_vm_event_op(cmd, mpo.domain, &mpo);
> if ( !rc && __copy_to_guest(arg, &mpo, 1) )
> return -EFAULT;
> break;
> @@ -1001,7 +1002,7 @@ long subarch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
> return -EFAULT;
> if ( mso.op == XENMEM_sharing_op_audit )
> return mem_sharing_audit();
> - rc = do_mem_event_op(cmd, mso.domain, &mso);
> + rc = do_vm_event_op(cmd, mso.domain, &mso);
> if ( !rc && __copy_to_guest(arg, &mso, 1) )
> return -EFAULT;
> break;
> diff --git a/xen/common/Makefile b/xen/common/Makefile
> index 8391246..f1b73a3 100644
> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -54,7 +54,7 @@ obj-y += rbtree.o
> obj-y += lzo.o
> obj-$(HAS_PDX) += pdx.o
> obj-$(HAS_MEM_ACCESS) += mem_access.o
> -obj-$(HAS_MEM_ACCESS) += mem_event.o
> +obj-$(HAS_MEM_ACCESS) += vm_event.o
>
> obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma unlzo unlz4 earlycpio,$(n).init.o)
>
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 336e9ea..d739614 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -15,7 +15,7 @@
> #include <xen/domain.h>
> #include <xen/mm.h>
> #include <xen/event.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <xen/time.h>
> #include <xen/console.h>
> #include <xen/softirq.h>
> @@ -344,8 +344,8 @@ struct domain *domain_create(
> poolid = 0;
>
> err = -ENOMEM;
> - d->mem_event = xzalloc(struct mem_event_per_domain);
> - if ( !d->mem_event )
> + d->vm_event = xzalloc(struct vm_event_per_domain);
> + if ( !d->vm_event )
> goto fail;
>
> d->pbuf = xzalloc_array(char, DOMAIN_PBUF_SIZE);
> @@ -387,7 +387,7 @@ struct domain *domain_create(
> if ( hardware_domain == d )
> hardware_domain = old_hwdom;
> atomic_set(&d->refcnt, DOMAIN_DESTROYED);
> - xfree(d->mem_event);
> + xfree(d->vm_event);
> xfree(d->pbuf);
> if ( init_status & INIT_arch )
> arch_domain_destroy(d);
> @@ -629,7 +629,7 @@ int domain_kill(struct domain *d)
> d->is_dying = DOMDYING_dead;
> /* Mem event cleanup has to go here because the rings
> * have to be put before we call put_domain. */
> - mem_event_cleanup(d);
> + vm_event_cleanup(d);
> put_domain(d);
> send_global_virq(VIRQ_DOM_EXC);
> /* fallthrough */
> @@ -808,7 +808,7 @@ static void complete_domain_destroy(struct rcu_head *head)
> free_xenoprof_pages(d);
> #endif
>
> - xfree(d->mem_event);
> + xfree(d->vm_event);
> xfree(d->pbuf);
>
> for ( i = d->max_vcpus - 1; i >= 0; i-- )
> diff --git a/xen/common/domctl.c b/xen/common/domctl.c
> index f15dcfe..e6d8310 100644
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -24,7 +24,7 @@
> #include <xen/bitmap.h>
> #include <xen/paging.h>
> #include <xen/hypercall.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <asm/current.h>
> #include <asm/irq.h>
> #include <asm/page.h>
> @@ -1113,8 +1113,8 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
> }
> break;
>
> - case XEN_DOMCTL_mem_event_op:
> - ret = mem_event_domctl(d, &op->u.mem_event_op,
> + case XEN_DOMCTL_vm_event_op:
> + ret = vm_event_domctl(d, &op->u.vm_event_op,
> guest_handle_cast(u_domctl, void));
> copyback = 1;
> break;
> diff --git a/xen/common/mem_access.c b/xen/common/mem_access.c
> index f01ccfd..b8d3d49 100644
> --- a/xen/common/mem_access.c
> +++ b/xen/common/mem_access.c
> @@ -24,21 +24,21 @@
> #include <xen/sched.h>
> #include <xen/guest_access.h>
> #include <xen/hypercall.h>
> -#include <xen/mem_event.h>
> +#include <xen/vm_event.h>
> #include <public/memory.h>
> #include <asm/p2m.h>
> #include <xsm/xsm.h>
>
> void mem_access_resume(struct domain *d)
> {
> - mem_event_response_t rsp;
> + vm_event_response_t rsp;
>
> /* Pull all responses off the ring. */
> - while ( mem_event_get_response(d, &d->mem_event->monitor, &rsp) )
> + while ( vm_event_get_response(d, &d->vm_event->monitor, &rsp) )
> {
> struct vcpu *v;
>
> - if ( rsp.flags & MEM_EVENT_FLAG_DUMMY )
> + if ( rsp.flags & VM_EVENT_FLAG_DUMMY )
> continue;
>
> /* Validate the vcpu_id in the response. */
> @@ -47,11 +47,11 @@ void mem_access_resume(struct domain *d)
>
> v = d->vcpu[rsp.vcpu_id];
>
> - p2m_mem_event_emulate_check(v, &rsp);
> + p2m_mem_access_emulate_check(v, &rsp);
>
> /* Unpause domain. */
> - if ( rsp.flags & MEM_EVENT_FLAG_VCPU_PAUSED )
> - mem_event_vcpu_unpause(v);
> + if ( rsp.flags & VM_EVENT_FLAG_VCPU_PAUSED )
> + vm_event_vcpu_unpause(v);
> }
> }
>
> @@ -74,12 +74,12 @@ int mem_access_memop(unsigned long cmd,
> if ( !p2m_mem_access_sanity_check(d) )
> goto out;
>
> - rc = xsm_mem_event_op(XSM_DM_PRIV, d, XENMEM_access_op);
> + rc = xsm_vm_event_op(XSM_DM_PRIV, d, XENMEM_access_op);
> if ( rc )
> goto out;
>
> rc = -ENODEV;
> - if ( unlikely(!d->mem_event->monitor.ring_page) )
> + if ( unlikely(!d->vm_event->monitor.ring_page) )
> goto out;
>
> switch ( mao.op )
> @@ -144,13 +144,13 @@ int mem_access_memop(unsigned long cmd,
> return rc;
> }
>
> -int mem_access_send_req(struct domain *d, mem_event_request_t *req)
> +int mem_access_send_req(struct domain *d, vm_event_request_t *req)
> {
> - int rc = mem_event_claim_slot(d, &d->mem_event->monitor);
> + int rc = vm_event_claim_slot(d, &d->vm_event->monitor);
> if ( rc < 0 )
> return rc;
>
> - mem_event_put_request(d, &d->mem_event->monitor, req);
> + vm_event_put_request(d, &d->vm_event->monitor, req);
>
> return 0;
> }
> diff --git a/xen/common/mem_event.c b/xen/common/mem_event.c
> deleted file mode 100644
> index b99e7d5..0000000
> --- a/xen/common/mem_event.c
> +++ /dev/null
> @@ -1,742 +0,0 @@
> -/******************************************************************************
> - * mem_event.c
> - *
> - * Memory event support.
> - *
> - * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp)
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> - */
> -
> -
> -#include <xen/sched.h>
> -#include <xen/event.h>
> -#include <xen/wait.h>
> -#include <xen/mem_event.h>
> -#include <xen/mem_access.h>
> -#include <asm/p2m.h>
> -
> -#ifdef HAS_MEM_PAGING
> -#include <asm/mem_paging.h>
> -#endif
> -
> -#ifdef HAS_MEM_SHARING
> -#include <asm/mem_sharing.h>
> -#endif
> -
> -#include <xsm/xsm.h>
> -
> -/* for public/io/ring.h macros */
> -#define xen_mb() mb()
> -#define xen_rmb() rmb()
> -#define xen_wmb() wmb()
> -
> -#define mem_event_ring_lock_init(_med) spin_lock_init(&(_med)->ring_lock)
> -#define mem_event_ring_lock(_med) spin_lock(&(_med)->ring_lock)
> -#define mem_event_ring_unlock(_med) spin_unlock(&(_med)->ring_lock)
> -
> -static int mem_event_enable(
> - struct domain *d,
> - xen_domctl_mem_event_op_t *mec,
> - struct mem_event_domain *med,
> - int pause_flag,
> - int param,
> - xen_event_channel_notification_t notification_fn)
> -{
> - int rc;
> - unsigned long ring_gfn = d->arch.hvm_domain.params[param];
> -
> - /* Only one helper at a time. If the helper crashed,
> - * the ring is in an undefined state and so is the guest.
> - */
> - if ( med->ring_page )
> - return -EBUSY;
> -
> - /* The parameter defaults to zero, and it should be
> - * set to something */
> - if ( ring_gfn == 0 )
> - return -ENOSYS;
> -
> - mem_event_ring_lock_init(med);
> - mem_event_ring_lock(med);
> -
> - rc = prepare_ring_for_helper(d, ring_gfn, &med->ring_pg_struct,
> - &med->ring_page);
> - if ( rc < 0 )
> - goto err;
> -
> - /* Set the number of currently blocked vCPUs to 0. */
> - med->blocked = 0;
> -
> - /* Allocate event channel */
> - rc = alloc_unbound_xen_event_channel(d->vcpu[0],
> - current->domain->domain_id,
> - notification_fn);
> - if ( rc < 0 )
> - goto err;
> -
> - med->xen_port = mec->port = rc;
> -
> - /* Prepare ring buffer */
> - FRONT_RING_INIT(&med->front_ring,
> - (mem_event_sring_t *)med->ring_page,
> - PAGE_SIZE);
> -
> - /* Save the pause flag for this particular ring. */
> - med->pause_flag = pause_flag;
> -
> - /* Initialize the last-chance wait queue. */
> - init_waitqueue_head(&med->wq);
> -
> - mem_event_ring_unlock(med);
> - return 0;
> -
> - err:
> - destroy_ring_for_helper(&med->ring_page,
> - med->ring_pg_struct);
> - mem_event_ring_unlock(med);
> -
> - return rc;
> -}
> -
> -static unsigned int mem_event_ring_available(struct mem_event_domain *med)
> -{
> - int avail_req = RING_FREE_REQUESTS(&med->front_ring);
> - avail_req -= med->target_producers;
> - avail_req -= med->foreign_producers;
> -
> - BUG_ON(avail_req < 0);
> -
> - return avail_req;
> -}
> -
> -/*
> - * mem_event_wake_blocked() will wakeup vcpus waiting for room in the
> - * ring. These vCPUs were paused on their way out after placing an event,
> - * but need to be resumed where the ring is capable of processing at least
> - * one event from them.
> - */
> -static void mem_event_wake_blocked(struct domain *d, struct mem_event_domain *med)
> -{
> - struct vcpu *v;
> - int online = d->max_vcpus;
> - unsigned int avail_req = mem_event_ring_available(med);
> -
> - if ( avail_req == 0 || med->blocked == 0 )
> - return;
> -
> - /*
> - * We ensure that we only have vCPUs online if there are enough free slots
> - * for their memory events to be processed. This will ensure that no
> - * memory events are lost (due to the fact that certain types of events
> - * cannot be replayed, we need to ensure that there is space in the ring
> - * for when they are hit).
> - * See comment below in mem_event_put_request().
> - */
> - for_each_vcpu ( d, v )
> - if ( test_bit(med->pause_flag, &v->pause_flags) )
> - online--;
> -
> - ASSERT(online == (d->max_vcpus - med->blocked));
> -
> - /* We remember which vcpu last woke up to avoid scanning always linearly
> - * from zero and starving higher-numbered vcpus under high load */
> - if ( d->vcpu )
> - {
> - int i, j, k;
> -
> - for (i = med->last_vcpu_wake_up + 1, j = 0; j < d->max_vcpus; i++, j++)
> - {
> - k = i % d->max_vcpus;
> - v = d->vcpu[k];
> - if ( !v )
> - continue;
> -
> - if ( !(med->blocked) || online >= avail_req )
> - break;
> -
> - if ( test_and_clear_bit(med->pause_flag, &v->pause_flags) )
> - {
> - vcpu_unpause(v);
> - online++;
> - med->blocked--;
> - med->last_vcpu_wake_up = k;
> - }
> - }
> - }
> -}
> -
> -/*
> - * In the event that a vCPU attempted to place an event in the ring and
> - * was unable to do so, it is queued on a wait queue. These are woken as
> - * needed, and take precedence over the blocked vCPUs.
> - */
> -static void mem_event_wake_queued(struct domain *d, struct mem_event_domain *med)
> -{
> - unsigned int avail_req = mem_event_ring_available(med);
> -
> - if ( avail_req > 0 )
> - wake_up_nr(&med->wq, avail_req);
> -}
> -
> -/*
> - * mem_event_wake() will wakeup all vcpus waiting for the ring to
> - * become available. If we have queued vCPUs, they get top priority. We
> - * are guaranteed that they will go through code paths that will eventually
> - * call mem_event_wake() again, ensuring that any blocked vCPUs will get
> - * unpaused once all the queued vCPUs have made it through.
> - */
> -void mem_event_wake(struct domain *d, struct mem_event_domain *med)
> -{
> - if (!list_empty(&med->wq.list))
> - mem_event_wake_queued(d, med);
> - else
> - mem_event_wake_blocked(d, med);
> -}
> -
> -static int mem_event_disable(struct domain *d, struct mem_event_domain *med)
> -{
> - if ( med->ring_page )
> - {
> - struct vcpu *v;
> -
> - mem_event_ring_lock(med);
> -
> - if ( !list_empty(&med->wq.list) )
> - {
> - mem_event_ring_unlock(med);
> - return -EBUSY;
> - }
> -
> - /* Free domU's event channel and leave the other one unbound */
> - free_xen_event_channel(d->vcpu[0], med->xen_port);
> -
> - /* Unblock all vCPUs */
> - for_each_vcpu ( d, v )
> - {
> - if ( test_and_clear_bit(med->pause_flag, &v->pause_flags) )
> - {
> - vcpu_unpause(v);
> - med->blocked--;
> - }
> - }
> -
> - destroy_ring_for_helper(&med->ring_page,
> - med->ring_pg_struct);
> - mem_event_ring_unlock(med);
> - }
> -
> - return 0;
> -}
> -
> -static inline void mem_event_release_slot(struct domain *d,
> - struct mem_event_domain *med)
> -{
> - /* Update the accounting */
> - if ( current->domain == d )
> - med->target_producers--;
> - else
> - med->foreign_producers--;
> -
> - /* Kick any waiters */
> - mem_event_wake(d, med);
> -}
> -
> -/*
> - * mem_event_mark_and_pause() tags vcpu and put it to sleep.
> - * The vcpu will resume execution in mem_event_wake_waiters().
> - */
> -void mem_event_mark_and_pause(struct vcpu *v, struct mem_event_domain *med)
> -{
> - if ( !test_and_set_bit(med->pause_flag, &v->pause_flags) )
> - {
> - vcpu_pause_nosync(v);
> - med->blocked++;
> - }
> -}
> -
> -/*
> - * This must be preceded by a call to claim_slot(), and is guaranteed to
> - * succeed. As a side-effect however, the vCPU may be paused if the ring is
> - * overly full and its continued execution would cause stalling and excessive
> - * waiting. The vCPU will be automatically unpaused when the ring clears.
> - */
> -void mem_event_put_request(struct domain *d,
> - struct mem_event_domain *med,
> - mem_event_request_t *req)
> -{
> - mem_event_front_ring_t *front_ring;
> - int free_req;
> - unsigned int avail_req;
> - RING_IDX req_prod;
> -
> - if ( current->domain != d )
> - {
> - req->flags |= MEM_EVENT_FLAG_FOREIGN;
> -#ifndef NDEBUG
> - if ( !(req->flags & MEM_EVENT_FLAG_VCPU_PAUSED) )
> - gdprintk(XENLOG_G_WARNING, "d%dv%d was not paused.\n",
> - d->domain_id, req->vcpu_id);
> -#endif
> - }
> -
> - mem_event_ring_lock(med);
> -
> - /* Due to the reservations, this step must succeed. */
> - front_ring = &med->front_ring;
> - free_req = RING_FREE_REQUESTS(front_ring);
> - ASSERT(free_req > 0);
> -
> - /* Copy request */
> - req_prod = front_ring->req_prod_pvt;
> - memcpy(RING_GET_REQUEST(front_ring, req_prod), req, sizeof(*req));
> - req_prod++;
> -
> - /* Update ring */
> - front_ring->req_prod_pvt = req_prod;
> - RING_PUSH_REQUESTS(front_ring);
> -
> - /* We've actually *used* our reservation, so release the slot. */
> - mem_event_release_slot(d, med);
> -
> - /* Give this vCPU a black eye if necessary, on the way out.
> - * See the comments above wake_blocked() for more information
> - * on how this mechanism works to avoid waiting. */
> - avail_req = mem_event_ring_available(med);
> - if( current->domain == d && avail_req < d->max_vcpus )
> - mem_event_mark_and_pause(current, med);
> -
> - mem_event_ring_unlock(med);
> -
> - notify_via_xen_event_channel(d, med->xen_port);
> -}
> -
> -int mem_event_get_response(struct domain *d, struct mem_event_domain *med, mem_event_response_t *rsp)
> -{
> - mem_event_front_ring_t *front_ring;
> - RING_IDX rsp_cons;
> -
> - mem_event_ring_lock(med);
> -
> - front_ring = &med->front_ring;
> - rsp_cons = front_ring->rsp_cons;
> -
> - if ( !RING_HAS_UNCONSUMED_RESPONSES(front_ring) )
> - {
> - mem_event_ring_unlock(med);
> - return 0;
> - }
> -
> - /* Copy response */
> - memcpy(rsp, RING_GET_RESPONSE(front_ring, rsp_cons), sizeof(*rsp));
> - rsp_cons++;
> -
> - /* Update ring */
> - front_ring->rsp_cons = rsp_cons;
> - front_ring->sring->rsp_event = rsp_cons + 1;
> -
> - /* Kick any waiters -- since we've just consumed an event,
> - * there may be additional space available in the ring. */
> - mem_event_wake(d, med);
> -
> - mem_event_ring_unlock(med);
> -
> - return 1;
> -}
> -
> -void mem_event_cancel_slot(struct domain *d, struct mem_event_domain *med)
> -{
> - mem_event_ring_lock(med);
> - mem_event_release_slot(d, med);
> - mem_event_ring_unlock(med);
> -}
> -
> -static int mem_event_grab_slot(struct mem_event_domain *med, int foreign)
> -{
> - unsigned int avail_req;
> -
> - if ( !med->ring_page )
> - return -ENOSYS;
> -
> - mem_event_ring_lock(med);
> -
> - avail_req = mem_event_ring_available(med);
> - if ( avail_req == 0 )
> - {
> - mem_event_ring_unlock(med);
> - return -EBUSY;
> - }
> -
> - if ( !foreign )
> - med->target_producers++;
> - else
> - med->foreign_producers++;
> -
> - mem_event_ring_unlock(med);
> -
> - return 0;
> -}
> -
> -/* Simple try_grab wrapper for use in the wait_event() macro. */
> -static int mem_event_wait_try_grab(struct mem_event_domain *med, int *rc)
> -{
> - *rc = mem_event_grab_slot(med, 0);
> - return *rc;
> -}
> -
> -/* Call mem_event_grab_slot() until the ring doesn't exist, or is available. */
> -static int mem_event_wait_slot(struct mem_event_domain *med)
> -{
> - int rc = -EBUSY;
> - wait_event(med->wq, mem_event_wait_try_grab(med, &rc) != -EBUSY);
> - return rc;
> -}
> -
> -bool_t mem_event_check_ring(struct mem_event_domain *med)
> -{
> - return (med->ring_page != NULL);
> -}
> -
> -/*
> - * Determines whether or not the current vCPU belongs to the target domain,
> - * and calls the appropriate wait function. If it is a guest vCPU, then we
> - * use mem_event_wait_slot() to reserve a slot. As long as there is a ring,
> - * this function will always return 0 for a guest. For a non-guest, we check
> - * for space and return -EBUSY if the ring is not available.
> - *
> - * Return codes: -ENOSYS: the ring is not yet configured
> - * -EBUSY: the ring is busy
> - * 0: a spot has been reserved
> - *
> - */
> -int __mem_event_claim_slot(struct domain *d, struct mem_event_domain *med,
> - bool_t allow_sleep)
> -{
> - if ( (current->domain == d) && allow_sleep )
> - return mem_event_wait_slot(med);
> - else
> - return mem_event_grab_slot(med, (current->domain != d));
> -}
> -
> -#ifdef HAS_MEM_PAGING
> -/* Registered with Xen-bound event channel for incoming notifications. */
> -static void mem_paging_notification(struct vcpu *v, unsigned int port)
> -{
> - if ( likely(v->domain->mem_event->paging.ring_page != NULL) )
> - p2m_mem_paging_resume(v->domain);
> -}
> -#endif
> -
> -#ifdef HAS_MEM_ACCESS
> -/* Registered with Xen-bound event channel for incoming notifications. */
> -static void mem_access_notification(struct vcpu *v, unsigned int port)
> -{
> - if ( likely(v->domain->mem_event->monitor.ring_page != NULL) )
> - mem_access_resume(v->domain);
> -}
> -#endif
> -
> -#ifdef HAS_MEM_SHARING
> -/* Registered with Xen-bound event channel for incoming notifications. */
> -static void mem_sharing_notification(struct vcpu *v, unsigned int port)
> -{
> - if ( likely(v->domain->mem_event->share.ring_page != NULL) )
> - mem_sharing_sharing_resume(v->domain);
> -}
> -#endif
> -
> -int do_mem_event_op(int op, uint32_t domain, void *arg)
> -{
> - int ret;
> - struct domain *d;
> -
> - ret = rcu_lock_live_remote_domain_by_id(domain, &d);
> - if ( ret )
> - return ret;
> -
> - ret = xsm_mem_event_op(XSM_DM_PRIV, d, op);
> - if ( ret )
> - goto out;
> -
> - switch (op)
> - {
> -#ifdef HAS_MEM_PAGING
> - case XENMEM_paging_op:
> - ret = mem_paging_memop(d, (xen_mem_paging_op_t *) arg);
> - break;
> -#endif
> -#ifdef HAS_MEM_SHARING
> - case XENMEM_sharing_op:
> - ret = mem_sharing_memop(d, (xen_mem_sharing_op_t *) arg);
> - break;
> -#endif
> - default:
> - ret = -ENOSYS;
> - }
> -
> - out:
> - rcu_unlock_domain(d);
> - return ret;
> -}
> -
> -/* Clean up on domain destruction */
> -void mem_event_cleanup(struct domain *d)
> -{
> -#ifdef HAS_MEM_PAGING
> - if ( d->mem_event->paging.ring_page ) {
> - /* Destroying the wait queue head means waking up all
> - * queued vcpus. This will drain the list, allowing
> - * the disable routine to complete. It will also drop
> - * all domain refs the wait-queued vcpus are holding.
> - * Finally, because this code path involves previously
> - * pausing the domain (domain_kill), unpausing the
> - * vcpus causes no harm. */
> - destroy_waitqueue_head(&d->mem_event->paging.wq);
> - (void)mem_event_disable(d, &d->mem_event->paging);
> - }
> -#endif
> -#ifdef HAS_MEM_ACCESS
> - if ( d->mem_event->monitor.ring_page ) {
> - destroy_waitqueue_head(&d->mem_event->monitor.wq);
> - (void)mem_event_disable(d, &d->mem_event->monitor);
> - }
> -#endif
> -#ifdef HAS_MEM_SHARING
> - if ( d->mem_event->share.ring_page ) {
> - destroy_waitqueue_head(&d->mem_event->share.wq);
> - (void)mem_event_disable(d, &d->mem_event->share);
> - }
> -#endif
> -}
> -
> -int mem_event_domctl(struct domain *d, xen_domctl_mem_event_op_t *mec,
> - XEN_GUEST_HANDLE_PARAM(void) u_domctl)
> -{
> - int rc;
> -
> - rc = xsm_mem_event_control(XSM_PRIV, d, mec->mode, mec->op);
> - if ( rc )
> - return rc;
> -
> - if ( unlikely(d == current->domain) )
> - {
> - gdprintk(XENLOG_INFO, "Tried to do a memory event op on itself.\n");
> - return -EINVAL;
> - }
> -
> - if ( unlikely(d->is_dying) )
> - {
> - gdprintk(XENLOG_INFO, "Ignoring memory event op on dying domain %u\n",
> - d->domain_id);
> - return 0;
> - }
> -
> - if ( unlikely(d->vcpu == NULL) || unlikely(d->vcpu[0] == NULL) )
> - {
> - gdprintk(XENLOG_INFO,
> - "Memory event op on a domain (%u) with no vcpus\n",
> - d->domain_id);
> - return -EINVAL;
> - }
> -
> - rc = -ENOSYS;
> -
> - switch ( mec->mode )
> - {
> -#ifdef HAS_MEM_PAGING
> - case XEN_DOMCTL_MEM_EVENT_OP_PAGING:
> - {
> - struct mem_event_domain *med = &d->mem_event->paging;
> - rc = -EINVAL;
> -
> - switch( mec->op )
> - {
> - case XEN_DOMCTL_MEM_EVENT_OP_PAGING_ENABLE:
> - {
> - struct p2m_domain *p2m = p2m_get_hostp2m(d);
> -
> - rc = -EOPNOTSUPP;
> - /* pvh fixme: p2m_is_foreign types need addressing */
> - if ( is_pvh_vcpu(current) || is_pvh_domain(hardware_domain) )
> - break;
> -
> - rc = -ENODEV;
> - /* Only HAP is supported */
> - if ( !hap_enabled(d) )
> - break;
> -
> - /* No paging if iommu is used */
> - rc = -EMLINK;
> - if ( unlikely(need_iommu(d)) )
> - break;
> -
> - rc = -EXDEV;
> - /* Disallow paging in a PoD guest */
> - if ( p2m->pod.entry_count )
> - break;
> -
> - rc = mem_event_enable(d, mec, med, _VPF_mem_paging,
> - HVM_PARAM_PAGING_RING_PFN,
> - mem_paging_notification);
> - }
> - break;
> -
> - case XEN_DOMCTL_MEM_EVENT_OP_PAGING_DISABLE:
> - {
> - if ( med->ring_page )
> - rc = mem_event_disable(d, med);
> - }
> - break;
> -
> - default:
> - rc = -ENOSYS;
> - break;
> - }
> - }
> - break;
> -#endif
> -
> -#ifdef HAS_MEM_ACCESS
> - case XEN_DOMCTL_MEM_EVENT_OP_MONITOR:
> - {
> - struct mem_event_domain *med = &d->mem_event->monitor;
> - rc = -EINVAL;
> -
> - switch( mec->op )
> - {
> - case XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE:
> - case XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION:
> - {
> - rc = -ENODEV;
> - if ( !p2m_mem_event_sanity_check(d) )
> - break;
> -
> - rc = mem_event_enable(d, mec, med, _VPF_mem_access,
> - HVM_PARAM_MONITOR_RING_PFN,
> - mem_access_notification);
> -
> - if ( mec->op == XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION
> - && !rc )
> - p2m_setup_introspection(d);
> -
> - }
> - break;
> -
> - case XEN_DOMCTL_MEM_EVENT_OP_MONITOR_DISABLE:
> - {
> - if ( med->ring_page )
> - {
> - rc = mem_event_disable(d, med);
> - d->arch.hvm_domain.introspection_enabled = 0;
> - }
> - }
> - break;
> -
> - default:
> - rc = -ENOSYS;
> - break;
> - }
> - }
> - break;
> -#endif
> -
> -#ifdef HAS_MEM_SHARING
> - case XEN_DOMCTL_MEM_EVENT_OP_SHARING:
> - {
> - struct mem_event_domain *med = &d->mem_event->share;
> - rc = -EINVAL;
> -
> - switch( mec->op )
> - {
> - case XEN_DOMCTL_MEM_EVENT_OP_SHARING_ENABLE:
> - {
> - rc = -EOPNOTSUPP;
> - /* pvh fixme: p2m_is_foreign types need addressing */
> - if ( is_pvh_vcpu(current) || is_pvh_domain(hardware_domain) )
> - break;
> -
> - rc = -ENODEV;
> - /* Only HAP is supported */
> - if ( !hap_enabled(d) )
> - break;
> -
> - rc = mem_event_enable(d, mec, med, _VPF_mem_sharing,
> - HVM_PARAM_SHARING_RING_PFN,
> - mem_sharing_notification);
> - }
> - break;
> -
> - case XEN_DOMCTL_MEM_EVENT_OP_SHARING_DISABLE:
> - {
> - if ( med->ring_page )
> - rc = mem_event_disable(d, med);
> - }
> - break;
> -
> - default:
> - rc = -ENOSYS;
> - break;
> - }
> - }
> - break;
> -#endif
> -
> - default:
> - rc = -ENOSYS;
> - }
> -
> - return rc;
> -}
> -
> -void mem_event_vcpu_pause(struct vcpu *v)
> -{
> - ASSERT(v == current);
> -
> - atomic_inc(&v->mem_event_pause_count);
> - vcpu_pause_nosync(v);
> -}
> -
> -void mem_event_vcpu_unpause(struct vcpu *v)
> -{
> - int old, new, prev = v->mem_event_pause_count.counter;
> -
> - /* All unpause requests as a result of toolstack responses. Prevent
> - * underflow of the vcpu pause count. */
> - do
> - {
> - old = prev;
> - new = old - 1;
> -
> - if ( new < 0 )
> - {
> - printk(XENLOG_G_WARNING
> - "%pv mem_event: Too many unpause attempts\n", v);
> - return;
> - }
> -
> - prev = cmpxchg(&v->mem_event_pause_count.counter, old, new);
> - } while ( prev != old );
> -
> - vcpu_unpause(v);
> -}
> -
> -/*
> - * Local variables:
> - * mode: C
> - * c-file-style: "BSD"
> - * c-basic-offset: 4
> - * indent-tabs-mode: nil
> - * End:
> - */
> diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
> new file mode 100644
> index 0000000..f81eae4
> --- /dev/null
> +++ b/xen/common/vm_event.c
> @@ -0,0 +1,742 @@
> +/******************************************************************************
> + * vm_event.c
> + *
> + * VM event support.
> + *
> + * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp)
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> + */
> +
> +
> +#include <xen/sched.h>
> +#include <xen/event.h>
> +#include <xen/wait.h>
> +#include <xen/vm_event.h>
> +#include <xen/mem_access.h>
> +#include <asm/p2m.h>
> +
> +#ifdef HAS_MEM_PAGING
> +#include <asm/mem_paging.h>
> +#endif
> +
> +#ifdef HAS_MEM_SHARING
> +#include <asm/mem_sharing.h>
> +#endif
> +
> +#include <xsm/xsm.h>
> +
> +/* for public/io/ring.h macros */
> +#define xen_mb() mb()
> +#define xen_rmb() rmb()
> +#define xen_wmb() wmb()
> +
> +#define vm_event_ring_lock_init(_ved) spin_lock_init(&(_ved)->ring_lock)
> +#define vm_event_ring_lock(_ved) spin_lock(&(_ved)->ring_lock)
> +#define vm_event_ring_unlock(_ved) spin_unlock(&(_ved)->ring_lock)
> +
> +static int vm_event_enable(
> + struct domain *d,
> + xen_domctl_vm_event_op_t *vec,
> + struct vm_event_domain *ved,
> + int pause_flag,
> + int param,
> + xen_event_channel_notification_t notification_fn)
> +{
> + int rc;
> + unsigned long ring_gfn = d->arch.hvm_domain.params[param];
> +
> + /* Only one helper at a time. If the helper crashed,
> + * the ring is in an undefined state and so is the guest.
> + */
> + if ( ved->ring_page )
> + return -EBUSY;
> +
> + /* The parameter defaults to zero, and it should be
> + * set to something */
> + if ( ring_gfn == 0 )
> + return -ENOSYS;
> +
> + vm_event_ring_lock_init(ved);
> + vm_event_ring_lock(ved);
> +
> + rc = prepare_ring_for_helper(d, ring_gfn, &ved->ring_pg_struct,
> + &ved->ring_page);
> + if ( rc < 0 )
> + goto err;
> +
> + /* Set the number of currently blocked vCPUs to 0. */
> + ved->blocked = 0;
> +
> + /* Allocate event channel */
> + rc = alloc_unbound_xen_event_channel(d->vcpu[0],
> + current->domain->domain_id,
> + notification_fn);
> + if ( rc < 0 )
> + goto err;
> +
> + ved->xen_port = vec->port = rc;
> +
> + /* Prepare ring buffer */
> + FRONT_RING_INIT(&ved->front_ring,
> + (vm_event_sring_t *)ved->ring_page,
> + PAGE_SIZE);
> +
> + /* Save the pause flag for this particular ring. */
> + ved->pause_flag = pause_flag;
> +
> + /* Initialize the last-chance wait queue. */
> + init_waitqueue_head(&ved->wq);
> +
> + vm_event_ring_unlock(ved);
> + return 0;
> +
> + err:
> + destroy_ring_for_helper(&ved->ring_page,
> + ved->ring_pg_struct);
> + vm_event_ring_unlock(ved);
> +
> + return rc;
> +}
> +
> +static unsigned int vm_event_ring_available(struct vm_event_domain *ved)
> +{
> + int avail_req = RING_FREE_REQUESTS(&ved->front_ring);
> + avail_req -= ved->target_producers;
> + avail_req -= ved->foreign_producers;
> +
> + BUG_ON(avail_req < 0);
> +
> + return avail_req;
> +}
> +
> +/*
> + * vm_event_wake_blocked() will wakeup vcpus waiting for room in the
> + * ring. These vCPUs were paused on their way out after placing an event,
> + * but need to be resumed where the ring is capable of processing at least
> + * one event from them.
> + */
> +static void vm_event_wake_blocked(struct domain *d, struct vm_event_domain *ved)
> +{
> + struct vcpu *v;
> + int online = d->max_vcpus;
> + unsigned int avail_req = vm_event_ring_available(ved);
> +
> + if ( avail_req == 0 || ved->blocked == 0 )
> + return;
> +
> + /*
> + * We ensure that we only have vCPUs online if there are enough free slots
> + * for their memory events to be processed. This will ensure that no
> + * memory events are lost (due to the fact that certain types of events
> + * cannot be replayed, we need to ensure that there is space in the ring
> + * for when they are hit).
> + * See comment below in vm_event_put_request().
> + */
> + for_each_vcpu ( d, v )
> + if ( test_bit(ved->pause_flag, &v->pause_flags) )
> + online--;
> +
> + ASSERT(online == (d->max_vcpus - ved->blocked));
> +
> + /* We remember which vcpu last woke up to avoid scanning always linearly
> + * from zero and starving higher-numbered vcpus under high load */
> + if ( d->vcpu )
> + {
> + int i, j, k;
> +
> + for (i = ved->last_vcpu_wake_up + 1, j = 0; j < d->max_vcpus; i++, j++)
> + {
> + k = i % d->max_vcpus;
> + v = d->vcpu[k];
> + if ( !v )
> + continue;
> +
> + if ( !(ved->blocked) || online >= avail_req )
> + break;
> +
> + if ( test_and_clear_bit(ved->pause_flag, &v->pause_flags) )
> + {
> + vcpu_unpause(v);
> + online++;
> + ved->blocked--;
> + ved->last_vcpu_wake_up = k;
> + }
> + }
> + }
> +}
> +
> +/*
> + * In the event that a vCPU attempted to place an event in the ring and
> + * was unable to do so, it is queued on a wait queue. These are woken as
> + * needed, and take precedence over the blocked vCPUs.
> + */
> +static void vm_event_wake_queued(struct domain *d, struct vm_event_domain *ved)
> +{
> + unsigned int avail_req = vm_event_ring_available(ved);
> +
> + if ( avail_req > 0 )
> + wake_up_nr(&ved->wq, avail_req);
> +}
> +
> +/*
> + * vm_event_wake() will wakeup all vcpus waiting for the ring to
> + * become available. If we have queued vCPUs, they get top priority. We
> + * are guaranteed that they will go through code paths that will eventually
> + * call vm_event_wake() again, ensuring that any blocked vCPUs will get
> + * unpaused once all the queued vCPUs have made it through.
> + */
> +void vm_event_wake(struct domain *d, struct vm_event_domain *ved)
> +{
> + if (!list_empty(&ved->wq.list))
> + vm_event_wake_queued(d, ved);
> + else
> + vm_event_wake_blocked(d, ved);
> +}
> +
> +static int vm_event_disable(struct domain *d, struct vm_event_domain *ved)
> +{
> + if ( ved->ring_page )
> + {
> + struct vcpu *v;
> +
> + vm_event_ring_lock(ved);
> +
> + if ( !list_empty(&ved->wq.list) )
> + {
> + vm_event_ring_unlock(ved);
> + return -EBUSY;
> + }
> +
> + /* Free domU's event channel and leave the other one unbound */
> + free_xen_event_channel(d->vcpu[0], ved->xen_port);
> +
> + /* Unblock all vCPUs */
> + for_each_vcpu ( d, v )
> + {
> + if ( test_and_clear_bit(ved->pause_flag, &v->pause_flags) )
> + {
> + vcpu_unpause(v);
> + ved->blocked--;
> + }
> + }
> +
> + destroy_ring_for_helper(&ved->ring_page,
> + ved->ring_pg_struct);
> + vm_event_ring_unlock(ved);
> + }
> +
> + return 0;
> +}
> +
> +static inline void vm_event_release_slot(struct domain *d,
> + struct vm_event_domain *ved)
> +{
> + /* Update the accounting */
> + if ( current->domain == d )
> + ved->target_producers--;
> + else
> + ved->foreign_producers--;
> +
> + /* Kick any waiters */
> + vm_event_wake(d, ved);
> +}
> +
> +/*
> + * vm_event_mark_and_pause() tags vcpu and put it to sleep.
> + * The vcpu will resume execution in vm_event_wake_waiters().
> + */
> +void vm_event_mark_and_pause(struct vcpu *v, struct vm_event_domain *ved)
> +{
> + if ( !test_and_set_bit(ved->pause_flag, &v->pause_flags) )
> + {
> + vcpu_pause_nosync(v);
> + ved->blocked++;
> + }
> +}
> +
> +/*
> + * This must be preceded by a call to claim_slot(), and is guaranteed to
> + * succeed. As a side-effect however, the vCPU may be paused if the ring is
> + * overly full and its continued execution would cause stalling and excessive
> + * waiting. The vCPU will be automatically unpaused when the ring clears.
> + */
> +void vm_event_put_request(struct domain *d,
> + struct vm_event_domain *ved,
> + vm_event_request_t *req)
> +{
> + vm_event_front_ring_t *front_ring;
> + int free_req;
> + unsigned int avail_req;
> + RING_IDX req_prod;
> +
> + if ( current->domain != d )
> + {
> + req->flags |= VM_EVENT_FLAG_FOREIGN;
> +#ifndef NDEBUG
> + if ( !(req->flags & VM_EVENT_FLAG_VCPU_PAUSED) )
> + gdprintk(XENLOG_G_WARNING, "d%dv%d was not paused.\n",
> + d->domain_id, req->vcpu_id);
> +#endif
> + }
> +
> + vm_event_ring_lock(ved);
> +
> + /* Due to the reservations, this step must succeed. */
> + front_ring = &ved->front_ring;
> + free_req = RING_FREE_REQUESTS(front_ring);
> + ASSERT(free_req > 0);
> +
> + /* Copy request */
> + req_prod = front_ring->req_prod_pvt;
> + memcpy(RING_GET_REQUEST(front_ring, req_prod), req, sizeof(*req));
> + req_prod++;
> +
> + /* Update ring */
> + front_ring->req_prod_pvt = req_prod;
> + RING_PUSH_REQUESTS(front_ring);
> +
> + /* We've actually *used* our reservation, so release the slot. */
> + vm_event_release_slot(d, ved);
> +
> + /* Give this vCPU a black eye if necessary, on the way out.
> + * See the comments above wake_blocked() for more information
> + * on how this vechanism works to avoid waiting. */
> + avail_req = vm_event_ring_available(ved);
> + if( current->domain == d && avail_req < d->max_vcpus )
> + vm_event_mark_and_pause(current, ved);
> +
> + vm_event_ring_unlock(ved);
> +
> + notify_via_xen_event_channel(d, ved->xen_port);
> +}
> +
> +int vm_event_get_response(struct domain *d, struct vm_event_domain *ved, vm_event_response_t *rsp)
> +{
> + vm_event_front_ring_t *front_ring;
> + RING_IDX rsp_cons;
> +
> + vm_event_ring_lock(ved);
> +
> + front_ring = &ved->front_ring;
> + rsp_cons = front_ring->rsp_cons;
> +
> + if ( !RING_HAS_UNCONSUMED_RESPONSES(front_ring) )
> + {
> + vm_event_ring_unlock(ved);
> + return 0;
> + }
> +
> + /* Copy response */
> + memcpy(rsp, RING_GET_RESPONSE(front_ring, rsp_cons), sizeof(*rsp));
> + rsp_cons++;
> +
> + /* Update ring */
> + front_ring->rsp_cons = rsp_cons;
> + front_ring->sring->rsp_event = rsp_cons + 1;
> +
> + /* Kick any waiters -- since we've just consumed an event,
> + * there may be additional space available in the ring. */
> + vm_event_wake(d, ved);
> +
> + vm_event_ring_unlock(ved);
> +
> + return 1;
> +}
> +
> +void vm_event_cancel_slot(struct domain *d, struct vm_event_domain *ved)
> +{
> + vm_event_ring_lock(ved);
> + vm_event_release_slot(d, ved);
> + vm_event_ring_unlock(ved);
> +}
> +
> +static int vm_event_grab_slot(struct vm_event_domain *ved, int foreign)
> +{
> + unsigned int avail_req;
> +
> + if ( !ved->ring_page )
> + return -ENOSYS;
> +
> + vm_event_ring_lock(ved);
> +
> + avail_req = vm_event_ring_available(ved);
> + if ( avail_req == 0 )
> + {
> + vm_event_ring_unlock(ved);
> + return -EBUSY;
> + }
> +
> + if ( !foreign )
> + ved->target_producers++;
> + else
> + ved->foreign_producers++;
> +
> + vm_event_ring_unlock(ved);
> +
> + return 0;
> +}
> +
> +/* Simple try_grab wrapper for use in the wait_event() macro. */
> +static int vm_event_wait_try_grab(struct vm_event_domain *ved, int *rc)
> +{
> + *rc = vm_event_grab_slot(ved, 0);
> + return *rc;
> +}
> +
> +/* Call vm_event_grab_slot() until the ring doesn't exist, or is available. */
> +static int vm_event_wait_slot(struct vm_event_domain *ved)
> +{
> + int rc = -EBUSY;
> + wait_event(ved->wq, vm_event_wait_try_grab(ved, &rc) != -EBUSY);
> + return rc;
> +}
> +
> +bool_t vm_event_check_ring(struct vm_event_domain *ved)
> +{
> + return (ved->ring_page != NULL);
> +}
> +
> +/*
> + * Determines whether or not the current vCPU belongs to the target domain,
> + * and calls the appropriate wait function. If it is a guest vCPU, then we
> + * use vm_event_wait_slot() to reserve a slot. As long as there is a ring,
> + * this function will always return 0 for a guest. For a non-guest, we check
> + * for space and return -EBUSY if the ring is not available.
> + *
> + * Return codes: -ENOSYS: the ring is not yet configured
> + * -EBUSY: the ring is busy
> + * 0: a spot has been reserved
> + *
> + */
> +int __vm_event_claim_slot(struct domain *d, struct vm_event_domain *ved,
> + bool_t allow_sleep)
> +{
> + if ( (current->domain == d) && allow_sleep )
> + return vm_event_wait_slot(ved);
> + else
> + return vm_event_grab_slot(ved, (current->domain != d));
> +}
> +
> +#ifdef HAS_MEM_PAGING
> +/* Registered with Xen-bound event channel for incoming notifications. */
> +static void mem_paging_notification(struct vcpu *v, unsigned int port)
> +{
> + if ( likely(v->domain->vm_event->paging.ring_page != NULL) )
> + p2m_mem_paging_resume(v->domain);
> +}
> +#endif
> +
> +#ifdef HAS_MEM_ACCESS
> +/* Registered with Xen-bound event channel for incoming notifications. */
> +static void mem_access_notification(struct vcpu *v, unsigned int port)
> +{
> + if ( likely(v->domain->vm_event->monitor.ring_page != NULL) )
> + mem_access_resume(v->domain);
> +}
> +#endif
> +
> +#ifdef HAS_MEM_SHARING
> +/* Registered with Xen-bound event channel for incoming notifications. */
> +static void mem_sharing_notification(struct vcpu *v, unsigned int port)
> +{
> + if ( likely(v->domain->vm_event->share.ring_page != NULL) )
> + mem_sharing_sharing_resume(v->domain);
> +}
> +#endif
> +
> +int do_vm_event_op(int op, uint32_t domain, void *arg)
> +{
> + int ret;
> + struct domain *d;
> +
> + ret = rcu_lock_live_remote_domain_by_id(domain, &d);
> + if ( ret )
> + return ret;
> +
> + ret = xsm_vm_event_op(XSM_DM_PRIV, d, op);
> + if ( ret )
> + goto out;
> +
> + switch (op)
> + {
> +#ifdef HAS_MEM_PAGING
> + case XENMEM_paging_op:
> + ret = mem_paging_memop(d, (xen_mem_paging_op_t *) arg);
> + break;
> +#endif
> +#ifdef HAS_MEM_SHARING
> + case XENMEM_sharing_op:
> + ret = mem_sharing_memop(d, (xen_mem_sharing_op_t *) arg);
> + break;
> +#endif
> + default:
> + ret = -ENOSYS;
> + }
> +
> + out:
> + rcu_unlock_domain(d);
> + return ret;
> +}
> +
> +/* Clean up on domain destruction */
> +void vm_event_cleanup(struct domain *d)
> +{
> +#ifdef HAS_MEM_PAGING
> + if ( d->vm_event->paging.ring_page ) {
> + /* Destroying the wait queue head means waking up all
> + * queued vcpus. This will drain the list, allowing
> + * the disable routine to complete. It will also drop
> + * all domain refs the wait-queued vcpus are holding.
> + * Finally, because this code path involves previously
> + * pausing the domain (domain_kill), unpausing the
> + * vcpus causes no harm. */
> + destroy_waitqueue_head(&d->vm_event->paging.wq);
> + (void)vm_event_disable(d, &d->vm_event->paging);
> + }
> +#endif
> +#ifdef HAS_MEM_ACCESS
> + if ( d->vm_event->monitor.ring_page ) {
> + destroy_waitqueue_head(&d->vm_event->monitor.wq);
> + (void)vm_event_disable(d, &d->vm_event->monitor);
> + }
> +#endif
> +#ifdef HAS_MEM_SHARING
> + if ( d->vm_event->share.ring_page ) {
> + destroy_waitqueue_head(&d->vm_event->share.wq);
> + (void)vm_event_disable(d, &d->vm_event->share);
> + }
> +#endif
> +}
> +
> +int vm_event_domctl(struct domain *d, xen_domctl_vm_event_op_t *vec,
> + XEN_GUEST_HANDLE_PARAM(void) u_domctl)
> +{
> + int rc;
> +
> + rc = xsm_vm_event_control(XSM_PRIV, d, vec->mode, vec->op);
> + if ( rc )
> + return rc;
> +
> + if ( unlikely(d == current->domain) )
> + {
> + gdprintk(XENLOG_INFO, "Tried to do a memory event op on itself.\n");
> + return -EINVAL;
> + }
> +
> + if ( unlikely(d->is_dying) )
> + {
> + gdprintk(XENLOG_INFO, "Ignoring memory event op on dying domain %u\n",
> + d->domain_id);
> + return 0;
> + }
> +
> + if ( unlikely(d->vcpu == NULL) || unlikely(d->vcpu[0] == NULL) )
> + {
> + gdprintk(XENLOG_INFO,
> + "Memory event op on a domain (%u) with no vcpus\n",
> + d->domain_id);
> + return -EINVAL;
> + }
> +
> + rc = -ENOSYS;
> +
> + switch ( vec->mode )
> + {
> +#ifdef HAS_MEM_PAGING
> + case XEN_DOMCTL_VM_EVENT_OP_PAGING:
> + {
> + struct vm_event_domain *ved = &d->vm_event->paging;
> + rc = -EINVAL;
> +
> + switch( vec->op )
> + {
> + case XEN_DOMCTL_VM_EVENT_OP_PAGING_ENABLE:
> + {
> + struct p2m_domain *p2m = p2m_get_hostp2m(d);
> +
> + rc = -EOPNOTSUPP;
> + /* pvh fixme: p2m_is_foreign types need addressing */
> + if ( is_pvh_vcpu(current) || is_pvh_domain(hardware_domain) )
> + break;
> +
> + rc = -ENODEV;
> + /* Only HAP is supported */
> + if ( !hap_enabled(d) )
> + break;
> +
> + /* No paging if iommu is used */
> + rc = -EMLINK;
> + if ( unlikely(need_iommu(d)) )
> + break;
> +
> + rc = -EXDEV;
> + /* Disallow paging in a PoD guest */
> + if ( p2m->pod.entry_count )
> + break;
> +
> + rc = vm_event_enable(d, vec, ved, _VPF_mem_paging,
> + HVM_PARAM_PAGING_RING_PFN,
> + mem_paging_notification);
> + }
> + break;
> +
> + case XEN_DOMCTL_VM_EVENT_OP_PAGING_DISABLE:
> + {
> + if ( ved->ring_page )
> + rc = vm_event_disable(d, ved);
> + }
> + break;
> +
> + default:
> + rc = -ENOSYS;
> + break;
> + }
> + }
> + break;
> +#endif
> +
> +#ifdef HAS_MEM_ACCESS
> + case XEN_DOMCTL_VM_EVENT_OP_MONITOR:
> + {
> + struct vm_event_domain *ved = &d->vm_event->monitor;
> + rc = -EINVAL;
> +
> + switch( vec->op )
> + {
> + case XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE:
> + case XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION:
> + {
> + rc = -ENODEV;
> + if ( !p2m_mem_access_sanity_check(d) )
> + break;
> +
> + rc = vm_event_enable(d, vec, ved, _VPF_mem_access,
> + HVM_PARAM_MONITOR_RING_PFN,
> + mem_access_notification);
> +
> + if ( vec->op == XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION
> + && !rc )
> + p2m_setup_introspection(d);
> +
> + }
> + break;
> +
> + case XEN_DOMCTL_VM_EVENT_OP_MONITOR_DISABLE:
> + {
> + if ( ved->ring_page )
> + {
> + rc = vm_event_disable(d, ved);
> + d->arch.hvm_domain.introspection_enabled = 0;
> + }
> + }
> + break;
> +
> + default:
> + rc = -ENOSYS;
> + break;
> + }
> + }
> + break;
> +#endif
> +
> +#ifdef HAS_MEM_SHARING
> + case XEN_DOMCTL_VM_EVENT_OP_SHARING:
> + {
> + struct vm_event_domain *ved = &d->vm_event->share;
> + rc = -EINVAL;
> +
> + switch( vec->op )
> + {
> + case XEN_DOMCTL_VM_EVENT_OP_SHARING_ENABLE:
> + {
> + rc = -EOPNOTSUPP;
> + /* pvh fixme: p2m_is_foreign types need addressing */
> + if ( is_pvh_vcpu(current) || is_pvh_domain(hardware_domain) )
> + break;
> +
> + rc = -ENODEV;
> + /* Only HAP is supported */
> + if ( !hap_enabled(d) )
> + break;
> +
> + rc = vm_event_enable(d, vec, ved, _VPF_mem_sharing,
> + HVM_PARAM_SHARING_RING_PFN,
> + mem_sharing_notification);
> + }
> + break;
> +
> + case XEN_DOMCTL_VM_EVENT_OP_SHARING_DISABLE:
> + {
> + if ( ved->ring_page )
> + rc = vm_event_disable(d, ved);
> + }
> + break;
> +
> + default:
> + rc = -ENOSYS;
> + break;
> + }
> + }
> + break;
> +#endif
> +
> + default:
> + rc = -ENOSYS;
> + }
> +
> + return rc;
> +}
> +
> +void vm_event_vcpu_pause(struct vcpu *v)
> +{
> + ASSERT(v == current);
> +
> + atomic_inc(&v->vm_event_pause_count);
> + vcpu_pause_nosync(v);
> +}
> +
> +void vm_event_vcpu_unpause(struct vcpu *v)
> +{
> + int old, new, prev = v->vm_event_pause_count.counter;
> +
> + /* All unpause requests as a result of toolstack responses. Prevent
> + * underflow of the vcpu pause count. */
> + do
> + {
> + old = prev;
> + new = old - 1;
> +
> + if ( new < 0 )
> + {
> + printk(XENLOG_G_WARNING
> + "%pv vm_event: Too many unpause attempts\n", v);
> + return;
> + }
> +
> + prev = cmpxchg(&v->vm_event_pause_count.counter, old, new);
> + } while ( prev != old );
> +
> + vcpu_unpause(v);
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 78c6977..964384b 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -1346,7 +1346,7 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn)
> * enabled for this domain */
> if ( unlikely(!need_iommu(d) &&
> (d->arch.hvm_domain.mem_sharing_enabled ||
> - d->mem_event->paging.ring_page ||
> + d->vm_event->paging.ring_page ||
> p2m_get_hostp2m(d)->global_logdirty)) )
> return -EXDEV;
>
> diff --git a/xen/include/Makefile b/xen/include/Makefile
> index 530db83..537a1f5 100644
> --- a/xen/include/Makefile
> +++ b/xen/include/Makefile
> @@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>
> all: headers.chk
>
> -headers.chk: $(filter-out public/arch-% public/%ctl.h public/mem_event.h public/xsm/% public/%hvm/save.h, $(wildcard public/*.h public/*/*.h) $(public-y)) Makefile
> +headers.chk: $(filter-out public/arch-% public/%ctl.h public/vm_event.h public/xsm/% public/%hvm/save.h, $(wildcard public/*.h public/*/*.h) $(public-y)) Makefile
> for i in $(filter %.h,$^); do $(CC) -ansi -include stdint.h -Wall -W -Werror -S -o /dev/null -x c $$i || exit 1; echo $$i; done >$@.new
> mv $@.new $@
>
> diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
> index da36504..e1a72d5 100644
> --- a/xen/include/asm-arm/p2m.h
> +++ b/xen/include/asm-arm/p2m.h
> @@ -45,7 +45,7 @@ struct p2m_domain {
> unsigned long shattered[4];
> } stats;
>
> - /* If true, and an access fault comes in and there is no mem_event listener,
> + /* If true, and an access fault comes in and there is no vm_event listener,
> * pause domain. Otherwise, remove access restrictions. */
> bool_t access_required;
> };
> @@ -71,8 +71,8 @@ typedef enum {
> } p2m_type_t;
>
> static inline
> -void p2m_mem_event_emulate_check(struct vcpu *v,
> - const mem_event_response_t *rsp)
> +void p2m_mem_access_emulate_check(struct vcpu *v,
> + const vm_event_response_t *rsp)
> {
> /* Not supported on ARM. */
> };
> diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h
> index 6a77a93..20ede1e 100644
> --- a/xen/include/asm-x86/domain.h
> +++ b/xen/include/asm-x86/domain.h
> @@ -478,13 +478,13 @@ struct arch_vcpu
>
> /*
> * Should we emulate the next matching instruction on VCPU resume
> - * after a mem_event?
> + * after a vm_event?
> */
> struct {
> uint32_t emulate_flags;
> unsigned long gpa;
> unsigned long eip;
> - } mem_event;
> + } vm_event;
>
> } __cacheline_aligned;
>
> diff --git a/xen/include/asm-x86/hvm/emulate.h b/xen/include/asm-x86/hvm/emulate.h
> index 5411302..b3971c8 100644
> --- a/xen/include/asm-x86/hvm/emulate.h
> +++ b/xen/include/asm-x86/hvm/emulate.h
> @@ -38,7 +38,7 @@ int hvm_emulate_one(
> struct hvm_emulate_ctxt *hvmemul_ctxt);
> int hvm_emulate_one_no_write(
> struct hvm_emulate_ctxt *hvmemul_ctxt);
> -void hvm_mem_event_emulate_one(bool_t nowrite,
> +void hvm_mem_access_emulate_one(bool_t nowrite,
> unsigned int trapnr,
> unsigned int errcode);
> void hvm_emulate_prepare(
> diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h
> index 5f7fe71..2ee863b 100644
> --- a/xen/include/asm-x86/p2m.h
> +++ b/xen/include/asm-x86/p2m.h
> @@ -238,7 +238,7 @@ struct p2m_domain {
> * retyped get this access type. See definition of p2m_access_t. */
> p2m_access_t default_access;
>
> - /* If true, and an access fault comes in and there is no mem_event listener,
> + /* If true, and an access fault comes in and there is no vm_event listener,
> * pause domain. Otherwise, remove access restrictions. */
> bool_t access_required;
>
> @@ -572,7 +572,7 @@ void p2m_mem_paging_resume(struct domain *d);
> * locks -- caller must also xfree the request. */
> bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
> struct npfec npfec,
> - mem_event_request_t **req_ptr);
> + vm_event_request_t **req_ptr);
>
> /* Set access type for a region of pfns.
> * If start_pfn == -1ul, sets the default access type */
> @@ -586,22 +586,16 @@ int p2m_get_mem_access(struct domain *d, unsigned long pfn,
>
> /* Check for emulation and mark vcpu for skipping one instruction
> * upon rescheduling if required. */
> -void p2m_mem_event_emulate_check(struct vcpu *v,
> - const mem_event_response_t *rsp);
> +void p2m_mem_access_emulate_check(struct vcpu *v,
> + const vm_event_response_t *rsp);
>
> /* Enable arch specific introspection options (such as MSR interception). */
> void p2m_setup_introspection(struct domain *d);
>
> -/* Sanity check for mem_event hardware support */
> -static inline bool_t p2m_mem_event_sanity_check(struct domain *d)
> -{
> - return hap_enabled(d) && cpu_has_vmx;
> -}
> -
> /* Sanity check for mem_access hardware support */
> static inline bool_t p2m_mem_access_sanity_check(struct domain *d)
> {
> - return is_hvm_domain(d);
> + return hap_enabled(d) && cpu_has_vmx && is_hvm_domain(d);
> }
>
> /*
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 0e3aaf1..1d4b241 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -753,7 +753,7 @@ struct xen_domctl_gdbsx_domstatus {
> * Memory event operations
> */
>
> -/* XEN_DOMCTL_mem_event_op */
> +/* XEN_DOMCTL_vm_event_op */
>
> /*
> * Domain memory paging
> @@ -762,17 +762,17 @@ struct xen_domctl_gdbsx_domstatus {
> * pager<->hypervisor interface. Use XENMEM_paging_op*
> * to perform per-page operations.
> *
> - * The XEN_DOMCTL_MEM_EVENT_OP_PAGING_ENABLE domctl returns several
> + * The XEN_DOMCTL_VM_EVENT_OP_PAGING_ENABLE domctl returns several
> * non-standard error codes to indicate why paging could not be enabled:
> * ENODEV - host lacks HAP support (EPT/NPT) or HAP is disabled in guest
> * EMLINK - guest has iommu passthrough enabled
> * EXDEV - guest has PoD enabled
> * EBUSY - guest has or had paging enabled, ring buffer still active
> */
> -#define XEN_DOMCTL_MEM_EVENT_OP_PAGING 1
> +#define XEN_DOMCTL_VM_EVENT_OP_PAGING 1
>
> -#define XEN_DOMCTL_MEM_EVENT_OP_PAGING_ENABLE 0
> -#define XEN_DOMCTL_MEM_EVENT_OP_PAGING_DISABLE 1
> +#define XEN_DOMCTL_VM_EVENT_OP_PAGING_ENABLE 0
> +#define XEN_DOMCTL_VM_EVENT_OP_PAGING_DISABLE 1
>
> /*
> * Monitor permissions.
> @@ -783,21 +783,21 @@ struct xen_domctl_gdbsx_domstatus {
> * There are HVM hypercalls to set the per-page access permissions of every
> * page in a domain. When one of these permissions--independent, read,
> * write, and execute--is violated, the VCPU is paused and a memory event
> - * is sent with what happened. (See public/mem_event.h) .
> + * is sent with what happened. (See public/vm_event.h) .
> *
> * The memory event handler can then resume the VCPU and redo the access
> * with a XENMEM_access_op_resume hypercall.
> *
> - * The XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE domctl returns several
> + * The XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE domctl returns several
> * non-standard error codes to indicate why access could not be enabled:
> * ENODEV - host lacks HAP support (EPT/NPT) or HAP is disabled in guest
> * EBUSY - guest has or had access enabled, ring buffer still active
> */
> -#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR 2
> +#define XEN_DOMCTL_VM_EVENT_OP_MONITOR 2
>
> -#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE 0
> -#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_DISABLE 1
> -#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION 2
> +#define XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE 0
> +#define XEN_DOMCTL_VM_EVENT_OP_MONITOR_DISABLE 1
> +#define XEN_DOMCTL_VM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION 2
>
> /*
> * Sharing ENOMEM helper.
> @@ -812,21 +812,21 @@ struct xen_domctl_gdbsx_domstatus {
> * Note that shring can be turned on (as per the domctl below)
> * *without* this ring being setup.
> */
> -#define XEN_DOMCTL_MEM_EVENT_OP_SHARING 3
> +#define XEN_DOMCTL_VM_EVENT_OP_SHARING 3
>
> -#define XEN_DOMCTL_MEM_EVENT_OP_SHARING_ENABLE 0
> -#define XEN_DOMCTL_MEM_EVENT_OP_SHARING_DISABLE 1
> +#define XEN_DOMCTL_VM_EVENT_OP_SHARING_ENABLE 0
> +#define XEN_DOMCTL_VM_EVENT_OP_SHARING_DISABLE 1
>
> /* Use for teardown/setup of helper<->hypervisor interface for paging,
> * access and sharing.*/
> -struct xen_domctl_mem_event_op {
> - uint32_t op; /* XEN_DOMCTL_MEM_EVENT_OP_*_* */
> - uint32_t mode; /* XEN_DOMCTL_MEM_EVENT_OP_* */
> +struct xen_domctl_vm_event_op {
> + uint32_t op; /* XEN_DOMCTL_VM_EVENT_OP_*_* */
> + uint32_t mode; /* XEN_DOMCTL_VM_EVENT_OP_* */
>
> uint32_t port; /* OUT: event channel for ring */
> };
> -typedef struct xen_domctl_mem_event_op xen_domctl_mem_event_op_t;
> -DEFINE_XEN_GUEST_HANDLE(xen_domctl_mem_event_op_t);
> +typedef struct xen_domctl_vm_event_op xen_domctl_vm_event_op_t;
> +DEFINE_XEN_GUEST_HANDLE(xen_domctl_vm_event_op_t);
>
> /*
> * Memory sharing operations
> @@ -1049,7 +1049,7 @@ struct xen_domctl {
> #define XEN_DOMCTL_suppress_spurious_page_faults 53
> #define XEN_DOMCTL_debug_op 54
> #define XEN_DOMCTL_gethvmcontext_partial 55
> -#define XEN_DOMCTL_mem_event_op 56
> +#define XEN_DOMCTL_vm_event_op 56
> #define XEN_DOMCTL_mem_sharing_op 57
> #define XEN_DOMCTL_disable_migrate 58
> #define XEN_DOMCTL_gettscinfo 59
> @@ -1117,7 +1117,7 @@ struct xen_domctl {
> struct xen_domctl_set_target set_target;
> struct xen_domctl_subscribe subscribe;
> struct xen_domctl_debug_op debug_op;
> - struct xen_domctl_mem_event_op mem_event_op;
> + struct xen_domctl_vm_event_op vm_event_op;
> struct xen_domctl_mem_sharing_op mem_sharing_op;
> #if defined(__i386__) || defined(__x86_64__)
> struct xen_domctl_cpuid cpuid;
> diff --git a/xen/include/public/mem_event.h b/xen/include/public/mem_event.h
> deleted file mode 100644
> index dbcc48b..0000000
> --- a/xen/include/public/mem_event.h
> +++ /dev/null
> @@ -1,197 +0,0 @@
> -/******************************************************************************
> - * mem_event.h
> - *
> - * Memory event common structures.
> - *
> - * Copyright (c) 2009 by Citrix Systems, Inc. (Patrick Colp)
> - *
> - * Permission is hereby granted, free of charge, to any person obtaining a copy
> - * of this software and associated documentation files (the "Software"), to
> - * deal in the Software without restriction, including without limitation the
> - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> - * sell copies of the Software, and to permit persons to whom the Software is
> - * furnished to do so, subject to the following conditions:
> - *
> - * The above copyright notice and this permission notice shall be included in
> - * all copies or substantial portions of the Software.
> - *
> - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> - * DEALINGS IN THE SOFTWARE.
> - */
> -
> -#ifndef _XEN_PUBLIC_MEM_EVENT_H
> -#define _XEN_PUBLIC_MEM_EVENT_H
> -
> -#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
> -#error "vm event operations are intended for use only by Xen or node control tools"
> -#endif
> -
> -#include "xen.h"
> -#include "io/ring.h"
> -
> -#define MEM_EVENT_INTERFACE_VERSION 0x00000001
> -
> -/* Memory event flags */
> -#define MEM_EVENT_FLAG_VCPU_PAUSED (1 << 0)
> -#define MEM_EVENT_FLAG_DROP_PAGE (1 << 1)
> -#define MEM_EVENT_FLAG_EVICT_FAIL (1 << 2)
> -#define MEM_EVENT_FLAG_FOREIGN (1 << 3)
> -#define MEM_EVENT_FLAG_DUMMY (1 << 4)
> -/*
> - * Emulate the fault-causing instruction (if set in the event response flags).
> - * This will allow the guest to continue execution without lifting the page
> - * access restrictions.
> - */
> -#define MEM_EVENT_FLAG_EMULATE (1 << 5)
> -/*
> - * Same as MEM_EVENT_FLAG_EMULATE, but with write operations or operations
> - * potentially having side effects (like memory mapped or port I/O) disabled.
> - */
> -#define MEM_EVENT_FLAG_EMULATE_NOWRITE (1 << 6)
> -
> -/* Reasons for the vm event request */
> -/* Default case */
> -#define MEM_EVENT_REASON_UNKNOWN 0
> -/* Memory access violation */
> -#define MEM_EVENT_REASON_MEM_ACCESS_VIOLATION 1
> -/* Memory sharing event */
> -#define MEM_EVENT_REASON_MEM_SHARING 2
> -/* Memory paging event */
> -#define MEM_EVENT_REASON_MEM_PAGING 3
> -/* CR0 was updated */
> -#define MEM_EVENT_REASON_CR0 4
> -/* CR3 was updated */
> -#define MEM_EVENT_REASON_CR3 5
> -/* CR4 was updated */
> -#define MEM_EVENT_REASON_CR4 6
> -/* Debug operation executed (int3) */
> -#define MEM_EVENT_REASON_INT3 7
> -/* Single-step (MTF) */
> -#define MEM_EVENT_REASON_SINGLESTEP 8
> -/* An MSR was updated. Does NOT honour HVMPME_onchangeonly */
> -#define MEM_EVENT_REASON_MSR 9
> -
> -/* Using a custom struct (not hvm_hw_cpu) so as to not fill
> - * the mem_event ring buffer too quickly. */
> -struct mem_event_regs_x86 {
> - uint64_t rax;
> - uint64_t rcx;
> - uint64_t rdx;
> - uint64_t rbx;
> - uint64_t rsp;
> - uint64_t rbp;
> - uint64_t rsi;
> - uint64_t rdi;
> - uint64_t r8;
> - uint64_t r9;
> - uint64_t r10;
> - uint64_t r11;
> - uint64_t r12;
> - uint64_t r13;
> - uint64_t r14;
> - uint64_t r15;
> - uint64_t rflags;
> - uint64_t dr7;
> - uint64_t rip;
> - uint64_t cr0;
> - uint64_t cr2;
> - uint64_t cr3;
> - uint64_t cr4;
> - uint64_t sysenter_cs;
> - uint64_t sysenter_esp;
> - uint64_t sysenter_eip;
> - uint64_t msr_efer;
> - uint64_t msr_star;
> - uint64_t msr_lstar;
> - uint64_t fs_base;
> - uint64_t gs_base;
> - uint32_t cs_arbytes;
> - uint32_t _pad;
> -};
> -
> -struct mem_event_regs {
> - union {
> - struct mem_event_regs_x86 x86;
> - };
> -};
> -
> -struct mem_event_mem_access_data {
> - uint64_t gfn;
> - uint64_t offset;
> - uint64_t gla; /* if gla_valid */
> - uint16_t access_r:1;
> - uint16_t access_w:1;
> - uint16_t access_x:1;
> - uint16_t gla_valid:1;
> - uint16_t fault_with_gla:1;
> - uint16_t fault_in_gpt:1;
> - uint16_t available:10;
> -};
> -
> -struct mem_event_cr_data {
> - uint64_t new_value;
> - uint64_t old_value;
> -};
> -
> -struct mem_event_int3_data {
> - uint64_t gfn;
> - uint64_t gla;
> -};
> -
> -struct mem_event_singlestep_data {
> - uint64_t gfn;
> - uint64_t gla;
> -};
> -
> -struct mem_event_msr_data {
> - uint64_t msr;
> - uint64_t old_value;
> - uint64_t new_value;
> -};
> -
> -struct mem_event_paging_data {
> - uint64_t gfn;
> - uint32_t p2mt;
> -};
> -
> -struct mem_event_sharing_data {
> - uint64_t gfn;
> - uint32_t p2mt;
> -};
> -
> -typedef struct mem_event_st {
> - uint32_t flags;
> - uint32_t vcpu_id;
> - uint32_t reason;
> -
> - union {
> - struct mem_event_paging_data mem_paging_event;
> - struct mem_event_sharing_data mem_sharing_event;
> - struct mem_event_mem_access_data mem_access_event;
> - struct mem_event_cr_data cr_event;
> - struct mem_event_int3_data int3_event;
> - struct mem_event_singlestep_data singlestep_event;
> - struct mem_event_msr_data msr_event;
> - };
> -
> - struct mem_event_regs regs;
> -} mem_event_request_t, mem_event_response_t;
> -
> -DEFINE_RING_TYPES(mem_event, mem_event_request_t, mem_event_response_t);
> -
> -#endif
> -
> -/*
> - * Local variables:
> - * mode: C
> - * c-file-style: "BSD"
> - * c-basic-offset: 4
> - * tab-width: 4
> - * indent-tabs-mode: nil
> - * End:
> - */
> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
> new file mode 100644
> index 0000000..287c3fc
> --- /dev/null
> +++ b/xen/include/public/vm_event.h
> @@ -0,0 +1,197 @@
> +/******************************************************************************
> + * vm_event.h
> + *
> + * VM event common structures.
> + *
> + * Copyright (c) 2009 by Citrix Systems, Inc. (Patrick Colp)
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to
> + * deal in the Software without restriction, including without limitation the
> + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.
> + */
> +
> +#ifndef _XEN_PUBLIC_VM_EVENT_H
> +#define _XEN_PUBLIC_VM_EVENT_H
> +
> +#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
> +#error "vm event operations are intended for use only by Xen or node control tools"
> +#endif
> +
> +#include "xen.h"
> +#include "io/ring.h"
> +
> +#define MEM_EVENT_INTERFACE_VERSION 0x00000001
> +
> +/* Memory event flags */
> +#define VM_EVENT_FLAG_VCPU_PAUSED (1 << 0)
> +#define VM_EVENT_FLAG_DROP_PAGE (1 << 1)
> +#define VM_EVENT_FLAG_EVICT_FAIL (1 << 2)
> +#define VM_EVENT_FLAG_FOREIGN (1 << 3)
> +#define VM_EVENT_FLAG_DUMMY (1 << 4)
> +/*
> + * Emulate the fault-causing instruction (if set in the event response flags).
> + * This will allow the guest to continue execution without lifting the page
> + * access restrictions.
> + */
> +#define VM_EVENT_FLAG_EMULATE (1 << 5)
> +/*
> + * Same as VM_EVENT_FLAG_EMULATE, but with write operations or operations
> + * potentially having side effects (like memory mapped or port I/O) disabled.
> + */
> +#define VM_EVENT_FLAG_EMULATE_NOWRITE (1 << 6)
> +
> +/* Reasons for the vm event request */
> +/* Default case */
> +#define VM_EVENT_REASON_UNKNOWN 0
> +/* Memory access violation */
> +#define VM_EVENT_REASON_MEM_ACCESS_VIOLATION 1
> +/* Memory sharing event */
> +#define VM_EVENT_REASON_MEM_SHARING 2
> +/* Memory paging event */
> +#define VM_EVENT_REASON_MEM_PAGING 3
> +/* CR0 was updated */
> +#define VM_EVENT_REASON_CR0 4
> +/* CR3 was updated */
> +#define VM_EVENT_REASON_CR3 5
> +/* CR4 was updated */
> +#define VM_EVENT_REASON_CR4 6
> +/* Debug operation executed (int3) */
> +#define VM_EVENT_REASON_INT3 7
> +/* Single-step (MTF) */
> +#define VM_EVENT_REASON_SINGLESTEP 8
> +/* An MSR was updated. Does NOT honour HVMPME_onchangeonly */
> +#define VM_EVENT_REASON_MSR 9
> +
> +/* Using a custom struct (not hvm_hw_cpu) so as to not fill
> + * the vm_event ring buffer too quickly. */
> +struct vm_event_regs_x86 {
> + uint64_t rax;
> + uint64_t rcx;
> + uint64_t rdx;
> + uint64_t rbx;
> + uint64_t rsp;
> + uint64_t rbp;
> + uint64_t rsi;
> + uint64_t rdi;
> + uint64_t r8;
> + uint64_t r9;
> + uint64_t r10;
> + uint64_t r11;
> + uint64_t r12;
> + uint64_t r13;
> + uint64_t r14;
> + uint64_t r15;
> + uint64_t rflags;
> + uint64_t dr7;
> + uint64_t rip;
> + uint64_t cr0;
> + uint64_t cr2;
> + uint64_t cr3;
> + uint64_t cr4;
> + uint64_t sysenter_cs;
> + uint64_t sysenter_esp;
> + uint64_t sysenter_eip;
> + uint64_t msr_efer;
> + uint64_t msr_star;
> + uint64_t msr_lstar;
> + uint64_t fs_base;
> + uint64_t gs_base;
> + uint32_t cs_arbytes;
> + uint32_t _pad;
> +};
> +
> +struct vm_event_regs {
> + union {
> + struct vm_event_regs_x86 x86;
> + };
> +};
> +
> +struct vm_event_mem_access_data {
> + uint64_t gfn;
> + uint64_t offset;
> + uint64_t gla; /* if gla_valid */
> + uint16_t access_r:1;
> + uint16_t access_w:1;
> + uint16_t access_x:1;
> + uint16_t gla_valid:1;
> + uint16_t fault_with_gla:1;
> + uint16_t fault_in_gpt:1;
> + uint16_t available:10;
> +};
> +
> +struct vm_event_cr_data {
> + uint64_t new_value;
> + uint64_t old_value;
> +};
> +
> +struct vm_event_int3_data {
> + uint64_t gfn;
> + uint64_t gla;
> +};
> +
> +struct vm_event_singlestep_data {
> + uint64_t gfn;
> + uint64_t gla;
> +};
> +
> +struct vm_event_msr_data {
> + uint64_t msr;
> + uint64_t old_value;
> + uint64_t new_value;
> +};
> +
> +struct vm_event_paging_data {
> + uint64_t gfn;
> + uint32_t p2mt;
> +};
> +
> +struct vm_event_sharing_data {
> + uint64_t gfn;
> + uint32_t p2mt;
> +};
> +
> +typedef struct vm_event_st {
> + uint32_t flags;
> + uint32_t vcpu_id;
> + uint32_t reason;
> +
> + union {
> + struct vm_event_paging_data mem_paging_event;
> + struct vm_event_sharing_data mem_sharing_event;
> + struct vm_event_mem_access_data mem_access_event;
> + struct vm_event_cr_data cr_event;
> + struct vm_event_int3_data int3_event;
> + struct vm_event_singlestep_data singlestep_event;
> + struct vm_event_msr_data msr_event;
> + };
> +
> + struct vm_event_regs regs;
> +} vm_event_request_t, vm_event_response_t;
> +
> +DEFINE_RING_TYPES(vm_event, vm_event_request_t, vm_event_response_t);
> +
> +#endif
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/xen/mem_access.h b/xen/include/xen/mem_access.h
> index 6ceb2a4..1d01221 100644
> --- a/xen/include/xen/mem_access.h
> +++ b/xen/include/xen/mem_access.h
> @@ -29,7 +29,7 @@
>
> int mem_access_memop(unsigned long cmd,
> XEN_GUEST_HANDLE_PARAM(xen_mem_access_op_t) arg);
> -int mem_access_send_req(struct domain *d, mem_event_request_t *req);
> +int mem_access_send_req(struct domain *d, vm_event_request_t *req);
>
> /* Resumes the running of the VCPU, restarting the last instruction */
> void mem_access_resume(struct domain *d);
> @@ -44,7 +44,7 @@ int mem_access_memop(unsigned long cmd,
> }
>
> static inline
> -int mem_access_send_req(struct domain *d, mem_event_request_t *req)
> +int mem_access_send_req(struct domain *d, vm_event_request_t *req)
> {
> return -ENOSYS;
> }
> diff --git a/xen/include/xen/mem_event.h b/xen/include/xen/mem_event.h
> deleted file mode 100644
> index 4f3ad8e..0000000
> --- a/xen/include/xen/mem_event.h
> +++ /dev/null
> @@ -1,143 +0,0 @@
> -/******************************************************************************
> - * mem_event.h
> - *
> - * Common interface for memory event support.
> - *
> - * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp)
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> - */
> -
> -
> -#ifndef __MEM_EVENT_H__
> -#define __MEM_EVENT_H__
> -
> -#include <xen/sched.h>
> -
> -#ifdef HAS_MEM_ACCESS
> -
> -/* Clean up on domain destruction */
> -void mem_event_cleanup(struct domain *d);
> -
> -/* Returns whether a ring has been set up */
> -bool_t mem_event_check_ring(struct mem_event_domain *med);
> -
> -/* Returns 0 on success, -ENOSYS if there is no ring, -EBUSY if there is no
> - * available space and the caller is a foreign domain. If the guest itself
> - * is the caller, -EBUSY is avoided by sleeping on a wait queue to ensure
> - * that the ring does not lose future events.
> - *
> - * However, the allow_sleep flag can be set to false in cases in which it is ok
> - * to lose future events, and thus -EBUSY can be returned to guest vcpus
> - * (handle with care!).
> - *
> - * In general, you must follow a claim_slot() call with either put_request() or
> - * cancel_slot(), both of which are guaranteed to
> - * succeed.
> - */
> -int __mem_event_claim_slot(struct domain *d, struct mem_event_domain *med,
> - bool_t allow_sleep);
> -static inline int mem_event_claim_slot(struct domain *d,
> - struct mem_event_domain *med)
> -{
> - return __mem_event_claim_slot(d, med, 1);
> -}
> -
> -static inline int mem_event_claim_slot_nosleep(struct domain *d,
> - struct mem_event_domain *med)
> -{
> - return __mem_event_claim_slot(d, med, 0);
> -}
> -
> -void mem_event_cancel_slot(struct domain *d, struct mem_event_domain *med);
> -
> -void mem_event_put_request(struct domain *d, struct mem_event_domain *med,
> - mem_event_request_t *req);
> -
> -int mem_event_get_response(struct domain *d, struct mem_event_domain *med,
> - mem_event_response_t *rsp);
> -
> -int do_mem_event_op(int op, uint32_t domain, void *arg);
> -int mem_event_domctl(struct domain *d, xen_domctl_mem_event_op_t *mec,
> - XEN_GUEST_HANDLE_PARAM(void) u_domctl);
> -
> -void mem_event_vcpu_pause(struct vcpu *v);
> -void mem_event_vcpu_unpause(struct vcpu *v);
> -
> -#else
> -
> -static inline void mem_event_cleanup(struct domain *d) {}
> -
> -static inline bool_t mem_event_check_ring(struct mem_event_domain *med)
> -{
> - return 0;
> -}
> -
> -static inline int mem_event_claim_slot(struct domain *d,
> - struct mem_event_domain *med)
> -{
> - return -ENOSYS;
> -}
> -
> -static inline int mem_event_claim_slot_nosleep(struct domain *d,
> - struct mem_event_domain *med)
> -{
> - return -ENOSYS;
> -}
> -
> -static inline
> -void mem_event_cancel_slot(struct domain *d, struct mem_event_domain *med)
> -{}
> -
> -static inline
> -void mem_event_put_request(struct domain *d, struct mem_event_domain *med,
> - mem_event_request_t *req)
> -{}
> -
> -static inline
> -int mem_event_get_response(struct domain *d, struct mem_event_domain *med,
> - mem_event_response_t *rsp)
> -{
> - return -ENOSYS;
> -}
> -
> -static inline int do_mem_event_op(int op, uint32_t domain, void *arg)
> -{
> - return -ENOSYS;
> -}
> -
> -static inline
> -int mem_event_domctl(struct domain *d, xen_domctl_mem_event_op_t *mec,
> - XEN_GUEST_HANDLE_PARAM(void) u_domctl)
> -{
> - return -ENOSYS;
> -}
> -
> -static inline void mem_event_vcpu_pause(struct vcpu *v) {}
> -static inline void mem_event_vcpu_unpause(struct vcpu *v) {}
> -
> -#endif /* HAS_MEM_ACCESS */
> -
> -#endif /* __MEM_EVENT_H__ */
> -
> -
> -/*
> - * Local variables:
> - * mode: C
> - * c-file-style: "BSD"
> - * c-basic-offset: 4
> - * indent-tabs-mode: nil
> - * End:
> - */
> diff --git a/xen/include/xen/p2m-common.h b/xen/include/xen/p2m-common.h
> index 29f3628..5da8a2d 100644
> --- a/xen/include/xen/p2m-common.h
> +++ b/xen/include/xen/p2m-common.h
> @@ -1,12 +1,12 @@
> #ifndef _XEN_P2M_COMMON_H
> #define _XEN_P2M_COMMON_H
>
> -#include <public/mem_event.h>
> +#include <public/vm_event.h>
>
> /*
> * Additional access types, which are used to further restrict
> * the permissions given my the p2m_type_t memory type. Violations
> - * caused by p2m_access_t restrictions are sent to the mem_event
> + * caused by p2m_access_t restrictions are sent to the vm_event
> * interface.
> *
> * The access permissions are soft state: when any ambiguous change of page
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 2fc36ea..14fae4a 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -23,7 +23,7 @@
> #include <public/domctl.h>
> #include <public/sysctl.h>
> #include <public/vcpu.h>
> -#include <public/mem_event.h>
> +#include <public/vm_event.h>
> #include <public/event_channel.h>
>
> #ifdef CONFIG_COMPAT
> @@ -214,8 +214,8 @@ struct vcpu
> unsigned long pause_flags;
> atomic_t pause_count;
>
> - /* VCPU paused for mem_event replies. */
> - atomic_t mem_event_pause_count;
> + /* VCPU paused for vm_event replies. */
> + atomic_t vm_event_pause_count;
> /* VCPU paused by system controller. */
> int controller_pause_count;
>
> @@ -258,7 +258,7 @@ struct vcpu
> #define domain_is_locked(d) spin_is_locked(&(d)->domain_lock)
>
> /* Memory event */
> -struct mem_event_domain
> +struct vm_event_domain
> {
> /* ring lock */
> spinlock_t ring_lock;
> @@ -269,10 +269,10 @@ struct mem_event_domain
> void *ring_page;
> struct page_info *ring_pg_struct;
> /* front-end ring */
> - mem_event_front_ring_t front_ring;
> + vm_event_front_ring_t front_ring;
> /* event channel port (vcpu0 only) */
> int xen_port;
> - /* mem_event bit for vcpu->pause_flags */
> + /* vm_event bit for vcpu->pause_flags */
> int pause_flag;
> /* list of vcpus waiting for room in the ring */
> struct waitqueue_head wq;
> @@ -282,14 +282,14 @@ struct mem_event_domain
> unsigned int last_vcpu_wake_up;
> };
>
> -struct mem_event_per_domain
> +struct vm_event_per_domain
> {
> /* Memory sharing support */
> - struct mem_event_domain share;
> + struct vm_event_domain share;
> /* Memory paging support */
> - struct mem_event_domain paging;
> - /* VM event monitor support */
> - struct mem_event_domain monitor;
> + struct vm_event_domain paging;
> + /* Memory access support */
> + struct vm_event_domain monitor;
> };
>
> struct evtchn_port_ops;
> @@ -442,8 +442,8 @@ struct domain
> /* Non-migratable and non-restoreable? */
> bool_t disable_migrate;
>
> - /* Various mem_events */
> - struct mem_event_per_domain *mem_event;
> + /* Various vm_events */
> + struct vm_event_per_domain *vm_event;
>
> /*
> * Can be specified by the user. If that is not the case, it is
> diff --git a/xen/include/xen/vm_event.h b/xen/include/xen/vm_event.h
> new file mode 100644
> index 0000000..988ea42
> --- /dev/null
> +++ b/xen/include/xen/vm_event.h
> @@ -0,0 +1,143 @@
> +/******************************************************************************
> + * vm_event.h
> + *
> + * Common interface for memory event support.
> + *
> + * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp)
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> + */
> +
> +
> +#ifndef __VM_EVENT_H__
> +#define __VM_EVENT_H__
> +
> +#include <xen/sched.h>
> +
> +#ifdef HAS_MEM_ACCESS
> +
> +/* Clean up on domain destruction */
> +void vm_event_cleanup(struct domain *d);
> +
> +/* Returns whether a ring has been set up */
> +bool_t vm_event_check_ring(struct vm_event_domain *med);
> +
> +/* Returns 0 on success, -ENOSYS if there is no ring, -EBUSY if there is no
> + * available space and the caller is a foreign domain. If the guest itself
> + * is the caller, -EBUSY is avoided by sleeping on a wait queue to ensure
> + * that the ring does not lose future events.
> + *
> + * However, the allow_sleep flag can be set to false in cases in which it is ok
> + * to lose future events, and thus -EBUSY can be returned to guest vcpus
> + * (handle with care!).
> + *
> + * In general, you must follow a claim_slot() call with either put_request() or
> + * cancel_slot(), both of which are guaranteed to
> + * succeed.
> + */
> +int __vm_event_claim_slot(struct domain *d, struct vm_event_domain *med,
> + bool_t allow_sleep);
> +static inline int vm_event_claim_slot(struct domain *d,
> + struct vm_event_domain *med)
> +{
> + return __vm_event_claim_slot(d, med, 1);
> +}
> +
> +static inline int vm_event_claim_slot_nosleep(struct domain *d,
> + struct vm_event_domain *med)
> +{
> + return __vm_event_claim_slot(d, med, 0);
> +}
> +
> +void vm_event_cancel_slot(struct domain *d, struct vm_event_domain *med);
> +
> +void vm_event_put_request(struct domain *d, struct vm_event_domain *med,
> + vm_event_request_t *req);
> +
> +int vm_event_get_response(struct domain *d, struct vm_event_domain *med,
> + vm_event_response_t *rsp);
> +
> +int do_vm_event_op(int op, uint32_t domain, void *arg);
> +int vm_event_domctl(struct domain *d, xen_domctl_vm_event_op_t *mec,
> + XEN_GUEST_HANDLE_PARAM(void) u_domctl);
> +
> +void vm_event_vcpu_pause(struct vcpu *v);
> +void vm_event_vcpu_unpause(struct vcpu *v);
> +
> +#else
> +
> +static inline void vm_event_cleanup(struct domain *d) {}
> +
> +static inline bool_t vm_event_check_ring(struct vm_event_domain *med)
> +{
> + return 0;
> +}
> +
> +static inline int vm_event_claim_slot(struct domain *d,
> + struct vm_event_domain *med)
> +{
> + return -ENOSYS;
> +}
> +
> +static inline int vm_event_claim_slot_nosleep(struct domain *d,
> + struct vm_event_domain *med)
> +{
> + return -ENOSYS;
> +}
> +
> +static inline
> +void vm_event_cancel_slot(struct domain *d, struct vm_event_domain *med)
> +{}
> +
> +static inline
> +void vm_event_put_request(struct domain *d, struct vm_event_domain *med,
> + vm_event_request_t *req)
> +{}
> +
> +static inline
> +int vm_event_get_response(struct domain *d, struct vm_event_domain *med,
> + vm_event_response_t *rsp)
> +{
> + return -ENOSYS;
> +}
> +
> +static inline int do_vm_event_op(int op, uint32_t domain, void *arg)
> +{
> + return -ENOSYS;
> +}
> +
> +static inline
> +int vm_event_domctl(struct domain *d, xen_domctl_vm_event_op_t *mec,
> + XEN_GUEST_HANDLE_PARAM(void) u_domctl)
> +{
> + return -ENOSYS;
> +}
> +
> +static inline void vm_event_vcpu_pause(struct vcpu *v) {}
> +static inline void vm_event_vcpu_unpause(struct vcpu *v) {}
> +
> +#endif /* HAS_MEM_ACCESS */
> +
> +#endif /* __VM_EVENT_H__ */
> +
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
> index f20e89c..4227093 100644
> --- a/xen/include/xsm/dummy.h
> +++ b/xen/include/xsm/dummy.h
> @@ -514,13 +514,13 @@ static XSM_INLINE int xsm_hvm_param_nested(XSM_DEFAULT_ARG struct domain *d)
> }
>
> #ifdef HAS_MEM_ACCESS
> -static XSM_INLINE int xsm_mem_event_control(XSM_DEFAULT_ARG struct domain *d, int mode, int op)
> +static XSM_INLINE int xsm_vm_event_control(XSM_DEFAULT_ARG struct domain *d, int mode, int op)
> {
> XSM_ASSERT_ACTION(XSM_PRIV);
> return xsm_default_action(action, current->domain, d);
> }
>
> -static XSM_INLINE int xsm_mem_event_op(XSM_DEFAULT_ARG struct domain *d, int op)
> +static XSM_INLINE int xsm_vm_event_op(XSM_DEFAULT_ARG struct domain *d, int op)
> {
> XSM_ASSERT_ACTION(XSM_DM_PRIV);
> return xsm_default_action(action, current->domain, d);
> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
> index 4ce089f..cff9d35 100644
> --- a/xen/include/xsm/xsm.h
> +++ b/xen/include/xsm/xsm.h
> @@ -142,8 +142,8 @@ struct xsm_operations {
> int (*get_vnumainfo) (struct domain *d);
>
> #ifdef HAS_MEM_ACCESS
> - int (*mem_event_control) (struct domain *d, int mode, int op);
> - int (*mem_event_op) (struct domain *d, int op);
> + int (*vm_event_control) (struct domain *d, int mode, int op);
> + int (*vm_event_op) (struct domain *d, int op);
> #endif
>
> #ifdef CONFIG_X86
> @@ -544,14 +544,14 @@ static inline int xsm_get_vnumainfo (xsm_default_t def, struct domain *d)
> }
>
> #ifdef HAS_MEM_ACCESS
> -static inline int xsm_mem_event_control (xsm_default_t def, struct domain *d, int mode, int op)
> +static inline int xsm_vm_event_control (xsm_default_t def, struct domain *d, int mode, int op)
> {
> - return xsm_ops->mem_event_control(d, mode, op);
> + return xsm_ops->vm_event_control(d, mode, op);
> }
>
> -static inline int xsm_mem_event_op (xsm_default_t def, struct domain *d, int op)
> +static inline int xsm_vm_event_op (xsm_default_t def, struct domain *d, int op)
> {
> - return xsm_ops->mem_event_op(d, op);
> + return xsm_ops->vm_event_op(d, op);
> }
> #endif
>
> diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
> index 8eb3050..25fca68 100644
> --- a/xen/xsm/dummy.c
> +++ b/xen/xsm/dummy.c
> @@ -119,8 +119,8 @@ void xsm_fixup_ops (struct xsm_operations *ops)
> set_to_dummy_if_null(ops, map_gmfn_foreign);
>
> #ifdef HAS_MEM_ACCESS
> - set_to_dummy_if_null(ops, mem_event_control);
> - set_to_dummy_if_null(ops, mem_event_op);
> + set_to_dummy_if_null(ops, vm_event_control);
> + set_to_dummy_if_null(ops, vm_event_op);
> #endif
>
> #ifdef CONFIG_X86
> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> index d48463f..c419543 100644
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -578,7 +578,7 @@ static int flask_domctl(struct domain *d, int cmd)
> case XEN_DOMCTL_memory_mapping:
> case XEN_DOMCTL_set_target:
> #ifdef HAS_MEM_ACCESS
> - case XEN_DOMCTL_mem_event_op:
> + case XEN_DOMCTL_vm_event_op:
> #endif
> #ifdef CONFIG_X86
> /* These have individual XSM hooks (arch/x86/domctl.c) */
> @@ -689,7 +689,7 @@ static int flask_domctl(struct domain *d, int cmd)
> return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__TRIGGER);
>
> case XEN_DOMCTL_set_access_required:
> - return current_has_perm(d, SECCLASS_HVM, HVM__MEM_EVENT);
> + return current_has_perm(d, SECCLASS_HVM, HVM__VM_EVENT);
>
> case XEN_DOMCTL_debug_op:
> case XEN_DOMCTL_gdbsx_guestmemio:
> @@ -1203,14 +1203,14 @@ static int flask_deassign_device(struct domain *d, uint32_t machine_bdf)
> #endif /* HAS_PASSTHROUGH && HAS_PCI */
>
> #ifdef HAS_MEM_ACCESS
> -static int flask_mem_event_control(struct domain *d, int mode, int op)
> +static int flask_vm_event_control(struct domain *d, int mode, int op)
> {
> - return current_has_perm(d, SECCLASS_HVM, HVM__MEM_EVENT);
> + return current_has_perm(d, SECCLASS_HVM, HVM__VM_EVENT);
> }
>
> -static int flask_mem_event_op(struct domain *d, int op)
> +static int flask_vm_event_op(struct domain *d, int op)
> {
> - return current_has_perm(d, SECCLASS_HVM, HVM__MEM_EVENT);
> + return current_has_perm(d, SECCLASS_HVM, HVM__VM_EVENT);
> }
> #endif /* HAS_MEM_ACCESS */
>
> @@ -1597,8 +1597,8 @@ static struct xsm_operations flask_ops = {
> #endif
>
> #ifdef HAS_MEM_ACCESS
> - .mem_event_control = flask_mem_event_control,
> - .mem_event_op = flask_mem_event_op,
> + .vm_event_control = flask_vm_event_control,
> + .vm_event_op = flask_vm_event_op,
> #endif
>
> #ifdef CONFIG_X86
> diff --git a/xen/xsm/flask/policy/access_vectors b/xen/xsm/flask/policy/access_vectors
> index 1da9f63..9da3275 100644
> --- a/xen/xsm/flask/policy/access_vectors
> +++ b/xen/xsm/flask/policy/access_vectors
> @@ -249,7 +249,7 @@ class hvm
> # HVMOP_inject_trap
> hvmctl
> # XEN_DOMCTL_set_access_required
> - mem_event
> + vm_event
> # XEN_DOMCTL_mem_sharing_op and XENMEM_sharing_op_{share,add_physmap} with:
> # source = the domain making the hypercall
> # target = domain whose memory is being shared
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 6/8] xen/vm_event: Decouple vm_event and mem_access.
2015-01-18 15:17 ` [RFC PATCH V2 6/8] xen/vm_event: Decouple vm_event and mem_access Tamas K Lengyel
@ 2015-01-22 14:56 ` Tim Deegan
2015-01-22 15:35 ` Tamas K Lengyel
0 siblings, 1 reply; 53+ messages in thread
From: Tim Deegan @ 2015-01-22 14:56 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, eddie.dong, ian.jackson, xen-devel, andres,
jbeulich, rshriram, keir, dgdegra, yanghy
At 16:17 +0100 on 18 Jan (1421594279), Tamas K Lengyel wrote:
> The vm_event subsystem has been artifically tied to the presence of mem_access.
> While mem_access does depend on vm_event, vm_event is an entirely independent
> subsystem that can be used for arbitrary function-offloading to helper apps in
> domains. This patch removes the dependency that mem_access needs to be supported
> in order to enable vm_event.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
For the x86/mem-event stuff,
Acked-by: Tim Deegan <tim@xen.org>
though you might want to check that it DTRT in an Arm build.
Cheers,
Tim.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file
2015-01-18 15:18 ` [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file Tamas K Lengyel
@ 2015-01-22 15:00 ` Tim Deegan
2015-01-22 15:36 ` Tamas K Lengyel
2015-01-22 16:25 ` Jan Beulich
2015-01-22 16:32 ` Andrew Cooper
2 siblings, 1 reply; 53+ messages in thread
From: Tim Deegan @ 2015-01-22 15:00 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
jun.nakajima, eddie.dong, ian.jackson, xen-devel, andres,
jbeulich, rshriram, keir, dgdegra, yanghy
At 16:18 +0100 on 18 Jan (1421594281), Tamas K Lengyel wrote:
> To avoid growing hvm.c these functions can be stored
> separately.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
Assuming this is just code motion, it seems like a good idea to me,
with one nit:
> --- a/xen/arch/x86/hvm/Makefile
> +++ b/xen/arch/x86/hvm/Makefile
> @@ -22,4 +22,5 @@ obj-y += vlapic.o
> obj-y += vmsi.o
> obj-y += vpic.o
> obj-y += vpt.o
> -obj-y += vpmu.o
> \ No newline at end of file
> +obj-y += vpmu.o
> +obj-y += event.o
This list is in alphabetical order; please keep it that way.
With that fixed,
Acked-by: Tim Deegan <tim@xen.org>
Cheers,
Tim.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-18 15:17 ` [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures Tamas K Lengyel
2015-01-22 12:43 ` Tim Deegan
@ 2015-01-22 15:00 ` Jan Beulich
2015-01-22 15:34 ` Tamas K Lengyel
1 sibling, 1 reply; 53+ messages in thread
From: Jan Beulich @ 2015-01-22 15:00 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: tim, kevin.tian, wei.liu2, ian.campbell, Razvan Cojocaru,
stefano.stabellini, eddie.dong, ian.jackson, xen-devel, andres,
jun.nakajima, rshriram, keir, dgdegra, yanghy
>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
> --- a/xen/include/Makefile
> +++ b/xen/include/Makefile
> @@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>
> all: headers.chk
>
> -headers.chk: $(filter-out public/arch-% public/%ctl.h public/xsm/%
> public/%hvm/save.h, $(wildcard public/*.h public/*/*.h) $(public-y)) Makefile
> +headers.chk: $(filter-out public/arch-% public/%ctl.h public/mem_event.h
> public/xsm/% public/%hvm/save.h, $(wildcard public/*.h public/*/*.h)
> $(public-y)) Makefile
I think you should finally break this already too long line. But of course
first of all you'll want to explain why the addition is necessary/correct.
The mere fact that this now becomes a tools-only interface isn't
enough imo - some of the other headers excluded here would better
undergo the checking too, just that first they would need cleaning up.
> --- a/xen/include/public/mem_event.h
> +++ b/xen/include/public/mem_event.h
> @@ -27,9 +27,15 @@
> #ifndef _XEN_PUBLIC_MEM_EVENT_H
> #define _XEN_PUBLIC_MEM_EVENT_H
>
> +#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
> +#error "vm event operations are intended for use only by Xen or node
> control tools"
> +#endif
> +
> #include "xen.h"
> #include "io/ring.h"
>
> +#define MEM_EVENT_INTERFACE_VERSION 0x00000001
This doesn't appear to be used anywhere, and hence isn't useful to
add here.
> @@ -48,16 +54,27 @@
> */
> #define MEM_EVENT_FLAG_EMULATE_NOWRITE (1 << 6)
>
> -/* Reasons for the memory event request */
> -#define MEM_EVENT_REASON_UNKNOWN 0 /* typical reason */
> -#define MEM_EVENT_REASON_VIOLATION 1 /* access violation, GFN is
> address */
> -#define MEM_EVENT_REASON_CR0 2 /* CR0 was hit: gfn is new CR0
> value, gla is previous */
> -#define MEM_EVENT_REASON_CR3 3 /* CR3 was hit: gfn is new CR3
> value, gla is previous */
> -#define MEM_EVENT_REASON_CR4 4 /* CR4 was hit: gfn is new CR4
> value, gla is previous */
> -#define MEM_EVENT_REASON_INT3 5 /* int3 was hit: gla/gfn are RIP
> */
> -#define MEM_EVENT_REASON_SINGLESTEP 6 /* single step was invoked:
> gla/gfn are RIP */
> -#define MEM_EVENT_REASON_MSR 7 /* MSR was hit: gfn is MSR value,
> gla is MSR address;
> - does NOT honour HVMPME_onchangeonly */
> +/* Reasons for the vm event request */
> +/* Default case */
> +#define MEM_EVENT_REASON_UNKNOWN 0
> +/* Memory access violation */
> +#define MEM_EVENT_REASON_MEM_ACCESS_VIOLATION 1
> +/* Memory sharing event */
> +#define MEM_EVENT_REASON_MEM_SHARING 2
> +/* Memory paging event */
> +#define MEM_EVENT_REASON_MEM_PAGING 3
> +/* CR0 was updated */
> +#define MEM_EVENT_REASON_CR0 4
> +/* CR3 was updated */
> +#define MEM_EVENT_REASON_CR3 5
> +/* CR4 was updated */
> +#define MEM_EVENT_REASON_CR4 6
> +/* Debug operation executed (int3) */
> +#define MEM_EVENT_REASON_INT3 7
> +/* Single-step (MTF) */
> +#define MEM_EVENT_REASON_SINGLESTEP 8
> +/* An MSR was updated. Does NOT honour HVMPME_onchangeonly */
> +#define MEM_EVENT_REASON_MSR 9
I see you rename these a second time in patch 5 - can't this renaming
be reduced to just one?
> @@ -97,16 +114,16 @@ struct mem_event_regs_x86 {
> uint32_t _pad;
> };
>
> -typedef struct mem_event_st {
> - uint32_t flags;
> - uint32_t vcpu_id;
> +struct mem_event_regs {
> + union {
> + struct mem_event_regs_x86 x86;
> + };
> +};
No non-standard (C89) features in public headers please.
> +struct mem_event_mem_access_data {
> uint64_t gfn;
> uint64_t offset;
> uint64_t gla; /* if gla_valid */
> -
> - uint32_t p2mt;
> -
> uint16_t access_r:1;
> uint16_t access_w:1;
> uint16_t access_x:1;
I also wonder how well thought through the use of bit fields here is.
> +struct mem_event_int3_data {
> + uint64_t gfn;
> + uint64_t gla;
> +};
> +
> +struct mem_event_singlestep_data {
> + uint64_t gfn;
> + uint64_t gla;
> +};
I may lack some understanding of the interfaces here, but what do
gfn and gla have to do with int3 and single-step events? Also, how
architecture-neutral is int3 really?!
> +struct mem_event_msr_data {
> + uint64_t msr;
Maybe better uint32_t with another such typed padding slot following?
> +typedef struct mem_event_st {
> + uint32_t flags;
> + uint32_t vcpu_id;
> + uint32_t reason;
> +
> + union {
> + struct mem_event_paging_data mem_paging_event;
> + struct mem_event_sharing_data mem_sharing_event;
> + struct mem_event_mem_access_data mem_access_event;
> + struct mem_event_cr_data cr_event;
> + struct mem_event_int3_data int3_event;
> + struct mem_event_singlestep_data singlestep_event;
> + struct mem_event_msr_data msr_event;
> + };
>
> - uint16_t reason;
> - struct mem_event_regs_x86 x86_regs;
> + struct mem_event_regs regs;
> } mem_event_request_t, mem_event_response_t;
This structure's layout now differs between 32- and 64-bit, which I'm
sure you want to avoid.
Jan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 5/8] xen/mem_event: Rename mem_event to vm_event
2015-01-22 14:52 ` Tim Deegan
@ 2015-01-22 15:02 ` Tamas K Lengyel
0 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-22 15:02 UTC (permalink / raw)
To: Tim Deegan
Cc: Tian, Kevin, wei.liu2, Ian Campbell, Stefano Stabellini,
Jun Nakajima, Dong, Eddie, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jan Beulich, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 3:52 PM, Tim Deegan <tim@xen.org> wrote:
> At 16:17 +0100 on 18 Jan (1421594278), Tamas K Lengyel wrote:
>> The mem_event system has originally been used to deliver memory event
>> related information to helper programs located in a domain. However,
>> the usage of this sub-system have since been expanded to include non-memory
>> related events as well, such as register changes, debugging and singlestepping.
>> Therefore, renaming the system "vm_event" more accurately describes the actual
>> usage of the subsystem.
>>
>> In this patch I also clear up the ambiguities that resulted from the interchanged
>> mem_event and mem_access terminology.
>>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
>
> This patch is pretty much unreviewable in that it is both renames and
> edits files, but I'm OK with the general intent. I see Andrew's
> already suggested some git runes to handle the rename better.
Ack, I'll go with Andrew's route: first introducing the vm_event
system in one patch; second moving everything over to the new naming;
third removing the old mem_event files. This will go somewhat against
the Xen convention of introducing code only when it is immediately
used, but for reviewing purposes IMHO it would be cleaner (or just
merge step and 1&2 into one patch?).
Thanks,
Tamas
>
> Cheers,
>
> Tim.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'
2015-01-18 15:17 ` [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor' Tamas K Lengyel
2015-01-22 12:53 ` Tim Deegan
@ 2015-01-22 15:02 ` Jan Beulich
2015-01-22 15:42 ` Tamas K Lengyel
1 sibling, 1 reply; 53+ messages in thread
From: Jan Beulich @ 2015-01-22 15:02 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: tim, kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
eddie.dong, ian.jackson, xen-devel, andres, jun.nakajima,
rshriram, keir, dgdegra, yanghy
>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -775,7 +775,7 @@ struct xen_domctl_gdbsx_domstatus {
> #define XEN_DOMCTL_MEM_EVENT_OP_PAGING_DISABLE 1
>
> /*
> - * Access permissions.
> + * Monitor permissions.
"permissions"?
Jan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 3/8] xen/mem_paging: Convert mem_event_op to mem_paging_op
2015-01-18 15:17 ` [RFC PATCH V2 3/8] xen/mem_paging: Convert mem_event_op to mem_paging_op Tamas K Lengyel
2015-01-22 13:03 ` Tim Deegan
@ 2015-01-22 15:09 ` Jan Beulich
2015-01-22 15:41 ` Tamas K Lengyel
1 sibling, 1 reply; 53+ messages in thread
From: Jan Beulich @ 2015-01-22 15:09 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: tim, kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
eddie.dong, ian.jackson, xen-devel, andres, jun.nakajima,
rshriram, keir, dgdegra, yanghy
>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
> --- a/xen/arch/x86/mm/mem_paging.c
> +++ b/xen/arch/x86/mm/mem_paging.c
> @@ -25,31 +25,31 @@
> #include <xen/mem_event.h>
>
>
> -int mem_paging_memop(struct domain *d, xen_mem_event_op_t *mec)
> +int mem_paging_memop(struct domain *d, xen_mem_paging_op_t *mpc)
> {
> if ( unlikely(!d->mem_event->paging.ring_page) )
> return -ENODEV;
>
> - switch( mec->op )
> + switch( mpc->op )
> {
> case XENMEM_paging_op_nominate:
> {
> - unsigned long gfn = mec->gfn;
> + unsigned long gfn = mpc->gfn;
> return p2m_mem_paging_nominate(d, gfn);
If you fiddle with this, please fix obvious style issues - here, blank
line after declaration(s). Albeit in the particular cases here I wonder
whether the local variable is really helpful.
> --- a/xen/common/mem_event.c
> +++ b/xen/common/mem_event.c
> @@ -474,7 +474,7 @@ int do_mem_event_op(int op, uint32_t domain, void *arg)
> {
> #ifdef HAS_MEM_PAGING
> case XENMEM_paging_op:
> - ret = mem_paging_memop(d, (xen_mem_event_op_t *) arg);
> + ret = mem_paging_memop(d, (xen_mem_paging_op_t *) arg);
Afaict the cast is useless and should be dropped rather than replaced.
> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -372,7 +372,7 @@ typedef struct xen_pod_target xen_pod_target_t;
> #define XENMEM_paging_op_evict 1
> #define XENMEM_paging_op_prep 2
>
> -struct xen_mem_event_op {
> +struct xen_mem_paging_op {
> uint8_t op; /* XENMEM_*_op_* */
Especially this comment makes me think this was originally intended
for more than just paging. Are we really determined for this to no
longer be the case? If so, the comment should be updated too.
Jan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-22 15:00 ` Jan Beulich
@ 2015-01-22 15:34 ` Tamas K Lengyel
2015-01-22 16:00 ` Jan Beulich
2015-01-29 11:54 ` Tamas K Lengyel
0 siblings, 2 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-22 15:34 UTC (permalink / raw)
To: Jan Beulich
Cc: Tim Deegan, Tian, Kevin, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Dong, Eddie, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
>> --- a/xen/include/Makefile
>> +++ b/xen/include/Makefile
>> @@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>>
>> all: headers.chk
>>
>> -headers.chk: $(filter-out public/arch-% public/%ctl.h public/xsm/%
>> public/%hvm/save.h, $(wildcard public/*.h public/*/*.h) $(public-y)) Makefile
>> +headers.chk: $(filter-out public/arch-% public/%ctl.h public/mem_event.h
>> public/xsm/% public/%hvm/save.h, $(wildcard public/*.h public/*/*.h)
>> $(public-y)) Makefile
>
> I think you should finally break this already too long line. But of course
> first of all you'll want to explain why the addition is necessary/correct.
> The mere fact that this now becomes a tools-only interface isn't
> enough imo - some of the other headers excluded here would better
> undergo the checking too, just that first they would need cleaning up.
I have to revisit what is actually going on here, I believe I had to
add this to get Xen to build. On a second look not sure why that was.
>
>> --- a/xen/include/public/mem_event.h
>> +++ b/xen/include/public/mem_event.h
>> @@ -27,9 +27,15 @@
>> #ifndef _XEN_PUBLIC_MEM_EVENT_H
>> #define _XEN_PUBLIC_MEM_EVENT_H
>>
>> +#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
>> +#error "vm event operations are intended for use only by Xen or node
>> control tools"
>> +#endif
>> +
>> #include "xen.h"
>> #include "io/ring.h"
>>
>> +#define MEM_EVENT_INTERFACE_VERSION 0x00000001
>
> This doesn't appear to be used anywhere, and hence isn't useful to
> add here.
It is intended to be used to establish an API version for backwards
compatibility. We don't have any backwards compatibility checks at
this point, but this will change as soon as we extend this interface
as things go forward in the future.
>
>> @@ -48,16 +54,27 @@
>> */
>> #define MEM_EVENT_FLAG_EMULATE_NOWRITE (1 << 6)
>>
>> -/* Reasons for the memory event request */
>> -#define MEM_EVENT_REASON_UNKNOWN 0 /* typical reason */
>> -#define MEM_EVENT_REASON_VIOLATION 1 /* access violation, GFN is
>> address */
>> -#define MEM_EVENT_REASON_CR0 2 /* CR0 was hit: gfn is new CR0
>> value, gla is previous */
>> -#define MEM_EVENT_REASON_CR3 3 /* CR3 was hit: gfn is new CR3
>> value, gla is previous */
>> -#define MEM_EVENT_REASON_CR4 4 /* CR4 was hit: gfn is new CR4
>> value, gla is previous */
>> -#define MEM_EVENT_REASON_INT3 5 /* int3 was hit: gla/gfn are RIP
>> */
>> -#define MEM_EVENT_REASON_SINGLESTEP 6 /* single step was invoked:
>> gla/gfn are RIP */
>> -#define MEM_EVENT_REASON_MSR 7 /* MSR was hit: gfn is MSR value,
>> gla is MSR address;
>> - does NOT honour HVMPME_onchangeonly */
>> +/* Reasons for the vm event request */
>> +/* Default case */
>> +#define MEM_EVENT_REASON_UNKNOWN 0
>> +/* Memory access violation */
>> +#define MEM_EVENT_REASON_MEM_ACCESS_VIOLATION 1
>> +/* Memory sharing event */
>> +#define MEM_EVENT_REASON_MEM_SHARING 2
>> +/* Memory paging event */
>> +#define MEM_EVENT_REASON_MEM_PAGING 3
>> +/* CR0 was updated */
>> +#define MEM_EVENT_REASON_CR0 4
>> +/* CR3 was updated */
>> +#define MEM_EVENT_REASON_CR3 5
>> +/* CR4 was updated */
>> +#define MEM_EVENT_REASON_CR4 6
>> +/* Debug operation executed (int3) */
>> +#define MEM_EVENT_REASON_INT3 7
>> +/* Single-step (MTF) */
>> +#define MEM_EVENT_REASON_SINGLESTEP 8
>> +/* An MSR was updated. Does NOT honour HVMPME_onchangeonly */
>> +#define MEM_EVENT_REASON_MSR 9
>
> I see you rename these a second time in patch 5 - can't this renaming
> be reduced to just one?
I didn't rename anything here, just updated the comments.
>
>> @@ -97,16 +114,16 @@ struct mem_event_regs_x86 {
>> uint32_t _pad;
>> };
>>
>> -typedef struct mem_event_st {
>> - uint32_t flags;
>> - uint32_t vcpu_id;
>> +struct mem_event_regs {
>> + union {
>> + struct mem_event_regs_x86 x86;
>> + };
>> +};
>
> No non-standard (C89) features in public headers please.
Elaborate please? I have this union as we will likely have ARM
registers as well soon. I guess it can wait and be introduced when the
ARM side catches up.
>
>> +struct mem_event_mem_access_data {
>> uint64_t gfn;
>> uint64_t offset;
>> uint64_t gla; /* if gla_valid */
>> -
>> - uint32_t p2mt;
>> -
>> uint16_t access_r:1;
>> uint16_t access_w:1;
>> uint16_t access_x:1;
>
> I also wonder how well thought through the use of bit fields here is.
It saves some space on the ring. Maybe a uint8_t is enough.
>
>> +struct mem_event_int3_data {
>> + uint64_t gfn;
>> + uint64_t gla;
>> +};
>> +
>> +struct mem_event_singlestep_data {
>> + uint64_t gfn;
>> + uint64_t gla;
>> +};
>
> I may lack some understanding of the interfaces here, but what do
> gfn and gla have to do with int3 and single-step events?
These contained auxiliary info about the instruction triggering the
event. It is somewhat superseded at this point by the automatic
filling of the x86 registers struct, however, the gfn is not included
in that struct so it can still be useful.
Also, how
> architecture-neutral is int3 really?!
These aren't architecture neutral by any means. However, we likely are
going to have SMC events on the ARM as well, which won't be
architecture neutral either. I don't see a way around it. But why
would this interface have to be architecture neutral? IMHO a comment
saying these are features only for Intel/AMD/ARM would be sufficient.
We already do checks for the architecture when the user attempts to
enable these features to see if it actually supported on the hardware
or not.
>
>> +struct mem_event_msr_data {
>> + uint64_t msr;
>
> Maybe better uint32_t with another such typed padding slot following?
Not sure I follow. Could you elaborate what the issue is?
>
>> +typedef struct mem_event_st {
>> + uint32_t flags;
>> + uint32_t vcpu_id;
>> + uint32_t reason;
>> +
>> + union {
>> + struct mem_event_paging_data mem_paging_event;
>> + struct mem_event_sharing_data mem_sharing_event;
>> + struct mem_event_mem_access_data mem_access_event;
>> + struct mem_event_cr_data cr_event;
>> + struct mem_event_int3_data int3_event;
>> + struct mem_event_singlestep_data singlestep_event;
>> + struct mem_event_msr_data msr_event;
>> + };
>>
>> - uint16_t reason;
>> - struct mem_event_regs_x86 x86_regs;
>> + struct mem_event_regs regs;
>> } mem_event_request_t, mem_event_response_t;
>
> This structure's layout now differs between 32- and 64-bit, which I'm
> sure you want to avoid.
Any suggestions? Make the struct(s) packed?
>
> Jan
Thanks,
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 6/8] xen/vm_event: Decouple vm_event and mem_access.
2015-01-22 14:56 ` Tim Deegan
@ 2015-01-22 15:35 ` Tamas K Lengyel
0 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-22 15:35 UTC (permalink / raw)
To: Tim Deegan
Cc: Tian, Kevin, wei.liu2, Ian Campbell, Stefano Stabellini,
Jun Nakajima, Dong, Eddie, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jan Beulich, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 3:56 PM, Tim Deegan <tim@xen.org> wrote:
> At 16:17 +0100 on 18 Jan (1421594279), Tamas K Lengyel wrote:
>> The vm_event subsystem has been artifically tied to the presence of mem_access.
>> While mem_access does depend on vm_event, vm_event is an entirely independent
>> subsystem that can be used for arbitrary function-offloading to helper apps in
>> domains. This patch removes the dependency that mem_access needs to be supported
>> in order to enable vm_event.
>>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
>
> For the x86/mem-event stuff,
>
> Acked-by: Tim Deegan <tim@xen.org>
>
> though you might want to check that it DTRT in an Arm build.
Thanks, good point, will do!
Tamas
>
> Cheers,
>
> Tim.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file
2015-01-22 15:00 ` Tim Deegan
@ 2015-01-22 15:36 ` Tamas K Lengyel
0 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-22 15:36 UTC (permalink / raw)
To: Tim Deegan
Cc: Tian, Kevin, wei.liu2, Ian Campbell, Stefano Stabellini,
Jun Nakajima, Dong, Eddie, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jan Beulich, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 4:00 PM, Tim Deegan <tim@xen.org> wrote:
> At 16:18 +0100 on 18 Jan (1421594281), Tamas K Lengyel wrote:
>> To avoid growing hvm.c these functions can be stored
>> separately.
>>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
>
> Assuming this is just code motion, it seems like a good idea to me,
> with one nit:
>
>> --- a/xen/arch/x86/hvm/Makefile
>> +++ b/xen/arch/x86/hvm/Makefile
>> @@ -22,4 +22,5 @@ obj-y += vlapic.o
>> obj-y += vmsi.o
>> obj-y += vpic.o
>> obj-y += vpt.o
>> -obj-y += vpmu.o
>> \ No newline at end of file
>> +obj-y += vpmu.o
>> +obj-y += event.o
>
> This list is in alphabetical order; please keep it that way.
Noted!
Thanks,
Tamas
> With that fixed,
>
> Acked-by: Tim Deegan <tim@xen.org>
>
> Cheers,
>
> Tim.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 3/8] xen/mem_paging: Convert mem_event_op to mem_paging_op
2015-01-22 15:09 ` Jan Beulich
@ 2015-01-22 15:41 ` Tamas K Lengyel
0 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-22 15:41 UTC (permalink / raw)
To: Jan Beulich
Cc: Tim Deegan, Tian, Kevin, wei.liu2, Ian Campbell,
Stefano Stabellini, Dong, Eddie, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 4:09 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
>> --- a/xen/arch/x86/mm/mem_paging.c
>> +++ b/xen/arch/x86/mm/mem_paging.c
>> @@ -25,31 +25,31 @@
>> #include <xen/mem_event.h>
>>
>>
>> -int mem_paging_memop(struct domain *d, xen_mem_event_op_t *mec)
>> +int mem_paging_memop(struct domain *d, xen_mem_paging_op_t *mpc)
>> {
>> if ( unlikely(!d->mem_event->paging.ring_page) )
>> return -ENODEV;
>>
>> - switch( mec->op )
>> + switch( mpc->op )
>> {
>> case XENMEM_paging_op_nominate:
>> {
>> - unsigned long gfn = mec->gfn;
>> + unsigned long gfn = mpc->gfn;
>> return p2m_mem_paging_nominate(d, gfn);
>
> If you fiddle with this, please fix obvious style issues - here, blank
> line after declaration(s). Albeit in the particular cases here I wonder
> whether the local variable is really helpful.
Ack.
>
>> --- a/xen/common/mem_event.c
>> +++ b/xen/common/mem_event.c
>> @@ -474,7 +474,7 @@ int do_mem_event_op(int op, uint32_t domain, void *arg)
>> {
>> #ifdef HAS_MEM_PAGING
>> case XENMEM_paging_op:
>> - ret = mem_paging_memop(d, (xen_mem_event_op_t *) arg);
>> + ret = mem_paging_memop(d, (xen_mem_paging_op_t *) arg);
>
> Afaict the cast is useless and should be dropped rather than replaced.
Ack.
>
>> --- a/xen/include/public/memory.h
>> +++ b/xen/include/public/memory.h
>> @@ -372,7 +372,7 @@ typedef struct xen_pod_target xen_pod_target_t;
>> #define XENMEM_paging_op_evict 1
>> #define XENMEM_paging_op_prep 2
>>
>> -struct xen_mem_event_op {
>> +struct xen_mem_paging_op {
>> uint8_t op; /* XENMEM_*_op_* */
>
> Especially this comment makes me think this was originally intended
> for more than just paging. Are we really determined for this to no
> longer be the case? If so, the comment should be updated too.
Ack. The only thing I could imagine is that sharing was intended to be
moved over to use this, but that never happened.
Tamas
>
> Jan
>
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'
2015-01-22 15:02 ` Jan Beulich
@ 2015-01-22 15:42 ` Tamas K Lengyel
0 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-22 15:42 UTC (permalink / raw)
To: Jan Beulich
Cc: Tim Deegan, Tian, Kevin, wei.liu2, Ian Campbell,
Stefano Stabellini, Dong, Eddie, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 4:02 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
>> --- a/xen/include/public/domctl.h
>> +++ b/xen/include/public/domctl.h
>> @@ -775,7 +775,7 @@ struct xen_domctl_gdbsx_domstatus {
>> #define XEN_DOMCTL_MEM_EVENT_OP_PAGING_DISABLE 1
>>
>> /*
>> - * Access permissions.
>> + * Monitor permissions.
>
> "permissions"?
>
> Jan
Ack, will do another sweep to make the comments more meaningful and
not just a mere word-replace.
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 4/8] x86/hvm: rename hvm_memory_event_* functions to hvm_event_*
2015-01-18 15:17 ` [RFC PATCH V2 4/8] x86/hvm: rename hvm_memory_event_* functions to hvm_event_* Tamas K Lengyel
2015-01-22 13:05 ` Tim Deegan
@ 2015-01-22 15:56 ` Andrew Cooper
2015-01-22 16:34 ` Tamas K Lengyel
1 sibling, 1 reply; 53+ messages in thread
From: Andrew Cooper @ 2015-01-22 15:56 UTC (permalink / raw)
To: Tamas K Lengyel, xen-devel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
ian.jackson, tim, jbeulich, eddie.dong, andres, jun.nakajima,
rshriram, keir, dgdegra, yanghy
On 18/01/15 15:17, Tamas K Lengyel wrote:
> The function names currently imply that these events are to be delivered via
> the memory_event subsystem. However, the naming is confusing as these events
> have nothing to do with actual memory events. Simply naming these functions
> hvm_event_* more accurately describe their usage.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
> ---
> docs/misc/pvh-readme.txt | 2 +-
> xen/arch/x86/hvm/hvm.c | 50 +++++++++++++++++++++----------------------
> xen/arch/x86/hvm/vmx/vmx.c | 6 +++---
> xen/include/asm-x86/hvm/hvm.h | 12 +++++------
> 4 files changed, 35 insertions(+), 35 deletions(-)
>
> diff --git a/docs/misc/pvh-readme.txt b/docs/misc/pvh-readme.txt
> index c5b3de4..bbd9dbe 100644
> --- a/docs/misc/pvh-readme.txt
> +++ b/docs/misc/pvh-readme.txt
> @@ -49,7 +49,7 @@ Following remain to be done for PVH:
> - AMD port.
> - 32bit PVH guest support in both linux and xen. Xen changes are tagged
> "32bitfixme".
> - - Add support for monitoring guest behavior. See hvm_memory_event* functions
> + - Add support for monitoring guest behavior. See hvm_event* functions
> in hvm.c
> - vcpu hotplug support
> - Live migration of PVH guests.
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index f936d51..1968865 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -3229,7 +3229,7 @@ int hvm_set_cr0(unsigned long value)
> hvm_funcs.handle_cd(v, value);
>
> hvm_update_cr(v, 0, value);
> - hvm_memory_event_cr0(value, old_value);
> + hvm_event_cr0(value, old_value);
I feel that if we are naming these things consistently, "vm_event_$FOO"
would be better than "hvm_event_$FOO". A while ago there was interest
in getting bits of the mem_event infrastructure working for PV guests,
and the vm_event infrastructure is not inherently hvm specific.
~Andrew
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-22 15:34 ` Tamas K Lengyel
@ 2015-01-22 16:00 ` Jan Beulich
2015-01-22 16:23 ` Tamas K Lengyel
2015-01-29 11:54 ` Tamas K Lengyel
1 sibling, 1 reply; 53+ messages in thread
From: Jan Beulich @ 2015-01-22 16:00 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: Tim Deegan, Kevin Tian, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Eddie Dong, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
>>> On 22.01.15 at 16:34, <tamas.lengyel@zentific.com> wrote:
> On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
>>> --- a/xen/include/public/mem_event.h
>>> +++ b/xen/include/public/mem_event.h
>>> @@ -27,9 +27,15 @@
>>> #ifndef _XEN_PUBLIC_MEM_EVENT_H
>>> #define _XEN_PUBLIC_MEM_EVENT_H
>>>
>>> +#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
>>> +#error "vm event operations are intended for use only by Xen or node
>>> control tools"
>>> +#endif
>>> +
>>> #include "xen.h"
>>> #include "io/ring.h"
>>>
>>> +#define MEM_EVENT_INTERFACE_VERSION 0x00000001
>>
>> This doesn't appear to be used anywhere, and hence isn't useful to
>> add here.
>
> It is intended to be used to establish an API version for backwards
> compatibility. We don't have any backwards compatibility checks at
> this point, but this will change as soon as we extend this interface
> as things go forward in the future.
But without the caller passing you the version of the ABI it uses,
how do you want to do such compatibility handling?
>>> @@ -48,16 +54,27 @@
>>> */
>>> #define MEM_EVENT_FLAG_EMULATE_NOWRITE (1 << 6)
>>>
>>> -/* Reasons for the memory event request */
>>> -#define MEM_EVENT_REASON_UNKNOWN 0 /* typical reason */
>>> -#define MEM_EVENT_REASON_VIOLATION 1 /* access violation, GFN is
>>> address */
>>> -#define MEM_EVENT_REASON_CR0 2 /* CR0 was hit: gfn is new CR0
>>> value, gla is previous */
>>> -#define MEM_EVENT_REASON_CR3 3 /* CR3 was hit: gfn is new CR3
>>> value, gla is previous */
>>> -#define MEM_EVENT_REASON_CR4 4 /* CR4 was hit: gfn is new CR4
>>> value, gla is previous */
>>> -#define MEM_EVENT_REASON_INT3 5 /* int3 was hit: gla/gfn are RIP
>>> */
>>> -#define MEM_EVENT_REASON_SINGLESTEP 6 /* single step was invoked:
>>> gla/gfn are RIP */
>>> -#define MEM_EVENT_REASON_MSR 7 /* MSR was hit: gfn is MSR value,
>>> gla is MSR address;
>>> - does NOT honour
> HVMPME_onchangeonly */
>>> +/* Reasons for the vm event request */
>>> +/* Default case */
>>> +#define MEM_EVENT_REASON_UNKNOWN 0
>>> +/* Memory access violation */
>>> +#define MEM_EVENT_REASON_MEM_ACCESS_VIOLATION 1
>>> +/* Memory sharing event */
>>> +#define MEM_EVENT_REASON_MEM_SHARING 2
>>> +/* Memory paging event */
>>> +#define MEM_EVENT_REASON_MEM_PAGING 3
>>> +/* CR0 was updated */
>>> +#define MEM_EVENT_REASON_CR0 4
>>> +/* CR3 was updated */
>>> +#define MEM_EVENT_REASON_CR3 5
>>> +/* CR4 was updated */
>>> +#define MEM_EVENT_REASON_CR4 6
>>> +/* Debug operation executed (int3) */
>>> +#define MEM_EVENT_REASON_INT3 7
>>> +/* Single-step (MTF) */
>>> +#define MEM_EVENT_REASON_SINGLESTEP 8
>>> +/* An MSR was updated. Does NOT honour HVMPME_onchangeonly */
>>> +#define MEM_EVENT_REASON_MSR 9
>>
>> I see you rename these a second time in patch 5 - can't this renaming
>> be reduced to just one?
>
> I didn't rename anything here, just updated the comments.
Afaics MEM_EVENT_REASON_VIOLATION became
MEM_EVENT_REASON_MEM_ACCESS_VIOLATION,
MEM_EVENT_REASON_MEM_{SHARING,PAGING} got
introduced, and many other got renumbered. And from a
trivial perspective - if what you said was true, the diff could
have retained every other line (as you then would have to
insert further blanks either).
>>> @@ -97,16 +114,16 @@ struct mem_event_regs_x86 {
>>> uint32_t _pad;
>>> };
>>>
>>> -typedef struct mem_event_st {
>>> - uint32_t flags;
>>> - uint32_t vcpu_id;
>>> +struct mem_event_regs {
>>> + union {
>>> + struct mem_event_regs_x86 x86;
>>> + };
>>> +};
>>
>> No non-standard (C89) features in public headers please.
>
> Elaborate please? I have this union as we will likely have ARM
> registers as well soon. I guess it can wait and be introduced when the
> ARM side catches up.
But the union has no field name.
>>> +struct mem_event_mem_access_data {
>>> uint64_t gfn;
>>> uint64_t offset;
>>> uint64_t gla; /* if gla_valid */
>>> -
>>> - uint32_t p2mt;
>>> -
>>> uint16_t access_r:1;
>>> uint16_t access_w:1;
>>> uint16_t access_x:1;
>>
>> I also wonder how well thought through the use of bit fields here is.
>
> It saves some space on the ring. Maybe a uint8_t is enough.
The same can be achieved with a flags field and a set of constants.
>>> +struct mem_event_int3_data {
>>> + uint64_t gfn;
>>> + uint64_t gla;
>>> +};
>>> +
>>> +struct mem_event_singlestep_data {
>>> + uint64_t gfn;
>>> + uint64_t gla;
>>> +};
>>
>> I may lack some understanding of the interfaces here, but what do
>> gfn and gla have to do with int3 and single-step events?
>
> These contained auxiliary info about the instruction triggering the
> event. It is somewhat superseded at this point by the automatic
> filling of the x86 registers struct, however, the gfn is not included
> in that struct so it can still be useful.
>
> Also, how
>> architecture-neutral is int3 really?!
>
> These aren't architecture neutral by any means. However, we likely are
> going to have SMC events on the ARM as well, which won't be
> architecture neutral either. I don't see a way around it. But why
> would this interface have to be architecture neutral? IMHO a comment
> saying these are features only for Intel/AMD/ARM would be sufficient.
> We already do checks for the architecture when the user attempts to
> enable these features to see if it actually supported on the hardware
> or not.
For the one at hand - why can't it be named software_breakpoint
or some such?
>>> +struct mem_event_msr_data {
>>> + uint64_t msr;
>>
>> Maybe better uint32_t with another such typed padding slot following?
>
> Not sure I follow. Could you elaborate what the issue is?
Architecturally there are no MSRs > 0xffffffff.
>>> +typedef struct mem_event_st {
>>> + uint32_t flags;
>>> + uint32_t vcpu_id;
>>> + uint32_t reason;
>>> +
>>> + union {
>>> + struct mem_event_paging_data mem_paging_event;
>>> + struct mem_event_sharing_data mem_sharing_event;
>>> + struct mem_event_mem_access_data mem_access_event;
>>> + struct mem_event_cr_data cr_event;
>>> + struct mem_event_int3_data int3_event;
>>> + struct mem_event_singlestep_data singlestep_event;
>>> + struct mem_event_msr_data msr_event;
>>> + };
>>>
>>> - uint16_t reason;
>>> - struct mem_event_regs_x86 x86_regs;
>>> + struct mem_event_regs regs;
>>> } mem_event_request_t, mem_event_response_t;
>>
>> This structure's layout now differs between 32- and 64-bit, which I'm
>> sure you want to avoid.
>
> Any suggestions? Make the struct(s) packed?
No, add explicit padding.
Jan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-22 16:00 ` Jan Beulich
@ 2015-01-22 16:23 ` Tamas K Lengyel
2015-01-22 16:34 ` Jan Beulich
0 siblings, 1 reply; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-22 16:23 UTC (permalink / raw)
To: Jan Beulich
Cc: Tim Deegan, Kevin Tian, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Eddie Dong, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 5:00 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 22.01.15 at 16:34, <tamas.lengyel@zentific.com> wrote:
>> On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
>>>> --- a/xen/include/public/mem_event.h
>>>> +++ b/xen/include/public/mem_event.h
>>>> @@ -27,9 +27,15 @@
>>>> #ifndef _XEN_PUBLIC_MEM_EVENT_H
>>>> #define _XEN_PUBLIC_MEM_EVENT_H
>>>>
>>>> +#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
>>>> +#error "vm event operations are intended for use only by Xen or node
>>>> control tools"
>>>> +#endif
>>>> +
>>>> #include "xen.h"
>>>> #include "io/ring.h"
>>>>
>>>> +#define MEM_EVENT_INTERFACE_VERSION 0x00000001
>>>
>>> This doesn't appear to be used anywhere, and hence isn't useful to
>>> add here.
>>
>> It is intended to be used to establish an API version for backwards
>> compatibility. We don't have any backwards compatibility checks at
>> this point, but this will change as soon as we extend this interface
>> as things go forward in the future.
>
> But without the caller passing you the version of the ABI it uses,
> how do you want to do such compatibility handling?
True. I was more imagining this flag to be used by the user to
determine (and know) what Xen supports. Currently we have to deduce
that by checking for various functions and structures being defined.
This would just simply that process for the user.
>
>>>> @@ -48,16 +54,27 @@
>>>> */
>>>> #define MEM_EVENT_FLAG_EMULATE_NOWRITE (1 << 6)
>>>>
>>>> -/* Reasons for the memory event request */
>>>> -#define MEM_EVENT_REASON_UNKNOWN 0 /* typical reason */
>>>> -#define MEM_EVENT_REASON_VIOLATION 1 /* access violation, GFN is
>>>> address */
>>>> -#define MEM_EVENT_REASON_CR0 2 /* CR0 was hit: gfn is new CR0
>>>> value, gla is previous */
>>>> -#define MEM_EVENT_REASON_CR3 3 /* CR3 was hit: gfn is new CR3
>>>> value, gla is previous */
>>>> -#define MEM_EVENT_REASON_CR4 4 /* CR4 was hit: gfn is new CR4
>>>> value, gla is previous */
>>>> -#define MEM_EVENT_REASON_INT3 5 /* int3 was hit: gla/gfn are RIP
>>>> */
>>>> -#define MEM_EVENT_REASON_SINGLESTEP 6 /* single step was invoked:
>>>> gla/gfn are RIP */
>>>> -#define MEM_EVENT_REASON_MSR 7 /* MSR was hit: gfn is MSR value,
>>>> gla is MSR address;
>>>> - does NOT honour
>> HVMPME_onchangeonly */
>>>> +/* Reasons for the vm event request */
>>>> +/* Default case */
>>>> +#define MEM_EVENT_REASON_UNKNOWN 0
>>>> +/* Memory access violation */
>>>> +#define MEM_EVENT_REASON_MEM_ACCESS_VIOLATION 1
>>>> +/* Memory sharing event */
>>>> +#define MEM_EVENT_REASON_MEM_SHARING 2
>>>> +/* Memory paging event */
>>>> +#define MEM_EVENT_REASON_MEM_PAGING 3
>>>> +/* CR0 was updated */
>>>> +#define MEM_EVENT_REASON_CR0 4
>>>> +/* CR3 was updated */
>>>> +#define MEM_EVENT_REASON_CR3 5
>>>> +/* CR4 was updated */
>>>> +#define MEM_EVENT_REASON_CR4 6
>>>> +/* Debug operation executed (int3) */
>>>> +#define MEM_EVENT_REASON_INT3 7
>>>> +/* Single-step (MTF) */
>>>> +#define MEM_EVENT_REASON_SINGLESTEP 8
>>>> +/* An MSR was updated. Does NOT honour HVMPME_onchangeonly */
>>>> +#define MEM_EVENT_REASON_MSR 9
>>>
>>> I see you rename these a second time in patch 5 - can't this renaming
>>> be reduced to just one?
>>
>> I didn't rename anything here, just updated the comments.
>
> Afaics MEM_EVENT_REASON_VIOLATION became
> MEM_EVENT_REASON_MEM_ACCESS_VIOLATION,
> MEM_EVENT_REASON_MEM_{SHARING,PAGING} got
> introduced, and many other got renumbered. And from a
> trivial perspective - if what you said was true, the diff could
> have retained every other line (as you then would have to
> insert further blanks either).
Ah yes, sorry for the noise. I was only looking at the last couple
defines and missed that we actually changed the others. The renaming
certainly can be done later, but the introduction of the new defines
needs to happen here.
>
>>>> @@ -97,16 +114,16 @@ struct mem_event_regs_x86 {
>>>> uint32_t _pad;
>>>> };
>>>>
>>>> -typedef struct mem_event_st {
>>>> - uint32_t flags;
>>>> - uint32_t vcpu_id;
>>>> +struct mem_event_regs {
>>>> + union {
>>>> + struct mem_event_regs_x86 x86;
>>>> + };
>>>> +};
>>>
>>> No non-standard (C89) features in public headers please.
>>
>> Elaborate please? I have this union as we will likely have ARM
>> registers as well soon. I guess it can wait and be introduced when the
>> ARM side catches up.
>
> But the union has no field name.
I see. I'll just move this union into mem_event_st and name it regs there.
>
>>>> +struct mem_event_mem_access_data {
>>>> uint64_t gfn;
>>>> uint64_t offset;
>>>> uint64_t gla; /* if gla_valid */
>>>> -
>>>> - uint32_t p2mt;
>>>> -
>>>> uint16_t access_r:1;
>>>> uint16_t access_w:1;
>>>> uint16_t access_x:1;
>>>
>>> I also wonder how well thought through the use of bit fields here is.
>>
>> It saves some space on the ring. Maybe a uint8_t is enough.
>
> The same can be achieved with a flags field and a set of constants.
True. I prefer having the variables directly describing its values
instead of having separate defines for the bits (like how i did for
struct npfec). IMHO it easier to read, but that's of course just a
personal preference.
>
>>>> +struct mem_event_int3_data {
>>>> + uint64_t gfn;
>>>> + uint64_t gla;
>>>> +};
>>>> +
>>>> +struct mem_event_singlestep_data {
>>>> + uint64_t gfn;
>>>> + uint64_t gla;
>>>> +};
>>>
>>> I may lack some understanding of the interfaces here, but what do
>>> gfn and gla have to do with int3 and single-step events?
>>
>> These contained auxiliary info about the instruction triggering the
>> event. It is somewhat superseded at this point by the automatic
>> filling of the x86 registers struct, however, the gfn is not included
>> in that struct so it can still be useful.
>>
>> Also, how
>>> architecture-neutral is int3 really?!
>>
>> These aren't architecture neutral by any means. However, we likely are
>> going to have SMC events on the ARM as well, which won't be
>> architecture neutral either. I don't see a way around it. But why
>> would this interface have to be architecture neutral? IMHO a comment
>> saying these are features only for Intel/AMD/ARM would be sufficient.
>> We already do checks for the architecture when the user attempts to
>> enable these features to see if it actually supported on the hardware
>> or not.
>
> For the one at hand - why can't it be named software_breakpoint
> or some such?
It can be named that - what would be the benefit? We still don't have
software breakpoints trappable to hyp mode on ARM so it still will be
just for x86.
>
>>>> +struct mem_event_msr_data {
>>>> + uint64_t msr;
>>>
>>> Maybe better uint32_t with another such typed padding slot following?
>>
>> Not sure I follow. Could you elaborate what the issue is?
>
> Architecturally there are no MSRs > 0xffffffff.
Ack.
>
>>>> +typedef struct mem_event_st {
>>>> + uint32_t flags;
>>>> + uint32_t vcpu_id;
>>>> + uint32_t reason;
>>>> +
>>>> + union {
>>>> + struct mem_event_paging_data mem_paging_event;
>>>> + struct mem_event_sharing_data mem_sharing_event;
>>>> + struct mem_event_mem_access_data mem_access_event;
>>>> + struct mem_event_cr_data cr_event;
>>>> + struct mem_event_int3_data int3_event;
>>>> + struct mem_event_singlestep_data singlestep_event;
>>>> + struct mem_event_msr_data msr_event;
>>>> + };
>>>>
>>>> - uint16_t reason;
>>>> - struct mem_event_regs_x86 x86_regs;
>>>> + struct mem_event_regs regs;
>>>> } mem_event_request_t, mem_event_response_t;
>>>
>>> This structure's layout now differs between 32- and 64-bit, which I'm
>>> sure you want to avoid.
>>
>> Any suggestions? Make the struct(s) packed?
>
> No, add explicit padding.
I was hoping to avoid that as it makes the structure quite messy to
read and in case a new struct is introduced to be delivered via
vm_event it may has to adjust the padding again. Wouldn't making the
struct packed just take care of it automatically?
>
> Jan
Thanks,
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file
2015-01-18 15:18 ` [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file Tamas K Lengyel
2015-01-22 15:00 ` Tim Deegan
@ 2015-01-22 16:25 ` Jan Beulich
2015-01-22 16:42 ` Tamas K Lengyel
2015-01-22 16:32 ` Andrew Cooper
2 siblings, 1 reply; 53+ messages in thread
From: Jan Beulich @ 2015-01-22 16:25 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: tim, kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
eddie.dong, ian.jackson, xen-devel, andres, jun.nakajima,
rshriram, keir, dgdegra, yanghy
>>> On 18.01.15 at 16:18, <tamas.lengyel@zentific.com> wrote:
> +static int hvm_event_traps(long parameters, vm_event_request_t *req)
> +{
> + int rc;
> + struct vcpu *v = current;
> + struct domain *d = v->domain;
Unless the intention is to have an exact 1:1 copy of the original,
please use curr and currd here respectively.
> +void hvm_event_cr0(unsigned long value, unsigned long old)
> +{
> + vm_event_request_t req = {
> + .reason = VM_EVENT_REASON_CR0,
> + .vcpu_id = current->vcpu_id,
> + .cr_event.new_value = value,
> + .cr_event.old_value = old
> + };
> +
> + long parameters = current->domain->arch.hvm_domain
> + .params[HVM_PARAM_MEMORY_EVENT_CR0];
And latch current into a local variable curr here and below.
> +void hvm_event_msr(unsigned long msr, unsigned long value)
> +{
> + vm_event_request_t req = {
> + .reason = VM_EVENT_REASON_MSR,
> + .vcpu_id = current->vcpu_id,
> + .msr_event.msr = msr,
> + .msr_event.new_value = value,
> + };
The .msr_event sub-structure also has an old_value member - how
come this doesn't get filled (I realize the old code was this way,
but I now doubt earlier patches are all correct in the regard).
Jan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file
2015-01-18 15:18 ` [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file Tamas K Lengyel
2015-01-22 15:00 ` Tim Deegan
2015-01-22 16:25 ` Jan Beulich
@ 2015-01-22 16:32 ` Andrew Cooper
2015-01-22 16:41 ` Tamas K Lengyel
2 siblings, 1 reply; 53+ messages in thread
From: Andrew Cooper @ 2015-01-22 16:32 UTC (permalink / raw)
To: Tamas K Lengyel, xen-devel
Cc: kevin.tian, wei.liu2, ian.campbell, stefano.stabellini,
ian.jackson, tim, jbeulich, eddie.dong, andres, jun.nakajima,
rshriram, keir, dgdegra, yanghy
On 18/01/15 15:18, Tamas K Lengyel wrote:
> -void hvm_event_cr0(unsigned long value, unsigned long old)
> -{
> - vm_event_request_t req = {
> - .reason = VM_EVENT_REASON_CR0,
> - .vcpu_id = current->vcpu_id,
> - .cr_event.new_value = value,
> - .cr_event.old_value = old
> - };
> -
> - long parameters = current->domain->arch.hvm_domain
> - .params[HVM_PARAM_MEMORY_EVENT_CR0];
(I realise this is probably not the best patch, but) As we are redoing
the API with a hope of including PV and ARM guests, can we remove this
use of hvm params? This would probably involve a new setup hypercall
subop to set up reporting preferences.
~Andrew
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-22 16:23 ` Tamas K Lengyel
@ 2015-01-22 16:34 ` Jan Beulich
[not found] ` <CAErYnsj8B1Fbo=JD3hLz-8kjtt-FoWTrSkGnbkvVf=iR64MDBQ@mail.gmail.com>
0 siblings, 1 reply; 53+ messages in thread
From: Jan Beulich @ 2015-01-22 16:34 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: Tim Deegan, Kevin Tian, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Eddie Dong, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
>>> On 22.01.15 at 17:23, <tamas.lengyel@zentific.com> wrote:
> On Thu, Jan 22, 2015 at 5:00 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 22.01.15 at 16:34, <tamas.lengyel@zentific.com> wrote:
>>> On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
>>>>> --- a/xen/include/public/mem_event.h
>>>>> +++ b/xen/include/public/mem_event.h
>>>>> @@ -27,9 +27,15 @@
>>>>> #ifndef _XEN_PUBLIC_MEM_EVENT_H
>>>>> #define _XEN_PUBLIC_MEM_EVENT_H
>>>>>
>>>>> +#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
>>>>> +#error "vm event operations are intended for use only by Xen or node
>>>>> control tools"
>>>>> +#endif
>>>>> +
>>>>> #include "xen.h"
>>>>> #include "io/ring.h"
>>>>>
>>>>> +#define MEM_EVENT_INTERFACE_VERSION 0x00000001
>>>>
>>>> This doesn't appear to be used anywhere, and hence isn't useful to
>>>> add here.
>>>
>>> It is intended to be used to establish an API version for backwards
>>> compatibility. We don't have any backwards compatibility checks at
>>> this point, but this will change as soon as we extend this interface
>>> as things go forward in the future.
>>
>> But without the caller passing you the version of the ABI it uses,
>> how do you want to do such compatibility handling?
>
> True. I was more imagining this flag to be used by the user to
> determine (and know) what Xen supports. Currently we have to deduce
> that by checking for various functions and structures being defined.
> This would just simply that process for the user.
If you think this will work going forward... Domctl and sysctl
specifically do it the other way. Plus if you do it the way you
describe, I can't see why __XEN_LATEST_INTERFACE_VERSION__
wouldn't be sufficient.
>>>>> +struct mem_event_mem_access_data {
>>>>> uint64_t gfn;
>>>>> uint64_t offset;
>>>>> uint64_t gla; /* if gla_valid */
>>>>> -
>>>>> - uint32_t p2mt;
>>>>> -
>>>>> uint16_t access_r:1;
>>>>> uint16_t access_w:1;
>>>>> uint16_t access_x:1;
>>>>
>>>> I also wonder how well thought through the use of bit fields here is.
>>>
>>> It saves some space on the ring. Maybe a uint8_t is enough.
>>
>> The same can be achieved with a flags field and a set of constants.
>
> True. I prefer having the variables directly describing its values
> instead of having separate defines for the bits (like how i did for
> struct npfec). IMHO it easier to read, but that's of course just a
> personal preference.
I too prefer this, but interface definitions require putting aside
such preferences. Just consider what happens on bi-endianness
architectures when consumer and producer use different
endianness. Since the bitfields aren't accessible as an addressable
entity, you can't byte swap them as you would need to. Plus
compilers have (or should I say take) quite a bit more freedom on
what they do to bitfields than what they may do to ordinary
structure members.
>>> Also, how
>>>> architecture-neutral is int3 really?!
>>>
>>> These aren't architecture neutral by any means. However, we likely are
>>> going to have SMC events on the ARM as well, which won't be
>>> architecture neutral either. I don't see a way around it. But why
>>> would this interface have to be architecture neutral? IMHO a comment
>>> saying these are features only for Intel/AMD/ARM would be sufficient.
>>> We already do checks for the architecture when the user attempts to
>>> enable these features to see if it actually supported on the hardware
>>> or not.
>>
>> For the one at hand - why can't it be named software_breakpoint
>> or some such?
>
> It can be named that - what would be the benefit? We still don't have
> software breakpoints trappable to hyp mode on ARM so it still will be
> just for x86.
But you could re-use "software_breakpoint" for ARM, while you can't
re-use "int3".
>>>>> +typedef struct mem_event_st {
>>>>> + uint32_t flags;
>>>>> + uint32_t vcpu_id;
>>>>> + uint32_t reason;
>>>>> +
>>>>> + union {
>>>>> + struct mem_event_paging_data mem_paging_event;
>>>>> + struct mem_event_sharing_data mem_sharing_event;
>>>>> + struct mem_event_mem_access_data mem_access_event;
>>>>> + struct mem_event_cr_data cr_event;
>>>>> + struct mem_event_int3_data int3_event;
>>>>> + struct mem_event_singlestep_data singlestep_event;
>>>>> + struct mem_event_msr_data msr_event;
>>>>> + };
>>>>>
>>>>> - uint16_t reason;
>>>>> - struct mem_event_regs_x86 x86_regs;
>>>>> + struct mem_event_regs regs;
>>>>> } mem_event_request_t, mem_event_response_t;
>>>>
>>>> This structure's layout now differs between 32- and 64-bit, which I'm
>>>> sure you want to avoid.
>>>
>>> Any suggestions? Make the struct(s) packed?
>>
>> No, add explicit padding.
>
> I was hoping to avoid that as it makes the structure quite messy to
> read and in case a new struct is introduced to be delivered via
> vm_event it may has to adjust the padding again.
How that? Fields with alignment bigger than that of uint64_t aren't
likely to appear.
> Wouldn't making the
> struct packed just take care of it automatically?
How would you envision to do that without using compiler
extensions?
Jan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 4/8] x86/hvm: rename hvm_memory_event_* functions to hvm_event_*
2015-01-22 15:56 ` Andrew Cooper
@ 2015-01-22 16:34 ` Tamas K Lengyel
0 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-22 16:34 UTC (permalink / raw)
To: Andrew Cooper
Cc: Tian, Kevin, wei.liu2, Ian Campbell, Stefano Stabellini,
Ian Jackson, Tim Deegan, xen-devel, Jan Beulich, Dong, Eddie,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 4:56 PM, Andrew Cooper
<andrew.cooper3@citrix.com> wrote:
> On 18/01/15 15:17, Tamas K Lengyel wrote:
>> The function names currently imply that these events are to be delivered via
>> the memory_event subsystem. However, the naming is confusing as these events
>> have nothing to do with actual memory events. Simply naming these functions
>> hvm_event_* more accurately describe their usage.
>>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
>> ---
>> docs/misc/pvh-readme.txt | 2 +-
>> xen/arch/x86/hvm/hvm.c | 50 +++++++++++++++++++++----------------------
>> xen/arch/x86/hvm/vmx/vmx.c | 6 +++---
>> xen/include/asm-x86/hvm/hvm.h | 12 +++++------
>> 4 files changed, 35 insertions(+), 35 deletions(-)
>>
>> diff --git a/docs/misc/pvh-readme.txt b/docs/misc/pvh-readme.txt
>> index c5b3de4..bbd9dbe 100644
>> --- a/docs/misc/pvh-readme.txt
>> +++ b/docs/misc/pvh-readme.txt
>> @@ -49,7 +49,7 @@ Following remain to be done for PVH:
>> - AMD port.
>> - 32bit PVH guest support in both linux and xen. Xen changes are tagged
>> "32bitfixme".
>> - - Add support for monitoring guest behavior. See hvm_memory_event* functions
>> + - Add support for monitoring guest behavior. See hvm_event* functions
>> in hvm.c
>> - vcpu hotplug support
>> - Live migration of PVH guests.
>> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
>> index f936d51..1968865 100644
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -3229,7 +3229,7 @@ int hvm_set_cr0(unsigned long value)
>> hvm_funcs.handle_cd(v, value);
>>
>> hvm_update_cr(v, 0, value);
>> - hvm_memory_event_cr0(value, old_value);
>> + hvm_event_cr0(value, old_value);
>
> I feel that if we are naming these things consistently, "vm_event_$FOO"
> would be better than "hvm_event_$FOO". A while ago there was interest
> in getting bits of the mem_event infrastructure working for PV guests,
> and the vm_event infrastructure is not inherently hvm specific.
>
> ~Andrew
Surely.
Thanks,
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file
2015-01-22 16:32 ` Andrew Cooper
@ 2015-01-22 16:41 ` Tamas K Lengyel
0 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-22 16:41 UTC (permalink / raw)
To: Andrew Cooper
Cc: Tian, Kevin, wei.liu2, Ian Campbell, Stefano Stabellini,
Ian Jackson, Tim Deegan, xen-devel, Jan Beulich, Dong, Eddie,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 5:32 PM, Andrew Cooper
<andrew.cooper3@citrix.com> wrote:
> On 18/01/15 15:18, Tamas K Lengyel wrote:
>> -void hvm_event_cr0(unsigned long value, unsigned long old)
>> -{
>> - vm_event_request_t req = {
>> - .reason = VM_EVENT_REASON_CR0,
>> - .vcpu_id = current->vcpu_id,
>> - .cr_event.new_value = value,
>> - .cr_event.old_value = old
>> - };
>> -
>> - long parameters = current->domain->arch.hvm_domain
>> - .params[HVM_PARAM_MEMORY_EVENT_CR0];
>
> (I realise this is probably not the best patch, but) As we are redoing
> the API with a hope of including PV and ARM guests, can we remove this
> use of hvm params? This would probably involve a new setup hypercall
> subop to set up reporting preferences.
>
> ~Andrew
Ack, that would be certainly a useful addition. We would need to
define some new place to store these preferences for the domain.
Thanks,
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file
2015-01-22 16:25 ` Jan Beulich
@ 2015-01-22 16:42 ` Tamas K Lengyel
2015-01-22 16:50 ` Tim Deegan
2015-01-23 8:56 ` Razvan Cojocaru
0 siblings, 2 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-22 16:42 UTC (permalink / raw)
To: Jan Beulich
Cc: Tim Deegan, Tian, Kevin, wei.liu2, Ian Campbell,
Stefano Stabellini, Dong, Eddie, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 5:25 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 18.01.15 at 16:18, <tamas.lengyel@zentific.com> wrote:
>> +static int hvm_event_traps(long parameters, vm_event_request_t *req)
>> +{
>> + int rc;
>> + struct vcpu *v = current;
>> + struct domain *d = v->domain;
>
> Unless the intention is to have an exact 1:1 copy of the original,
> please use curr and currd here respectively.
Ack.
>
>> +void hvm_event_cr0(unsigned long value, unsigned long old)
>> +{
>> + vm_event_request_t req = {
>> + .reason = VM_EVENT_REASON_CR0,
>> + .vcpu_id = current->vcpu_id,
>> + .cr_event.new_value = value,
>> + .cr_event.old_value = old
>> + };
>> +
>> + long parameters = current->domain->arch.hvm_domain
>> + .params[HVM_PARAM_MEMORY_EVENT_CR0];
>
> And latch current into a local variable curr here and below.
Ack.
>
>> +void hvm_event_msr(unsigned long msr, unsigned long value)
>> +{
>> + vm_event_request_t req = {
>> + .reason = VM_EVENT_REASON_MSR,
>> + .vcpu_id = current->vcpu_id,
>> + .msr_event.msr = msr,
>> + .msr_event.new_value = value,
>> + };
>
> The .msr_event sub-structure also has an old_value member - how
> come this doesn't get filled (I realize the old code was this way,
> but I now doubt earlier patches are all correct in the regard).
Razvan might have more information on this side as I haven't really
touched MSR events. I vaguely recall some issues with having access to
the old MSR value?
>
> Jan
>
Thanks,
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file
2015-01-22 16:42 ` Tamas K Lengyel
@ 2015-01-22 16:50 ` Tim Deegan
2015-01-23 8:56 ` Razvan Cojocaru
1 sibling, 0 replies; 53+ messages in thread
From: Tim Deegan @ 2015-01-22 16:50 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: Tian, Kevin, wei.liu2, Ian Campbell, Stefano Stabellini,
Jun Nakajima, Dong, Eddie, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jan Beulich, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
At 17:42 +0100 on 22 Jan (1421944966), Tamas K Lengyel wrote:
> On Thu, Jan 22, 2015 at 5:25 PM, Jan Beulich <JBeulich@suse.com> wrote:
> >>>> On 18.01.15 at 16:18, <tamas.lengyel@zentific.com> wrote:
> >> +static int hvm_event_traps(long parameters, vm_event_request_t *req)
> >> +{
> >> + int rc;
> >> + struct vcpu *v = current;
> >> + struct domain *d = v->domain;
> >
> > Unless the intention is to have an exact 1:1 copy of the original,
> > please use curr and currd here respectively.
>
> Ack.
>
> >
> >> +void hvm_event_cr0(unsigned long value, unsigned long old)
> >> +{
> >> + vm_event_request_t req = {
> >> + .reason = VM_EVENT_REASON_CR0,
> >> + .vcpu_id = current->vcpu_id,
> >> + .cr_event.new_value = value,
> >> + .cr_event.old_value = old
> >> + };
> >> +
> >> + long parameters = current->domain->arch.hvm_domain
> >> + .params[HVM_PARAM_MEMORY_EVENT_CR0];
> >
> > And latch current into a local variable curr here and below.
>
> Ack.
>
> >
> >> +void hvm_event_msr(unsigned long msr, unsigned long value)
> >> +{
> >> + vm_event_request_t req = {
> >> + .reason = VM_EVENT_REASON_MSR,
> >> + .vcpu_id = current->vcpu_id,
> >> + .msr_event.msr = msr,
> >> + .msr_event.new_value = value,
> >> + };
> >
> > The .msr_event sub-structure also has an old_value member - how
> > come this doesn't get filled (I realize the old code was this way,
> > but I now doubt earlier patches are all correct in the regard).
>
> Razvan might have more information on this side as I haven't really
> touched MSR events. I vaguely recall some issues with having access to
> the old MSR value?
Yep - ISTR this is also why the MSR event doesn't respect
HVMPME_onchangeonly.
Tim.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file
2015-01-22 16:42 ` Tamas K Lengyel
2015-01-22 16:50 ` Tim Deegan
@ 2015-01-23 8:56 ` Razvan Cojocaru
2015-01-23 9:03 ` Jan Beulich
1 sibling, 1 reply; 53+ messages in thread
From: Razvan Cojocaru @ 2015-01-23 8:56 UTC (permalink / raw)
To: Tamas K Lengyel, Jan Beulich
Cc: Tian, Kevin, wei.liu2, Ian Campbell, Stefano Stabellini,
Tim Deegan, Dong, Eddie, xen-devel, Andres Lagar-Cavilla,
Jun Nakajima, rshriram, Keir Fraser, Daniel De Graaf, yanghy,
Ian Jackson
On 01/22/2015 06:42 PM, Tamas K Lengyel wrote:
> On Thu, Jan 22, 2015 at 5:25 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 18.01.15 at 16:18, <tamas.lengyel@zentific.com> wrote:
>>> +void hvm_event_msr(unsigned long msr, unsigned long value)
>>> +{
>>> + vm_event_request_t req = {
>>> + .reason = VM_EVENT_REASON_MSR,
>>> + .vcpu_id = current->vcpu_id,
>>> + .msr_event.msr = msr,
>>> + .msr_event.new_value = value,
>>> + };
>>
>> The .msr_event sub-structure also has an old_value member - how
>> come this doesn't get filled (I realize the old code was this way,
>> but I now doubt earlier patches are all correct in the regard).
>
> Razvan might have more information on this side as I haven't really
> touched MSR events. I vaguely recall some issues with having access to
> the old MSR value?
Indeed, getting the previous value would be a bit involved. Please see
xen/arch/x86/hvm/hvm.c, specifically hvm_msr_write_intercept(). At first
glance, you'd have to call hvm_msr_read_intercept() to get the previous
value, or create some sort of cache for previous values for all MSRs,
updated by hvm_msr_write_intercept().
Since this has not had any real value for my use-case, and since my code
has only needed to keep track of a handful of MSRs, I took the route of
caching previous values for them in the userspace application.
This is, of course, not to say that it can't be done at the HV level,
just that (at least IMHO) the HV-level costs have outweighed the benefits.
Thanks for the question,
Razvan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
[not found] ` <CAErYnsj8B1Fbo=JD3hLz-8kjtt-FoWTrSkGnbkvVf=iR64MDBQ@mail.gmail.com>
@ 2015-01-23 9:00 ` Jan Beulich
2015-01-23 9:18 ` Tamas K Lengyel
0 siblings, 1 reply; 53+ messages in thread
From: Jan Beulich @ 2015-01-23 9:00 UTC (permalink / raw)
To: Tamas K Lengyel; +Cc: xen-devel
(re-adding xen-devel)
>>> On 22.01.15 at 17:54, <tamas.lengyel@zentific.com> wrote:
> On Thu, Jan 22, 2015 at 5:34 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 22.01.15 at 17:23, <tamas.lengyel@zentific.com> wrote:
>>> Wouldn't making the
>>> struct packed just take care of it automatically?
>>
>> How would you envision to do that without using compiler
>> extensions?
>
> My understanding of making the struct packed is that there is simply
> no alignment and padding. Thus, it would look the same on 32-bit and
> 64-bit as the size of each member is explicitly the same on each
> architecture. Am I missing something here?
But isn't that exactly what I suggested by adding explicit padding?
If not, please give an example.
Jan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file
2015-01-23 8:56 ` Razvan Cojocaru
@ 2015-01-23 9:03 ` Jan Beulich
2015-01-23 9:21 ` Tamas K Lengyel
0 siblings, 1 reply; 53+ messages in thread
From: Jan Beulich @ 2015-01-23 9:03 UTC (permalink / raw)
To: Razvan Cojocaru, Tamas K Lengyel
Cc: Tim Deegan, Kevin Tian, wei.liu2, Ian Campbell,
Stefano Stabellini, Eddie Dong, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
>>> On 23.01.15 at 09:56, <rcojocaru@bitdefender.com> wrote:
> On 01/22/2015 06:42 PM, Tamas K Lengyel wrote:
>> On Thu, Jan 22, 2015 at 5:25 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>> On 18.01.15 at 16:18, <tamas.lengyel@zentific.com> wrote:
>>>> +void hvm_event_msr(unsigned long msr, unsigned long value)
>>>> +{
>>>> + vm_event_request_t req = {
>>>> + .reason = VM_EVENT_REASON_MSR,
>>>> + .vcpu_id = current->vcpu_id,
>>>> + .msr_event.msr = msr,
>>>> + .msr_event.new_value = value,
>>>> + };
>>>
>>> The .msr_event sub-structure also has an old_value member - how
>>> come this doesn't get filled (I realize the old code was this way,
>>> but I now doubt earlier patches are all correct in the regard).
>>
>> Razvan might have more information on this side as I haven't really
>> touched MSR events. I vaguely recall some issues with having access to
>> the old MSR value?
>
> Indeed, getting the previous value would be a bit involved. Please see
> xen/arch/x86/hvm/hvm.c, specifically hvm_msr_write_intercept(). At first
> glance, you'd have to call hvm_msr_read_intercept() to get the previous
> value, or create some sort of cache for previous values for all MSRs,
> updated by hvm_msr_write_intercept().
>
> Since this has not had any real value for my use-case, and since my code
> has only needed to keep track of a handful of MSRs, I took the route of
> caching previous values for them in the userspace application.
>
> This is, of course, not to say that it can't be done at the HV level,
> just that (at least IMHO) the HV-level costs have outweighed the benefits.
In which case the respective interface structure field should have a
comment attached saying that it currently doesn't hold what the field
name promises (and, without having checked whether this may already
be the case, it should be made hold a deterministic value, e.g. zero).
Jan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-23 9:00 ` Jan Beulich
@ 2015-01-23 9:18 ` Tamas K Lengyel
0 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-23 9:18 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
On Fri, Jan 23, 2015 at 10:00 AM, Jan Beulich <JBeulich@suse.com> wrote:
> (re-adding xen-devel)
>
>>>> On 22.01.15 at 17:54, <tamas.lengyel@zentific.com> wrote:
>> On Thu, Jan 22, 2015 at 5:34 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>> On 22.01.15 at 17:23, <tamas.lengyel@zentific.com> wrote:
>>>> Wouldn't making the
>>>> struct packed just take care of it automatically?
>>>
>>> How would you envision to do that without using compiler
>>> extensions?
>>
>> My understanding of making the struct packed is that there is simply
>> no alignment and padding. Thus, it would look the same on 32-bit and
>> 64-bit as the size of each member is explicitly the same on each
>> architecture. Am I missing something here?
>
> But isn't that exactly what I suggested by adding explicit padding?
> If not, please give an example.
>
> Jan
Ack, I was thinking of using __attribute__((packed)) but I see your
point now that that's a gcc extensions. So we are going to have to do
it by hand as you said.
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file
2015-01-23 9:03 ` Jan Beulich
@ 2015-01-23 9:21 ` Tamas K Lengyel
0 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-23 9:21 UTC (permalink / raw)
To: Jan Beulich
Cc: Tim Deegan, Kevin Tian, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Eddie Dong, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Fri, Jan 23, 2015 at 10:03 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 23.01.15 at 09:56, <rcojocaru@bitdefender.com> wrote:
>> On 01/22/2015 06:42 PM, Tamas K Lengyel wrote:
>>> On Thu, Jan 22, 2015 at 5:25 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>>> On 18.01.15 at 16:18, <tamas.lengyel@zentific.com> wrote:
>>>>> +void hvm_event_msr(unsigned long msr, unsigned long value)
>>>>> +{
>>>>> + vm_event_request_t req = {
>>>>> + .reason = VM_EVENT_REASON_MSR,
>>>>> + .vcpu_id = current->vcpu_id,
>>>>> + .msr_event.msr = msr,
>>>>> + .msr_event.new_value = value,
>>>>> + };
>>>>
>>>> The .msr_event sub-structure also has an old_value member - how
>>>> come this doesn't get filled (I realize the old code was this way,
>>>> but I now doubt earlier patches are all correct in the regard).
>>>
>>> Razvan might have more information on this side as I haven't really
>>> touched MSR events. I vaguely recall some issues with having access to
>>> the old MSR value?
>>
>> Indeed, getting the previous value would be a bit involved. Please see
>> xen/arch/x86/hvm/hvm.c, specifically hvm_msr_write_intercept(). At first
>> glance, you'd have to call hvm_msr_read_intercept() to get the previous
>> value, or create some sort of cache for previous values for all MSRs,
>> updated by hvm_msr_write_intercept().
>>
>> Since this has not had any real value for my use-case, and since my code
>> has only needed to keep track of a handful of MSRs, I took the route of
>> caching previous values for them in the userspace application.
>>
>> This is, of course, not to say that it can't be done at the HV level,
>> just that (at least IMHO) the HV-level costs have outweighed the benefits.
>
> In which case the respective interface structure field should have a
> comment attached saying that it currently doesn't hold what the field
> name promises (and, without having checked whether this may already
> be the case, it should be made hold a deterministic value, e.g. zero).
>
> Jan
Ack, I'll remove it as we don't need unused struct members to pollute
the landscape.
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-22 15:34 ` Tamas K Lengyel
2015-01-22 16:00 ` Jan Beulich
@ 2015-01-29 11:54 ` Tamas K Lengyel
2015-01-29 12:02 ` Jan Beulich
1 sibling, 1 reply; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-29 11:54 UTC (permalink / raw)
To: Jan Beulich
Cc: Tim Deegan, Tian, Kevin, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Dong, Eddie, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 22, 2015 at 4:34 PM, Tamas K Lengyel
<tamas.lengyel@zentific.com> wrote:
> On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
>>> --- a/xen/include/Makefile
>>> +++ b/xen/include/Makefile
>>> @@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>>>
>>> all: headers.chk
>>>
>>> -headers.chk: $(filter-out public/arch-% public/%ctl.h public/xsm/%
>>> public/%hvm/save.h, $(wildcard public/*.h public/*/*.h) $(public-y)) Makefile
>>> +headers.chk: $(filter-out public/arch-% public/%ctl.h public/mem_event.h
>>> public/xsm/% public/%hvm/save.h, $(wildcard public/*.h public/*/*.h)
>>> $(public-y)) Makefile
>>
>> I think you should finally break this already too long line. But of course
>> first of all you'll want to explain why the addition is necessary/correct.
>> The mere fact that this now becomes a tools-only interface isn't
>> enough imo - some of the other headers excluded here would better
>> undergo the checking too, just that first they would need cleaning up.
>
> I have to revisit what is actually going on here, I believe I had to
> add this to get Xen to build. On a second look not sure why that was.
So I double checked and the addition here is correct, without
excluding the header, the compilation fails at #if !defined(__XEN__)
&& !defined(__XEN_TOOLS__) in mem_event.h. So I'll break the line but
cleaning up/checking the other headers IMHO is out of scope for this
series.
Thanks,
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-29 11:54 ` Tamas K Lengyel
@ 2015-01-29 12:02 ` Jan Beulich
2015-01-29 12:09 ` Tamas K Lengyel
0 siblings, 1 reply; 53+ messages in thread
From: Jan Beulich @ 2015-01-29 12:02 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: Tim Deegan, Kevin Tian, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Eddie Dong, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
>>> On 29.01.15 at 12:54, <tamas.lengyel@zentific.com> wrote:
> On Thu, Jan 22, 2015 at 4:34 PM, Tamas K Lengyel
> <tamas.lengyel@zentific.com> wrote:
>> On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
>>>> --- a/xen/include/Makefile
>>>> +++ b/xen/include/Makefile
>>>> @@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>>>>
>>>> all: headers.chk
>>>>
>>>> -headers.chk: $(filter-out public/arch-% public/%ctl.h public/xsm/%
>>>> public/%hvm/save.h, $(wildcard public/*.h public/*/*.h) $(public-y)) Makefile
>>>> +headers.chk: $(filter-out public/arch-% public/%ctl.h public/mem_event.h
>>>> public/xsm/% public/%hvm/save.h, $(wildcard public/*.h public/*/*.h)
>>>> $(public-y)) Makefile
>>>
>>> I think you should finally break this already too long line. But of course
>>> first of all you'll want to explain why the addition is necessary/correct.
>>> The mere fact that this now becomes a tools-only interface isn't
>>> enough imo - some of the other headers excluded here would better
>>> undergo the checking too, just that first they would need cleaning up.
>>
>> I have to revisit what is actually going on here, I believe I had to
>> add this to get Xen to build. On a second look not sure why that was.
>
> So I double checked and the addition here is correct, without
> excluding the header, the compilation fails at #if !defined(__XEN__)
> && !defined(__XEN_TOOLS__) in mem_event.h.
Hardly at that line. I'm afraid I won't be convinced without you
explaining what fails why, and why that can't be dealt with.
> So I'll break the line but
> cleaning up/checking the other headers IMHO is out of scope for this
> series.
Of course, no-one asked you to do this (and even less so in this series).
Jan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-29 12:02 ` Jan Beulich
@ 2015-01-29 12:09 ` Tamas K Lengyel
2015-01-29 12:15 ` Tamas K Lengyel
2015-01-29 12:51 ` Jan Beulich
0 siblings, 2 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-29 12:09 UTC (permalink / raw)
To: Jan Beulich
Cc: Tim Deegan, Kevin Tian, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Eddie Dong, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 29, 2015 at 1:02 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 29.01.15 at 12:54, <tamas.lengyel@zentific.com> wrote:
>> On Thu, Jan 22, 2015 at 4:34 PM, Tamas K Lengyel
>> <tamas.lengyel@zentific.com> wrote:
>>> On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
>>>>> --- a/xen/include/Makefile
>>>>> +++ b/xen/include/Makefile
>>>>> @@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>>>>>
>>>>> all: headers.chk
>>>>>
>>>>> -headers.chk: $(filter-out public/arch-% public/%ctl.h public/xsm/%
>>>>> public/%hvm/save.h, $(wildcard public/*.h public/*/*.h) $(public-y)) Makefile
>>>>> +headers.chk: $(filter-out public/arch-% public/%ctl.h public/mem_event.h
>>>>> public/xsm/% public/%hvm/save.h, $(wildcard public/*.h public/*/*.h)
>>>>> $(public-y)) Makefile
>>>>
>>>> I think you should finally break this already too long line. But of course
>>>> first of all you'll want to explain why the addition is necessary/correct.
>>>> The mere fact that this now becomes a tools-only interface isn't
>>>> enough imo - some of the other headers excluded here would better
>>>> undergo the checking too, just that first they would need cleaning up.
>>>
>>> I have to revisit what is actually going on here, I believe I had to
>>> add this to get Xen to build. On a second look not sure why that was.
>>
>> So I double checked and the addition here is correct, without
>> excluding the header, the compilation fails at #if !defined(__XEN__)
>> && !defined(__XEN_TOOLS__) in mem_event.h.
>
> Hardly at that line. I'm afraid I won't be convinced without you
> explaining what fails why, and why that can't be dealt with.
>
>> So I'll break the line but
>> cleaning up/checking the other headers IMHO is out of scope for this
>> series.
>
> Of course, no-one asked you to do this (and even less so in this series).
>
> Jan
The reason why compilation fails is because the new preprocessor check
in mem_event.j #if !defined(__XEN__) && !defined(__XEN_TOOLS__) is not
happy and I get the error message #error "vm event operations are
intended for use only by Xen or node control tools". This is a new
addition into the mem_event.h thus the build without this
pre-processor check works just fine. All other headers within
include/public that have similar preprocessor checks are already
excluded in this line, thus my impression was this is the correct way
to get the build to progress. Of course if I missed something please
let me know, I don't honestly fully comprehend the build process here.
Thanks,
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-29 12:09 ` Tamas K Lengyel
@ 2015-01-29 12:15 ` Tamas K Lengyel
2015-01-29 12:51 ` Jan Beulich
1 sibling, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-29 12:15 UTC (permalink / raw)
To: Jan Beulich
Cc: Tim Deegan, Kevin Tian, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Eddie Dong, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 29, 2015 at 1:09 PM, Tamas K Lengyel
<tamas.lengyel@zentific.com> wrote:
> On Thu, Jan 29, 2015 at 1:02 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 29.01.15 at 12:54, <tamas.lengyel@zentific.com> wrote:
>>> On Thu, Jan 22, 2015 at 4:34 PM, Tamas K Lengyel
>>> <tamas.lengyel@zentific.com> wrote:
>>>> On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>>>> On 18.01.15 at 16:17, <tamas.lengyel@zentific.com> wrote:
>>>>>> --- a/xen/include/Makefile
>>>>>> +++ b/xen/include/Makefile
>>>>>> @@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>>>>>>
>>>>>> all: headers.chk
>>>>>>
>>>>>> -headers.chk: $(filter-out public/arch-% public/%ctl.h public/xsm/%
>>>>>> public/%hvm/save.h, $(wildcard public/*.h public/*/*.h) $(public-y)) Makefile
>>>>>> +headers.chk: $(filter-out public/arch-% public/%ctl.h public/mem_event.h
>>>>>> public/xsm/% public/%hvm/save.h, $(wildcard public/*.h public/*/*.h)
>>>>>> $(public-y)) Makefile
>>>>>
>>>>> I think you should finally break this already too long line. But of course
>>>>> first of all you'll want to explain why the addition is necessary/correct.
>>>>> The mere fact that this now becomes a tools-only interface isn't
>>>>> enough imo - some of the other headers excluded here would better
>>>>> undergo the checking too, just that first they would need cleaning up.
>>>>
>>>> I have to revisit what is actually going on here, I believe I had to
>>>> add this to get Xen to build. On a second look not sure why that was.
>>>
>>> So I double checked and the addition here is correct, without
>>> excluding the header, the compilation fails at #if !defined(__XEN__)
>>> && !defined(__XEN_TOOLS__) in mem_event.h.
>>
>> Hardly at that line. I'm afraid I won't be convinced without you
>> explaining what fails why, and why that can't be dealt with.
>>
>>> So I'll break the line but
>>> cleaning up/checking the other headers IMHO is out of scope for this
>>> series.
>>
>> Of course, no-one asked you to do this (and even less so in this series).
>>
>> Jan
>
> The reason why compilation fails is because the new preprocessor check
> in mem_event.j #if !defined(__XEN__) && !defined(__XEN_TOOLS__) is not
> happy and I get the error message #error "vm event operations are
> intended for use only by Xen or node control tools". This is a new
> addition into the mem_event.h thus the build without this
> pre-processor check works just fine. All other headers within
> include/public that have similar preprocessor checks are already
> excluded in this line, thus my impression was this is the correct way
> to get the build to progress. Of course if I missed something please
> let me know, I don't honestly fully comprehend the build process here.
>
> Thanks,
> Tamas
Here is the full error message I get when the header is not filtered-out here:
for i in public/vcpu.h public/kexec.h public/dom0_ops.h public/nmi.h
public/xencomm.h public/gcov.h public/elfnote.h public/xenoprof.h
public/sched.h public/version.h public/mem_event.h public/memory.h
public/xen.h public/features.h public/callback.h public/grant_table.h
public/xen-compat.h public/physdev.h public/platform.h public/tmem.h
public/trace.h public/event_channel.h public/io/xs_wire.h
public/io/kbdif.h public/io/protocols.h public/io/ring.h
public/io/fsif.h public/io/blkif.h public/io/console.h
public/io/tpmif.h public/io/fbif.h public/io/xenbus.h
public/io/netif.h public/io/pciif.h public/io/usbif.h
public/io/libxenvchan.h public/io/vscsiif.h public/hvm/pvdrivers.h
public/hvm/e820.h public/hvm/hvm_xs_strings.h public/hvm/hvm_op.h
public/hvm/hvm_info_table.h public/hvm/ioreq.h public/hvm/params.h; do
gcc -ansi -include stdint.h -Wall -W -Werror -S -o /dev/null -x c $i
|| exit 1; echo $i; done >headers.chk.new
public/mem_event.h:31:2: error: #error "vm event operations are
intended for use only by Xen or node control tools"
#error "vm event operations are intended for use only by Xen or node
control tools"
^
Makefile:94: recipe for target 'headers.chk' failed
make[3]: *** [headers.chk] Error 1
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-29 12:09 ` Tamas K Lengyel
2015-01-29 12:15 ` Tamas K Lengyel
@ 2015-01-29 12:51 ` Jan Beulich
2015-01-29 13:03 ` Tamas K Lengyel
1 sibling, 1 reply; 53+ messages in thread
From: Jan Beulich @ 2015-01-29 12:51 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: Tim Deegan, Kevin Tian, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Eddie Dong, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
>>> On 29.01.15 at 13:09, <tamas.lengyel@zentific.com> wrote:
> The reason why compilation fails is because the new preprocessor check
> in mem_event.j #if !defined(__XEN__) && !defined(__XEN_TOOLS__) is not
> happy and I get the error message #error "vm event operations are
> intended for use only by Xen or node control tools".
Ah, it's the #error afterwards.
> This is a new
> addition into the mem_event.h thus the build without this
> pre-processor check works just fine. All other headers within
> include/public that have similar preprocessor checks are already
> excluded in this line, thus my impression was this is the correct way
> to get the build to progress. Of course if I missed something please
> let me know, I don't honestly fully comprehend the build process here.
Question is - do you really need this here? Is it completely beyond
possibility that some event interaction may also be possible from
the VM being subject of the event generation/handling? There are
plenty examples of
#if defined(__XEN__) || defined(__XEN_TOOLS__)
in other than domctl.h/sysctl.h, and perhaps that's instead the way
to go here?
Jan
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures
2015-01-29 12:51 ` Jan Beulich
@ 2015-01-29 13:03 ` Tamas K Lengyel
0 siblings, 0 replies; 53+ messages in thread
From: Tamas K Lengyel @ 2015-01-29 13:03 UTC (permalink / raw)
To: Jan Beulich
Cc: Tim Deegan, Kevin Tian, wei.liu2, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Eddie Dong, Ian Jackson, xen-devel,
Andres Lagar-Cavilla, Jun Nakajima, rshriram, Keir Fraser,
Daniel De Graaf, yanghy
On Thu, Jan 29, 2015 at 1:51 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 29.01.15 at 13:09, <tamas.lengyel@zentific.com> wrote:
>> The reason why compilation fails is because the new preprocessor check
>> in mem_event.j #if !defined(__XEN__) && !defined(__XEN_TOOLS__) is not
>> happy and I get the error message #error "vm event operations are
>> intended for use only by Xen or node control tools".
>
> Ah, it's the #error afterwards.
>
>> This is a new
>> addition into the mem_event.h thus the build without this
>> pre-processor check works just fine. All other headers within
>> include/public that have similar preprocessor checks are already
>> excluded in this line, thus my impression was this is the correct way
>> to get the build to progress. Of course if I missed something please
>> let me know, I don't honestly fully comprehend the build process here.
>
> Question is - do you really need this here? Is it completely beyond
> possibility that some event interaction may also be possible from
> the VM being subject of the event generation/handling? There are
> plenty examples of
>
> #if defined(__XEN__) || defined(__XEN_TOOLS__)
>
> in other than domctl.h/sysctl.h, and perhaps that's instead the way
> to go here?
>
> Jan
Sure, that would work if I wrap the entire header into that
#if/#endif. I can switch to that if preferred.
Tamas
^ permalink raw reply [flat|nested] 53+ messages in thread
end of thread, other threads:[~2015-01-29 13:03 UTC | newest]
Thread overview: 53+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-18 15:17 [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Tamas K Lengyel
2015-01-18 15:17 ` [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures Tamas K Lengyel
2015-01-22 12:43 ` Tim Deegan
2015-01-22 12:50 ` Razvan Cojocaru
2015-01-22 12:50 ` Tamas K Lengyel
2015-01-22 12:53 ` Razvan Cojocaru
2015-01-22 13:11 ` Tim Deegan
2015-01-22 15:00 ` Jan Beulich
2015-01-22 15:34 ` Tamas K Lengyel
2015-01-22 16:00 ` Jan Beulich
2015-01-22 16:23 ` Tamas K Lengyel
2015-01-22 16:34 ` Jan Beulich
[not found] ` <CAErYnsj8B1Fbo=JD3hLz-8kjtt-FoWTrSkGnbkvVf=iR64MDBQ@mail.gmail.com>
2015-01-23 9:00 ` Jan Beulich
2015-01-23 9:18 ` Tamas K Lengyel
2015-01-29 11:54 ` Tamas K Lengyel
2015-01-29 12:02 ` Jan Beulich
2015-01-29 12:09 ` Tamas K Lengyel
2015-01-29 12:15 ` Tamas K Lengyel
2015-01-29 12:51 ` Jan Beulich
2015-01-29 13:03 ` Tamas K Lengyel
2015-01-18 15:17 ` [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor' Tamas K Lengyel
2015-01-22 12:53 ` Tim Deegan
2015-01-22 14:12 ` Tamas K Lengyel
2015-01-22 15:02 ` Jan Beulich
2015-01-22 15:42 ` Tamas K Lengyel
2015-01-18 15:17 ` [RFC PATCH V2 3/8] xen/mem_paging: Convert mem_event_op to mem_paging_op Tamas K Lengyel
2015-01-22 13:03 ` Tim Deegan
2015-01-22 15:09 ` Jan Beulich
2015-01-22 15:41 ` Tamas K Lengyel
2015-01-18 15:17 ` [RFC PATCH V2 4/8] x86/hvm: rename hvm_memory_event_* functions to hvm_event_* Tamas K Lengyel
2015-01-22 13:05 ` Tim Deegan
2015-01-22 15:56 ` Andrew Cooper
2015-01-22 16:34 ` Tamas K Lengyel
2015-01-18 15:17 ` [RFC PATCH V2 5/8] xen/mem_event: Rename mem_event to vm_event Tamas K Lengyel
2015-01-22 14:52 ` Tim Deegan
2015-01-22 15:02 ` Tamas K Lengyel
2015-01-18 15:17 ` [RFC PATCH V2 6/8] xen/vm_event: Decouple vm_event and mem_access Tamas K Lengyel
2015-01-22 14:56 ` Tim Deegan
2015-01-22 15:35 ` Tamas K Lengyel
2015-01-18 15:18 ` [RFC PATCH V2 7/8] tools/tests: Clean-up tools/tests/xen-access Tamas K Lengyel
2015-01-18 15:18 ` [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file Tamas K Lengyel
2015-01-22 15:00 ` Tim Deegan
2015-01-22 15:36 ` Tamas K Lengyel
2015-01-22 16:25 ` Jan Beulich
2015-01-22 16:42 ` Tamas K Lengyel
2015-01-22 16:50 ` Tim Deegan
2015-01-23 8:56 ` Razvan Cojocaru
2015-01-23 9:03 ` Jan Beulich
2015-01-23 9:21 ` Tamas K Lengyel
2015-01-22 16:32 ` Andrew Cooper
2015-01-22 16:41 ` Tamas K Lengyel
2015-01-19 13:03 ` [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Andrew Cooper
2015-01-21 10:59 ` Tamas K Lengyel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.