> > > printf("PAGE ACCESS: %c%c%c for GFN %"PRIx64" (offset > %06" > > - PRIx64") gla %016"PRIx64" (vcpu %d)\n", > > + PRIx64") gla %016"PRIx64" (valid: %c) fault in > gpt: %c fault with gla: %c (vcpu %u)\n", > > This patch is fine except that the message punctuation could do with > being slightly improved, I think. Something like this: > > PRIx64") gla %016"PRIx64" (valid: %c; fault in gpt: %c; fault with gla: > %c; vcpu %u)\n", > > unless I have misunderstood the nature of these fields. > > Thanks, > Ian. > I agree, that print format may be more intuitive. I will reroll the patch to include these changes. Thanks, Tamas