From: Tamas K Lengyel <tamas.lengyel@zentific.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Jun Nakajima <jun.nakajima@intel.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] vmx/monitor: CPUID events
Date: Fri, 8 Jul 2016 09:44:45 -0600 [thread overview]
Message-ID: <CAErYnshgLWUPTPGw0hewHsn9U4ca5t80tvUT2Siz9sqzpQFAKg@mail.gmail.com> (raw)
In-Reply-To: <0cf6f009-a73b-02b1-d71d-d1277105d3d9@citrix.com>
On Fri, Jul 8, 2016 at 3:33 AM, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> On 08/07/16 03:31, Tamas K Lengyel wrote:
>> This patch implements sending notification to a monitor subscriber when an
>> x86/vmx guest executes the CPUID instruction.
>>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
>
> Is it wise having an on/off control without any further filtering? (I
> suppose that it is at least a fine first start).
What type of extra filtering do you have in mind?
>
> cpuid is usually the serialising instruction used with rdtsc for timing
> loops. This is bad enough in VMs because of the VMExit, but becomes
> even worse if there is a monitor delay as well.
Yes, going the extra route of sending a monitor event out will add to
that delay (how much delay will depend on the subscriber and what it
decides to do with the event). Wouldn't we be able to mask some of
that with tsc offsetting though?
Thanks,
Tamas
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-08 15:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 2:31 [PATCH] vmx/monitor: CPUID events Tamas K Lengyel
2016-07-08 7:03 ` Razvan Cojocaru
2016-07-08 15:36 ` Tamas K Lengyel
2016-07-08 9:33 ` Andrew Cooper
2016-07-08 15:44 ` Tamas K Lengyel [this message]
2016-07-08 16:49 ` Andrew Cooper
2016-07-08 16:59 ` Tamas K Lengyel
2016-07-08 17:37 ` Andrew Cooper
2016-07-11 3:00 ` Tian, Kevin
2016-07-12 16:30 ` Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAErYnshgLWUPTPGw0hewHsn9U4ca5t80tvUT2Siz9sqzpQFAKg@mail.gmail.com \
--to=tamas.lengyel@zentific.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=rcojocaru@bitdefender.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.