From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tamas K Lengyel <tamas.lengyel@zentific.com>
Subject: Re: [PATCH v3 15/15] tools/tests: Enable xen-access on
	ARM
Date: Tue, 2 Sep 2014 10:49:13 +0200
Message-ID: <CAErYnshkmiViGF_YyyxuiQ+QLP_tjqfA+EDOuBVS69o==dY4Qw@mail.gmail.com>
References: <1409581329-2607-1-git-send-email-tklengyel@sec.in.tum.de>
	<1409581329-2607-16-git-send-email-tklengyel@sec.in.tum.de>
	<5404E48D.8080109@linaro.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7080268877629784864=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5404E48D.8080109@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Jan Beulich <jbeulich@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Tamas K Lengyel <tklengyel@sec.in.tum.de>
List-Id: xen-devel@lists.xenproject.org

--===============7080268877629784864==
Content-Type: multipart/alternative; boundary=001a11c361229bc6f90502113180

--001a11c361229bc6f90502113180
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Sep 1, 2014 at 11:26 PM, Julien Grall <julien.grall@linaro.org>
wrote:

> Hello Tamas,
>
>
> On 01/09/14 10:22, Tamas K Lengyel wrote:
>
>> diff --git a/tools/tests/xen-access/Makefile b/tools/tests/xen-access/
>> Makefile
>> index 65eef99..698355c 100644
>> --- a/tools/tests/xen-access/Makefile
>> +++ b/tools/tests/xen-access/Makefile
>> @@ -7,9 +7,7 @@ CFLAGS += $(CFLAGS_libxenctrl)
>>   CFLAGS += $(CFLAGS_libxenguest)
>>   CFLAGS += $(CFLAGS_xeninclude)
>>
>> -TARGETS-y :=
>> -TARGETS-$(CONFIG_X86) += xen-access
>> -TARGETS := $(TARGETS-y)
>> +TARGETS := xen-access
>>
>
> I would move the definition of HAS_MEM_ACCESS from arch/*/Rules.mk to
> config/*.mk and use the defition here to build or not xen-access.
>
>
>  @@ -520,7 +551,7 @@ int main(int argc, char *argv[])
>>
>>               /* Unregister for every event */
>>               rc = xc_set_mem_access(xch, domain_id, XENMEM_access_rwx,
>> ~0ull, 0);
>> -            rc = xc_set_mem_access(xch, domain_id, XENMEM_access_rwx, 0,
>> +            rc = xc_set_mem_access(xch, domain_id, XENMEM_access_rwx,
>> GUEST_RAM_BASE_PFN,
>>                                      xenaccess->domain_info->max_pages);
>>
>
> ARM may contains multiple banks non-contiguous banks. On Xen 4.5, there is
> 2 banks with a hole (see GUEST_RAM{0,1}_* in xen/include/public/arch-arm.h)
> .
>
> This change won't work with guest using more than 3G of RAM.
>

I guess it would only partially work. I'll add an #ifdef CONFIG_ARM here to
set the second bank's permissions also.

Tamas


>
> Regards,
>
> --
> Julien Grall
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>

--001a11c361229bc6f90502113180
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><br><div class=3D"gmail=
_quote">On Mon, Sep 1, 2014 at 11:26 PM, Julien Grall <span dir=3D"ltr">&lt=
;<a href=3D"mailto:julien.grall@linaro.org" target=3D"_blank">julien.grall@=
linaro.org</a>&gt;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">Hello Tamas,<div class=3D""><br>
<br>
On 01/09/14 10:22, Tamas K Lengyel wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
diff --git a/tools/tests/xen-access/<u></u>Makefile b/tools/tests/xen-acces=
s/<u></u>Makefile<br>
index 65eef99..698355c 100644<br>
--- a/tools/tests/xen-access/<u></u>Makefile<br>
+++ b/tools/tests/xen-access/<u></u>Makefile<br>
@@ -7,9 +7,7 @@ CFLAGS +=3D $(CFLAGS_libxenctrl)<br>
=A0 CFLAGS +=3D $(CFLAGS_libxenguest)<br>
=A0 CFLAGS +=3D $(CFLAGS_xeninclude)<br>
<br>
-TARGETS-y :=3D<br>
-TARGETS-$(CONFIG_X86) +=3D xen-access<br>
-TARGETS :=3D $(TARGETS-y)<br>
+TARGETS :=3D xen-access<br>
</blockquote>
<br></div>
I would move the definition of HAS_MEM_ACCESS from arch/*/Rules.mk to confi=
g/*.mk and use the defition here to build or not xen-access.<div class=3D""=
><br>
<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
@@ -520,7 +551,7 @@ int main(int argc, char *argv[])<br>
<br>
=A0 =A0 =A0 =A0 =A0 =A0 =A0 /* Unregister for every event */<br>
=A0 =A0 =A0 =A0 =A0 =A0 =A0 rc =3D xc_set_mem_access(xch, domain_id, XENMEM=
_access_rwx, ~0ull, 0);<br>
-=A0 =A0 =A0 =A0 =A0 =A0 rc =3D xc_set_mem_access(xch, domain_id, XENMEM_ac=
cess_rwx, 0,<br>
+=A0 =A0 =A0 =A0 =A0 =A0 rc =3D xc_set_mem_access(xch, domain_id, XENMEM_ac=
cess_rwx, GUEST_RAM_BASE_PFN,<br>
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
xenaccess-&gt;domain_info-&gt;max_<u></u>pages);<br>
</blockquote>
<br></div>
ARM may contains multiple banks non-contiguous banks. On Xen 4.5, there is =
2 banks with a hole (see GUEST_RAM{0,1}_* in xen/include/public/arch-arm.h)=
<u></u>.<br>
<br>
This change won&#39;t work with guest using more than 3G of RAM.<br></block=
quote><div><br></div><div>I guess it would only partially work. I&#39;ll ad=
d an #ifdef CONFIG_ARM here to set the second bank&#39;s permissions also.<=
br>
<br>Tamas<br></div><div>=A0</div><blockquote class=3D"gmail_quote" style=3D=
"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Regards,<span class=3D"HOEnZb"><font color=3D"#888888"><br>
<br>
-- <br>
Julien Grall</font></span><div class=3D"HOEnZb"><div class=3D"h5"><br>
<br>
______________________________<u></u>_________________<br>
Xen-devel mailing list<br>
<a href=3D"mailto:Xen-devel@lists.xen.org" target=3D"_blank">Xen-devel@list=
s.xen.org</a><br>
<a href=3D"http://lists.xen.org/xen-devel" target=3D"_blank">http://lists.x=
en.org/xen-devel</a><br>
</div></div></blockquote></div><br></div></div>

--001a11c361229bc6f90502113180--


--===============7080268877629784864==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============7080268877629784864==--