From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamas K Lengyel Subject: Re: [PATCH v3 01/15] xen: Relocate mem_access and mem_event into common. Date: Mon, 1 Sep 2014 17:15:47 +0200 Message-ID: References: <1409581329-2607-1-git-send-email-tklengyel@sec.in.tum.de> <1409581329-2607-2-git-send-email-tklengyel@sec.in.tum.de> <5404A77B020000780002F860@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7080145345337810288==" Return-path: In-Reply-To: <5404A77B020000780002F860@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian Campbell , Tim Deegan , Julien Grall , Ian Jackson , "xen-devel@lists.xen.org" , Stefano Stabellini , Andres Lagar-Cavilla , Daniel De Graaf , Tamas K Lengyel List-Id: xen-devel@lists.xenproject.org --===============7080145345337810288== Content-Type: multipart/alternative; boundary=001a11c17ab63ea90d0502027a55 --001a11c17ab63ea90d0502027a55 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Sep 1, 2014 at 5:06 PM, Jan Beulich wrote: > >>> On 01.09.14 at 16:21, wrote: > > --- /dev/null > > +++ b/xen/common/mem_access.c > > @@ -0,0 +1,133 @@ > > > +/****************************************************************************** > > + * mem_access.c > > + * > > + * Memory access support. > > + * > > + * Copyright (c) 2011 Virtuata, Inc. > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License as published by > > + * the Free Software Foundation; either version 2 of the License, or > > + * (at your option) any later version. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * You should have received a copy of the GNU General Public License > > + * along with this program; if not, write to the Free Software > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA > 02111-1307 USA > > + */ > > + > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > I asked you on the previous round already to get this mixture of > headers from various subdirectories cleaned up: Unless anything > really can't be made built with properly grouped headers, please > have all xen/, asm/, public/, xsm/, etc headers each grouped > together. > > > +int prepare_ring_for_helper( > > + struct domain *d, unsigned long gmfn, struct page_info **_page, > > + void **_va) > > +{ > > + struct page_info *page; > > + p2m_type_t p2mt; > > + void *va; > > + > > + page = get_page_from_gfn(d, gmfn, &p2mt, P2M_UNSHARE); > > + > > +#ifdef CONFIG_MEM_PAGING > > I can't spot where this and CONFIG_MEM_SHARING get defined in > this patch. > > Jan Right, they only get defined later in patch [13/15], I forgot to move them up front. Tamas --001a11c17ab63ea90d0502027a55 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable



On Mon, Sep 1, 2014 at 5:06 PM, Jan Beulich <<= a href=3D"mailto:JBeulich@suse.com" target=3D"_blank">JBeulich@suse.com= > wrote:
>= >> On 01.09.14 at 16:21, <tklengyel@sec.in.tum.de> wrote:
> --- /dev/null
> +++ b/xen/common/mem_access.c
> @@ -0,0 +1,133 @@
> +/********************************************************************= **********
> + * mem_access.c
> + *
> + * Memory access support.
> + *
> + * Copyright (c) 2011 Virtuata, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modi= fy
> + * it under the terms of the GNU General Public License as published = by
> + * the Free Software Foundation; either version 2 of the License, or<= br> > + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.=A0 See the > + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License<= br> > + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA=A0 02111-= 1307=A0 USA
> + */
> +
> +
> +#include <xen/sched.h>
> +#include <xen/guest_access.h>
> +#include <xen/hypercall.h>
> +#include <asm/p2m.h>
> +#include <public/memory.h>
> +#include <xen/mem_event.h>
> +#include <xsm/xsm.h>

I asked you on the previous round already to get this mixture o= f
headers from various subdirectories cleaned up: Unless anything
really can't be made built with properly grouped headers, please
have all xen/, asm/, public/, xsm/, etc headers each grouped
together.

> +int prepare_ring_for_helper(
> +=A0 =A0 struct domain *d, unsigned long gmfn, struct page_info **_pag= e,
> +=A0 =A0 void **_va)
> +{
> +=A0 =A0 struct page_info *page;
> +=A0 =A0 p2m_type_t p2mt;
> +=A0 =A0 void *va;
> +
> +=A0 =A0 page =3D get_page_from_gfn(d, gmfn, &p2mt, P2M_UNSHARE);<= br> > +
> +#ifdef CONFIG_MEM_PAGING

I can't spot where this and CONFIG_MEM_SHARING get defined in
this patch.

Jan

Right, they only get defi= ned later in patch [13/15], I forgot to move them up front.

Tamas
--001a11c17ab63ea90d0502027a55-- --===============7080145345337810288== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7080145345337810288==--