From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tamas K Lengyel <tamas.lengyel@zentific.com>
Subject: Re: [PATCH V6 04/13] xen: Rename mem_event to vm_event
Date: Wed, 18 Feb 2015 18:22:06 +0100
Message-ID: <CAErYnsiBENCZh-10ChS+KE0Pn3uQz6_vyhbos6=L4H-EiRj4JA@mail.gmail.com>
References: <1424218303-11331-1-git-send-email-tamas.lengyel@zentific.com>
	<1424218303-11331-5-git-send-email-tamas.lengyel@zentific.com>
	<54E46D6A0200007800060F85@mail.emea.novell.com>
	<1424262111.5799.17.camel@terminator>
	<54E4A32A0200007800061161@mail.emea.novell.com>
	<CAErYnsjafdqSMQVRDGkb1KN6azAvPOnWw0UkT4JSJUqqUESRiA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAErYnsjafdqSMQVRDGkb1KN6azAvPOnWw0UkT4JSJUqqUESRiA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, "Tian, Kevin" <kevin.tian@intel.com>, "wei.liu2@citrix.com" <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Steven Maresca <steve@zentific.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Tamas K Lengyel <tamas.k.lengyel@gmail.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "Dong,
	Eddie" <eddie.dong@intel.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Jun Nakajima <jun.nakajima@intel.com>, "rshriram@cs.ubc.ca" <rshriram@cs.ubc.ca>, Keir Fraser <keir@xen.org>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, "yanghy@cn.fujitsu.com" <yanghy@cn.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, Feb 18, 2015 at 4:55 PM, Tamas K Lengyel
<tamas.lengyel@zentific.com> wrote:
> On Wed, Feb 18, 2015 at 2:35 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 18.02.15 at 13:21, <tamas.k.lengyel@gmail.com> wrote:
>>> On Wed Feb 18 2015 10:46:02 AM CET, Jan Beulich <JBeulich@suse.com> wrote:
>>>
>>>> > > > On 18.02.15 at 01:11, <tamas.lengyel@zentific.com> wrote:
>>>> > diff --git a/xen/common/mem_event.c b/xen/common/vm_event.c
>>>> > similarity index 59%
>>>> > rename from xen/common/mem_event.c
>>>> > rename to xen/common/vm_event.c
>>>>
>>>> Looking at this already quite huge delta I can't really see why
>>>> adjusting white space at once would make it much worse. In any
>>>> case better than leaving white space damage behind.
>>>
>>> I did that in the first version of the patch and the feedback I got was that
>>> it is unreviewable that way.
>>
>> Not really - in the first version of the patch the old file gets removed
>> as a whole, and the new file added. Same in v2 afaics, where indeed
>> you got such a comment.
>>
>> Jan
>
> I would rather prefer it all being done in one patch but unfortunately
> git can't keep track of the code movement that way. I'm not aware of
> any option to git to achieve all this in one patch.
>
> Tamas

So apparently this is possible if I relax the default 50% similarity
index -M looks for. I'll merge the white-space fixing part into this
patch in v7.

Thanks,
Tamas