From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tamas K Lengyel <tamas.lengyel@zentific.com>
Subject: Re: [PATCH for-4.5 v8 16/19] xen/arm: Instruction
 prefetch abort (X) mem_event handling
Date: Wed, 24 Sep 2014 19:08:03 +0200
Message-ID: <CAErYnsiVNwTKjiSNFS6PKMrjCSnk2Ky3bqm1GX5xeofxtXA5Cg@mail.gmail.com>
References: <1411478070-13836-1-git-send-email-tklengyel@sec.in.tum.de>
	<1411478070-13836-17-git-send-email-tklengyel@sec.in.tum.de>
	<5422E60C.2010007@linaro.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1814858990351702318=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5422E60C.2010007@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Jan Beulich <jbeulich@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Tamas K Lengyel <tklengyel@sec.in.tum.de>
List-Id: xen-devel@lists.xenproject.org

--===============1814858990351702318==
Content-Type: multipart/alternative; boundary=001a11c2c5c2101c600503d2bac0

--001a11c2c5c2101c600503d2bac0
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Sep 24, 2014 at 5:41 PM, Julien Grall <julien.grall@linaro.org>
wrote:

> Hello Tamas,
>
> On 09/23/2014 02:14 PM, Tamas K Lengyel wrote:
> > +        unsigned long s1ptw:1; /* Fault during a stage 1 translation
> table walk */
>
> [..]
>
> > +        unsigned long s1ptw:1; /* Fault during a stage 1 translation
> table walk */
>
> The description is confusing, it gives the impression that this bit is
> used to know if the fault has occurred a stage 1 translation table walk
> or not. I would say: "Stage 2 fault during a stage 1 translation table
> walk".
>
> Regards,
>
> --
> Julien Grall
>

That's a bit too long to fit into 80 chars in that line and I don't want to
line-break for the comment (looks ugly). Maybe shorten it to "Stage 2 fault
during stage 1 translation"?

Tamas

--001a11c2c5c2101c600503d2bac0
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Wed, Sep 24, 2014 at 5:41 PM, Julien Grall <span dir=3D"ltr">&lt;<a =
href=3D"mailto:julien.grall@linaro.org" target=3D"_blank">julien.grall@lina=
ro.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"=
margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Tamas,=
<br>
<span class=3D""><br>
On 09/23/2014 02:14 PM, Tamas K Lengyel wrote:<br>
&gt; +=A0 =A0 =A0 =A0 unsigned long s1ptw:1; /* Fault during a stage 1 tran=
slation table walk */<br>
<br>
</span>[..]<br>
<span class=3D""><br>
&gt; +=A0 =A0 =A0 =A0 unsigned long s1ptw:1; /* Fault during a stage 1 tran=
slation table walk */<br>
<br>
</span>The description is confusing, it gives the impression that this bit =
is<br>
used to know if the fault has occurred a stage 1 translation table walk<br>
or not. I would say: &quot;Stage 2 fault during a stage 1 translation table=
<br>
walk&quot;.<br>
<br>
Regards,<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
--<br>
Julien Grall<br>
</font></span></blockquote></div><br></div><div class=3D"gmail_extra">That&=
#39;s a bit too long to fit into 80 chars in that line and I don&#39;t want=
 to line-break for the comment (looks ugly). Maybe shorten it to &quot;Stag=
e 2 fault during stage 1 translation&quot;?<br><br></div><div class=3D"gmai=
l_extra">Tamas<br></div></div>

--001a11c2c5c2101c600503d2bac0--


--===============1814858990351702318==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============1814858990351702318==--