>
> +    /* For PV domains we only support rw, rx, rx2rw, rwx access
> permissions */
>

There is a bit of discrepancy between the comment and the code here. Also,
could you briefly explain why only these permissions are supported?


> +    if ( unlikely(p2ma != p2m_access_r &&
> +                  p2ma != p2m_access_rw &&
> +                  p2ma != p2m_access_rx &&
> +                  p2ma != p2m_access_rwx &&
> +                  p2ma != p2m_access_rx2rw) )
> +        return -EINVAL;
>


> +    /* For PV domains we only support r, rw, rx, rwx access permissions */
>

Code/comment discrepancy again.


> +    if ( p2m->default_access != p2m_access_r &&
> +         p2m->default_access != p2m_access_rw &&
> +         p2m->default_access != p2m_access_rx &&
> +         p2m->default_access != p2m_access_rwx &&
> +         p2m->default_access != p2m_access_rx2rw )
> +        return -EINVAL;
> +
>