From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamas K Lengyel Subject: Re: [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case Date: Fri, 12 Aug 2016 08:51:14 -0600 Message-ID: References: <1470841215-24450-1-git-send-email-tamas.lengyel@zentific.com> <1470841215-24450-2-git-send-email-tamas.lengyel@zentific.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7632494182439483241==" Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYDo4-00036V-W2 for xen-devel@lists.xenproject.org; Fri, 12 Aug 2016 14:51:33 +0000 Received: by mail-ua0-f194.google.com with SMTP id d97so2197741uad.1 for ; Fri, 12 Aug 2016 07:51:31 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Julien Grall Cc: Wei Liu , Sergej Proskurin , Ian Jackson , Jan Beulich , Andrew Cooper , xen-devel@lists.xenproject.org, Daniel De Graaf List-Id: xen-devel@lists.xenproject.org --===============7632494182439483241== Content-Type: multipart/alternative; boundary=94eb2c14b102a512a00539e103af --94eb2c14b102a512a00539e103af Content-Type: text/plain; charset=UTF-8 On Aug 12, 2016 05:24, "Julien Grall" wrote: > > Hello Tamas, > > > On 10/08/2016 17:00, Tamas K Lengyel wrote: >> >> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl >> index ef614be..97948fd 100644 >> --- a/tools/libxl/libxl_types.idl >> +++ b/tools/libxl/libxl_types.idl >> @@ -439,6 +439,13 @@ libxl_rdm_reserve = Struct("rdm_reserve", [ >> ("policy", libxl_rdm_reserve_policy), >> ]) >> >> +# Consistent with the values defined for HVM_PARAM_ALTP2M >> +libxl_altp2m_mode = Enumeration("altp2m_mode", [ >> + (0, "disabled"), >> + (1, "mixed"), >> + (2, "external_only"), >> + ], init_val = "LIBXL_ALTP2M_MODE_DISABLED") >> + >> libxl_domain_build_info = Struct("domain_build_info",[ >> ("max_vcpus", integer), >> ("avail_vcpus", libxl_bitmap), >> @@ -512,7 +519,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ >> ("mmio_hole_memkb", MemKB), >> ("timer_mode", libxl_timer_mode), >> ("nested_hvm", libxl_defbool), >> - ("altp2m", libxl_defbool), >> + ("altp2m", libxl_altp2m_mode), > > > Should we move altp2m directly outside of the structure "hvm" to avoid yet another change when altp2m will be supported on ARM? (see [1]) > > Regards, > > [1] https://lists.xen.org/archives/html/xen-devel/2016-08/msg00147.html > > -- > Julien Grall Hi Julien, We can do that here if preferred by the tools maintainers though I'm on the opinion that it should be adjusted in the ARM altp2m series once it actually becomes available there. Tamas --94eb2c14b102a512a00539e103af Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Aug 12, 2016 05:24, "Julien Grall" <julien.grall@arm.com> wrote:
>
> Hello Tamas,
>
>
> On 10/08/2016 17:00, Tamas K Lengyel wrote:
>>
>> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types= .idl
>> index ef614be..97948fd 100644
>> --- a/tools/libxl/libxl_types.idl
>> +++ b/tools/libxl/libxl_types.idl
>> @@ -439,6 +439,13 @@ libxl_rdm_reserve =3D Struct("rdm_reserv= e", [
>> =C2=A0 =C2=A0 =C2=A0("policy",=C2=A0 =C2=A0 =C2=A0 libxl= _rdm_reserve_policy),
>> =C2=A0 =C2=A0 =C2=A0])
>>
>> +# Consistent with the values defined for HVM_PARAM_ALTP2M
>> +libxl_altp2m_mode =3D Enumeration("altp2m_mode", [
>> +=C2=A0 =C2=A0 (0, "disabled"),
>> +=C2=A0 =C2=A0 (1, "mixed"),
>> +=C2=A0 =C2=A0 (2, "external_only"),
>> +=C2=A0 =C2=A0 ], init_val =3D "LIBXL_ALTP2M_MODE_DISABLED&qu= ot;)
>> +
>> =C2=A0libxl_domain_build_info =3D Struct("domain_build_info&q= uot;,[
>> =C2=A0 =C2=A0 =C2=A0("max_vcpus",=C2=A0 =C2=A0 =C2=A0 = =C2=A0integer),
>> =C2=A0 =C2=A0 =C2=A0("avail_vcpus",=C2=A0 =C2=A0 =C2=A0l= ibxl_bitmap),
>> @@ -512,7 +519,7 @@ libxl_domain_build_info =3D Struct("domai= n_build_info",[
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (= "mmio_hole_memkb",=C2=A0 MemKB),
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (= "timer_mode",=C2=A0 =C2=A0 =C2=A0 =C2=A0libxl_timer_mode),
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (= "nested_hvm",=C2=A0 =C2=A0 =C2=A0 =C2=A0libxl_defbool),
>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0("altp2m",=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0libxl_defbo= ol),
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0("altp2m",=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0libxl_altp2= m_mode),
>
>
> Should we move altp2m directly outside of the structure "hvm"= ; to avoid yet another change when altp2m will be supported on ARM? (see [1= ])
>
> Regards,
>
> [1] https://lists.xen.org/archives/html/xen-devel/2016-08/msg0014= 7.html
>
> --
> Julien Grall

Hi Julien,
We can do that here if preferred by the tools maintainers though I'm on= the opinion that it should be adjusted in the ARM altp2m series once it ac= tually becomes available there.

Tamas

--94eb2c14b102a512a00539e103af-- --===============7632494182439483241== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7632494182439483241==--