From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tamas K Lengyel <tamas.lengyel@zentific.com>
Subject: Re: [RFC PATCH V3 05/12] xen: Introduce vm_event
Date: Fri, 6 Feb 2015 15:01:08 +0100
Message-ID: <CAErYnsj4nDx3-X_5YCqO1OPEXOLP1hZVLaPq=-8tFNuKdCVVVA@mail.gmail.com>
References: <1422567998-29995-1-git-send-email-tamas.lengyel@zentific.com>
	<1422567998-29995-6-git-send-email-tamas.lengyel@zentific.com>
	<54D0FD39020000780005C792@mail.emea.novell.com>
	<CAErYnsg1e8QMv8ARe-fsrX4U=J2O9eeFk5D9Ny4xY3tyxRaAzg@mail.gmail.com>
	<54D4C883.70000@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54D4C883.70000@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>, "wei.liu2@citrix.com" <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Jun Nakajima <jun.nakajima@intel.com>, "Dong,
	Eddie" <eddie.dong@intel.com>, Tim Deegan <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Steven Maresca <steve@zentific.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Jan Beulich <JBeulich@suse.com>, "rshriram@cs.ubc.ca" <rshriram@cs.ubc.ca>, Keir Fraser <keir@xen.org>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, "yanghy@cn.fujitsu.com" <yanghy@cn.fujitsu.com>, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Feb 6, 2015 at 2:58 PM, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> On 06/02/15 13:54, Tamas K Lengyel wrote:
>>> Please clarify in the patch description whether this (and perhaps
>>> other) copied or cloned code is really just a plain copy with some
>>> renaming, or whether there are any other changes. Reviewing this
>>> as a non-renaming change isn't time well spent in the former case.
>> Ack, this code is identical to mem_event beside the name.
>
> Using git format-patch/diff -M will make this much more obvious by
> creating a diff which looks something like:
>
> --- a/xen/common/mem_event.c
> +++ b/xen/common/vm_event.c
>
> and contains hunks renaming the functions alone.
>
> ~Andrew

I'll take a look at that, it would certainly simplify things.

Tamas