From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tamas K Lengyel <tamas.lengyel@zentific.com>
Subject: Re: [PATCH for-4.5 v8 16/19] xen/arm: Instruction
 prefetch abort (X) mem_event handling
Date: Wed, 24 Sep 2014 19:04:12 +0200
Message-ID: <CAErYnsjZBg_JoX4bwh9N+qE5wdwDCmZCMn23YEYRUvRLDRf0Hg@mail.gmail.com>
References: <1411478070-13836-1-git-send-email-tklengyel@sec.in.tum.de>
	<1411478070-13836-17-git-send-email-tklengyel@sec.in.tum.de>
	<1411571121.28127.64.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6307634524727582261=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1411571121.28127.64.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@linaro.org>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Jan Beulich <jbeulich@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Tamas K Lengyel <tklengyel@sec.in.tum.de>
List-Id: xen-devel@lists.xenproject.org

--===============6307634524727582261==
Content-Type: multipart/alternative; boundary=001a11c3127e577f230503d2ac28

--001a11c3127e577f230503d2ac28
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Sep 24, 2014 at 5:05 PM, Ian Campbell <Ian.Campbell@citrix.com>
wrote:

> On Tue, 2014-09-23 at 15:14 +0200, Tamas K Lengyel wrote:
> > Add missing structure definition for iabt and update the trap handling
> > mechanism to only inject the exception if the mem_access checker
> > decides to do so.
> >
> > Signed-off-by: Tamas K Lengyel <tklengyel@sec.in.tum.de>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> > +        const struct npfec npfec = {
> > +            .insn_fetch = 1,
> > +            .gla_valid = 1,
> > +            .kind = iabt.s1ptw ? npfec_kind_in_gpt : npfec_kind_with_gla
>
> The references to "gla" here are just because the interface has been
> refactored out of x86 into common code, right?
>

Yes, that is correct. On ARM I've seen gvaddr and gva being used as the
lingo, gla refers to the same thing.

Tamas


>
> (if not and this is in fact an arm specific thing then please rename)
>
> Ian.
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>

--001a11c3127e577f230503d2ac28
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Wed, Sep 24, 2014 at 5:05 PM, Ian Campbell <span dir=3D"ltr">&lt;<a =
href=3D"mailto:Ian.Campbell@citrix.com" target=3D"_blank">Ian.Campbell@citr=
ix.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"=
margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=
=3D"">On Tue, 2014-09-23 at 15:14 +0200, Tamas K Lengyel wrote:<br>
&gt; Add missing structure definition for iabt and update the trap handling=
<br>
&gt; mechanism to only inject the exception if the mem_access checker<br>
&gt; decides to do so.<br>
&gt;<br>
&gt; Signed-off-by: Tamas K Lengyel &lt;<a href=3D"mailto:tklengyel@sec.in.=
tum.de">tklengyel@sec.in.tum.de</a>&gt;<br>
<br>
</span>Acked-by: Ian Campbell &lt;<a href=3D"mailto:ian.campbell@citrix.com=
">ian.campbell@citrix.com</a>&gt;<br>
<span class=3D""><br>
&gt; +=A0 =A0 =A0 =A0 const struct npfec npfec =3D {<br>
&gt; +=A0 =A0 =A0 =A0 =A0 =A0 .insn_fetch =3D 1,<br>
&gt; +=A0 =A0 =A0 =A0 =A0 =A0 .gla_valid =3D 1,<br>
&gt; +=A0 =A0 =A0 =A0 =A0 =A0 .kind =3D iabt.s1ptw ? npfec_kind_in_gpt : np=
fec_kind_with_gla<br>
<br>
</span>The references to &quot;gla&quot; here are just because the interfac=
e has been<br>
refactored out of x86 into common code, right?<br></blockquote><div><br></d=
iv><div>Yes, that is correct. On ARM I&#39;ve seen gvaddr and gva being use=
d as the lingo, gla refers to the same thing.<br><br></div><div>Tamas<br></=
div><div>=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .=
8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
(if not and this is in fact an arm specific thing then please rename)<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
Ian.<br>
</font></span><div class=3D"HOEnZb"><div class=3D"h5"><br>
<br>
_______________________________________________<br>
Xen-devel mailing list<br>
<a href=3D"mailto:Xen-devel@lists.xen.org">Xen-devel@lists.xen.org</a><br>
<a href=3D"http://lists.xen.org/xen-devel" target=3D"_blank">http://lists.x=
en.org/xen-devel</a><br>
</div></div></blockquote></div><br></div></div>

--001a11c3127e577f230503d2ac28--


--===============6307634524727582261==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============6307634524727582261==--